From unknown Sat Jun 21 03:11:36 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77501 <77501@debbugs.gnu.org> To: bug#77501 <77501@debbugs.gnu.org> Subject: Status: [PATCH] Restore logging of OpenSMTPd to /var/log/maillog. Reply-To: bug#77501 <77501@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:11:36 +0000 retitle 77501 [PATCH] Restore logging of OpenSMTPd to /var/log/maillog. reassign 77501 guix-patches submitter 77501 Felix Lechner severity 77501 normal tag 77501 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 14:06:29 2025 Received: (at submit) by debbugs.gnu.org; 3 Apr 2025 18:06:29 +0000 Received: from localhost ([127.0.0.1]:35602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0OxR-0001lq-0g for submit@debbugs.gnu.org; Thu, 03 Apr 2025 14:06:29 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34986) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0OxN-0001lU-W8 for submit@debbugs.gnu.org; Thu, 03 Apr 2025 14:06:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0OxC-0006Pa-Pe for guix-patches@gnu.org; Thu, 03 Apr 2025 14:06:14 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0Ox9-000736-G2 for guix-patches@gnu.org; Thu, 03 Apr 2025 14:06:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=LOLFOvfWoXPFqJT snEP0WwdbsMRGEIEjj9BYtt++pgU=; h=date:subject:cc:to:from; d=lease-up.com; b=Pp5UQYpeq0zoPsEEsbmWQ2o/aVj80bX6REFAoPp5nysU9C6grxm3 KsvnARdpfCAUgQ61zjh1O7NcDObkpmGsi9kq3KjW1H5g2ZTcrNaCBvGBak4W8q1DuBNeSj cNflk+wFvETmYWKos8Daxg/iDkyIulv5f9VG0DD5CsIgIFiWA= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 0f9da6e0 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 3 Apr 2025 18:06:04 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 429e596c; Thu, 3 Apr 2025 18:06:04 +0000 (UTC) From: Felix Lechner To: guix-patches@gnu.org Subject: [PATCH] Restore logging of OpenSMTPd to /var/log/maillog. Date: Thu, 3 Apr 2025 11:04:28 -0700 Message-ID: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=208.82.101.137; envelope-from=felix.lechner@us-core.com; helo=sail-ipv4.us-core.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Please see this thread for details: https://lists.gnu.org/archive/html/help-guix/2025-04/msg00009.html Change-Id: I485e040d680ccb39fa62e49d2e6ea916f047972c --- gnu/services/mail.scm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm index b9a61163d5..5a627dbbaf 100644 --- a/gnu/services/mail.scm +++ b/gnu/services/mail.scm @@ -1742,8 +1742,11 @@ (define (opensmtpd-shepherd-service config) (documentation "Run the OpenSMTPD daemon.") (start (let ((smtpd (file-append package "/sbin/smtpd"))) #~(make-forkexec-constructor - (list #$smtpd "-f" #$config-file) - #:pid-file "/var/run/smtpd.pid"))) + (list #$smtpd + "-d" + "-f" #$config-file) + #:pid-file "/var/run/smtpd.pid" + #:log-file "/var/log/maillog"))) (stop #~(make-kill-destructor)))))) (define %opensmtpd-accounts base-commit: 52ce48e754a77675da69e14d8f0dfa5fb76539ef -- 2.48.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 14:55:59 2025 Received: (at 77501) by debbugs.gnu.org; 3 Apr 2025 18:56:00 +0000 Received: from localhost ([127.0.0.1]:35719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0PjL-00049K-Ih for submit@debbugs.gnu.org; Thu, 03 Apr 2025 14:55:59 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:35474) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0PjJ-000494-Q3 for 77501@debbugs.gnu.org; Thu, 03 Apr 2025 14:55:58 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 12DC2600; Thu, 3 Apr 2025 20:55:51 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id t3QlaF8IMifh; Thu, 3 Apr 2025 20:55:50 +0200 (CEST) Received: from jurong (176-179-191-150.abo.bbox.fr [176.179.191.150]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C878B2A4; Thu, 3 Apr 2025 20:55:48 +0200 (CEST) Date: Thu, 3 Apr 2025 20:55:45 +0200 From: Andreas Enge To: Felix Lechner Subject: Re: OpenSMTP logging Message-ID: References: <875xjlpp3l.fsf@erlikon.ch> <87zfgxcdup.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87zfgxcdup.fsf@lease-up.com> X-Rspamd-Queue-Id: 12DC2600 X-Spamd-Result: default: False [-9.59 / 15.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM(-2.99)[-0.997]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[] X-Rspamd-Action: no action X-Spamd-Bar: --------- X-Rspamd-Server: hera X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: Gabriel Wicki , 77501@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Am Thu, Apr 03, 2025 at 11:13:50AM -0700 schrieb Felix Lechner via: > P.S. I linked to my Debbugs clone since Mumi did not pick it up. this was probably just a question of time; I can see it now on issues. > I can confirm that logging in OpenSMTPd is broken. I fixed it locally > with the patch in Bug#77501. [1] This looks good to me as someone who knows very little about services... I have looked at the shepherd manual, and in https://www.gnu.org/software/shepherd/manual/shepherd.html#Service-De_002d-and-Constructors it says the following about make-fork-exec-constructor: "Note: This will not work as expected if the process “daemonizes” (forks); in that case, you will need to pass #:pid-file, as explained below." Now that you do not daemonize, is #:pid-file still needed or useful? #:log-file "/var/log/maillog" And is this the good file name? Not mail.log? Andreas From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 15:39:54 2025 Received: (at 77501) by debbugs.gnu.org; 3 Apr 2025 19:39:54 +0000 Received: from localhost ([127.0.0.1]:35771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0QPq-00066p-AS for submit@debbugs.gnu.org; Thu, 03 Apr 2025 15:39:54 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:39176) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0QPm-00066f-I4 for 77501@debbugs.gnu.org; Thu, 03 Apr 2025 15:39:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=PqkDB1koEeY8B/Z q4lpW8Z1oD0NFl31EU/MKRLE5p4o=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=OI9rhbiBm05LTSDv8galo+LmXVoxaWpMnwVNXx8t Qxsy2wnszzVRoNfM/z1d2t7qpqINLlwEe8SGMCeAdyUGjmKxRSu3h2JbkE/Jprvr96qYlQ Fd5Zqo1fZ1ppHNSA3eKcDfwr8MdwSJ3x1BLjNkgOrCn2Ow7L5vr4uzFl43dlg= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 48291044 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 3 Apr 2025 19:39:46 +0000 (UTC) From: Felix Lechner To: Andreas Enge Subject: Re: OpenSMTP logging In-Reply-To: (Andreas Enge's message of "Thu, 3 Apr 2025 20:55:45 +0200") References: <875xjlpp3l.fsf@erlikon.ch> <87zfgxcdup.fsf@lease-up.com> User-Agent: mu4e 1.12.8; emacs 29.4 Date: Thu, 03 Apr 2025 12:39:46 -0700 Message-ID: <87tt75c9vh.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77501 Cc: Gabriel Wicki , 77501@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Andreas, On Thu, Apr 03 2025, Andreas Enge wrote: > This looks good to me Thanks for taking a look! > is #:pid-file still needed or useful? No, it isn't. It also occurred to me after I had sent in the patch, and moved onto something else. As a side note, I'm not sure we have the luxury of making such minor improvements. Guix is already a system with a thousand warts. My patch definitely makes Guix better. Either way, I'd be happy to remove it if we can reach an acceptance deal per below. > And is this the good file name? It isn't, but I think /var/log/maillog has a long tradition with Sendmail. The filename should actually be configurable, but I won't submit such a patch unless you promise to accept it. I already have a gazillion rebases because my patches, which I carry in my custom branch, are almost never accepted. Kind regards Felix From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 05:15:45 2025 Received: (at 77501) by debbugs.gnu.org; 8 Apr 2025 09:15:45 +0000 Received: from localhost ([127.0.0.1]:59055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u253Z-0008WG-08 for submit@debbugs.gnu.org; Tue, 08 Apr 2025 05:15:45 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:49660) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u253W-0008Vj-Bd for 77501@debbugs.gnu.org; Tue, 08 Apr 2025 05:15:43 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id A739551; Tue, 8 Apr 2025 11:15:35 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id 9CvBFFFyugCh; Tue, 8 Apr 2025 11:15:35 +0200 (CEST) Received: from jurong.lan (176-179-191-150.abo.bbox.fr [176.179.191.150]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 35B5F6E3; Tue, 8 Apr 2025 11:15:23 +0200 (CEST) From: Andreas Enge To: 77501@debbugs.gnu.org Subject: [PATCH] services: opensmtpd: Add logging to a file. Date: Tue, 8 Apr 2025 11:14:23 +0200 Message-ID: <2bd63e09a5664ecc3bb8fcee114e44db4e88bca6.1744103663.git.andreas@enge.fr> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: hera X-Rspamd-Queue-Id: A739551 X-Spamd-Result: default: False [-2.60 / 15.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM(-3.00)[-1.000]; FORGED_RECIPIENTS(2.00)[m:andreas@enge.fr,s:andreas.enge@aquilenet.fr]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[] X-Spamd-Bar: -- X-Rspamd-Action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: Andreas Enge , felix.lechner@lease-up.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From: Felix Lechner * gnu/services/mail.scm (opensmtpd-shepherd-service)[start]: Add a command line flag to not daemonize. Drop #:pid-file. Add #:log-file. Change-Id: I485e040d680ccb39fa62e49d2e6ea916f047972c Signed-off-by: Andreas Enge --- Hello, so just to be sure before I push, the patch below works for you? Andreas gnu/services/mail.scm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm index b9a61163d5..0d5af95986 100644 --- a/gnu/services/mail.scm +++ b/gnu/services/mail.scm @@ -1742,8 +1742,10 @@ (define (opensmtpd-shepherd-service config) (documentation "Run the OpenSMTPD daemon.") (start (let ((smtpd (file-append package "/sbin/smtpd"))) #~(make-forkexec-constructor - (list #$smtpd "-f" #$config-file) - #:pid-file "/var/run/smtpd.pid"))) + (list #$smtpd + "-d" + "-f" #$config-file) + #:log-file "/var/log/maillog"))) (stop #~(make-kill-destructor)))))) (define %opensmtpd-accounts base-commit: 43d30332bf3b4de0003578a7b5b27472b11183c7 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 14:30:34 2025 Received: (at 77501) by debbugs.gnu.org; 8 Apr 2025 18:30:35 +0000 Received: from localhost ([127.0.0.1]:35427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2DiU-0004PX-Dm for submit@debbugs.gnu.org; Tue, 08 Apr 2025 14:30:34 -0400 Received: from wolfsden.cz ([37.205.8.62]:41838) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1u2DiP-0004P8-J1 for 77501@debbugs.gnu.org; Tue, 08 Apr 2025 14:30:31 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 0482F390494; Tue, 8 Apr 2025 18:30:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1744137027; bh=v0DrdXW9GU1A+TgUqwTKMqbqlv8RR1kdi4q0SdxKgh4=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=jrsKkoo0yXHuySHUovywl6/FJ1ZxJdsKwt45mhvx8aayj5MsU8FaIXxp8BPiX1E8t NmWLKaOF4CD+IkpzN4N+etLoyEpNRb0f6ZSRBR/2fT7bt0qooiuwZkEYnmcfKYaJHl nua5EI7TjMzlOKqZC+1tP9XN8sdBb0jSUTr+XlWWW7+2xeAljmTgjZTKvTe/DMPcSz EkE24PbDVH4/RWVhhz8HblUAxisXt5CjlBAPqf3DLXMlR0eVQI/mk9XT/4/1Fe0c55 Gq8eWbp6Gznn4Xiwvo58LBZoBCssV/Qbk5L9mkYbfSgLpQnCrYImCSkBTnc+LzpZOY P5nfPyczRm81Hg9qZHH/40o8BMcaJYVhd0B3AyUQmay/oeYW+yMiLAZyPoM7+58MJ9 w4R7AjD7RSuw/x7SAxrVY/mYzJoTSYimQFzgzbNa3tzP7o61+TsxuurqHM3odMOZLp vP4c/GkB1kL8zWxkpYXlmavTuAa403DMdMOjFXP7Kt7ATgMin7GmDE/fxShDx2NQel jj0s6PTKFp7fCZ2zQwO+PYVbqEpb2YVGhHM9W4dBo446zxtMU5rMu017N7ErhY4G/v h2HwQkT9MY2o27hkYBjxAuzpyjqxXvBYv2T31dtXGrgGhcnao244jz82fhLhcHU+NB vNz5aA6KRifxYFmXmtBwuJ30= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 2D2AA39021B; Tue, 8 Apr 2025 18:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1744137026; bh=v0DrdXW9GU1A+TgUqwTKMqbqlv8RR1kdi4q0SdxKgh4=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=mdi8v5qGVb+2WfmdjjUyg8qAEznjC7viU+mDc9Rr/6StjJUZXn1rArU7epNsqSI7J +Z83abFZlpIXeLLRJc0IXu2gxSLTFpPvWOdaRsLcH03R3PnWCZDBWwV4cbFjEmhuvG D6Nx6TaWQT57S/6/QU101L0k7tAYBOPQL+A2zuTBr1J5mGW2UHEjq2b9AS+feN9mT/ rBs26PuIyiudgbjCYoQ4dAIdem6KkOf2+UtQ0D3AWU/Xu2WxJo2AKt4SFBW5mqosgG /VIBA4T1U+xNKKnf/OJ21HOqSOU2jiNzlBY/YB3Mvg5CK3mC2qZIrPVaftSNeDmH17 KdUZ/+FuKGzTx6l7vNpRBQNH96devaL3LuQpoFdoMTzD5nlibCschzAKELehJP2y37 gaPsYRoNWdeyPZCFZ2biOypyKx5HBc887Ygv+yaqzaXRLjF1J9nYdlt1VLrn9uPaqH +skji37ZsBduON5nYPO2uljKbx6z7g8nH8ttKMciHiI/DEqv5shiKHVo0mbI1uHtx3 vYZD0S3c0o3fg3NnyF+PHk3KIFHgVrH/TwaPhy38kCkJKWMLyrSFqhfBbiIanMVqt8 YS1ePnNHs2GymuGgdoARBFGdzT5Pp6iEg3ay47fuIx+z5H3wuX5KRuvBBLJctIy2Km qty0FTmhUy6lb9y6DbQvPyJo= From: Tomas Volf <~@wolfsden.cz> To: Andreas Enge Subject: Re: [bug#77501] [PATCH] services: opensmtpd: Add logging to a file. In-Reply-To: <2bd63e09a5664ecc3bb8fcee114e44db4e88bca6.1744103663.git.andreas@enge.fr> (Andreas Enge's message of "Tue, 8 Apr 2025 11:14:23 +0200") References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <2bd63e09a5664ecc3bb8fcee114e44db4e88bca6.1744103663.git.andreas@enge.fr> Date: Tue, 08 Apr 2025 20:30:26 +0200 Message-ID: <87ldsapku5.fsf@wolfsden.cz> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: 77501@debbugs.gnu.org, felix.lechner@lease-up.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andreas Enge writes: > diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm > index b9a61163d5..0d5af95986 100644 > --- a/gnu/services/mail.scm > +++ b/gnu/services/mail.scm > @@ -1742,8 +1742,10 @@ (define (opensmtpd-shepherd-service config) > (documentation "Run the OpenSMTPD daemon.") > (start (let ((smtpd (file-append package "/sbin/smtpd"))) > #~(make-forkexec-constructor > - (list #$smtpd "-f" #$config-file) > - #:pid-file "/var/run/smtpd.pid"))) > + (list #$smtpd > + "-d" > + "-f" #$config-file) > + #:log-file "/var/log/maillog"))) Probably out of scope but would be cool to have this configurable, I personally prefer /var/log/mail.log. I assume you have enough on your hands already, so will send a separate patch later. Tomas -- There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 14:41:44 2025 Received: (at 77501) by debbugs.gnu.org; 8 Apr 2025 18:41:44 +0000 Received: from localhost ([127.0.0.1]:35475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2DtH-0004yX-TA for submit@debbugs.gnu.org; Tue, 08 Apr 2025 14:41:44 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:55446) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2DtF-0004yC-2x for 77501@debbugs.gnu.org; Tue, 08 Apr 2025 14:41:41 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id E93AE2E2; Tue, 8 Apr 2025 20:41:33 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id Ii-jQAo-9Mzv; Tue, 8 Apr 2025 20:41:33 +0200 (CEST) Received: from jurong (176-179-191-150.abo.bbox.fr [176.179.191.150]) by hera.aquilenet.fr (Postfix) with ESMTPSA id A07CFEB; Tue, 8 Apr 2025 20:41:29 +0200 (CEST) Date: Tue, 8 Apr 2025 20:41:24 +0200 From: Andreas Enge To: Tomas Volf <~@wolfsden.cz> Subject: Re: [bug#77501] [PATCH] services: opensmtpd: Add logging to a file. Message-ID: References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <2bd63e09a5664ecc3bb8fcee114e44db4e88bca6.1744103663.git.andreas@enge.fr> <87ldsapku5.fsf@wolfsden.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ldsapku5.fsf@wolfsden.cz> X-Rspamd-Server: hera X-Spamd-Bar: +++++ X-Rspamd-Queue-Id: E93AE2E2 X-Spamd-Result: default: False [5.40 / 15.00]; SPAM_FLAG(5.00)[]; NEURAL_SPAM(3.00)[1.000]; BAYES_HAM(-3.00)[99.98%]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[] X-Spam-Level: ***** X-Rspamd-Action: greylist X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: 77501@debbugs.gnu.org, felix.lechner@lease-up.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Tue, Apr 08, 2025 at 08:30:26PM +0200 schrieb Tomas Volf: > Probably out of scope but would be cool to have this configurable, I > personally prefer /var/log/mail.log. I assume you have enough on your > hands already, so will send a separate patch later. Sounds good, thanks! You can already start the bikeshedding discussion about what the default value should be :) Andreas From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 14:52:42 2025 Received: (at 77501) by debbugs.gnu.org; 8 Apr 2025 18:52:42 +0000 Received: from localhost ([127.0.0.1]:35496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2E3u-0005Vq-5n for submit@debbugs.gnu.org; Tue, 08 Apr 2025 14:52:42 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:48386) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2E3q-0005Ve-Hw for 77501@debbugs.gnu.org; Tue, 08 Apr 2025 14:52:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=qQJfjKsN2xygNBW sdF0xAvcH8gpFLhmDtFJPlAbQvQs=; h=date:references:in-reply-to:subject: cc:to:from; d=lease-up.com; b=TFLXf+D/LV+oZtni6l0J96tuJEGgbs7+wqFVN0XE P8vY/qBEpli/z8lFcYiJR3Y9mBdc+3KNyYC371+PoGt39jAhj/w/SWhx9ZpgXuoEwRFUfq PVvnjCxhTieLFSdwnGEZOh2LNz0N6tUEH8jIB2WB91q1mr4D+ob5BPGKXj+1s= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id cb0bf6ac (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 8 Apr 2025 18:52:34 +0000 (UTC) From: Felix Lechner To: 77501@debbugs.gnu.org Subject: Re: [bug#77501] [PATCH] services: opensmtpd: Add logging to a file. In-Reply-To: (Andreas Enge's message of "Tue, 8 Apr 2025 20:41:24 +0200") References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <2bd63e09a5664ecc3bb8fcee114e44db4e88bca6.1744103663.git.andreas@enge.fr> <87ldsapku5.fsf@wolfsden.cz> User-Agent: mu4e 1.12.9; emacs 29.4 Date: Tue, 08 Apr 2025 11:52:34 -0700 Message-ID: <87v7relc3x.fsf@lease-up.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki , Andreas Enge X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Andreas & Tomas, On Tue, Apr 08 2025, Andreas Enge wrote: > You can already start the bikeshedding No bikeshedding needed! Given the emerging consensus, which includes a senior committer, I will happily prepare a patch that makes the name of the log file configurable. Like both of you, I also find mail.log more agreeable. Anyway, it's easy to change that default later, but it would be harder to change the name of the option, which is part of the API. Is "log-file" okay? Kind regards Felix From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 08 17:35:03 2025 Received: (at 77501) by debbugs.gnu.org; 8 Apr 2025 21:35:03 +0000 Received: from localhost ([127.0.0.1]:35837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2Gb1-0008Ip-9P for submit@debbugs.gnu.org; Tue, 08 Apr 2025 17:35:03 -0400 Received: from sail-ipv4.us-core.com ([208.82.101.137]:56888) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2Gax-0008II-RY for 77501@debbugs.gnu.org; Tue, 08 Apr 2025 17:35:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=2017; bh=/Ku3f9+u94K5pFF dYZ+vA5FgjJw6clPXF0ObsI3pM8o=; h=date:subject:cc:to:from; d=lease-up.com; b=j8maW/lQvIJtJgGcp9ivzxJVb0g1WLKF+cjj3+g3Ce1MTh9aKtvA 51i4vQfQphnM+rko4AyBCC9+MdL+0m8lCCZDCFlwoCiMjw0oE5Ytia3ZJ7KZu6VpQtwPw0 Tjf7TJdFmEUtxP08isxjh214zvuA3lfWsekeZsMU00CsBsLNU= Received: by sail-ipv4.us-core.com (OpenSMTPD) with ESMTPSA id 329400b9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 8 Apr 2025 21:34:55 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b0cc682a; Tue, 8 Apr 2025 21:34:54 +0000 (UTC) From: Felix Lechner To: 77501@debbugs.gnu.org Subject: [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) Date: Tue, 8 Apr 2025 14:32:27 -0700 Message-ID: X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 X-Debbugs-Cc: Ludovic Courtès , Maxim Cournoyer Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki , Andreas Enge , Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Please also see this thread: https://lists.gnu.org/archive/html/help-guix/2025-04/msg00009.html Change-Id: I485e040d680ccb39fa62e49d2e6ea916f047972c --- Hi, This was deployed briefly on production equipment and appears to work. Kind regards Felix doc/guix.texi | 4 ++++ gnu/services/mail.scm | 10 +++++++--- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index bee80cd4e2..c2640e5063 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -29219,6 +29219,10 @@ Mail Services users and daemons on the local machine, as well as permitting email to remote servers. Run @command{man smtpd.conf} for more information. +@item @code{log-file} (default: @code{"/var/log/mail.log"}) +The file location for the OpenSMTPD log file. Logging occurs in the +foreground via the Shepherd, i.e. OpenSMTPD does not detach. + @item @code{setgid-commands?} (default: @code{#t}) Make the following commands setgid to @code{smtpq} so they can be executed: @command{smtpctl}, @command{sendmail}, @command{send-mail}, diff --git a/gnu/services/mail.scm b/gnu/services/mail.scm index ee61887369..cf23f76bc7 100644 --- a/gnu/services/mail.scm +++ b/gnu/services/mail.scm @@ -1719,6 +1719,8 @@ (define-record-type* (default '())) ; list of symbols (config-file opensmtpd-configuration-config-file (default %default-opensmtpd-config-file)) + (log-file opensmtpd-configuration-log-file + (default "/var/log/mail.log")) (setgid-commands? opensmtpd-setgid-commands? (default #t))) (define %default-opensmtpd-config-file @@ -1734,15 +1736,17 @@ (define %default-opensmtpd-config-file (define (opensmtpd-shepherd-service config) (match-record config - (package config-file shepherd-requirement) + (package config-file log-file shepherd-requirement) (list (shepherd-service (provision '(smtpd)) (requirement `(pam loopback ,@shepherd-requirement)) (documentation "Run the OpenSMTPD daemon.") (start (let ((smtpd (file-append package "/sbin/smtpd"))) #~(make-forkexec-constructor - (list #$smtpd "-f" #$config-file) - #:pid-file "/var/run/smtpd.pid"))) + (list #$smtpd + "-d" + "-f" #$config-file) + #:log-file #$log-file))) (stop #~(make-kill-destructor)))))) (define %opensmtpd-accounts base-commit: c88f98bb3ca2616baea6b1e452cc900cc9c87503 -- 2.49.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 09 17:23:12 2025 Received: (at 77501) by debbugs.gnu.org; 9 Apr 2025 21:23:12 +0000 Received: from localhost ([127.0.0.1]:42417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2ct6-0001Xj-Ah for submit@debbugs.gnu.org; Wed, 09 Apr 2025 17:23:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55862) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2ct4-0001XV-Pf for 77501@debbugs.gnu.org; Wed, 09 Apr 2025 17:23:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2csx-0007NQ-EJ; Wed, 09 Apr 2025 17:23:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=fXPcSMq0kYqmd1ShcEFr0hRWohM/PVvoksrL7LHiqIU=; b=rsM1mI7V5gwWvQisLDRy MFcW0nPzlrbaaB5thS6APW5dfw+57rqhuB/UWaXO67mG+ZBkXuXm4KLgPrESjEBvtkQTDB1mKcVHf /nuQLuLw9fpGfwiGrbqo6kxm11mMc4i19zAJlnzbfHtTWfvUiwIWk6FT9klOLA/Qafzvq7VkQ3Eyr bp00Nv4MNBEtNzM/3Mtq8j3ZyxmSAk95k+OBe0STReWm2GYOWw2rp+NVSBNJ03rOCk5v3/w3smIpu FgFjIE36NlhM2Qx3gk+2CNwxhToxukw3T7a2uNyEP3ndSRCOVBrluSU+/j/euYX0GF9gpJTA3MWSc dzcvy8to39rFjw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Felix Lechner Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) In-Reply-To: (Felix Lechner's message of "Tue, 8 Apr 2025 14:32:27 -0700") References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> User-Agent: mu4e 1.12.9; emacs 29.4 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: =?utf-8?Q?D=C3=A9cadi?= 20 Germinal an 233 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la Ruche Date: Wed, 09 Apr 2025 23:22:58 +0200 Message-ID: <87lds9xc5p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki , Maxim Cournoyer , 77501@debbugs.gnu.org, Andreas Enge X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Felix Lechner skribis: > Please also see this thread: > > https://lists.gnu.org/archive/html/help-guix/2025-04/msg00009.html > > Change-Id: I485e040d680ccb39fa62e49d2e6ea916f047972c Could you add a conventional commit log? [...] > #~(make-forkexec-constructor > - (list #$smtpd "-f" #$config-file) > - #:pid-file "/var/run/smtpd.pid"))) > + (list #$smtpd > + "-d" > + "-f" #$config-file) > + #:log-file #$log-file))) I believe #:pid-file should be kept, no? I would also keep the (list =E2=80=A6) bit on a single line. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 09 17:58:34 2025 Received: (at 77501) by debbugs.gnu.org; 9 Apr 2025 21:58:34 +0000 Received: from localhost ([127.0.0.1]:42589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2dRK-0003Sc-59 for submit@debbugs.gnu.org; Wed, 09 Apr 2025 17:58:34 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:35716) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2dRH-0003SG-UO for 77501@debbugs.gnu.org; Wed, 09 Apr 2025 17:58:32 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 85C4468B; Wed, 9 Apr 2025 23:58:25 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id XrX_O9YHA8xV; Wed, 9 Apr 2025 23:58:25 +0200 (CEST) Received: from jurong (176-179-191-150.abo.bbox.fr [176.179.191.150]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 655997E; Wed, 9 Apr 2025 23:58:24 +0200 (CEST) Date: Wed, 9 Apr 2025 23:58:22 +0200 From: Andreas Enge To: Ludovic =?iso-8859-15?Q?Court=E8s?= Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) Message-ID: References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <87lds9xc5p.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87lds9xc5p.fsf@gnu.org> X-Rspamd-Server: hera X-Spamd-Bar: ++ X-Rspamd-Queue-Id: 85C4468B X-Spamd-Result: default: False [2.90 / 15.00]; SPAM_FLAG(5.00)[]; REPLY(-4.00)[]; SUSPICIOUS_RECIPS(1.50)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[lease-up.com, debbugs.gnu.org, wolfsden.cz, erlikon.ch, gmail.com] X-Spam-Level: ** X-Rspamd-Action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki , Maxim Cournoyer , 77501@debbugs.gnu.org, Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Wed, Apr 09, 2025 at 11:22:58PM +0200 schrieb Ludovic Courtès: > Could you add a conventional commit log? This was there in my version of the patch a bit further up. > > #~(make-forkexec-constructor > > - (list #$smtpd "-f" #$config-file) > > - #:pid-file "/var/run/smtpd.pid"))) > > + (list #$smtpd > > + "-d" > > + "-f" #$config-file) > > + #:log-file #$log-file))) > I believe #:pid-file should be kept, no? This was dropped following my remark above: "I have looked at the shepherd manual, and in https://www.gnu.org/software/shepherd/manual/shepherd.html#Service-De_002d-and-Constructors it says the following about make-fork-exec-constructor: 'Note: This will not work as expected if the process “daemonizes” (forks); in that case, you will need to pass #:pid-file, as explained below.' Now that you do not daemonize, is #:pid-file still needed or useful?" The "-d" flag passed to #$smtpd prevents it from "daemonizing". So we concluded that the #:pid-file thing was not needed (maybe it is needed, but then the documentation should be adapted). Andreas From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 10 08:35:50 2025 Received: (at 77501) by debbugs.gnu.org; 10 Apr 2025 12:35:50 +0000 Received: from localhost ([127.0.0.1]:44275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2r8I-00027Y-Gc for submit@debbugs.gnu.org; Thu, 10 Apr 2025 08:35:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50252) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2r8D-000274-3d for 77501@debbugs.gnu.org; Thu, 10 Apr 2025 08:35:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2r85-0001tO-51; Thu, 10 Apr 2025 08:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=8VefqSPDe0GiYJlfcN7oZpQ13Py2i19+6P15bNDQ37I=; b=kxblE6Tic8KXgvvyu4H9 VCeeOttU6wWDjvqP+pB8ulYlY47wLQEjjoCeLxDrXRG7i1+j8OlxEbjtZDhDEZYu9NsRwXLzbpdOo KmPa7ZvyaCAGbhbQqxVCwRkWkwx0damT2stdFuhifitwKsa+if9lJFCFICEA3QrBpgyDzxkRTkPQG Ef7c629v/sehl0qtKBxQTeQgWx1MqI4LdODrjbQa3Uv5JHFghuxVT8gsv5HNGXkkGik63Id1bSUDI VZEJl7h5fYy1KalXT9zYuK8wmXg0BuX4Hec1w71Aj5qou+5TLgRYp4z2n4/9L9Xb3VhT6+Q71lNhi FcgIZ8UeN4gfrg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Andreas Enge Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) In-Reply-To: (Andreas Enge's message of "Wed, 9 Apr 2025 23:58:22 +0200") References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <87lds9xc5p.fsf@gnu.org> User-Agent: mu4e 1.12.9; emacs 29.4 X-URL: https://people.bordeaux.inria.fr/lcourtes/ X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu X-Revolutionary-Date: Primidi 21 Germinal an 233 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour du Gainier Date: Thu, 10 Apr 2025 12:24:24 +0200 Message-ID: <87v7rctiuf.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki , Maxim Cournoyer , 77501@debbugs.gnu.org, Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Andreas Enge skribis: > The "-d" flag passed to #$smtpd prevents it from "daemonizing". So we > concluded that the #:pid-file thing was not needed (maybe it is needed, > but then the documentation should be adapted). Oh I see, understood. Thanks for explaining! Ludo'. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 10 09:42:05 2025 Received: (at 77501-done) by debbugs.gnu.org; 10 Apr 2025 13:42:05 +0000 Received: from localhost ([127.0.0.1]:44499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u2sAO-00061m-RT for submit@debbugs.gnu.org; Thu, 10 Apr 2025 09:42:05 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:39822) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u2sAL-000618-VF for 77501-done@debbugs.gnu.org; Thu, 10 Apr 2025 09:42:02 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C4E64176; Thu, 10 Apr 2025 15:41:55 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id DWTUBUlBWM5r; Thu, 10 Apr 2025 15:41:55 +0200 (CEST) Received: from jurong (176-179-191-150.abo.bbox.fr [176.179.191.150]) by hera.aquilenet.fr (Postfix) with ESMTPSA id A396087; Thu, 10 Apr 2025 15:41:54 +0200 (CEST) Date: Thu, 10 Apr 2025 15:41:52 +0200 From: Andreas Enge To: Ludovic =?iso-8859-15?Q?Court=E8s?= Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) Message-ID: References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <87lds9xc5p.fsf@gnu.org> <87v7rctiuf.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v7rctiuf.fsf@gnu.org> X-Rspamd-Server: hera X-Spamd-Bar: ++ X-Rspamd-Queue-Id: C4E64176 X-Spamd-Result: default: False [2.90 / 15.00]; SPAM_FLAG(5.00)[]; REPLY(-4.00)[]; SUSPICIOUS_RECIPS(1.50)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TAGGED_RCPT(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; FREEMAIL_CC(0.00)[lease-up.com, debbugs.gnu.org, wolfsden.cz, erlikon.ch, gmail.com] X-Spam-Level: ** X-Rspamd-Action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501-done Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki , Maxim Cournoyer , Felix Lechner , 77501-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I have added a commit message and a copyright header, turned the list into one line and pushed. Thanks to all! Andreas From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 13 20:53:23 2025 Received: (at 77501) by debbugs.gnu.org; 14 Apr 2025 00:53:23 +0000 Received: from localhost ([127.0.0.1]:44643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u484g-0006fo-Vd for submit@debbugs.gnu.org; Sun, 13 Apr 2025 20:53:23 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]:48153) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u484e-0006fV-VM for 77501@debbugs.gnu.org; Sun, 13 Apr 2025 20:53:21 -0400 Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-af91fc1fa90so3459001a12.0 for <77501@debbugs.gnu.org>; Sun, 13 Apr 2025 17:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744591995; x=1745196795; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LpLwozBcBGecgmaqQYkLyuGoWCQD1ZNO7XXGFDrMsFo=; b=JMtFa6u1yBFymLWPFiF4fN/4sJHBbaCqUOADKe4JFAGQ29V5keJuw978Q7ZF7l6Rva Sq2fKFQSSi7WwyizFJUAQNkNjuvIayptE+Cw5F14V6sA2NFvSdOqXCYbtcwOxynVwTVl 7lCpHsWR9udLdg9OIR7S32MDYzxok9gRvpPRZKi8VYGdHVBf3J9w7kXoECxNuolY8ZGt q39rCCBQerYieWiVZy5+OIlv1OZZcNau/hVn+o5OXsT5Inj7fTPZ8NfaGLBC/RYOXyQ6 p9FLiZPcJlYNfmo6g/Xk5+anMsbtaDaqaFlo9ni100bvyE0WNF19i+aACTfvI02BVZFv uzYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744591995; x=1745196795; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LpLwozBcBGecgmaqQYkLyuGoWCQD1ZNO7XXGFDrMsFo=; b=ZhF8tzEWslVxNencGPwCnGgxBMoXqig/SEU8IKWKxdnm/9bP9fh73cmpZAZyFM6q3a h0VUu3yG61ruzubQfZH6Nb9t+WOEuIUEutVcF6SSPFPLO5kFXt4audAGv39ElSxLCptj tBkDOd4gmQIh/8X3bFrQj+fh+MaqEsddiwHNHYe9GL/+oNzmNRWU76nbrZyslhXvDGyZ UpFrS3Ia1raEO8icrLUNo7NDNG3+1LcEGcTEU5FycVXvbz0DGuEXPbhDC4L/o4hq8vIW Mj1xwifHAU7QRzKP1wVYbs3wzJZ+KnK/wZgTXOqSxJ8uTaP0noSN5fh85nsrBpzsyC4K s9uw== X-Forwarded-Encrypted: i=1; AJvYcCWsejl4b9etMMmriMtlvfzn2rdUEDBVS2TdeH15tGjGl2IgBbTWsNqbsoX6IoltxY3PVSH5Jw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw39usQOqOZ88tZH0JQd5j02pcViFHsD0NUNVbs3dNZOpFYqn71 q0w6uUWCRcafrnqDL5D+dpnfj6/uH21npcTo4MJhYxomhrbWvKYzYrxnvw== X-Gm-Gg: ASbGncu4FwzcgQCld34pHUnzUkCayfdG7xu1XDt97mt+KjZEb1l1REVBXAnUurY5MbY XjwgRkVkw0Hf59elon6bJIxRx2qgkbs8OKDu6LzOrn9Pify2dhP88orG5wafXvFMZALeE7V+ArX FKVbmhbKgzzrq1HL5WsRZR/1nN8v747mZddtrSpyjr1UGEOW7kTToEtfxZH0s2tQs7hgsNeVLpY VT78BSJd6qP1Gfv7Z2kDQ3f35LPYAVJslD/BmRif0ZqmEWGviUWS10GWqP7xFNzco4WwMj4fKup dtyGB6Quml7GjFptvXAJmwMSJ3JcyIfAKXtLAc8= X-Google-Smtp-Source: AGHT+IGIyDLOAKIfRXcP72hZj/Oh00FDk1IiZ6jGX7OcR839YMXRqSF4z+/scFZTeDB3f1manPlnFA== X-Received: by 2002:a17:902:d4cf:b0:220:d078:eb33 with SMTP id d9443c01a7336-22bea4eefc6mr137392295ad.36.1744591994490; Sun, 13 Apr 2025 17:53:14 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-22ac7cb5311sm88223025ad.169.2025.04.13.17.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Apr 2025 17:53:13 -0700 (PDT) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) In-Reply-To: <87v7rctiuf.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 10 Apr 2025 12:24:24 +0200") References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <87lds9xc5p.fsf@gnu.org> <87v7rctiuf.fsf@gnu.org> Date: Mon, 14 Apr 2025 09:52:53 +0900 Message-ID: <87ikn7wom2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Andreas Enge , Gabriel Wicki , 77501@debbugs.gnu.org, Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Andreas, Ludovic Court=C3=A8s writes: > Andreas Enge skribis: > >> The "-d" flag passed to #$smtpd prevents it from "daemonizing". So we >> concluded that the #:pid-file thing was not needed (maybe it is needed, >> but then the documentation should be adapted). >From my understanding, a pid file is still useful for *synchronization* reasons, whether the service daemonizes or not. It's a token that lets the service notify the init system that "OK, I've done my basic startup, I'm ready to receive client requests". That's been progressively replaced by socket activation in the systemd world (and we support that via make-systemd-constructor, though I've found some issue with it when using TLS connections -- to be reported separately). --=20 Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 14 03:58:40 2025 Received: (at 77501) by debbugs.gnu.org; 14 Apr 2025 07:58:40 +0000 Received: from localhost ([127.0.0.1]:45582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4EiG-0001ZS-FY for submit@debbugs.gnu.org; Mon, 14 Apr 2025 03:58:40 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:40378) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4EiD-0001ZC-MD for 77501@debbugs.gnu.org; Mon, 14 Apr 2025 03:58:38 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 9FA78127; Mon, 14 Apr 2025 09:58:30 +0200 (CEST) Authentication-Results: hera.aquilenet.fr; none X-Virus-Scanned: Debian amavis at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavis, port 10024) with ESMTP id NPbsp_C2yONt; Mon, 14 Apr 2025 09:58:30 +0200 (CEST) Received: from jurong (176-179-191-150.abo.bbox.fr [176.179.191.150]) by hera.aquilenet.fr (Postfix) with ESMTPSA id E1A19A8; Mon, 14 Apr 2025 09:58:27 +0200 (CEST) Date: Mon, 14 Apr 2025 09:58:26 +0200 From: Andreas Enge To: Maxim Cournoyer Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) Message-ID: References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <87lds9xc5p.fsf@gnu.org> <87v7rctiuf.fsf@gnu.org> <87ikn7wom2.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ikn7wom2.fsf@gmail.com> X-Rspamd-Queue-Id: 9FA78127 X-Spamd-Result: default: False [6.90 / 15.00]; SPAM_FLAG(5.00)[]; NEURAL_SPAM(3.00)[1.000]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TAGGED_RCPT(0.00)[]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[] X-Spamd-Bar: ++++++ X-Rspamd-Action: add header X-Rspamd-Server: hera X-Spam-Level: ****** X-Spam: Yes X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Ludovic =?iso-8859-15?Q?Court=E8s?= , Gabriel Wicki , 77501@debbugs.gnu.org, Felix Lechner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Maxim, Am Mon, Apr 14, 2025 at 09:52:53AM +0900 schrieb Maxim Cournoyer: > From my understanding, a pid file is still useful for *synchronization* > reasons, whether the service daemonizes or not. It's a token that lets > the service notify the init system that "OK, I've done my basic startup, > I'm ready to receive client requests". would you like to update the documentation and re-add the pid file for this service here? Andreas From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 22 03:32:43 2025 Received: (at 77501) by debbugs.gnu.org; 22 Apr 2025 07:32:43 +0000 Received: from localhost ([127.0.0.1]:44572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u787U-0006zx-Id for submit@debbugs.gnu.org; Tue, 22 Apr 2025 03:32:42 -0400 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:43256) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u787Q-0006zQ-FV for 77501@debbugs.gnu.org; Tue, 22 Apr 2025 03:32:38 -0400 Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-736dd9c4b40so5053176b3a.0 for <77501@debbugs.gnu.org>; Tue, 22 Apr 2025 00:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745307150; x=1745911950; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kyVR4KRLmLyz8oh2rjuz3UnVLBjcDtJnuKGKUE6y1q8=; b=JYHnUBUsxBYE36CGJK73JKwTb/V23Rohjl1Bm7sgLUB+JcdIs1SJqCkUqQOxl1und3 zGc5Z/cPhWYBGAlUe23V1lcw7wIED+mhQc9ArJPPhFDROJPOFDwH1OvitMCgTivZ7GK1 MXcViuwL651dNWQU/5BqM0hvqo735uX6j4VVluiBgVeqGoX8ZbIs2HtBSuEb5RG58u// e0bSio8JL9RB5hnCUraaUTSX7qRNl5n8/bIFrj4bvXMivwqIeVIGDZQUSAopLKQm08yc NIb8W9vSoPCKT9WdfzAhsWpFfbB/iostQ/LHa7s+k1nOF+M33IfTJu+QE5UVy7gNUa7h bwYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745307150; x=1745911950; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kyVR4KRLmLyz8oh2rjuz3UnVLBjcDtJnuKGKUE6y1q8=; b=KJUaZX5F2TPX7IP/slL6bZKNP/jf2pUpkUZW6s9dAJa8WX913+/OcVkL3hbY66lpOl DklSptRHQKHjYvGfLq0TXvBUq2U2efuqyXw5yYfCrA8r0WZOQTLtNifx1leb3b+LomzO jyv/LhPqhEInMP3uCF4/pnI8mAKUr5/SDWSTuZ1G9ggWuZcbgX1da3pkrRvSD8o/ZuJl AvS8fGm3Tjm+JVQFgdMzmFq2Pl/CCna8j2ICY8Q9F5Hq7lyqLO1nB6ggTRqsrVkDyiFp c7YRxMBrlaKf50cu2/zxNbWbe+z20HWyY5Pw/Gnvhz3C7arfwR5yiJzF+RgDvBM3yp+E DE7g== X-Forwarded-Encrypted: i=1; AJvYcCVGeuTqRCb9q6qrzkGsYb6mQhiMBUapfJ7hLI+JYtwek5MvMmUZl41EKIXdg71QYrBcB+sARQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyQ4NR2UiNyPqqZePxSu3rUbd7TL8dWzQmztYPrbFf85y9Zzc51 VfBwLu/6GwSoA5KqJXynbdOQ+ACUXxIZnWAf8GS9JO3ZDJvgwCxh X-Gm-Gg: ASbGncsGpJm99ZXAfCILu5C15RAVhN0ybdFQWyToZkCwBfPQvOnyF3QAXQjZw8QQD7+ z/5uRQEx7Mj6gdxnfaiXN4o8zEvABbmbEQFQn6CinIQAXt+NG/zPkITovVCS5WTQhEAqb6SybcA yv3NsO2J6kBpPTtYGXXvDUMlOsNe7B5Re0Ajo+lDRStKchhIbYtKNcjHtrsW/fGJQvhNvIfWRnA L9gy93xaBz8FKSxvN+rCPDfOz41xsH4NjC4X+iB0MEnl2ZXLFhW5Y63RO83YxxssXeOBdujHjIc pLnc0xB6qf+2bdoyq/q4OY/TJJHyXEwklm11WzmgWOoVWw84rg== X-Google-Smtp-Source: AGHT+IHdnKbuu7BEVc7A8H/LyuXqe/e9UtbGPMXUMhL2dqychstA42dcMU5GBO8EKUatG0suILCDMw== X-Received: by 2002:a05:6a21:3297:b0:201:8a06:6e3b with SMTP id adf61e73a8af0-203cc6095a5mr20263951637.9.1745307150072; Tue, 22 Apr 2025 00:32:30 -0700 (PDT) Received: from terra ([2405:6586:be0:0:83c8:d31d:2cec:f542]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b0db14588dfsm6658098a12.52.2025.04.22.00.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Apr 2025 00:32:29 -0700 (PDT) From: Maxim Cournoyer To: Andreas Enge Subject: Re: [bug#77501] [PATCH] Log OpenSMTPd to /var/log/mail.log via a configurable option. (Closes: #77501) In-Reply-To: (Andreas Enge's message of "Mon, 14 Apr 2025 09:58:26 +0200") References: <8f60a2b7cd79da8cf4853affbdb2db4e7394c68c.1743703468.git.felix.lechner@lease-up.com> <87lds9xc5p.fsf@gnu.org> <87v7rctiuf.fsf@gnu.org> <87ikn7wom2.fsf@gmail.com> Date: Tue, 22 Apr 2025 16:32:25 +0900 Message-ID: <87plh4k5x2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77501 Cc: Tomas Volf <~@wolfsden.cz>, Gabriel Wicki , Ludovic =?utf-8?Q?Court=C3=A8s?= , Felix Lechner , 77501@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Andreas, Andreas Enge writes: > Hello Maxim, > > Am Mon, Apr 14, 2025 at 09:52:53AM +0900 schrieb Maxim Cournoyer: >> From my understanding, a pid file is still useful for *synchronization* >> reasons, whether the service daemonizes or not. It's a token that lets >> the service notify the init system that "OK, I've done my basic startup, >> I'm ready to receive client requests". > > would you like to update the documentation and re-add the pid file > for this service here? Let's wait and see if a problem come up. Typically that'd happen if something requires opensmtpd as a shepherd-requirement, I'm not sure anyone is using that yet. -- Thanks, Maxim From unknown Sat Jun 21 03:11:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 20 May 2025 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator