GNU bug report logs - #77483
[PATCH] gnu: emacs-ghub: Update to 4.3.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77483 in the body.
You can then email your comments to 77483 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: guix-patches <at> gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH] gnu: emacs-ghub: Update to 4.3.0.
Date: Thu,  3 Apr 2025 12:13:05 +0200

* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 4.3.0.

Change-Id: I5aed2f53f9de8b116148b69cf572a75135be7cab
---
 gnu/packages/emacs-xyz.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e30989cb1e..827b8344ff 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2721,7 +2721,7 @@ (define-public emacs-ghq
 (define-public emacs-ghub
   (package
     (name "emacs-ghub")
-    (version "4.2.2")
+    (version "4.3.0")
     (source
      (origin
        (method git-fetch)
@@ -2730,7 +2730,7 @@ (define-public emacs-ghub
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1bd8lnhv50brfxqwyk7jmgrig0cahkam7ggwaifaz8vb8m456yar"))))
+        (base32 "00xc8957j700zfjcazbp2mcwk6gj8jyrw017864sw47j50p83wy7"))))
     (build-system emacs-build-system)
     (arguments
      (list
@@ -2756,7 +2756,6 @@ (define-public emacs-ghub
      (list texinfo))
     (propagated-inputs
      (list emacs-compat
-           emacs-dash
            emacs-llama
            emacs-let-alist
            emacs-treepy))

base-commit: 6f53abfdab78e45530d0d9ca3b789482c052c6a7
-- 
2.49.0

Message #8 received at 77483 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77483 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v2] gnu: emacs-ghub: Update to 4.3.0.
Date: Thu,  3 Apr 2025 13:47:54 +0200

* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 4.3.0.

Change-Id: I5aed2f53f9de8b116148b69cf572a75135be7cab
---
 gnu/packages/emacs-xyz.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e30989cb1e..16f1e4bda1 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2721,7 +2721,7 @@ (define-public emacs-ghq
 (define-public emacs-ghub
   (package
     (name "emacs-ghub")
-    (version "4.2.2")
+    (version "4.3.0")
     (source
      (origin
        (method git-fetch)
@@ -2730,10 +2730,11 @@ (define-public emacs-ghub
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1bd8lnhv50brfxqwyk7jmgrig0cahkam7ggwaifaz8vb8m456yar"))))
+        (base32 "00xc8957j700zfjcazbp2mcwk6gj8jyrw017864sw47j50p83wy7"))))
     (build-system emacs-build-system)
     (arguments
      (list
+      #:tests? #f ; there are no tests
       #:phases
       #~(modify-phases %standard-phases
           (add-before 'install 'make-info
@@ -2756,7 +2757,6 @@ (define-public emacs-ghub
      (list texinfo))
     (propagated-inputs
      (list emacs-compat
-           emacs-dash
            emacs-llama
            emacs-let-alist
            emacs-treepy))

base-commit: 6f53abfdab78e45530d0d9ca3b789482c052c6a7
-- 
2.49.0

Message #11 received at 77483 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 77483 <at> debbugs.gnu.org
Cc: Cayetano Santos <csantosb <at> inventati.org>
Subject: [PATCH v3] gnu: emacs-ghub: Update to 4.3.0.
Date: Thu,  3 Apr 2025 14:15:09 +0200

* gnu/packages/emacs-xyz.scm (emacs-ghub): Update to 4.3.0.

Change-Id: I5aed2f53f9de8b116148b69cf572a75135be7cab
---

Let's mimic packaging of emacs-forge, with same directory structure.

 gnu/packages/emacs-xyz.scm | 27 ++++++++++-----------------
 1 file changed, 10 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e30989cb1e..dd00d3975d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -2721,7 +2721,7 @@ (define-public emacs-ghq
 (define-public emacs-ghub
   (package
     (name "emacs-ghub")
-    (version "4.2.2")
+    (version "4.3.0")
     (source
      (origin
        (method git-fetch)
@@ -2730,33 +2730,26 @@ (define-public emacs-ghub
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1bd8lnhv50brfxqwyk7jmgrig0cahkam7ggwaifaz8vb8m456yar"))))
+        (base32 "00xc8957j700zfjcazbp2mcwk6gj8jyrw017864sw47j50p83wy7"))))
     (build-system emacs-build-system)
     (arguments
      (list
+      #:tests? #f ; there are no tests
       #:phases
       #~(modify-phases %standard-phases
-          (add-before 'install 'make-info
-            (lambda _
-              (invoke "make" "info")))
-          (add-after 'make-info 'enter-lisp-directory
-            (lambda _
-              (chdir "lisp")))
-          (add-after 'expand-load-path 'add-el-dir-to-emacs-load-path
+          (add-after 'unpack 'build-info-manual
             (lambda _
-              (setenv "EMACSLOADPATH"
-                      (string-append (getcwd)
-                                     "/lisp:"
-                                     (getenv "EMACSLOADPATH")))))
-          (add-after 'install 'install-info
+              (invoke "make" "info")
+              ;; Move the info file to lisp so that it gets installed by the
+              ;; emacs-build-system.
+              (rename-file "docs/ghub.info" "lisp/ghub.info")))
+          (add-after 'build-info-manual 'chdir-lisp
             (lambda _
-              (let ((info (string-append #$output "/share/info")))
-                (install-file "../docs/ghub.info" info)))))))
+              (chdir "lisp"))))))
     (native-inputs
      (list texinfo))
     (propagated-inputs
      (list emacs-compat
-           emacs-dash
            emacs-llama
            emacs-let-alist
            emacs-treepy))

base-commit: c6d27c20f4685a9ac1299974f6ace42ae29f474d
--
2.49.0

Message #14 received at 77483 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 77483 <at> debbugs.gnu.org
Subject: Re: [bug#77483] [PATCH v3] gnu: emacs-ghub: Update to 4.3.0.
Date: Sat, 05 Apr 2025 12:07:37 -0700

Hi Cayetano,

Pushed as 01ddd47a0b.

Thanks,
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.