GNU bug report logs - #77468
30.1.50; package-quickstart file is not relocatable

Previous Next

Full log

Message #41 received at 77468 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 77468 <at> debbugs.gnu.org
Subject: Re: bug#77468: 30.1.50; package-quickstart file is not relocatable
Date: Mon, 07 Apr 2025 13:29:54 -0400

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>> I guess file-name-directory can be slow due to find-file-name-handler...
>> that's sad since it's otherwise just a trivial string operation.
>
> It's not a major performance issue, but I can't think of a reason why we
> wouldn't want to make this trivial optimization.

Agree, agreed.  Just thinking about whether there's possibilities for
further optimization (like, do we really need to have non-nil
find-file-name-handler in the quickstart?).

>> I guess I could wrap the entire file in a let binding, but that's mildly
>> annoying and ugly...
>
> We can just `setq` a private global var.  It's conceptually
> ugly, but it gets the job done.  As long as we support only a single
> global `package-quickstart.el` that should be good enough.

I guess you prefer this to the approach in the patch I sent, where I
let-bind default-directory outside the load of package-quickstart-file?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.