From unknown Tue Jun 24 15:40:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail Resent-From: Mark Lillibridge Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Dec 2010 00:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 7746@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Reply-To: mark.lillibridge@hp.com Received: via spool by submit@debbugs.gnu.org id=B.129349504328151 (code B ref -1); Tue, 28 Dec 2010 00:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 28 Dec 2010 00:10:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXN9G-0007K0-9Z for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:10:42 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXN9E-0007Jm-Ny for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:10:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXNFo-0002Zl-NR for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:17:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:38286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXNFo-0002Zh-LH for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:17:28 -0500 Received: from [140.186.70.92] (port=34882 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXNFn-0003Dn-J7 for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 19:17:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXNFm-0002ZQ-Hv for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 19:17:27 -0500 Received: from gundega.hpl.hp.com ([192.6.19.190]:32823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXNFm-0002ZL-8K for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 19:17:26 -0500 Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by gundega.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id oBS0HMDG010294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 27 Dec 2010 16:17:22 -0800 Received: from ts-rhel5 (ts-rhel5.hpl.hp.com [15.25.118.27]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id oBS0HKSJ006087; Mon, 27 Dec 2010 16:17:20 -0800 Date: Mon, 27 Dec 2010 16:17:20 -0800 Message-Id: From: Mark Lillibridge X-Scanned-By: MIMEDefang 2.69 on 15.0.48.190 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) mail-strip-quoted-names in mail/mail-utils.el (at least version 23.1 onwards) contains the following code: mail-utils.el:187: (with-current-buffer (get-buffer-create " *temp*") (erase-buffer) ... (erase-buffer)) This code erases the buffer " *temp*" even if it is being used by another piece of code! This is particularly bad because this is the first buffer used by with-temp-buffer. A simple fix is to switch to using with-temp-buffer, which always creates and destroys a new buffer (patch at end): (with-temp-buffer ... ) This bug breaks unrmail badly, causing it to discard all messages after one containing a from line that causes that block of code to be executed (roughly, from lines that contain nested comments). This is because unrmail loads the file to be converted into a buffer created with with-temp-buffer, which is in turn erased prematurely by mail-strip-quoted-names. [There is a longer discussion about this on the developers mailing list.] As this bug causes the permanent loss of e-mail, it should probably be fixed posthaste, including in version 23. - Mark ts-rhel5 [158]% diff mail-utils.el new-mail-utils.el 187,188c187 < (with-current-buffer (get-buffer-create " *temp*") < (erase-buffer) --- > (with-temp-buffer 201,202c200 < (setq address (buffer-string)) < (erase-buffer)) --- > (setq address (buffer-string))) From unknown Tue Jun 24 15:40:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: mark.lillibridge@hp.com Subject: bug#7746: closed (Re: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail) Message-ID: References: X-Gnu-PR-Message: they-closed 7746 X-Gnu-PR-Package: emacs Reply-To: 7746@debbugs.gnu.org Date: Sun, 02 Jan 2011 02:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1293935822-19942-1" This is a multi-part message in MIME format... ------------=_1293935822-19942-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 7746@debbugs.gnu.org. --=20 7746: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D7746 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1293935822-19942-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 7746-done) by debbugs.gnu.org; 2 Jan 2011 02:37:01 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZDob-0005BS-C3 for submit@debbugs.gnu.org; Sat, 01 Jan 2011 21:37:01 -0500 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZDoa-0005BI-6E for 7746-done@debbugs.gnu.org; Sat, 01 Jan 2011 21:37:00 -0500 Received: from localhost ([127.0.0.1]:48909) by fencepost.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZDvL-0007Re-Kh; Sat, 01 Jan 2011 21:43:59 -0500 To: 7746-done@debbugs.gnu.org Subject: Re: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail References: From: Glenn Morris X-Spook: Al-Qaeda INS United Nations illuminati kilo class X-Ran: lVR"l~/T8'D$)BtDOiaWPS}czR(Ii#7AAhuSv'0,TK5l_]6\*[eG6R9P (Mark Lillibridge's message of "Mon\, 27 Dec 2010 16\:17\:20 -0800") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 7746-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Version: 23.3 Thanks; applied. ------------=_1293935822-19942-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Dec 2010 00:10:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXN9G-0007K0-9Z for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:10:42 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXN9E-0007Jm-Ny for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:10:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXNFo-0002Zl-NR for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:17:29 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:38286) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXNFo-0002Zh-LH for submit@debbugs.gnu.org; Mon, 27 Dec 2010 19:17:28 -0500 Received: from [140.186.70.92] (port=34882 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PXNFn-0003Dn-J7 for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 19:17:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PXNFm-0002ZQ-Hv for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 19:17:27 -0500 Received: from gundega.hpl.hp.com ([192.6.19.190]:32823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PXNFm-0002ZL-8K for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2010 19:17:26 -0500 Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by gundega.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id oBS0HMDG010294 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 27 Dec 2010 16:17:22 -0800 Received: from ts-rhel5 (ts-rhel5.hpl.hp.com [15.25.118.27]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id oBS0HKSJ006087; Mon, 27 Dec 2010 16:17:20 -0800 Date: Mon, 27 Dec 2010 16:17:20 -0800 Message-Id: From: Mark Lillibridge To: bug-gnu-emacs@gnu.org Subject: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail X-Scanned-By: MIMEDefang 2.69 on 15.0.48.190 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: mark.lillibridge@hp.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) mail-strip-quoted-names in mail/mail-utils.el (at least version 23.1 onwards) contains the following code: mail-utils.el:187: (with-current-buffer (get-buffer-create " *temp*") (erase-buffer) ... (erase-buffer)) This code erases the buffer " *temp*" even if it is being used by another piece of code! This is particularly bad because this is the first buffer used by with-temp-buffer. A simple fix is to switch to using with-temp-buffer, which always creates and destroys a new buffer (patch at end): (with-temp-buffer ... ) This bug breaks unrmail badly, causing it to discard all messages after one containing a from line that causes that block of code to be executed (roughly, from lines that contain nested comments). This is because unrmail loads the file to be converted into a buffer created with with-temp-buffer, which is in turn erased prematurely by mail-strip-quoted-names. [There is a longer discussion about this on the developers mailing list.] As this bug causes the permanent loss of e-mail, it should probably be fixed posthaste, including in version 23. - Mark ts-rhel5 [158]% diff mail-utils.el new-mail-utils.el 187,188c187 < (with-current-buffer (get-buffer-create " *temp*") < (erase-buffer) --- > (with-temp-buffer 201,202c200 < (setq address (buffer-string)) < (erase-buffer)) --- > (setq address (buffer-string))) ------------=_1293935822-19942-1-- From unknown Tue Jun 24 15:40:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jan 2011 03:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: mark.lillibridge@hp.com Cc: 7746@debbugs.gnu.org Received: via spool by 7746-submit@debbugs.gnu.org id=B7746.129393805925815 (code B ref 7746); Sun, 02 Jan 2011 03:15:02 +0000 Received: (at 7746) by debbugs.gnu.org; 2 Jan 2011 03:14:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZEOg-0006iJ-JS for submit@debbugs.gnu.org; Sat, 01 Jan 2011 22:14:18 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZEOe-0006i3-Sq; Sat, 01 Jan 2011 22:14:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqkFAHJ9H01Ld/TY/2dsb2JhbACWK44cdLtBgnOCVwSEZY4b X-IronPort-AV: E=Sophos;i="4.60,261,1291611600"; d="scan'208";a="86887982" Received: from 75-119-244-216.dsl.teksavvy.com (HELO pastel.home) ([75.119.244.216]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 01 Jan 2011 22:21:18 -0500 Received: by pastel.home (Postfix, from userid 20848) id 88B8758DFC; Sat, 1 Jan 2011 22:21:18 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Sat, 01 Jan 2011 22:21:18 -0500 In-Reply-To: (Mark Lillibridge's message of "Mon, 27 Dec 2010 16:17:20 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) close 7746 thanks > This code erases the buffer " *temp*" even if it is being used by > another piece of code! This is particularly bad because this is the > first buffer used by with-temp-buffer. Indeed, that's wrong, thanks for spotting it. I've installed your suggested patch (see below) into the emacs-23 branch (for Emacs-23.3). BTW, I'm wondering why the code handles nesting in this way. Can you try the second patch below (you may need to hand-apply it since it's based on the new code I just installed), to confirm that it works just as well? Stefan --- lisp/mail/mail-utils.el 2010-10-09 00:41:03 +0000 +++ lisp/mail/mail-utils.el 2011-01-02 03:03:38 +0000 @@ -189,8 +189,7 @@ ;; Detect nested comments. (if (string-match "[ \t]*(\\([^)\\]\\|\\\\.\\|\\\\\n\\)*(" address) ;; Strip nested comments. - (with-current-buffer (get-buffer-create " *temp*") - (erase-buffer) + (with-temp-buffer (insert address) (set-syntax-table lisp-mode-syntax-table) (goto-char 1) @@ -203,8 +202,7 @@ (forward-sexp 1) (error (goto-char (point-max)))) (point)))) - (setq address (buffer-string)) - (erase-buffer)) + (setq address (buffer-string))) ;; Strip non-nested comments an easier way. (while (setq pos (string-match ;; This doesn't hack rfc822 nested comments Second patch to simplify the code: === modified file 'lisp/mail/mail-utils.el' --- lisp/mail/mail-utils.el 2011-01-02 03:16:03 +0000 +++ lisp/mail/mail-utils.el 2011-01-02 03:19:53 +0000 @@ -186,30 +186,13 @@ (mapconcat 'identity (rfc822-addresses address) ", ")) (let (pos) - ;; Detect nested comments. - (if (string-match "[ \t]*(\\([^)\\]\\|\\\\.\\|\\\\\n\\)*(" address) - ;; Strip nested comments. - (with-temp-buffer - (insert address) - (set-syntax-table lisp-mode-syntax-table) - (goto-char 1) - (while (search-forward "(" nil t) - (forward-char -1) - (skip-chars-backward " \t") - (delete-region (point) - (save-excursion - (condition-case () - (forward-sexp 1) - (error (goto-char (point-max)))) - (point)))) - (setq address (buffer-string))) - ;; Strip non-nested comments an easier way. + ;; Strip comments. (while (setq pos (string-match ;; This doesn't hack rfc822 nested comments ;; `(xyzzy (foo) whinge)' properly. Big deal. - "[ \t]*(\\([^)\\]\\|\\\\.\\|\\\\\n\\)*)" + "[ \t]*(\\([^()\\]\\|\\\\.\\|\\\\\n\\)*)" address)) - (setq address (replace-match "" nil nil address 0)))) + (setq address (replace-match "" nil nil address 0))) ;; strip surrounding whitespace (string-match "\\`[ \t\n]*" address) From unknown Tue Jun 24 15:40:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail Resent-From: Mark Lillibridge Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jan 2011 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 7746@debbugs.gnu.org Reply-To: mark.lillibridge@hp.com Received: via spool by 7746-submit@debbugs.gnu.org id=B7746.12940134957105 (code B ref 7746); Mon, 03 Jan 2011 00:12:02 +0000 Received: (at 7746) by debbugs.gnu.org; 3 Jan 2011 00:11:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZY1P-0001qY-7o for submit@debbugs.gnu.org; Sun, 02 Jan 2011 19:11:35 -0500 Received: from gundega.hpl.hp.com ([192.6.19.190]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZY1N-0001qL-Fh for 7746@debbugs.gnu.org; Sun, 02 Jan 2011 19:11:34 -0500 Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by gundega.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id p030IW47021584 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 2 Jan 2011 16:18:32 -0800 Received: from ts-rhel5 (ts-rhel5.hpl.hp.com [15.25.118.27]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id p030IT1u025304; Sun, 2 Jan 2011 16:18:29 -0800 Date: Sun, 02 Jan 2011 16:18:29 -0800 Message-Id: From: Mark Lillibridge In-reply-to: (message from Stefan Monnier on Sat, 1 Jan 2011 22:21:18 -0500) References: X-Scanned-By: MIMEDefang 2.69 on 15.0.48.190 X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > close 7746 > thanks > > > This code erases the buffer " *temp*" even if it is being used by > > another piece of code! This is particularly bad because this is the > > first buffer used by with-temp-buffer. > > Indeed, that's wrong, thanks for spotting it. I've installed your > suggested patch (see below) into the emacs-23 branch (for Emacs-23.3). > > BTW, I'm wondering why the code handles nesting in this way. Can you > try the second patch below (you may need to hand-apply it since it's > based on the new code I just installed), to confirm that it works just > as well? I looked up rfc822 comments on the web and found at http://www.w3.org/Protocols/rfc822/3_Lexical.html: comment = "(" *(ctext / quoted-pair / comment) ")" ctext = may be folded ")", "\" & CR, & including linear-white-space> quoted-pair = "\" CHAR ; may quote any char After some thought, I figured out why you your code doesn't work: it turns "( \( )" into "( \" You might be able to fix this problem using subgroups, but it's going to be fairly tricky code. - Mark From unknown Tue Jun 24 15:40:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jan 2011 03:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: mark.lillibridge@hp.com Cc: 7746@debbugs.gnu.org Received: via spool by 7746-submit@debbugs.gnu.org id=B7746.129402539426088 (code B ref 7746); Mon, 03 Jan 2011 03:30:04 +0000 Received: (at 7746) by debbugs.gnu.org; 3 Jan 2011 03:29:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZb7J-0006mj-R8 for submit@debbugs.gnu.org; Sun, 02 Jan 2011 22:29:53 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZb7I-0006mW-0v for 7746@debbugs.gnu.org; Sun, 02 Jan 2011 22:29:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4FAHbSIE1Ld/TY/2dsb2JhbACWF44cdLothUoEhGWOGw X-IronPort-AV: E=Sophos;i="4.60,265,1291611600"; d="scan'208";a="86924250" Received: from 75-119-244-216.dsl.teksavvy.com (HELO ceviche.home) ([75.119.244.216]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 02 Jan 2011 22:36:56 -0500 Received: by ceviche.home (Postfix, from userid 20848) id DAA3C6610E; Sun, 2 Jan 2011 22:36:55 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Sun, 02 Jan 2011 22:36:55 -0500 In-Reply-To: (Mark Lillibridge's message of "Sun, 02 Jan 2011 16:18:29 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) > After some thought, I figured out why you your code doesn't work: > it turns "( \( )" into "( \" Hmm... not in my test: (let ((address "(sadffds \\( adf)") pos) (while (setq pos (string-match ;; This doesn't hack rfc822 nested comments ;; `(xyzzy (foo) whinge)' properly. Big deal. "[ \t]*(\\([^()\\]\\|\\\\.\\|\\\\\n\\)*)" address)) (setq address (replace-match "" nil nil address 0))) address) returns "". Stefan From unknown Tue Jun 24 15:40:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail Resent-From: Mark Lillibridge Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jan 2011 04:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 7746@debbugs.gnu.org Reply-To: mark.lillibridge@hp.com Received: via spool by 7746-submit@debbugs.gnu.org id=B7746.129402757431924 (code B ref 7746); Mon, 03 Jan 2011 04:07:01 +0000 Received: (at 7746) by debbugs.gnu.org; 3 Jan 2011 04:06:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZbgU-0008Ir-Mw for submit@debbugs.gnu.org; Sun, 02 Jan 2011 23:06:14 -0500 Received: from madara.hpl.hp.com ([192.6.19.124]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZbgS-0008Id-Jw for 7746@debbugs.gnu.org; Sun, 02 Jan 2011 23:06:13 -0500 Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by madara.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id p034DE30006224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 2 Jan 2011 20:13:15 -0800 Received: from ts-rhel5 (ts-rhel5.hpl.hp.com [15.25.118.27]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id p034DDDe028718; Sun, 2 Jan 2011 20:13:13 -0800 Date: Sun, 02 Jan 2011 20:13:13 -0800 Message-Id: From: Mark Lillibridge In-reply-to: (message from Stefan Monnier on Sun, 2 Jan 2011 22:36:55 -0500) References: X-Scanned-By: MIMEDefang 2.69 on 15.0.152.124 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.0 (----) Opps. My bad. On closer look, I can't see any way to trip up the code. I'm it running against my e-mail corpus now. - Mark From unknown Tue Jun 24 15:40:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail Resent-From: Mark Lillibridge Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jan 2011 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: monnier@iro.umontreal.ca, 7746@debbugs.gnu.org Reply-To: mark.lillibridge@hp.com Received: via spool by 7746-submit@debbugs.gnu.org id=B7746.129408181511845 (code B ref 7746); Mon, 03 Jan 2011 19:11:02 +0000 Received: (at 7746) by debbugs.gnu.org; 3 Jan 2011 19:10:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZpnL-000350-G9 for submit@debbugs.gnu.org; Mon, 03 Jan 2011 14:10:15 -0500 Received: from madara.hpl.hp.com ([192.6.19.124]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PZpnK-00034p-1w for 7746@debbugs.gnu.org; Mon, 03 Jan 2011 14:10:14 -0500 Received: from mailhub-pa1.hpl.hp.com (mailhub-pa1.hpl.hp.com [15.25.115.25]) by madara.hpl.hp.com (8.14.3/8.14.3/HPL-PA Relay) with ESMTP id p03JHItc031403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 3 Jan 2011 11:17:18 -0800 Received: from ts-rhel5 (ts-rhel5.hpl.hp.com [15.25.118.27]) by mailhub-pa1.hpl.hp.com (8.14.3/8.14.3/HPL-PA Hub) with ESMTP id p03JHGx1011951; Mon, 3 Jan 2011 11:17:16 -0800 Date: Mon, 03 Jan 2011 11:17:16 -0800 Message-Id: From: Mark Lillibridge In-reply-to: (message from Mark Lillibridge on Sun, 2 Jan 2011 20:13:13 -0800) References: X-Scanned-By: MIMEDefang 2.69 on 15.0.152.124 X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) I ran the change against my e-mail corpus and my sanity checker didn't find any problems for what it's worth. - Mark From unknown Tue Jun 24 15:40:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7746: SERIOUS BUG: mail-strip-quoted-names bug causing unrmail to lose mail Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jan 2011 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: mark.lillibridge@hp.com Cc: 7746@debbugs.gnu.org Received: via spool by 7746-submit@debbugs.gnu.org id=B7746.129426271116795 (code B ref 7746); Wed, 05 Jan 2011 21:26:02 +0000 Received: (at 7746) by debbugs.gnu.org; 5 Jan 2011 21:25:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Paar0-0004Mq-Mk for submit@debbugs.gnu.org; Wed, 05 Jan 2011 16:25:10 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Paaqy-0004Md-Nu for 7746@debbugs.gnu.org; Wed, 05 Jan 2011 16:25:09 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id p05LWKXZ016274; Wed, 5 Jan 2011 16:32:20 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id B20AB130519; Wed, 5 Jan 2011 16:32:19 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Wed, 05 Jan 2011 16:32:19 -0500 In-Reply-To: (Mark Lillibridge's message of "Mon, 03 Jan 2011 11:17:16 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3731=0 X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I ran the change against my e-mail corpus and my sanity checker > didn't find any problems for what it's worth. Thanks for confirming. I've installed that change on the trunk (i.e. for Emacs-24). Stefan