GNU bug report logs - #77454
30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Daniel Mendler <mail <at> daniel-mendler.de>
Subject: bug#77454: closed (Re: bug#77454: 30.1.50; *-pkg.el header
 comment broken on GNU/NonGNU ELPA (devel))
Date: Thu, 17 Apr 2025 08:15:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#77454: 30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 77454 <at> debbugs.gnu.org.

-- 
77454: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77454
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Philip Kaludercic <philipk <at> posteo.net>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 77454-done <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#77454: 30.1.50; *-pkg.el header comment broken on
 GNU/NonGNU ELPA (devel)
Date: Thu, 17 Apr 2025 08:13:56 +0000

[Message part 3 (text/plain, inline)]

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> Daniel Mendler <mail <at> daniel-mendler.de> writes:
>
>> For example the Transient package has this header:
>>
>> ;; Generated package description from .el  -*- transientno-byte-compile: t -*-
>
> Ping. This problem is still present, for example:
>
> ;; Generated package description from mode: lisp-data; .el  -*- corfuno-byte-compile: t -*-

It seems that there was just a swap-o in elpa-admin.el:

[Message part 4 (text/x-patch, inline)]

diff --git a/elpa-admin.el b/elpa-admin.el
index 7e6db3fbf3..9ff01721ab 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1519,12 +1519,12 @@ Rename DIR/ to PKG-VERS/, and return the descriptor."
                  (cdr metadata)))
       (write-region
        (concat (format ";; Generated package description from %s.el  -*- %sno-byte-compile: t -*-\n"
+		       name
 		       (let* ((emacs-req (assq 'emacs requires))
 		              (emacs-vers (car (cadr emacs-req))))
 		         (if (not (and emacs-vers (>= emacs-vers 28)))
 		             ""     ;Need compatibility with Emacs<28.
-		           "mode: lisp-data; "))
-		       name)
+		           "mode: lisp-data; ")))
 	       (prin1-to-string
                 (nconc
                  (list 'define-package

[Message part 5 (text/plain, inline)]

That now generates

;; Generated package description from corfu.el  -*- mode: lisp-data;
   no-byte-compile: t -*-

As this is a serious issue with a simple fix, I'll push the change
myself.  If that was a mistake, anyone can feel free to undo it.

[Message part 6 (message/rfc822, inline)]

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)
Date: Wed, 02 Apr 2025 12:43:01 +0200

For example the Transient package has this header:

;; Generated package description from .el  -*- transientno-byte-compile: t -*-

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.