Subject: bug#77454: closed (Re: bug#77454: 30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel))

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 17 Apr 2025 08:15:04 +0000

Your bug report

#77454: 30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
77454: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77454
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#77454: 30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)
From: Philip Kaludercic <[email-masked]>
To: Daniel Mendler <[email-masked]>
Cc: [email-masked], Stefan Monnier <[email-masked]>
Date: Thu, 17 Apr 2025 08:13:56 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Daniel Mendler <[email-masked]> writes:

> Daniel Mendler <[email-masked]> writes:
>
>> For example the Transient package has this header:
>>
>> ;; Generated package description from .el  -*- transientno-byte-compile: t -*-
>
> Ping. This problem is still present, for example:
>
> ;; Generated package description from mode: lisp-data; .el  -*- corfuno-byte-compile: t -*-

It seems that there was just a swap-o in elpa-admin.el:

diff --git a/elpa-admin.el b/elpa-admin.el
index 7e6db3fbf3..9ff01721ab 100644
--- a/elpa-admin.el
+++ b/elpa-admin.el
@@ -1519,12 +1519,12 @@ Rename DIR/ to PKG-VERS/, and return the descriptor."
                  (cdr metadata)))
       (write-region
        (concat (format ";; Generated package description from %s.el  -*- %sno-byte-compile: t -*-\n"
+		       name
 		       (let* ((emacs-req (assq 'emacs requires))
 		              (emacs-vers (car (cadr emacs-req))))
 		         (if (not (and emacs-vers (>= emacs-vers 28)))
 		             ""     ;Need compatibility with Emacs<28.
-		           "mode: lisp-data; "))
-		       name)
+		           "mode: lisp-data; ")))
 	       (prin1-to-string
                 (nconc
                  (list 'define-package

That now generates

;; Generated package description from corfu.el  -*- mode: lisp-data;
   no-byte-compile: t -*-

As this is a serious issue with a simple fix, I'll push the change
myself.  If that was a mistake, anyone can feel free to undo it.

Subject: 30.1.50; *-pkg.el header comment broken on GNU/NonGNU ELPA (devel)
From: Daniel Mendler <[email-masked]>
To: [email-masked]
Date: Wed, 02 Apr 2025 12:43:01 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

For example the Transient package has this header:

;; Generated package description from .el  -*- transientno-byte-compile: t -*-