GNU bug report logs - #77445
[PATCH] gnu: nsxiv: Update to version 33.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77445: closed ([PATCH] gnu: nsxiv: Update to version 33.)
Date: Sun, 06 Apr 2025 17:14:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 06 Apr 2025 18:13:07 +0100
with message-id <87o6x9usbg.fsf <at> cbaines.net>
and subject line Re: [bug#77445] [PATCH] gnu: nsxiv: Update to version 33.
has caused the debbugs.gnu.org bug report #77445,
regarding [PATCH] gnu: nsxiv: Update to version 33.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77445: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77445
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jake Koroman <jake <at> jakekoroman.com>
To: guix-patches <at> gnu.org
Cc: Jake Koroman <jake <at> jakekoroman.com>
Subject: [PATCH] gnu: nsxiv: Update to version 33.
Date: Tue,  1 Apr 2025 13:34:06 -0400

Updated git-reference url to codeberg and updated install-icons and
install-desktop-file phases.

* gnu/packages/image-viewers.scm (nsxiv): Update to version 33
[#:phases]<install-desktop-file>: Update nsxiv.desktop path.
          <install-icons>: Fix old make command.

Change-Id: I75984bdaff321b1302d40d22e9599249f221ee37
---
 gnu/packages/image-viewers.scm | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm
index 1dbc410a58..dba1c6cc4c 100644
--- a/gnu/packages/image-viewers.scm
+++ b/gnu/packages/image-viewers.scm
@@ -445,16 +445,16 @@ (define-public sxiv
 (define-public nsxiv
   (package
     (name "nsxiv")
-    (version "27.1")
+    (version "33")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
-             (url "https://github.com/nsxiv/nsxiv")
+             (url "https://codeberg.org/nsxiv/nsxiv")
              (commit (string-append "v" version))))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1na7f0hpc9g04nm7991gzaqr5gkj08n2azx833hgxcm2w1pnn1bk"))))
+        (base32 "1y8rsg8q45b1dbm9zrsr0s7v86z95b87cvn7n81nlkj7paj3wnqz"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f                      ;no check target
@@ -476,12 +476,12 @@ (define-public nsxiv
                   (string-append "-I" freetype))))))
          (add-after 'install 'install-desktop-file
            (lambda* (#:key outputs #:allow-other-keys)
-             (install-file "nsxiv.desktop"
+             (install-file "etc/nsxiv.desktop"
                            (string-append (assoc-ref outputs "out")
                                           "/share/applications"))))
          (add-after 'install 'install-icons
            (lambda* (#:key make-flags #:allow-other-keys)
-             (apply invoke "make" "-C" "icon" "install" make-flags))))))
+             (apply invoke "make" "install-icon" make-flags))))))
     (inputs
      (list freetype
            giflib
-- 
2.49.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Jake Koroman via Guix-patches via <guix-patches <at> gnu.org>
Cc: 77445-done <at> debbugs.gnu.org, Jake Koroman <jake <at> jakekoroman.com>
Subject: Re: [bug#77445] [PATCH] gnu: nsxiv: Update to version 33.
Date: Sun, 06 Apr 2025 18:13:07 +0100

[Message part 4 (text/plain, inline)]

Jake Koroman via Guix-patches via <guix-patches <at> gnu.org> writes:

> Updated git-reference url to codeberg and updated install-icons and
> install-desktop-file phases.
>
> * gnu/packages/image-viewers.scm (nsxiv): Update to version 33
> [#:phases]<install-desktop-file>: Update nsxiv.desktop path.
>           <install-icons>: Fix old make command.
>
> Change-Id: I75984bdaff321b1302d40d22e9599249f221ee37
> ---
>  gnu/packages/image-viewers.scm | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Thanks for the patch, I've pushed this to master as
1056ca81cbb4575177e7e43b23f79d565c510167.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.