GNU bug report logs - #77441
[PATCH] gnu: compsize: Remove.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Greg Hogan <code <at> greghogan.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77441: closed ([PATCH] gnu: compsize: Remove.)
Date: Tue, 29 Apr 2025 15:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 29 Apr 2025 11:41:31 -0400
with message-id <CA+3U0ZnqLDNeAURbuDPQqs+ReSFomErTE35C+Qo2Pg7h0QXi9g <at> mail.gmail.com>
and subject line Re: [bug#77441] [PATCH] gnu: compsize: Update and fix build.
has caused the debbugs.gnu.org bug report #77441,
regarding [PATCH] gnu: compsize: Remove.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77441: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77441
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 Ashish SHUKLA <ashish.is <at> lostca.se>
Subject: [PATCH] gnu: compsize: Remove.
Date: Wed,  2 Apr 2025 00:30:13 +0200

This package fails to build with btrfs-progs <at> 6.3.3 and hasn’t seen any
activity upstream since Dec. 2023.

* gnu/packages/linux.scm (compsize): Remove.

Change-Id: I30513d8fbda362c49c763300db7a7ff41e81a38c
---
 gnu/packages/linux.scm | 44 ------------------------------------------
 1 file changed, 44 deletions(-)

Hi,

The ‘compsize’ package fails to build since the e2fsprogs and btrfs-progs
upgrades from <https://issues.guix.gnu.org/75119> (commit
7cef57e2a7dedd3eea0ba5852915eaf10f00e9f4).

According to the deprecation policy, this patch can be applied in one month
if there are no objections, on May 2nd.

Ludo’.

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 2c587baac0..7fa36306cc 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -6887,50 +6887,6 @@ (define-public cramfs-tools
 blocks and random block placement.")
     (license license:gpl2+)))
 
-(define-public compsize
-  (package
-    (name "compsize")
-    (version "1.5")
-    (home-page "https://github.com/kilobyte/compsize")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url home-page)
-                    (commit (string-append "v" version))))
-              (sha256
-               (base32 "0vqnrwgpv6pc1yjl0g4gl71xyl6v0xl3pyqjanjpwps73c53azir"))
-              (file-name (git-file-name name version))))
-    (build-system gnu-build-system)
-    (inputs
-     (list btrfs-progs))
-    (arguments
-     `(#:tests? #f                      ; No tests.
-       #:make-flags
-       (list (string-append "CC=" ,(cc-for-target)))
-       #:phases
-       (modify-phases %standard-phases
-         (delete 'configure)
-         (replace 'install
-           (lambda* (#:key outputs #:allow-other-keys)
-             (let ((out (assoc-ref outputs "out")))
-               (install-file "compsize" (string-append out "/bin"))
-               (install-file "compsize.8" (string-append out "/share/man/man8"))))))))
-    (synopsis "Find compression type/ratio on Btrfs files")
-    (description "@command{compsize} takes a list of files (given as
-arguments) on a Btrfs file system and measures used compression types and
-effective compression ratio, producing a report.
-
-A directory has no extents but has a (recursive) list of files.  A non-regular
-file is silently ignored.
-
-As it makes no sense to talk about compression ratio of a partial extent,
-every referenced extent is counted whole, exactly once -- no matter if you use
-only a few bytes of a 1GB extent or reflink it a thousand times.  Thus, the
-uncompressed size will not match the number given by @command{tar} or
-@command{du}.  On the other hand, the space used should be accurate (although
-obviously it can be shared with files outside our set).")
-    (license license:gpl2+)))
-
 (define-public f2fs-tools
   (package
     (name "f2fs-tools")

base-commit: eb04a0d2c955f5fa9a721537c8202fc5c5959b19
-- 
2.49.0

[Message part 3 (message/rfc822, inline)]

From: Greg Hogan <code <at> greghogan.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 77441-done <at> debbugs.gnu.org, Wilko Meyer <w <at> wmeyer.eu>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#77441] [PATCH] gnu: compsize: Update and fix build.
Date: Tue, 29 Apr 2025 11:41:31 -0400

On Wed, Apr 23, 2025 at 6:32 AM Ludovic Courtès <ludo <at> gnu.org> wrote:
>
> Hello,
>
> Greg Hogan <code <at> greghogan.com> writes:
>
> > * gnu/packages/linux.scm (compsize): Update to d79eacf7.
> > [source]<patches>: Add compsize-fix-btrfs-progs-compatibility.patch.
> > * gnu/packages/patches/compsize-fix-btrfs-progs-compatibility.patch:
> > New file.
> > * gnu/local.mk (dist_patch_DATA): Update accordingly.
> >
> > Change-Id: Ia967635c2fce035ebf7e4067a2dd412d4f7a0467
>
> LGTM!
>
> > +++ b/gnu/packages/patches/compsize-fix-btrfs-progs-compatibility.patch
> > @@ -0,0 +1,1614 @@
> > +From upstream from https://github.com/kilobyte/compsize/pull/53
>
> Neat, I hadn’t checked PRs while searching for a fix.
>
> Thanks,
> Ludo’.

Pushed as e913acf1183968397b834757cc6c7f902a0acc05.

I tweaked the "version" field so as not to shadow a variable, but this
does not change the derivation.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.