GNU bug report logs - #77421
[PATCH] [etags] Fix module definition with ::

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Laurent Stacul <laurent.stacul <at> gmail.com>, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 77421 <at> debbugs.gnu.org
Subject: bug#77421: [PATCH] [etags] Fix module definition with ::
Date: Tue, 01 Apr 2025 14:53:30 +0300

> From: Laurent Stacul <laurent.stacul <at> gmail.com>
> Date: Mon, 31 Mar 2025 20:45:12 +0200
> 
> I have a patch I would like to submit. I tried to follow all the docs
> but if I did something wrong, don't hesitate to tell me.
> 
> Problem: In ruby we can define a nested module/class the safe way (in
> the sense, if the parent module does not exist, it will define it):
> 
>   module M
>     module N
>     end
>   end
> 
> Or, if M already exists, we can also write:
> 
>   module M::N; end
> 
> With the later notation, the tag generated by etags will be M::N. When
> browsing the code, using xref-find-definitions when the point is on N,
> will not be able to find the definition of N because the implicit tag
> name is M::N.
> 
> This is the same problem with nested classes or even some rare
> allowed definitions like explicitely defining a module/class from the
> global namespace:
> 
>   class ::A; end
> 
> Solution: We need to give an explicit tag name. To achieve this, on
> module/class definition we truncate the name to the last found column.

Thanks.

Dmitry, any comments?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.