GNU bug report logs - #77396
[PATCH] services: Add ngircd-service-type.

Previous Next

Full log

View this message in rfc822 format

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>, Christopher Baines <guix <at> cbaines.net>, 77396 <at> debbugs.gnu.org
Subject: [bug#77396] [PATCH v2 1/2] least-authority: Preserve systemd LISTEN_* environment variables.
Date: Mon, 14 Apr 2025 10:19:32 +0900

Hi Ludovic,

Ludovic Courtès <ludo <at> gnu.org> writes:

[...]

>>>> -(define %precious-variables
>>>> +(define %default-preserved-environment-variables
>>>>    ;; Environment variables preserved by the wrapper by default.
>>>> -  '("HOME" "USER" "LOGNAME" "DISPLAY" "XAUTHORITY" "TERM" "TZ" "PAGER"))
>>>> +  '("HOME" "USER" "LOGNAME" "DISPLAY" "XAUTHORITY" "TERM" "TZ" "PAGER"
>>>> +    "LISTEN_PID" "LISTEN_FDS" "LISTEN_FDNAMES")) ;for make-systemd-constructor
>>>
>>> I would not export this variable, but otherwise LGTM!
>>
>> It aims to make extending the list easier.  Otherwise one has to peek
>> into the code, and copy the existing list to be consed to.
>
> Ah yes, that makes sense to me.  Let’s export it then!

I had already pushed this without exporting it.  Let's revisit the next
time we have a reason to extend the list.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.