GNU bug report logs - #77396
[PATCH] services: Add ngircd-service-type.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Mon, 31 Mar 2025 02:29:07 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #34 received at 77396 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Tobias Geerinckx-Rice <me <at> tobias.gr>, Christopher Baines <guix <at> cbaines.net>,
 77396 <at> debbugs.gnu.org
Subject: Re: [bug#77396] [PATCH v2 1/2] least-authority: Preserve systemd
 LISTEN_* environment variables.
Date: Tue, 08 Apr 2025 11:49:35 +0200

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>>
>>> Otherwise, combining make-systemd-constructor with least-authority-wrapper
>>> would not work correctly out of the box.
>>>
>>> * guix/least-authority.scm (%precious-variables): Rename to...
>>> (%default-preserved-environment-variables): ... this, and export it.
>>> Add "LISTEN_PID" "LISTEN_FDS" "LISTEN_FDNAMES" environment variables.
>>> (least-authority-wrapper): Adjust accordingly.
>>>
>>> Change-Id: Idd259b15463920965f530e1917d76bf97def3b7b
>>
>> [...]
>>
>>> -(define %precious-variables
>>> +(define %default-preserved-environment-variables
>>>    ;; Environment variables preserved by the wrapper by default.
>>> -  '("HOME" "USER" "LOGNAME" "DISPLAY" "XAUTHORITY" "TERM" "TZ" "PAGER"))
>>> +  '("HOME" "USER" "LOGNAME" "DISPLAY" "XAUTHORITY" "TERM" "TZ" "PAGER"
>>> +    "LISTEN_PID" "LISTEN_FDS" "LISTEN_FDNAMES")) ;for make-systemd-constructor
>>
>> I would not export this variable, but otherwise LGTM!
>
> It aims to make extending the list easier.  Otherwise one has to peek
> into the code, and copy the existing list to be consed to.

Ah yes, that makes sense to me.  Let’s export it then!

Ludo’.
This bug report was last modified 34 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.