GNU bug report logs - #77383
[PATCH 0/2] Run speakersafetyd as unprivileged user

Previous Next

Full log

Message #29 received at 77383 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 77383 <at> debbugs.gnu.org, Steve George <steve <at> futurile.net>,
 Efraim Flashner <efraim <at> flashner.co.il>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>
Subject: Re: [bug#77383] [PATCH v2 1/3] gnu: speakersafetyd: Update to 1.1.2.
Date: Tue, 08 Apr 2025 11:09:26 +0900

Hi Roman,

2nd pass over this series.

Roman Scherer <roman <at> burningswell.com> writes:

> * gnu/packages/rust-apps.scm (speakersafetyd): Update to 1.1.2.
>
> Change-Id: I1c6d7b6080b18bd8228e8b39d1a0b42267e2b7e1

[...]

> -              (setenv "BINDIR" (string-append #$output "/bin"))
> -              (setenv "UNITDIR" (string-append #$output "/lib/systemd/system"))
> -              (setenv "UDEVDIR" (string-append #$output "/lib/udev/rules.d"))
> -              (setenv "TMPFILESDIR" (string-append #$output "/usr/lib/tmpfiles.d"))
> -              (setenv "SHAREDIR" (string-append #$output "/share"))
> -              (setenv "VARDIR" (string-append #$output "/var"))
> -              (invoke "make" "install-data"))))))
> +              (setenv "DESTDIR" #$output)
> +              (setenv "SHAREDIR" "/share")
> +              (setenv "SPEAKERSAFETYD_GROUP" "nixbld")
> +              (setenv "SPEAKERSAFETYD_USER" "nixbld")

Since this are just setting environment variables, which are statufel,
there's no need to override the install phase, it can go in a
'prepare-to-install or similarly named phase ordered before 'install.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.