GNU bug report logs - #77369
typescript-ts-mode's defun definition is wrong

Previous Next

Full log

Message #16 received at 77369 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Daniel Colascione <dancol <at> dancol.org>, 77369 <at> debbugs.gnu.org,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#77369: typescript-ts-mode's defun definition is wrong
Date: Thu, 3 Apr 2025 00:46:04 -0700

> On Apr 3, 2025, at 12:30 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
>> From: Daniel Colascione <dancol <at> dancol.org>
>> Date: Sat, 29 Mar 2025 14:17:15 -0400
>> 
>> Not sure whether this is a bug or just surprising design, but in this
>> code:
>> 
>>    function Blah(foo) {
>>      const foo = 1;
>>      const bar = 2;
>>    }
>> 
>> with point on "const foo", I do not expect end-of-defun to go to "const
>> bar".  I expect it to go to the closing curly brace.
> 
> Juri and Yuan, any comments or suggestions?

I pushed a fix for it. Maybe my message got lost? Though now that I think of it, I should’ve pushed the fix to emacs-30 instead of master...

Below is my last message:
> 
> Yeah, that’s because const foo = 1; is a “lexical_declaration”, which is considered a defunct in typescript-ts-mode, because in js you can have arrow functions like
> 
> const Blah = (foo) => {
>  return true;
> };
> 
> Which is also a “lexical_declaration”. I guess we can refine the pattern matching to check if it’s an arrow function and only then consider it a defun.
> 
> I did that, now on latest master, end-of-defun should move to the end of the function in your example.
> 
Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.