From unknown Fri Aug 15 03:38:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77369 <77369@debbugs.gnu.org> To: bug#77369 <77369@debbugs.gnu.org> Subject: Status: typescript-ts-mode's defun definition is wrong Reply-To: bug#77369 <77369@debbugs.gnu.org> Date: Fri, 15 Aug 2025 10:38:51 +0000 retitle 77369 typescript-ts-mode's defun definition is wrong reassign 77369 emacs submitter 77369 Daniel Colascione severity 77369 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 14:17:29 2025 Received: (at submit) by debbugs.gnu.org; 29 Mar 2025 18:17:29 +0000 Received: from localhost ([127.0.0.1]:33000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyakL-0005t9-4Z for submit@debbugs.gnu.org; Sat, 29 Mar 2025 14:17:29 -0400 Received: from lists.gnu.org ([2001:470:142::17]:41670) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyakH-0005sq-7r for submit@debbugs.gnu.org; Sat, 29 Mar 2025 14:17:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyakB-0006Fo-HO for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2025 14:17:19 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyak9-0004yN-Eh for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2025 14:17:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qw5uxKJpMG5dgCGUMo0vkcaml42MvQJcUaEqv9mCmTM=; b=fQ/UUwa9uE5RgDKcwOUU+UYpuH Yq6HnVYD+Az1GwQMEsalC3JHLjANaiwhl8W1Fo5ZUyxwj6xzMUfvUQFlk4N0Hd8frCBY21f3Jawsc ip5ByjIuc8FzBR6Vva5RFhFqFAevRLTmk7RdwmbtrxjFXZpsZs/WBhZ37G0QeJ1EB2a4G2kro1B/C 998QFEMAgldTjBWyL/7nV2pUW49eHvG6nnufylagh+Np8cQsJqoilH7JaEC9GF4MOoGYXFkm8yk9m 3Y2GlAtu+LxrwD6/N+h1LOBMe3m6uJLLkhis0Id0xscjDM62iwwzIrX7WGbJdY2scOIZeNQ3zIKZe aY0mGzqg==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from ) id 1tyaji-004RNQ-1v for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2025 14:16:50 -0400 From: Daniel Colascione To: bug-gnu-emacs@gnu.org Subject: typescript-ts-mode's defun definition is wrong User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Sat, 29 Mar 2025 14:17:15 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2600:3c01:e000:3d8::1; envelope-from=dancol@dancol.org; helo=dancol.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Not sure whether this is a bug or just surprising design, but in this code: function Blah(foo) { const foo = 1; const bar = 2; } with point on "const foo", I do not expect end-of-defun to go to "const bar". I expect it to go to the closing curly brace. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 30 00:21:26 2025 Received: (at 77369-done) by debbugs.gnu.org; 30 Mar 2025 04:21:26 +0000 Received: from localhost ([127.0.0.1]:33961 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tykAo-0008Pl-H4 for submit@debbugs.gnu.org; Sun, 30 Mar 2025 00:21:26 -0400 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:43250) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tykAl-0008PS-2d for 77369-done@debbugs.gnu.org; Sun, 30 Mar 2025 00:21:23 -0400 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2ff615a114bso6785155a91.0 for <77369-done@debbugs.gnu.org>; Sat, 29 Mar 2025 21:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743308477; x=1743913277; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kzHGMwOJRcJYB7ocwjtJoND/zC5wa0DBt94/v5AQ3oI=; b=niIX5Zk7d6upyDi2rShBz4gtqBIwdjbxQnN+HP6MexezKq2blaYq3EEuwbXBKTy467 haME793pAS6qVpqMZljXQPvzxFfaPqTNquB1PDNxgDXY7btR4ypADR4dDwvMoq5tShUr pXwwqbHIhUrAp8Sg0bx+feeiLZWICEdbzI9D5FOJGiQBX7U583+q3SfQ6CrXeYfIMHMt d30kfNUzX+NZEaSudN5OUd+2s7ghwMa3grt8MeeqoVTR9m56nboBl4c6edMgodENhGuS x2+la9YeiVsHAQCWIyIShIMkSIy8T2Z0oVF5YKTGBHvwWp9a/Yk+KBYN4SpLQGmgWbH0 zOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743308477; x=1743913277; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kzHGMwOJRcJYB7ocwjtJoND/zC5wa0DBt94/v5AQ3oI=; b=g3shSIZhjwo/SHh+NqlyaShgjwi2+PXTb883hCbfZ4/BFrX8sBfZsKQQpkrNsM9BvK 7UwvY9/IM98J6WAOLAXVpjOAWlV6uKubibjJ7Hpw+jGQnAV5Q6WMC3KwJmefuiuPv8Ve B3r7PdWHyCUXtv/369YAhJ5Oi4HCKMJlhZPUwd7k6Zkv6L8m9WjlEBFKAZesHJMguT4c TdL1MREtHWY5PMdGlCOpBKofzo29YYEBNlXdX8Cw+R8YNxrwMAp92UBPEtdwOaNtpjil ZrElM+DEVqcjxr+cziWm80ZWvzq46oGzhlaysFXMxh1bKBEu1/gWVLYaYruloEZL2jMk pDhA== X-Gm-Message-State: AOJu0Yxqu1PfH1vgA1+YP1P7f3HMfK9VTUHXb/ZAx5V5n6uj/2SShCvr VO7+9FYUpcWklZezkqaFHKxytjqhNQQi2UvvxeA2CoAMlBP6Q9sU6y3DnA== X-Gm-Gg: ASbGncvsHKrMOGf8/6E71tQVKvQe+27QwkJBBGMdL+/LZm1pzoegQh4KoMey/haQb0o aV4M55HPevxNHy5R42qUiZpB/2C9IZSoPX+I/lvFnakngmwygfB0QTpygJc4XMx3PuIHxxsRpIZ V5wyI44+4VCyWLIOfHNAlKx26zQe0xeWm013nRo42M6usaz/cm+8ddyZKwRHZW0UU19Bca6v3NF 5HWW7nx7DzyO4uWvoWqQtBZmSb/wAyZMJe6+cHWTUC6piODOiU+O4uw55JpiDVkKetQm0oMmlB7 9xqx8F7us/UaVLJrJUrAqSAC/JVg3VjbleBtsrKLK0uGX/LI8APH7F1of6Epcz2oxyRS X-Google-Smtp-Source: AGHT+IGg1UXXLEnDuAmpp/K9v3KpM4IsJBeEGgXeik21aMvvK7GpywNKmQf2DlS3Xn0jamWXxYTYHg== X-Received: by 2002:a17:90b:258c:b0:2fa:6793:e860 with SMTP id 98e67ed59e1d1-3051c63c952mr14221797a91.0.1743308476930; Sat, 29 Mar 2025 21:21:16 -0700 (PDT) Received: from smtpclient.apple ([2601:646:8f81:6120:4c87:420d:deb5:690a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3039dfd38a6sm6981241a91.10.2025.03.29.21.21.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Mar 2025 21:21:16 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: bug#77369: typescript-ts-mode's defun definition is wrong From: Yuan Fu In-Reply-To: Date: Sat, 29 Mar 2025 21:21:05 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <75B4CE4F-7F95-483D-AFAB-7FC5E1719DCC@gmail.com> References: To: Daniel Colascione X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77369-done Cc: Theodor Thornhill , 77369-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 29, 2025, at 11:17=E2=80=AFAM, Daniel Colascione = wrote: >=20 > Not sure whether this is a bug or just surprising design, but in this > code: >=20 > function Blah(foo) { > const foo =3D 1; > const bar =3D 2; > } >=20 > with point on "const foo", I do not expect end-of-defun to go to = "const > bar". I expect it to go to the closing curly brace. Yeah, that=E2=80=99s because const foo =3D 1; is a = =E2=80=9Clexical_declaration=E2=80=9D, which is considered a defunct in = typescript-ts-mode, because in js you can have arrow functions like const Blah =3D (foo) =3D> { return true; }; Which is also a =E2=80=9Clexical_declaration=E2=80=9D. I guess we can = refine the pattern matching to check if it=E2=80=99s an arrow function = and only then consider it a defun. I did that, now on latest master, end-of-defun should move to the end of = the function in your example. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 03:30:32 2025 Received: (at 77369) by debbugs.gnu.org; 3 Apr 2025 07:30:33 +0000 Received: from localhost ([127.0.0.1]:60739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0F20-0006rw-K7 for submit@debbugs.gnu.org; Thu, 03 Apr 2025 03:30:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60530) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0F1w-0006rc-LE for 77369@debbugs.gnu.org; Thu, 03 Apr 2025 03:30:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0F1p-00024V-Ok; Thu, 03 Apr 2025 03:30:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oxpH2eQfvYRDv+7OhOO0hgpznH41qBcNFzpStLo6ZD4=; b=cSM9ySG0wNJJ JXbS2JJhkcJlV4g9FVnbM9Ais17/2frbj+v4pR8j9g2pL9XRQDkSkd/7JG6Ud++wjyWr4f2lxSus3 lHDPNXv/a3YsPJjVEfFQvLB8wfBA8TWcHbCPrzztdAtcdBUdHos49/i2zOP5hhOKKsfIr8YSqwAo7 1VS28PoIaiVTXfq8oDw/Mp47YmnTZ4Ct6jBkruIcf8Bw0JIfdPSgThTV9HE82TU3pd4HZG6RtSyaz 2DrM/KZPRlGUHkyv5rWmcPKB77n5Uthy3dLsXi3pF6iVSHR1D+X4Rx5EJbBrZMZ05V0usB1JL5UMK wP2kSPoV0wUcc79pTkm3VA==; Date: Thu, 03 Apr 2025 10:30:19 +0300 Message-Id: <86plhtzoqc.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione , Yuan Fu , Juri Linkov In-Reply-To: (message from Daniel Colascione on Sat, 29 Mar 2025 14:17:15 -0400) Subject: Re: bug#77369: typescript-ts-mode's defun definition is wrong References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77369 Cc: 77369@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Colascione > Date: Sat, 29 Mar 2025 14:17:15 -0400 > > Not sure whether this is a bug or just surprising design, but in this > code: > > function Blah(foo) { > const foo = 1; > const bar = 2; > } > > with point on "const foo", I do not expect end-of-defun to go to "const > bar". I expect it to go to the closing curly brace. Juri and Yuan, any comments or suggestions? From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 03:46:29 2025 Received: (at 77369) by debbugs.gnu.org; 3 Apr 2025 07:46:29 +0000 Received: from localhost ([127.0.0.1]:60801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0FHQ-00029z-MB for submit@debbugs.gnu.org; Thu, 03 Apr 2025 03:46:29 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:42495) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u0FHK-00025c-S8 for 77369@debbugs.gnu.org; Thu, 03 Apr 2025 03:46:27 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-223f4c06e9fso5575705ad.1 for <77369@debbugs.gnu.org>; Thu, 03 Apr 2025 00:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743666376; x=1744271176; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2C0mpWGQL8IQtBltCNGD0+5axgTf/zVxbkUgG6Ex24s=; b=gOy+zgeyLtD2X9EnRfjJ8hIQ/avahzdBPIGrvX/tloMtSoNADaP56eng4n4ZKCBqc1 bAdCmhq93EDts83DoSP/HSG1QGH305AnauKroPOK+LehdFtzrP8gH79kIFOcyRBYW7ka 8KZ04jC1v94dAylM9uKhuxyhlUXG8QsiCHRFSG1zP4Do0pvnPk9omtCVJldq5z7aYQGO O2xXlbjP/BDYMiVa/DjECB9SgvVgWvZ3sYmWSR2pX7LqdIHZMfSac7tgPBMLO8md2uvh iZRzoT6KPSFKV11C8bMwzq9NVLt/uL81xss2SYOntYsbg30KEWLL3ftZeMFmNy10Enn2 /wUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743666376; x=1744271176; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2C0mpWGQL8IQtBltCNGD0+5axgTf/zVxbkUgG6Ex24s=; b=k2VduG6f/CAHnmH3w7S0TRB43STeGQYkgV1NfGKoakftX8hq2KRRu4Bc8jC0HBK7Nu FuvNRtzVvqkLo93QnQmGUJ93sY6O8W+HC/6/8fxpJfH/Q304YAJv1zb1G25xhao5ydCJ 196xtLbgG3Nf2Ezykj4chfIGGFMwxTsQmg9C5zq5tbPnlUBkzloZfayD/uYAFLtLqVI/ Qb/9bU2hsscsdFwcFEyoCNDsMqpM3bMaWyxGRSKZiKtVcfxCh/ZbeiCxGl+OoxWMCUQJ R/DjLDBBMKIXiPXs0d+/y7OAUCBwSbFgSW9anJ4k7y01zLa+Hut3o/02jvXrqXGlMiRl EGQA== X-Forwarded-Encrypted: i=1; AJvYcCUbIFDwCIJFQUhWbmn9qUuFewafTQ7jozhzHY9u+TN9bCSrYIG17Rqrs/A3ipFPlaGv+880og==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx7ooU0IIyVAIjwfWBKDsmr5gSK4Ysek6OCyL133wE5i8KAqIh4 CY2ECxlmmhkKLyLLedK0cLIutc+tp42jpqNVTUcwDZWBZBfjpMOmsxBcpw== X-Gm-Gg: ASbGnctiN1/T1X6Vz+fclIgVF1dK4VuHiwxYraKZ+dsPCBblAaMSP1l7puN2ols53JE EfDRb2GjwC9XfyRk6jBWFEpFRz5gNk80lT1sw9659lg/dbYLLsbQqSd5MOxbltEOvtUqrt09Q4D Od0OeD/Z++V9olY5LrA9OOT5YSdM2xNTxJLJesd1R1Alrd60b9macQsJkc/V1ggeRLUbWvtI/Bp CDiVOgZpEhB5DKzBQddSGisgymfk3T3DEtlVKEwDFWINGo3ya6ZsAWXMYp0YFHN2paDAeZJVB7D aNTNc1oYRhnJaqgKgET4S0dxDtLv6B3BhC1Y2JU7OA2nW7/OLF+fIVLN6+/UG1WvtdIN X-Google-Smtp-Source: AGHT+IHF62UPMPAuy7CrYHJAmMewFMZy5tatgIw2ahw7MP8Zo1zPmNAPvljaKuG9lGJBKNXL+3+Ddw== X-Received: by 2002:a17:902:f546:b0:226:194f:48ef with SMTP id d9443c01a7336-229765d1ad7mr33840525ad.13.1743666376291; Thu, 03 Apr 2025 00:46:16 -0700 (PDT) Received: from smtpclient.apple ([2601:646:8f81:6120:88c1:462c:b290:4695]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739da0b2d76sm802489b3a.122.2025.04.03.00.46.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Apr 2025 00:46:15 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: bug#77369: typescript-ts-mode's defun definition is wrong From: Yuan Fu In-Reply-To: <86plhtzoqc.fsf@gnu.org> Date: Thu, 3 Apr 2025 00:46:04 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <883B3D5E-2D37-4435-BDCB-8B9511B3DE72@gmail.com> References: <86plhtzoqc.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77369 Cc: Daniel Colascione , 77369@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Apr 3, 2025, at 12:30=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Daniel Colascione >> Date: Sat, 29 Mar 2025 14:17:15 -0400 >>=20 >> Not sure whether this is a bug or just surprising design, but in this >> code: >>=20 >> function Blah(foo) { >> const foo =3D 1; >> const bar =3D 2; >> } >>=20 >> with point on "const foo", I do not expect end-of-defun to go to = "const >> bar". I expect it to go to the closing curly brace. >=20 > Juri and Yuan, any comments or suggestions? I pushed a fix for it. Maybe my message got lost? Though now that I = think of it, I should=E2=80=99ve pushed the fix to emacs-30 instead of = master... Below is my last message: >=20 > Yeah, that=E2=80=99s because const foo =3D 1; is a = =E2=80=9Clexical_declaration=E2=80=9D, which is considered a defunct in = typescript-ts-mode, because in js you can have arrow functions like >=20 > const Blah =3D (foo) =3D> { > return true; > }; >=20 > Which is also a =E2=80=9Clexical_declaration=E2=80=9D. I guess we can = refine the pattern matching to check if it=E2=80=99s an arrow function = and only then consider it a defun. >=20 > I did that, now on latest master, end-of-defun should move to the end = of the function in your example. >=20 Yuan= From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 03:57:03 2025 Received: (at 77369) by debbugs.gnu.org; 3 Apr 2025 07:57:03 +0000 Received: from localhost ([127.0.0.1]:60850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0FRe-0002d8-K1 for submit@debbugs.gnu.org; Thu, 03 Apr 2025 03:57:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53278) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0FRb-0002cX-3M for 77369@debbugs.gnu.org; Thu, 03 Apr 2025 03:57:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0FRT-0006zb-Ux; Thu, 03 Apr 2025 03:56:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=YIcBRLZErRIcExCw1+Gp7oZiWTzHYhjIgP7f1XmYtmA=; b=Sfml9ApfE26/YNurz9NB jOZkKjFwbCGCY2Iy0V+aga6jxhSAW996Gh949wybtQ/pqnfsc2uw2hJ3EnHCWw0egxv1WM268IvFh 9bD2+E3t+Fm1JmUV1fLxgu89PZRvclcoynZuvCLOjl1z1PiBH3CCfUFWfbp29IkJBG+AHbAjZuLsU Wujf/rBrrOFlvaAWLqzafqa2QQVAVQUmXorJjWJIoBlXlGLIuasPYGEmWUBtfQIDFmUCThc5jSnDX YvV0odrNcTVO56QZxXuwOeUsSid785WQYZzUn7Gyj3EOVDdFiAoKSw75QTgpTKjtfJnosZ0HpJpyG Y/NoMujsZozihA==; Date: Thu, 03 Apr 2025 10:56:41 +0300 Message-Id: <86jz81znie.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: <883B3D5E-2D37-4435-BDCB-8B9511B3DE72@gmail.com> (message from Yuan Fu on Thu, 3 Apr 2025 00:46:04 -0700) Subject: Re: bug#77369: typescript-ts-mode's defun definition is wrong References: <86plhtzoqc.fsf@gnu.org> <883B3D5E-2D37-4435-BDCB-8B9511B3DE72@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77369 Cc: dancol@dancol.org, 77369@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Thu, 3 Apr 2025 00:46:04 -0700 > Cc: Daniel Colascione , > Juri Linkov , > 77369@debbugs.gnu.org > > > On Apr 3, 2025, at 12:30 AM, Eli Zaretskii wrote: > > > >> From: Daniel Colascione > >> Date: Sat, 29 Mar 2025 14:17:15 -0400 > >> > >> Not sure whether this is a bug or just surprising design, but in this > >> code: > >> > >> function Blah(foo) { > >> const foo = 1; > >> const bar = 2; > >> } > >> > >> with point on "const foo", I do not expect end-of-defun to go to "const > >> bar". I expect it to go to the closing curly brace. > > > > Juri and Yuan, any comments or suggestions? > > I pushed a fix for it. Maybe my message got lost? Or maybe I missed it, in which case my apologies. > Though now that I think of it, I should’ve pushed the fix to emacs-30 instead of master... Yes, please backport to emacs-30, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 01:54:39 2025 Received: (at 77369-done) by debbugs.gnu.org; 4 Apr 2025 05:54:40 +0000 Received: from localhost ([127.0.0.1]:36749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0a0l-000444-Gq for submit@debbugs.gnu.org; Fri, 04 Apr 2025 01:54:39 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:54394) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u0a0i-00043p-Gh for 77369-done@debbugs.gnu.org; Fri, 04 Apr 2025 01:54:37 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2295d78b45cso21769565ad.0 for <77369-done@debbugs.gnu.org>; Thu, 03 Apr 2025 22:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743746069; x=1744350869; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5CULNB0f9PFfzrlvHZmDubNw3a1B835uaH217RD1jRM=; b=QsZGRI+Znh5azsutwa5utLw17VCkpZeRwGADdUJGh2x/u8yW2zGY41zisBXGokJrNB AlRQ9lMdpIQR2hqnp5guek1GaEPBXBYaFZ+9CWQ6VCEfEQ3NvmYFelLhnrIb1F8Qjo0B VFASSap4JZPi9YNihZwOOY9wZPKqtPJ61WBlNzmxoP1FVZW+wtA3Vpdj4mL8DEQFSMdl 6Ag2zRZqS64Xjb0mBAlX4rW/orneJLnJvnBMYNjC4H1r5mNjmvSX/7DWhQcgnILGcWq1 swF8iC02yuDC1wnI2B5sRuTH/pBjfrHKMCQWs4BYRUZQpB6Nry4JVB+h30TEXW/mVyUj qErA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743746069; x=1744350869; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CULNB0f9PFfzrlvHZmDubNw3a1B835uaH217RD1jRM=; b=dp3oQKNw/65D4z8r1f1lUzxEQCCATgal/8jefEyL/EMJQo9RrczIL12hABEgyc2Sk6 HnaezOIPExuQc+9r7Dxy+dbZt0U8Et4j+jtMXus7B+LNEK1q4J9EmpQlua5meLOrc0dW hn4vf0ob1O/i/gcHlYP0jewufTQREj/PHa1gw4LD80tCIpJGMubkpacvsOsEBCLLQmyZ 85DiD9dMfjJzdZsZIhwIhPupM96lyErxPj0nyizqgALmDJhwGmPMtoxdncJqB+jbAzD6 q2Rt+7nF8N4z0KBU8pEuhM6O1MiB7u15kZ9uJx8hVNkXZXIEBs2Dr9bHvhO/T0F5Ut8y soKQ== X-Forwarded-Encrypted: i=1; AJvYcCVEdAq8MNIdVQBQCiwfYvHLw2KhDhZn7x1gg1YdnT0nMGW/D6mITpBef8AHrTnJXrGzeu9CxbN9YA8j@debbugs.gnu.org X-Gm-Message-State: AOJu0Yxlb65L7me2F+D7kzA4p23abba/3iHVcpbjGf4N63+76laOuO0W pufEo0rPlSIFjoNVDDxWcW45q4RcZxJHKqBDQdMYp+GX8ONMAdfG X-Gm-Gg: ASbGncsupWuYsTRFKOq8DHEMv5v93C9H09kBE+HIefRKNW2g5dDZ7B8IkgPmLd0D7eD XQ8i3Ug6Zj4VuyrmGNpg0sKrVK6rtKmaGjiQBcUsoCJNgPh5OeUOj0H89CU6gXi17JGgAgRQY8O xbrsss08EGbKOqg+hDWfGWqLq/spoK/0E4ERde0kRemwuSlXcr9R3JzvAAu1PPjyKKvCKK9jCMm tGgUyhds3WWG1T/PXUxAqOiVr2evw44uxdzuR5DZjs8eeoc2pb2T01ToREEsdIHUT5ChNFay1Xt rMk74hy25vwSdg7yoUWWWjFcwuB2A7rhOCHjrJD8q7YSH6KcgiZ0HZFE7Ni/ybSvYu6q X-Google-Smtp-Source: AGHT+IHJCZQD1KubFXsfrT4YWO499fFbdGndc2cm+MkONxdet+WgeqBFCenhDc3eqTHS9RvlESIbbw== X-Received: by 2002:a17:902:e890:b0:224:1001:677c with SMTP id d9443c01a7336-22a8a0429c5mr24850505ad.9.1743746069319; Thu, 03 Apr 2025 22:54:29 -0700 (PDT) Received: from smtpclient.apple ([2601:646:8f81:6120:743a:d29c:3bad:267e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-229785ad0c9sm24394705ad.12.2025.04.03.22.54.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Apr 2025 22:54:28 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: bug#77369: typescript-ts-mode's defun definition is wrong From: Yuan Fu In-Reply-To: <86jz81znie.fsf@gnu.org> Date: Thu, 3 Apr 2025 22:54:17 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86plhtzoqc.fsf@gnu.org> <883B3D5E-2D37-4435-BDCB-8B9511B3DE72@gmail.com> <86jz81znie.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77369-done Cc: 77369-done@debbugs.gnu.org, dancol@dancol.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Apr 3, 2025, at 12:56=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: Yuan Fu >> Date: Thu, 3 Apr 2025 00:46:04 -0700 >> Cc: Daniel Colascione , >> Juri Linkov , >> 77369@debbugs.gnu.org >>=20 >>> On Apr 3, 2025, at 12:30=E2=80=AFAM, Eli Zaretskii = wrote: >>>=20 >>>> From: Daniel Colascione >>>> Date: Sat, 29 Mar 2025 14:17:15 -0400 >>>>=20 >>>> Not sure whether this is a bug or just surprising design, but in = this >>>> code: >>>>=20 >>>> function Blah(foo) { >>>> const foo =3D 1; >>>> const bar =3D 2; >>>> } >>>>=20 >>>> with point on "const foo", I do not expect end-of-defun to go to = "const >>>> bar". I expect it to go to the closing curly brace. >>>=20 >>> Juri and Yuan, any comments or suggestions? >>=20 >> I pushed a fix for it. Maybe my message got lost? >=20 > Or maybe I missed it, in which case my apologies. >=20 >> Though now that I think of it, I should=E2=80=99ve pushed the fix to = emacs-30 instead of master... >=20 > Yes, please backport to emacs-30, and thanks. Cool, backported to emacs-30. Yuan From unknown Fri Aug 15 03:38:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 May 2025 11:24:15 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator