GNU bug report logs - #77361
[PATCH] New user option to hide minor mode lighters

Previous Next

Full log

Message #37 received at 77361 <at> debbugs.gnu.org (full text, mbox):

From: Pengji Zhang <me <at> pengjiz.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 77361 <at> debbugs.gnu.org
Subject: Re: bug#77361: [PATCH] New user option to hide minor mode lighters
Date: Mon, 05 May 2025 11:18:27 +0800

Sean Whitton <spwhitton <at> spwhitton.name> writes:

> Hello,
>
> On Sat 19 Apr 2025 at 06:08pm +08, Sean Whitton wrote:
>
>> Hello Pengji,
>>
>> Thanks.  Making this customizable sounds good.
>>
>> A couple of comments on your patch:
>>
>> - It doesn't make sense to add an additional NEWS entry because the
>>   whole feature will be new in this release.  So you can delete that
>>   part of your patch.
>>
>> - Ideally the name of the variable would start with mode-line-collapse-
>>   instead of mode-line-collapsed- in order to match the existing one.
>>
>>   May I suggest mode-line-collapse-minor-modes-to ?
>
> I've installed it using this name.  Thanks again.

Sorry for the late reply. I got a bit busy with my day job.

I like this name, and thanks for installing it!

As for merging the two variables into one, I guess you might have
noticed it, it is not easy to do. 'mode-line-collapse-minor-modes' could
take a list of symbols to select modes to hide, in which case I could
not find a clear way to specify the lighter string.

Best,
Pengji

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.