GNU bug report logs - #77361
[PATCH] New user option to hide minor mode lighters

Previous Next

Package: emacs;

Reported by: Pengji Zhang <me <at> pengjiz.com>

Date: Sat, 29 Mar 2025 11:09:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Pengji Zhang <me <at> pengjiz.com>
Cc: Jonas Bernoulli <jonas <at> bernoul.li>, 77361 <at> debbugs.gnu.org
Subject: bug#77361: [PATCH] New user option to hide minor mode lighters
Date: Sat, 19 Apr 2025 18:08:44 +0800

Hello Pengji,

Thanks.  Making this customizable sounds good.

A couple of comments on your patch:

- It doesn't make sense to add an additional NEWS entry because the
  whole feature will be new in this release.  So you can delete that
  part of your patch.

- Ideally the name of the variable would start with mode-line-collapse-
  instead of mode-line-collapsed- in order to match the existing one.

  May I suggest mode-line-collapse-minor-modes-to ?
  Or mode-line-collapse-minor-modes-to-char ?

  Or could we get away with just one variable?
  mode-line-collapse-major-modes can be the string to use; a value of
  't' means to use ….
  Possibly renaming it to mode-line-collapse-major-modes-to-char.

-- 
Sean Whitton
This bug report was last modified 14 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.