Subject: Re: bug#77361: [PATCH] New user option to hide minor mode lighters

From: Sean Whitton <[email-masked]>
Date: Sat, 19 Apr 2025 18:08:44 +0800

Hello Pengji,

Thanks.  Making this customizable sounds good.

A couple of comments on your patch:

- It doesn't make sense to add an additional NEWS entry because the
  whole feature will be new in this release.  So you can delete that
  part of your patch.

- Ideally the name of the variable would start with mode-line-collapse-
  instead of mode-line-collapsed- in order to match the existing one.

  May I suggest mode-line-collapse-minor-modes-to ?
  Or mode-line-collapse-minor-modes-to-char ?

  Or could we get away with just one variable?
  mode-line-collapse-major-modes can be the string to use; a value of
  't' means to use ….
  Possibly renaming it to mode-line-collapse-major-modes-to-char.

-- 
Sean Whitton