From unknown Thu Sep 18 18:06:28 2025 X-Loop: help-debbugs@gnu.org Subject: bug#77354: 30.1; `finder-commentary' could call `help-make-xrefs' to generate links Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Mar 2025 08:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 77354 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 77354@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.174323564032678 (code B ref -1); Sat, 29 Mar 2025 08:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Mar 2025 08:07:20 +0000 Received: from localhost ([127.0.0.1]:56638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyRDs-0008Uz-G0 for submit@debbugs.gnu.org; Sat, 29 Mar 2025 04:07:20 -0400 Received: from lists.gnu.org ([2001:470:142::17]:57274) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyRDq-0008Ul-5a for submit@debbugs.gnu.org; Sat, 29 Mar 2025 04:07:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyRDj-0006mh-TM for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2025 04:07:12 -0400 Received: from smtp-4.orcon.net.nz ([60.234.4.59]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyRDh-0005yp-1l for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2025 04:07:11 -0400 Received: from [10.253.37.70] (port=37218 helo=webmail.orcon.net.nz) by smtp-4.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1tyRDT-0002vd-Qo for bug-gnu-emacs@gnu.org; Sat, 29 Mar 2025 21:06:55 +1300 Received: from ip-139-180-92-114.as55850.net ([139.180.92.114]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Sat, 29 Mar 2025 21:06:55 +1300 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 29 Mar 2025 21:06:55 +1300 From: Phil Sainty Message-ID: X-Sender: psainty@orcon.net.nz User-Agent: Orcon Webmail X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.59; envelope-from=psainty@orcon.net.nz; helo=smtp-4.orcon.net.nz X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) If `finder-commentary' calls `help-make-xrefs' then we'll get buttons/links to the relevant Help and/or Info nodes in the rendered Commentary, which would be a nice improvement. Can anyone think of a reason not to do that? Before Emacs 29.1 this was prevented by bug#41836 as the links would not work outside of Help buffers; but that's been fixed, and experimentally the idea seems to work as desired. With that bug fixed, I was looking at making `so-long-commentary' invoke `help-make-xrefs' (and changing how I'd formatted the info node references to match), but I realised that I'd get the same result if `finder-commentary' did it, and other finder uses would benefit besides. Shall we install this?: modified lisp/finder.el @@ -388,6 +388,7 @@ finder-commentary (insert str) (goto-char (point-min)) (package--describe-add-library-links) + (help-make-xrefs) (goto-char (point-min)) (setq buffer-read-only t) (set-buffer-modified-p nil) -Phil