GNU bug report logs - #77349
[PATCH] gnu: Add emacs-yari.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77349 in the body.
You can then email your comments to 77349 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-yari.
Date: Sat, 29 Mar 2025 10:00:33 +0900

* gnu/packages/emacs-xyz.scm (emacs-yari): New variable.

Change-Id: I16a5be5ceef46a4d8cb036e1c06994d1b5513a33
---
 gnu/packages/emacs-xyz.scm | 41 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 72f8a8f415..39ac71dc07 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17295,6 +17295,47 @@ (define-public emacs-yaml-mode
 behavior very similar to that of Python mode.")
     (license license:gpl3+)))
 
+(define-public emacs-yari
+  (let ((revision "0")
+        (commit "de61285ceb21f56c29f4be12e2e65b2aa2bccf56"))
+    (package
+      (name "emacs-yari")
+      (version (git-version "0.8" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/hron/yari.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0sik21rifw0q1rw4wrffnnwynsmgrv6w323gz3fw89cz6n8kqsgn"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #t
+        #:test-command #~(list "ert-runner")
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'set-program-names
+              (lambda* (#:key inputs #:allow-other-keys)
+                (let* ((package (assoc-ref inputs "ruby"))
+                       (ri (string-append package "/bin/ri"))
+                       (ruby (string-append package "/bin/ruby")))
+                  (emacs-substitute-variables "yari.el"
+                    ("yari-ri-program-name" ri)
+                    ("yari-ruby-program-name" ruby))))))))
+      (native-inputs (list emacs-ert-runner))
+      (inputs (list ruby))
+      (home-page "https://github.com/hron/yari.el")
+      (synopsis "Yet Another RI interface for Emacs")
+      (description
+       "@samp{yari.el} provides an Emacs frontend to Ruby's @samp{ri}
+documentation tool, and offers lookup and completion.  The main
+function you should use as interface to @samp{ri} is @samp{M-x yari}.
+@samp{yari-helm} is a variant using Helm input framework.")
+      (license license:gpl3+))))
+
 (define-public emacs-gitlab-ci-mode
   (package
     (name "emacs-gitlab-ci-mode")

base-commit: c31662f7294b194663bc521358b01c3a7d7e4e27
-- 
2.48.1

Message #8 received at 77349 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: gemmaro <gemmaro.dev <at> gmail.com>
Cc: Cayetano Santos <csantosb <at> inventati.org>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>, 77349 <at> debbugs.gnu.org
Subject: Re: [bug#77349] [PATCH] gnu: Add emacs-yari.
Date: Sat, 29 Mar 2025 07:49:18 -0700

Hi gemmaro,

gemmaro <gemmaro.dev <at> gmail.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-yari): New variable.
>
> Change-Id: I16a5be5ceef46a4d8cb036e1c06994d1b5513a33
> ---
>  gnu/packages/emacs-xyz.scm | 41 
>  ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index 72f8a8f415..39ac71dc07 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -17295,6 +17295,47 @@ (define-public emacs-yaml-mode
>  behavior very similar to that of Python mode.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-yari
> +  (let ((revision "0")
> +        (commit "de61285ceb21f56c29f4be12e2e65b2aa2bccf56"))
> +    (package
> +      (name "emacs-yari")
> +      (version (git-version "0.8" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/hron/yari.el")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 
> "0sik21rifw0q1rw4wrffnnwynsmgrv6w323gz3fw89cz6n8kqsgn"))))
> +      (build-system emacs-build-system)
> +      (arguments
> +       (list
> +        #:tests? #t
> +        #:test-command #~(list "ert-runner")
> +        #:phases
> +        #~(modify-phases %standard-phases
> +            (add-after 'unpack 'set-program-names
> +              (lambda* (#:key inputs #:allow-other-keys)
> +                (let* ((package (assoc-ref inputs "ruby"))
> +                       (ri (string-append package "/bin/ri"))
> +                       (ruby (string-append package 
> "/bin/ruby")))
> +                  (emacs-substitute-variables "yari.el"
> +                    ("yari-ri-program-name" ri)
> +                    ("yari-ruby-program-name" ruby))))))))

Please remove the let and use `search-input-file' here.  ex.

   (emacs-substitute-variables "yari.el"
     ("yari-ri-program-name" (search-input-files "ri"))
     ("yari-ruby-program-name" (search-input-files 
     "ruby")))))))))

> +      (native-inputs (list emacs-ert-runner))
> +      (inputs (list ruby))
> +      (home-page "https://github.com/hron/yari.el")
> +      (synopsis "Yet Another RI interface for Emacs")
> +      (description
> +       "@samp{yari.el} provides an Emacs frontend...

@file is probably better than @sampe here, but I’d go with "This 
package provides..."


> +     ...to Ruby's @samp{ri}

Should be @code, not @samp.


> +documentation tool, and offers lookup and completion.  The main
> +function you should use as interface to @samp{ri} is @samp{M-x 
> yari}.

Same feedback about @samp{ri} here.  @samp is correct for "M-x 
yari".

> +@samp{yari-helm} is a variant using Helm input framework.")

Are you intending to package yari-helm?  If not, please remove the 
mention of it.

Thanks,

 -- Ian

Message #11 received at 77349 <at> debbugs.gnu.org (full text, mbox):

From: gemmaro <gemmaro.dev <at> gmail.com>
To: 77349 <at> debbugs.gnu.org
Cc: gemmaro <gemmaro.dev <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-yari.
Date: Sun, 30 Mar 2025 08:01:18 +0900

* gnu/packages/emacs-xyz.scm (emacs-yari): New variable.

Change-Id: I1caca3772efff15d2155fdc5eaf648100bed1895
---

Hi Ian,

I have updated the following items in the patch:

* [arguments]<#:phases>: Updated to utilize search-input-file.
* [description]: Revised the description to begin with "This package
provides...".  Utilized @code for inline ri commands.  Removed the sentence
regarding yari-helm.

Thanks,
gemmaro.

 gnu/packages/emacs-xyz.scm | 39 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index a633bf76b1..b5dc07acbb 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -17323,6 +17323,45 @@ (define-public emacs-yaml-mode
 behavior very similar to that of Python mode.")
     (license license:gpl3+)))
 
+(define-public emacs-yari
+  (let ((revision "0")
+        (commit "de61285ceb21f56c29f4be12e2e65b2aa2bccf56"))
+    (package
+      (name "emacs-yari")
+      (version (git-version "0.8" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/hron/yari.el")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0sik21rifw0q1rw4wrffnnwynsmgrv6w323gz3fw89cz6n8kqsgn"))))
+      (build-system emacs-build-system)
+      (arguments
+       (list
+        #:tests? #t
+        #:test-command #~(list "ert-runner")
+        #:phases
+        #~(modify-phases %standard-phases
+            (add-after 'unpack 'set-program-names
+              (lambda* (#:key inputs #:allow-other-keys)
+                (emacs-substitute-variables "yari.el"
+                  ("yari-ri-program-name"
+                   (search-input-file inputs "/bin/ri"))
+                  ("yari-ruby-program-name"
+                   (search-input-file inputs "/bin/ruby"))))))))
+      (native-inputs (list emacs-ert-runner))
+      (inputs (list ruby))
+      (home-page "https://github.com/hron/yari.el")
+      (synopsis "Yet Another RI interface for Emacs")
+      (description
+       "This package provides an Emacs frontend to Ruby's @code{ri}
+documentation tool, and offers lookup and completion.  The main
+function you should use as interface to @code{ri} is @samp{M-x yari}.")
+      (license license:gpl3+))))
+
 (define-public emacs-gitlab-ci-mode
   (package
     (name "emacs-gitlab-ci-mode")

base-commit: d17c20911361844ff6479704d3e26bef8f73aa5c
-- 
2.49.0

Message #14 received at 77349 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: gemmaro <gemmaro.dev <at> gmail.com>
Cc: Cayetano Santos <csantosb <at> inventati.org>,
 Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>,
 Divya Ranjan Pattanaik <divya <at> subvertising.org>, 77349 <at> debbugs.gnu.org
Subject: Re: [bug#77349] [PATCH] gnu: Add emacs-yari.
Date: Sat, 29 Mar 2025 17:12:52 -0700

Hi gemmaro,

Pushed as 953ec15324.

Thanks,

 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.