From unknown Tue Jun 17 03:38:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77323 <77323@debbugs.gnu.org> To: bug#77323 <77323@debbugs.gnu.org> Subject: Status: [PATCH] Allow temp buffer cleanup in ediff-current-file Reply-To: bug#77323 <77323@debbugs.gnu.org> Date: Tue, 17 Jun 2025 10:38:56 +0000 retitle 77323 [PATCH] Allow temp buffer cleanup in ediff-current-file reassign 77323 emacs submitter 77323 "Paul D. Nelson" severity 77323 normal tag 77323 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 17:54:27 2025 Received: (at submit) by debbugs.gnu.org; 27 Mar 2025 21:54:27 +0000 Received: from localhost ([127.0.0.1]:51642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txvBC-0004td-H6 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 17:54:26 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60124) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txvB9-0004tQ-Jr for submit@debbugs.gnu.org; Thu, 27 Mar 2025 17:54:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txvB3-0007Ol-TU for bug-gnu-emacs@gnu.org; Thu, 27 Mar 2025 17:54:17 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1txvB2-0004hG-0a for bug-gnu-emacs@gnu.org; Thu, 27 Mar 2025 17:54:17 -0400 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-aaecf50578eso254586066b.2 for ; Thu, 27 Mar 2025 14:54:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743112453; x=1743717253; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Os76LRMUmokI6zD2LQp8Vx0Cvi1uA8BtVKCnM2qFzfs=; b=VCO7rtd7UdOuFu/FjhxupkAnKxADc6acigwF78HF8EyI24b5DSEXWKOxDIvZ9iJV8A rnfsBEfr0x382736dm4H0JTWaUw2LVAmW4nyu2LhokvW4qSgkCaZ7aSLSusiwjhqJ9hK n7p6gGumi2S87QKZKmzB5tWWSFoocZgc3b7PSU6tHqYZnr3XL8S1lfuDkNYdj0taD1qc NzW6KBJhx9JGJt6WMQooSzcOMRqP2RIGPFYvxOLNj/3T6o23RCzlcXg30HCVEHAscSw5 WPhbO96hlgLb7tr2N390bzwunMwlsh6Hd+zjzF+HELIbbgC5raFWYDH84G6QRaU8CVZx Z/cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743112453; x=1743717253; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Os76LRMUmokI6zD2LQp8Vx0Cvi1uA8BtVKCnM2qFzfs=; b=AESegHQCk2xtizlhE/hHk+bit0KWGl48Xi/BY7c88BC7K3yVZcdRKA4hpHm2D7QBU0 OXRLTLRrPMclvIbK/2/LAivq57uRmhRNarlf/X4JIRzwYemosSu/V+nPeltagLXGubgo DGPK+udVW5juDHrPtaHH8PvwUDjkQ3m2uN+wEvxo1KSR2dAqy/XMmkBnj9QWnOHWpVyd aatd37K49zbQcsT6fIdfoI4ThFwZn0preiSZGXySEa0sxuprbfnkXgnxudCeujTnB3vz NfYI8uNGTsUHLAfxCC1/tHiStoWdKqZoQJBg03N9p3FL283tYXpWGSffQzI+HH2YjoFi wwhw== X-Gm-Message-State: AOJu0Yz89FTwEMECqz/69ahdYlqEBamrLlCzZReGsAC5CnPlXUICeI7d V8eWb+7uEO/QOWyD5+W6G5gvNimw0G+W32DUU5d1pKuR/DZY2Ynwnrll+gZ3 X-Gm-Gg: ASbGnctkmGv9dVekIKJrw15+0nxS+Qgiqet/qtAywWuKD0oS0YAk1DqiMps0/0JfygH 3l/gq1kr7Kn2gPZ3R3Pyes55XCztz/tCrmyM5A6f5WAstQSWClLT3crGZ4Giem0q/ouGcdzGYwT xkZv/vNHA+WNzfbURQIkrklZuegVfm9WH/DdFDJrNMW4649qRZIHTPkrP4wR9Bv6yKOIJDx1RgZ Kuj7GIKGSKMM62OdSBB6NJJesz+OymQYV9wNXian/25D1AfXuOsi994gNBVpBn4pyVtYaSVcK4j cNaPj1mU4is0p3kEo8uUVidj14d7bKwZ0M3Zyge/kpVvidmaiCg4V24tUEiq6VzH X-Google-Smtp-Source: AGHT+IGc2TrYHIE2hoInN1uZD9mgTPTANoCuJ2C8vKPvn4f4tniWifkUlLQSZRYs0BU+XvmjRzYEgw== X-Received: by 2002:a17:907:1b02:b0:ac2:9e1a:bf81 with SMTP id a640c23a62f3a-ac6faeb12edmr508314766b.21.1743112453049; Thu, 27 Mar 2025 14:54:13 -0700 (PDT) Received: from localhost ([130.225.16.16]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ac71927b205sm58953166b.60.2025.03.27.14.54.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 14:54:12 -0700 (PDT) From: "Paul D. Nelson" To: bug-gnu-emacs@gnu.org Subject: [PATCH] Allow temp buffer cleanup in ediff-current-file Date: Thu, 27 Mar 2025 22:51:57 +0100 Message-ID: X-Debbugs-Cc: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=ultrono@gmail.com; helo=mail-ej1-x62d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain When ediff-current-file compares a modified buffer with its saved version, it creates a temporary "FILE=..." buffer to hold the saved contents. Currently, this buffer persists after the Ediff session quits, requiring manual cleanup later. In my experience, this buffer serves no further purpose once the comparison is done, and just clutters the buffer list. On the other hand, I could imagine someone using it as a way to retain a snapshot of the saved file state. The attached patch introduces a user option that, when non-nil, causes the "FILE=..." buffer to be killed automatically after quitting Ediff. The default is nil, so that the patch does not modify existing behavior. Such automatic cleanup does not seem achievable via existing Ediff hooks. Any feedback would be welcome. Thanks, best, Paul --=-=-= Content-Type: text/x-patch Content-Disposition: attachment >From c0a6429b5672f43114d7d67e268f31998723071d Mon Sep 17 00:00:00 2001 From: Paul Nelson Date: Thu, 27 Mar 2025 22:00:08 +0100 Subject: [PATCH] Allow temp buffer cleanup in ediff-current-file * lisp/vc/ediff.el (ediff-current-file-cleanup-temporary-buffer): New custom option that controls whether to kill the temporary buffer created by ediff-current-file. (ediff-current-file): Use it. --- etc/NEWS | 5 +++++ lisp/vc/ediff.el | 15 ++++++++++++++- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 1bd2fd6d486..7fbd6f830af 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1199,6 +1199,11 @@ is non-nil, this suffix is fontified using 'font-lock-type-face'. ** Ediff ++++ +*** New user option 'ediff-current-file-cleanup-temporary-buffer'. +This option controls whether to kill the 'FILE=...' buffer created by +'ediff-current-file' when the Ediff session exits. + +++ *** Ediff's copy commands now apply to all changes with 'C-u' prefix. The Ediff copy commands, bound to 'a', 'b', 'ab', etc., now copy all diff --git a/lisp/vc/ediff.el b/lisp/vc/ediff.el index 36580c73d6b..401c6e2c119 100644 --- a/lisp/vc/ediff.el +++ b/lisp/vc/ediff.el @@ -359,6 +359,12 @@ ediff-files-internal ;;;###autoload (defalias 'ediff #'ediff-files) +(defcustom ediff-current-file-cleanup-temporary-buffer nil + "If non-nil, kill the 'FILE=...' buffer created by `ediff-current-file'. +If this option is non-nil, the buffer is killed automatically when the +Ediff session ends. Otherwise, the buffer is preserved." + :type 'boolean) + ;;;###autoload (defun ediff-current-file () "Start ediff between current buffer and its file on disk. @@ -395,7 +401,14 @@ ediff-current-file (insert-file-contents file-name) ;; Assume same modes: (funcall current-major)) - (ediff-buffers revert-buf (current-buffer)))) + (ediff-buffers revert-buf (current-buffer) + (when ediff-current-file-cleanup-temporary-buffer + (list (lambda () + (add-hook 'ediff-quit-hook + (lambda () + (when (buffer-live-p revert-buf) + (kill-buffer revert-buf))) + nil t))))))) ;;;###autoload -- 2.39.3 (Apple Git-145) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 21:08:50 2025 Received: (at 77323) by debbugs.gnu.org; 28 Mar 2025 01:08:50 +0000 Received: from localhost ([127.0.0.1]:51988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txyDJ-0000h7-P1 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 21:08:50 -0400 Received: from mout.web.de ([212.227.15.4]:39491) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txyDF-0000go-7M for 77323@debbugs.gnu.org; Thu, 27 Mar 2025 21:08:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1743124118; x=1743728918; i=michael_heerdegen@web.de; bh=QeudkDihHbl9Q+d+5fJTgoh6jwo5bqEke8aG/xg2X+4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=Ir8QEwxmt1Yh08IK9DnxnGxmd3N//p8UJ41g2Cyi9dZBAIbElk1NqOgD2NxgnQSw PI28bGD+n8Vy4+P0jKbguvNrMABXBjsWvz6XkV3aXtwzFEg+sWzc7zDVnUMxNrzT9 E+pMLA9ijRGGcpxvk2DUSrei19btdCNbWU0rkhhuYgXycYpKpZG6vvcDsu8qXkb13 Ll7W7cWi0uJ6zGLaFtq46QKQXiUbWUogLM42S1Pg0UhmMpCxlPAmXb+14xF1C2GHQ 4pe491SuVUATCNsvIvT9AM4MxO+AexQkgkss0YDtfUdfAVIjjhWVWJwAXynMPZaiY ocV0y2ur1N+t7xq5sw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.136]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MMGu2-1tfkKu1gyU-00NApA; Fri, 28 Mar 2025 02:08:38 +0100 From: Michael Heerdegen To: "Paul D. Nelson" Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: References: Date: Fri, 28 Mar 2025 02:10:09 +0100 Message-ID: <87h63e7yfi.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:IlW9fxO6ngkFjkW86Uv2kk1bj5/cSIGIYlUX1pE9RSiv5TLujh+ WPGI50ofCkQN2mmJ9fEnvC0mQid8nvEgyBjLSumPqOE9iRRtMNU/xn/PJTC9A95S3lgfogm Y1RCzi14caTH50njLZpppjB1KtGk7hHPvcSeOYygTtbQkj5t20kab8Mw9yUNjz6FFWBwOH7 aO4FQB85yKZTKB30mjuqA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:R1DkizxsLxM=;Iwc8N41LCSTEY6fqIQHI9INMiUg IT4KjOnLZsFJMHz3hDGv24l+lH+gKq7hA5KZeuJgLOWXnuMty4AT96iaaZsaswLAYAAfCVmoz zMx2tidmu05kbwXld3kmn8+e6xtggwOFPGEh9uWW0sF4KqOC6YgL/Ino8A/S4EXfkj7ARBmIC O+RrRyekkzkH7Lnyt00g0CgBNv3RJrThVEo/MXO33evcf7Y8tDHD+gOOqItKnC4EjExcluuNi kwW/ZHsvJDZSmGb0s2BL1avf4Qh0iB5wUTJQeW0yjS2Z+EbhP+/fo0tbB0iyUVtEPSLq4hmMi y2xt7cChT3SbaKrRSi19N2l7UDFQSY6tcc1Jx7ghkUFOXl5iEh5x6HxtltEfcNKt4mnJCDLUw jDchshHvRTNJtqPdcouxeVilUpgKtxsYKbVFAziA9KVnGEfd3rgWLxuU+3Td56g0wBedAvMA1 bhGGVZ6luwAvn9ZJIc7k0jCj25fkwyKYEqX7NlEHaKjmXLPpMN9SY4Oyi9s8mj6WLOESc4x/j 06lvVm+uU+wnQ8AKcxmmlihW1TZx6sX+DRN4B4F4GV4HugQM+9aH9vjKoyO7fgLKpnS0QOsqS e8rFgCPd76syUI0RxSphv+pcdqvF8NLIWMJTPvi2LrUQJCX/vQozXaIjk2mFZjOk8WJFE9kUM S/3QLeUy4K/6FncEUXOjvYEpfVQLTNrQfTqTtu+ZwrM3Vi3t1CA+nZbTT+UNa2aqK17KoSomK xsiJXtWFWzPRLxG6B/oi7QMsZLlqgvKdK94WthIzi1UoJ/fdjIXKOUahGpKZG/Od/xp7wn8y3 6Y98vz1YgvS8ilNlLpaBS/316egVHkflkpcvrWHHUjEtSHtV0jdApGjlb+vvilro7maP5HJJv DpjNhf7IvH3H3vY3+o3kl/poMjk8DERc9TSOOExY66N3qMh3c54icNnew1Yj6I0x82nZEaJJV tttqCYtA+7GfoJwpQRquKHUQP8LgKNhjkNV3R4un4VZfpnnwB50dYaSLX+vRCqpQ2nkmLunae Dyf6Tg6yAKEnJzZI55ZHx9xko5pxY0QTviRu3FmfEXdnP/MM+NHfyVpcDwQGK2+Evsc1ECQrq SalplGo63JPYmhq+4oBDUHKz+LxUQKHeXQm4rKE0dyDsLZb3Ju5zqqf3SVM4sgAB5TIUrQDLy f/AOLCguR9HIMmeyJiRHhpY29PmPi6JwBXNEjvbL3H0kfZ6sdqJbY4fVfQ5N5GASwMVumHqTq Q/vPeAA4jjf6bSd3fBDRvjYrga8ycE3weskZSPrk1eJhgPYbcAHca+cQ2YSs12vICWgU9XViV 8M8gedToJCMUv477eqg68tAVd85Dbb4TCZCcrHx7Yvvn0g+6TGGzQLLOK6Zbbfj2VWvsSLFjL q3MnUO9VDH7aQvR501jsaUJn7FXPt8p9VUaEGALWlsA0c2pa6GEU356yMS+kP40wrYQGGutHT +OcINLbo+xa6RWK3tfgQeDImU21I= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77323 Cc: 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Paul, > When ediff-current-file compares a modified buffer with its saved > version, it creates a temporary "FILE=..." buffer to hold the saved > contents. Currently, this buffer persists after the Ediff session > quits, requiring manual cleanup later. I wonder if this related to Bug#74881 whose fix makes Emacs delete temporary Ediff files. Does your Emacs version contain the fix of this bug? Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 01:39:25 2025 Received: (at 77323) by debbugs.gnu.org; 28 Mar 2025 05:39:25 +0000 Received: from localhost ([127.0.0.1]:52417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ty2RB-0005F0-0g for submit@debbugs.gnu.org; Fri, 28 Mar 2025 01:39:25 -0400 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]:46130) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ty2R8-0005Ed-5g for 77323@debbugs.gnu.org; Fri, 28 Mar 2025 01:39:22 -0400 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e8be1bdb7bso2874904a12.0 for <77323@debbugs.gnu.org>; Thu, 27 Mar 2025 22:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743140355; x=1743745155; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=Ph1+ejDZTFCW2VowDhOy2T0aT0lx9OgU5ixpy3wW3w4=; b=jD3Vk9MmOfRTf17x7eW51rSPt6GeKoRA8ABS5mM4rK2tOgKjphuCYxt+XWYNTx90OY nskTdNFACpU/e2FuLIbTv+Rv+6bcqmnky7xi8B1tIvmfMVe9BBTVV43po6ZkgXXbJIHc EcOi4+p6XdaQoeN/mrVW6TmyYnZ/U9pgUY94c2v85S2CtjZK2F5BVLkh8V2oo1XD4IKo ZLXwmR4ebNQbV2/5XAi8wOzOiv5Y/d2gItdhHf5OKxZxzrJK0uyiAu/ddiOvkc2Xbp0m En0xlZAmbMETuqXeZoTQhVMffh0Auh7/WxvJB9J447uKGsFfN8ZSzVunAIHg8iHJ/c+g zMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743140355; x=1743745155; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ph1+ejDZTFCW2VowDhOy2T0aT0lx9OgU5ixpy3wW3w4=; b=NhI8kIhV5YWIiRbTcC40GDg6uGGvRy99AYA7wSFyvZ8VaPcRPdt/maMR6ED4ktAbue dn8LkboU87thZ9RlZZgb5t1yHAJP/tfX35CJCz99GT0K0kEWZBzgiBEaUt+YZuKB/8eB 06ha2ZV5hCxyBalaieczF410XsEw9LvD0Gz9mrl71Fj9UfWst7Wpyqa3HbBpCS5RV/Cq 2lGjkgv8XwrTpOYteDUUki8KJlyGWGxeut0RI5PA40H75AZX+XQLsW3Mllr+j2aPofH+ wHrYC+Y6czSshg3kOGvg6vitgplUm7uXLEUQqqDyQhc+lWvKCtMiEpD1jyJDhuiI5YFd /vnQ== X-Gm-Message-State: AOJu0Yyfx5keTrSL3Cw+9P9ffeP9SO2ycjyT8U5tw9rsv2X/7ZLIJ+or ILCUC18eXwKa9atjr5dyntyUSaIaHPzSbCKhLY8T5CCKsYKgALxfMlhJdQdOjLo= X-Gm-Gg: ASbGnctWmyasLI3y+YBQCqb839PDj6Xfw2h6gnqIEPAhWhW6tcJsQGuSyAdg2lNKU/E SzZ1kPN1cFh8D1HjSPEUzYdEHe8oxrYlRqAzKo+XlIazyvHwIaQ+vGbr/hQLTxvUSBSYFR8DsGc iDgXByApzigY69KrVF2U0l004xBLQwzUBlOCFRLovU0xBAhaI8M+54KBNO2Rf12MPlYfIW4z5By HBjnRMWQ/qL+5nTbLvCFxMezd7UCcVkTCAQfnNJnKMKxXlWjJnQc1Mgybq6QmrFQY/Efscgbr3V d01lE/Cgni0bF5btNlLMbNsod2uVZS7/MNwzZ8Y4f/zHiURRQ74RuUBfB0iamHGmYQxq1O02Hfr KOL5nkgZVZG6h0lqqZLs+ X-Google-Smtp-Source: AGHT+IFfOilXZDwfm/6xvbo6/u2QwtuPipxkvIvCW+1yRVn+sjmjxTNpo/tuwviXqtzCALCN8DjCVA== X-Received: by 2002:a17:907:3d92:b0:ac3:c7c6:3c97 with SMTP id a640c23a62f3a-ac6fa7e7335mr610562966b.0.1743140355040; Thu, 27 Mar 2025 22:39:15 -0700 (PDT) Received: from localhost (0x573d6713.static.cust.fastspeed.dk. [87.61.103.19]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ac71961f8c2sm102300866b.105.2025.03.27.22.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 22:39:14 -0700 (PDT) From: "Paul D. Nelson" To: Michael Heerdegen Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: <87h63e7yfi.fsf@web.de> (message from Michael Heerdegen on Fri, 28 Mar 2025 02:10:09 +0100) Date: Fri, 28 Mar 2025 06:39:13 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323 Cc: 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Michael, > I wonder if this related to Bug#74881 whose fix makes Emacs delete > temporary Ediff files. Does your Emacs version contain the fix of this > bug? Thanks for checking on this. Bug#74881 seems to be about deleting temporary files (produced by vc-ediff, I think), while the present issue is about cleaning up temporary buffers produced by ediff-current-file. Incidentally, my version (updated yesterday) does contain this fix. Paul From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 21:06:26 2025 Received: (at 77323) by debbugs.gnu.org; 29 Mar 2025 01:06:26 +0000 Received: from localhost ([127.0.0.1]:56033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyKeY-0005Vj-Gs for submit@debbugs.gnu.org; Fri, 28 Mar 2025 21:06:26 -0400 Received: from mout.web.de ([212.227.15.4]:40587) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyKeV-0005VU-NY for 77323@debbugs.gnu.org; Fri, 28 Mar 2025 21:06:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1743210375; x=1743815175; i=michael_heerdegen@web.de; bh=+o+tkOLbwUMZTauL6c13fFlNXWC5LS/axR+DErYHHOY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=vx4Duf0FQfsVd11U8wharPKYKA9tuqxE3JHGb0HH8nRYJ3emJWi9c2ehHYevnR9X mMNCMjWHuNMtY1hBQZA/WoXxbl1olWZfRB7MSv7lcPYiLSf+oaMOm1G7H5hUMKw9l 7C4VBt69p7K32ZQOq5zxS8XptrUBx7Trsyt/dewBQ5FSieAR5ML0OB//5l/mh10pN r39mwMK9tCqfcK2/wW2+Sl7ITCSKs49AvyepilgMwnPljf1ZgDI5dWN5UUEoUHuVs xOnxW5pC+n0m+GIbNDtBSAa7sIO/7oNP8aX+KG8EGW23knax518nmg21CRZSar2XI +qNiwhRGjld5C8AaQA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.136]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M7usw-1u2CGq3auA-0001GM; Sat, 29 Mar 2025 02:06:14 +0100 From: Michael Heerdegen To: "Paul D. Nelson" Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: References: Date: Sat, 29 Mar 2025 02:07:46 +0100 Message-ID: <87cye0tzj1.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:w2ZrIUaKpvonSE5YLQ5ACD8IgcxfmXSIDHPRaipvF9FVWwtZfW3 2cjeSeyWQE5E7FecYrdgUhkE+WVKP8dfGul8h4MEjs5gn5+xEc+7zTO1AdNv1sQ/H4vEMmY RijzLXU19V3Q9LvnD7M3HYCyteLyJN+5MwNbX5P1AZWev88p7n3cBWOzvIEQiN5z3lVYFog x3A7Q++BKqOjw9jdRoMVA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:1YbCBMNMbfc=;iKRixNkj9Cz7Bq7t4i5KbxZM0tg 82SYVAqWsxcX57FHpGHjUL7XR5JKt/Gb+ASHKUPH5UPi7ROPWVEdYItqA42kp3yu3dfUckfH3 PtuPSpxQM6QedbzKke6vqF03jYpyeFrWWBK2p1+FfKyALe8a3z4snboUmV97BHb85L2rOyBSA i0wUeIha4rI85CQFfNCpn2KJc+lpIhT8PLy3k8YQC4sId78ntpae9Y85NUetEHObo4RrMeS/A KI7+lQxWrwSLq53orKEmdMRJ0DE4yJXU90u0NUb9xla7UKGQhWqmg8wYHcm1xijx5JjVF20UL DPsiJWEFUr7QMU4U/IOtd3JU9Yx8eOMOvsjNMtYFghRDdnipTZAb1AXtYo3RKg6lQYAoW57RZ sHZcDxTXnUlbD4BctWImc8Y7HD8B3iVREu40eqpdJ37g9ox1bdJSzPfZl6KX7zlaUPR4Ww1Ph /Rhw03nSAycDQAzKeFQSiWf136gfeZhB6B8gqitdL4LjZi2Vy6qOsLH5ydniII0nS7+ixNWXJ pPbXo5S3f0wjbssEwniN2cPRJF8GKuevC9b/ifL1NTVoFkyL/vob8ZV2q1g8d0AHNi/9YwZvo 3RxgLIKOGzLl0+W6qKcZze7f5WExAzXYZbGEWFGxyAjerScIeM+DPl7yczaLi6GQ8f0Vqz2E6 Zq/76DX+K35nrnOjuwUSvz8A5s6Y2uW+UL7N19m3kT5sJSBnG9CaPKnMU3bNKvI5dSzLVdipc ZSoqcsmuR5gx+lPlgzh5U/MN8j2tVJy8YHji/X37xMT5G5iLK21Wuv/N1Jf3P0VlrMy6GWZPc N0MrTHlFBDEd5Pa0QoPqmrOfIeElVGMZj4C3dMnsh+t/X27MrWWs7xPmm5gNDWMh3LGDk0C0q Tq9YEuAcVq80ngNRPDZB/Syyzc5+LVzUijTXbigMW20zhAnprWiIRP88ktDUpYy9ffelTTeEb ESzM0a33J8ofyvXqR0ZKQmdM0D6yrttyd7nWcEk5juBvXjqXEM1Q6FM9pReiOLdilvWIuVf/X bi2kcueZYsYxaxBjQhaQTnhtar6QDjDrSO458dnJ3nuRgJIPADV2b7Nd6tyCJAAcYXITLUvAC kIgBHvxBfppN8h+KMKJmdYc5gpnCbgRa4XPCB0BS5HqjxKMpqWwQHcGaBUSZ2ZvPoLk5kz3Be BB2gCyiRVZfcfgVm4lhvuzEun1NdGg9DhROmMbFyxEVTVqftD5Nb5fp0pmbDQSqGI5i3tfqrz 3r9nl+DFgJKfccwNLemskymREB0cCu7xHxRsRU9sZiyijZKbjK3EC+MqSAX5pUnu3Y4ETDzcQ X1zegb2oakDuP6TMnoli3bfwsOvXnXqE37HsdDrsa/PPFuitF2ZPsRoT1HKXmhtt7hqwob54+ qu1gK+kttOIWlSNA35zbWZvaG4WDoNvNeYBiWUYnEyqZfBEguvOAAUjGH29qDG3JBICLYaO2B q4fNZCWhsZov44btet8nLCfLpIIE= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77323 Cc: 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) "Paul D. Nelson" writes: > Thanks for checking on this. Bug#74881 seems to be about deleting > temporary files (produced by vc-ediff, I think), while the present issue > is about cleaning up temporary buffers produced by ediff-current-file. > Incidentally, my version (updated yesterday) does contain this fix. Ok, thanks. Then your proposal looks reasonable to me. Allow two questions: - Have you thought about checking `ediff-current-file-cleanup-temporary-buffer' when quitting Ediff, instead of when entering Ediff (with other words: in the lambda you add to `ediff-quit-hook')? I think this would fit better with the expected behavior. A user might toggle the new option when the Ediff session is already running. - Is this the only Ediff command that leaves such temporary buffers behind? TIA, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 04:29:44 2025 Received: (at 77323) by debbugs.gnu.org; 29 Mar 2025 08:29:44 +0000 Received: from localhost ([127.0.0.1]:56692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyRZX-00018S-RH for submit@debbugs.gnu.org; Sat, 29 Mar 2025 04:29:44 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:57480) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyRZV-00018D-G7 for 77323@debbugs.gnu.org; Sat, 29 Mar 2025 04:29:42 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5e677f59438so4446952a12.2 for <77323@debbugs.gnu.org>; Sat, 29 Mar 2025 01:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743236975; x=1743841775; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=pQd+dM6V+QlAof+IZ9iMEDrg75a6OXCydeN+70e3pv4=; b=Aw3+rweQQkYW7HqWXmbry8F47FsOQQ7rBItox01z+8avVcjbjWEgGG54PC538+IxPd qsvobl3lcoBVNSwgmF+GyiBwL1P5SqQO54b79wov8HNPX9D+5LRUgnfWvnYApiFfGPjH Q/P2VPL+6yUDpgQaE2oI/I8PIUqgW7GpFa9ARi22pK9iTcWZfgqT/x/Wjg9eeEjm8huB ZpcRBkQWdFFk6d82e9LqzBq0hSjSJI1Jj9q5Wuf49mQs39pK0m5WUyQYiuVxKuoq/RBk 7ts0UfoQXKwNalbku8hc80PSZvJbDxQx228nDTfySJ9QprX8NlGcjOe80v7kWEtsrDBG w5fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743236975; x=1743841775; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pQd+dM6V+QlAof+IZ9iMEDrg75a6OXCydeN+70e3pv4=; b=KIdZh8Mquj4CFRM5/hjqGKsSjicowpcsn9rylnkKLtzg01VHIdgwhO5+S7lQg4xkUV eobaKyT1tjlygIDsJeud2OFgu2nc+jm+P9u/m1YW+8JE+j/z+iq6CPT6oe/SSOmUxlk8 YCH/KKvv1SvU33T+39NQ9vK1LLWKEGE1qGIqugsnk/pRxuWVFOKm0KwhE1t6l8yu5V6k stwnM0zkv702Py0VQenseOvNCNJsRZIi31glmXQKwqsJNIxqJSJWSCQMJ2ZSCiYhcLy5 wPt6zOKLtTjR5T2SPsx1NY9YCAJ9OusQMZT9YrtLQ6M84wtuvOoaUUkMNoKGaMrZ3/D0 qM0A== X-Gm-Message-State: AOJu0YwBbNii3PDKNhEczBC3Gsn9fjeCD4+ThfOn4eSPya4z4wTrOgte qbotzqq9xRH3ZAGDGAKxX8grAqG+ciN8/GOFge8qGyFXXqCvg1ai X-Gm-Gg: ASbGncu/Aq4/0zFOPj6TnBoXEDm0guCHDMx/6c3BN4uRyMNnHGegqfqdfXo3J0ZTcwd /xjSVqFN3j7lXxLD0r/NI2qDRg+4nipPFPQYGh7bdH2kSqFlzEIUAK3aSPcfgHM18ccFH4TCPUK 16Tn+Qs2OzeC0jD44pIXM2lKLHXlfCkegVf03D8s/Kng9yCpiIZ0JHi64cY1T4U0/5r7RajtliY KvBwKB08Z2PZY6SWNcow9D+gzhAjZo8xbEjrOwjHUtu1kZ4ED3EaJF7ccAJ2LYs+OxRUvpvhl/Y /5pq8alHtpkq/CwY2WkhiG7B5qiF7e8/uJoOMw2hd9+uZQ6Ez0lBRVHdooWgPvvcV4clNWEHp/5 UaXSD/PH8Mw== X-Google-Smtp-Source: AGHT+IEbSGhwPDQp5WiqaCb9lAqFTQry3IUfbc7YXegXhuANhv0ARVCYFDMnkM7DiOihgLZpre/D0w== X-Received: by 2002:a17:907:86a2:b0:ac1:fa91:2b98 with SMTP id a640c23a62f3a-ac7389d0bcamr209321766b.14.1743236974820; Sat, 29 Mar 2025 01:29:34 -0700 (PDT) Received: from localhost (0x573d6713.static.cust.fastspeed.dk. [87.61.103.19]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ac71927b184sm301435866b.51.2025.03.29.01.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Mar 2025 01:29:34 -0700 (PDT) From: "Paul D. Nelson" To: Michael Heerdegen Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: <87cye0tzj1.fsf@web.de> (message from Michael Heerdegen on Sat, 29 Mar 2025 02:07:46 +0100) Date: Sat, 29 Mar 2025 09:29:33 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323 Cc: 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > - Have you thought about checking > `ediff-current-file-cleanup-temporary-buffer' when quitting Ediff, > instead of when entering Ediff (with other words: in the lambda you add > to `ediff-quit-hook')? I think this would fit better with the expected > behavior. A user might toggle the new option when the Ediff session is > already running. My reasons for "checking before" (basically to allow let-binding of the variable) were less compelling and specific than what you describe, so I agree that "checking after" is more natural and have updated the patch accordingly. > > - Is this the only Ediff command that leaves such temporary buffers > behind? The other Ediff commands that create buffers are: - ediff-regions-* and ediff-windows-*. These create indirect buffers that are cleaned up when Ediff quits (via ediff-temp-indirect-buffer). - ediff-patch-buffer. This creates a buffer *_patched with the result of applying a patch to buffer *. The persistence of this buffer is intentional - it allows the user to inspect or save the result. - ediff-patch-file. This applies a patch to a file, creating a backup (e.g., ediff.el.orig), and leaves buffers visiting both files. - vc-ediff and vc-version-ediff. These create buffers like ediff.el.~c0a6429b5672f43114d7d67e268f31998723071d~, which can be created by other VC commands (like log-view-find-revision) and are reused across calls. In each case, the buffers either visit files, are cleaned up, or are explicitly intended for further use by the client or other commands. There is also the option ediff-keep-variants, for which nil means to ask to remove any unmodified A/B/C buffers when quitting Ediff. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Allow-temp-buffer-cleanup-in-ediff-current-file.patch >From 7279b700cd9e95f7c1a6c3c193a1438358233496 Mon Sep 17 00:00:00 2001 From: Paul Nelson Date: Thu, 27 Mar 2025 22:00:08 +0100 Subject: [PATCH] Allow temp buffer cleanup in ediff-current-file * lisp/vc/ediff.el (ediff-current-file-cleanup-temporary-buffer): New custom option that controls whether to kill the temporary buffer created by ediff-current-file. (ediff-current-file): Use it. --- etc/NEWS | 5 +++++ lisp/vc/ediff.el | 16 +++++++++++++++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 1bd2fd6d486..7fbd6f830af 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1199,6 +1199,11 @@ is non-nil, this suffix is fontified using 'font-lock-type-face'. ** Ediff ++++ +*** New user option 'ediff-current-file-cleanup-temporary-buffer'. +This option controls whether to kill the 'FILE=...' buffer created by +'ediff-current-file' when the Ediff session exits. + +++ *** Ediff's copy commands now apply to all changes with 'C-u' prefix. The Ediff copy commands, bound to 'a', 'b', 'ab', etc., now copy all diff --git a/lisp/vc/ediff.el b/lisp/vc/ediff.el index 36580c73d6b..f7e3be2384f 100644 --- a/lisp/vc/ediff.el +++ b/lisp/vc/ediff.el @@ -359,6 +359,12 @@ ediff-files-internal ;;;###autoload (defalias 'ediff #'ediff-files) +(defcustom ediff-current-file-cleanup-temporary-buffer nil + "If non-nil, kill the 'FILE=...' buffer created by `ediff-current-file'. +If this option is non-nil, the buffer is killed automatically when the +Ediff session ends. Otherwise, the buffer is preserved." + :type 'boolean) + ;;;###autoload (defun ediff-current-file () "Start ediff between current buffer and its file on disk. @@ -395,7 +401,15 @@ ediff-current-file (insert-file-contents file-name) ;; Assume same modes: (funcall current-major)) - (ediff-buffers revert-buf (current-buffer)))) + (ediff-buffers + revert-buf (current-buffer) + (list (lambda () + (add-hook 'ediff-quit-hook + (lambda () + (when (and ediff-current-file-cleanup-temporary-buffer + (buffer-live-p revert-buf)) + (kill-buffer revert-buf))) + nil t)))))) ;;;###autoload -- 2.39.3 (Apple Git-145) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 06:33:22 2025 Received: (at 77323) by debbugs.gnu.org; 29 Mar 2025 10:33:23 +0000 Received: from localhost ([127.0.0.1]:57061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyTVC-0008Ax-Lg for submit@debbugs.gnu.org; Sat, 29 Mar 2025 06:33:22 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:34822) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyTV9-0008AZ-RS for 77323@debbugs.gnu.org; Sat, 29 Mar 2025 06:33:21 -0400 DKIM-Signature: a=rsa-sha256; b=mp11X/q2FXnLOE7Q7QuZBRLr+B+8wdDWUWoMipMfa/Qzmr66wugh1IEode2z2wRpgVIER0MPQToPr8Zzn7OUGuTCbm9JaoewxhgQXwML1vQ8vgJYWGgjJsmFWWD9JjRouKBfw5iaUq2LG9MiVOxjZ7ONz4sqB6RmVNPMHoJSHXBCYM7ESvjHSx4yvLic/CpilsxstPKqKL+wHPXdo5TQKDsTXSQfPh9UefR37vmogQm8JU9wX08/9zMO2RgdC6HQ7mbcpq1QjjGG7wezCtz+6HXLh/alkWSDMbKcsBhbRlG7+WiB3/6NU4t+a7H98QSAKmwMK5PoT9wqSxHJK6kquw==; s=purelymail3; d=spwhitton.name; v=1; bh=daD6JTBAikv6hL0miakx2503qsCh5oc5Q1jK0nlzDGs=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=CMaUGpTYaXkq2N49HPVsonvFUwDN5uAOSd2y731WaXUsS5CGhlYlOK5VzXBz8WoIah0Wr8SZbUUTAekeGLOc0slW4StgDy1a4ftsXhEEVMjGbfEXD/hFy1ljdLNsfDeNVKHu/zWBEYE32lwa5ReYSuG/Shj3+iLosDyp16m1MZRv3t3EYviSUzcDpmWIocWD8Kbyd3vp9PGb0OK1WaGDRXwBDFRGjpgVs/czrd91NShFDuU9sZ/J1r2v7se3iM6EYZROmETZoeAlqTpA77EQJ++2ORPE9lmCz4C8hFueNmzgxikw/a9+HeXKhxsYtm6CFqFztXCYrOmPecapNY6Dlw==; s=purelymail3; d=purelymail.com; v=1; bh=daD6JTBAikv6hL0miakx2503qsCh5oc5Q1jK0nlzDGs=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77323@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id -1888726584; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 29 Mar 2025 10:33:08 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 111CF7E0578; Sat, 29 Mar 2025 18:33:05 +0800 (CST) From: Sean Whitton To: "Paul D. Nelson" Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: References: Date: Sat, 29 Mar 2025 18:33:05 +0800 Message-ID: <87ecyg2kke.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323 Cc: Michael Heerdegen , 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Paul, There is also already ediff-keep-tmp-versions. Even though some are about files and some are about buffers, I'm concerned about these variables proliferating. It's already quite confusing. Do you think there is any possibility of you reusing one of the existing ones? -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 08:46:37 2025 Received: (at 77323) by debbugs.gnu.org; 29 Mar 2025 12:46:37 +0000 Received: from localhost ([127.0.0.1]:57463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyVa9-0007He-68 for submit@debbugs.gnu.org; Sat, 29 Mar 2025 08:46:37 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:44517) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyVa5-0007HF-LI for 77323@debbugs.gnu.org; Sat, 29 Mar 2025 08:46:34 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-5e6167d0536so1923871a12.1 for <77323@debbugs.gnu.org>; Sat, 29 Mar 2025 05:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743252386; x=1743857186; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=/mGcQ/CAIqqRa/f3ioQB10HWcF0UKiwymM5c65OrPB0=; b=euq61Hc3gyBpF/ZEsk8lQ0twOgxo0e/g72vQqc199Xpg9RAnlgKZ+KqpJ3HO7NBXo9 PmqkYb2K0w7RIJeGlZTRItuOu/7A/5jB8bRQDRExSD2Eb6Scs2S4CIzoCkAdHb8t82jr ii/UmArhDcDzQ1LlY5k61eoIDYnr4t+txRJJK+n9hBqyWfNL1fOZwhQD1wMs+jNQZ3M9 ZX6jfB3tIY4jcnGd+V4dBDbqYH1hK+0v7lEprH1N4sPed7ipzTVtXqfP/Swep3zzj5kZ zHv1EPA6CiJqWC2bnl2I+kxW7m2yZ+9ovOSqU3P8/F5BtBZ4XG23HM3ExCHgGJ5vHI/1 ymBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743252386; x=1743857186; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/mGcQ/CAIqqRa/f3ioQB10HWcF0UKiwymM5c65OrPB0=; b=Oo6WDHon0/ciFAn0AfL8GNtsNQvVnzPWcHtEEFrk0sdDEVhx3u7vCOcKKvQyEt2Zmn ZXJUfEXY4AYvcfbPUONdUEersSmN8HFk4vwM+yuzHfkF3no44fq7di7J377rTqfrgGio PhRA8OmK/6f4CqB9iMsMVpIcUpfl4ruNXJTaPF2OyKdE3+thfJDMS2v0A/dJYKR+zs2W iNd9uKl2VQ1rLKi12tTN/G0Dr5tQUVOSC973WzN9ea+6mM2l++K81Nr3JnO5GeeWJetF KpSwuVFgNLK2XXey+1cJrYkI6mYPALg76JupRPqLa70977c31gTIPCOCX0kG1ohKedyc x2aQ== X-Forwarded-Encrypted: i=1; AJvYcCUBu1EznRTsT7IwciJKUOWjgeIMrqKf7y718u+XxqV4QxBaccJny0ADSn0uo7zCJM9/rID/ng==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz605t+zgMAo8VFZsovgurutVP9kerxfEz8A1tZ31p7Mufw+GyT RW9o8lzG1GY97TwLQOoirCs1vAqUh8AUPrgFkIpogE2m3JSy28Fi X-Gm-Gg: ASbGncsFB1nWPy3s71mVCgEPNYZQk81hefaFhMTWEpn1RkW5u9D9LeqrC2jrZ6OPtOP iFSkpdCYYdX2rVlsUaf8ytnw5/+AGF7w5064mq3D87+9cZmEDDaNJ4T7+u73r5sTenZW6D9D0WC l9lTZgk9atwNSZ/AB5+XyejLZr/QwzMVpSQcxKeKE6Y3hzH5tY0IlzLcCsQEhP6lVu4NMDVeh0P V7YgtPDp1f0gAhK0fv1CAAgoyjFkuuq47wQ19lMSJo/NbTgS/3/04spSLR90yQvIZZzlsDjN+dP F1c/PtHwv/JFZtNsLtzu3Zx62Ov8TerDW33FOiMiM9Y3BKFZRjVIh6ZepLN0UBn7/7NZPm0wfYp oJg/UqzbR9Q== X-Google-Smtp-Source: AGHT+IEWo57wbefVOxyfnZkfmPfCefNlC5ARPTNKlHG3vQ47AktvcPIZrLuxe79feSyiuggIPiBeJw== X-Received: by 2002:a05:6402:3490:b0:5e4:9726:7779 with SMTP id 4fb4d7f45d1cf-5edfcc1f72fmr2468147a12.2.1743252385721; Sat, 29 Mar 2025 05:46:25 -0700 (PDT) Received: from localhost (0x573d6713.static.cust.fastspeed.dk. [87.61.103.19]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-5edc16d475esm2926376a12.28.2025.03.29.05.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Mar 2025 05:46:24 -0700 (PDT) From: "Paul D. Nelson" To: Sean Whitton Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: <87ecyg2kke.fsf@melete.silentflame.com> (message from Sean Whitton on Sat, 29 Mar 2025 18:33:05 +0800) Date: Sat, 29 Mar 2025 13:46:22 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323 Cc: michael_heerdegen@web.de, 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Sean, > There is also already ediff-keep-tmp-versions. > > Even though some are about files and some are about buffers, I'm > concerned about these variables proliferating. It's already quite > confusing. Do you think there is any possibility of you reusing one of > the existing ones? Let's see. I think it would be confusing to reuse ediff-keep-tmp-versions (which concerns temporary VC files) or ediff-keep-variants (which is anyways hard-coded to "t" via ediff-buffers, hence in ediff-current-file). I understand the concern about variable proliferation. Some alternatives: 1) Make "clean-up" the default behavior for ediff-current-file. 2) Add an optional startup-hooks argument to ediff-current-file, passed along to ediff-buffers. This would improve consistency with other Ediff commands and allow clean-up of temporary buffers via a wrapper command: (defun my/ediff-current-file-with-cleanup () (interactive) (ediff-current-file (list (lambda () (let ((buffer-to-kill ediff-buffer-A)) (add-hook 'ediff-quit-hook (lambda () (when (buffer-live-p buffer-to-kill) (kill-buffer buffer-to-kill))) nil t)))))) 3) Take advantage of the "FILE=" prefix, which I don't think is used elsewhere in Emacs: (add-hook 'ediff-cleanup-hook (lambda () (and (buffer-live-p ediff-buffer-A) (string-prefix-p "FILE=" (buffer-name ediff-buffer-A)) (kill-buffer ediff-buffer-A)))) Having now stumbled upon solution 3), I think it's the simplest one for my purposes, if a bit hacky. It makes my patch unnecessary, so we can close this report. Alternatively, if others feel that the undeleted temporary buffer produced by ediff-current-file represents a bug/issue (e.g., as an undesired "resource leak") rather than an alternative among preferences, then I'd be happy to follow-up with either my original patch or one of the other proposed alternatives. Thanks for your feedback and best, Paul From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 21:53:40 2025 Received: (at 77323) by debbugs.gnu.org; 30 Mar 2025 01:53:40 +0000 Received: from localhost ([127.0.0.1]:33685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyhrn-0000wP-OW for submit@debbugs.gnu.org; Sat, 29 Mar 2025 21:53:39 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:36996) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyhrk-0000w9-Ag for 77323@debbugs.gnu.org; Sat, 29 Mar 2025 21:53:37 -0400 DKIM-Signature: a=rsa-sha256; b=sW75VbA1NOJkVicQChzmIurFnvziX9DR8QZemeONjEBxWJNEPYArbWFsR5TvsPlqShM7vaIT6Y//ntj7a6kfJRKCiQXdrgzfxAwQbMO+5oO1quO3SKgNg+RiwXfTQkysywEb+zC2juYXcCBzuVbppLiyziy3XN9H+1W91badF23uZ3UcBmU2R3YPtBTudERZxQmVBDTcSR7WuLqk0PeUJc6pILHWRKT714t8Z+2mq68FOEGLsSuV8KbvXRcVkSVoCNC2fUGJYJqickp0CsnC2CG45thkZqpjVIE68zwlYlionXvFuKtmybO/Pb3vKha8akShk+9fxZ+y14RIbeli2w==; s=purelymail3; d=spwhitton.name; v=1; bh=HrBMWO/UkAEJeqj+8lThlQIIqDUvr4UByQcdAsOxgrE=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=G1YgXlCv65JEIq2aNoJZ3U5uDoEaRNRfgPCF7rf19LP9fsEVF6OCJzScZZWhQ66Y168S1r7azFRvcksPeHL/TdmN+qKTMmNjIc2TFJ8R3cfcP53orKUe6t5yoz+zzc1oSBNqn6tefd88UQYBs/OE8O5DQw91QBqDAMkw6cddXv4ESK5mXNixzURFZzWELHJ0ZxMURGO6WdJMtgfsUK1v503TVhThWF2DBv1ObGsyiKnfRWJf9quuZen/m8S+DXkX8h8X/P75OHJak2vuxdireLkORRrmabSHPkxuP27dD+iHA0K0nhgk44r/0x0xb1hC5dclRFfCJhOxfLPG+oB3Dw==; s=purelymail3; d=purelymail.com; v=1; bh=HrBMWO/UkAEJeqj+8lThlQIIqDUvr4UByQcdAsOxgrE=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77323@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1909824346; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 30 Mar 2025 01:53:29 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id A242E7E0676; Sun, 30 Mar 2025 09:53:26 +0800 (CST) From: Sean Whitton To: "Paul D. Nelson" Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: References: Date: Sun, 30 Mar 2025 09:53:26 +0800 Message-ID: <874izb2six.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323 Cc: michael_heerdegen@web.de, 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Thank you for looking further. Generally we don't worry too much about unkilled buffers. Given that you have a solution to your original problem and there is the problem of all these variables, I think we should close this bug, but I'll give Michael a chance to chime in first. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 30 23:04:29 2025 Received: (at 77323) by debbugs.gnu.org; 31 Mar 2025 03:04:29 +0000 Received: from localhost ([127.0.0.1]:38842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tz5Rs-0001Oi-4I for submit@debbugs.gnu.org; Sun, 30 Mar 2025 23:04:29 -0400 Received: from mout.web.de ([212.227.15.14]:40169) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tz5Rj-0001MQ-FK for 77323@debbugs.gnu.org; Sun, 30 Mar 2025 23:04:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1743390253; x=1743995053; i=michael_heerdegen@web.de; bh=Uc7cpy7IpkhehXw2rPTSuUc1Y0JF1u3F47D3DdKW2h4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=kTiHcvIJYVFmiCzHcyVCWXSsmkkDGSPqP8qioI7FnhVMrM3l17MjNt7GCjVOBu1E QkmVEm8S0StwSUtBF0H5XfQtsBxLmAFMUKNLBLM2H0e4TcYVwQZwok0bhD0nDHIbW j0INL+hbuc9E1FR9zh30HTb8pfNKKWJW1lPwIatXZR5BhAEbY20QLUaIhhXnL6dkP Kh6w5OSSnjWJH8FR/xj7msQb+y1tWnewFke14VJrok6+Jm1HWqQxS71QlG0PCPcIp m/PRwoOBJaoixFwbLhurY1/fbQjWBF8ZwW45PInwldfb/MDqKLiqijudT7eXCmaLa oMTbljGdzxAJpivpsA== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.230]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1N0Zns-1tE0fg3aUO-00sDXS; Mon, 31 Mar 2025 05:04:12 +0200 From: Michael Heerdegen To: Sean Whitton Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: <874izb2six.fsf@melete.silentflame.com> References: <874izb2six.fsf@melete.silentflame.com> Date: Mon, 31 Mar 2025 05:05:39 +0200 Message-ID: <87y0wldhmk.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:VSB6vSLcGnKEbh2JYLxRqcKCUeuWtiPck/J/op5c1aBMuq6v9YE setjRoGvAaSc4IvIr7q01BbxgTbCO960X9wIfLs4AIw+bThkacC/9FCMG2/xyIfrrWQobCv 6LzrdkkDGci95VQiNcMMVXHiiq9pPvyOnof3LKZ+Whuu9yidIZE98RlA8tfaILeVlalUqYU edBfMcxLCRw3qe/CyooRA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:DKp6bAZKsXo=;njnW6GFMkTMrGnOD7vr4lMD5K1Y YJB+L/naujOsl4Xg1wsJXVXeNOEFIVw5ZehR+lm/PBYKOAsbZ6JP3zAsI3fXN0DWveya92Ckq oMrp1buLmipFhnenuZ3KwHe3CTjgxvk1XxgxUiTiq4Y2rZQ/cXxYe+WcQN8UmCZs9l55iX5oY ozQyt3EHVw3JeeAATtsWpXqdcsCpivOKsvCXwh+FdG/rYcOHho5OC8ml7DugP/dYGQajcdhHi Q2eA0OFHXmUc0LuOgxVr0Fbanq9yIMe1Xw7tSU4+xdcaY6TDQvZeTUCdppvrtvAN8kJsHqRax zxk+YY7dXLC8gPyMOGy9PQoE2/VUvvjNIWhNELpGQXplKZUUcXhnkJ/s8mUVJd5HJDiB6xLlu Y/IPgIct2FTOASXpxA+lkpDve3Weex6cQbv4LCfeKebLET8c4IOVQzOJRLN9G2giFqHq46VXe 9F1nMaR3xga4M4xwnng/bMLO7pfQdnJlpddnZWe8R4rsQ+HTsR7QsaTwV8TP124NXILmi6bu9 PMJ+nD2GYJSzXZ3XKfUbNZGOOs9rHdkjgGy2koEAgGFmsinQXNlQvuG2PEpHMtt1P+0wsYqkZ 6fXQm2ykAiYXRP+Vsamn/BQ4no2xw6eaQqCc3eqOvUz4nmEzesyW6KDsWl+PoBMQbj8rp0ykq 3CwiAOy9gxmRyvAesxqzKVWpyWZPUEu6T8a6MCzEhvsmVpeQfGZMZs9DTagNCdWfu09V0hcZi hJCdHpeLOA1LVJPeF9dz5pJKP0j9YMCVB6yJiGP924aJNxVE5GFpsY4InfGJy3YS3jfB40rpp uStK4RughEAy4TM6NQ+r50D8YgDdca5JDJQ17KfZzu9g8HZOXkeD9a+Lx4adf2PM24yPF2nSP pnO6fb1x5aHzkA0HFuqMNkMze9+fZ4FdUSUlN/4BsddNiZMri9Ul/VyQtEx80uFPpQFG/h7ji DAalsyaK2UhTqaOq1WzKwZa2MInrLJ0Gs1uvnA5GMpjMDwqYs6/CV9WVxFTl1+vuFFkFVKI55 LTR+N4+O6SjMZSsal/u2qowxXTJmIVfdnzCShLLaZo3gPDpYOsZD3biqZT+usjWoKGRy/Qr71 19nrfIo1JJoWCLo05MuCBOXSZbP1eEpgyj8qxS+7IZrjdOsmZoZw9EVeL7o2S69VIA/UeBLaj YTce3GEQM5KXA0aikdjYn3+2a25YNM8XJHxqpLIkyXsVJCz5csPLWirAaQB4VQR/x4peoQ/0d aqhsKLkFv7hx3jvKZMsz9iru8tu95ssifUn9NWEPozQ6Gxz93OHxX5kuEHJd4nlms89jmQLKq yymbfQunpSGOrocgDXUy1XwaAxDN12RXVW3XI+K2kNGYNf+3GeyP/PMbK+icZySM7F/V8DB6K pDay6qQfozgYtCCBg14+KRKKzWFl09DvR/byRvH5toJaxAxc6oJ1YjAN3Hg9uec+vGriRKP9F WDaxSVHtl6s7Ez78lpCvC9WI90Go= X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 77323 Cc: 77323@debbugs.gnu.org, "Paul D. Nelson" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Sean Whitton writes: > Given that you have a solution to your original problem and there is > the problem of all these variables, I think we should close this bug, > but I'll give Michael a chance to chime in first. I'm not a heavy Ediff user, so don't take my words too seriously. In general the whole Ediff thing is partially quite hard to configure, in my opinion, if what you want had not been anticipated by the author(s). This here is not the only case. My thoughts here are: we should consider that the buffers we speak about (containing the saved version of the file) might be useful to some users. Maybe equally useful as other buffers we silently keep. Apart from that, this case doesn't really fit into any other case that handles automatically created buffers. Although - `ediff-dispose-of-variant-according-to-user' is not only about indirect buffers, right? We could marry this case with this existing mechanism. Would that make some sense? And apart from that, adding a STARTUP-HOOKS argument to `ediff-current-file' looks acceptable to me, although it would have no direct uses in Emacs currently. I don't like it when users are forced to use really bad hacks to change the behavior of such cases. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 31 03:07:18 2025 Received: (at 77323) by debbugs.gnu.org; 31 Mar 2025 07:07:18 +0000 Received: from localhost ([127.0.0.1]:39434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tz9Es-0005q7-3Z for submit@debbugs.gnu.org; Mon, 31 Mar 2025 03:07:18 -0400 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]:49439) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tz9Ep-0005pC-OC for 77323@debbugs.gnu.org; Mon, 31 Mar 2025 03:07:16 -0400 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-5e6c18e2c7dso7616436a12.3 for <77323@debbugs.gnu.org>; Mon, 31 Mar 2025 00:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743404829; x=1744009629; darn=debbugs.gnu.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=eDEqdHEy3khpj41Rexh5TkDWOSJ/XbzTVKi+6XAE+q0=; b=PiuOEGrixYqxcQtTntMUhA5Pir1Vnj4j6wNB/0JGYtdRzSfu0QmbNCVKQLuFU8xlhS LOnUAbMMLQ8Z7Yo/SyiozyYs6kd3/Zo9iZf9ja82icJgQjAUhhzSdBDpqCcdE6l9DuzC W2iTXgFzN9wtwHgR0tXH5/ZcS4NOndbiNMuz+RktHUYMBWeA+Py9ZrCfqJBCvAe0mCsC 7cM9UsvdNWvgQaEkxxyt3l5YoJ45tPL8pGXad9VlGV4RmZl18mXPr9RUgPeeq1+k2Y6G 9xMoFvqLj+gy+FWsgSzrLL2NTV5Evu7y5qL7NnDpCl6pWnBv2ZLfaZyDNF8i6xj/Otln FYfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743404829; x=1744009629; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eDEqdHEy3khpj41Rexh5TkDWOSJ/XbzTVKi+6XAE+q0=; b=wh9s14fUHs9TqMFrN57kkEVScIRzP26iaQg4+rk2s9aA2APD5HLijAX50VajEmgku3 9pbIxv+9Wc8W7To/aTF8KFTSd5/Y3Q8YICs42NkBTOyvl+1Qx7yydzlbBl4VLPgKFp51 MCPJgQNcO3aOpl7I/CPqAspkhfv5m4kWZUJuziyXTfF6Yo7SNJPy8jMA7h4Nr1nbIFxI SGHmiJyYk3pq5rbCzQUt6cs0glB+RTChl+q0fuJKUL+whPCsvK+AJ+IgvBxMvh8WxBLY FAFolulLdbJ9eHwhkCbaup93+2h4rfcvZDS12ID8gbNBXMCvBZFLQeRXw232+AQEtlFm HggQ== X-Forwarded-Encrypted: i=1; AJvYcCUASfXMPnIaacrJXIpy0nVVOVY8mrT+gUPb/RQggbK/rHTI5/oYukhR9/Ga5nZGnyRxDMruBg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzG08w0LUn7DKL/TFNCKrIGjbHG13LM/SO1C54PdBVr9BT2ocMr 1ku21a7XF0F/mf0ZoBJOjUULznMknHHDw+4gQxXduhrLmh49yJRb X-Gm-Gg: ASbGncsNCfTINO1DB6cFsE7YVl6Tnztw7LpBb+h6JtHrJMjrESVmo/PzvDtGfRT5cFL y5Nul4+p2lh/KGzjwOYxPBQFYxLJxuXNbGjEY1BV7OraG7uciRjsvxCnLUGGTQEv3PK8Sw8t6ZD owrWDKJPP9a/aPatl4cgcBqmv6JxxvTeRxfPdi3XoAkvoLcIBwDjgQZ9entOA06/ArgbjJyrQZK wRe9Nan5iDqxVkdclby/y7KFA5Yqp66F86HHoQ8oHNnAuj7KfAljgnydWrBI4jvMEsoXPqCbD7w 4H5zy1gXBifq53WWzilffUNmziY9fWE5W+vuKAUWHTIsWW5sHoHNNZxKAjUNFVHRkFF+yL9c6Yo km9zYfz2CYA== X-Google-Smtp-Source: AGHT+IGtFWVb2oZoOpOMmdBzNoyafPTVnbbhqkv76/3Jd1A4CNW/mT6kboJs3ryukdQWAml3qriVJw== X-Received: by 2002:a05:6402:34cb:b0:5e4:c119:7ff8 with SMTP id 4fb4d7f45d1cf-5edfcbd22c4mr7177009a12.4.1743404829103; Mon, 31 Mar 2025 00:07:09 -0700 (PDT) Received: from localhost (0x573d6713.static.cust.fastspeed.dk. [87.61.103.19]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-5edc16ed61esm5220262a12.34.2025.03.31.00.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 00:07:08 -0700 (PDT) From: "Paul D. Nelson" To: Michael Heerdegen Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: <87y0wldhmk.fsf@web.de> (message from Michael Heerdegen on Mon, 31 Mar 2025 05:05:39 +0200) Date: Mon, 31 Mar 2025 09:07:07 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323 Cc: 77323@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > Apart from that, this case doesn't really fit into any other case that > handles automatically created buffers. Although - > `ediff-dispose-of-variant-according-to-user' is not only about indirect > buffers, right? We could marry this case with this existing mechanism. > Would that make some sense? Currently, ediff-dispose-of-variant-according-to-user - kills any indirect buffers with ediff-temp-indirect-buffer non-nil (used by region/window comparison), and - if ediff-keep-variants is nil, asks about killing any unmodified buffers. It's not clear to me how best to fit modified non-file buffers (such as the FILE=... buffer produced by ediff-current-file) into this picture. And, as you point out, the user might wish to keep such buffers around. > And apart from that, adding a STARTUP-HOOKS argument to > `ediff-current-file' looks acceptable to me, although it would have no > direct uses in Emacs currently. I don't like it when users are forced > to use really bad hacks to change the behavior of such cases. That indeed seems like the simplest way to allow customization that doesn't resort to hacks or simply overwriting the function, so please see the attached patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment >From fd9b5d248fb8112be8dc4ff6db5bd2bc04c4f588 Mon Sep 17 00:00:00 2001 From: Paul Nelson Date: Mon, 31 Mar 2025 08:31:23 +0200 Subject: [PATCH] ediff-current-file: Add optional startup-hooks arg * lisp/vc/ediff.el (ediff-current-file): Add optional startup-hooks argument, so that the user can write wrapper commands with more finely customized behavior. --- lisp/vc/ediff.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lisp/vc/ediff.el b/lisp/vc/ediff.el index 36580c73d6b..bc89b2025ff 100644 --- a/lisp/vc/ediff.el +++ b/lisp/vc/ediff.el @@ -360,10 +360,13 @@ ediff-files-internal (defalias 'ediff #'ediff-files) ;;;###autoload -(defun ediff-current-file () +(defun ediff-current-file (&optional startup-hooks) "Start ediff between current buffer and its file on disk. This command can be used instead of `revert-buffer'. If there is -nothing to revert then this command fails." +nothing to revert then this command fails. + +Non-interactively, STARTUP-HOOKS is a list of functions that Emacs calls +without arguments after setting up the Ediff buffers." (interactive) ;; This duplicates code from menu-bar.el. (unless (or (not (eq revert-buffer-function 'revert-buffer--default)) @@ -395,7 +398,7 @@ ediff-current-file (insert-file-contents file-name) ;; Assume same modes: (funcall current-major)) - (ediff-buffers revert-buf (current-buffer)))) + (ediff-buffers revert-buf (current-buffer) startup-hooks))) ;;;###autoload -- 2.39.3 (Apple Git-145) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 31 21:36:21 2025 Received: (at 77323) by debbugs.gnu.org; 1 Apr 2025 01:36:21 +0000 Received: from localhost ([127.0.0.1]:43671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tzQY9-0007XM-D0 for submit@debbugs.gnu.org; Mon, 31 Mar 2025 21:36:21 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:55162) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tzQY5-0007W9-Qq for 77323@debbugs.gnu.org; Mon, 31 Mar 2025 21:36:18 -0400 DKIM-Signature: a=rsa-sha256; b=n1Y3z4dEofs0ex7bdC1u4Nl3l+32WyIBMkVLRPtyu6BhhnpVvk099trCzmUZuFpE2HPC6MH9c4LNUNGhb+mG312t0eqBWzo8XycvnQU1iJJ5XYZ34RCdB3Afdgo95VnbTVo+0RV4VIlm4vBpjy9QZWF6UQPGWi8gv6fQI1Lu3OuOuEf8SDsgWtRb5/oIGuXZcWkDks6i6B4gPoVX5hdICxvASPP7Y1NC3Gg3LCXI9upqkuyT7Vemdb5BFYdXxJ1XGuVJ8dNHycr/KdOf3dVwmzekXdZ/vj3uokYxpItBTnERVwIGUc12bvF3lId80CdkuGjshpgRhdOGTpzqlL3wHQ==; s=purelymail3; d=spwhitton.name; v=1; bh=PkPvzU/xLymxwMnH4vHDopdAYSFINKzwpt5ghNtVpuA=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=d85fxGr4FofolS47DuW6Q6nKcA0R0ln3GMh3q1FbxhXuXFaFsscVPsN+08PxWkz+xXNggkvywCdx3RdmmF+47HyRAPP5fw831PW+U6khWHyy0Ox3fGo5PwM4EYzyan6h2kT2POwQ5aB5+poENyM75Bglu/yV34bpJeXlPfYzvHWSkMhSQL5it0G6tOEUAtatGq208MwC1STEV878oAzrzjPzL580mhpdJbfCMKBt1KbmdHAOmOTvbBZhn/dEpmc08g1rWoPXD3M8hvOv0RYEbX5U6DT3Xawpp8uNfkbz53adFWLCpe1Ljt0IkKxdh3VH6dC9WAxXCfWbmutTUhDhJA==; s=purelymail3; d=purelymail.com; v=1; bh=PkPvzU/xLymxwMnH4vHDopdAYSFINKzwpt5ghNtVpuA=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77323@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1853016154; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 01 Apr 2025 01:36:09 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id 9B0627E8A9C; Tue, 01 Apr 2025 09:36:07 +0800 (CST) From: Sean Whitton To: "Paul D. Nelson" Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: References: Date: Tue, 01 Apr 2025 09:36:07 +0800 Message-ID: <87v7ro3bp4.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323 Cc: Michael Heerdegen , 77323@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On Mon 31 Mar 2025 at 09:07am +02, Paul D. Nelson wrote: > That indeed seems like the simplest way to allow customization that > doesn't resort to hacks or simply overwriting the function, so please > see the attached patch. This looks good to me. -- Sean Whitton From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 07:46:43 2025 Received: (at 77323) by debbugs.gnu.org; 4 Apr 2025 11:46:43 +0000 Received: from localhost ([127.0.0.1]:37316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0fVS-0000mI-QW for submit@debbugs.gnu.org; Fri, 04 Apr 2025 07:46:43 -0400 Received: from mout.web.de ([212.227.15.4]:53599) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0fVQ-0000m1-RP for 77323@debbugs.gnu.org; Fri, 04 Apr 2025 07:46:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1743767191; x=1744371991; i=michael_heerdegen@web.de; bh=PJNTNanbOYmb8QmqyT0qweChHY8x+AGYm+iYqW6K0VI=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=DuAaI8G2kbuTbztifu9LgL6j0SZL+CK+fYsI+9LsI93yyf8jUbiVsCrPQTfSgt3G igxRzOO6XqHKv/e1PM7kAr8/GnM/Ng5pjUd0ZjhVxL2cgzlE54McQb6WLmHR4My88 qJEItXXpsk7+CkedVCkSxoi4OcdSljvZcvKPU1QQFYxQlU4myQKe0ZlEbRc0Hs6AG H3YT6/JZL5APXFAX2px2LmyOFJPs567VYBfqIp2d5VNfB1Q69ezlGaeI4bg6SNu7w QsRLOkH4Cp5MwFs1Ngh2fRx/p/tls0FdpZ35Xw6UU0kmvNEmdos44XOspH7SLkF1N r/vtbSHyxJHEC/Wj7g== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.230]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MHVaf-1tw2wI2jMv-007gAv; Fri, 04 Apr 2025 13:46:31 +0200 From: Michael Heerdegen To: Sean Whitton Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: <87v7ro3bp4.fsf@melete.silentflame.com> References: <87v7ro3bp4.fsf@melete.silentflame.com> Date: Fri, 04 Apr 2025 13:48:02 +0200 Message-ID: <878qoggnbh.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:XVaaRxiQZAMxfSJF+wE5I8ZEIHM5811o6tGGxdx0uxzT1mckoN9 k/UCmmBxMsV0ec6E7HWRFYPhxtXAj0Xvns5dl8F89z6QEiTNArT99G4MfTETgscdAyazecM Sx90Na99qimVACdqtiBmgGXivcO1Y76D75q0bEQ0VFXuAjh3Rh21u9+DjvzHq1houJqHWoB BzCrYRVIaJW8UEOdgvSgw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:HgcQn4kRIeg=;b6hyJNUhgAx/FNmltHHuzA2LeT7 tHZ6zvH2fEO1VxA2Gyt5yxs8vHpsDalwA+Qc69aEPDZJHFQS25Qw2u8JQ+ogrZEJcza1UGk8x AkltSIMaMaCFTKWqYJMjUnn7c8FrkFsa9nPRK8psQnlyCkue+ix8GTWaWIj5vsjyS/daMi3Tu OjWIp+dMnopfBN/LEGtiBQlMa6lZ318m3IP83oRahKkegWx2QjkngErvC/++sHIYBMUsdnKq8 vqBWVkxlBS40YQaPA1E2I4kYohm25O6QlDD/lzqhyhb7+4dzspyE0NZrkihZ+/XC0FScqWKQy +nHtZPmUS6/FbO14vzJsjGuMTO4EXa83VRkO0526FhR49MMl+n+XNGM039tQVVGAAdGVi6HMo vKVl3b5p+dmZjAcGna6SVWcvbdciUP257zB7mjst6jV7LNr5RvTmmjVull9B3er7EV+Y7xLAD jtvo5Efs0vfoP/amM1Y1y/3lFuNCVt9Q1EbutW309EDV/iozBLlEaQLdiBQeV2wSRlxxSNWY7 wFK3TfuV37o0JgVb4g7oX7FPJG7uOXXLXEJSolespmCAx3BI/HIzCiGu7gR0gRz1PAbqr0Z7a 2oKAjwDMm+uHUKahRm3+GrFYCCQnn/cT8Rx8dy+3R93olmxadBNEvVx5IiC0n/8jyWHtGRc7c AqpFURr/P3sUQmPMMFDzx7M/64tdw04Fc3HP2yW+bXNtQj9HuSfYROIUYb7I10zJfPqBOnhZb Bvebog3kal1Hcb+ENBbYNHaVurBhQiNQenc9EHzmTK/ZsZszjCAMsT1wwtQZTmL01UxHJJMtM O7iDxoj8AiWY20hsYh/z8ELl6WUJNN4eyecU/nYoLO0/iprbo8+tOUfq7iS1Kb2G+EFekSc8O fKjrk/9g3mMmeyFtLBDYoMqNOIY4AmiR7DRGPMgnAGNzIqkQY586Gwy6zNfK6Dq4TXFXbem3t 9Jzsbl5iE7UIzZZR39jhWOru2QSkoOoOJ+zXNiZVwdx3vS6QCEvfDX/Hs6UHPzUhz9Q0v8FM8 tvnm4jpJ4NNYNgMxxJY7znuHdIryJziwaDWGEhGX7ilyJlrV7N8/IwYOKmMmqxqbh5lV+eQiw kSFEvY5T9WwfKk/8iNm6rkkKtj6sZBUCB7nZffFxPCvauJdgIBhSi819DayPXgNsvorvOlg7v pLUvyGdcsApJZUemm3RUMjh/y3HHe9bzsFoCNS5FV1z7SviNKSdaGYHz7VnNhPB/71Dv6VNh1 3ZMi+s4QXnQnLyfQTGgvSZEBmfMVHOLH1DR5ekZuZdwQk2/zSICvD8mEIs/zJKr/hQ9HuKRbs 587UvWAj6h4WpYMZMNqwHdKGJUc8JVwmN44McKvEkB9IZvwxOYIBpb8ZmTyOTQ/mJcQOh6cTX giV32b3nhBU3mIsMScx/jLiikDMrQjodsJlLvmnQ2TGaAgIQ+4hTtduz5TLNSEtLmrp9ktFux j8ddc0w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77323 Cc: 77323@debbugs.gnu.org, "Paul D. Nelson" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Sean Whitton writes: > > That indeed seems like the simplest way to allow customization that > > doesn't resort to hacks or simply overwriting the function, so please > > see the attached patch. > > This looks good to me. Yes, to me, too. Has Paul signed the Copyright papers? Those who know, please install Paul's latest patch. Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 09:14:25 2025 Received: (at 77323) by debbugs.gnu.org; 4 Apr 2025 13:14:25 +0000 Received: from localhost ([127.0.0.1]:37426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0gsL-0007g4-Ee for submit@debbugs.gnu.org; Fri, 04 Apr 2025 09:14:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53726) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0gsJ-0007fs-3B for 77323@debbugs.gnu.org; Fri, 04 Apr 2025 09:14:23 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0gsD-0004m7-69; Fri, 04 Apr 2025 09:14:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MfVA0F7+MzCqB1ox72M5RD/ZrFy4yuvRV0pjv3306WY=; b=XQliyJasY+6D TxjXugsIn/UrMXbsQnR1hLdEcHTECtI9BO78ZRoAv6P/8d0LHJ0Aa1XE9vZ0bEFZQx6Z106i2sgIb /Xg4BoZugT+xBni22qF5kXcYoB90HtRYwTGMXLBAeAqVECoAXvhE9Og+FzS61Os3UZlxz6mN3BbyY HgC914yz4WnNGFkpgSPfMgLNHQj3KS3agy0FL+Oclnmgam/ExluwnxY3zGJfvI+lHoNPbme4jwUqL UYaUVbwDGXSB/Nzyv//DDvnnthkhKPABIQ8hWJs3r2l6bOWFRZ01HWAaHukCYBmIv/7KsPDu/t0vd kNAKM6SLhWOfOl99C8OTMQ==; Date: Fri, 04 Apr 2025 16:14:14 +0300 Message-Id: <86tt74xe55.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <878qoggnbh.fsf@web.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file References: <87v7ro3bp4.fsf@melete.silentflame.com> <878qoggnbh.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77323 Cc: ultrono@gmail.com, 77323@debbugs.gnu.org, spwhitton@spwhitton.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 77323@debbugs.gnu.org, "Paul D. Nelson" > Date: Fri, 04 Apr 2025 13:48:02 +0200 > From: Michael Heerdegen via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Has Paul signed the Copyright papers? Yes, he did. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 21:37:35 2025 Received: (at 77323-done) by debbugs.gnu.org; 5 Apr 2025 01:37:35 +0000 Received: from localhost ([127.0.0.1]:40766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0sTX-0007Bv-FQ for submit@debbugs.gnu.org; Fri, 04 Apr 2025 21:37:35 -0400 Received: from sendmail.purelymail.com ([34.202.193.197]:39488) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0sTT-0007Bd-RU for 77323-done@debbugs.gnu.org; Fri, 04 Apr 2025 21:37:33 -0400 DKIM-Signature: a=rsa-sha256; b=ath+3QHi22z7IoSp9ilvVe27KSoL4PNw0mrPjeP6UmvZM52WwIZ6jxF//UYv9oOTNdsY3YgtOmxy2EjVg/bsfGWa/6lqyFJ3L1fP8MEmKIKRW4kaDsWZdWK4GDPgswny//vfShVju/uE2XAAwHSCob67XC7ECHslTD+t2uz13KvH8bqvAP0J9bbwmPxEvprFu7sA+S+10IJRjEyRBlaScG5rkCLEz66qLoPbY+v/wwEB/Ik3kLVT2TmRqML69Q6OzH9H7XGWamEyRjw2gQTjXt78JMzrnRoF1JrZ/AXc00ohJozZG3PsOYzXEh58/QwSv6GP0mHHguYM6yVefJTW5Q==; s=purelymail1; d=spwhitton.name; v=1; bh=Loqy/mwdOs9ZvwVCyKLzKAmIF3eA1DjRta783ogYRlU=; h=Received:Received:From:To:Subject:Date; DKIM-Signature: a=rsa-sha256; b=XDojNPBgVswmlhShrcSBLxvFkXwKjyd1I2Ffjgw8r76d9qQPapSVUOc7gx3I3Bgc+MT5Zdd+WKfIv8d9Y4/t/c0b+ulnBl6p0S2JyTpvvAk2XjuPAUDQmITVr1tBjhYB2xbrHFPl3MxxeUiBGzuncMxR/JBacPUhd+Vu6xmiHKcpBsXazcarVDP1vJNENgwO92y7RI/CAxuYFNSVpn7kty2vC/knPzXaMicnhLtpv2RDYk5LS1vnIGyqN04PduzUb52chfaxqk/4xPElyk+TsdQpa3iRMCY3AA5pEIi+VtEa+y2XlV59JjmRBM6UM7MTWKwdajCYwcgQ/UHLJdIN6w==; s=purelymail1; d=purelymail.com; v=1; bh=Loqy/mwdOs9ZvwVCyKLzKAmIF3eA1DjRta783ogYRlU=; h=Feedback-ID:Received:Received:From:To:Subject:Date; Feedback-ID: 20115:3760:null:purelymail X-Pm-Original-To: 77323-done@debbugs.gnu.org Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 964389363; (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 05 Apr 2025 01:37:19 +0000 (UTC) Received: by melete.silentflame.com (Postfix, from userid 1000) id D261D7ED206; Sat, 05 Apr 2025 09:37:13 +0800 (CST) From: Sean Whitton To: Eli Zaretskii , Michael Heerdegen , ultrono@gmail.com, 77323-done@debbugs.gnu.org Subject: Re: bug#77323: [PATCH] Allow temp buffer cleanup in ediff-current-file In-Reply-To: <86tt74xe55.fsf@gnu.org> References: <87v7ro3bp4.fsf@melete.silentflame.com> <878qoggnbh.fsf@web.de> <86tt74xe55.fsf@gnu.org> Date: Sat, 05 Apr 2025 09:37:13 +0800 Message-ID: <874iz3s81i.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77323-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Thanks, installed this. -- Sean Whitton From unknown Tue Jun 17 03:38:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 May 2025 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator