GNU bug report logs - #77313
30.1.50; Regression: flymake indicators are erroneously using margins

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 77313 <at> debbugs.gnu.org, juri <at> linkov.net
Subject: bug#77313: 30.1.50; Regression: flymake indicators are erroneously using margins
Date: Sat, 12 Apr 2025 14:13:00 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: 77313 <at> debbugs.gnu.org,  juri <at> linkov.net
> Date: Tue, 08 Apr 2025 17:50:38 -0400
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> >> From: Spencer Baugh <sbaugh <at> janestreet.com>
> >> Date: Tue, 8 Apr 2025 08:43:37 -0400
> >> Subject: [PATCH] flymake: fall back to margins on text terminals
> >> 
> >> Previously, flymake-indicator-type defaulted to either fringes
> >> or margins.  But fringes should be used on graphical frames, and
> >> margins on TTY frames.  So default to fringes instead, and
> >> simply fall back to margins automatically on text frames.
> >
> > The above needs to be updated to mention the disabled fringes.
> 
> Updated.
> 
> >> * lisp/progmodes/flymake.el (flymake-indicator-type): Set to
> >> fringes.  (bug#77313)
> >> (flymake-mode): Fallback to margins if there's no fringes.
> >
> > This needs a NEWS entry, but other than that it LGTM.  Let's wait for
> > a couple of days to let others a chance to comment.
> 
> Added a NEWS entry.

Thanks, installed on master.

Should we now close this bug?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.