GNU bug report logs - #77303
[PATCH] services: anonip: Rotate log files.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77303: closed ([PATCH] services: anonip: Rotate log files.)
Date: Tue, 08 Apr 2025 15:32:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 08 Apr 2025 17:13:40 +0200
with message-id <87ecy24rff.fsf <at> gnu.org>
and subject line Re: [bug#77303] [PATCH] services: anonip: Rotate log files.
has caused the debbugs.gnu.org bug report #77303,
regarding [PATCH] services: anonip: Rotate log files.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77303: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77303
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: [PATCH] services: anonip: Rotate log files.
Date: Thu, 27 Mar 2025 09:34:08 +0100

* gnu/services/web.scm (anonip-log-files): New procedure.
(anonip-service-type): Use it to extend ‘log-rotation-service-type’.
* doc/guix.texi (Log Rotation): Document it.

Change-Id: I903bb79e0992b794bb0a40e504283cd57a8a087b
---
 doc/guix.texi        | 4 +++-
 gnu/services/web.scm | 6 ++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

This fixes a longstanding issue, in particular on berlin where log
files keep growing. :-)

Ludo'.

diff --git a/doc/guix.texi b/doc/guix.texi
index 3b98f1b4ea..28d7bf60ea 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -21453,7 +21453,9 @@ Log Rotation
 FIFO of this name.  The web server should write its logs to this FIFO.
 
 @item @code{output}
-The file name of the processed log file.
+The file name of the processed log file.  This file is subject to log
+rotation @i{via} the Shepherd's log rotation service (@pxref{Log
+Rotation}).
 @end table
 
 The following optional settings may be provided:
diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index f8cf06fb48..9caa03317b 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -1574,12 +1574,18 @@ (define (anonip-shepherd-service config)
                   "LC_ALL=en_US.utf8"))))
       (stop #~(make-kill-destructor))))))
 
+(define (anonip-log-files config)
+  "Return the list of log files produced by @command{anonip}."
+  (list (anonip-configuration-output config)))
+
 (define anonip-service-type
   (service-type
    (name 'anonip)
    (extensions
     (list (service-extension shepherd-root-service-type
                              anonip-shepherd-service)
+          (service-extension log-rotation-service-type
+                             anonip-log-files)
           (service-extension activation-service-type
                              anonip-activation)))
    (description

base-commit: cfdd0f58d0f85127c166f0908aa7b85c7cb9cc74
-- 
2.49.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: 77303-done <at> debbugs.gnu.org
Cc: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#77303] [PATCH] services: anonip: Rotate log files.
Date: Tue, 08 Apr 2025 17:13:40 +0200

Ludovic Courtès <ludo <at> gnu.org> skribis:

> * gnu/services/web.scm (anonip-log-files): New procedure.
> (anonip-service-type): Use it to extend ‘log-rotation-service-type’.
> * doc/guix.texi (Log Rotation): Document it.
>
> Change-Id: I903bb79e0992b794bb0a40e504283cd57a8a087b

I went ahead with this change, which is hopefully a cheap improvement.

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.