Subject: Re: [bug#77290] [PATCH v1] gnu: Add emacs-rescript-mode

From: Ian Eure <[email-masked]>
Date: Sat, 29 Mar 2025 08:13:48 -0700

Hi Vasilii,

[email-masked] writes:

> From: Vasilii Smirnov <[email-masked]>
>
> * gnu/packages/emacs-xyz.scm (emacs-rescript-mode): New 
> variable.
>
> Change-Id: I52fa3e2693f62aa25ec2d97441bc3f191d46ac0b
> ---
>  gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index da30b4776c..2735527fac 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -3772,6 +3772,33 @@ (define-public emacs-reformatter
>  optional minor mode which can apply this command automatically 
>  on save.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-rescript-mode
> +  (let ((commit "b9dda43cc52cd4a9b384c59fb0cc7a11f0bad230")
> +        (revision "0"))
> +    (package
> +      (name "emacs-rescript-mode")
> +      (version (git-version "0.0.0" revision commit))

rescript-mode.el declares a version of 0.1.0, please use that 
instead of 0.0.0.

When you resend the patch, please make sure to send it as version 
2 -- your second patch was sent as version 1, but version 1 is 
implied for patches which don’t declare a version, and multiple 
patches with the same version can be hard to apply.

Thanks,

  -- Ian