GNU bug report logs - #7729
24.0.50; doc string of `image-mode-fit-frame'

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Fri, 24 Dec 2010 23:03:01 UTC

Severity: minor

Tags: fixed

Found in version 24.0.50

Fixed in version 24.1

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7729 in the body.
You can then email your comments to 7729 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7729; Package emacs. (Fri, 24 Dec 2010 23:03:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to "Drew Adams" <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 24 Dec 2010 23:03:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; doc string of `image-mode-fit-frame'
Date: Fri, 24 Dec 2010 15:08:01 -0800

Doc string:
 
"Fit the frame to the current image.
This function assumes the current frame has only one window."
 
But the command actually toggles between fitting the frame to the image
and restoring the previous frame size.  This behavior should be
mentioned in the doc.  Actually, the command name should reflect this
behavior: `toggle-fit-frame-to-image' or some such.
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-12-20 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
Added tag(s) fixed. Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 14 Jul 2011 17:08:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 24.1, send any further explanations to 7729 <at> debbugs.gnu.org and "Drew Adams" <drew.adams <at> oracle.com> Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 14 Jul 2011 17:08:02 GMT) Full text and rfc822 format available.
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7729; Package emacs. (Thu, 14 Jul 2011 17:45:03 GMT) Full text and rfc822 format available.

Message #12 received at 7729 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 7729 <at> debbugs.gnu.org
Subject: Re: 24.0.50; doc string of `image-mode-fit-frame'
Date: Thu, 14 Jul 2011 19:07:00 +0200

"Drew Adams" <drew.adams <at> oracle.com> writes:

> Doc string:
>
> "Fit the frame to the current image.
> This function assumes the current frame has only one window."
>
> But the command actually toggles between fitting the frame to the image
> and restoring the previous frame size.  This behavior should be
> mentioned in the doc.

I've now fixed this.

> Actually, the command name should reflect this behavior:
> `toggle-fit-frame-to-image' or some such.

No, I don't think that's warranted.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
Information forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#7729; Package emacs. (Thu, 14 Jul 2011 20:30:02 GMT) Full text and rfc822 format available.

Message #15 received at 7729 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Lars Magne Ingebrigtsen'" <larsi <at> gnus.org>
Cc: 7729 <at> debbugs.gnu.org
Subject: RE: 24.0.50; doc string of `image-mode-fit-frame'
Date: Thu, 14 Jul 2011 13:29:26 -0700

> > Actually, the command name should reflect this behavior:
> > `toggle-fit-frame-to-image' or some such.
> 
> No, I don't think that's warranted.

Why not?

The command only does what the current name says 50% of the time.  It does what
the new, suggested name says 100% of the time.

Not to mention that `-mode-' here is unnecessary verbiage.  The command toggles
frame fitting to an image.

Why not improve things by giving it a name that fits?
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 12 Aug 2011 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 14 years and 6 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.