Subject: Re: [bug#77284] [PATCH] gnu: emacs-org-node: Update to 2.4.1.

From: Ian Eure <[email-masked]>
Date: Sat, 29 Mar 2025 08:16:55 -0700

Hi Cayetano,

Cayetano Santos <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-org-node): Update to 2.4.1.
>
> Change-Id: I8412633c31fd7c5ce2159323d4720dd64e590ffd
> ---
>  gnu/packages/emacs-xyz.scm | 33 
>  +++++++++++++++++++++++----------
>  1 file changed, 23 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm 
> b/gnu/packages/emacs-xyz.scm
> index da30b4776c..3c99681a88 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -40003,26 +40003,39 @@ (define-public emacs-org-roam
>  (define-public emacs-org-node
>    (package
>      (name "emacs-org-node")
> -    (version "2.1.2")
> +    (version "2.4.1")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> -                    (url 
> "https://github.com/meedstrom/org-node.git")
> +                    (url 
> "https://github.com/meedstrom/org-node/")
>                      (commit version)))
>                (file-name (git-file-name name version))
>                (sha256
>                 (base32
> - 
> "05f5ga66q2vyv48z95lky0hzbs2zq5bvppkx7bbyv252jzxbibw3"))))
> + 
> "0yvc61ydz8c8wms5pwb14v67da7w4l3xvd5w4x83qf81d9f44w9v"))))
>      (build-system emacs-build-system)
> +    (arguments
> +     '(#:tests? #f ; fails
> +       #:test-command '("./makem.sh" "tests")
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'dont-git
> +           (lambda _
> +             (substitute* "makem.sh"
> +               (("^cd.*\"")
> +                "")))))))
>      (propagated-inputs
> -     (list emacs-dash
> -           emacs-el-job
> +     (list emacs-el-job
>             emacs-llama
> -           emacs-magit
> -           emacs-org
> -           emacs-persist
> -           emacs-transient))
> -    (home-page "https://github.com/meedstrom/org-node")
> +           emacs-magit))
> +    ;; tests
> +    (inputs
> +     (list emacs-buttercup
> +           emacs-dash
> +           util-linux
> +           grep
> +           sed))

Any test dependencies need to be moved to native-inputs.  Could 
you please do that and send a v2?

Thanks,

  -- Ian