GNU bug report logs - #7726
reveal-mode bypassed by compile-goto-error

Previous Next

To reply to this bug, email your comments to 7726 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Emacs Bugs <bug-gnu-emacs <at> gnu.org>
Subject: reveal-mode bypassed by compile-goto-error
Date: Fri, 24 Dec 2010 13:54:53 +0100

If I use compile-goto-error from a grep-mode buffer to a org-mode
buffer where the destination line is in a hidden outline then the
outline will not be revealed until after next command.

GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) from trunk 2010-10-19 (patched)

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Fri, 24 Dec 2010 15:40:53 +0100

Lennart Borgman <lennart.borgman <at> gmail.com> writes:

> If I use compile-goto-error from a grep-mode buffer to a org-mode
> buffer where the destination line is in a hidden outline then the
> outline will not be revealed until after next command.

Indeed,

also, goto-line is unable to reach line in an outline based buffer.
See in anything and ioccur, it is fixed for org-mode and
outline-minor-mode.

Is there other modes based on outline to handle?

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #11 received at 7726 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 7726 <at> debbugs.gnu.org
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Sat, 22 Jan 2011 18:47:14 -0500

Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:

> Lennart Borgman <lennart.borgman <at> gmail.com> writes:
>
>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>> buffer where the destination line is in a hidden outline then the
>> outline will not be revealed until after next command.
>
> Indeed,
>
> also, goto-line is unable to reach line in an outline based buffer.
> See in anything and ioccur, it is fixed for org-mode and
> outline-minor-mode.
>
> Is there other modes based on outline to handle?

Anyone have a test case?

Message #14 received at 7726 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 7726 <at> debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Sun, 23 Jan 2011 03:00:14 +0100

On Sun, Jan 23, 2011 at 12:47 AM, Chong Yidong <cyd <at> stupidchicken.com> wrote:
> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> Lennart Borgman <lennart.borgman <at> gmail.com> writes:
>>
>>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>>> buffer where the destination line is in a hidden outline then the
>>> outline will not be revealed until after next command.
>>
>> Indeed,
>>
>> also, goto-line is unable to reach line in an outline based buffer.
>> See in anything and ioccur, it is fixed for org-mode and
>> outline-minor-mode.
>>
>> Is there other modes based on outline to handle?
>
> Anyone have a test case?

Yes, but why do you want one? Is not the recipes we have given enough?

Message #17 received at 7726 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 7726 <at> debbugs.gnu.org
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Sun, 23 Jan 2011 08:19:29 +0100

Chong Yidong <cyd <at> stupidchicken.com> writes:

> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> Lennart Borgman <lennart.borgman <at> gmail.com> writes:
>>
>>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>>> buffer where the destination line is in a hidden outline then the
>>> outline will not be revealed until after next command.
>>
>> Indeed,
>>
>> also, goto-line is unable to reach line in an outline based buffer.
>> See in anything and ioccur, it is fixed for org-mode and
>> outline-minor-mode.
>>
>> Is there other modes based on outline to handle?
>
> Anyone have a test case?
Switch to any org buffer, close all, and:
M-g g 20 RET

-- 
A+ Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #20 received at 7726 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 7726 <at> debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Sun, 23 Jan 2011 19:50:53 -0500

>>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>>> buffer where the destination line is in a hidden outline then the
>>> outline will not be revealed until after next command.
>> also, goto-line is unable to reach line in an outline based buffer.
>> See in anything and ioccur, it is fixed for org-mode and
>> outline-minor-mode.
>> Is there other modes based on outline to handle?
> Anyone have a test case?

I think the problem is that reveal-mode runs from post-command-hook and
reveals what's in the buffer that's current when post-command-hook is
run, whereas in the above cases, the buffer that needs revealing is not
current at that point.
That's one of the cases where we could use something like
a "pre-redisplay-hook".


        Stefan

Message #23 received at 7726 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 7726 <at> debbugs.gnu.org,
	Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Mon, 24 Jan 2011 02:00:19 +0100

On Mon, Jan 24, 2011 at 1:50 AM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>>>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>>>> buffer where the destination line is in a hidden outline then the
>>>> outline will not be revealed until after next command.
>>> also, goto-line is unable to reach line in an outline based buffer.
>>> See in anything and ioccur, it is fixed for org-mode and
>>> outline-minor-mode.
>>> Is there other modes based on outline to handle?
>> Anyone have a test case?
>
> I think the problem is that reveal-mode runs from post-command-hook and
> reveals what's in the buffer that's current when post-command-hook is
> run, whereas in the above cases, the buffer that needs revealing is not
> current at that point.
> That's one of the cases where we could use something like
> a "pre-redisplay-hook".

Isn't it more like post-post-command-hook?

(Didn't I take up such a problem with cua-mode long ago? But at the
moment I can't remember what it was.)

Message #26 received at 7726 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 7726 <at> debbugs.gnu.org,
	Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Mon, 24 Jan 2011 11:12:57 -0500

>>>>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>>>>> buffer where the destination line is in a hidden outline then the
>>>>> outline will not be revealed until after next command.
>>>> also, goto-line is unable to reach line in an outline based buffer.
>>>> See in anything and ioccur, it is fixed for org-mode and
>>>> outline-minor-mode.
>>>> Is there other modes based on outline to handle?
>>> Anyone have a test case?
>> I think the problem is that reveal-mode runs from post-command-hook and
>> reveals what's in the buffer that's current when post-command-hook is
>> run, whereas in the above cases, the buffer that needs revealing is not
>> current at that point.
>> That's one of the cases where we could use something like
>> a "pre-redisplay-hook".
> Isn't it more like post-post-command-hook?

No I really meant pre-redisplay-hook.  I don't see why
post-post-command-hook would have anything to do with this problem.
E.g. I think a case that needs to work is when you're in the *compile*
buffer and select one entry to display the source but while staying in
the *compile* buffer: the current buffer before and after the command is
*compile*, so no amount of post/pre-command-hooks can tell you that some
other buffer needs revealing.


        Stefan

Message #29 received at 7726 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Chong Yidong <cyd <at> stupidchicken.com>, 7726 <at> debbugs.gnu.org,
	Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#7726: reveal-mode bypassed by compile-goto-error
Date: Mon, 24 Jan 2011 21:09:29 +0100

On Mon, Jan 24, 2011 at 5:12 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:
>>>>>> If I use compile-goto-error from a grep-mode buffer to a org-mode
>>>>>> buffer where the destination line is in a hidden outline then the
>>>>>> outline will not be revealed until after next command.
>>>>> also, goto-line is unable to reach line in an outline based buffer.
>>>>> See in anything and ioccur, it is fixed for org-mode and
>>>>> outline-minor-mode.
>>>>> Is there other modes based on outline to handle?
>>>> Anyone have a test case?
>>> I think the problem is that reveal-mode runs from post-command-hook and
>>> reveals what's in the buffer that's current when post-command-hook is
>>> run, whereas in the above cases, the buffer that needs revealing is not
>>> current at that point.
>>> That's one of the cases where we could use something like
>>> a "pre-redisplay-hook".
>> Isn't it more like post-post-command-hook?
>
> No I really meant pre-redisplay-hook.  I don't see why
> post-post-command-hook would have anything to do with this problem.
> E.g. I think a case that needs to work is when you're in the *compile*
> buffer and select one entry to display the source but while staying in
> the *compile* buffer: the current buffer before and after the command is
> *compile*, so no amount of post/pre-command-hooks can tell you that some
> other buffer needs revealing.

Oh, I see.

And haven't we been discussing before that such a hook maybe could be
useful for cases where we now are using
window-configuration-change-hook?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.