GNU bug report logs - #77258
[PATCH] New package: emacs-boxy

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Thompson, David" <dthompson2 <at> worcester.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77258: closed ([PATCH] New package: emacs-boxy)
Date: Thu, 03 Apr 2025 15:06:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 3 Apr 2025 11:04:48 -0400
with message-id <CAJ=RwfaGiNKoH7pAgAcTW82u8ipgnBmGu82P6+EHY=sxgqzoMQ <at> mail.gmail.com>
and subject line Re: [PATCH] New package: emacs-boxy
has caused the debbugs.gnu.org bug report #77258,
regarding [PATCH] New package: emacs-boxy
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77258: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77258
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Amy Grinn <grinn.amy <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] New package: emacs-boxy
Date: Tue, 25 Mar 2025 18:55:34 +0100

[Message part 3 (text/plain, inline)]

Hello,

I would like to add my package, emacs-boxy, to Guix.

This is my first patch to Guix so let me know if I did anything wrong!

[0001-gnu-Add-emacs-boxy.patch (text/x-diff, inline)]

From b3223cec32425d6b8cf2c11545ed63ad6dabae88 Mon Sep 17 00:00:00 2001
From: Amy Grinn <grinn.amy <at> tuta.com>
Date: Tue, 25 Mar 2025 18:17:25 +0100
Subject: [PATCH] gnu: Add emacs-boxy

* gnu/packages/emacs-xyz.scm (emacs-boxy): New variable.
---
 gnu/packages/emacs-xyz.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f00c5e4b29..0423858b2f 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -39025,6 +39025,21 @@ (define-public emacs-boxquote
 example code.")
     (license license:gpl3+)))
 
+(define-public emacs-boxy
+  (package
+    (name "emacs-boxy")
+    (version "2.0.0")
+    (source (origin
+	      (method url-fetch)
+	      (uri (string-append "https://elpa.gnu.org/packages/boxy-"
+                                  version ".tar"))
+	      (sha256 (base64 "6w1QtINpWz9voCrc/ne6q8sPj4UcA3s8E/f/Pebjz+0="))))
+    (build-system emacs-build-system)
+    (home-page "https://gitlab.com/grinn.amy/boxy")
+    (synopsis "A boxy layout framework")
+    (description "Boxy provides an interface to create a 3D representation of boxes.")
+    (license license:gpl3+)))
+
 (define-public emacs-buffer-env
   (package
     (name "emacs-buffer-env")
-- 
2.49.0

[Message part 5 (text/plain, inline)]

-- 
Best,

Amy

[Message part 6 (message/rfc822, inline)]

From: "Thompson, David" <dthompson2 <at> worcester.edu>
To: 77258-done <at> debbugs.gnu.org
Subject: Re: [PATCH] New package: emacs-boxy
Date: Thu, 3 Apr 2025 11:04:48 -0400

Hi Amy,

The latest version of your patch looks good overall. Thanks for
expanding the description and adding a copyright line. As you
mentioned, many packages in emacs-xyz.scm use tarballs from ELPA so
given the instability of the upstream repo due to hosting migrations I
think using an ELPA URL is just fine here.

FWIW, patches as attachments are no problem for me. Whether inline or
attachment, doing code review by email is just as frustrating. ;)

Also, I think the comments from Ian about the code in the project
itself are irrelevant to the discussion of this patch, which should be
scoped to just the package recipe.

I modified the hash to use the conventional base32 format and pushed to master.

Congrats on your first Guix patch!

- Dave

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.