From unknown Thu Aug 14 12:25:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77258 <77258@debbugs.gnu.org> To: bug#77258 <77258@debbugs.gnu.org> Subject: Status: [PATCH] New package: emacs-boxy Reply-To: bug#77258 <77258@debbugs.gnu.org> Date: Thu, 14 Aug 2025 19:25:28 +0000 retitle 77258 [PATCH] New package: emacs-boxy reassign 77258 guix-patches submitter 77258 Amy Grinn severity 77258 normal tag 77258 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 15:03:28 2025 Received: (at submit) by debbugs.gnu.org; 25 Mar 2025 19:03:28 +0000 Received: from localhost ([127.0.0.1]:40028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tx9Yd-0004Sm-9G for submit@debbugs.gnu.org; Tue, 25 Mar 2025 15:03:28 -0400 Received: from lists.gnu.org ([2001:470:142::17]:50176) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tx8V8-00018A-VG for submit@debbugs.gnu.org; Tue, 25 Mar 2025 13:55:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tx8V3-0006Lf-6p for guix-patches@gnu.org; Tue, 25 Mar 2025 13:55:41 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tx8V1-0004HX-Cr for guix-patches@gnu.org; Tue, 25 Mar 2025 13:55:40 -0400 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-ac2ab99e16eso1175203066b.0 for ; Tue, 25 Mar 2025 10:55:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742925336; x=1743530136; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=rAZq7BoFchmskllKhzbdsUSu7LE8qvJiu/Dp+HZYQ3g=; b=a/dWDC6enIQoF2q9GU8TC/umX9kfTkDCS3ySth0Sq5pkqJiTz70esDWRGtN5QoCyUm 0GB94Wciq4eC/5elw8tQf+WCyU0Oy02fQqO3Q5qrXqTp6NcLLKX+n8dvjag5Y/JQRY+8 s9GF/XzvRcTk3j0F3tP5QKARwcO3xKRPix16SckWUvYG5rHVDSfX6XKov7ckERJUoeGd 6UuigPT/sylraZURAo6+IRA9VKnr8fv5XodZpzFs86o3E7xhpo3fhglO6eTG2wXQvyyk Tr4z5WaZ3yYwcBf/DFGw9sH2CZX4d5FZ2Guy4+hEswkveXk7H9bj6VA73jkIEH2nLFQj wZsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742925336; x=1743530136; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rAZq7BoFchmskllKhzbdsUSu7LE8qvJiu/Dp+HZYQ3g=; b=u9mz33EHOk1SOY5OXM+NM3ioQAms/kIlRxQHpRIWjxS12dDLmToT834XUdfJkJ7lVK 3fbqX3JmTKutEj94tbiTDUQNB6MFBrIZy3EiDr1rimgl6XOPcBdv+ssL7YjwWltm10O8 Vv4KTI8z9ND5yGQDah+0M21Tg0UYiAja0qbEKaj/je1cIOWjZZL5Fjlm1rUQbz/k1ttJ oJjaAMFTfQThp6mPKESLXCUtACOgns5ygN/vvGR146P/jWuQEaynQcGtSaIVOymT35ba xK2J5XtrveidipN5EH0oGBe14WAzz8C+t1CAlg361NTC5YgsX0cgn/EJetIHs+x+Hjp5 g0EA== X-Gm-Message-State: AOJu0YxwTGBteDAZXAzq7hgUvZ/VAshGoLEm3ef+Dkphp6hIlu4lgdKs HKMhTt/Jypd0IKLqGZPmoRvnr8Z1hU3aDxMNMclMUzvdQxKjAEC6FjfMSrby X-Gm-Gg: ASbGnctZRyFwiXCrE2UWHQY0FN/PrrQvVrSxbfEC/9YK6lTD3Fa4tGxwjQ3KBygau/s J+wCyeMJ8hdKIdQV4IuuslyADLOBzeL4Tk4qcIQKm+1RMXqTC5fCU6p1R3yPP5ufgK7V9hxi9fG aDVD2MCzTwY5BiwZGfsCBkzBfNFMRJiplhFkru5YppZtb5HelDf1SrFyQsfqtE7ZRMlfe55mNUv 9XMFOSvYh/TqvzPCh637KES/Eg4WI2srocQmKxlhWoFJo6oRbaPGbX2PVSG+1Tz8M5FG/CYvkgl mvUWJW4i8eT8YOPEgGyG2OY7mGQGU7HBcQxNr3Oeug== X-Google-Smtp-Source: AGHT+IFKcZoFEJ5GeH/DCBdcVpmyuFVWZv/xScSrS8cJa41WPEWDlVkx8aUyqM2G66XOpmdHGI+xKQ== X-Received: by 2002:a17:906:478d:b0:ac3:b12c:b1f2 with SMTP id a640c23a62f3a-ac3f251ac58mr1572756466b.35.1742925335699; Tue, 25 Mar 2025 10:55:35 -0700 (PDT) Received: from pop-os ([2a02:8109:b537:d300:3f01:12ff:3d56:6835]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3ef8e5152sm886098966b.47.2025.03.25.10.55.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 10:55:35 -0700 (PDT) From: Amy Grinn To: guix-patches@gnu.org Subject: [PATCH] New package: emacs-boxy Date: Tue, 25 Mar 2025 18:55:34 +0100 Message-ID: <87o6xp571l.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=grinn.amy@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 25 Mar 2025 15:03:24 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Hello, I would like to add my package, emacs-boxy, to Guix. This is my first patch to Guix so let me know if I did anything wrong! --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-Add-emacs-boxy.patch Content-Description: emacs-boxy patch >From b3223cec32425d6b8cf2c11545ed63ad6dabae88 Mon Sep 17 00:00:00 2001 From: Amy Grinn Date: Tue, 25 Mar 2025 18:17:25 +0100 Subject: [PATCH] gnu: Add emacs-boxy * gnu/packages/emacs-xyz.scm (emacs-boxy): New variable. --- gnu/packages/emacs-xyz.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index f00c5e4b29..0423858b2f 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -39025,6 +39025,21 @@ (define-public emacs-boxquote example code.") (license license:gpl3+))) +(define-public emacs-boxy + (package + (name "emacs-boxy") + (version "2.0.0") + (source (origin + (method url-fetch) + (uri (string-append "https://elpa.gnu.org/packages/boxy-" + version ".tar")) + (sha256 (base64 "6w1QtINpWz9voCrc/ne6q8sPj4UcA3s8E/f/Pebjz+0=")))) + (build-system emacs-build-system) + (home-page "https://gitlab.com/grinn.amy/boxy") + (synopsis "A boxy layout framework") + (description "Boxy provides an interface to create a 3D representation of boxes.") + (license license:gpl3+))) + (define-public emacs-buffer-env (package (name "emacs-buffer-env") -- 2.49.0 --=-=-= Content-Type: text/plain -- Best, Amy --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 11:49:49 2025 Received: (at 77258) by debbugs.gnu.org; 29 Mar 2025 15:49:50 +0000 Received: from localhost ([127.0.0.1]:60916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyYRR-0000uq-Cn for submit@debbugs.gnu.org; Sat, 29 Mar 2025 11:49:49 -0400 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]:41543) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyYRN-0000uY-UM for 77258@debbugs.gnu.org; Sat, 29 Mar 2025 11:49:47 -0400 Received: from phl-compute-05.internal (phl-compute-05.phl.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id C46D92540197; Sat, 29 Mar 2025 11:49:39 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Sat, 29 Mar 2025 11:49:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm1; t=1743263379; x=1743349779; bh=Ek x1H90lhrN/t3Kmxcn4rkXcB8skSEb11Nsq8lckIzg=; b=B7PJabSpLTzgsh+Hoo ZFsTSW/nMAWAYAnz/u67UP+4WuwdYO4K2l+tHiC0ZRp1mZtNOfTQl0zzbjhCBRde JOl+z0U7mTIvlJ2RZ7XRMRBpJ377lUXeQ5HSdS3NdN4lugAAE4o1OAjGrWHJsBwo bKgJUYJf8vhL2gKOCboYFX/fvP33hsqpvUqZQMfBBQKRtPEG30CraaiOrSTjvO4x mVNttaJJgQyOnEG0BQZkJlEPOfESU8LCSlsPxqgXWuwEtNMp5Q0nAP9okxE/9Mek 7jkIWmAFsNWyzL7HULUQznN4tEG/MHLRzf+jhClMl8Dh0d5aiLP17vhlynWw2Csx YTIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1743263379; x=1743349779; bh=Ekx1H90lhrN/t3Kmxcn4rkXcB8sk SEb11Nsq8lckIzg=; b=c+LG8N2foHn3qjvdXRBg34THX6X0/XCymiVK03BIQ++K 3OxiysxyV9Aok/muMT2IrhaYeGsUHFUrTXG3b2hve9Cct9P2p3jAegWNafoKP01h pK0yuIVzMnYggJgcTXwlB1vvb3W6dZPNw11qHoLTr2S0Mzuni7LxUKEMQ3isTsj6 EgReJj8/ZNqxpVAtiTiXVCo49acZPFDkD8C3eoUz4oXx+CiHvuJqo3T1j+huOFkQ HcYX8PVmkY4mMxuwjhekgE7VF/jAbUqWtGtBCAxjS8dY9xXWEH+/a1vcVJ0GVJrU qcVusntH7H3qcw6aWU0HK5EvG8z4Nf7CXRqxXPMEmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujeegheekucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefufgffkfggtgfgsehtqhertddtreej necuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdhtvheqne cuggftrfgrthhtvghrnhepleekteeghfdvudeugfeghefgvddtvdefgfetvddvueettdev keettdejgfeufeeunecuffhomhgrihhnpehgnhhurdhorhhgpdhgihhtlhgrsgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghn sehrvghtrhhoshhpvggtrdhtvhdpnhgspghrtghpthhtohepvddpmhhouggvpehsmhhtph houhhtpdhrtghpthhtohepjeejvdehkeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgt phhtthhopehgrhhinhhnrdgrmhihsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Mar 2025 11:49:38 -0400 (EDT) From: Ian Eure To: Amy Grinn Subject: Re: [bug#77258] [PATCH] New package: emacs-boxy User-Agent: mu4e 1.12.9; emacs 29.4 Date: Sat, 29 Mar 2025 08:49:37 -0700 Message-ID: <87r02fet0u.fsf@retrospec.tv> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77258 Cc: 77258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hi Amy, Amy Grinn writes: > Hello, > > I would like to add my package, emacs-boxy, to Guix. > > This is my first patch to Guix so let me know if I did anything=20 > wrong! Thank you for contributing to Guix! Please see=20 (guix)Contributing[1] for info about sending patches. The Guix=20 tooling expects patches to be submitted with `git send-email', and=20 not mailed as an attachment. Other comments below. >>>From b3223cec32425d6b8cf2c11545ed63ad6dabae88 Mon Sep 17=20 >>00:00:00 2001 > From: Amy Grinn > Date: Tue, 25 Mar 2025 18:17:25 +0100 > Subject: [PATCH] gnu: Add emacs-boxy > > * gnu/packages/emacs-xyz.scm (emacs-boxy): New variable. > --- > gnu/packages/emacs-xyz.scm | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/gnu/packages/emacs-xyz.scm=20 > b/gnu/packages/emacs-xyz.scm > index f00c5e4b29..0423858b2f 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -39025,6 +39025,21 @@ (define-public emacs-boxquote > example code.") > (license license:gpl3+))) >=20=20 > +(define-public emacs-boxy > + (package > + (name "emacs-boxy") > + (version "2.0.0") > + (source (origin > + (method url-fetch) > + (uri (string-append=20 > "https://elpa.gnu.org/packages/boxy-" > + version ".tar")) Please prefer the upstream Git repo over M/ELPA. > + (sha256 (base64=20 > "6w1QtINpWz9voCrc/ne6q8sPj4UcA3s8E/f/Pebjz+0=3D")))) > + (build-system emacs-build-system) > + (home-page "https://gitlab.com/grinn.amy/boxy") > + (synopsis "A boxy layout framework") > + (description "Boxy provides an interface to create a 3D=20 > representation of boxes.") "Boxy" should probably reference the package name=20 (@code{emacs-boxy}), "This package," or similar. It would also be=20 nice to have a bit more info about what the package is used for. I also noticed a couple issues with the package itself which ought=20 to be corrected: - Your `defcustom' and `defface' forms don=E2=80=99t have `:group boxy',=20 so won=E2=80=99t appear if you `M-x customize-group RET boxy RET'. - Several macros from `cl-macs' are used, but `cl-macs' isn=E2=80=99t=20 required. ex. `cl-defstruct', `cl-flet*', possibly others.=20 `cl-lib' might also require `cl-macs', but you should always=20 require your direct dependencies instead of relying on=20 transitive ones. - You may want to condsider using symbols or keywords for=20 `boxy-relationships' instead of strings. Thanks, -- Ian [1]:=20 https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html#= Single-Patches-1 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 30 08:49:47 2025 Received: (at 77258) by debbugs.gnu.org; 30 Mar 2025 12:49:47 +0000 Received: from localhost ([127.0.0.1]:35335 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tys6j-0006cs-PY for submit@debbugs.gnu.org; Sun, 30 Mar 2025 08:49:47 -0400 Received: from msg-6.mailo.com ([213.182.54.16]:37682 helo=mailo.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyru3-000664-Tc for 77258@debbugs.gnu.org; Sun, 30 Mar 2025 08:36:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lavache.com; s=mailo; t=1743337275; bh=qYTBie3LfC/vvjKp5N9kWV/i2ztC/Fu/Ca6edScH65s=; h=X-EA-Auth:From:To:Subject:In-Reply-To:References:CC:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; b=Xdo1+jV40ObsqB35GpzbavDaVggl4a3Z7A88sg/rSVmeEZeCEi3Jap1nwP6W6War4 tHBCRiL80akGwJNm1YXB/eyzXJxNet8Dy5t2jVf2roncNmUFJzCqzSeZKHhF+87v6V E9/PSuYKFc3/tb2AP1L+t1b1mvVp78wjhd8p5DFE= Received: by b221-6.in.mailobj.net [192.168.90.26] with ESMTP via ip-20.mailobj.net [213.182.54.20] Sun, 30 Mar 2025 14:20:59 +0200 (CEST) X-EA-Auth: 8OXTR2YSVMWvPIQWA/X4VwkyOmYobbRnHtP8RlDINTgKwixnzW0ScCy6uc2nU4Bfq8/3/Eem2qKzyANteU5/qiuWN5Cr9p2fc/Fu+LViI3M= From: Amy Pillow To: Ian Eure Subject: [PATCH v1] gnu: Add emacs-boxy In-Reply-To: (Amy Grinn's message of "Sun, 30 Mar 2025 13:37:18 +0200") References: <87r02fet0u.fsf@retrospec.tv> Date: Sun, 30 Mar 2025 14:20:59 +0200 Message-ID: <87v7rq1zh0.fsf_-_@lavache.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77258 X-Mailman-Approved-At: Sun, 30 Mar 2025 08:49:44 -0400 Cc: 77258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-boxy): New variable. --- Hi, sorry, I changed my email address, but I do have a few questions about this contribution: > Hi Amy, > > Amy Grinn writes: > >> Hello, >> >> I would like to add my package, emacs-boxy, to Guix. >> >> This is my first patch to Guix so let me know if I did anything=20 >> wrong! > > Thank you for contributing to Guix! Please see=20 > (guix)Contributing[1] for info about sending patches. The Guix=20 > tooling expects patches to be submitted with `git send-email', and=20 > not mailed as an attachment. > I was going off of these instructions: https://guix.gnu.org/manual/en/html_node/Sending-a-Patch-Series.html which state that "Sending patches as email attachments may make them difficult to review in some mail clients, and git diff does not store commit metadata." I'm not sure how many email clients still have trouble viewing attachments in emails, but you seemed to have no problem, so I'm curious if maybe the instructions should be updated to explicitly state which patch formats are allowed and maybe give a different justification for it. I tried my best here to stick to the git send-email format, let me know if this is acceptable. > Other comments below. > >>>>From b3223cec32425d6b8cf2c11545ed63ad6dabae88 Mon Sep 17=20 >>>00:00:00 2001 >> From: Amy Grinn >> Date: Tue, 25 Mar 2025 18:17:25 +0100 >> Subject: [PATCH] gnu: Add emacs-boxy >> >> * gnu/packages/emacs-xyz.scm (emacs-boxy): New variable. >> --- >> gnu/packages/emacs-xyz.scm | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/gnu/packages/emacs-xyz.scm=20 >> b/gnu/packages/emacs-xyz.scm >> index f00c5e4b29..0423858b2f 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -39025,6 +39025,21 @@ (define-public emacs-boxquote >> example code.") >> (license license:gpl3+))) >>=20=20 >> +(define-public emacs-boxy >> + (package >> + (name "emacs-boxy") >> + (version "2.0.0") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append=20 >> "https://elpa.gnu.org/packages/boxy-" >> + version ".tar")) > > Please prefer the upstream Git repo over M/ELPA. > The upstream repo is not at a stable location, I've changed it once or twice already and I'm planning to do so again soon. Is it acceptable to use GNU ELPA? I see that other packages in emacs-xyz.scm are doing the same thing. >> + (sha256 (base64=20 >> "6w1QtINpWz9voCrc/ne6q8sPj4UcA3s8E/f/Pebjz+0=3D")))) >> + (build-system emacs-build-system) >> + (home-page "https://gitlab.com/grinn.amy/boxy") >> + (synopsis "A boxy layout framework") >> + (description "Boxy provides an interface to create a 3D=20 >> representation of boxes.") > > "Boxy" should probably reference the package name=20 > (@code{emacs-boxy}), "This package," or similar. It would also be=20 > nice to have a bit more info about what the package is used for. > Sure, I can do that. > I also noticed a couple issues with the package itself which ought=20 > to be corrected: > > - Your `defcustom' and `defface' forms don=E2=80=99t have `:group boxy',= =20 > so won=E2=80=99t appear if you `M-x customize-group RET boxy RET'. I think it's a little rude to point out a bug without actually checking if it exists. `M-x customize-group RET boxy RET' works fine. The `:group' option is unnecessary when you evaluate it after a `defgroup'. > - Several macros from `cl-macs' are used, but `cl-macs' isn=E2=80=99t=20 > required. ex. `cl-defstruct', `cl-flet*', possibly others.=20 > `cl-lib' might also require `cl-macs', but you should always=20 > require your direct dependencies instead of relying on=20 > transitive ones. cl-macs is part of the cl-lib package. You can see more info about how to use Common Lisp in Emacs here: https://www.gnu.org/software/emacs/manual/html_mono/cl.html > - You may want to condsider using symbols or keywords for=20 > `boxy-relationships' instead of strings. > Haha yes, maybe, it's far too late to change that now though. Maybe in version 3. > Thanks, > > -- Ian > > [1]:=20 > https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.htm= l#Single-Patches-1 > I appreciate all of your thoughts, please let me know if you need anything else! Best, Amy gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b5dc07acbb..8db221affb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -156,6 +156,7 @@ ;;; Copyright =C2=A9 2025 Skylar Hill ;;; Copyright =C2=A9 2025 Cayetano Santos ;;; Copyright =C2=A9 2025 Lee Thompson +;;; Copyright @ 2025 Amy Pillow ;;; ;;; This file is part of GNU Guix. ;;; @@ -39170,6 +39171,23 @@ (define-public emacs-boxquote example code.") (license license:gpl3+))) =20 +(define-public emacs-boxy + (package + (name "emacs-boxy") + (version "2.0.0") + (source (origin + (method url-fetch) + (uri (string-append "https://elpa.gnu.org/packages/boxy-" + version ".tar")) + (sha256 (base64 "6w1QtINpWz9voCrc/ne6q8sPj4UcA3s8E/f/Pebjz+0=3D")))) + (build-system emacs-build-system) + (home-page "https://gitlab.com/grinn.amy/boxy") + (synopsis "A boxy layout framework") + (description "@code{boxy} provides an interface to create a 3D +representation of boxes. Other packages can use this library to create +expandable menus for interacting with hierarchical data.") + (license license:gpl3+))) + (define-public emacs-buffer-env (package (name "emacs-buffer-env") base-commit: 2ed28b5c24c599b2f9bc60dfc93151cf489ca477 --=20 2.34.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 30 09:00:45 2025 Received: (at 77258) by debbugs.gnu.org; 30 Mar 2025 13:00:45 +0000 Received: from localhost ([127.0.0.1]:35381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tysHM-0007Es-Jh for submit@debbugs.gnu.org; Sun, 30 Mar 2025 09:00:45 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:60298 helo=mailo.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tysHJ-0007EX-BD for 77258@debbugs.gnu.org; Sun, 30 Mar 2025 09:00:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lavache.com; s=mailo; t=1743338732; bh=qYTBie3LfC/vvjKp5N9kWV/i2ztC/Fu/Ca6edScH65s=; h=X-EA-Auth:From:To:Subject:In-Reply-To:Date:References:CC: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; b=W7tEIbA1lIrmcKJeBUr/OYBCkNbnn4iLmrALUahqMcl6UWGYsfHUmOe6jSxTsancc +/DuMLyOpqExrwcpkg3Y0dgdsZzTttjgwzTKI9msq2bB9CcF7oXQTNj6s4fcpwwoHo eWH165G0c7Rd8xxgRf6UXaBms/+AzGwjfp7g1dxg= Received: by b221-6.in.mailobj.net [192.168.90.26] with ESMTP via ip-20.mailobj.net [213.182.54.20] Sun, 30 Mar 2025 14:45:27 +0200 (CEST) X-EA-Auth: Dvu835PIqK5Ep/1AAi53/orziIiWemn1rK9sJUyjX26pcSBv4jUogNM5roNt8H9e3DCP9BvUDZ1NqViJ5B4hl3pFuCAksQxY64xE6BW55s8= From: Amy Pillow To: Ian Eure Subject: [PATCH v1] gnu: Add emacs-boxy In-Reply-To: (Amy Grinn's message of "Sun, 30 Mar 2025 13:37:18 +0200") Date: Sun, 30 Mar 2025 14:20:59 +0200 Lines: 185 References: <87r02fet0u.fsf@retrospec.tv> User-Agent: Gnus/5.13 (Gnus v5.13) X-From-Line: nobody Sun Mar 30 14:21:00 2025 Message-ID: <87r02e1yc9.fsf@lavache.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77258 Cc: 77258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/emacs-xyz.scm (emacs-boxy): New variable. --- Hi, sorry, I changed my email address, but I do have a few questions about this contribution: > Hi Amy, > > Amy Grinn writes: > >> Hello, >> >> I would like to add my package, emacs-boxy, to Guix. >> >> This is my first patch to Guix so let me know if I did anything=20 >> wrong! > > Thank you for contributing to Guix! Please see=20 > (guix)Contributing[1] for info about sending patches. The Guix=20 > tooling expects patches to be submitted with `git send-email', and=20 > not mailed as an attachment. > I was going off of these instructions: https://guix.gnu.org/manual/en/html_node/Sending-a-Patch-Series.html which state that "Sending patches as email attachments may make them difficult to review in some mail clients, and git diff does not store commit metadata." I'm not sure how many email clients still have trouble viewing attachments in emails, but you seemed to have no problem, so I'm curious if maybe the instructions should be updated to explicitly state which patch formats are allowed and maybe give a different justification for it. I tried my best here to stick to the git send-email format, let me know if this is acceptable. > Other comments below. > >>>>From b3223cec32425d6b8cf2c11545ed63ad6dabae88 Mon Sep 17=20 >>>00:00:00 2001 >> From: Amy Grinn >> Date: Tue, 25 Mar 2025 18:17:25 +0100 >> Subject: [PATCH] gnu: Add emacs-boxy >> >> * gnu/packages/emacs-xyz.scm (emacs-boxy): New variable. >> --- >> gnu/packages/emacs-xyz.scm | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/gnu/packages/emacs-xyz.scm=20 >> b/gnu/packages/emacs-xyz.scm >> index f00c5e4b29..0423858b2f 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -39025,6 +39025,21 @@ (define-public emacs-boxquote >> example code.") >> (license license:gpl3+))) >>=20=20 >> +(define-public emacs-boxy >> + (package >> + (name "emacs-boxy") >> + (version "2.0.0") >> + (source (origin >> + (method url-fetch) >> + (uri (string-append=20 >> "https://elpa.gnu.org/packages/boxy-" >> + version ".tar")) > > Please prefer the upstream Git repo over M/ELPA. > The upstream repo is not at a stable location, I've changed it once or twice already and I'm planning to do so again soon. Is it acceptable to use GNU ELPA? I see that other packages in emacs-xyz.scm are doing the same thing. >> + (sha256 (base64=20 >> "6w1QtINpWz9voCrc/ne6q8sPj4UcA3s8E/f/Pebjz+0=3D")))) >> + (build-system emacs-build-system) >> + (home-page "https://gitlab.com/grinn.amy/boxy") >> + (synopsis "A boxy layout framework") >> + (description "Boxy provides an interface to create a 3D=20 >> representation of boxes.") > > "Boxy" should probably reference the package name=20 > (@code{emacs-boxy}), "This package," or similar. It would also be=20 > nice to have a bit more info about what the package is used for. > Sure, I can do that. > I also noticed a couple issues with the package itself which ought=20 > to be corrected: > > - Your `defcustom' and `defface' forms don=E2=80=99t have `:group boxy',= =20 > so won=E2=80=99t appear if you `M-x customize-group RET boxy RET'. I think it's a little rude to point out a bug without actually checking if it exists. `M-x customize-group RET boxy RET' works fine. The `:group' option is unnecessary when you evaluate it after a `defgroup'. > - Several macros from `cl-macs' are used, but `cl-macs' isn=E2=80=99t=20 > required. ex. `cl-defstruct', `cl-flet*', possibly others.=20 > `cl-lib' might also require `cl-macs', but you should always=20 > require your direct dependencies instead of relying on=20 > transitive ones. cl-macs is part of the cl-lib package. You can see more info about how to use Common Lisp in Emacs here: https://www.gnu.org/software/emacs/manual/html_mono/cl.html > - You may want to condsider using symbols or keywords for=20 > `boxy-relationships' instead of strings. > Haha yes, maybe, it's far too late to change that now though. Maybe in version 3. > Thanks, > > -- Ian > > [1]:=20 > https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.htm= l#Single-Patches-1 > I appreciate all of your thoughts, please let me know if you need anything else! Best, Amy gnu/packages/emacs-xyz.scm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b5dc07acbb..8db221affb 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -156,6 +156,7 @@ ;;; Copyright =C2=A9 2025 Skylar Hill ;;; Copyright =C2=A9 2025 Cayetano Santos ;;; Copyright =C2=A9 2025 Lee Thompson +;;; Copyright @ 2025 Amy Pillow ;;; ;;; This file is part of GNU Guix. ;;; @@ -39170,6 +39171,23 @@ (define-public emacs-boxquote example code.") (license license:gpl3+))) =20 +(define-public emacs-boxy + (package + (name "emacs-boxy") + (version "2.0.0") + (source (origin + (method url-fetch) + (uri (string-append "https://elpa.gnu.org/packages/boxy-" + version ".tar")) + (sha256 (base64 "6w1QtINpWz9voCrc/ne6q8sPj4UcA3s8E/f/Pebjz+0=3D")))) + (build-system emacs-build-system) + (home-page "https://gitlab.com/grinn.amy/boxy") + (synopsis "A boxy layout framework") + (description "@code{boxy} provides an interface to create a 3D +representation of boxes. Other packages can use this library to create +expandable menus for interacting with hierarchical data.") + (license license:gpl3+))) + (define-public emacs-buffer-env (package (name "emacs-buffer-env") base-commit: 2ed28b5c24c599b2f9bc60dfc93151cf489ca477 --=20 2.34.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 11:05:11 2025 Received: (at 77258-done) by debbugs.gnu.org; 3 Apr 2025 15:05:11 +0000 Received: from localhost ([127.0.0.1]:35166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0M7z-0004Fp-39 for submit@debbugs.gnu.org; Thu, 03 Apr 2025 11:05:11 -0400 Received: from mail-ed1-x533.google.com ([2a00:1450:4864:20::533]:53385) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u0M7u-00049W-LB for 77258-done@debbugs.gnu.org; Thu, 03 Apr 2025 11:05:08 -0400 Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-5e5e1a38c1aso1433931a12.2 for <77258-done@debbugs.gnu.org>; Thu, 03 Apr 2025 08:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=worcester.edu; s=google; t=1743692700; x=1744297500; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=rbDZXiVeqGqYj7NuRSFb8ifSY/dhd9e3MHEAzsypbYM=; b=dnl2qDPar1i1IVYayPC/ECorBH7DHlCpPUeTqgC0+dFWDecCA8LMMZx4nPiPdAmvSa ch5aiJgha3Jedvb26bkqB8YkVMhidvmB1XvzlQ663r6rdKWd8Aj9I3GLGL/RQ7IRR9Kq VIAag6QHYu+dCsm0/zgc83xBXXi0Du46TZvx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743692700; x=1744297500; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=rbDZXiVeqGqYj7NuRSFb8ifSY/dhd9e3MHEAzsypbYM=; b=rHxZCxNsbdhGItn0az0pUDXVBSiELtMFy/2NZTCMAtWV1X5CWp5YWbvDc3wq9fjBh3 e+o9kwSD670tY19jUdgLlDmzbuU/yBTYAsQpMeLIuZcHifklAqGnXmaVHI1JTewtZ1A3 aGokPwSOILlZ94gkRODHAYjhLPVW6USVN8PzJ40bGfLB+2QZlhGJpPt5WfuoiFcTBKc5 jxXFPJ9YS5ZqZqDa6w72URLJJTcKaiCh6Y16POmbxkI7dVAZ45tctjPRD8ho9dDVVTPQ CzA1b57kBZm2vrC3oVBT7UYaMb/nYNUa55HQVjTYr8F7C/yDDMRM7ZCc6h+9p6gtSEm+ IKuA== X-Gm-Message-State: AOJu0Yye/00eVSoP1RPV87JPEy7Mude0oaUUwbOju6ELvxrbX9RWT6GO PtYGrTiwJPRMJ4YnkZqpaxZG8LHhZt5UtXwOEQhT69F+vh4D/xzEqPBu6WRpu8clk+nB5tozWgT YiTplp9UlurDTruMa5UZo3R45+EDfQ6g3fRI80tUDkcxO2/gI X-Gm-Gg: ASbGncsSk+2gI75TJNpMwrwECDTt2EPL/ikjcETuoqR//ol6whSJtZUE4N3e+fRAZa6 x1Fn6jSam0eyI++fc0gOOlYkaKC/y0D3vWaMeW9hvZ2epEbGE8rxeuc7ibVcshRLBdfWgo7GKId Lpai9CRw7yl5si51BSvXbRzOMOxd+bdcYFX/fCbyq4 X-Google-Smtp-Source: AGHT+IFzJ56H9jrQlXXvuESoFakVRuEaLNDFUQv5EcCfbhzH5nr2FqFItL0pJR8Mirvyn8o/i/X8UC6lvEAaoIkzggU= X-Received: by 2002:a05:6402:3495:b0:5e0:49e4:2180 with SMTP id 4fb4d7f45d1cf-5f0871efaecmr2423675a12.25.1743692699590; Thu, 03 Apr 2025 08:04:59 -0700 (PDT) MIME-Version: 1.0 From: "Thompson, David" Date: Thu, 3 Apr 2025 11:04:48 -0400 X-Gm-Features: ATxdqUFaHodJnJvfGN2JGops6S43MIeT8eefLSBib_61Lg8GItco2-EHiR35jrA Message-ID: Subject: Re: [PATCH] New package: emacs-boxy To: 77258-done@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77258-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Amy, The latest version of your patch looks good overall. Thanks for expanding the description and adding a copyright line. As you mentioned, many packages in emacs-xyz.scm use tarballs from ELPA so given the instability of the upstream repo due to hosting migrations I think using an ELPA URL is just fine here. FWIW, patches as attachments are no problem for me. Whether inline or attachment, doing code review by email is just as frustrating. ;) Also, I think the comments from Ian about the code in the project itself are irrelevant to the discussion of this patch, which should be scoped to just the package recipe. I modified the hash to use the conventional base32 format and pushed to master. Congrats on your first Guix patch! - Dave From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 05:41:06 2025 Received: (at 77258-done) by debbugs.gnu.org; 4 Apr 2025 09:41:06 +0000 Received: from localhost ([127.0.0.1]:37104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0dXu-0000PX-I5 for submit@debbugs.gnu.org; Fri, 04 Apr 2025 05:41:06 -0400 Received: from msg-2.mailo.com ([213.182.54.12]:36504 helo=mailo.com) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0dXq-0000Oa-UP for 77258-done@debbugs.gnu.org; Fri, 04 Apr 2025 05:41:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lavache.com; s=mailo; t=1743758999; bh=2dxa5U961V2joQxADU9cEFBLTXtMNA8/o5br3Fg66GY=; h=X-EA-Auth:From:To:Subject:CC:Date:Message-ID:MIME-Version: Content-Type; b=E97NHF4VX1Q5AaB1QAFNdTMdXGg3Gh5yZ2ySuTjZgdvRX1EKK9MlhxSgyRD9SkYmi aqKZEk/LhxJZVd31vRY2ktHsHVgiFyv6EYvJB8azS/iHzzrpqVPjnGkC3DK7Br99// eGvMRl3gHvTApX2Z6HmEtaL+SBfbIh9bpym0IePQ= Received: by b221-4.in.mailobj.net [192.168.90.24] with ESMTP via ip-20.mailobj.net [213.182.54.20] Fri, 4 Apr 2025 11:29:16 +0200 (CEST) X-EA-Auth: tQ5a3gXximZjiWUVX1bF56e1kPjEjcMGn9Eq6M0HgceYWwvS9cF57Mosc4UNwEFQM+tFVZUNcgTFBCtLnYauhIomirr5fGheO1VCk2eHtFk= From: Amy Pillow To: "Thompson, David" Subject: Re: [PATCH] New package: emacs-boxy Date: Fri, 04 Apr 2025 11:29:13 +0200 Message-ID: <87a58wb7h2.fsf@lavache.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77258-done Cc: 77258-done@debbugs.gnu.org, Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Hi Amy, > > The latest version of your patch looks good overall. Thanks for > expanding the description and adding a copyright line. As you > mentioned, many packages in emacs-xyz.scm use tarballs from ELPA so > given the instability of the upstream repo due to hosting migrations I > think using an ELPA URL is just fine here. > > FWIW, patches as attachments are no problem for me. Whether inline or > attachment, doing code review by email is just as frustrating. ;) > > Also, I think the comments from Ian about the code in the project > itself are irrelevant to the discussion of this patch, which should be > scoped to just the package recipe. > > I modified the hash to use the conventional base32 format and pushed to master. > > Congrats on your first Guix patch! > > - Dave Thank you so much Dave, I appreciate it! I agree with everything you said and I think both the ELPA src url and patches-as-attachments will make it easier for me to contribute in the future. I also agree that issues in the source project should be addressed outside of the guix-patches mailing list. If anyone has an issue using the boxy library please use the forge's issue tracker (currently gitlab) instead of Guix'. That way, Emacs users who don't use Guix will be able to join the discussion. -- Best, Amy From unknown Thu Aug 14 12:25:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 May 2025 11:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator