From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 23 23:58:45 2025 Received: (at submit) by debbugs.gnu.org; 24 Mar 2025 03:58:45 +0000 Received: from localhost ([127.0.0.1]:53606 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twYxY-0002qm-Qy for submit@debbugs.gnu.org; Sun, 23 Mar 2025 23:58:45 -0400 Received: from lists.gnu.org ([2001:470:142::17]:43542) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twYxR-0002qT-BO for submit@debbugs.gnu.org; Sun, 23 Mar 2025 23:58:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twYxL-000700-Ge for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 23:58:31 -0400 Received: from mail-oa1-x43.google.com ([2001:4860:4864:20::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twYxJ-0001cd-H2 for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 23:58:31 -0400 Received: by mail-oa1-x43.google.com with SMTP id 586e51a60fabf-2b3680e548aso2774749fac.0 for ; Sun, 23 Mar 2025 20:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742788708; x=1743393508; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=CIAVAaKxp2mThElIFK9wtHYHbnUf3ATjP1kZ8/mzdzI=; b=X0MSqhJsv96bLqAmlZr7yJnPQNMDqAckDIvxafMCXDeaV/lE5AMyUUyLl34Ggpb8fA NjOGgOtb9s3JdYRjA2rxn1wzk8aV/m1aNu1yhOk6d7yS5OVkdjlINlvx3MyyC+Sbbtvz dbNUceFnB3XtTYFAZVKayuk0Zu0/wyGTgcbQ7tYTm+LgX9ET4kXcSiA3qY+/D7ni2qoF RZjCYix+vVmbU15dllNp7i8EMuO3Wga8EEq6JNjM2tgIRvRvrhZdX5BaXva2IWlTzui1 jpwWhNhPMAWyb3JFhzl5+JZJIU1dOmx1rL7OcksL72JkKC1A8xNLwwgetvBgYOF4syw/ IH/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742788708; x=1743393508; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=CIAVAaKxp2mThElIFK9wtHYHbnUf3ATjP1kZ8/mzdzI=; b=PR+f4YdaeDjXGXHk6KFs4nTtnG4aQ2MokudyvLbTXDw4uk4+se9WK9w2ET2xtvVp2J 4nnJQbBJxmsrZjythJKN+aoHAuxMIwsMHVOksWKb+6Xlq76ZSf6Y4qARkVZeFqc9MxGt bBAU5PlBJhanBmANRiNMERHu1/OINNCC/voJIYJGYJGNHHJz8MPCr5wQ8gy7hzTHi+rb f93eKE2ewne4JNTajse4YVohZrHJEhvqf+YJhfcQYBYidIFN8gKLl10UUqBPWD7FeoWU 7F90WZ9/9h/ISaE85lpafaSpsYx++415OEAEhgOi1RLjT9NmMTY0dYhjbXVi/G5qgYkh n7Zg== X-Gm-Message-State: AOJu0Ywtcl5RExqzFAyEjZ+iVLWPzTDNQArx6qYZWNLNowpfwCLj/ijt 1TDqBuWIz3jKDcyim5itiohmfnzKTgKZxqbZ+MY69k89FUT36mEBjZeNE2iS X-Gm-Gg: ASbGncvUyRLIGM6FL+BbQSHqzjIKtYsd+Jm4mLH/qk8SkgVeLtuehswMsFlTCUWxIHV dWL0900FFlnCyn55tO63aZIH5bF12B7uD5kEm2p/AcNcwlmrZu2dcjWehfcbZdFAUK77TGCNE51 +8xmsV+Yvzj7S3qcvGstSUYiw45KJd4ZbPFbowr1fQ6eknSZ0PdqdOEO36FajmU7P1YGhi0C9a4 //OO2sfK7gWtKxGOqwuJCBV3iQuSUcsBdrDwiJTKXMje2kUmicK9D0pCkjvqgjkPYeY4A6Okntx fULcuQs4diz+ X-Google-Smtp-Source: AGHT+IECfPj5RzWKuu8SmHHUc+Nh+4QUK404y94HaWc3gzDmYbej2+DOMp10cdEM/Bv6r7+/W0j5HQ== X-Received: by 2002:a05:6870:d14b:b0:29d:c6dd:cc6c with SMTP id 586e51a60fabf-2c7804952d4mr7689631fac.15.1742788707881; Sun, 23 Mar 2025 20:58:27 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2c77ece4132sm1865497fac.27.2025.03.23.20.58.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 20:58:27 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add 'project-customize-dirlocals' X-Debbugs-Cc: Date: Sun, 23 Mar 2025 21:58:26 -0600 Message-ID: <87r02nrsf1.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4860:4864:20::43; envelope-from=eg642616@gmail.com; helo=mail-oa1-x43.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch This patch add a new function for use =customize-dirlocals= in projects. customize-dirlocals by default creates a .dir-locals.el if there is not one found at current directory, this new function aims [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (eg642616[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (eg642616[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 HTML_MESSAGE BODY: HTML included in message X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Tags: patch This patch add a new function for use =customize-dirlocals= in projects. customize-dirlocals by default creates a .dir-locals.el if there is not one found at current directory, this new function aims to ensure to create (or open) one at current project root. --==-=-= Content-Type: text/html

Tags: patch

This patch add a new function for use customize-dirlocals in projects.
customize-dirlocals by default creates a .dir-locals.el if there is not
one found at current directory, this new function aims to ensure to
create (or open) one at current project root.

--==-=-=-- --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Add-project-customize-dirlocals.patch >From 31f1f80668aea33c3f130e792f010a35b1609519 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Sun, 23 Mar 2025 21:35:32 -0600 Subject: [PATCH] Add 'project-customize-dirlocals' * lisp/menu-bar.el (menu-bar-project-menu): Add new function entry to project menu. * lisp/progmodes/project.el (project-customize-dirlocals): New interactive command. --- lisp/menu-bar.el | 1 + lisp/progmodes/project.el | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 1685357fab6..6a68ad63a5b 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1830,6 +1830,7 @@ menu-bar-project-menu (define-key menu [project-compile] '(menu-item "Compile..." project-compile :help "Invoke compiler or Make for current project, view errors")) (define-key menu [separator-project-programs] menu-bar-separator) (define-key menu [project-switch-project] '(menu-item "Switch Project..." project-switch-project :help "Switch to another project and then run a command")) + (define-key menu [project-customize-dirlocals] '(menu-item "Customize Directory Local Variables" project-customize-dirlocals :help "Customize current project Directory Local Variables.")) (define-key menu [project-vc-dir] '(menu-item "VC Dir" project-vc-dir :help "Show the VC status of the project repository")) (define-key menu [project-dired] '(menu-item "Open Project Root" project-dired :help "Read the root directory of the current project, to operate on its files")) (define-key menu [project-find-dir] '(menu-item "Open Directory..." project-find-dir :help "Open existing directory that belongs to current project")) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index e2cd5bfa231..158f334fea3 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1391,6 +1391,12 @@ project-vc-dir (interactive) (vc-dir (project-root (project-current t)))) +;;;###autoload +(defun project-customize-dirlocals () + "Run `customize-dirlocals' in current project's root." + (interactive) + (customize-dirlocals (concat (project-root (project-current t)) ".dir-locals.el"))) + (declare-function comint-check-proc "comint") ;;;###autoload -- 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 05:45:39 2025 Received: (at 77229) by debbugs.gnu.org; 24 Mar 2025 09:45:39 +0000 Received: from localhost ([127.0.0.1]:54259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tweNH-00040h-0o for submit@debbugs.gnu.org; Mon, 24 Mar 2025 05:45:39 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]:47182) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tweNE-00040J-7Z for 77229@debbugs.gnu.org; Mon, 24 Mar 2025 05:45:36 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-22401f4d35aso82715065ad.2 for <77229@debbugs.gnu.org>; Mon, 24 Mar 2025 02:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742809530; x=1743414330; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=bN1N4NfIk2U22awQJnbCuSzv1XiFTFYwnBw+9rglulo=; b=hWegMLKbz91lz2iAMxDd7Nc1vYSqAa3qFmUCAF/w9o55CBKsNGjNAx0fwndw8N1G8S mnLLWn7Ld9Uv/lWuzYlTp7XOUrN3f93MrxyUlgnF2QiFJh3ERhGQ9krC4e66nP8mrSUO J0UFTJhCbAuyaCZUIp2+ium/Phr+TppWskcspLCXwGVuaZSS0/rTrxnDECymwVkP/KN7 H3VyMSTOwLUKIcRCOIDhzbm5miGw7UtgeYqe6RoSly35+h60cD4z2jhKizOYnjPmRVdL su2VEM3DW3cGdpzCERPFlfgmUpk7RwMh60/XgjJ1Q1ouCbUKhIWDPBO4v6ZOygukG1TW F/PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742809530; x=1743414330; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bN1N4NfIk2U22awQJnbCuSzv1XiFTFYwnBw+9rglulo=; b=QPW+kGljSlf6pIu05oVEcm2aZJz8OhOOwm3m1o1TRK0ekPxMbTxuOKzr9Wl0KgEeGC qWxvXYhifUE7p94usvtCl1RBvb/09NXuv429NfdEo3TXHEB5qV2t+4+mtHLJAATDsCmc zMe9A/n5IPsCgpEVzhYkP584G2k1UjaP3XIqwkV6g9RvouOfr2xsMIcueSj1M8uzMS/W tn3sDCVDVyzUYt2zg+shYtLesf/5t+a3/eaK0qIMgCXk3mmBNZC/IAmYp4Dj/6ltxZwm wRt4cKX//WpLL971AgcbKmrGgqw/TVw/I5teI1EeZCzHoSh+11xkC9v230POX71EjS6y lyUQ== X-Forwarded-Encrypted: i=1; AJvYcCXKJOvZrXsK2WwN9hvdeSeJgZzqwjEO1Km2BykSSe1zl+EnpT7/S4pWvnGsgkVtzYiCOSAQ6w==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwJC4bjwMhgI7KfCi6tjBbI1gANOphd/Wufx/fl5Z6cRec48QjD F5hHJBMVyMRbj8pUygt9/Z3XJN8WfAZCWl9kiDgtIgW6GOjUj0WBbKk7Osr8 X-Gm-Gg: ASbGncuLLWlr2tHA2l9dCRfcbd8lWxwuIJUU6oTc6yqyc0h/OKob8QB4w92oP4HyZus ZeGP0e/pnlyILxtNknUHcIfA90dsLKG5pF2sShNUnZ/cZroC3s2aCCqxbGUqV3g3H/OYebEd6n+ r/+KXUYbhDp49+gc7ZCOik4cIl+mKOfQElAd31qDmcdgV7hvB+jmy/EyuXGqw7/stfhNjGUuqCg qs/zVkjv4DmnAoSw1bdp/XAaosUorE+zsCeI7NPagSvoQhTUBhPBNIvTxQbsSWwnIDmsWXk02dq sbaXHZSJ2EjaeNYgAN4Nuu2lh5CUDHb0cAG0qiztueGFYeaHn14= X-Google-Smtp-Source: AGHT+IHLkl7WK/frA5pMBgxRbZywclyg1aP7IR+YoIaZN6HMjctKdWEDk5DmOv4tbPRMmr2GuKjjpQ== X-Received: by 2002:a17:902:d58c:b0:220:ce37:e31f with SMTP id d9443c01a7336-22780d7e9bemr196908325ad.17.1742809529999; Mon, 24 Mar 2025 02:45:29 -0700 (PDT) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7390611d580sm7427760b3a.119.2025.03.24.02.45.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Mar 2025 02:45:29 -0700 (PDT) Message-ID: Date: Mon, 24 Mar 2025 06:45:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77229: [PATCH] Add 'project-customize-dirlocals' To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= , 77229@debbugs.gnu.org References: <87r02nrsf1.fsf@gmail.com> Content-Language: en-US From: Mauro Aranda In-Reply-To: <87r02nrsf1.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77229 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe Pérez writes: > Tags: patch > > This patch add a new function for use customize-dirlocals in projects. > customize-dirlocals by default creates a .dir-locals.el if there is > not one found at current directory, this new function aims to ensure > to create (or open) one at current project root. Thanks. I had that in my original package, but it seems I completely forgot to add it back then. >>From 31f1f80668aea33c3f130e792f010a35b1609519 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= > Date: Sun, 23 Mar 2025 21:35:32 -0600 > Subject: [PATCH] Add 'project-customize-dirlocals' > > * lisp/menu-bar.el (menu-bar-project-menu): Add new function > entry to project menu. > * lisp/progmodes/project.el (project-customize-dirlocals): > New interactive command. Please mention the Bug#. > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1391,6 +1391,12 @@ project-vc-dir > (interactive) > (vc-dir (project-root (project-current t)))) > > +;;;###autoload > +(defun project-customize-dirlocals () > + "Run `customize-dirlocals' in current project's root." > + (interactive) > + (customize-dirlocals (concat (project-root (project-current t)) ".dir-locals.el"))) > + Would you change it to use file-name-concat or expand-file-name? From past discussions, I think that using concat for file names is discouraged. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 08:57:50 2025 Received: (at 77229) by debbugs.gnu.org; 24 Mar 2025 12:57:50 +0000 Received: from localhost ([127.0.0.1]:54697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twhNG-00006d-35 for submit@debbugs.gnu.org; Mon, 24 Mar 2025 08:57:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48396) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twhNC-00006M-C1 for 77229@debbugs.gnu.org; Mon, 24 Mar 2025 08:57:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twhN6-0003oC-Il; Mon, 24 Mar 2025 08:57:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CHkFFSSqG7HlFct0hBDMuemoJzYCcklk6zs/fDE49lI=; b=dRkFac73z7sY n7n3AYxU2VK0Y3mlb2Sm42pKiVpU78yfPZujgXpKtIdK0hG8OrobOaOlXyR/eFmrsBq714yYh480u RL7zPu98xi2la0/b83f1HxNccIxCdDlUZ5MQ+JsucoqLWCmAA1VJTKBCYlyaUqjZD2+iYtmAJ9AX0 99ino9uOvIyxc9VDfW4c4Jq9ShcW4GFpaRtRmmaQFZohrr+giPKZK2RnOyLkACoIM33Jdov0RfcbV uorvTk7h4spFBvhHsKZdIuYghSEWSJJlmNQeL9ZDL9ecKtsq34qR9egfXnmdNjIcBk764548hc2ZQ tFmZ7ir5eO3+dJsiVcT4tg==; Date: Mon, 24 Mar 2025 14:57:35 +0200 Message-Id: <865xjyfuww.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: (message from Mauro Aranda on Mon, 24 Mar 2025 06:45:27 -0300) Subject: Re: bug#77229: [PATCH] Add 'project-customize-dirlocals' References: <87r02nrsf1.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77229 Cc: eg642616@gmail.com, 77229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 24 Mar 2025 06:45:27 -0300 > From: Mauro Aranda > > > +(defun project-customize-dirlocals () > > + "Run `customize-dirlocals' in current project's root." > > + (interactive) > > + (customize-dirlocals (concat (project-root (project-current t)) > ".dir-locals.el"))) > > + > > Would you change it to use file-name-concat or expand-file-name? From > past discussions, I think that using concat for file names is > discouraged. Yes, but file-name-concat is also not right here. Please use expand-file-name. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 14:25:04 2025 Received: (at 77229) by debbugs.gnu.org; 24 Mar 2025 18:25:04 +0000 Received: from localhost ([127.0.0.1]:58184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twmTv-0005K2-Rx for submit@debbugs.gnu.org; Mon, 24 Mar 2025 14:25:04 -0400 Received: from mail-oo1-xc42.google.com ([2607:f8b0:4864:20::c42]:49438) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1twmTt-0005IY-3i for 77229@debbugs.gnu.org; Mon, 24 Mar 2025 14:25:01 -0400 Received: by mail-oo1-xc42.google.com with SMTP id 006d021491bc7-6021e3daeabso2095455eaf.3 for <77229@debbugs.gnu.org>; Mon, 24 Mar 2025 11:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742840695; x=1743445495; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=DLV3ALWRm9533uPKo5CLRYXa46amEmVbK4yGr5zKC40=; b=mmwVFa7ZPojvLgFlxmTnvcthc3iEAF4Kq/Pd1tqXm2aP8/5MtS5ROpvU7y+cPzR3nb 8eqehvqVAX9Jfe7nan/X36A62R4WDwio6TuvsOYyRlZExpvDEKSnQHhFZFH/nKjN1z63 2yGL91x00uNB7nEbJamFNccSww2GOwROH+9SpJBAd9qQLa0bOOI7QfSjpePywySsJJGm C6baAvHeZ/498sinyvpC+80ZNRhca4C0lI56pO74otDgizmvDDjsnb8LA+pfzRDhZsc2 aYtgF+gJxyQadkE4vqVdG/Rik26i1NgWy6kuj6aEoko39bAyFrIq5TSkyXIiw3d5Jksy CSHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742840695; x=1743445495; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DLV3ALWRm9533uPKo5CLRYXa46amEmVbK4yGr5zKC40=; b=DNw2i48vXyi540veClsTiUljP7i3qpYmjMMJvqip1wCSu5gk1sxsbM0aZ5q4uZfPmR Vf1McaoKTMq4kasn9iViCmwkDaZqXHKvJhvAc9zt/g9vvAbN3vKbz/0kmFxqF74ASKW9 d081K6Z4dK1aXwHVVKjCylaZIeGtNyR5isfgPCjle08/yBzFvK7pjUBrA9QLRPWtUBQr K6iXTiKS68FSzkFob/lHRsDX5D8Z4hx4ZIgdcyADwC8frXEtnEh1kwSe3+xIPkko2ncw l+Yoc8Hcw+t/q8AQsdwtLBlpzBeRNoIeQZM4gp+JxaNS7ZZAkl8LLC9ZcPlVcGgIvG0Y zAHw== X-Forwarded-Encrypted: i=1; AJvYcCVp1UBBGSetf/l2BUrEEiNzylQotOIzr64Ny5XgWonEEP8B4W7NTdoz1Ext8CVGE85lz8qB7w==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx24ENaxS3H2M6eFUIjnZpL53wUjzaBqdk2+WZoh2lztv3tM6L/ IDhXFVoyDkamfKwop+b8fX1M92W6iJY0tEjj9K56gXAn326fpRpbZptLKAoN X-Gm-Gg: ASbGncsOc82pszUdX2a/hspNhCReAxiwUoLFwmsMrv2afUavvh9RJO+F7dbT9H6TcqY 03bUldrFi4/hmCb3DPN3ciLW0yajgXtS7jAEqfjyYfj5j+owWix58CKK4/RRBP1AdmNQzWu2eAT w6c61/h+X3xejmrjAB9S+QWecUsaDsNjzr4zclbd9oMbcNm5LaNYS+RbCHbo8N0qi9g0sbZ2f7m QollP+HqC8dmfdlo5GD2Zu2FfESpktcRfdd0FDeZL52+WyJtRZy53wgmnRNMVox3TsohShAFR/2 CJa9FJtYNdIR X-Google-Smtp-Source: AGHT+IE486Sd33ItbrRJ+Z6EUDg17FRMKnyIt9WpWnOAR3VdlXdT9SQlj9Qrcr8lgWuGzxGIHxtDjw== X-Received: by 2002:a05:6820:2406:b0:5fc:fb1a:2b8a with SMTP id 006d021491bc7-602346041afmr6758747eaf.6.1742840694847; Mon, 24 Mar 2025 11:24:54 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-602346dce01sm1290911eaf.8.2025.03.24.11.24.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 11:24:54 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77229: [PATCH] Add 'project-customize-dirlocals' In-Reply-To: <865xjyfuww.fsf@gnu.org> References: <87r02nrsf1.fsf@gmail.com> <865xjyfuww.fsf@gnu.org> Date: Mon, 24 Mar 2025 12:24:53 -0600 Message-ID: <87wmcel216.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77229 Cc: 77229@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Eli Zaretskii writes: >> Date: Mon, 24 Mar 2025 06:45:27 -0300 >> From: Mauro Aranda >> > +(defun project-customize-dirlocals () >> > + "Run `customize-dirlocals' in current project's root." >> > + (interactive) >> > + (customize-dirlocals (concat (project-root (project-current t)) >> ".dir-locals.el"))) >> > + >> Would you change it to use file-name-concat or expand-file-name? From >> past discussions, I think that using concat for file names is >> discouraged. > Yes, but file-name-concat is also not right here. Please use > expand-file-name. Done. --==-=-= Content-Type: text/html

Eli Zaretskii <eliz@gnu.org> writes:

Date: Mon, 24 Mar 2025 06:45:27 -0300
From: Mauro Aranda <maurooaranda@gmail.com>

+(defun project-customize-dirlocals ()
+ "Run `customize-dirlocals' in current project's root."
+ (interactive)
+ (customize-dirlocals (concat (project-root (project-current t))
".dir-locals.el")))
+

Would you change it to use file-name-concat or expand-file-name? From
past discussions, I think that using concat for file names is
discouraged.

Yes, but file-name-concat is also not right here. Please use
expand-file-name.

Done.

--==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-project-customize-dirlocals.patch >From feb95a04b34e92bc59611e21eb775d76d219a8cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Sun, 23 Mar 2025 21:35:32 -0600 Subject: [PATCH] Add 'project-customize-dirlocals' * lisp/menu-bar.el (menu-bar-project-menu): Add new function entry to project menu. * lisp/progmodes/project.el (project-customize-dirlocals): New interactive command. (Bug#77229) --- lisp/menu-bar.el | 1 + lisp/progmodes/project.el | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 1685357fab6..6a68ad63a5b 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1830,6 +1830,7 @@ menu-bar-project-menu (define-key menu [project-compile] '(menu-item "Compile..." project-compile :help "Invoke compiler or Make for current project, view errors")) (define-key menu [separator-project-programs] menu-bar-separator) (define-key menu [project-switch-project] '(menu-item "Switch Project..." project-switch-project :help "Switch to another project and then run a command")) + (define-key menu [project-customize-dirlocals] '(menu-item "Customize Directory Local Variables" project-customize-dirlocals :help "Customize current project Directory Local Variables.")) (define-key menu [project-vc-dir] '(menu-item "VC Dir" project-vc-dir :help "Show the VC status of the project repository")) (define-key menu [project-dired] '(menu-item "Open Project Root" project-dired :help "Read the root directory of the current project, to operate on its files")) (define-key menu [project-find-dir] '(menu-item "Open Directory..." project-find-dir :help "Open existing directory that belongs to current project")) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index e2cd5bfa231..56e72caae1d 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1391,6 +1391,12 @@ project-vc-dir (interactive) (vc-dir (project-root (project-current t)))) +;;;###autoload +(defun project-customize-dirlocals () + "Run `customize-dirlocals' in current project's root." + (interactive) + (customize-dirlocals (expand-file-name ".dir-locals.el" (project-root (project-current t))))) + (declare-function comint-check-proc "comint") ;;;###autoload -- 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 31 07:26:19 2025 Received: (at 77229) by debbugs.gnu.org; 31 Mar 2025 11:26:19 +0000 Received: from localhost ([127.0.0.1]:40090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tzDHW-0008LW-F7 for submit@debbugs.gnu.org; Mon, 31 Mar 2025 07:26:19 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]:47284) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tzDHU-0008Ks-Kr for 77229@debbugs.gnu.org; Mon, 31 Mar 2025 07:26:17 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-22401f4d35aso84259315ad.2 for <77229@debbugs.gnu.org>; Mon, 31 Mar 2025 04:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743420370; x=1744025170; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2JoCtk6p2H+S4XICeJ/ltAc23rwfqUqCOwEmXzwAvXs=; b=i56S+z6rBsGxy3rSv8E8mmhbIdgkSJjfLSu2W0Dkm6ZffrPxI+kf1xoslxhSjqnyvn dvrB4OkG4FHGqLAXOCkp4JGtH45zkGFQobWXcODK94kpBpeus9BxOFIuasmwqOZfPcdx 1J9s5IGEf4t7UapmZVGTVKQZAKBq2oikKVa1HwycPSWZcL98qqrIPruFDFzNwr/wsIUE +kePeTKQm0DtI3BQTva4y4OiXspqqMcRUJVoPn1AxKbONnfXw3aHVQrdDA9egTUB9RoW tSuKV/wfEtx1kwZerVP7lS3rbyxUyTxWsRRTTeOA52dfy3kYDnUzB/bzMAHzvvn4y/jh eAGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743420370; x=1744025170; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2JoCtk6p2H+S4XICeJ/ltAc23rwfqUqCOwEmXzwAvXs=; b=itTgc73qPfZdHIhyknVDhGtoEWLhiLIjoAMy9xvYSSoQplkH4z9L0F0+/qKKFMzXV+ i3c7z1yNUigLhsJC0dwxmMGRnDXWX9XE86vaZU8lVV6Cb8Mz4vWXDl1AZWEWPsEGk+0F T/m3K7mFGCCSLXnnQ+00Mi5p67j9JJhh98YwPV0u4OPzkzyi414nkMtZivcpyhUIiFpj FTo1+pq5xpu6LQyY6c6oB/yzuaRHBPqyuR29tXUZ6xpUmlf68DlbAdGMS3xl2Wf9YG6B 37WMj++5+mH866BsBMZuV3VSxY3yanjFmOvyWJWpPcKL0GlF3OXGNoTwA8OtmKZsCAaB d8rw== X-Gm-Message-State: AOJu0YwgOtiyp5urjkP176BHPHcEeGI1whhvqZL3itoLC4mQhLjpNA/q FkPueAoTU5gYr+lJN5mXGeoN+caxRGl8TFaqFWrWh3uDNjMCTakP X-Gm-Gg: ASbGncsmkkovmXXx+WH0vWPv/7XEVgGY8tmS75ozndbncj8DsSgRqdckMM6DgEphG+w O25qxQ4RI2YS6+RJpCR7ILf7hb6CmS3AKUfayyp13vKtTBHixuO2BDngrA0xszgCFb/c/YhSSjc y9dwLnt46tRFDwJ27Gsye1Pxl/Gn6MiOpf5NzBTpX8akYh1FB5SLg4BtIE9HSxnieP0UxfgDzPZ 9f79/776nILVKhHp7uiXRGNzQ2Mp8wSAvoMO5UwDG/HuNT1IJ378Yosn1Dxn3Um93aJQmsvGl8o igsdoQr1cRPGYquuWqfOamaO5S1cDu3v+twIEY4sDuC9g/1lpTUtuoG54wFjLA== X-Google-Smtp-Source: AGHT+IGIEcEgUErVeKduvUDWYlhAKsfl0PN4I7uI60jrPnX963qx6TId5+Rf2wCXJbVA1Sxy0iSBiQ== X-Received: by 2002:a05:6a21:3414:b0:1f5:83bd:6cc1 with SMTP id adf61e73a8af0-2009f39641bmr16535026637.0.1743420370448; Mon, 31 Mar 2025 04:26:10 -0700 (PDT) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af93ba0e4f0sm6125882a12.72.2025.03.31.04.26.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Mar 2025 04:26:09 -0700 (PDT) Message-ID: Date: Mon, 31 Mar 2025 08:26:06 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77229: [PATCH] Add 'project-customize-dirlocals' To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= References: <87r02nrsf1.fsf@gmail.com> <865xjyfuww.fsf@gnu.org> <87wmcel216.fsf@gmail.com> Content-Language: en-US From: Mauro Aranda In-Reply-To: <87wmcel216.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77229 Cc: Eli Zaretskii , 77229@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe Pérez writes: > Eli Zaretskii writes: > >  Date: Mon, 24 Mar 2025 06:45:27 -0300 >  From: Mauro Aranda > >  +(defun project-customize-dirlocals () >  + "Run `customize-dirlocals' in current project's root." >  + (interactive) >  + (customize-dirlocals (concat (project-root (project-current t)) > >  ".dir-locals.el"))) > >  + > >  Would you change it to use file-name-concat or expand-file-name? From >  past discussions, I think that using concat for file names is >  discouraged. > >  Yes, but file-name-concat is also not right here. Please use >  expand-file-name. > > Done. >>From feb95a04b34e92bc59611e21eb775d76d219a8cb Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= > Date: Sun, 23 Mar 2025 21:35:32 -0600 > Subject: [PATCH] Add 'project-customize-dirlocals' > > * lisp/menu-bar.el (menu-bar-project-menu): Add new function > entry to project menu. > * lisp/progmodes/project.el (project-customize-dirlocals): > New interactive command. (Bug#77229) Nit: "Interactive command" sounds redundant.  And I think we leave two spaces after the period in commit messages too. > diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el > index 1685357fab6..6a68ad63a5b 100644 > --- a/lisp/menu-bar.el > +++ b/lisp/menu-bar.el > @@ -1830,6 +1830,7 @@ menu-bar-project-menu >      (define-key menu [project-compile] '(menu-item "Compile..." project-compile :help "Invoke compiler or Make for current project, view errors")) >      (define-key menu [separator-project-programs] menu-bar-separator) >      (define-key menu [project-switch-project] '(menu-item "Switch Project..." project-switch-project :help "Switch to another project and then run a command")) > +    (define-key menu [project-customize-dirlocals] '(menu-item "Customize Directory Local Variables" project-customize-dirlocals :help "Customize current project Directory Local Variables.")) >      (define-key menu [project-vc-dir] '(menu-item "VC Dir" project-vc-dir :help "Show the VC status of the project repository")) >      (define-key menu [project-dired] '(menu-item "Open Project Root" project-dired :help "Read the root directory of the current project, to operate on its files")) >      (define-key menu [project-find-dir] '(menu-item "Open Directory..." project-find-dir :help "Open existing directory that belongs to current project")) > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index e2cd5bfa231..56e72caae1d 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1391,6 +1391,12 @@ project-vc-dir >    (interactive) >    (vc-dir (project-root (project-current t)))) > > +;;;###autoload > +(defun project-customize-dirlocals () > +  "Run `customize-dirlocals' in current project's root." > +  (interactive) > +  (customize-dirlocals (expand-file-name ".dir-locals.el" (project-root (project-current t))))) Nit: Rearrange this last line to respect the 80-character limit. More importantly, I think this new command should be announced in NEWS. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 31 15:52:29 2025 Received: (at 77229) by debbugs.gnu.org; 31 Mar 2025 19:52:30 +0000 Received: from localhost ([127.0.0.1]:42969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tzLBN-00051O-L6 for submit@debbugs.gnu.org; Mon, 31 Mar 2025 15:52:29 -0400 Received: from fhigh-b5-smtp.messagingengine.com ([202.12.124.156]:38559) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tzLBL-00050a-1R for 77229@debbugs.gnu.org; Mon, 31 Mar 2025 15:52:27 -0400 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfhigh.stl.internal (Postfix) with ESMTP id 506462540127; Mon, 31 Mar 2025 15:52:21 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Mon, 31 Mar 2025 15:52:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1743450741; x=1743537141; bh=puBfB8Y9l9jFzJ0idTdwyr8KStsghcXc/tvgDmhyTk8=; b= asaM9xE3RopNvvJG1baV2Xdi4jJJJwBUQWZHPOTL3CB4bwIwaTddX8Y7qr/KyftJ umdDcnLEpzEuNdx0oI8J9y/peMzM3zosxjAMmCiu4LBIkQ7uD8P1oVxaXGGYZL4U XeKsh4k0ik3T1wouzkYhbY2iNsm5wJ6DLPnILmMwy+pprrLKQrpwYLICPsxNlZTe /1PZw0Fj4bSuJnZ9SSRKYOCPtTYG/FjxmlMR+qSoAFR8f4Uu2vce5c00pi/M1mOF 7vKLpeYBh9Y/cERzTasjWOvMgz/Wvbm333/XnOq+lkg32C0a21YB5mkDtm7d+UKE 7kChI6xn5KtQ8YOWwUvt0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1743450741; x= 1743537141; bh=puBfB8Y9l9jFzJ0idTdwyr8KStsghcXc/tvgDmhyTk8=; b=T n6gIKpAO+e4P1JbTxcBhEZ5TH+kjbMriAk9fFzTJarrjKW8UUKzglH4F+Wi/+fxO SdC5O3RripLRAzIlqdiMfsNyjLiSlqwyIikVrEt6+qizDntdbxsCWK1rf1pI9USn lhWFwTDSbDzWwKVjpPdZEGQTTDm11Y5KCSKeYqoE/ggQ6Fu5KZ0sy4KpyT/+XLED yRTFyONOMIZ106Zj8pZ+YjwsxKDRiam6avVMdRaIhtFZtCCCxU50+u0zBMm0fqeV X2dKHiapMx5w9JUmaR1iQtGK53gk9m5mrzKXmndKkuLlOT/lwOicBKhhS3wUg2Mg BPDCK5ZuWos75KgjomRbQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddukedtkeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddt vdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovh druggvvheqnecuggftrfgrthhtvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeet veegtedthefhudekteehffeukeeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphht thhopeegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvgheigedvieduieesgh hmrghilhdrtghomhdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthho peejjedvvdelseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepmhgruhhroh horghrrghnuggrsehgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 31 Mar 2025 15:52:19 -0400 (EDT) Message-ID: <380b65a7-e3f9-4207-bd24-bacd0a0e8591@gutov.dev> Date: Mon, 31 Mar 2025 22:52:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77229: [PATCH] Add 'project-customize-dirlocals' To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= , Eli Zaretskii References: <87r02nrsf1.fsf@gmail.com> <865xjyfuww.fsf@gnu.org> <87wmcel216.fsf@gmail.com> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <87wmcel216.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77229 Cc: 77229@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 24/03/2025 20:24, Elijah Gabe Pérez wrote: > Yes, but file-name-concat is also not right here. Please use > expand-file-name. > > Done. FWIW, looks good to me. Waiting for the updated version with the NEWS entry, to install. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 31 16:21:39 2025 Received: (at 77229) by debbugs.gnu.org; 31 Mar 2025 20:21:39 +0000 Received: from localhost ([127.0.0.1]:43082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tzLda-00089b-3O for submit@debbugs.gnu.org; Mon, 31 Mar 2025 16:21:38 -0400 Received: from mail-ot1-x344.google.com ([2607:f8b0:4864:20::344]:51540) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tzLdW-00088q-DF for 77229@debbugs.gnu.org; Mon, 31 Mar 2025 16:21:34 -0400 Received: by mail-ot1-x344.google.com with SMTP id 46e09a7af769-72c40235c34so1226879a34.3 for <77229@debbugs.gnu.org>; Mon, 31 Mar 2025 13:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743452488; x=1744057288; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/OhdWr7wxSZaQHC7hSUZgfG8l3j6ZnFYsYWuTtahRvE=; b=RQ+L3/rhSZWXlBGa362kemhYcUisQQ6NRkF5KoLmWMiKyNFIM/rybZgeFL0yeQsFHC j3nP0pxKEC13BxM9voYSDIQeUgvVft7TzBcDE3o8FJFUeDAnp/FDDsmOv0K31RlSScPd 3bD+c50LprT2IyxQ10shpsOZx2xEQJbJLYlCd/e3iuMb+xQr7crZwpaPG4ODodcoyDx4 FAi+NFPKy82I4Hbu02ArWV7IF14HK4R0HOMsksVzINFQvmbpl8sgkzGe/JZFGZ3SbfDl YatWD4OFoiUMWFEmznD001HGI/kcrYHx3kR0+6PtcRZ/IyZnjAwxc5m32rBddSK6Sx0E KEXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743452488; x=1744057288; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/OhdWr7wxSZaQHC7hSUZgfG8l3j6ZnFYsYWuTtahRvE=; b=WFpH3tC1+6FexaUo3SmCHvN12XG+yA3RirHT0ITmo0ll/R+PNBfVU/krZAzUCfuzZ4 sVLFwjkCmyHMKL1ZDBUfajioaVMVSCwVmrSNyxQTqkoxbZsiBKdyffS9NPIS0jHTu1R2 wC++fK8bUZ+t7oJ3dDrZE3WtYhRAwCGGScrLHPaFaz4vX43Gd1E+huRWaZwmHwYGw/cN TfxGy96/eY5M6ciIn1qJe84QyE4rX1CE0cU9CHR3i7gkz0HNfPgUi1QY23wA+Cpm+JuS JmpAw24UtRRh5z10WFLN7qxELKhDAW/14A0UkklNA5hNzB1DNtOGKqg7M8p9WYQRQ/ui AIdg== X-Forwarded-Encrypted: i=1; AJvYcCWRGZKkuRMZ404bdqz22FnU6atNa3IJjvTjMCzjEC7CGh5LjFpKbhkEJR4bfksZx6YhIPYdow==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxKHTr3zGYh37oMFtiIuAZ3szQzywIvqe4kdHpZ1ABE7ImUBvOM ySAKXM7EmnizsWce3kXnr1T/MQKKLY+GGadBMeJHL4WK6iIExylX X-Gm-Gg: ASbGncs54lediAgufNi00b5ECiYgZQeGqr/+9T/b/we/Z3BIRxXToAOCJDeDESUAN+e QzPXNB8jnjAKK0JnSOnwvotcnlkeOs3RgM5E0uACADqbtFiPv/X05Rae3uFhg7h8Q5kp3imMW0I EEomyCn/60lSXIHZyETYsj8jieIlWm+xvSGyHMixhoJ+MlMY9YtXq46VqVsQW78XV8j7a55AXDZ ZyDiun01WSyQWBQv8utqCQ3bhkjE5yRO5EHc+Zdqpkor6fdKgTTmLGMynz5dZgB9zwuKfy1OGx5 4RiqLvGAaJC9 X-Google-Smtp-Source: AGHT+IF60Z13Y52IwO79i/gxv+BAPWOTY49l+AXm0zUWDv63nl/oKe/zlwCwzMLkuE/sxUKJlbIAWQ== X-Received: by 2002:a05:6830:6487:b0:72a:449e:2b69 with SMTP id 46e09a7af769-72c638275d5mr6446771a34.28.1743452488346; Mon, 31 Mar 2025 13:21:28 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c5828b43csm1598753a34.59.2025.03.31.13.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 13:21:27 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Dmitry Gutov Subject: Re: bug#77229: [PATCH] Add 'project-customize-dirlocals' In-Reply-To: <380b65a7-e3f9-4207-bd24-bacd0a0e8591@gutov.dev> References: <87r02nrsf1.fsf@gmail.com> <865xjyfuww.fsf@gnu.org> <87wmcel216.fsf@gmail.com> <380b65a7-e3f9-4207-bd24-bacd0a0e8591@gutov.dev> Date: Mon, 31 Mar 2025 14:21:26 -0600 Message-ID: <8734etgddl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77229 Cc: Eli Zaretskii , 77229@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Dmitry Gutov writes: > On 24/03/2025 20:24, Elijah Gabe P=C3=A9rez wrote: >> Yes, but file-name-concat is also not right here. Please use >> expand-file-name. >> Done. > > FWIW, looks good to me. > > Waiting for the updated version with the NEWS entry, to install. Done, sorry for the delay: --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-Add-project-customize-dirlocals.patch Content-Transfer-Encoding: quoted-printable >From 73e2e627b0f9c1d92cddd39172ebb89ccc083801 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sun, 23 Mar 2025 21:35:32 -0600 Subject: [PATCH] Add 'project-customize-dirlocals' * etc/NEWS: Add command entry. * lisp/menu-bar.el (menu-bar-project-menu): Add command entry to project menu. * lisp/progmodes/project.el (project-customize-dirlocals): New command. (Bug#77229) --- etc/NEWS | 5 +++++ lisp/menu-bar.el | 1 + lisp/progmodes/project.el | 8 ++++++++ 3 files changed, 14 insertions(+) diff --git a/etc/NEWS b/etc/NEWS index 2745d467722..607e6da6301 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -341,6 +341,11 @@ docstring for arguments passed to a help-text function. *** New command 'project-root-find-file'. It is equivalent to running =E2=80=98project-any-command=E2=80=99 with =E2= =80=98find-file=E2=80=99. =20 +--- +*** New command 'project-customize-dirlocals'. +It is equivalent to running =E2=80=98project-any-command=E2=80=99 with +=E2=80=98customize-dirlocals=E2=80=99. + --- *** Improved prompt for 'project-switch-project'. The prompt now displays the chosen project on which to invoke a command. diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 1685357fab6..6a68ad63a5b 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1830,6 +1830,7 @@ menu-bar-project-menu (define-key menu [project-compile] '(menu-item "Compile..." project-co= mpile :help "Invoke compiler or Make for current project, view errors")) (define-key menu [separator-project-programs] menu-bar-separator) (define-key menu [project-switch-project] '(menu-item "Switch Project.= .." project-switch-project :help "Switch to another project and then run a = command")) + (define-key menu [project-customize-dirlocals] '(menu-item "Customize = Directory Local Variables" project-customize-dirlocals :help "Customize cur= rent project Directory Local Variables.")) (define-key menu [project-vc-dir] '(menu-item "VC Dir" project-vc-dir = :help "Show the VC status of the project repository")) (define-key menu [project-dired] '(menu-item "Open Project Root" proje= ct-dired :help "Read the root directory of the current project, to operate = on its files")) (define-key menu [project-find-dir] '(menu-item "Open Directory..." pr= oject-find-dir :help "Open existing directory that belongs to current proje= ct")) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index e2cd5bfa231..cb0cc038585 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1391,6 +1391,14 @@ project-vc-dir (interactive) (vc-dir (project-root (project-current t)))) =20 +;;;###autoload +(defun project-customize-dirlocals () + "Run `customize-dirlocals' in current project's root." + (interactive) + (customize-dirlocals + (expand-file-name ".dir-locals.el" + (project-root (project-current t))))) + (declare-function comint-check-proc "comint") =20 ;;;###autoload --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 01 17:00:57 2025 Received: (at 77229-done) by debbugs.gnu.org; 1 Apr 2025 21:00:57 +0000 Received: from localhost ([127.0.0.1]:51694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tzijA-0001Sd-IX for submit@debbugs.gnu.org; Tue, 01 Apr 2025 17:00:56 -0400 Received: from fout-a5-smtp.messagingengine.com ([103.168.172.148]:52485) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tzij8-0001Rg-AA for 77229-done@debbugs.gnu.org; Tue, 01 Apr 2025 17:00:55 -0400 Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfout.phl.internal (Postfix) with ESMTP id 142591384571; Tue, 1 Apr 2025 17:00:49 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Tue, 01 Apr 2025 17:00:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1743541249; x=1743627649; bh=YoDo4ODFBU+iZ+F/ZW2MCIR+c34Haeo/LgYoKKAFZVg=; b= BeWernaeh5pCl+kjUA+65jyTrGwspCFopkKhZt7uYGtLpl5anlMfRekNhVf5Nidp EgsBkQIgG5OkZuQ6XX+yPINxEYrcsoAsy846/eNKaalKyS2aApckmZRmVBMYE17n sjYm+IUOFRYqS0ZZvyZVyG7rDPQRjPHoyp5ZRClXhwuDHNR7KKxrvJ3OMc8s2FK3 3qp8e6Owop1GDxBxWnm/C8iYPbKz8qUAE5tkZmGhVUHZQdMPpykbPbK98ur175ue hakOnD1Gi1U368ZXD3g9D7K9MgoWWYWPK/wVxWKBk2/iYRLg3FsVgNgn8bDygKXr 0ilo1b7wdeEQ9EM0DzavcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1743541249; x= 1743627649; bh=YoDo4ODFBU+iZ+F/ZW2MCIR+c34Haeo/LgYoKKAFZVg=; b=o My8NuVVjuCIb1Z7CaA2hREU5Pyccta/AhX7v+HK29Tuxkqo68xstVfvm72QCoqyB fwX61Z8WsAt6fNUqytWASFzgt4CtFOMLN4/N5fUGu7Eutx7Gcb9TZlxlICCDnt6g QUS6yeNcefgDyBQTTbI4KTnF8a4R96wMzMLmPZ9BNjKAPxRliBTMF4d0dme7ASd6 juguhR7qvIvJUOBzInaGzA20WxSBctyXQfqSWtkNPpproJZfJJcISCx6KZCmHxSp 63VhkfCx9x77is+qpmYWwGfI5Fy3Pk/E7x1+NzykWnglHQqVXGmHLVF/17+NzCN5 414fIcpVSg6a2m/04lVeA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddukeefkeduucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddt vdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovh druggvvheqnecuggftrfgrthhtvghrnhepueetudfhiedtjeekuefffeehgfffveevteej tdfhteetgeethfevueejkeejgfevnecuffhomhgrihhnpehgnhhurdhorhhgnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehg uhhtohhvrdguvghvpdhnsggprhgtphhtthhopeegpdhmohguvgepshhmthhpohhuthdprh gtphhtthhopegvgheigedvieduieesghhmrghilhdrtghomhdprhgtphhtthhopegvlhhi iiesghhnuhdrohhrghdprhgtphhtthhopeejjedvvdelqdguohhnvgesuggvsggsuhhgsh drghhnuhdrohhrghdprhgtphhtthhopehmrghurhhoohgrrhgrnhgurgesghhmrghilhdr tghomh X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Apr 2025 17:00:46 -0400 (EDT) Message-ID: Date: Wed, 2 Apr 2025 00:00:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77229: [PATCH] Add 'project-customize-dirlocals' To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= References: <87r02nrsf1.fsf@gmail.com> <865xjyfuww.fsf@gnu.org> <87wmcel216.fsf@gmail.com> <380b65a7-e3f9-4207-bd24-bacd0a0e8591@gutov.dev> <8734etgddl.fsf@gmail.com> Content-Language: en-US From: Dmitry Gutov In-Reply-To: <8734etgddl.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77229-done Cc: Eli Zaretskii , 77229-done@debbugs.gnu.org, Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On 31/03/2025 23:21, Elijah Gabe Pérez wrote: > Dmitry Gutov writes: > >> On 24/03/2025 20:24, Elijah Gabe Pérez wrote: >>> Yes, but file-name-concat is also not right here. Please use >>> expand-file-name. >>> Done. >> >> FWIW, looks good to me. >> >> Waiting for the updated version with the NEWS entry, to install. > > Done, sorry for the delay: Thanks! Now pushed to master: https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=da6da5744b95451bdc3339c3a241892466a08551 From unknown Fri Aug 15 03:56:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 30 Apr 2025 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator