GNU bug report logs - #77228
[PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode

Previous Next

Full log

View this message in rfc822 format

From: Elijah Gabe Pérez <eg642616 <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 77228 <at> debbugs.gnu.org
Subject: bug#77228: [PATCH] Create major mode for `customize-dirlocals`
Date: Fri, 04 Apr 2025 22:39:59 -0600

[Message part 1 (text/plain, inline)]

Mauro Aranda <maurooaranda <at> gmail.com> writes:

>> I made it a major mode but not derived from it.
>> I've included the Custom-mode options that are useful (as you pointed)
>> and run Custom-mode-hook.
>
> Anyway, I'm OK with this. Maybe we can use derived-mode-add-parents to
> be clear that we consider Custom-mode a parent of this new mode. Some
> comments below:
>
>> * lisp/cus-edit.el (Custom-dirlocals-mode): New major mode.
>> (custom-dirlocals-with-buffer): Move stuffs to
>> `Custom-dirlocals-mode'.
>
> "stuff".
>
>> +(define-derived-mode Custom-dirlocals-mode nil "Custom dirlocals"
>> +  "Major mode for Customize Directory Local Variables in the current directory."
>
> Please mention that it runs Custom-mode-hook too.

Done.

[0001-Create-major-mode-for-customize-dirlocals-bug-77228.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

> Let's see if somebody else has an opinion. I'm on a trip for the
> weekend, so it won't be until next week that I can install this.

Don't worry, take your time.

-- 
                                          - E.G via GNU Emacs and Org.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.