From unknown Sat Jun 21 03:07:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77228 <77228@debbugs.gnu.org> To: bug#77228 <77228@debbugs.gnu.org> Subject: Status: [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode Reply-To: bug#77228 <77228@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:07:45 +0000 retitle 77228 [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): = Use Custom-mode reassign 77228 emacs submitter 77228 Elijah Gabe P=C3=A9rez severity 77228 normal tag 77228 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 23 23:46:08 2025 Received: (at submit) by debbugs.gnu.org; 24 Mar 2025 03:46:08 +0000 Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twYlL-0002I3-VK for submit@debbugs.gnu.org; Sun, 23 Mar 2025 23:46:08 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56784) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twYlG-0002HG-Dx for submit@debbugs.gnu.org; Sun, 23 Mar 2025 23:46:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twYlB-0006EF-1Z for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 23:45:57 -0400 Received: from mail-oa1-x43.google.com ([2001:4860:4864:20::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twYl9-0000Ut-BP for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 23:45:56 -0400 Received: by mail-oa1-x43.google.com with SMTP id 586e51a60fabf-2c6f27599abso1074329fac.2 for ; Sun, 23 Mar 2025 20:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742787953; x=1743392753; darn=gnu.org; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=dL37qeItxYYtN3hPn7KkrjPOP5XuaPHyLHqZirC6Ubo=; b=Exr5Sa1kZvgvtOuekZ5bNgdVOCOXUBpr8FChE+uXh3QCCLHFE2SfoSatmOYqZm9wak hCw/yyoQgOINiEH1DMUd1HjFInNTrLox/9EE+8EYmzYzrAELRr5cEP2zmYjDjdtVZ2g9 1KghBQ1jtuu+eJRsAPZJpYi8VMy1S0AUwbv6GnaSEadF4S1BsYiGzUolUEqUHw0+5Zfj ZOQE5NLd3oJePGe1cA4rnmsXhtqPurlr+bTdwUkM5VU6XFLndLNkDODL0Wav1SXCSmM1 4K5gVyOfs15Wt6uFTA6to+oqx89g/mjnBWJgBtp1AxmmjX1ueao2vzEHizYx3XAGGl3b vkzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742787953; x=1743392753; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dL37qeItxYYtN3hPn7KkrjPOP5XuaPHyLHqZirC6Ubo=; b=MxHnfygWpqLll0+jxsgr1bOAr4XO7BTATa1B8AhWeM3H2AzRyivg+p3uArZ3OLJT2V zyiT3m1ahbkk9eUHMyOQkmwFQmGl4f1MLWutBXOpGkwb56EQA9ziCq6jeprUHwBJ49as 6HdppOQnUZTb/fhmSBDD6dpMzPKlhE8/aHsheW2a5S/P+IMdzihGnRxXCptOVlaeK518 IUrUI2y4I7HFPm0yiL8AJ8Bp5qBTftfDf5CdZwetSHtmv3QnsLbRwWI0n99OHC4UvO1T 2QCUoo/Un+ulkNCHwKW0dw2gXdcEfWLDefk+fMKfm7OntNQ900at5jwmHkPddC7oJVg0 vjTg== X-Gm-Message-State: AOJu0YwSS4Z0H6nBTKra0wBckMSINAlBPcHUR49UdG+GCFNZKNBfKsxS nX9BPNiHbhXdf/QH+33n9OvHAQvt//Qtts2/Yt5vXTT+6Ry16JIvV8hbaP0B X-Gm-Gg: ASbGncs6Y0EMDM9nfs4tgKPJ8EM4OozvzzI2YfOZ9tbiMoI0+IlMh8DIuR1udx5cCbN dYUgPZfrR3AJ28EE54nIcKJ2LaAfJWaImsWR7KxWT51ozX0TIg/0bwoHlfmlpKvNvsT75seLc3P ckskz/rCgO1naXgLBIt7AOv0KwjbLdc2C8PbcnlKmG59cuVhSGOOwPCVCTSYGs5RFeMFfutInZ4 6qkdSQWNJ2c31VppifvhYGHNCQj8jw2DcEPdZLNywOUIB7XmUiJVaonc/wIYCGEy20gDsJvtzGe O1B7WFQYBnFz X-Google-Smtp-Source: AGHT+IHfhAcBVxqevZhTniAOiYCrZ0Dx1kBvPyGjXQ2z1q9HzLosfx7sorn8nq8XhXcjFMG8UnZJew== X-Received: by 2002:a05:6870:1b85:b0:29f:a0b8:6f7f with SMTP id 586e51a60fabf-2c780298187mr7440253fac.12.1742787953265; Sun, 23 Mar 2025 20:45:53 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2c77f0f3fbcsm1854089fac.49.2025.03.23.20.45.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 20:45:52 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode X-Debbugs-Cc: Date: Sun, 23 Mar 2025 21:45:51 -0600 Message-ID: <87y0wvrt00.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4860:4864:20::43; envelope-from=eg642616@gmail.com; helo=mail-oa1-x43.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Tags: patch Little patch for make =customize-dirlocals= use =Custom-mode= instead =fundamental-mode=, Mostly intended for make this inherit and use =Custom-mode-hook=. I have tested it and at the moment it does not cause problems with the configuration made. Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (eg642616[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (eg642616[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 HTML_MESSAGE BODY: HTML included in message X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Tags: patch Little patch for make =customize-dirlocals= use =Custom-mode= instead =fundamental-mode=, Mostly intended for make this inherit and use =Custom-mode-hook=. I have tested it and at the moment it does not cause problems with the configuration made. --==-=-= Content-Type: text/html

Tags: patch

Little patch for make customize-dirlocals use Custom-mode instead
fundamental-mode, Mostly intended for make this inherit and use
Custom-mode-hook.

I have tested it and at the moment it does not cause problems with the
configuration made.

--==-=-=-- --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-cus-edit.el-custom-dirlocals-with-buffer-Use-Cu.patch >From e3e488c4994db80a07f6efb49d57201f1468fecd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Sun, 23 Mar 2025 21:26:26 -0600 Subject: [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode --- lisp/cus-edit.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index ecfce03e490..52808aa8ee0 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -6070,6 +6070,7 @@ custom-dirlocals-with-buffer (let ((inhibit-read-only t)) (erase-buffer)) (remove-overlays) + (Custom-mode) (custom-dirlocals--set-widget-vars) ,@body (setq-local tool-bar-map -- 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 05:33:53 2025 Received: (at 77228) by debbugs.gnu.org; 24 Mar 2025 09:33:53 +0000 Received: from localhost ([127.0.0.1]:54239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tweBt-0003MD-3C for submit@debbugs.gnu.org; Mon, 24 Mar 2025 05:33:53 -0400 Received: from mail-pl1-x62a.google.com ([2607:f8b0:4864:20::62a]:45369) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tweBp-0003Lu-J1 for 77228@debbugs.gnu.org; Mon, 24 Mar 2025 05:33:50 -0400 Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-227d6b530d8so2559415ad.3 for <77228@debbugs.gnu.org>; Mon, 24 Mar 2025 02:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742808823; x=1743413623; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=XH3qX2XYeOdkJtS/m035gY6mIv3WpasVL67erETeC3I=; b=gcA+qc3wYmBZwZCV1COTK+wWX08dcLwCSlPKxuw6fIdl5LSiDinbdCftMoWhP1HQZ+ wXn9FiIrOkceYhGl1g4OFzyEG0+MUdSi7+zxIDXhqQeDyhoZQKMdeFsRwap3czSD6+ha mLrJBP7skS8R1WvsgQDTSv9ZlBb430aRFXfTpvuEB/TGkqsiRC2nsmZH5qQO5dY0yzLQ uaysz/JFwatC/cBXfmyPP+7cwzBeqxc8ggseB+l3vT0gudlIW2uDOlXxS1zV1A95pLb3 AZAp1ZoTIbePS8jck2WjY0d0URXbcX6tsJdYNBrVmeIMnldRHpZu2QUgEhFRhN9TB4wn oa1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742808823; x=1743413623; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XH3qX2XYeOdkJtS/m035gY6mIv3WpasVL67erETeC3I=; b=WaHk1zBpbD/cPI6jrkJ7OaNbABozXgrNhPw/6IiVUddEfSeFIAlPOnSHQDXxtiKk9r g8itMQCVnCtK799vlkLnJyTyXM/+vFxJW3HNnWbHdl2jM8revEyPWa3Gg0YtNadPGEa1 iq6C3xltPIuYRAE4rFbX5X3favSak4s/Tq6lCRe7qyjV6uKHRngYJEyMQRijynFy5cY6 8UvUft4fRdI6HsI1eZdMCLXBonTyj6+hVDXIm+P5DTf6il7Tgs8rTnnMY76lDvZGkXkK SFO+9N2AfF3r+QvBqPBMGY1oDGVB8gUIzKQCd33ALAXfZmAkcbvuGXaCcRQrk65/xcuc izWw== X-Forwarded-Encrypted: i=1; AJvYcCWvIdGWKc49YKm897vojZkanjkuMJmYzcgRmuGtNSS+0Kh1/4Vc8opVuf7Etlf59EMfAmgWXg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxKY6aiXTYckx+OigNFJHDqcCxay4xO4YAkUewU+bB9TY5iUPut JbKTfz2fOVf47qq5EihJkZvfXiQvT0KMYyJUmNTv1OSCerTWu7/W X-Gm-Gg: ASbGncs1UAVZ5Ah+DlUEKRyXHU9NJz1qPCTgK4zBVkR3umSVvtRy8rDI3nElHb8j2fS eULHatdp2E2mcLG/cS2ALkWUFOVQ6ukZN7hp4okV/9skxYvOJe81PaZpSFV8f7uKcostPsRB3Cd b/bLF9/ypdihCQOD0lXV/RYlZmxkgyDOF0E3FtGwYAr5ziu/GQkQ6nvGAJCHeDJ+Z9YPEQPV600 2VxpphTVj4xI020pB8Tno8iGopoyGMeCU0walQoaVdQYtPogj6aYTnVfq5Ij84Oy+rjILj+1SMF ZQStZhxqUnIsPbmgxTiuPz3sXj76Qfkj2R1g8p0ntAcDKQJYwJ0= X-Google-Smtp-Source: AGHT+IF16ptUfgIcG5MuuGDxK0EEAZrXKGmO4BOz7Zl0DZzB3mqiiG9lt2OEIhHYbyu8cKJSg1ER9A== X-Received: by 2002:a17:903:40cb:b0:224:1c41:a4cd with SMTP id d9443c01a7336-22780c50d38mr181325095ad.3.1742808823144; Mon, 24 Mar 2025 02:33:43 -0700 (PDT) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-227811c0fd5sm66042605ad.133.2025.03.24.02.33.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Mar 2025 02:33:42 -0700 (PDT) Message-ID: <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> Date: Mon, 24 Mar 2025 06:33:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77228: [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= , 77228@debbugs.gnu.org References: <87y0wvrt00.fsf@gmail.com> Content-Language: en-US From: Mauro Aranda In-Reply-To: <87y0wvrt00.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77228 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe Pérez writes: > Tags: patch > > Little patch for make customize-dirlocals use Custom-mode instead > fundamental-mode, Mostly intended for make this inherit and use > Custom-mode-hook. > > I have tested it and at the moment it does not cause problems with the > configuration made. Yes, I don't anticipate any real problems, but just using Custom-mode is almost entirely redundant since some of the settings that it performs are not relevant, and others get clobbered right away. Overriden: custom-mode-map, tool-bar-map, revert-buffer-function. Not relevant: custom--invocation-options, custom--hidden-state, custom-options, custom-local-buffer, widget-edit-functions. Redundant: custom--initialize-widget-variables. That just leaves us with the text-conversion-style and touch-screen-keyboard-function settings, which my guess is that they should've been added to custom-dirlocals-with-buffer too, and of course, running Custom-mode-hook. So I think it'd be better either to derive from Custom-mode, or find a way to avoid the redundant settings. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 02 20:26:20 2025 Received: (at 77228) by debbugs.gnu.org; 3 Apr 2025 00:26:20 +0000 Received: from localhost ([127.0.0.1]:60026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u08PU-0003mj-7B for submit@debbugs.gnu.org; Wed, 02 Apr 2025 20:26:20 -0400 Received: from mail-oo1-xc44.google.com ([2607:f8b0:4864:20::c44]:57473) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u08PR-0003mO-0X for 77228@debbugs.gnu.org; Wed, 02 Apr 2025 20:26:17 -0400 Received: by mail-oo1-xc44.google.com with SMTP id 006d021491bc7-603be85490bso209960eaf.2 for <77228@debbugs.gnu.org>; Wed, 02 Apr 2025 17:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743639971; x=1744244771; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=O+OHyxsVjzdenEyNFCRunSQuCwUtGUML74eALgPhl0A=; b=F2UZ2VNFazXL7mCBVqWVt1V4nAs05txSMo9RI6whge+dW66AqXga9elcX10nU6zBfM oQcT4E1XgOOlKnenf+lNLuQl1JgQHgZj8z92YJd4a02caWnJyao0iIqE2M7KlVjLj3C3 0QmZ6CYRTG9F5wjI8XqY6bqfOH179P9EWjyY1NRe45ouY5tCyniOttQbQhKCxtbbllXk mYLAmrzHRvuhxpaWuTBx3cTxrKWivWTPw2939eTMTUCW5LG31AGQ5xagILAh65ZBlegI 7ONhlAzhYY89ZfzlXnPWwjtxuoH6dtbIdhgTh7a1mkltydKyapVRLjuOTZOByIYQTdhE y9sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743639971; x=1744244771; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O+OHyxsVjzdenEyNFCRunSQuCwUtGUML74eALgPhl0A=; b=X4UA18eqISQtcZx9dOk6VBWr5nCuKAmXvx7JQv6XKKEmMO86zUn2wN68z11+uIkFRi JAvdfsjGlXR1YPA5dz+h23Uj7bFOEZtGBrIUwEtEBdbZf3x7ZPaFz9ZRKwqD8f4i8HyE 0oFkTMlOzfHr23828FJ2+wpDQoP/ciJzvIIe3wLuoEnwg4mvmox7y3xchY+2QYbuLokT CnixMDFn7XusxUq9wSNqFtiaaHfgEpfiJ4/vDL5xOPnyain1px+Ly/AtMe+yHxIeG/ci fiZeMCkYvIgtQGTXK1WLsh+q+KWMfH0Td05MF6qgc6/salTU/qOTPsQSlqXYcUGm8ilc P0+A== X-Gm-Message-State: AOJu0Ywz+ifQP/MgqY0XzUO24Ahf+eFND1lcwxX6G6snzvgQZIT3DCAB v+tteQ/yN1M5BcxTZ1vFoNaN3p5hCusladEHebDCr/XPZ4jt1wbQ+R1YZbgD X-Gm-Gg: ASbGncvxS+VJC5oeHnUW0/RWHt4eEnI9SbzW8ah/HyOMeULgkGWk2a4bLiMeyQ2tvKa CWNqcP8KpiPXLhGSzv4GSYSicnwC1LRCfZH5t84g2qmA1f2dBlaqrsq9DrsBtBsTnFf6p3gRleC 5ynEWtycrxalpJ4JMh3Hvf0Mb/z4iVboPjoqluV2jsW6vRfyTdj6TkqUQhPw0xF5EjKXO1YrDB6 vjqKyhov9QV+d7Y0AB/azOW8YqR67aFOGOr9k8zENh/sIGVAFXsZtPhVibah47VyJ5KtwETx5+v l7mIM8PMpayi X-Google-Smtp-Source: AGHT+IFh1pqmOIirn49fB/WAgvIttZua7IEHcmqYCprYMT9saIC/dw/ZTcHVITrCBGtFktqGjpR4/g== X-Received: by 2002:a05:6870:171b:b0:2bc:98d0:dc64 with SMTP id 586e51a60fabf-2cbcf03b345mr11219181fac.0.1743639970704; Wed, 02 Apr 2025 17:26:10 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2cc84b279c9sm40422fac.31.2025.04.02.17.26.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 17:26:10 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Mauro Aranda Subject: Re: bug#77228: [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode In-Reply-To: <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> Date: Wed, 02 Apr 2025 18:26:08 -0600 Message-ID: <87a58y2iqn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77228 Cc: 77228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mauro Aranda writes: > Elijah Gabe P=C3=A9rez writes: > >> Tags: patch >> >> Little patch for make customize-dirlocals use Custom-mode instead >> fundamental-mode, Mostly intended for make this inherit and use >> Custom-mode-hook. >> >> I have tested it and at the moment it does not cause problems with the >> configuration made. > > Yes, I don't anticipate any real problems, but just using Custom-mode is > almost entirely redundant since some of the settings that it performs > are not relevant, and others get clobbered right away. > > Overriden: > custom-mode-map, tool-bar-map, revert-buffer-function. > > Not relevant: > custom--invocation-options, custom--hidden-state, custom-options, > custom-local-buffer, widget-edit-functions. > > Redundant: > custom--initialize-widget-variables. > > > That just leaves us with the text-conversion-style and > touch-screen-keyboard-function settings, which my guess is that they > should've been added to custom-dirlocals-with-buffer too, and of course, > running Custom-mode-hook. > > So I think it'd be better either to derive from Custom-mode, or find a > way to avoid the redundant settings. But making it derived won't include Custom-mode options anyway? I made it a major mode but not derived from it. I've included the Custom-mode options that are useful (as you pointed) and run Custom-mode-hook. --==-=-= Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Mauro Aranda <maurooaranda@gmail.com> writes:

Elijah Gabe P=C3=A9rez <eg642616@gmail.com> writes:

Tags: patch

Little patch for make customize-dirlocals use Custom-mode instead
fundamental-mode, Mostly intended for make this inherit and use
Custom-mode-hook.

I have tested it and at the moment it does not cause problems with the
configuration made.

Yes, I don't anticipate any real problems, but just using Custom-mode is almost entirely redundant since some of the settings that it performs
are not relevant, and others get clobbered right away.

Overriden:
custom-mode-map, tool-bar-map, revert-buffer-function.

Not relevant:
custom–invocation-options, custom–hidden-state, custom-option= s,
custom-local-buffer, widget-edit-functions.

Redundant:
custom–initialize-widget-variables.


That just leaves us with the text-conversion-style and
touch-screen-keyboard-function settings, which my guess is that they
should've been added to custom-dirlocals-with-buffer too, and of course, running Custom-mode-hook.

So I think it'd be better either to derive from Custom-mode, or find a
way to avoid the redundant settings.

But making it derived won't include Custom-mode options anyway?

I made it a major mode but not derived from it.
I've included the Custom-mode options that are useful (as you pointed)
and run Custom-mode-hook.

--==-=-=-- --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Create-major-mode-for-customize-dirlocals-bug-77228.patch >From 6510e3f7f68289c99e80426e3c76b8268661fa8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Sun, 23 Mar 2025 21:26:26 -0600 Subject: [PATCH] Create major mode for `customize-dirlocals` (bug#77228) * lisp/cus-edit.el (Custom-dirlocals-mode): New major mode. (custom-dirlocals-with-buffer): Move stuffs to `Custom-dirlocals-mode'. --- lisp/cus-edit.el | 39 ++++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index ecfce03e490..a0d21fee571 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -6060,31 +6060,40 @@ custom-dirlocals--set-widget-vars (custom--initialize-widget-variables) (add-hook 'widget-forward-hook #'custom-dirlocals-maybe-update-cons nil t)) +(define-derived-mode Custom-dirlocals-mode nil "Custom dirlocals" + "Major mode for Customize Directory Local Variables in the current directory." + (kill-all-local-variables) + (run-hooks 'Custom-mode-hook) + (custom-dirlocals--set-widget-vars) + (setq-local text-conversion-style 'action) + (setq-local touch-screen-keyboard-function + #'Custom-display-on-screen-keyboard-p) + (setq-local revert-buffer-function #'Custom-dirlocals-revert-buffer) + (setq-local tool-bar-map + (or custom-dirlocals-tool-bar-map + ;; Set up `custom-dirlocals-tool-bar-map'. + (let ((map (make-sparse-keymap))) + (mapc + (lambda (arg) + (tool-bar-local-item-from-menu + (nth 1 arg) (nth 4 arg) map custom-dirlocals-map + :label (nth 5 arg))) + custom-dirlocals-commands) + (setq custom-dirlocals-tool-bar-map map)))) + (use-local-map custom-dirlocals-map)) + (defmacro custom-dirlocals-with-buffer (&rest body) "Arrange to execute BODY in a \"*Customize Dirlocals*\" buffer." ;; We don't use `custom-buffer-create' because the settings here ;; don't go into the `custom-file'. `(progn (switch-to-buffer "*Customize Dirlocals*") - (kill-all-local-variables) + (let ((inhibit-read-only t)) (erase-buffer)) (remove-overlays) - (custom-dirlocals--set-widget-vars) + (Custom-dirlocals-mode) ,@body - (setq-local tool-bar-map - (or custom-dirlocals-tool-bar-map - ;; Set up `custom-dirlocals-tool-bar-map'. - (let ((map (make-sparse-keymap))) - (mapc - (lambda (arg) - (tool-bar-local-item-from-menu - (nth 1 arg) (nth 4 arg) map custom-dirlocals-map - :label (nth 5 arg))) - custom-dirlocals-commands) - (setq custom-dirlocals-tool-bar-map map)))) - (setq-local revert-buffer-function #'Custom-dirlocals-revert-buffer) - (use-local-map custom-dirlocals-map) (widget-setup))) (defun custom-dirlocals-get-options () -- 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 06:07:28 2025 Received: (at 77228) by debbugs.gnu.org; 4 Apr 2025 10:07:28 +0000 Received: from localhost ([127.0.0.1]:37129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0dxP-0001b3-UH for submit@debbugs.gnu.org; Fri, 04 Apr 2025 06:07:28 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]:61666) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u0dxN-0001an-4W for 77228@debbugs.gnu.org; Fri, 04 Apr 2025 06:07:26 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-736c3e7b390so1728109b3a.2 for <77228@debbugs.gnu.org>; Fri, 04 Apr 2025 03:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743761239; x=1744366039; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PNNFj1UZnsXEm5ptg9v+nvHQ1FRenVnAzRgns4rJqw0=; b=miHgvMFUqgoNd0nbUpH0/Kj8uzF9Ynbuex+ECXc8GW2+RFMzdMpzloGxXWuIzPRaTZ 065/TGGdw9+RtFiq4xWEaLph3GyBqvzv+JLOgaKvJ/AdzuMBZmDP3JCWnYjTT3PFjdvK UJEV5wU+ndTrNjgvIamUroEBbk/UEybYOjpha7GSO0ICthAmXdpihGbw2NxaHbTZEdte Bj9By+SdABL8P3upDC3VDHS4iZTGSYGChOJXF8aNEqpMuSBodpvElPaw292wTAEelamO t29KLqpgW8hLL+z1b/HI9ZZIDkqCyutM5xwTUwVIV05u/Gg54r3EB4Ld/JvUETlqbkmJ +WiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743761239; x=1744366039; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PNNFj1UZnsXEm5ptg9v+nvHQ1FRenVnAzRgns4rJqw0=; b=Z4OlzFkXMKdCWN9CheJEeKjDzce1NQKjNY46F3XNkFVTDOYCwSeNh3Sx1qA0o3fFIY bp9/d9o5dLNBIFZqGDAzM1S+iKIQRvv823jpSGiwKr+Sqeb6UMEUIQSB29mAU2K3JE6h INHoKd/aKOxsSfWz19bwhDdoqTQB7ZW9FKA3kDoyccV01RVP4etrRW+x+nm0Qlu67BDR yvrIVHJ0+FR/Pj37j4pwm96YnuOR/TXoxezsaiqpYdKa/keYGXDLwr58F8zVEeBauDId 45RulkzcyvfG37YwRp5ekW4DfLm7ijDpYcldz7zuBVZxJqXTyi2F7+kkIsENninpHOSm 76cA== X-Gm-Message-State: AOJu0YzVyo5yeb+RgdMFZt1Xrr0fRVKr/cxLpFcVC5AnqgBnKzQUWtji L+6k1hE/4SH3OjFrXPSQhVetCxBTjWH7cCrcYYGqnB6lpEikdA4MhJ0h5A== X-Gm-Gg: ASbGncspV1ZKtS7QdriQNIdhG4Z0rEhUnNC4QXMhwpdv2hl9T0N/SUz5UdSPaJ8Tfpk Gsyl03TaGdooBELWtp2N0ldYeFrK8VR/xmm6fyXqH+xnO1cO3PH89thffwPfZeFoC6sc0909M/h koZnru7L8NQb7i6EEmqnb8FcpnbfBYP2ovikQM7tDHuroiraqiFQaChpH9naVtA7QqEAE2ZkOwt UUMHuMCcy0iFDPNqG3fJSSO39Avh+svUxy0JbtnXzrr+AT3K73Um2x0Fa1qUYdZFm151Or9WnKA Bl6leVBQiWu3/wLXOMTCbEXV27fVYWWx2T5uELkn5IfHVDOro9M= X-Google-Smtp-Source: AGHT+IH6elAGeaWwA+H2S59Bdv7XeGjxGrgCA+j3lmIfUT1N0x2QkwV4SlN3f64ct9Bo4smwcRmagA== X-Received: by 2002:a05:6a20:4392:b0:1f5:6c94:2cc1 with SMTP id adf61e73a8af0-20108011008mr3377599637.21.1743761238719; Fri, 04 Apr 2025 03:07:18 -0700 (PDT) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d97effe5sm3064472b3a.61.2025.04.04.03.07.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 03:07:18 -0700 (PDT) Message-ID: Date: Fri, 4 Apr 2025 07:07:15 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77228: [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> <87a58y2iqn.fsf@gmail.com> Content-Language: en-US From: Mauro Aranda In-Reply-To: <87a58y2iqn.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77228 Cc: 77228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/4/25 21:26, Elijah Gabe Pérez wrote: > > Mauro Aranda writes: > > Elijah Gabe Pérez writes: > > Tags: patch > > Little patch for make customize-dirlocals use Custom-mode instead > fundamental-mode, Mostly intended for make this inherit and use > Custom-mode-hook. > > I have tested it and at the moment it does not cause problems with the > configuration made. > > > Yes, I don't anticipate any real problems, but just using Custom-mode is > almost entirely redundant since some of the settings that it performs > are not relevant, and others get clobbered right away. > > Overriden: > custom-mode-map, tool-bar-map, revert-buffer-function. > > Not relevant: > custom–invocation-options, custom–hidden-state, custom-options, > custom-local-buffer, widget-edit-functions. > > Redundant: > custom–initialize-widget-variables. > > > That just leaves us with the text-conversion-style and > touch-screen-keyboard-function settings, which my guess is that they > should've been added to custom-dirlocals-with-buffer too, and of course, > running Custom-mode-hook. > > So I think it'd be better either to derive from Custom-mode, or find a > way to avoid the redundant settings. > > But making it derived won't include Custom-mode options anyway? Yes, but we could arrange for Custom-mode to set the right values, I think. Although maybe it's not worth it. > I made it a major mode but not derived from it. > I've included the Custom-mode options that are useful (as you pointed) > and run Custom-mode-hook. Anyway, I'm OK with this. Maybe we can use derived-mode-add-parents to be clear that we consider Custom-mode a parent of this new mode. Some comments below: >>From 6510e3f7f68289c99e80426e3c76b8268661fa8a Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= > Date: Sun, 23 Mar 2025 21:26:26 -0600 > Subject: [PATCH] Create major mode for `customize-dirlocals` (bug#77228) > > * lisp/cus-edit.el (Custom-dirlocals-mode): New major mode. > (custom-dirlocals-with-buffer): Move stuffs to > `Custom-dirlocals-mode'. "stuff". > --- > lisp/cus-edit.el | 39 ++++++++++++++++++++++++--------------- > 1 file changed, 24 insertions(+), 15 deletions(-) > > diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el > index ecfce03e490..a0d21fee571 100644 > --- a/lisp/cus-edit.el > +++ b/lisp/cus-edit.el > @@ -6060,31 +6060,40 @@ custom-dirlocals--set-widget-vars > (custom--initialize-widget-variables) > (add-hook 'widget-forward-hook #'custom-dirlocals-maybe-update-cons nil t)) > > +(define-derived-mode Custom-dirlocals-mode nil "Custom dirlocals" > + "Major mode for Customize Directory Local Variables in the current directory." Please mention that it runs Custom-mode-hook too. Let's see if somebody else has an opinion. I'm on a trip for the weekend, so it won't be until next week that I can install this. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 06:50:08 2025 Received: (at 77228) by debbugs.gnu.org; 4 Apr 2025 10:50:08 +0000 Received: from localhost ([127.0.0.1]:37199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0ech-0003ZU-Tg for submit@debbugs.gnu.org; Fri, 04 Apr 2025 06:50:08 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]:46511) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u0ece-0003Yk-QP for 77228@debbugs.gnu.org; Fri, 04 Apr 2025 06:50:05 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-736b98acaadso1850082b3a.1 for <77228@debbugs.gnu.org>; Fri, 04 Apr 2025 03:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743763799; x=1744368599; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VM1KbN6EL50J7VdAHd9trQTG7JaUlGB/yy76Mks/Cy8=; b=UqRlVPg99Re59pemL8lLI5vNuAEykY1KjXvVB4IX901XVCzzOX7f2V9phl/efg3ETX hZmXsLqjM7QbcK4b5qTfr0yLVkPs1ZLlT0xeg8vIickQRzVXbu5oZu8iHisarxVZ4HZV mbsP3xGtpoxEmaRuOppkiHwthQ/Wa7ML7ZP45Wucxr7Q3XGOd91BOTdM8ckTLOXf0SG4 h+lFYEU653ZoQKpx0V6LgBmMv4QoPuRHjAfHQc34j/OTEJx1LA13Z5lqBgB1hVy+yoKe Za8ueT2Tvhq1Cni1+03wHWRkK5hRWzRdluC9hTWQzUAPUlYbmydNgvQjKGt8UwWsPD3h cjaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743763799; x=1744368599; h=content-transfer-encoding:in-reply-to:cc:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VM1KbN6EL50J7VdAHd9trQTG7JaUlGB/yy76Mks/Cy8=; b=MYjS3pwZoIe0qOp4gez+BNVlC+ZkMSUA96rXOnDO/ixrKfB7FfSumUebfmGQ2phCpk MUh1sKqEcxpv6twvvK8Wc1RAikW26AlOfDSPaJ2a6KwlpO7Wve3i/2CEhUbVZtVcJ1qa Vju2ykF5sSPobAqsqnOsvYBceQ/BQkO3ObdjZqZI+3u9Crq3r6VYQ/sT7bJmXJPcRK8h eS/TcqN2FqE30h9USkzr7VAhaCYUmLAj9+AaCOvGGbc+yYIvK7qOVjlxLz4O9yAXPmAD SLru2bhwLYBzLrxKzGv9TMRcnOBKeE8ZPeGSU6F8yhl1TzPC1SFStVpGCB22ti7LC/ZY 8wCA== X-Gm-Message-State: AOJu0YxP+xXZxspXcfzCKlYAbiqvvSZyV/KlHYr01jf3WgU0vyhvG3sH So0y8nrBP60nuq9VfvY5c8e11/xqTpO+0SZFSbu+VxOgVXPgy2st X-Gm-Gg: ASbGncushGg8v+sJfGYD2bs+5CHnzdTTFZt37OlZ8XoYBlu4upnc6lwmN2Ti/+gt/Rs RWLOwi2i800hZzZHITW37E+ZVtu++eAy75fTshVdM0esM6RsQtRfpV5Yb3qRVwzRGOruaoheZCI R8B7YQxxLIiYdG6O1xG5nMZQurL9e/LYbui0wMqjhnTPfJ6xuCbhMi41uBLiEXWEXJzHnTrldHW c7EoCEiMgPm4yQ9kaDaQgvpqpWLOWi9HC3hgcw2K8MY99pP2XPhvsXbSaLM34ZyuSqsfzQMtcpr Kuqsn7DHB1qhTvyP2so1veMNgtJuYLmL2/nJ7cNAt7o/tM7Bwcw= X-Google-Smtp-Source: AGHT+IHEI7ERzhqKqz+SnNpXJ4nHnLqmaG5VvW5KuoQHMYjgktEbQXhVepgOlzq/f/h+Z+/71V0k6g== X-Received: by 2002:a05:6a00:2d22:b0:730:9801:d3e2 with SMTP id d2e1a72fcca58-739e4816b40mr4806720b3a.8.1743763798473; Fri, 04 Apr 2025 03:49:58 -0700 (PDT) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d9e9dcc6sm3131554b3a.99.2025.04.04.03.49.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 03:49:58 -0700 (PDT) Message-ID: Date: Fri, 4 Apr 2025 07:49:55 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77228: [PATCH] ; * lisp/cus-edit.el (custom-dirlocals-with-buffer): Use Custom-mode From: Mauro Aranda To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> <87a58y2iqn.fsf@gmail.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77228 Cc: 77228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [ Resending ] Elijah Gabe Pérez writes: > Mauro Aranda writes: > > Elijah Gabe Pérez writes: > > Tags: patch > > Little patch for make customize-dirlocals use Custom-mode instead > fundamental-mode, Mostly intended for make this inherit and use > Custom-mode-hook. > > I have tested it and at the moment it does not cause problems with the > configuration made. > > Yes, I don't anticipate any real problems, but just using Custom-mode is > almost entirely redundant since some of the settings that it performs > are not relevant, and others get clobbered right away. > > Overriden: > custom-mode-map, tool-bar-map, revert-buffer-function. > > Not relevant: > custom–invocation-options, custom–hidden-state, custom-options, > custom-local-buffer, widget-edit-functions. > > Redundant: > custom–initialize-widget-variables. > > That just leaves us with the text-conversion-style and > touch-screen-keyboard-function settings, which my guess is that they > should've been added to custom-dirlocals-with-buffer too, and of course, > running Custom-mode-hook. > > So I think it'd be better either to derive from Custom-mode, or find a > way to avoid the redundant settings. > > But making it derived won't include Custom-mode options anyway? Yes, but we could arrange for Custom-mode to set the right values, I think. Although maybe it's not worth it. > I made it a major mode but not derived from it. > I've included the Custom-mode options that are useful (as you pointed) > and run Custom-mode-hook. Anyway, I'm OK with this. Maybe we can use derived-mode-add-parents to be clear that we consider Custom-mode a parent of this new mode. Some comments below: > * lisp/cus-edit.el (Custom-dirlocals-mode): New major mode. > (custom-dirlocals-with-buffer): Move stuffs to > `Custom-dirlocals-mode'. "stuff". > +(define-derived-mode Custom-dirlocals-mode nil "Custom dirlocals" > + "Major mode for Customize Directory Local Variables in the current directory." Please mention that it runs Custom-mode-hook too. Let's see if somebody else has an opinion. I'm on a trip for the weekend, so it won't be until next week that I can install this. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 05 00:40:17 2025 Received: (at 77228) by debbugs.gnu.org; 5 Apr 2025 04:40:17 +0000 Received: from localhost ([127.0.0.1]:41039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0vKK-0007YF-OM for submit@debbugs.gnu.org; Sat, 05 Apr 2025 00:40:17 -0400 Received: from mail-oa1-x41.google.com ([2001:4860:4864:20::41]:52413) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u0vKB-0007Rz-Q1 for 77228@debbugs.gnu.org; Sat, 05 Apr 2025 00:40:13 -0400 Received: by mail-oa1-x41.google.com with SMTP id 586e51a60fabf-2b38896c534so1382088fac.0 for <77228@debbugs.gnu.org>; Fri, 04 Apr 2025 21:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743828001; x=1744432801; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=QqWBJRr3BoMngL5XWTZrKNI9zZIknSu5tulwaS443+o=; b=lmlmQtBYYmUmqUicvKsNzLd02pQiZA/Hf68hr9G/OroA9UzEQ3qiDOTDBHnaDVYXyp tw/+gfbPYpNRH+mDWAkkKrKwG92KDKULQIzGrDgY0fMIh59y57NC4jeqYkDTDSLmKHRA sfyD1XRjFoRu+N7yMWaSS1lvzqAgn611t27/wG2FvNpD0qxMCJsgNTZA9+gSerYQbsfw XLAa7Ygn3ra7VI/AdcB/7VrH7iVqMQQlTFS0Q9ojTaRd7AyQwS9VPgWW/aEAPZtu3YPB tDvPr6jq43GEXWpDLGo0j0fnidx+EnmOtCaRg+J4iq0XX501Y03bx641lF7iRJZ8+P8K 5K2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743828001; x=1744432801; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QqWBJRr3BoMngL5XWTZrKNI9zZIknSu5tulwaS443+o=; b=l89GNnelrQL67NuIvnaNU3BYZKf5+YIYwqnkjgfQg4McWrXEq1vdOE4FURLVzop7Yu 8SeXzxcj1Mi/mANJpMeqh52V+nuGxYM+ZSkTj7MQPNC7IIF1jqTuwm8ImMdpMnHWEdgV nLJ+/xKLQf0/Fe/pRHF7ZrHE/IzN+aDUr8W8H+Zgz5e9XjMmYl8IQzEMDkryFIvoUG74 jIGvWq3U4e9jNBeguLKN5VPMooS/jV799lY5ScTs4Z4NOO7fpwOooOhtk5BtLqi0VgCF l/5j78bxBSwUs00y+JQhe25aZ0VXkGMeUbIuE4EO/1Wfhk2SxqIi6+KZoNV93jb1jMpq or0w== X-Gm-Message-State: AOJu0YyUajwTVIwqVKupbR0l54N5nrIh/e729MA49Yv7Q2g17hES0yjF zntYrgUvg0wySFHMQv3ZcvxCNyfJIaiwkcOak9J9tW4F5yf8+Vk7OQWsY6Dv X-Gm-Gg: ASbGnctIuHXiIGYxS2bBWKeRuptl4L8Qua1vvUokkIYnxC4KsgkVUkfsyMwia8mFTZw Lujk9NXSj6Sj2Y01+BIdDpFzp1aeOBCiRSxBXOxsdsZ5VRxw6G+BYjQjiydzpGDu7U06G4jdhoD 0a2JmVTJ+fwsezo3aeesHjToRM9w9CzGXNnUKRsXRABQcQvRbIhbZ008vuwIotXhoByvvZLGZvA DxgKMiv+uszOKhqkiyEg3fMIKDykPllJMD3EYTArAAcfwl+QrlTn9+2xhytimbhLFErtdkMQW/x IFgHxWs9v0ZZ X-Google-Smtp-Source: AGHT+IFRTG47BiNk0OtMr8NtmqJvHqJl+d9i5sbVfaNNT9u4e8E64mK88udJdyF6LTQHHv6EcKajDg== X-Received: by 2002:a05:6871:3790:b0:296:b568:7901 with SMTP id 586e51a60fabf-2cc9e5a7740mr2990206fac.16.1743828001515; Fri, 04 Apr 2025 21:40:01 -0700 (PDT) Received: from fedora ([2806:10ae:e:79da::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2cc84b2720asm1036867fac.40.2025.04.04.21.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 21:40:00 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Mauro Aranda Subject: Re: bug#77228: [PATCH] Create major mode for `customize-dirlocals` In-Reply-To: References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> <87a58y2iqn.fsf@gmail.com> Date: Fri, 04 Apr 2025 22:39:59 -0600 Message-ID: <87ldsfz0f4.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77228 Cc: 77228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Mauro Aranda writes: >> I made it a major mode but not derived from it. >> I've included the Custom-mode options that are useful (as you pointed) >> and run Custom-mode-hook. > > Anyway, I'm OK with this. Maybe we can use derived-mode-add-parents to > be clear that we consider Custom-mode a parent of this new mode. Some > comments below: > >> * lisp/cus-edit.el (Custom-dirlocals-mode): New major mode. >> (custom-dirlocals-with-buffer): Move stuffs to >> `Custom-dirlocals-mode'. > > "stuff". > >> +(define-derived-mode Custom-dirlocals-mode nil "Custom dirlocals" >> + "Major mode for Customize Directory Local Variables in the current directory." > > Please mention that it runs Custom-mode-hook too. Done. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Create-major-mode-for-customize-dirlocals-bug-77228.patch >From 0c61b54b5f4b33d56abc130cd108b8d896e2bc85 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?El=C3=ADas=20Gabriel=20P=C3=A9rez?= Date: Sun, 23 Mar 2025 21:26:26 -0600 Subject: [PATCH] Create major mode for `customize-dirlocals` (bug#77228) * lisp/cus-edit.el (Custom-dirlocals-mode): New major mode. (custom-dirlocals-with-buffer): Move settings to `Custom-dirlocals-mode'. --- lisp/cus-edit.el | 46 +++++++++++++++++++++++++++++++--------------- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/lisp/cus-edit.el b/lisp/cus-edit.el index ecfce03e490..1016a5667ff 100644 --- a/lisp/cus-edit.el +++ b/lisp/cus-edit.el @@ -6060,31 +6060,47 @@ custom-dirlocals--set-widget-vars (custom--initialize-widget-variables) (add-hook 'widget-forward-hook #'custom-dirlocals-maybe-update-cons nil t)) +(define-derived-mode Custom-dirlocals-mode nil "Custom dirlocals" + "Major mode for customize Directory Local Variables in the current directory. +Entry to this mode calls the value of `Custom-mode-hook' if that value +is non-nil. + +\\{custom-dirlocals-map}" + (kill-all-local-variables) + (custom-dirlocals--set-widget-vars) + (setq-local major-mode #'Custom-dirlocals-mode) + (setq-local text-conversion-style 'action) + (setq-local touch-screen-keyboard-function + #'Custom-display-on-screen-keyboard-p) + (setq-local revert-buffer-function #'Custom-dirlocals-revert-buffer) + (setq-local tool-bar-map + (or custom-dirlocals-tool-bar-map + ;; Set up `custom-dirlocals-tool-bar-map'. + (let ((map (make-sparse-keymap))) + (mapc + (lambda (arg) + (tool-bar-local-item-from-menu + (nth 1 arg) (nth 4 arg) map custom-dirlocals-map + :label (nth 5 arg))) + custom-dirlocals-commands) + (setq custom-dirlocals-tool-bar-map map)))) + (use-local-map custom-dirlocals-map) + (run-hooks 'Custom-mode-hook)) + +(derived-mode-add-parents 'Custom-dirlocals-mode '(Custom-mode)) + (defmacro custom-dirlocals-with-buffer (&rest body) "Arrange to execute BODY in a \"*Customize Dirlocals*\" buffer." ;; We don't use `custom-buffer-create' because the settings here ;; don't go into the `custom-file'. `(progn (switch-to-buffer "*Customize Dirlocals*") - (kill-all-local-variables) + (let ((inhibit-read-only t)) (erase-buffer)) (remove-overlays) - (custom-dirlocals--set-widget-vars) + (Custom-dirlocals-mode) ,@body - (setq-local tool-bar-map - (or custom-dirlocals-tool-bar-map - ;; Set up `custom-dirlocals-tool-bar-map'. - (let ((map (make-sparse-keymap))) - (mapc - (lambda (arg) - (tool-bar-local-item-from-menu - (nth 1 arg) (nth 4 arg) map custom-dirlocals-map - :label (nth 5 arg))) - custom-dirlocals-commands) - (setq custom-dirlocals-tool-bar-map map)))) - (setq-local revert-buffer-function #'Custom-dirlocals-revert-buffer) - (use-local-map custom-dirlocals-map) (widget-setup))) (defun custom-dirlocals-get-options () -- 2.49.0 --=-=-= Content-Type: text/plain > Let's see if somebody else has an opinion. I'm on a trip for the > weekend, so it won't be until next week that I can install this. Don't worry, take your time. -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 09:51:47 2025 Received: (at 77228) by debbugs.gnu.org; 19 Apr 2025 13:51:48 +0000 Received: from localhost ([127.0.0.1]:60417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u68bi-0005KO-H1 for submit@debbugs.gnu.org; Sat, 19 Apr 2025 09:51:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39668) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u68be-0005Jp-DY for 77228@debbugs.gnu.org; Sat, 19 Apr 2025 09:51:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u68bY-0001iw-S0; Sat, 19 Apr 2025 09:51:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=2M8jJOqseiCDP10nhDSruAT/hS/xW6PBPEagAMyMN4s=; b=RTwegVN4q33UTz9RMJMq W6Wg7nPfGntr849uPqnjdPoj3+4Lc4T30DOPw0pN0MwSB2k+AFNl2X/pi5s4Dd+l5gP382cp9rhdm QLDmc3NyJeVXsIvkiEYMpE4jBC2NHl+VN0vevkw3FWumqyHRqvM2L3xyYn5HqQ8hkAXkXs8OS/n03 wRtj/CsJIXcZ2dS2dJg3UXLT2ATaIC2H1i6jO+5+b5FSHfJPMBoVgpZ4rZ6p71mUGfyrQNFIwzw0T 2wSf6fZ6a8YrqC3wbGCUFmo4hK5hnP9lR+gwTWx3nEEKOZ3eh35hUB3PbSrmhF7fGBPf7uumCmnOU 5ITsNUQVW+ra/A==; Date: Sat, 19 Apr 2025 16:51:35 +0300 Message-Id: <86bjss8djs.fsf@gnu.org> From: Eli Zaretskii To: maurooaranda@gmail.com, Elijah Gabe =?iso-8859-1?Q?P=E9rez?= In-Reply-To: <87ldsfz0f4.fsf_-_@gmail.com> (message from Elijah Gabe =?iso-8859-1?Q?P=E9rez?= on Fri, 04 Apr 2025 22:39:59 -0600) Subject: Re: bug#77228: [PATCH] Create major mode for `customize-dirlocals` References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> <87a58y2iqn.fsf@gmail.com> <87ldsfz0f4.fsf_-_@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77228 Cc: 77228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 77228@debbugs.gnu.org > From: Elijah Gabe Pérez > Date: Fri, 04 Apr 2025 22:39:59 -0600 > > > Let's see if somebody else has an opinion. I'm on a trip for the > > weekend, so it won't be until next week that I can install this. > > Don't worry, take your time. Ping! Any progress here? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 19 12:46:11 2025 Received: (at 77228) by debbugs.gnu.org; 19 Apr 2025 16:46:11 +0000 Received: from localhost ([127.0.0.1]:36228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u6BKV-0006Cs-8z for submit@debbugs.gnu.org; Sat, 19 Apr 2025 12:46:11 -0400 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:61770) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u6BKS-0006C2-Ga for 77228@debbugs.gnu.org; Sat, 19 Apr 2025 12:46:09 -0400 Received: by mail-qv1-xf41.google.com with SMTP id 6a1803df08f44-6ecfc2cb1aaso28065986d6.3 for <77228@debbugs.gnu.org>; Sat, 19 Apr 2025 09:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745081163; x=1745685963; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3jjCB8FCGJClyblW/AAqcLbdbr8i6EQlmL58i/AeOVg=; b=W8UxtpzUgxuD8us9E2HVy39Wq0gZzMH/I0CUyvF73ErVoQbLtx+Cn4oM5kAJAdr3XO UHW/oKv/nEdQBFwQoC6MrMuEjIvRcuogjwTIUGpLaGyLB462CZApfqP6kU7npOQZGsKy upTE1c/c/SISmKYfw3MnumAEfcT8L4sSldkt9BpPTBtYbAkYLDw/HMhhL4XJVxpHajLj 02ADOntO8/TAGo7APZAYogzaX3KZKihzKB0NjB/3bNAo013FvCcrioC9cd+gvvBUhBRO X3sDSt2X35pt7CNYpATiJ2tBVQbOA1SU6rtrhb49iCV1IbHEgw4Kr0TBSP0PsOcMnABW JCEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745081163; x=1745685963; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3jjCB8FCGJClyblW/AAqcLbdbr8i6EQlmL58i/AeOVg=; b=FGmq9bZKwZ6RVVk7ehegJuqpRuT/OWsdKrXboOkIuTZB+p9w8WKsPAq471ESvSXG6b 2tJYT6bR3VUoC88H3JWPVw5n9OF3oqC/KpVnnPH9chnf56KViUvjELnBfFmGAdAMbmuw TUosO6GGcTcyI1xxm9Syyqc6nzJ5k9ni/wh8GuFGGAFiFG+b8cxIg9zFMOONVLxtZgbA 4+bcpbtFA9H5Lo7hPutUrGcI6zp/uOCs56jsyeUCkvnoQkGE0UwvBA7QvHkBjXgP6OVV 6be1BSMKA0IDrmOBqkVQkGX9yTVU5JvBLRTmGHq6wj16Q7eNo+Wb3GDQuCt4mBpnD0IH jERA== X-Forwarded-Encrypted: i=1; AJvYcCUecL2tooOF6LCsgv/dsEkh5kgDyZRl4m4p/TmjhB1HMixsAxellCcEzfviqrG77Bq2qmz1tw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxZFuaNkm6gSETzEJwXCQQPrxai4fTqqrXmHZGvWCK3MLGtS0KD mmQZ1KnBRTiesMhBBu6mwzKlhblAcjRU/xsTBuI5JxdA9x2XOcHwdJfnAEeaMHO3kT6bvSIK8Zr ShPhu4m+bXPNNfmd8nZkOIYjvRvw= X-Gm-Gg: ASbGncs5lFtYJNLri4zm4nfP2hqVMRv2shanL6EXtjenmUwk+oJw3NkcydaZ7L6GFSS eOGj6wktqOOM5CrslTsIZOTTjtxNCozn7Q9gccUbFuQF1gpoGqvDhhVYPgqFBxVANaMCXRp1SPK M5EocEEJN3zaYMDfHZJtgUpxvMKsEyN8sOJBnOsRXx/1G1/nVK8pap X-Google-Smtp-Source: AGHT+IE6Rd0y0fZwiIXHwk7/oOmYztFcc1BLALkpHEcdxUl8Q1xkYerFBvJvauu6+1plOr3o1E1oeUJBP5xYBwGgMMI= X-Received: by 2002:a05:6214:176e:b0:6f2:c81f:9f04 with SMTP id 6a1803df08f44-6f2c81fa606mr77592576d6.35.1745081162669; Sat, 19 Apr 2025 09:46:02 -0700 (PDT) MIME-Version: 1.0 References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> <87a58y2iqn.fsf@gmail.com> <87ldsfz0f4.fsf_-_@gmail.com> <86bjss8djs.fsf@gnu.org> In-Reply-To: <86bjss8djs.fsf@gnu.org> From: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= Date: Sat, 19 Apr 2025 10:45:50 -0600 X-Gm-Features: ATxdqUFCdwjJcQXJ34NoeTPOzI1IxvRbojYCMEDtfzSsauUhQhsDEH7h1xlbw0E Message-ID: Subject: Re: bug#77228: [PATCH] Create major mode for `customize-dirlocals` To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000ce24360633245ee9" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77228 Cc: Mauro Aranda , 77228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --000000000000ce24360633245ee9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: > > Cc: 77228@debbugs.gnu.org > > From: Elijah Gabe P=C3=A9rez > > Date: Fri, 04 Apr 2025 22:39:59 -0600 > > > > > Let's see if somebody else has an opinion. I'm on a trip for the > > > weekend, so it won't be until next week that I can install this. > > > > Don't worry, take your time. > > Ping! Any progress here? > Well, the patch is ready to install, I'm waiting Mauro's review. > --000000000000ce24360633245ee9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii writes:
= > Cc: 77228@debbugs.gnu.org
> From: Elijah Gabe P=C3=A9rez <eg642616@gmail.com>
> Date: Fri, 04 Apr 2025 22:39:59 -0600
>
> > Let's see if somebody else has an opinion. I'm on a trip = for the
> > weekend, so it won't be until next week that I can install th= is.
>
> Don't worry, take your time.

Ping!=C2=A0 Any progress here?

Well, the patch is ready to install, I'm = waiting Mauro's review.
--000000000000ce24360633245ee9-- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 24 06:44:54 2025 Received: (at 77228) by debbugs.gnu.org; 24 Apr 2025 10:44:55 +0000 Received: from localhost ([127.0.0.1]:36701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7u4c-0007hL-JD for submit@debbugs.gnu.org; Thu, 24 Apr 2025 06:44:54 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]:51206) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u7u4Z-0007h2-HG for 77228@debbugs.gnu.org; Thu, 24 Apr 2025 06:44:52 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-7370a2d1981so611133b3a.2 for <77228@debbugs.gnu.org>; Thu, 24 Apr 2025 03:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745491485; x=1746096285; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8DsFgk36XWXcSFiUH6gtQcqqW2LCePiQvPO4wM3uQ30=; b=kB/bi2DU2jKlX5Cz/7f5IYwUyNlPShbgS8438g893yOa0RCruU51c5A7hxurWhkPlP oYakiKukq7ncrMt8fLBLC5UBCo8l1rwe76aAg1CIAmID9P9mfbysQFQJ6PmRdCy6+fGt IRlut8+oNJao0mmtynLeWEzK7HABjjL9xB05d9JBNr6XMt1FrhdN5ZIscVKkqH6GkOAt 6ohKGg+y3EotoBEcoseZYkBwfm2p07NzKJ8/UeMaZ7ag9cfZVV2+PASObPBo1UukRLBJ TQXLNyx9OgaUjr7yq2zTRDAmV/g3SbpytZAI4dhzI5r50EJoZzWcge411jTkRGOm2Fpc xsyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745491485; x=1746096285; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8DsFgk36XWXcSFiUH6gtQcqqW2LCePiQvPO4wM3uQ30=; b=Oqws74AL/CCbQ/SBiZbwEh/4QrX6/KF9h9zFv8Z5/gM/xB3bDonBDZy3LSFR/Wjpd1 R/mXibPStKPY08QUa0D8cDa8XSadayKK4FnKv4o8yVH9HYRlFFeAf/qhFNqGa/3rdQt5 P+bdxmHsDuX9mBCZE0qV5x/LZeL+daga45+z7FWEwR36FJdsTlPrEUj2prwPOUQknB/f BspvnVYalLrwcpUCHFN9ei9qxTtNPfbNFRiQhBJhUrInxLEMq2S650UQwMSIlEuliDXa RilUPfOQRIKfAcLLuYawVuPMMKn4ThHo4hSZHSlZG3v2Lnl71r341de8+uEvvVEdgmdw iBHA== X-Gm-Message-State: AOJu0YyhRnykF2kRtyPVFxnT2ulnmwAqOwOVcI0SfPLncEUPFR+pfORP s0JddZizSJGDei69kxNu1WrkRLIFt6pDfUqXyLaqekbeTYTGkEjX3qrBDmGe X-Gm-Gg: ASbGncuzr+jwlcJ63SM7mWayePcOk8JP5xRLiHlQegkV78dmpEpDmU5jnHekZ1L3iJb 3LztHeKo/yhnOTahUdW+5SvSzjxiXgZBQLMkMSWvishDa/OUVAndX8onack2qZJD9bHP3nTsmvM JH8iJWexEnvJrKQippuTX4Cv6VV6Axt4634oOB0WqtS1VO/zzIrfR9PbCm2kO02HF602VOwyl3v 9TaQCKnlCoQWQ6hSJLl/8a/feOEX8qefR7s8WiBbtfjFvjbZH6YY+/tHMq0PNo3MRJ2q4tP0Ee9 3y8/YNTJn6McNBZgyESJX6iMw2lHbT6FegLPwjD8+VktmfU= X-Google-Smtp-Source: AGHT+IFOPjp31uzT3IY82LDeAF/LnBrkiApBOkxJMpkuWPjUoxDbw9JnNMSbgrMpJr7ve6HV86tsmA== X-Received: by 2002:a05:6a21:3a8b:b0:1f5:9393:fd4d with SMTP id adf61e73a8af0-20444f22dafmr3448156637.27.1745491485379; Thu, 24 Apr 2025 03:44:45 -0700 (PDT) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73e25a6a8c2sm1092283b3a.98.2025.04.24.03.44.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 03:44:44 -0700 (PDT) Message-ID: Date: Thu, 24 Apr 2025 07:44:42 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77228: [PATCH] Create major mode for `customize-dirlocals` To: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= , Eli Zaretskii References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> <87a58y2iqn.fsf@gmail.com> <87ldsfz0f4.fsf_-_@gmail.com> <86bjss8djs.fsf@gnu.org> Content-Language: en-US From: Mauro Aranda In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77228 Cc: 77228@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Elijah Gabe Pérez writes: > Eli Zaretskii writes: > >  > Cc: 77228@debbugs.gnu.org >  > From: Elijah Gabe Pérez >  > Date: Fri, 04 Apr 2025 22:39:59 -0600 >  > >  > > Let's see if somebody else has an opinion. I'm on a trip for the >  > > weekend, so it won't be until next week that I can install this. >  > >  > Don't worry, take your time. > >  Ping!  Any progress here? > > Well, the patch is ready to install, I'm waiting Mauro's review. Code changes look good to me.  Please remember to add a mention to the bug number in the commit log message. Currently, I don't have good access to internet, so I'd appreciate if someone else can install the patch, to not delay this further. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 24 08:08:54 2025 Received: (at 77228-done) by debbugs.gnu.org; 24 Apr 2025 12:08:54 +0000 Received: from localhost ([127.0.0.1]:37083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u7vNu-0001KU-1J for submit@debbugs.gnu.org; Thu, 24 Apr 2025 08:08:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40996) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u7vNo-0001Jm-3r for 77228-done@debbugs.gnu.org; Thu, 24 Apr 2025 08:08:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u7vNi-0001QK-I2; Thu, 24 Apr 2025 08:08:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=oY2rdI2Mm3dGtKYwHHu6ZPse0J/L15VrhYh58m05Tsc=; b=Kwrs7UHooMx59U1OkbMH SV6tSpExmQ949srD5gVqI3WuYmyI1qtwmX9octNqqUCSfY/VkbBVj3JmvK1zR2FHGMRh6/RWrOwIK jQMFBjaxsn3KApSOLqjKTOCnUgwngvSHFncclD6cApNZy2omqB91sTszkbo66P5I4uKkf6pZaI+zD FMbTDrpzRKhB97HIN6lpzRKccA3wx8ddA2KeFZ1ejbpsqk6/UQjmHh50WSn5G4VnJYdWeG+UouSaZ FbZVJIPjB/Cn51/1PLAoI7gyjs0Bap5OEsDmlhjRJEUKNPPjjBMs/q34RyElgCrI2J5aa/rMkamcr euBg8MailAxqTQ==; Date: Thu, 24 Apr 2025 15:08:37 +0300 Message-Id: <864iydzrqy.fsf@gnu.org> From: Eli Zaretskii To: Mauro Aranda In-Reply-To: (message from Mauro Aranda on Thu, 24 Apr 2025 07:44:42 -0300) Subject: Re: bug#77228: [PATCH] Create major mode for `customize-dirlocals` References: <87y0wvrt00.fsf@gmail.com> <3913d51a-50e0-4b5e-8458-896528c53ef0@gmail.com> <87a58y2iqn.fsf@gmail.com> <87ldsfz0f4.fsf_-_@gmail.com> <86bjss8djs.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77228-done Cc: eg642616@gmail.com, 77228-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 24 Apr 2025 07:44:42 -0300 > Cc: 77228@debbugs.gnu.org > From: Mauro Aranda > > Elijah Gabe Pérez writes: > > > Eli Zaretskii writes: > > > >  > Cc: 77228@debbugs.gnu.org > >  > From: Elijah Gabe Pérez > >  > Date: Fri, 04 Apr 2025 22:39:59 -0600 > >  > > >  > > Let's see if somebody else has an opinion. I'm on a trip for the > >  > > weekend, so it won't be until next week that I can install this. > >  > > >  > Don't worry, take your time. > > > >  Ping!  Any progress here? > > > > Well, the patch is ready to install, I'm waiting Mauro's review. > > Code changes look good to me.  Please remember to add a mention to the > bug number in the commit log message. > > Currently, I don't have good access to internet, so I'd appreciate if > someone else can install the patch, to not delay this further. Thanks, done. From unknown Sat Jun 21 03:07:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 23 May 2025 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator