From unknown Tue Jun 17 03:39:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77224 <77224@debbugs.gnu.org> To: bug#77224 <77224@debbugs.gnu.org> Subject: Status: [PATCH] New minor mode 'cursor-indicators-mode' Reply-To: bug#77224 <77224@debbugs.gnu.org> Date: Tue, 17 Jun 2025 10:39:40 +0000 retitle 77224 [PATCH] New minor mode 'cursor-indicators-mode' reassign 77224 emacs submitter 77224 Elijah Gabe P=C3=A9rez severity 77224 normal tag 77224 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 23 18:58:53 2025 Received: (at submit) by debbugs.gnu.org; 23 Mar 2025 22:58:53 +0000 Received: from localhost ([127.0.0.1]:53037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twUHM-0002Qs-SD for submit@debbugs.gnu.org; Sun, 23 Mar 2025 18:58:53 -0400 Received: from lists.gnu.org ([2001:470:142::17]:49108) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twUHK-0002Qb-2m for submit@debbugs.gnu.org; Sun, 23 Mar 2025 18:58:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twUHE-00009P-PX for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 18:58:44 -0400 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twUHC-00080v-AC for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 18:58:44 -0400 Received: by mail-ot1-x342.google.com with SMTP id 46e09a7af769-72b0626c785so2674333a34.2 for ; Sun, 23 Mar 2025 15:58:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742770720; x=1743375520; darn=gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=UErBeR5jcvm5P7UwjJ0ebo9FJsW77QEpPP0SNuBTK8Q=; b=kEqAs6a8LIv66yvSY4ipxvtkd71SAtD35ckf3q8TllnF8roBfu4xaO8OHpFT/OViaO ELi/ivgpf7mVOWf43mHOuaWRR/p/t5Unz/gJQUaps/XvOtxjK9Ng9e9ELSIS/qVOQQN/ tx6K6JHZRMwcoNNnYTL0FlKwBEoKFcou0ZJs2QpcA9h7xticoTatAuqWGvmcN/EBAcqx OOAN0pZ+qYPjuEWaKiUJCXsUmjn7eUbMOXYd1XzW+g8iP7LiAWWd4qnRYa940l+NKJyf czL0fBw8ne7pwnIFRbfsfLStZhgV9lg7GPyMl5ktcvns0jPXS3gOWaBuQ9pfDQ8/tDvi lQ4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742770720; x=1743375520; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UErBeR5jcvm5P7UwjJ0ebo9FJsW77QEpPP0SNuBTK8Q=; b=VGY/+mTNPK79w3T3qO5kywnku5ZxEOe+9hFyMegkN6Q+eEny74m2rGnpSOpatjnS51 K1RvHyVrtZHDkJjWQU1DLuStmKBJcFJfTN0QtPAT6XfhxKIbfst6nefLbcTAioA8IP8v UoKHUUEcjG2GYs0JKK0CSOxyXSmVddsn8SN4PH1/N5SpWSRDq/qCdlMs64YBAjh+35Fc cip9g43U84K+b2Bx9mBJnTN29swGcXeGkQ8U9MJ9E/4YVmroHAi1JZnUXG/t0TVwfY73 VhmYWZPiED9kqpGtwA9o8uiNu/d+bAbW/f48Pg/ihM3WkX3e0xL2v9DPwIR3oxvIWHML T3LQ== X-Gm-Message-State: AOJu0YwKjxyJz9zutsuWUnJwNnELJfkYLtzf/LfqOaVWtb8YBEc4+ty/ a1xoKP0xP7g3ERjobM7MbMJ/a7SZ+xXDkXRjLmBZk7CwOx7GOfl+svkTw6Ri X-Gm-Gg: ASbGncsF+4FJT80gbb985rSAwbfe5tdlm83oWvDiQAeIj03R42fEbHw0V+oxdeFfW2f QswB5iZEy6JVzlq+20QBOGpZecJHfXBkRm+mI7RjbUDWES62uaAe0dHc7A0IRx0ejIkOPHVDToQ MuYJXx8RrDW037z7bgqEOlEA21aIPwGbXB56K0SuOhAOohgM+LjwFyWHcOOOWt/RiThVeNZ4ccQ 81BxZkQVMVRegJ+Gk47IM5OX3TOS6G/BPYTb0cJNNFXPVTiXxoPXpnuLJYzcl/AZwo3j6LdowMp h0aO7S2Xh+4D X-Google-Smtp-Source: AGHT+IE4cNNKYNJo773ippanNwOlTYE+lJ0bqmWMMdwzZnC/jXp9lmafPYVqQU6V5sT3MpyPgD2/cg== X-Received: by 2002:a05:6830:640a:b0:72b:8aec:fbd5 with SMTP id 46e09a7af769-72c0ae4f1b4mr6823202a34.1.1742770719993; Sun, 23 Mar 2025 15:58:39 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c0ac887e6sm1348120a34.67.2025.03.23.15.58.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 15:58:39 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] New minor mode 'cursor-indicators-mode' Date: Sun, 23 Mar 2025 16:58:37 -0600 Message-ID: <87iknzxski.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::342; envelope-from=eg642616@gmail.com; helo=mail-ot1-x342.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Based on Stefan Kangas comments, this minor mode mode changes the cursor appearance to indicate overwrite mode or read-only buffers. This is extracted from `cua-enable-cursor-indications'. Start of forwarded message From: Stefan Kangas Subject: Re: Should 'cua-overwrite-cursor-color' be standalone? To: Elijah Gabe Pérez , Sat, 22 Mar 2025 [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2001:470:142:0:0:0:0:17 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (eg642616[at]gmail.com) 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (eg642616[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 HTML_MESSAGE BODY: HTML included in message X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Based on Stefan Kangas comments, this minor mode mode changes the cursor appearance to indicate overwrite mode or read-only buffers. This is extracted from `cua-enable-cursor-indications'. -------------------- Start of forwarded message -------------------- From: Stefan Kangas Subject: Re: Should 'cua-overwrite-cursor-color' be standalone? To: Elijah Gabe P=C3=A9rez , emacs-devel@gnu.org Date: Sat, 22 Mar 2025 02:01:11 -0500 (1 day, 15 hours, 49 minutes ago) Elijah Gabe P=C3=A9rez writes: > I've noticed about this variable today, but > Should not this option be part of =3Doverwrite=3D instead =3Dcua=3D? > Or be a standalone minor-mode? > > IMO, I find this useful outside =3Dcua=3D. I think a standalone mode is probably best, because if you want the cursor color changed for overwrite-mode, you might want it for buffer-read-only too. In other words, I'd do both of these: cua-overwrite-cursor-color cua-read-only-cursor-color FWIW, I have this in my init file since forever: (setq my/set-cursor-color-color "") (setq my/set-cursor-color-buffer "") (defun my/set-cursor-color-according-to-mode () "Change cursor color according to some minor modes." ;; set-cursor-color is somewhat costly, so we only call it when neede= d: (let ((color (if buffer-read-only "#8888FF" (if overwrite-mode "#000000" "#FF0000")))) (unless (and (string=3D color my/set-cursor-color-color) (string=3D (buffer-name) my/set-cursor-color-buffer)) (set-cursor-color (setq my/set-cursor-color-color color)) (setq my/set-cursor-color-buffer (buffer-name))))) (add-hook 'post-command-hook 'my/set-cursor-color-according-to-mode) I picked it up on EmacsWiki years ago. -------------------- End of forwarded message -------------------- --==-=-= Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Based on Stefan Kangas comments, this minor mode mode changes the cursor appearance to indicate overwrite mode or read-only buffers.

This is extracted from `cua-enable-cursor-indications'.

---------------–— Start of forwarded message ---------------&= #x2013;—
From: Stefan Kangas <stefankangas@gmail.com>
Subject: Re: Should 'cua-overwrite-cursor-color' be standalone?
To: Elijah Gabe P=C3=A9rez <eg642616@gmail.com>, emacs-devel@gnu.org=
Date: Sat, 22 Mar 2025 02:01:11 -0500 (1 day, 15 hours, 49 minutes ago)

Elijah Gabe P=C3=A9rez <eg642616@gmail.com> writes:

I've noticed about this variable today, but
Should not this option be part of overwrite instead cua<= /code>?
Or be a standalone minor-mode?

IMO, I find this useful outside cua.

I think a standalone mode is probably best, because if you want the
cursor color changed for overwrite-mode, you might want it for
buffer-read-only too.

In other words, I'd do both of these:

cua-overwrite-cursor-color
cua-read-only-cursor-color

FWIW, I have this in my init file since forever:

(setq my/set-cursor-color-color "")
(setq my/set-cursor-color-buffer "")
(defun my/set-cursor-color-according-to-mode ()
"Change cursor color according to some minor modes."
;; set-cursor-color is somewhat costly, so we only call it when needed: (let ((color
(if buffer-read-only "#8888FF"
(if overwrite-mode "#000000"
"#FF0000"))))
(unless (and
(string=3D color my/set-cursor-color-color)
(string=3D (buffer-name) my/set-cursor-color-buffer))
(set-cursor-color (setq my/set-cursor-color-color color))
(setq my/set-cursor-color-buffer (buffer-name)))))
(add-hook 'post-command-hook 'my/set-cursor-color-according-to-mode)

I picked it up on EmacsWiki years ago.

---------------–— End of forwarded message ---------------&#x= 2013;—

--==-=-=-- --=-=-= Content-Type: text/patch; charset=utf-8 Content-Disposition: attachment; filename=0001-New-minor-mode-cursor-indicators-mode.patch Content-Transfer-Encoding: quoted-printable >From 15b9074636a31676b83ac7e2086959e23b93cd11 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sat, 22 Mar 2025 22:56:01 -0600 Subject: [PATCH] New minor mode 'cursor-indicators-mode' This minor mode changes the cursor appearance to indicate overwrite mode or read-only buffers. (bug#) Acts similar to 'cua-enable-cursor-indications' * etc/NEWS: Document changes. * lisp/cursor-indicators.el (cursor-indicators-overwrite-indicator) (cursor-indicators-read-only-indicator): New user options. (cursor-indicators--default-cursor-color): New use internal variable. (cursor-indicators--update-indications): New use internal function. (cursor-indicators-mode): New minor mode definition. --- etc/NEWS | 5 ++ lisp/cursor-indicators.el | 125 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 130 insertions(+) create mode 100644 lisp/cursor-indicators.el diff --git a/etc/NEWS b/etc/NEWS index cc63d03eafe..22c84d253ba 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1566,6 +1566,11 @@ This user option replaces 'follow-mode-prefix', whic= h had to be set before loading Follow mode. This new option allows you to change the prefix even after it was loaded, using 'customize-option' or 'setopt'. =20 +--- +*** New minor mode 'cursor-indicators-mode' +This minor mode changes cursor type and/or face to indicate +overwrite mode or read-only buffers. + --- *** cdl.el is now obsolete. Use 'shell-command' and 'shell-command-on-region' instead. diff --git a/lisp/cursor-indicators.el b/lisp/cursor-indicators.el new file mode 100644 index 00000000000..d97237c6942 --- /dev/null +++ b/lisp/cursor-indicators.el @@ -0,0 +1,125 @@ +;;; cursor-indicators.el --- Cursor indicators for some states -*- lexica= l-binding: t; -*- + +;; Copyright (C) 2025 Free Software Foundation, Inc. + +;; Author: El=C3=ADas Gabriel P=C3=A9rez +;; Keywords: + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: +;; This package changes cursor appearance (color and/or type) to indicate +;; overwrite mode and read-only buffers. +;; +;; For example: +;; +;; The following setting will use a YELLOW cursor in overwrite mode in rea= d-write +;; buffers, and a GREEN cursor in read-only buffers: +;; +;; (setq cursor-indicators-overwrite-indicator "yellow") +;; (setq cursor-indicators-read-only-indicator "green") + + +;;; Code: +(defcustom cursor-indicators-overwrite-indicator "yellow" + "Cursor indicator used when overwrite mode is set, if non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defcustom cursor-indicators-read-only-indicator "darkgreen" + "Cursor indicator used in read-only buffers, if non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defvar cursor-indicators--default-cursor-color (frame-parameter nil 'curs= or-color)) + +(defun cursor-indicators--update-indications () + (let* ((cursor + (or + ;; XXX: global mark? + ;; (and cua--global-mark-active cursor-indicators-global-mark-color) + (and buffer-read-only cursor-indicators-read-only-indicator) + (and overwrite-mode cursor-indicators-overwrite-indicator) + (cons (default-value 'cursor-type) + cursor-indicators--default-cursor-color))) + (color (if (consp cursor) (cdr cursor) cursor)) + (type (if (consp cursor) (car cursor) cursor))) + (if (and color + (stringp color) + (not (equal color (frame-parameter nil 'cursor-color)))) + (set-cursor-color color)) + (if (and type + (symbolp type) + (not (eq type (default-value 'cursor-type)))) + (setq-local cursor-type type)))) + +;;;###autoload +(define-minor-mode cursor-indicators-mode + "Change cursor type and/or face for indications. +When enabled, this mode changes the cursor appearance to indicate +overwrite mode or read-only buffers." + :group 'cursor + :global t + (if cursor-indicators-mode + (progn + (add-hook 'post-command-hook #'cursor-indicators--update-indications) + (cursor-indicators--update-indications)) + (remove-hook 'post-command-hook #'cursor-indicators--update-indication= s) + (set-cursor-color cursor-indicators--default-cursor-color) + (setq-local cursor-type (default-value 'cursor-type)))) + +(provide 'cursor-indicators) +;;; cursor-indicators.el ends here --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 03:37:33 2025 Received: (at 77224) by debbugs.gnu.org; 24 Mar 2025 07:37:33 +0000 Received: from localhost ([127.0.0.1]:54018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twcNI-0005wn-UV for submit@debbugs.gnu.org; Mon, 24 Mar 2025 03:37:33 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:56381) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twcNG-0005wR-RU for 77224@debbugs.gnu.org; Mon, 24 Mar 2025 03:37:31 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id BAA7444383; Mon, 24 Mar 2025 07:37:22 +0000 (UTC) From: Juri Linkov To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87iknzxski.fsf@gmail.com> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> Date: Mon, 24 Mar 2025 09:35:38 +0200 Message-ID: <87o6xq6fud.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduheeludelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepvddprhgtphhtthhopeejjedvvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghgieegvdeiudeisehgmhgrihhlrdgtohhm X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > FWIW, I have this in my init file since forever: > > (setq my/set-cursor-color-color "") > (setq my/set-cursor-color-buffer "") > (defun my/set-cursor-color-according-to-mode () > "Change cursor color according to some minor modes." > ;; set-cursor-color is somewhat costly, so we only call it when needed: > (let ((color > (if buffer-read-only "#8888FF" > (if overwrite-mode "#000000" > "#FF0000")))) > (unless (and > (string= color my/set-cursor-color-color) > (string= (buffer-name) my/set-cursor-color-buffer)) > (set-cursor-color (setq my/set-cursor-color-color color)) > (setq my/set-cursor-color-buffer (buffer-name))))) > (add-hook 'post-command-hook 'my/set-cursor-color-according-to-mode) Cool. Will it be possible to replace these settings in my init file with the new package? #+begin_src emacs-lisp (defun my-change-cursor (&rest _) "Change cursor color and type depending on insertion mode and input method." (set-cursor-color (cond (repeat-in-progress "blue") (current-input-method "red3") (t "black"))) (setq-default cursor-type (cond (overwrite-mode 'box) (t 'bar)))) (add-hook 'post-command-hook 'my-change-cursor t) ;; Also update the cursor on the repeat timer events: (add-function :after repeat-echo-function #'my-change-cursor) #+end_src From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 14:11:06 2025 Received: (at 77224) by debbugs.gnu.org; 24 Mar 2025 18:11:07 +0000 Received: from localhost ([127.0.0.1]:58080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twmGL-0003Wi-Df for submit@debbugs.gnu.org; Mon, 24 Mar 2025 14:11:06 -0400 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]:43313) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1twmGH-0003Vl-MS for 77224@debbugs.gnu.org; Mon, 24 Mar 2025 14:10:59 -0400 Received: by mail-oi1-x242.google.com with SMTP id 5614622812f47-3fa58dc37c5so2828309b6e.1 for <77224@debbugs.gnu.org>; Mon, 24 Mar 2025 11:10:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742839851; x=1743444651; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=I7jF0nrZ+4EEJPwqiJGgpZKHItTkDEnNxNokgXuWopQ=; b=WYed4Nh/qbl7tZepBdfe1adk+q7dnqqMdgxl6ozeAr+I9Uo1fpTPBCGMJs+OBxHAgz xO+KVmdnohEZfMPeJvqF2BHAPWMA6seA4hKRse0Fots2vFRYH36gneej5MM4NT/0Xivg JyosomWhiVlWU2iXLkpy3CdrwdbzKXaYfVw5+8QF5N3qVJ1BM/o5Hg0BLRopPEL0aveB X3nC1DMIkjHYjx6k7pd1SBQDl3PUGtzAQYx5eSjRlAus09t24dVdS66N0J2POXW+OivB NXHdQR2JsKlNPaMOhgwIaz83IztKdIAx3yD8zsWgL8Zw/S5tQ5tVP72IMoycs0Lkwf18 xdag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742839851; x=1743444651; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I7jF0nrZ+4EEJPwqiJGgpZKHItTkDEnNxNokgXuWopQ=; b=ls3dSt1G7abywDGG1PyJ6RslJ+J5DIeSHNg3ZhMXJSTADu+zpEDnTNxEfAspr+F807 Xs3FEhMbeGc7vhRONU0idEWy7lqDvO2FnMmkluH+D84UwpHtNwzFWabv+yXtoTixxvDr sXZj0uBwGklKNgArZ6eagpnDjX/DhFXFnOHz6TZJ7BWW2lhJ0Lmn10mYpiwlW7wDz43w ij7H4fd87nIlITZclZnYLry1B4cHXC8VdRXJ2YyLuRIzWHxZF7v9e/qvetWevQI3AVL9 dnGNehDgCsQ/2+CIZWnn52TvLk4pjNVQ/sTxJ7SH48GvmwdtdWSx/Gv72VjurmS1ycY5 /FOA== X-Gm-Message-State: AOJu0YwYlmWy2yks9BD0NyejEyO78smc+6HwJsRAsV+v24+G3EOfe+Ht px1ssvV+VcP8362HYRM5F8RIq8CqVZ5yQf9W7Cl8P0I3VUiJdfeYNYhCulzK X-Gm-Gg: ASbGncurbHwbn4GUBYnn3dz2sE+E6eAqf+o4QdwKnjRyt2PAPrQ1/vMZ7bQmr/1Sz5A nAmk6HxVOyAoIJMvGaZm60b9FWLR82Ho+Xsrrm0T7OLRO895w5u4Jzt/w4K6WfIPIsQoqemlv7f KHHwyauQRDpMPyG0KOtrje4lEsv4CIFSUFatnW+PUJsc0GiVd83nyjOm2/KY+9cXNp46Th3NTif Mu6Pj6lvtfWfNEwpRQ6WbHymq1Q1WcspUs/nZNJGyLsXhW1Ro5h8xAQ2l/uVcNy4Kwd0JhTZyWE orPLUgcrsZnx X-Google-Smtp-Source: AGHT+IEF8qLi5HVk132mALWTGcT5OuNDcpn4Cvx3boc2mrMrN/uOg7j/yEpG1IteXf3zPV0hgFXz8A== X-Received: by 2002:a05:6808:6b48:b0:3f4:bc5:d47a with SMTP id 5614622812f47-3febee94fbemr9219867b6e.13.1742839850959; Mon, 24 Mar 2025 11:10:50 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3febf79e27dsm1687659b6e.50.2025.03.24.11.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 11:10:50 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Juri Linkov Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87o6xq6fud.fsf@mail.linkov.net> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> Date: Mon, 24 Mar 2025 12:10:48 -0600 Message-ID: <875xjymh93.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Juri Linkov writes: >> FWIW, I have this in my init file since forever: >> (setq my/set-cursor-color-color "") >> (setq my/set-cursor-color-buffer "") >> (defun my/set-cursor-color-according-to-mode () >> "Change cursor color according to some minor modes." >> ;; set-cursor-color is somewhat costly, so we only call it when needed: >> (let ((color >> (if buffer-read-only "#8888FF" >> (if overwrite-mode "#000000" >> "#FF0000")))) >> (unless (and >> (string= color my/set-cursor-color-color) >> (string= (buffer-name) my/set-cursor-color-buffer)) >> (set-cursor-color (setq my/set-cursor-color-color color)) >> (setq my/set-cursor-color-buffer (buffer-name))))) >> (add-hook 'post-command-hook 'my/set-cursor-color-according-to-mode) > Cool. Will it be possible to replace these settings in my init file > with the new package? > #+begin_src emacs-lisp > (defun my-change-cursor (&rest _) > "Change cursor color and type depending on insertion mode and input method." > (set-cursor-color > (cond (repeat-in-progress "blue") > (current-input-method "red3") > (t "black"))) > (setq-default cursor-type > (cond (overwrite-mode 'box) > (t 'bar)))) > (add-hook 'post-command-hook 'my-change-cursor t) > ;; Also update the cursor on the repeat timer events: > (add-function :after repeat-echo-function #'my-change-cursor) > #+end_src Sure, I've updated the patch for handle this. --==-=-= Content-Type: text/html

Juri Linkov <juri@linkov.net> writes:

FWIW, I have this in my init file since forever:

(setq my/set-cursor-color-color "")
(setq my/set-cursor-color-buffer "")
(defun my/set-cursor-color-according-to-mode ()
"Change cursor color according to some minor modes."
;; set-cursor-color is somewhat costly, so we only call it when needed:
(let ((color
(if buffer-read-only "#8888FF"
(if overwrite-mode "#000000"
"#FF0000"))))
(unless (and
(string= color my/set-cursor-color-color)
(string= (buffer-name) my/set-cursor-color-buffer))
(set-cursor-color (setq my/set-cursor-color-color color))
(setq my/set-cursor-color-buffer (buffer-name)))))
(add-hook 'post-command-hook 'my/set-cursor-color-according-to-mode)

Cool. Will it be possible to replace these settings in my init file
with the new package?

#+beginsrc emacs-lisp
(defun my-change-cursor (&rest _)
"Change cursor color and type depending on insertion mode and input method."
(set-cursor-color
(cond (repeat-in-progress "blue")
(current-input-method "red3")
(t "black")))
(setq-default cursor-type
(cond (overwrite-mode 'box)
(t 'bar))))
(add-hook 'post-command-hook 'my-change-cursor t)

;; Also update the cursor on the repeat timer events:
(add-function :after repeat-echo-function #'my-change-cursor)
#+endsrc

Sure, I've updated the patch for handle this.

--==-=-=-- --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-New-minor-mode-cursor-indicators-mode.patch Content-Transfer-Encoding: quoted-printable >From 82a59dce91c15a742ed6031b6961e316c8da627b Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sat, 22 Mar 2025 22:56:01 -0600 Subject: [PATCH] New minor mode 'cursor-indicators-mode' This minor mode changes the cursor appearance to indicate buffers states, such as if overwrite-mode is active or current buffer is read-only. (Bug#77224) Acts similar to 'cua-enable-cursor-indications' * etc/NEWS: Document changes. * lisp/cursor-indicators.el (cursor-indicators-overwrite-indicator) (cursor-indicators-repeat-indicator) (cursor-indicators-input-method-indicator) (cursor-indicators-read-only-indicator): New user options. (cursor-indicators--default-cursor-color): New use internal variable. (cursor-indicators--update-indications): New use internal function. (cursor-indicators-mode): New minor mode definition. --- etc/NEWS | 9 ++ lisp/cursor-indicators.el | 185 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 194 insertions(+) create mode 100644 lisp/cursor-indicators.el diff --git a/etc/NEWS b/etc/NEWS index cc63d03eafe..a9fee82a29e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1566,6 +1566,15 @@ This user option replaces 'follow-mode-prefix', whic= h had to be set before loading Follow mode. This new option allows you to change the prefix even after it was loaded, using 'customize-option' or 'setopt'. =20 +--- +*** New minor mode 'cursor-indicators-mode' +This mode changes cursor appearance (color and/or type) to indicate +different buffer states. This mode have cursor indicators for: +- Overwrite mode +- Read-only buffers +- Repeat mode +- Input method activation + --- *** cdl.el is now obsolete. Use 'shell-command' and 'shell-command-on-region' instead. diff --git a/lisp/cursor-indicators.el b/lisp/cursor-indicators.el new file mode 100644 index 00000000000..6b9ae9677d7 --- /dev/null +++ b/lisp/cursor-indicators.el @@ -0,0 +1,185 @@ +;;; cursor-indicators.el --- Cursor indicators for some states -*- lexica= l-binding: t; -*- + +;; Copyright (C) 2025 Free Software Foundation, Inc. + +;; Author: El=C3=ADas Gabriel P=C3=A9rez +;; Keywords: + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: +;; This package changes cursor appearance (color and/or type) to indicate +;; different buffer states. +;; +;; For example: +;; +;; The following setting will use a YELLOW cursor in overwrite mode in rea= d-write +;; buffers, and a GREEN cursor in read-only buffers: +;; +;; (setq cursor-indicators-overwrite-indicator "yellow") +;; (setq cursor-indicators-read-only-indicator "green") + + +;;; Code: + +;;; User options +(defcustom cursor-indicators-overwrite-indicator "red3" + "Cursor indicator used when overwrite mode is set, if non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defcustom cursor-indicators-read-only-indicator "darkgreen" + "Cursor indicator used in read-only buffers, if non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defcustom cursor-indicators-repeat-indicator "blue" + "Cursor indicator used when `repeat-in-progress' is non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defcustom cursor-indicators-input-method-indicator "dark magenta" + "Cursor indicator used when input method is activated now. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +;;; Internal Code + +(defvar cursor-indicators--default-cursor-color (frame-parameter nil 'curs= or-color)) + +(defun cursor-indicators--update-indications (&optional cursor-color) + (let* ((cursor + (or + ;; CURSOR-COLOR is intended to be used by the user in an advice= -add + cursor-color + ;; XXX: global mark? + ;; (and cua--global-mark-active cursor-indicators-global-mark-c= olor) + (and buffer-read-only cursor-indicators-read-only-indicator) + (and overwrite-mode cursor-indicators-overwrite-indicator) + (and (bound-and-true-p repeat-in-progress) cursor-indicators-re= peat-indicator) + (and (bound-and-true-p current-input-method) cursor-indicators-= input-method-indicator) + (cons (default-value 'cursor-type) + cursor-indicators--default-cursor-color))) + (color (if (consp cursor) (cdr cursor) cursor)) + (type (if (consp cursor) (car cursor) cursor))) + (if (and color + (stringp color) + (not (equal color (frame-parameter nil 'cursor-color)))) + (set-cursor-color color)) + (if (and type + (symbolp type) + (not (eq type (default-value 'cursor-type)))) + (setq-local cursor-type type)))) + +;;;###autoload +(define-minor-mode cursor-indicators-mode + "Change cursor type and/or face for indications. +When enabled, this mode changes the cursor appearance to indicate +overwrite mode or read-only buffers." + :group 'cursor + :global t + (if cursor-indicators-mode + (progn + (add-hook 'post-command-hook #'cursor-indicators--update-indications) + (cursor-indicators--update-indications)) + (remove-hook 'post-command-hook #'cursor-indicators--update-indication= s) + (set-cursor-color cursor-indicators--default-cursor-color) + (setq-local cursor-type (default-value 'cursor-type)))) + +(provide 'cursor-indicators) +;;; cursor-indicators.el ends here --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 14:49:31 2025 Received: (at 77224) by debbugs.gnu.org; 24 Mar 2025 18:49:31 +0000 Received: from localhost ([127.0.0.1]:58398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twmra-0000BY-KV for submit@debbugs.gnu.org; Mon, 24 Mar 2025 14:49:31 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:53687) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1twmrX-0000Af-Ks for 77224@debbugs.gnu.org; Mon, 24 Mar 2025 14:49:28 -0400 Received: by mail-oi1-x243.google.com with SMTP id 5614622812f47-3f6a92f234dso2670789b6e.3 for <77224@debbugs.gnu.org>; Mon, 24 Mar 2025 11:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742842161; x=1743446961; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EI3/qq0DZK8fLacC2IwkKo9MQzm0N+GZH+dvuEnwkGs=; b=cXNbR0+OfTjsO9ZljolVD1TxS5x9ePm+rhvZW/JocyiSgvDUKR1JOsi1eBAfLWMhDE fH87YSNPg+dH5kUI9klFfc4fB5PQKVS+0g6FefSmdg+yVgp54FDan2TfwkvvWwQGlvm9 zEuYmySdso8ZG2t8u0LEgGgaOvB8I8Qa5xXobOUPG08DyzJ0dmwJ499TLUJtNIIw0l2C DQOxZij/DNVQ7qwa7Km+C3Q+IwbNcOl9yecX+U+Ozq+1exT2UP2HWKb3faZ8krk1W9N0 NGg8ZoLhEdqsNZ3D9vktVSikx/Np40zrCQ4NU/fs9r5PrSKnemD2XmLIduLdpajaK+Us mttQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742842161; x=1743446961; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EI3/qq0DZK8fLacC2IwkKo9MQzm0N+GZH+dvuEnwkGs=; b=XqmsEahTUuRa/XWud3c7CdZj3fhbJeMmtnR9Cpd34VxeQfDDeegjwjJHYPs1F99NgE aBQ6e44dySBWf4M9Y7cI24q9ur5GeR9gPA2ayhrgXUEqsB34ucCaGqw1eSmZnrjPG/VG +nfvjLE1o7RQETCLKSVqXYyeudi+Oi8Hu6zHvQ7atEm2TppcNFu38fB6bunuF69wZPUw 9b66ak3f65lXSB/C0iTupoBk1Sb/uUVUy6LDe7KVvv093La0qXu6a3TIzo/XSQM4/tKt Kl+to2rBw6oLwJHEd4PRSJX9XDwsN5uHF3DuBZlCZH3iOumHYVHmd77McbEB72dli2vD LqfA== X-Gm-Message-State: AOJu0Yyuotz8nc221slnlf0TddGz7VepZo/7l8e9RuLeI2oXG6mCL7FA d3V5kNd+YGD0ClCRTi1mApnbi7dDryZJe2o1RkIMGDT5XvrizAF/ X-Gm-Gg: ASbGncuJ0cUw1CxqGXJ8OU39T7hBaYRbjVG78ejHSAV8gYofq0Wb6ZSeePGVm9tvbn5 P6EfSQwpH3du85ZOHFsgFyX4F4Fqwrq9ivt3U1zcvoCVZzZjZoZyCBiAlaq/3CeF4R2nB7VrRKw lh3Uh+CFh7n0pMDl/5eMBtn8vSVJ/D1UM5BznrY2m0QQe9IpLNOa3EFA84/Kgn5OG1F1yAH+m7z dKiAR3YciRoYMkhfrQfa5OTeoTsgmSVn2zDHy5fNoQ2ui0MUtlR2kuJY5pJIHcEDFz/KDJwxVWu puNsgkCwIb26 X-Google-Smtp-Source: AGHT+IHQDT2aOIuDvvBQjx8I+piE5HmA6YrNqNkqGo+iFSJYPzWB9VYnZN/f8Cq64J4MMrGoLD+rqA== X-Received: by 2002:a05:6808:199c:b0:3f9:17f9:30bd with SMTP id 5614622812f47-3febf702481mr8726512b6e.7.1742842161121; Mon, 24 Mar 2025 11:49:21 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3febf79dda8sm1668667b6e.44.2025.03.24.11.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 11:49:20 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: eg642616@gmail.com Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <875xjymh93.fsf@gmail.com> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> Date: Mon, 24 Mar 2025 12:49:19 -0600 Message-ID: <87ikny2rio.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, shipmints@gmail.com, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Ship Mints writes: > I think you need to update your configuration to not use tabs in lisp code--your patch is filled with tabs. > Standard elisp is this (see emacs/.dir-locals.el for other settings): > (emacs-lisp-mode . ((indent-tabs-mode . nil) ... Yeah, i forgot to untabify the whole file. Sending fixed one. --==-=-= Content-Type: text/html

Ship Mints <shipmints@gmail.com> writes:

I think you need to update your configuration to not use tabs in lisp code–your patch is filled with tabs.
Standard elisp is this (see emacs/.dir-locals.el for other settings):
(emacs-lisp-mode . ((indent-tabs-mode . nil) …

Yeah, i forgot to untabify the whole file.

Sending fixed one.

--==-=-=-- --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-New-minor-mode-cursor-indicators-mode.patch Content-Transfer-Encoding: quoted-printable >From b2e9e8e1b60c3d0f051c3c7d0bbe6af39edf2408 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sat, 22 Mar 2025 22:56:01 -0600 Subject: [PATCH] New minor mode 'cursor-indicators-mode' This minor mode changes the cursor appearance to indicate buffers states, such as if overwrite-mode is active or current buffer is read-only. (Bug#77224) Acts similar to 'cua-enable-cursor-indications' * etc/NEWS: Document changes. * lisp/cursor-indicators.el (cursor-indicators-overwrite-indicator) (cursor-indicators-repeat-indicator) (cursor-indicators-input-method-indicator) (cursor-indicators-read-only-indicator): New user options. (cursor-indicators--default-cursor-color): New use internal variable. (cursor-indicators--update-indications): New use internal function. (cursor-indicators-mode): New minor mode definition. --- etc/NEWS | 9 ++ lisp/cursor-indicators.el | 185 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 194 insertions(+) create mode 100644 lisp/cursor-indicators.el diff --git a/etc/NEWS b/etc/NEWS index cc63d03eafe..a9fee82a29e 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1566,6 +1566,15 @@ This user option replaces 'follow-mode-prefix', whic= h had to be set before loading Follow mode. This new option allows you to change the prefix even after it was loaded, using 'customize-option' or 'setopt'. =20 +--- +*** New minor mode 'cursor-indicators-mode' +This mode changes cursor appearance (color and/or type) to indicate +different buffer states. This mode have cursor indicators for: +- Overwrite mode +- Read-only buffers +- Repeat mode +- Input method activation + --- *** cdl.el is now obsolete. Use 'shell-command' and 'shell-command-on-region' instead. diff --git a/lisp/cursor-indicators.el b/lisp/cursor-indicators.el new file mode 100644 index 00000000000..cf778c5bfce --- /dev/null +++ b/lisp/cursor-indicators.el @@ -0,0 +1,185 @@ +;;; cursor-indicators.el --- Cursor indicators for some states -*- lexica= l-binding: t; -*- + +;; Copyright (C) 2025 Free Software Foundation, Inc. + +;; Author: El=C3=ADas Gabriel P=C3=A9rez +;; Keywords: + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: +;; This package changes cursor appearance (color and/or type) to indicate +;; different buffer states. +;; +;; For example: +;; +;; The following setting will use a YELLOW cursor in overwrite mode in rea= d-write +;; buffers, and a GREEN cursor in read-only buffers: +;; +;; (setq cursor-indicators-overwrite-indicator "yellow") +;; (setq cursor-indicators-read-only-indicator "green") + + +;;; Code: + +;;; User options +(defcustom cursor-indicators-overwrite-indicator "red3" + "Cursor indicator used when overwrite mode is set, if non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defcustom cursor-indicators-read-only-indicator "darkgreen" + "Cursor indicator used in read-only buffers, if non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defcustom cursor-indicators-repeat-indicator "blue" + "Cursor indicator used when `repeat-in-progress' is non-nil. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +(defcustom cursor-indicators-input-method-indicator "dark magenta" + "Cursor indicator used when input method is activated now. +Only used when `cursor-indicators-mode' is enabled. + +If the value is a COLOR name, then only the `cursor-color' attribute will = be +affected. If the value is a cursor TYPE (one of: box, hollow, bar, or hba= r), +then only the `cursor-type' property will be affected. If the value is +a cons (TYPE . COLOR), then both properties are affected. +If the value is nil then do not change cursor." + :group 'cursor + :type '(choice + (const :tag "None (do not change cursor)" nil) + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (cons :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))) + +;;; Internal Code + +(defvar cursor-indicators--default-cursor-color (frame-parameter nil 'curs= or-color)) + +(defun cursor-indicators--update-indications (&optional cursor-color) + (let* ((cursor + (or + ;; CURSOR-COLOR is intended to be used by the user in an advice= -add + cursor-color + ;; XXX: global mark? + ;; (and cua--global-mark-active cursor-indicators-global-mark-c= olor) + (and buffer-read-only cursor-indicators-read-only-indicator) + (and overwrite-mode cursor-indicators-overwrite-indicator) + (and (bound-and-true-p repeat-in-progress) cursor-indicators-re= peat-indicator) + (and (bound-and-true-p current-input-method) cursor-indicators-= input-method-indicator) + (cons (default-value 'cursor-type) + cursor-indicators--default-cursor-color))) + (color (if (consp cursor) (cdr cursor) cursor)) + (type (if (consp cursor) (car cursor) cursor))) + (if (and color + (stringp color) + (not (equal color (frame-parameter nil 'cursor-color)))) + (set-cursor-color color)) + (if (and type + (symbolp type) + (not (eq type (default-value 'cursor-type)))) + (setq-local cursor-type type)))) + +;;;###autoload +(define-minor-mode cursor-indicators-mode + "Change cursor type and/or face for indications. +When enabled, this mode changes the cursor appearance to indicate +overwrite mode or read-only buffers." + :group 'cursor + :global t + (if cursor-indicators-mode + (progn + (add-hook 'post-command-hook #'cursor-indicators--update-indicatio= ns) + (cursor-indicators--update-indications)) + (remove-hook 'post-command-hook #'cursor-indicators--update-indication= s) + (set-cursor-color cursor-indicators--default-cursor-color) + (setq-local cursor-type (default-value 'cursor-type)))) + +(provide 'cursor-indicators) +;;; cursor-indicators.el ends here --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 03:34:41 2025 Received: (at 77224) by debbugs.gnu.org; 25 Mar 2025 07:34:41 +0000 Received: from localhost ([127.0.0.1]:35920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twyo5-00023h-7f for submit@debbugs.gnu.org; Tue, 25 Mar 2025 03:34:41 -0400 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:46273) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twyo2-00023P-QX for 77224@debbugs.gnu.org; Tue, 25 Mar 2025 03:34:39 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4CF7D20487; Tue, 25 Mar 2025 07:34:28 +0000 (UTC) From: Juri Linkov To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87ikny2rio.fsf@gmail.com> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> Date: Tue, 25 Mar 2025 09:34:08 +0200 Message-ID: <871pula7sn.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduiedvtdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopehshhhiphhmihhnthhssehgmhgrihhlrdgtohhmpdhrtghpthhtohepjeejvddvgeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvgheigedvieduieesghhmrghilhdrtghomh X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, shipmints@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > +*** New minor mode 'cursor-indicators-mode' > +This mode changes cursor appearance (color and/or type) to indicate > +different buffer states. This mode have cursor indicators for: > +- Overwrite mode > +- Read-only buffers > +- Repeat mode > +- Input method activation What if users want to add more conditions? Could you try to create only one defcustom that contains a list of default conditions plus a possible user-defined conditions. For example: #+begin_src emacs-lisp (defcustom cursor-indicators nil :type `(alist :key-type (choice :tag "Condition" (const :tag "Overwrite mode" overwrite) (const :tag "Read-only mode" read-only) (const :tag "Repeat mode" repeat-in-progress) (const :tag "Activated input method" input-method) (function :tag "Matcher function")) ;; User-defined condition :value-type (choice (const :tag "None (do not change cursor)" nil) (color :tag "Color") (choice :tag "Type" (const :tag "Filled box" box) (const :tag "Vertical bar" bar) (const :tag "Horizontal bar" hbar) (const :tag "Hollow box" hollow)) (cons :tag "Color and Type" (choice :tag "Type" (const :tag "Filled box" box) (const :tag "Vertical bar" bar) (const :tag "Horizontal bar" hbar) (const :tag "Hollow box" hollow)) (color :tag "Color"))))) #+end_src Then I could replace: #+begin_src emacs-lisp (defun my-change-cursor (&rest _) "Change cursor color and type depending on insertion mode and input method." (set-cursor-color (cond (repeat-in-progress "blue") (current-input-method "red3") (t "black"))) (setq-default cursor-type (cond (overwrite-mode 'box) (t 'bar)))) #+end_src with just #+begin_src emacs-lisp (setopt cursor-indicators '((repeat-in-progress "blue") (current-input-method "red3") (overwrite-mode 'box) (default 'bar))) #+end_src From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 03:53:21 2025 Received: (at submit) by debbugs.gnu.org; 25 Mar 2025 07:53:21 +0000 Received: from localhost ([127.0.0.1]:35982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twz68-0002x4-VP for submit@debbugs.gnu.org; Tue, 25 Mar 2025 03:53:21 -0400 Received: from lists.gnu.org ([2001:470:142::17]:50316) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twz66-0002wn-RJ for submit@debbugs.gnu.org; Tue, 25 Mar 2025 03:53:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twz60-0006Q6-8F for bug-gnu-emacs@gnu.org; Tue, 25 Mar 2025 03:53:12 -0400 Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twz5y-0001Pv-3Y for bug-gnu-emacs@gnu.org; Tue, 25 Mar 2025 03:53:11 -0400 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1twz5u-00074e-B7 for bug-gnu-emacs@gnu.org; Tue, 25 Mar 2025 08:53:06 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Rudolf Schlatte Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' Date: Tue, 25 Mar 2025 08:52:56 +0100 Message-ID: References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <871pula7sn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:sPdbSBJhMZMbp/5fSFpyt5B+a/U= Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >> +*** New minor mode 'cursor-indicators-mode' >> +This mode changes cursor appearance (color and/or type) to indicate >> +different buffer states. This mode have cursor indicators for: >> +- Overwrite mode >> +- Read-only buffers >> +- Repeat mode >> +- Input method activation > > What if users want to add more conditions? > Could you try to create only one defcustom that > contains a list of default conditions > plus a possible user-defined conditions. > For example: > > #+begin_src emacs-lisp > (defcustom cursor-indicators nil > :type `(alist :key-type > (choice :tag "Condition" > (const :tag "Overwrite mode" overwrite) > (const :tag "Read-only mode" read-only) > (const :tag "Repeat mode" repeat-in-progress) > (const :tag "Activated input method" input-method) > (function :tag "Matcher function")) ;; User-defined condition > :value-type > (choice > (const :tag "None (do not change cursor)" nil) > (color :tag "Color") > (choice :tag "Type" > (const :tag "Filled box" box) > (const :tag "Vertical bar" bar) > (const :tag "Horizontal bar" hbar) > (const :tag "Hollow box" hollow)) > (cons :tag "Color and Type" > (choice :tag "Type" > (const :tag "Filled box" box) > (const :tag "Vertical bar" bar) > (const :tag "Horizontal bar" hbar) > (const :tag "Hollow box" hollow)) > (color :tag "Color"))))) > #+end_src > > > Then I could replace: > > #+begin_src emacs-lisp > (defun my-change-cursor (&rest _) > "Change cursor color and type depending on insertion mode and input method." > (set-cursor-color > (cond (repeat-in-progress "blue") > (current-input-method "red3") > (t "black"))) > (setq-default cursor-type > (cond (overwrite-mode 'box) > (t 'bar)))) > #+end_src > > > with just > > #+begin_src emacs-lisp > (setopt cursor-indicators '((repeat-in-progress "blue") > (current-input-method "red3") > (overwrite-mode 'box) > (default 'bar))) > #+end_src I set the following hooks, which makes the cursor unobtrusive while I'm selecting text (C-SPC then moving cursor). Could this also fit in the above framework? (deactivate-mark-hook . (lambda () (setq cursor-type t))) (activate-mark-hook . (lambda () (setq cursor-type 'bar))) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 08:12:14 2025 Received: (at 77224) by debbugs.gnu.org; 25 Mar 2025 12:12:14 +0000 Received: from localhost ([127.0.0.1]:36660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tx38g-0007lU-70 for submit@debbugs.gnu.org; Tue, 25 Mar 2025 08:12:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34910) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tx38b-0007l5-N2 for 77224@debbugs.gnu.org; Tue, 25 Mar 2025 08:12:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tx38T-0001BN-UJ; Tue, 25 Mar 2025 08:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=AZnr6eYsc7tQmD8NezzdEoVmNCaUqc3+AuwDVwWA1IA=; b=FD8HjQO6W9keVYee5NYX w2sB9IOkfItv31QfJqPI3YLDwKGA0pgKknb68LbKg9wK32ZpDC+1QXJ9lnlvbQzO3eYDx/Lp/Yecc SRZQbuNsRyWPrlOd49P6QQswBQlEofoW3pYRqbQF/TrjQKYk1qWHoF0EFs/dlh1kaly90H8Bq1zxH EOZlzq2M57MEKcoBkAyWGs5kS/zdL8kBxiAlekbmggB9PXvPPFDoVIsxyrK8NNbwXxD2b9L9QnZ6r dHyw55H7eUL+9YtHCW6a1oljGaBl3VUUHx0cg32/L511qDg13QXsYU1PzIviW2ZZqBcsHaaFD7k9A f4eLfDOnv2zIiQ==; Date: Tue, 25 Mar 2025 14:11:58 +0200 Message-Id: <86o6xpe2cx.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: <87ikny2rio.fsf@gmail.com> (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Mon, 24 Mar 2025 12:49:19 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, shipmints@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 77224@debbugs.gnu.org, shipmints@gmail.com, Juri Linkov > From: Elijah Gabe Pérez > Date: Mon, 24 Mar 2025 12:49:19 -0600 > > Ship Mints writes: > > I think you need to update your configuration to not use tabs in lisp code–your patch is filled with tabs. > Standard elisp is this (see emacs/.dir-locals.el for other settings): > (emacs-lisp-mode . ((indent-tabs-mode . nil) … > > Yeah, i forgot to untabify the whole file. Thanks. > +(defcustom cursor-indicators-overwrite-indicator "red3" Using literal color names might be problematic on terminals that don't support enough colors, unless you are extra careful to select colors that are supported everywhere. Alternatively, the default value could be different for different numbers of supported colors. Also, what happens if an Emacs session has both GUI frames (with lots of colors) and TTY frames with a small number of colors -- does each frame get its own color? > + "Cursor indicator used when overwrite mode is set, if non-nil. That "if non-nil" part can potentially confuse, because it isn't clear whether it refers to the value of the variable or to "overwrite mode". Better say this the other way around: If non-nil, the cursor indication to use when overwrite mode is set. (Note that I also slightly reworded the rest of this sentence, for clarity.) Suggest to make the same changes for other user options in this file. > +(defcustom cursor-indicators-repeat-indicator "blue" > + "Cursor indicator used when `repeat-in-progress' is non-nil. repeat-in-progress is an obscure variable, which is also not visible until repeat.el is loaded. Please reword this to be in user-level terms, like "when a command is repeated due to `repeat-mode'" or something similar. Please also add the :version tag to each and every new defcustom. > +(defcustom cursor-indicators-input-method-indicator "dark magenta" > + "Cursor indicator used when input method is activated now. ^^^ What do you mean by "now"? > +(define-minor-mode cursor-indicators-mode > + "Change cursor type and/or face for indications. "Change cursor type and/or face to indicate various minor modes." > +When enabled, this mode changes the cursor appearance to indicate > +overwrite mode or read-only buffers." ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ That is not the full list of indications. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 00:55:28 2025 Received: (at 77224) by debbugs.gnu.org; 26 Mar 2025 04:55:29 +0000 Received: from localhost ([127.0.0.1]:40849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txInY-0002rD-3e for submit@debbugs.gnu.org; Wed, 26 Mar 2025 00:55:28 -0400 Received: from mail-oa1-x43.google.com ([2001:4860:4864:20::43]:58657) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txInU-0002qU-40 for 77224@debbugs.gnu.org; Wed, 26 Mar 2025 00:55:25 -0400 Received: by mail-oa1-x43.google.com with SMTP id 586e51a60fabf-2c759bf1b2eso3352242fac.1 for <77224@debbugs.gnu.org>; Tue, 25 Mar 2025 21:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742964918; x=1743569718; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fJZTtYRiQ4ozjLGDMf31il2vtA4/cyFitZzuQmVWfq0=; b=cXsVFYEm97Of9ViUgDh/Unhk4w8lhyrY7hzGJ6oyeHOyvkHtluhDChGI9cBhDdSOD8 mthFInO3M+naMOPxjAZJiuzOZ5mmZTI3em0eEXq9+y2Oa/9Iu3e4D+6EnaKEu3odfJX4 sgHrE42yCIy9koSRzQrenZiZ8CHamEF4qnKrSxGe2/zMhM430HslTuDiTWVvVcM+sJoJ A5V9igj5B2ly8j0T1KSD7j3K69BYOXOrYC/Pr2jlPwkfOu9ukJBOpeZVX3n+/tGTsIgv vb5MpOeUqLUP2j/DvJBezE1Gj7EWg8+Vta/gV/pYmJy1TQ0U7sAYQqXpHfCAg5dz/N7b W/Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742964918; x=1743569718; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fJZTtYRiQ4ozjLGDMf31il2vtA4/cyFitZzuQmVWfq0=; b=uzpbpVN0f2OMCvthYvtXKIjuL5pVEY/2eI2qlZOpAj8xM6eKwZKRUctJ4KCX7bGlUO 6dWX7XRqWw5zC6+dqz8M2zP2uCeqB4FSxPD8GZIGvZuQiBna84WiH8Dh8DoS86+f0NlY rDuN7PMWhX384oJLZnGJpeQuIuLLmm64idNvq8PmCk9aP8EFskNsD7lC1kZJMh9zGRxJ voeJRoqMOMKLKi4+A+3o+hBsDnmK/7t/IxcSVQRovRZSgXnNKLQHxkiTVYmsMkrpAy2E nfhVUHHf/wn0SZWkxRJj7DLupgxofDry6y6AbSRHix5/zccYiw/z5q80YyMpw6fXQG2d gQCQ== X-Gm-Message-State: AOJu0YxUpe6dfT5KncqcwtogOLr6uOoqG9xH8aOuODYf+NrvZ7jiGx08 jUJSuxYz2/cQ2wd2rZfbRiNlN2Y4KaxqTyNuEOft4K4iV6HFmCXijSLi/o9o X-Gm-Gg: ASbGncvZKhGqMgUKBxVVGiQLQIaY+yo1o52Nm94HP5mT2twm9xSUZtImcpwADQ9bgaO yX5WogdCIiMKE/h8MeTbUPDa4o3sQOf2HjLzVzjYku9k2iATqC1GOBxLQFMkZB+lb/wICEn8BV6 RAJpPcGUlVf/d2ypRCFVuIc7IKoSgI7G3mUQoUUesr2zsLBhpLmwibeHRKlmYvHPXy9GQVd3SNv sA25eMPYjnt29eP2jmfh62ZroYvyidRDjcDabcpI3ONRkIy7QfLWNM4M+MUcEf7vPOkmiqdgDdD vFHZKFqJEs1l X-Google-Smtp-Source: AGHT+IHQcguYjv0+1KQB5CQ7Ohw87RBKbVpxIc5bULOrkP6U4alKM9lYj9k9mB58eaO92Rw47y3U+g== X-Received: by 2002:a05:6871:5310:b0:2c2:561c:47e3 with SMTP id 586e51a60fabf-2c78032a79amr11647285fac.21.1742964917599; Tue, 25 Mar 2025 21:55:17 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2c77ebc9f40sm2859234fac.3.2025.03.25.21.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 21:55:16 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86o6xpe2cx.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> Date: Tue, 25 Mar 2025 22:55:15 -0600 Message-ID: <87o6xobdcc.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: , 77224@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain I've updated the patch following Juri suggestions. Now all the conditions are inside a single =defcustom=. I've added only basic colors that a basic TTY can support, and a =Package-Requires= tag in case this package should also be included in ELPA. This version now can handle functions as conditions (lambdas and function symbols). --==-=-= Content-Type: text/html

I've updated the patch following Juri suggestions.
Now all the conditions are inside a single defcustom.

I've added only basic colors that a basic TTY can support, and a
Package-Requires tag in case this package should also be included in
ELPA.

This version now can handle functions as conditions (lambdas and function
symbols).

--==-=-=-- --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-New-minor-mode-cursor-indicators-mode.patch Content-Transfer-Encoding: quoted-printable >From 2d89262880a47628cb47d803cedc6f04fd1f70d4 Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sat, 22 Mar 2025 22:56:01 -0600 Subject: [PATCH] New minor mode 'cursor-indicators-mode' This minor mode changes the cursor appearance to indicate buffers states, such as if overwrite-mode is active or current buffer is read-only. (Bug#77224) Acts similar to 'cua-enable-cursor-indications' * etc/NEWS: Document changes. * lisp/cursor-indicators.el (cursor-indicators-conditions): New user option. (cursor-indicators--default-cursor-color): New use internal variable. (cursor-indicators--update-indications) (cursor-indicators--change-cursor): New use internal function. (cursor-indicators-mode): New minor mode definition. --- etc/NEWS | 9 +++ lisp/cursor-indicators.el | 139 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 148 insertions(+) create mode 100644 lisp/cursor-indicators.el diff --git a/etc/NEWS b/etc/NEWS index cc63d03eafe..e87afc8c1b6 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1566,6 +1566,15 @@ This user option replaces 'follow-mode-prefix', whic= h had to be set before loading Follow mode. This new option allows you to change the prefix even after it was loaded, using 'customize-option' or 'setopt'. =20 +--- +*** New minor mode 'cursor-indicators-mode' +This mode changes cursor appearance (color and/or type) to indicate +different buffer states according to 'cursor-indicators-conditions'. +The mode have cursor indicators out the box for: +- Overwrite mode +- Read-only buffers +- Input method activation + --- *** cdl.el is now obsolete. Use 'shell-command' and 'shell-command-on-region' instead. diff --git a/lisp/cursor-indicators.el b/lisp/cursor-indicators.el new file mode 100644 index 00000000000..bbd33e7c634 --- /dev/null +++ b/lisp/cursor-indicators.el @@ -0,0 +1,139 @@ +;;; cursor-indicators.el --- Cursor indicators for some states -*- lexica= l-binding: t; -*- + +;; Copyright (C) 2025 Free Software Foundation, Inc. + +;; Version: 1.0.0 +;; Author: El=C3=ADas Gabriel P=C3=A9rez +;; Package-Requires: ((emacs "26.1")) + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: +;; This package changes cursor appearance (color and/or type) to indicate +;; different buffer states. + +;;; Code: +(require 'map) + +;;; User options + +(defcustom cursor-indicators-conditions + '((overwrite-mode . box) + (buffer-read-only . "green") + (current-input-method . "blue")) + "Alist of conditions to which cursor should change its appearence. +Only used when `cursor-indicators-mode' is enabled. + +Each element is an alist entry in one of these forms: + (CONDITION . COLOR) Change cursor color + (CONDITION . TYPE) Change cursor type + (CONDITION TYPE COLOR) Change cursor color and type + +CONDITION must be a function (without arguments) or a variable that +must return non-nil. +COLOR is a string specifying the cursor color. +TYPE specifies cursor type. + +Colors can be any valid color name or hex RGB value. +Valid cursor types are: + `box' - Filled box + `bar' - Vertical bar + `hbar' - Horizontal bar + `hollow' - Hollow box + +Each element in this alist takes predominance according to its order. + +If none of the conditions return non-nil, the cursor will use default +cursor type and color." + :group 'cursor + :version "31.1" + :type '(alist :key-type + (choice :tag "Condition" + (const :tag "Overwrite mode" overwrite-mode) + (const :tag "Read-only mode" buffer-read-only) + (const :tag "Repeat mode" repeat-in-progress) + (const :tag "Activated input method" current-input= -method) + ;; User-defined conditions + (function :tag "Variable") + (variable :tag "Function")) + :value-type + (choice + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (group :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color"))))) + +;;; Internal Code + +(defvar cursor-indicators--default-cursor-color (frame-parameter nil 'curs= or-color)) + +(defun cursor-indicators--change-cursor (key val) + ;; Check if KEY is non-nil + (when (or (and (symbolp key) (boundp key) (symbol-value key)) + (and (interpreted-function-p key) (funcall key)) + (and (functionp key) (symbolp key) (not (boundp key)) (funcall= key))) + (cond + ;; Set cursor color + ((and (stringp val) (not (equal val (frame-parameter nil 'cursor-colo= r)))) + (set-cursor-color val) + (setq-local cursor-type (default-value 'cursor-type))) ; Set to defa= ult cursor type + ;; Set cursor type + ((and (symbolp val) (not (eq val (default-value 'cursor-type)))) + (setq-local cursor-type val) + (set-cursor-color cursor-indicators--default-cursor-color)) ; Set to= default cursor color + ;; Set cursor color and type + ((consp val) + (let ((type (car val)) + (color (cadr val))) + (when (and (symbolp type) (not (eq type (default-value 'cursor-typ= e))) + (stringp color) (not (equal color (frame-parameter nil = 'cursor-color)))) + (set-cursor-color color) + (setq-local cursor-type type))))) + ;; And exit from loop. + (throw 'c-i-exit t))) + +(defun cursor-indicators--update-indications () + ;; C-I-EXIT is used here for exit from loop. + (when (and cursor-type + (not (catch 'c-i-exit (map-do #'cursor-indicators--change-cur= sor cursor-indicators-conditions)))) + (setq-local cursor-type (default-value 'cursor-type)) + (set-cursor-color cursor-indicators--default-cursor-color))) + +;;;###autoload +(define-minor-mode cursor-indicators-mode + "Change cursor type and/or face for indications. +When enabled, this mode changes the cursor appearance to indicate +different buffer states." + :group 'cursor + :version "31.1" + :global t + (if cursor-indicators-mode + (progn + (add-hook 'post-command-hook #'cursor-indicators--update-indicatio= ns) + (cursor-indicators--update-indications)) + (remove-hook 'post-command-hook #'cursor-indicators--update-indication= s) + (set-cursor-color cursor-indicators--default-cursor-color) + (setq-local cursor-type (default-value 'cursor-type)))) + +(provide 'cursor-indicators) +;;; cursor-indicators.el ends here --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 01:01:08 2025 Received: (at 77224) by debbugs.gnu.org; 26 Mar 2025 05:01:08 +0000 Received: from localhost ([127.0.0.1]:40856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txIt1-00038B-Lh for submit@debbugs.gnu.org; Wed, 26 Mar 2025 01:01:08 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:61857) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txIsy-00037U-En for 77224@debbugs.gnu.org; Wed, 26 Mar 2025 01:01:05 -0400 Received: by mail-oi1-x243.google.com with SMTP id 5614622812f47-3fa6c54cdb2so5528332b6e.3 for <77224@debbugs.gnu.org>; Tue, 25 Mar 2025 22:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742965258; x=1743570058; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dE8ffj+xIXWLB9zedBabIuwfUW5qVJ7n4dM0/e03yIE=; b=ALweFWNpw+31LZmZoEpMewWboQDeDiLRbGGtfzQoZrrJT+CGe2/LTN3rmfbchajANX Eukmw6ywa8yD7yYW0+9wtI3wcsAAE5STcxX9+3jgXTlwXH5HWuzsObJKjVpGOgXcSUjf 89gNG34vb3rrmplQ2MfFIYCkK7WZOsTtl1+DuDOyr3D+Cx2fscFdbhy6YmPearSfuRZT a66mVqFJHjO5OR4VG+Xelx60St5JgsYreT96ZMJPjCuB6E/rrDlj+M0GTcp4gMB9rqhX DfxRCu+yYwd4QN80yVhtnBtpEjmSwhX4U9hwRjx6di5j+wMFFGO/gZeW0JVj7Q946gQE iP+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742965258; x=1743570058; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dE8ffj+xIXWLB9zedBabIuwfUW5qVJ7n4dM0/e03yIE=; b=LIEnRhK6OUOu/B9TObX/EXy3waksrNmChUm8W5GO08fmpSvM71LIZ+DVVhBzUq5f8M 63SsVYZK1RrbYP8RU6mUJZxPaMA3xEHClRhLqgvQuNsM5ce2k7UIQeNzE7qprAYr74a/ 1zJnojOehkLSAIazDmrHK/u++JiejVHtmquHBLgoIpNHdBo8V41vE1UuHngeS4Vr73ik yDeDz7oUsIjsmDoNc9cH1zMu40MngRVZDGAo1nalvLSesqoIyK3m0UZfaBnjosQik5im cA1aQNYmdC0tAVDMrLdC9DWDbac3yOVnxUfjXRNX3OhVimluag0sjoDk5AJMZylU5nu9 CyZw== X-Gm-Message-State: AOJu0YzACJKVCSw6FS3AHriQYFHRCBzH2pjPe348mLWGzUKM2xXWa59g UySpZ350zJG1ww1P3DyGTA10MltMz30OnaCvvbJuEkiqLHbZCPecPN0BPzgY X-Gm-Gg: ASbGnctbYZXxYNfqcYA5O0Rccy0LjMTUjOTroGfrnlErff3yTasCbPBlui2OCIQuEG7 ZvZEwsUyZrAKkm13xwXOaf4pCZmciG+7hKtUR2+sAUGI5tw807YLO/57+NslqplJgHBsq5KpaRy hMh7VSVr3Hltw7iGxhCpN7QJVusMZh3W1mSUl0nMq3UGjHBfmnF8m7t1d1MBmaQ4wUZf/uChefu kfzxKP8IShZm3TyY+N2udtGUeXkiCWIH1nu9OFs1CvNXtd8wpgbsd2J3mWmoLJeT9mptqOOEVeY b+OyQLCnt89C X-Google-Smtp-Source: AGHT+IFOhF4JbDJ1JR8OgYbh0zY831SWgytcxaV3A8VUQb5vW/mhufrVTOoDGayZjfG4AlTFeqTsVw== X-Received: by 2002:a05:6808:14c6:b0:3f9:1fee:8055 with SMTP id 5614622812f47-3febf723a8cmr12388458b6e.15.1742965257895; Tue, 25 Mar 2025 22:00:57 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-60234759a2fsm1740327eaf.21.2025.03.25.22.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 22:00:57 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Rudolf Schlatte Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <871pula7sn.fsf@mail.linkov.net> Date: Tue, 25 Mar 2025 23:00:56 -0600 Message-ID: <87ldssbd2v.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Rudolf Schlatte writes: > Juri Linkov writes: >>> +*** New minor mode 'cursor-indicators-mode' >>> +This mode changes cursor appearance (color and/or type) to indicate >>> +different buffer states. This mode have cursor indicators for: >>> +- Overwrite mode >>> +- Read-only buffers >>> +- Repeat mode >>> +- Input method activation >> What if users want to add more conditions? >> Could you try to create only one defcustom that >> contains a list of default conditions >> plus a possible user-defined conditions. >> For example: >> #+begin_src emacs-lisp >> (defcustom cursor-indicators nil >> :type `(alist :key-type >> (choice :tag "Condition" >> (const :tag "Overwrite mode" overwrite) >> (const :tag "Read-only mode" read-only) >> (const :tag "Repeat mode" repeat-in-progress) >> (const :tag "Activated input method" input-method) >> (function :tag "Matcher function")) ;; User-defined condition >> :value-type >> (choice >> (const :tag "None (do not change cursor)" nil) >> (color :tag "Color") >> (choice :tag "Type" >> (const :tag "Filled box" box) >> (const :tag "Vertical bar" bar) >> (const :tag "Horizontal bar" hbar) >> (const :tag "Hollow box" hollow)) >> (cons :tag "Color and Type" >> (choice :tag "Type" >> (const :tag "Filled box" box) >> (const :tag "Vertical bar" bar) >> (const :tag "Horizontal bar" hbar) >> (const :tag "Hollow box" hollow)) >> (color :tag "Color"))))) >> #+end_src >> Then I could replace: >> #+begin_src emacs-lisp >> (defun my-change-cursor (&rest _) >> "Change cursor color and type depending on insertion mode and input method." >> (set-cursor-color >> (cond (repeat-in-progress "blue") >> (current-input-method "red3") >> (t "black"))) >> (setq-default cursor-type >> (cond (overwrite-mode 'box) >> (t 'bar)))) >> #+end_src >> with just >> #+begin_src emacs-lisp >> (setopt cursor-indicators '((repeat-in-progress "blue") >> (current-input-method "red3") >> (overwrite-mode 'box) >> (default 'bar))) >> #+end_src > I set the following hooks, which makes the cursor unobtrusive while I'm > selecting text (C-SPC then moving cursor). Could this also fit in the > above framework? > (deactivate-mark-hook . (lambda () (setq cursor-type t))) > (activate-mark-hook . (lambda () (setq cursor-type 'bar))) Yeah, you can set it as something like this. #+begin_src elisp (setopt cursor-indicators-conditions '((use-region-p . "purple"))) #+end_src --==-=-= Content-Type: text/html

Rudolf Schlatte <rudi@constantly.at> writes:

Juri Linkov <juri@linkov.net> writes:

+*** New minor mode 'cursor-indicators-mode'
+This mode changes cursor appearance (color and/or type) to indicate
+different buffer states. This mode have cursor indicators for:
+- Overwrite mode
+- Read-only buffers
+- Repeat mode
+- Input method activation

What if users want to add more conditions?
Could you try to create only one defcustom that
contains a list of default conditions
plus a possible user-defined conditions.
For example:

#+beginsrc emacs-lisp
(defcustom cursor-indicators nil
:type `(alist :key-type
(choice :tag "Condition"
(const :tag "Overwrite mode" overwrite)
(const :tag "Read-only mode" read-only)
(const :tag "Repeat mode" repeat-in-progress)
(const :tag "Activated input method" input-method)
(function :tag "Matcher function")) ;; User-defined condition
:value-type
(choice
(const :tag "None (do not change cursor)" nil)
(color :tag "Color")
(choice :tag "Type"
(const :tag "Filled box" box)
(const :tag "Vertical bar" bar)
(const :tag "Horizontal bar" hbar)
(const :tag "Hollow box" hollow))
(cons :tag "Color and Type"
(choice :tag "Type"
(const :tag "Filled box" box)
(const :tag "Vertical bar" bar)
(const :tag "Horizontal bar" hbar)
(const :tag "Hollow box" hollow))
(color :tag "Color")))))
#+endsrc

Then I could replace:

#+beginsrc emacs-lisp
(defun my-change-cursor (&rest _)
"Change cursor color and type depending on insertion mode and input method."
(set-cursor-color
(cond (repeat-in-progress "blue")
(current-input-method "red3")
(t "black")))
(setq-default cursor-type
(cond (overwrite-mode 'box)
(t 'bar))))
#+endsrc

with just

#+beginsrc emacs-lisp
(setopt cursor-indicators '((repeat-in-progress "blue")
(current-input-method "red3")
(overwrite-mode 'box)
(default 'bar)))
#+endsrc

I set the following hooks, which makes the cursor unobtrusive while I'm
selecting text (C-SPC then moving cursor). Could this also fit in the
above framework?

(deactivate-mark-hook . (lambda () (setq cursor-type t)))
(activate-mark-hook . (lambda () (setq cursor-type 'bar)))

Yeah, you can set it as something like this.

(setopt cursor-indicators-conditions '((use-region-p . "⏺purple")))
--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 04:16:23 2025 Received: (at 77224) by debbugs.gnu.org; 26 Mar 2025 08:16:23 +0000 Received: from localhost ([127.0.0.1]:41200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txLvy-0004Ie-PP for submit@debbugs.gnu.org; Wed, 26 Mar 2025 04:16:23 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35069) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txLvs-0004IF-Og for 77224@debbugs.gnu.org; Wed, 26 Mar 2025 04:16:20 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id A016A443E1; Wed, 26 Mar 2025 08:16:08 +0000 (UTC) From: Juri Linkov To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87o6xobdcc.fsf@gmail.com> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> Date: Wed, 26 Mar 2025 09:58:06 +0200 Message-ID: <875xjwyzvt.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduieehtddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepfedprhgtphhtthhopeejjedvvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepvghgieegvdeiudeisehgmhgrihhlrdgtohhm X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I've updated the patch following Juri suggestions. > Now all the conditions are inside a single defcustom. Thanks! I tested that everything works nicely. There is only one small problem for repeat-mode: > + (add-hook 'post-command-hook #'cursor-indicators--update-indications) It would be better to use a large value DEPTH for add-hook to add the hook to the end. The problem is that repeat-mode also uses the same hook 'post-command-hook'. So the cursor indication hook should be called afterwards as the last hook. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 08:50:27 2025 Received: (at 77224) by debbugs.gnu.org; 26 Mar 2025 12:50:27 +0000 Received: from localhost ([127.0.0.1]:41978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txQDD-0004Vi-8x for submit@debbugs.gnu.org; Wed, 26 Mar 2025 08:50:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51862) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txQD9-0004VU-Pf for 77224@debbugs.gnu.org; Wed, 26 Mar 2025 08:50:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txQD4-0002HQ-0j; Wed, 26 Mar 2025 08:50:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0CLpxbDVsbakKuoz6Xcu8YL0g2M7kLTQks86uV5xVjw=; b=Hm+4iVtcZmM9 V8hPBST2XUdoysGC1DF56HDk91DfMJB7dvOVhqfYLWjZbncbq+wCbZGYKI9+xLJ6SdSKp/q3YEDbg RekqtvwSFayWy29SJX2Qd+MpoU3m7/8wfn3dR+SAu4dDCKcLzoJ58ilWqsjL9dcv2CTbDaRcM+NUy MJR0lS4cB7rdkjFTY7rlZxKDoL2Jj2AdVEaKTV/Dp/6kIBZiRMabsBQ5xhfX2JDNf/vx4IO3aRnQB jsXdfDDAlaGaoyxADng7gbb6YPTzcBV++W05roREz1UUt68qCJtLtLDMGVk9713c4WcoR7mPrG3jn jQjMSSfpppC8z/JRjoyG/A==; Date: Wed, 26 Mar 2025 14:50:09 +0200 Message-Id: <8634f0dkhq.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <875xjwyzvt.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 26 Mar 2025 09:58:06 +0200) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , 77224@debbugs.gnu.org > Date: Wed, 26 Mar 2025 09:58:06 +0200 > > > I've updated the patch following Juri suggestions. > > Now all the conditions are inside a single defcustom. > > Thanks! I tested that everything works nicely. > There is only one small problem for repeat-mode: > > > + (add-hook 'post-command-hook #'cursor-indicators--update-indications) > > It would be better to use a large value DEPTH for add-hook > to add the hook to the end. The problem is that repeat-mode > also uses the same hook 'post-command-hook'. So the cursor > indication hook should be called afterwards as the last hook. Would it be better to use an idle timer instead? post-command-hook tends to make Emacs sluggish. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 20:51:03 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 00:51:03 +0000 Received: from localhost ([127.0.0.1]:45085 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txbSX-000417-1J for submit@debbugs.gnu.org; Wed, 26 Mar 2025 20:51:03 -0400 Received: from mail-ot1-x343.google.com ([2607:f8b0:4864:20::343]:45398) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txbSR-0003z3-Uy for 77224@debbugs.gnu.org; Wed, 26 Mar 2025 20:50:58 -0400 Received: by mail-ot1-x343.google.com with SMTP id 46e09a7af769-72bbc03d436so312311a34.3 for <77224@debbugs.gnu.org>; Wed, 26 Mar 2025 17:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743036650; x=1743641450; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EHw0Jv2o5da++rqVMNLI5gn8XdXmoMlN/3lsYbWbw/0=; b=OQgxMDl9Y442f1AwP/IRZxR4m6m/ArfccK9nIc25ZrPYj7ukoszyY9tgwE74WLTJdu GIcGhUNW68b2hCcjerMKsibpw8bx8NVxxqM+awJZ6hxVflEnUGq9Uzulm2DWSHUmHZma H2SOB5XcTft0bDHegiuICe7iOPofaK5bwT3ZHzX0518h3XSChvtGV0Z3m0kRjx2bAsrG pVaz6/symreXzYnL0aAoqQbHGoXPATl9nr6j5x4i2Co2OXeMl0cc9GeFQh0iMQlf1/D7 9vglG0SxIzPRwqdOhCe9laIwALNi4tBcEA4ctYRwyUzKZ7hN/8i3p/r17DNbwaN9QMUj u5hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743036650; x=1743641450; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EHw0Jv2o5da++rqVMNLI5gn8XdXmoMlN/3lsYbWbw/0=; b=ilcDAEUAHhyyoFP1691uBCfJOb8ViKraE1c4KujfqPKM5YSxdXVzq7ZEW6ptmcvREO CDR6aHXRie7SY8ph5Y8QH6tBtTJk7XFpDkpVJbHepiyEgNSbQ2LGW/CTUzJcMf9aKpt1 Zr4yuskPyMuakgTygo+y+l8x8MjEcGoJOjE05VhV1Ju96yACbXMhJBxjwzvPx+ZRo9M+ KkhqgPmf5NAVBVG13vFeIBpcgh8ygyRr+FPTW2zrDYL5FjTiGVBbyI/+M3QBkCXHfqPt emLTIquONrR1T/s5MABoXYDwFLD/MvuaFpt2Zp+gv5rEjFt9ejPthtJI18hrhj62RFzV z4Yg== X-Forwarded-Encrypted: i=1; AJvYcCU/l8LTOT27MB61+2LyM2ssvTiQ6ZSeFIf5eyijR/SIH/kRHJFkeyBsJpRQTeeEwDobvZQ1cQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzT+4Phdap/9dcTgJ4nJ1NUo/ssFRHO8WG1lKhkk4LJ1sQqJZuF t5xMnbN+zbMcTZDoP+iMjlT+dp78936ofVUeiHBFR7Oe9z2byVNjo1LUA7HS X-Gm-Gg: ASbGnculocek8tA4JlYl+Fm6bp02lNqzy+Q06EC1rRVg0yNx5JRkATaUE7nVah6uY4P Z419UtLC8wiNppBAPgRyDZIdDElwhrt3Id+6nSNcpar9gGN/Y2nwB3yjZUXVx2LL808DZtnuMhu 8XgKP25KmkCe9ka9nzyft4tm/PPzxtmJ1S98odiRM/Fht7nW6Qy9JZZT7Dc2HXmW6aBPA22ZIHl eI1MzvQMs+xYIgsrLX2hLZzXRBlXP9Pnlcubupb9f0OeDjNfrrlPUEmScSFklQWPVIo9tFVS1js Kari86sGJO39 X-Google-Smtp-Source: AGHT+IGub5PsrLLmfVF4ho4QfyDrtDNiz/ruUyGMgb/MxDlE92kKBGcI62uSknf0Z+d4jlK5JYX13w== X-Received: by 2002:a05:6830:f93:b0:727:3303:7ea8 with SMTP id 46e09a7af769-72c4ca166f8mr1256333a34.25.1743036649513; Wed, 26 Mar 2025 17:50:49 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c0ac7b8aasm2520187a34.62.2025.03.26.17.50.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 17:50:48 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <8634f0dkhq.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> Date: Wed, 26 Mar 2025 18:50:47 -0600 Message-ID: <875xjvcn4o.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Juri Linkov >> Cc: Eli Zaretskii , 77224@debbugs.gnu.org >> Date: Wed, 26 Mar 2025 09:58:06 +0200 >> > I've updated the patch following Juri suggestions. >> > Now all the conditions are inside a single defcustom. >> Thanks! I tested that everything works nicely. >> There is only one small problem for repeat-mode: >> > + (add-hook 'post-command-hook #'cursor-indicators--update-indications) >> It would be better to use a large value DEPTH for add-hook >> to add the hook to the end. The problem is that repeat-mode >> also uses the same hook 'post-command-hook'. So the cursor >> indication hook should be called afterwards as the last hook. > Would it be better to use an idle timer instead? post-command-hook > tends to make Emacs sluggish. Yeah, that is that what worried me when i decided to use that hook. I've fixed the patch to use only idle-timer instead. --==-=-= Content-Type: text/html

Eli Zaretskii <eliz@gnu.org> writes:

From: Juri Linkov <juri@linkov.net>
Cc: Eli Zaretskii <eliz@gnu.org>, 77224@debbugs.gnu.org
Date: Wed, 26 Mar 2025 09:58:06 +0200

I've updated the patch following Juri suggestions.
Now all the conditions are inside a single defcustom.

Thanks! I tested that everything works nicely.
There is only one small problem for repeat-mode:

+ (add-hook 'post-command-hook #'cursor-indicators–update-indications)

It would be better to use a large value DEPTH for add-hook
to add the hook to the end. The problem is that repeat-mode
also uses the same hook 'post-command-hook'. So the cursor
indication hook should be called afterwards as the last hook.

Would it be better to use an idle timer instead? post-command-hook
tends to make Emacs sluggish.

Yeah, that is that what worried me when i decided to use that hook.

I've fixed the patch to use only idle-timer instead.

--==-=-=-- --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-New-minor-mode-cursor-indicators-mode.patch Content-Transfer-Encoding: quoted-printable >From 03099d0bfe4f2e56444973d9eb1c93ec7896465d Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sat, 22 Mar 2025 22:56:01 -0600 Subject: [PATCH] New minor mode 'cursor-indicators-mode' This minor mode changes the cursor appearance to indicate buffers states, such as if overwrite-mode is active or current buffer is read-only. (Bug#77224) Acts similar to 'cua-enable-cursor-indications' * etc/NEWS: Document changes. * lisp/cursor-indicators.el (cursor-indicators-conditions): New user option. (cursor-indicators--default-cursor-color) (cursor-indicators--idle-timer) (cursor-indicators-idle-time): New use internal variables. (cursor-indicators--update-indications) (cursor-indicators--remove-idle-timer) (cursor-indicators--change-cursor): New use internal functions. (cursor-indicators-mode): New minor mode definition. --- etc/NEWS | 9 +++ lisp/cursor-indicators.el | 153 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 162 insertions(+) create mode 100644 lisp/cursor-indicators.el diff --git a/etc/NEWS b/etc/NEWS index cc63d03eafe..e87afc8c1b6 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1566,6 +1566,15 @@ This user option replaces 'follow-mode-prefix', whic= h had to be set before loading Follow mode. This new option allows you to change the prefix even after it was loaded, using 'customize-option' or 'setopt'. =20 +--- +*** New minor mode 'cursor-indicators-mode' +This mode changes cursor appearance (color and/or type) to indicate +different buffer states according to 'cursor-indicators-conditions'. +The mode have cursor indicators out the box for: +- Overwrite mode +- Read-only buffers +- Input method activation + --- *** cdl.el is now obsolete. Use 'shell-command' and 'shell-command-on-region' instead. diff --git a/lisp/cursor-indicators.el b/lisp/cursor-indicators.el new file mode 100644 index 00000000000..64db160f390 --- /dev/null +++ b/lisp/cursor-indicators.el @@ -0,0 +1,153 @@ +;;; cursor-indicators.el --- Cursor indicators for some states -*- lexica= l-binding: t; -*- + +;; Copyright (C) 2025 Free Software Foundation, Inc. + +;; Version: 1.0.0 +;; Author: El=C3=ADas Gabriel P=C3=A9rez +;; Package-Requires: ((emacs "26.1") (compat "30.0.1.0")) + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: +;; This package changes cursor appearance (color and/or type) to indicate +;; different buffer states. + +;;; Code: +(require 'map) +(require 'compat) + +;;; User options + +(defcustom cursor-indicators-conditions + '((overwrite-mode . "red") + (buffer-read-only . "green") + (current-input-method . "blue")) + "Alist of conditions to which cursor should change its appearence. +Only used when `cursor-indicators-mode' is enabled. + +Each element is an alist entry in one of these forms: + (CONDITION . COLOR) Change cursor color + (CONDITION . TYPE) Change cursor type + (CONDITION TYPE COLOR) Change cursor color and type + +CONDITION must be a function (without arguments) or a variable that +must return non-nil. +COLOR is a string specifying the cursor color. +TYPE specifies cursor type. + +Colors can be any valid color name or hex RGB value. +Valid cursor types are: + `box' - Filled box + `bar' - Vertical bar + `hbar' - Horizontal bar + `hollow' - Hollow box + +Each element in this alist takes predominance according to its order. + +If none of the conditions return non-nil, the cursor will use default +cursor type and color." + :group 'cursor + :version "31.1" + :type '(alist :key-type + (choice :tag "Condition" + (const :tag "Overwrite mode" overwrite-mode) + (const :tag "Read-only mode" buffer-read-only) + (const :tag "Repeat mode" repeat-in-progress) + (const :tag "Activated input method" current-input= -method) + ;; User-defined conditions + (function :tag "Variable") + (variable :tag "Function")) + :value-type + (choice + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (group :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color"))))) + +;;; Internal Code + +(defvar cursor-indicators--default-cursor-color (frame-parameter nil 'curs= or-color)) +(defvar cursor-indicators--idle-timer nil) + +(defun cursor-indicators--change-cursor (key val) + "Helper function to `cursor-indicators--update-indications'." + ;; Check if KEY is non-nil + (when (or (and (symbolp key) (boundp key) (symbol-value key)) + (and (interpreted-function-p key) (funcall key)) + (and (functionp key) (symbolp key) (not (boundp key)) (funcall= key))) + (cond + ;; Set cursor color + ((and (stringp val) (not (equal val (frame-parameter nil 'cursor-colo= r)))) + (set-cursor-color val) + (setq-local cursor-type (default-value 'cursor-type))) ; Set to defa= ult cursor type + ;; Set cursor type + ((and (symbolp val) (not (eq val (default-value 'cursor-type)))) + (setq-local cursor-type val) + (set-cursor-color cursor-indicators--default-cursor-color)) ; Set to= default cursor color + ;; Set cursor color and type + ((consp val) + (let ((type (car val)) + (color (cadr val))) + (when (and (symbolp type) (not (eq type (default-value 'cursor-typ= e))) + (stringp color) (not (equal color (frame-parameter nil = 'cursor-color)))) + (set-cursor-color color) + (setq-local cursor-type type))))) + ;; And exit from loop. + (throw 'c-i-exit t))) + +(defun cursor-indicators--update-indications () + ;; C-I-EXIT is used here for exit from loop. + (when (and cursor-type + (not (catch 'c-i-exit (map-do #'cursor-indicators--change-cur= sor cursor-indicators-conditions)))) + (setq-local cursor-type (default-value 'cursor-type)) + (set-cursor-color cursor-indicators--default-cursor-color))) + +(defun cursor-indicators--remove-idle-timer () + "Stop and Remove idle time set." + (when cursor-indicators--idle-timer + (cancel-timer cursor-indicators--idle-timer) + (setq cursor-indicators--idle-timer nil))) + +(defvar cursor-indicators-idle-time 0.1 + "Time used for set an idle-timer.") + +;;;###autoload +(define-minor-mode cursor-indicators-mode + "Change cursor type and/or face for indications. +When enabled, this mode changes the cursor appearance to indicate +different buffer states." + :group 'cursor + :version "31.1" + :global t + (if cursor-indicators-mode + (progn + (cursor-indicators--remove-idle-timer) + (setq cursor-indicators--idle-timer + (run-with-idle-timer cursor-indicators-idle-time t + #'cursor-indicators--update-indications= ))) + (cursor-indicators--remove-idle-timer) + (set-cursor-color cursor-indicators--default-cursor-color) + (setq-local cursor-type (default-value 'cursor-type)))) + +(provide 'cursor-indicators) +;;; cursor-indicators.el ends here --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 26 22:52:29 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 02:52:29 +0000 Received: from localhost ([127.0.0.1]:45668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txdM3-0005VF-LF for submit@debbugs.gnu.org; Wed, 26 Mar 2025 22:52:29 -0400 Received: from mail-oo1-xc41.google.com ([2607:f8b0:4864:20::c41]:53714) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txdM0-0005Ti-0e for 77224@debbugs.gnu.org; Wed, 26 Mar 2025 22:52:25 -0400 Received: by mail-oo1-xc41.google.com with SMTP id 006d021491bc7-601b1132110so332449eaf.3 for <77224@debbugs.gnu.org>; Wed, 26 Mar 2025 19:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743043938; x=1743648738; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=2bHIyP0JWXA/qlab1DPj+VlansYYd2gz7avX0f/NNVI=; b=blrr7cOHEjonOwwsKA2nrlm7UMLwy93Yr98Bd4konIYlE1Tp7O5fSkvbTFRk/3voEA tLWdKEc3sBsU0x2qyl6mA2RL8r/cbihSQ7SNvqmWd3WbuylX7BNEFty8gJm05eZumLCB tBxJzFvGMDL+i1yN36QfJTQAy+L8WnZFIajfkbSD9WZfUlMw18k/BF02k+i1Dm+jrXlj QAirIA7WmieRpboZECgG8cpTtM/XcpmP3Q5qpyRZZHh/t9SWk9u6r/UZcyc2NPWiqaTb 3qUvtoLtKKxIiGhTDk51T9nIm5k9sBzd3QTX9nyLICv4c4YdUVv73L7hP9vbC0qNuWxo kbdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743043938; x=1743648738; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2bHIyP0JWXA/qlab1DPj+VlansYYd2gz7avX0f/NNVI=; b=wsxcY0hB3BgcT6G+SyVFgyWkoFW8kkf/MMxubJp7DkiBku0+pfKBLN5kGFeSS43IPe 1URajHADVMmTE0kD/0BxzkeVmiCeVz9qK6jurlt4n7lamJqSf/yrS73Vxg0+xxZzXdCx Jat9X8IKA+bP/qO4M0wZbfXhQzt3LHgROxg4oYnq8o6VO7TAoUwZT/yvJhLWcA4B+ziK dNS9gS2pXW6W8fYJIRXQCEOiIhrP0Aa0rPOoKhkj9k+30366LYqribIkmrDisNQ0qrFN yu5PTMHWvyfOrTHn9zFY8JZNJdNFg2p+yJb0DReKtuWHTkOOPE7TkMY3PObxaIeT2V6e 6ToA== X-Gm-Message-State: AOJu0YyAmv0jFgyNVIqh56spz4wSH1qwucy88hiEMDUJGglvljnBozAg P2MxdRS4nGooJ7f6TyIHwfZwLxs3JQw5GgkBj8hhagZJLxKLR61K X-Gm-Gg: ASbGncvPbahMQXG/6ajkoCeidMM9zgRvYi4aNdASqoFp0qvjMnewKtEvtFDz4hljGbx 8dBGzo1zj00s+hHciGvjp4fgNQXZUg756ZGMzkfOabFYRi7MUx2Dg3aUkha4iZ4Drn4J/TUsHyr 4++RPY3NMudXs2RAkDdA8or/exsHdi6X1GH4Iki9aPyVzV9QjSztgUZaFRCWwmARImXtJHYcoWC q0y7xNPCBSxITLbbBLCLjC6gkbWXFcFR+265WmYzJ1vSqTm35Ci0KKIihX98mHqjisIdqvTcK2e aHlYhX+0lUMF X-Google-Smtp-Source: AGHT+IHv3S2wFWT7AVmFYLHCx8BBlqJx34NQFdZAMQCZWMitqYH7jTq1XQu/4VC//dwquB09UlbJmw== X-Received: by 2002:a05:6870:d113:b0:29d:c764:f873 with SMTP id 586e51a60fabf-2c84819d07emr1147638fac.31.1743043937676; Wed, 26 Mar 2025 19:52:17 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2c77f05ec85sm3413184fac.32.2025.03.26.19.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 19:52:16 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <875xjvcn4o.fsf@gmail.com> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> Date: Wed, 26 Mar 2025 20:52:15 -0600 Message-ID: <87r02jb2xs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain I forgot to update commit message properly. Sending fixed patch. --==-=-= Content-Type: text/html

I forgot to update commit message properly.
Sending fixed patch.

--==-=-=-- --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-New-package-cursor-indicators-mode-Bug-77224.patch Content-Transfer-Encoding: quoted-printable >From 09400072236d8297b2cf8af644bfeeaa8c63593e Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sat, 22 Mar 2025 22:56:01 -0600 Subject: [PATCH] New package 'cursor-indicators-mode' (Bug#77224) This minor mode changes the cursor appearance to indicate buffers states, such as if overwrite-mode is active or current buffer is read-only. Acts similar to 'cua-enable-cursor-indications' * etc/NEWS: Document new package. * lisp/cursor-indicators.el: New file. --- etc/NEWS | 10 +++ lisp/cursor-indicators.el | 167 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 177 insertions(+) create mode 100644 lisp/cursor-indicators.el diff --git a/etc/NEWS b/etc/NEWS index cc63d03eafe..2745d467722 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1566,6 +1566,16 @@ This user option replaces 'follow-mode-prefix', whic= h had to be set before loading Follow mode. This new option allows you to change the prefix even after it was loaded, using 'customize-option' or 'setopt'. =20 +--- +*** New package 'cursor-indicators-mode' +This provides a new minor mode, 'cursor-indicators-mode'. +This mode changes cursor appearance (color and/or type) to indicate +different buffer states according to 'cursor-indicators-conditions'. +The mode have cursor indicators out the box for: +- Overwrite mode +- Read-only buffers +- Input method activation + --- *** cdl.el is now obsolete. Use 'shell-command' and 'shell-command-on-region' instead. diff --git a/lisp/cursor-indicators.el b/lisp/cursor-indicators.el new file mode 100644 index 00000000000..c9122ae864b --- /dev/null +++ b/lisp/cursor-indicators.el @@ -0,0 +1,167 @@ +;;; cursor-indicators.el --- Cursor indicators for some states -*- lexica= l-binding: t; -*- + +;; Copyright (C) 2025 Free Software Foundation, Inc. + +;; Version: 1.0.0 +;; Author: El=C3=ADas Gabriel P=C3=A9rez +;; Package-Requires: ((emacs "26.1") (compat "30")) + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: +;; This package allows changes cursor appearance (color and/or type) to +;; indicate different buffer states such as if current buffer is +;; read-only or if overwrite mode is currently active. +;; +;; Usage: +;; For use this mode enable: cursor-indicators-mode. +;; By default it will set cursor color if overwrite mode is currently +;; active, if buffer is read-only or if input method is active. +;; +;; To change this behavior customize `cursor-indicators-conditions'. +;; For example, change cursor type to bar when there is a region active: +;; (setopt cursor-indicators-conditions '((use-region-p . bar))) +;; Or change both cursor color and type when current buffer have a +;; specific name: +;; (setopt cursor-indicators-conditions `((,(lambda () (string-prefix-p " = *" (buffer-name))) +;; hollow "yellow"))) + +;;; Code: +(require 'map) +(require 'compat) + +;;; User options + +(defcustom cursor-indicators-conditions + '((overwrite-mode . "red") + (buffer-read-only . "green") + (current-input-method . "blue")) + "Alist of conditions to which cursor should change its appearence. +Only used when `cursor-indicators-mode' is enabled. + +Each element is an alist entry in one of these forms: + (CONDITION . COLOR) Change cursor color + (CONDITION . TYPE) Change cursor type + (CONDITION TYPE COLOR) Change cursor color and type + +CONDITION must be a function (without arguments) or a variable that +must return non-nil. If variable shares name with a function, +the variable will be used instead. +COLOR is a string specifying the cursor color. +TYPE specifies cursor type. + +Valid cursor types are: + `box' - Filled box + `bar' - Vertical bar + `hbar' - Horizontal bar + `hollow' - Hollow box + +Each element in this alist takes predominance according to its order. + +If none of the conditions return non-nil, the cursor will use default +cursor type and color." + :group 'cursor + :version "31.1" + :type '(alist :key-type + (choice :tag "Condition" + (const :tag "Overwrite mode" overwrite-mode) + (const :tag "Read-only mode" buffer-read-only) + (const :tag "Repeat mode" repeat-in-progress) + (const :tag "Activated input method" current-input= -method) + ;; User-defined conditions + (function :tag "Variable") + (variable :tag "Function")) + :value-type + (choice + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (group :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color"))))) + +;;; Internal Code + +(defvar cursor-indicators--default-cursor-color (frame-parameter nil 'curs= or-color)) +(defvar cursor-indicators--idle-timer nil) + +(defun cursor-indicators--change-cursor (key val) + "Helper function to `cursor-indicators--update-indications'." + ;; Check if KEY is non-nil + (when (or (and (symbolp key) (boundp key) (symbol-value key)) + (and (interpreted-function-p key) (funcall key)) + (and (functionp key) (symbolp key) (not (boundp key)) (funcall= key))) + (cond + ;; Set cursor color + ((and (stringp val) (not (equal val (frame-parameter nil 'cursor-colo= r)))) + (set-cursor-color val) + (setq-local cursor-type (default-value 'cursor-type))) ; Set to defa= ult cursor type + ;; Set cursor type + ((and (symbolp val) (not (eq val (default-value 'cursor-type)))) + (setq-local cursor-type val) + (set-cursor-color cursor-indicators--default-cursor-color)) ; Set to= default cursor color + ;; Set cursor color and type + ((consp val) + (let ((type (car val)) + (color (cadr val))) + (when (and (symbolp type) (not (eq type (default-value 'cursor-typ= e))) + (stringp color) (not (equal color (frame-parameter nil = 'cursor-color)))) + (set-cursor-color color) + (setq-local cursor-type type))))) + ;; And exit from loop. + (throw 'c-i-exit t))) + +(defun cursor-indicators--update-indications () + ;; C-I-EXIT is used here for exit from loop. + (when (and cursor-type + (not (catch 'c-i-exit (map-do #'cursor-indicators--change-cur= sor cursor-indicators-conditions)))) + (setq-local cursor-type (default-value 'cursor-type)) + (set-cursor-color cursor-indicators--default-cursor-color))) + +(defun cursor-indicators--remove-idle-timer () + "Stop and Remove idle time set." + (when cursor-indicators--idle-timer + (cancel-timer cursor-indicators--idle-timer) + (setq cursor-indicators--idle-timer nil))) + +(defvar cursor-indicators-idle-time 0.1 + "Time used for set an idle-timer.") + +;;;###autoload +(define-minor-mode cursor-indicators-mode + "Change cursor type and/or face for indications. +When enabled, this mode changes the cursor appearance to indicate +different buffer states." + :group 'cursor + :version "31.1" + :global t + (if cursor-indicators-mode + (progn + (cursor-indicators--remove-idle-timer) + (setq cursor-indicators--idle-timer + (run-with-idle-timer cursor-indicators-idle-time t + #'cursor-indicators--update-indications= ))) + (cursor-indicators--remove-idle-timer) + (set-cursor-color cursor-indicators--default-cursor-color) + (setq-local cursor-type (default-value 'cursor-type)))) + +(provide 'cursor-indicators) +;;; cursor-indicators.el ends here --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 01:48:27 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 05:48:28 +0000 Received: from localhost ([127.0.0.1]:46749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txg6M-0006kf-6R for submit@debbugs.gnu.org; Thu, 27 Mar 2025 01:48:27 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:55919 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txg6J-0006jO-Ew for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 01:48:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AWiZdf+esAl3vmTRbB6BYnk6udggjyh6gtZXwNdUBSU=; b=pzFPZ2L7karvvmwr8IzO5qx/m7 LGh9bSaZ3UKNDE0cofkn580Uu+ROyNkQGzpjZ8dofwV34I6aiF+vvZFjca5rEF5O5FXZW/HVNfNRr W52MKNAs5u4EtCRS0855iFb/nNQslnD2jfU0PZHvjkSOxfHbKfRVz1+4sYqofX0gO+nE=; From: Daniel Mendler To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <875xjvcn4o.fsf@gmail.com> ("Elijah Gabe =?utf-8?Q?P=C3=A9rez?= =?utf-8?Q?=22's?= message of "Wed, 26 Mar 2025 18:50:47 -0600") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> Date: Thu, 27 Mar 2025 06:48:15 +0100 Message-ID: <877c4b81nk.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Eli Zaretskii , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Elijah Gabe P=C3=A9rez writes: > Eli Zaretskii writes: > >>> From: Juri Linkov >>> Cc: Eli Zaretskii , 77224@debbugs.gnu.org >>> Date: Wed, 26 Mar 2025 09:58:06 +0200 > >>> > I've updated the patch following Juri suggestions. >>> > Now all the conditions are inside a single defcustom. > >>> Thanks! I tested that everything works nicely. >>> There is only one small problem for repeat-mode: > >>> > + (add-hook 'post-command-hook #'cursor-indicators--update-ind= ications) > >>> It would be better to use a large value DEPTH for add-hook >>> to add the hook to the end. The problem is that repeat-mode >>> also uses the same hook 'post-command-hook'. So the cursor >>> indication hook should be called afterwards as the last hook. > >> Would it be better to use an idle timer instead? post-command-hook >> tends to make Emacs sluggish. > > Yeah, that is that what worried me when i decided to use that hook. > > I've fixed the patch to use only idle-timer instead. The problem with the idle timer is that it might not run immediately. However when the user changes the input method, overwrite mode or similar, the users expects that the cursor reflects the change immediately after the last key press and does not lag behind. Therefore I think there is no alternative to the `post-command-hook'. It seems to me that only a bunch of mode variables are checked and then `cursor-type' is set. In CUA the cursor indicator is also updated in the `post-command-hook'. So this should not be too costly? Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 04:38:17 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 08:38:17 +0000 Received: from localhost ([127.0.0.1]:47352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txiki-0000vZ-Ef for submit@debbugs.gnu.org; Thu, 27 Mar 2025 04:38:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50958) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txike-0000uI-Ky for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 04:38:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txikX-000265-Sc; Thu, 27 Mar 2025 04:38:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5beOnUPrzxOJny3vZrylTsXbRXsKu5oR0Z1q9CA1duA=; b=I0kio0m2kP21jszBdOnY jGJVHjYtr3u/aT+XM04QGHvXj5eqEzjotICnXFq8kMEJVC6DSI4zT6nhsl74fkl3Y6qJKRivGMz62 Zf2tH77YcFK1vCB34SlXyVevm4ln5Fv7GBm1aliXhOpQVu1fWdoA6fJwxtuN6CCfuBPvIhCP5iRBk RJ1MBr/AhZCY8lHaDhQEtgj6bRheZbicObda5dUie5TXN33gFxRkSRQbpzhn8nlW8H0vxRQYiwGLM IDkdhoqsR0AzOIw69dBVETVKtBq/hmEYJePUz0uJuMN220roZMdmSQQT4Z0FQNVzgPFdhqdJX4Iwc HOm4MlkS3oJdsQ==; Date: Thu, 27 Mar 2025 10:38:02 +0200 Message-Id: <86ecyidg2d.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <877c4b81nk.fsf@daniel-mendler.de> (message from Daniel Mendler on Thu, 27 Mar 2025 06:48:15 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: Eli Zaretskii , 77224@debbugs.gnu.org, Juri Linkov > > Date: Thu, 27 Mar 2025 06:48:15 +0100 > > Elijah Gabe Pérez writes: > > >> Would it be better to use an idle timer instead? post-command-hook > >> tends to make Emacs sluggish. > > > > Yeah, that is that what worried me when i decided to use that hook. > > > > I've fixed the patch to use only idle-timer instead. > > The problem with the idle timer is that it might not run immediately. That depends on the value of the SECS argument to run-with-idle-timer, doesn't it. > However when the user changes the input method, overwrite mode or > similar, the users expects that the cursor reflects the change > immediately after the last key press and does not lag behind. Therefore > I think there is no alternative to the `post-command-hook'. It seems to > me that only a bunch of mode variables are checked and then > `cursor-type' is set. In CUA the cursor indicator is also updated in the > `post-command-hook'. So this should not be too costly? Sorry, I object to adding stuff to post-command-hook in these cases. Emacs becomes very sluggish, and we should avoid that as much as we can. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 05:42:32 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 09:42:32 +0000 Received: from localhost ([127.0.0.1]:47581 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txjku-0005mS-0V for submit@debbugs.gnu.org; Thu, 27 Mar 2025 05:42:32 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:39307 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txjks-0005lE-6i for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 05:42:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3b2vce8KPq8hoMoKIGGRdnMviQtP3LYVEmCHxjTdf94=; b=iWa1PC1LHV9z8OMF2skU6yQHf4 rBXUHj8KHcy9+WXu/zsdZtINT3/4gfWHw3yekfcrME3piAXPxKpspWMfdEmouoNt0X3YsPBerTwAo Tep/qbxheVWAZb3cLnJoWtdUzIDSsnvW8MiuKv2riwi4sEjvFJSBa+tQTwa+4g6YQ9Ds=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86ecyidg2d.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Mar 2025 10:38:02 +0200") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> Date: Thu, 27 Mar 2025 10:42:21 +0100 Message-ID: <87h63ekdxe.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: Eli Zaretskii , 77224@debbugs.gnu.org, Juri Linkov >> >> Date: Thu, 27 Mar 2025 06:48:15 +0100 >>=20 >> Elijah Gabe P=C3=A9rez writes: >>=20 >> >> Would it be better to use an idle timer instead? post-command-hook >> >> tends to make Emacs sluggish. >> > >> > Yeah, that is that what worried me when i decided to use that hook. >> > >> > I've fixed the patch to use only idle-timer instead. >>=20 >> The problem with the idle timer is that it might not run immediately. > > That depends on the value of the SECS argument to run-with-idle-timer, > doesn't it. No, there is no guarantee that the idle timer will run soon enough after the given time if Emacs stays busy. >> However when the user changes the input method, overwrite mode or >> similar, the users expects that the cursor reflects the change >> immediately after the last key press and does not lag behind. Therefore >> I think there is no alternative to the `post-command-hook'. It seems to >> me that only a bunch of mode variables are checked and then >> `cursor-type' is set. In CUA the cursor indicator is also updated in the >> `post-command-hook'. So this should not be too costly? > > Sorry, I object to adding stuff to post-command-hook in these cases. > Emacs becomes very sluggish, and we should avoid that as much as we > can. I see your point about sluggishness and I am very careful myself to not enable modes which add expensive computations to the `post-command-hook'. Nevertheless in this case using the `post-command-hook' is the right thing, such that the `cursor-type' is changed effective immediately, as had been done before in CUA, see `cua--post-command-handler-1'. The computation in this case is not expensive. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 07:14:58 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 11:14:58 +0000 Received: from localhost ([127.0.0.1]:47782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txlCL-0003qc-Uv for submit@debbugs.gnu.org; Thu, 27 Mar 2025 07:14:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34434) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txlCI-0003pN-M5 for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 07:14:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txlCB-0004Yy-VC; Thu, 27 Mar 2025 07:14:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=b5bJ1yCqygWpnDQ8Zy0f85l7OqNBSAimReiII1hpNzQ=; b=n1vb2FX9v0Ea 96gDao7wgDPkS7z8HH+vm0fqQbW1fks+vhYvh6GGGLu6CbRdAj8kFBUTjvyIbwG7LzkYSbozolI9z i3mG7yG38npDkJJtgf3BGgs1qJr/kl7bpMRzm0TyupARFG8LBOh4h8uE5sLcFqJDCX2wtJetSrluF VjC9YTcgfZoJjcKQVPvn0VhTgGA6IzA1DzgZDd6CY3KGLv9EYHokG91zW77X8ElLLeiM6RJOhadRg opm2rQPjuL+vM3WLzvNW/ADcH74/1P4DCP8oHp2+EjlPjyEY6tNGlN1mLJMUnyWNJhPykw4KNeFqk rnt9PAejwXeAxVcFdQMppw==; Date: Thu, 27 Mar 2025 13:14:45 +0200 Message-Id: <86cye2d8t6.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87h63ekdxe.fsf@daniel-mendler.de> (message from Daniel Mendler on Thu, 27 Mar 2025 10:42:21 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Thu, 27 Mar 2025 10:42:21 +0100 > > Eli Zaretskii writes: > > >> The problem with the idle timer is that it might not run immediately. > > > > That depends on the value of the SECS argument to run-with-idle-timer, > > doesn't it. > > No, there is no guarantee that the idle timer will run soon enough after > the given time if Emacs stays busy. If Emacs is busy, the post-command-hook will not run, either. When a command exits, it return to the main loop, and unless the user types something before that, Emacs then becomes "idle". > > Sorry, I object to adding stuff to post-command-hook in these cases. > > Emacs becomes very sluggish, and we should avoid that as much as we > > can. > > I see your point about sluggishness and I am very careful myself to not > enable modes which add expensive computations to the > `post-command-hook'. Nevertheless in this case using the > `post-command-hook' is the right thing, such that the `cursor-type' is > changed effective immediately, as had been done before in CUA, see > `cua--post-command-handler-1'. The computation in this case is not > expensive. I disagree that the cursor must change "immediately", in the rigorous sense of that word. I think if it changes after 10 or 20 or 50 milliseconds, that's "immediately" for any practical purpose. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 07:41:26 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 11:41:26 +0000 Received: from localhost ([127.0.0.1]:47861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txlby-00033H-0P for submit@debbugs.gnu.org; Thu, 27 Mar 2025 07:41:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51708) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txlbs-00032N-K4 for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 07:41:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txlbl-0000M2-Uo; Thu, 27 Mar 2025 07:41:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=s61E38v8kGhUvYGkbehDbKjxf4DWECI333URkFAAPvI=; b=p1Vp4Cy34woy K+VWr4eg+t2isml6RlLvsVHGzdcWBGkxRSdVG7xp5ksmzg6gDYG/7sTxCvgyFg5ElvEhd/G0XzUY7 mbgCrffgC5aQXerNF8iEoD+lql2W4oJDO7tZs8ba8Ob3WVYHglDjX5q0aWOyX/J/LRYkyrNOKhDdq 3/DFAaFc7zuO5D2onR0gdqg5jmQQq1yTaFtw7Sdpx79WjLwPgV7oZ/j8vMmqKJzk/xwPyhWcVTuw1 0C3iKl9rtBob6svgaCUW5hn8YkYnPqeV+10HL2AbujjxRCEp07/VBXzKiUJaIJ0FByHZn8Nb1nLGl ILtnUC+R4YtBCRSWAAzh8g==; Date: Thu, 27 Mar 2025 13:41:10 +0200 Message-Id: <86a596d7l5.fsf@gnu.org> From: Eli Zaretskii To: mail@daniel-mendler.de In-Reply-To: <86cye2d8t6.fsf@gnu.org> (message from Eli Zaretskii on Thu, 27 Mar 2025 13:14:45 +0200) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net > Date: Thu, 27 Mar 2025 13:14:45 +0200 > From: Eli Zaretskii > > > I see your point about sluggishness and I am very careful myself to not > > enable modes which add expensive computations to the > > `post-command-hook'. Nevertheless in this case using the > > `post-command-hook' is the right thing, such that the `cursor-type' is > > changed effective immediately, as had been done before in CUA, see > > `cua--post-command-handler-1'. The computation in this case is not > > expensive. > > I disagree that the cursor must change "immediately", in the rigorous > sense of that word. I think if it changes after 10 or 20 or 50 > milliseconds, that's "immediately" for any practical purpose. Btw, a possibly even better way is to modify the cursor looks from the hooks of the relevant commands, like overwrite-mode. If some of them don't have a hook, we could add a hook. This is better because it doesn't unnecessarily "punish" Emacs anywhere else, only the commands that could affect the cursor. Does this make sense? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 10:53:51 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 14:53:51 +0000 Received: from localhost ([127.0.0.1]:50781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txoc8-0003tZ-T4 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 10:53:50 -0400 Received: from mail-qv1-xf41.google.com ([2607:f8b0:4864:20::f41]:61498) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txoc4-0003sE-3t for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 10:53:47 -0400 Received: by mail-qv1-xf41.google.com with SMTP id 6a1803df08f44-6e41e17645dso9781306d6.2 for <77224@debbugs.gnu.org>; Thu, 27 Mar 2025 07:53:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743087218; x=1743692018; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=wxY5BoFvWy+7xUdZC7oSpueOhpYjhebcTTrMgihzESQ=; b=BWbduz18b4NG4ljXcnG6mk2S3ZTkZpxLpUSvQziUa77zP5FKYzPuiN/Ij5cg7CHJxt 1II9e2ynxy5NZG+QtNtppjAAvCZydDOYmthmx+5dR9LOsJMgk6xY9qu7plNsq/NITwVH gZqiN1gk+jM8+2nj+7xkuTG2IMQh6O9ajFnTpM9u1roxgUOuZg9nRfumBP32/u6JUuxo cjv2QLn5+cvfXwS4q23Oo4+x5poI2yEKdXl0qRyIwipM/sD4TQxY4yhvLcGN5OwhKkSs IjMB8wWKuK/x/vaxL5vmDaFwUS+MbWRLc4hkMUECN0lwvZEUdYC5pAm90w7nFpZM44d8 4MFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743087218; x=1743692018; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wxY5BoFvWy+7xUdZC7oSpueOhpYjhebcTTrMgihzESQ=; b=xF57rU8S7Ey5FwwaEk4EBXsvmN+YzuLMTWYdaRtD9iRLxRDj9OXPgSKI/Kv3sb8fPi CPU0eMGcerXRbAAw1iRguzfTkaW6qONAVIB8FrouAUmd/p0uskqDj+kDPu8mo5FkDx3n AqXwpjTaYg2n3VHGyne2j6YS1YDrFE4s016Ny/g+j8cw6QrMDTB+ONMeirIvyBnW649e 81M88cN1kam6RbFIu/wcIeEKCazMRXaGtkvuEKOUe9ej9l2aEn1qBePrWB4+fX48oO66 9CydAdO4ZPUC3Z6c9xmhCUrgwPm5oVlXqfIiEJG7qieXuREyPQI3Xnuh+UQoPyos3Z94 npag== X-Forwarded-Encrypted: i=1; AJvYcCWfhiCe9eCpAlNjZR9jkv4xZn3fLkz+yp01XfHeKHqg99b+cxtToFXz1x3rSRZDt4p4H3vssQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yw16Y5hVW59ismzXAgDT5SDSOt0vZ+BOtwLBTeJHOk8UsOeTHog Lw4N/k/y5m0QAuvG4uMEgsf1+OzkRMpA3EeIuoRtfHY3NeXhGfl7AKe4Pak4vq0NiNKVZnsOvrd B92ut9sqL2B5tNyC7OXFaD/BKe0METSJD X-Gm-Gg: ASbGncsurjLP9Q/GlB/XZVbYc6dgaJtJanIqNUlrvXryKcgfi+DC9Qw3s3PYUhhLvrA 8gZUN4G4gGGxyGNhc6idR9jacUWKQP2lqtdSBlrx2ZetEsz9P/93UBT3UONjKVjqaW5EBPc3itT fqM5pOtNX+nJaA+o/1GEYPqlgaUmDQocDJXiqS6pJdxUKsVIyZz5T1p0Y7 X-Google-Smtp-Source: AGHT+IH444NnQ1kevV6AHxSNe8D1hiLOHrQf25LJwCSNWUt+L1nAF6MlhxKnZkQTlcWD/068bzR44ppMzy0Pr6samLg= X-Received: by 2002:a05:6214:5194:b0:6ea:d393:962c with SMTP id 6a1803df08f44-6ed2390f966mr39958806d6.30.1743087218338; Thu, 27 Mar 2025 07:53:38 -0700 (PDT) MIME-Version: 1.0 References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <86a596d7l5.fsf@gnu.org> In-Reply-To: <86a596d7l5.fsf@gnu.org> From: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= Date: Thu, 27 Mar 2025 08:53:25 -0600 X-Gm-Features: AQ5f1JqqOGY0xQQ3wsEG8i-NFC8zquDwG8vIdKiyIhs8dwWTgSwUzZmNtqabvNE Message-ID: Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000007634490631541e34" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, Juri Linkov , 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000007634490631541e34 Content-Type: text/plain; charset="UTF-8" Eli Zaretskii writes: > Btw, a possibly even better way is to modify the cursor looks from the > hooks of the relevant commands, like overwrite-mode. If some of them > don't have a hook, we could add a hook. This is better because it > doesn't unnecessarily "punish" Emacs anywhere else, only the commands > that could affect the cursor. > But what if user prefer using a lambda instead a function? For example for a specific mode or action from a key binding package such as evil or meow, also i don't know if buffer-read-only have a proper hook. > --0000000000007634490631541e34 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli Zaretskii <eliz@gnu.org> writes:
Btw, a possibly even better way is to modify the cursor looks from the
hooks of the relevant commands, like overwrite-mode.=C2=A0 If some of them<= br> don't have a hook, we could add a hook.=C2=A0 This is better because it=
doesn't unnecessarily "punish" Emacs anywhere else, only the = commands
that could affect the cursor.

But what if user prefer using a lambda instead= a function? For example for a specific mode or action from a key binding p= ackage such as evil or meow, also i don't know if buffer-read-only have= a proper hook.
--0000000000007634490631541e34-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 11:45:56 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 15:45:57 +0000 Received: from localhost ([127.0.0.1]:50953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txpQZ-0004dl-J5 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 11:45:56 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:25384) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txpQW-0004d2-Ir for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 11:45:54 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52RFfrU0022236; Thu, 27 Mar 2025 15:45:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=SPNhtk/4c2ztjTquh+9OI4zVfA0msckLaGRz+r7m1Cg=; b= Zt+zFUleSu0zXx1/NaApPnSlCZpZ9QAu3Nc1B4QSHNrJDSgw7ONFYYliu7ntflh2 NvkEL/flTtzzmo9HIy7qJyBQpZj2mYOPPMyjXT/Zpvxvc+hDVvxZsLzyltu9QQ76 i9zh+A5a05KbguQcaFWGePfcipeRgWm5C27vQ4WnC+lkdyVvrpIyzFf1ahADDprj HCdJ+PmhFIJUX+K9ZYVDnAB6W9t14ajsOoj4zNbD3pixgYNniU3TkCYIddPV90xZ TMgc9sYS6/mkqebNBndORB1A3CqqXrc9HpKGuzF47IyAGRu+bhuD0SzRPpGWeL59 Uz/x2x05Y65bFusignx9DA== Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 45hnd6cuck-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Mar 2025 15:45:48 +0000 (GMT) Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 52RFVQo3028708; Thu, 27 Mar 2025 15:45:47 GMT Received: from nam02-sn1-obe.outbound.protection.outlook.com (mail-sn1nam02lp2046.outbound.protection.outlook.com [104.47.57.46]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 45jj6vhvrb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Mar 2025 15:45:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WJI2HhSk+ew8DF3UVlbK2iptbP2CwWkHtPon780BEbYGjQf2S5wd1fE71qt0UdvX+kaO8EVTHOfBGEf9FzIuL53jTZ526ARoZI2SYkWCJxuUpfeCWb4381xbz7E6yZ/ul+hxA772kvkJ8NdUcB5w1EwfCmBTrfYTM4lo01EM8du7auuSj/qiu69eTdf+Bv2yWqdm/kldCpCTRYmRoeBdsdfm1MoAaFhVDTO71oeCpVAsnG64awcS2R0jJ1q5nJMl0EPdtCO6ASvqqArsLq37+WSRKI/Svp1Z3gDNuxC3Z1ZZ1rzrpvLK4iXIYzsc6zx9ttC+6VndmFrvaAHKSfW4VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SPNhtk/4c2ztjTquh+9OI4zVfA0msckLaGRz+r7m1Cg=; b=OQLUQrzf5CN1oGI+qYf7qISuHrrSRLOcueuIV2aO9g0a72FMWFOL2HZbfyo5m1AVSp/I20rEjIsrsQDxEIbpV5GJVEF8zluHEdns+4WgD6IingEWyt8k5yalksKbE3XsiL61D4T3oVZOsoLjk+Lhbh0Gqh83FT55qnLNpefwlPQylGu++RCZev34dvOPoiNgbjl3Nw/pzPckxEytIuhd+zzAvXZ7079etsnatga5kGeDVMoxs66umsghAs1sRRHPqXpPxM8RFxH0ateMCwV06AuztAlVNxXV0yYTX1/g/3R6jK/V2oPvVa+qkLNjY7FPD001Y7Rdv7gstR4EUTDRkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SPNhtk/4c2ztjTquh+9OI4zVfA0msckLaGRz+r7m1Cg=; b=KAWzyjINm2VYA0W9m4u+wBiF8Bu+pb23nuchBAlKByMNl4E1A7wudiT5BDb2ZAopBaW887W3lXc9RPpuYaVN9s3YcVQPvV7YWrroY1NKPFWT4rC1ZBK/Rqua8t0pZQnDdGY+5pd0MpVWQg6fg220zm+Ak9F6H8FjlLNYNTsEz74= Received: from DS7PR10MB5232.namprd10.prod.outlook.com (2603:10b6:5:3aa::24) by PH8PR10MB6315.namprd10.prod.outlook.com (2603:10b6:510:1ce::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8534.44; Thu, 27 Mar 2025 15:45:45 +0000 Received: from DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324]) by DS7PR10MB5232.namprd10.prod.outlook.com ([fe80::8303:658f:14f8:2324%5]) with mapi id 15.20.8534.043; Thu, 27 Mar 2025 15:45:45 +0000 From: Drew Adams To: Eli Zaretskii , "mail@daniel-mendler.de" Subject: RE: [External] : bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' Thread-Topic: [External] : bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' Thread-Index: AQHbnw1eQoMma3FWQ0OswldzO6qz5LOHHQ4Q Date: Thu, 27 Mar 2025 15:45:44 +0000 Message-ID: References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <86a596d7l5.fsf@gnu.org> In-Reply-To: <86a596d7l5.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR10MB5232:EE_|PH8PR10MB6315:EE_ x-ms-office365-filtering-correlation-id: f7630142-444b-4f69-32df-08dd6d466ff7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018; x-microsoft-antispam-message-info: =?us-ascii?Q?fkdNRUZhBacVcEJGB2PsLoI3OrbK/Hmr7XZisvzaoDcG8hbugLSwyrGsdjcm?= =?us-ascii?Q?uuyDIfVlPuM3S8qWuGmPoVICETkxuzZncffYTpJHwxKJd9ycQ/jza8YdRvdl?= =?us-ascii?Q?UWlNkyRiETCewMIB4tbr78z3Yp427h3+6vQwi+G0YT3ZYr3VIaLrdw1dI8hM?= =?us-ascii?Q?XILtdl5INObf6YOxqwBbhNEzlMeJdfLg40Ux6enTuLBMII5HK1UiQ7lhgaOb?= =?us-ascii?Q?LBLKwbPUxDs4yys381uBKULoYe5gg/0qdjqz4ElPBiM0L3Bawxlwzz1AA2fK?= =?us-ascii?Q?pe4g1ESujuCMMOXPOIK9DAXM3ojjDO8pXt2sG2E86nZwDt5C/dmQ0AxsSIu2?= =?us-ascii?Q?Fbq+bv1kGgub1NhyVPzFvVGMXfvtu0GhpiebTLee86dDmRPmSeEQEandynGx?= =?us-ascii?Q?Oskie5vuk1MGSm1ldtDUtlr2S4WUCO2T5lgLINCcsL/fLE+NvVNCdCLO4H13?= =?us-ascii?Q?G6S4z9OLkkIaABw3l90CvVfFGKbInrrpxvbg4lFZJ37SvdCrp5RGrUbIBaoa?= =?us-ascii?Q?Y0z20Wh1QHWCTwBI0x0IDCH2q5BSTwAKq0L+QSrljCnSB89w8asIjAJ8s3qP?= =?us-ascii?Q?+IjG36Y0C56Gl38MBbRQJNtlfpT0H9uxVqAmq9xnxv8+KDHKvFV7mMW+46mC?= =?us-ascii?Q?KFqGCe1BxYdLWLNgad3iU8wevk0GroNCgq3ad4LfNR1cWoRLsP1nSIjVUN3i?= =?us-ascii?Q?ErAllgO5YiW8hEdkUbjN4DVA31KrP52FcxgmtzRiTn51+/KLJWZYH8mOD60F?= =?us-ascii?Q?vha7pk0kVEazsaUVYJPxlMpyyFGJi4cxO/RFsus0RLwyz3Vi9Vz4pSP8MAzN?= =?us-ascii?Q?OlINf9YGOxoqNo+xrVkemz6KRrvS4eAEairGjBOc3dM0q07oLnG1sYGSlXAG?= =?us-ascii?Q?VqnGV3It7qa2zbLwfvYdrv5e93cAAgD3PQoiy0aXfk3JU9efmboajoY3MoEK?= =?us-ascii?Q?bjsoEYFG8JLFr5tbth0TAqyvF84+ycT7P4yPBCrwN/MQ14S1CyFLYxnICRNZ?= =?us-ascii?Q?JJ1QNPZWuQNt5P6+zYC/vEq1ztUZbcJKpuNiiscMwcpH2wse989akyklhdod?= =?us-ascii?Q?birpVTf1sRurpj7hzRXXe61K64w+JOdMogQHdWaE4hwAhHl4DqGpeEtA77w4?= =?us-ascii?Q?eAtf3XUrJbB1CZZVwNnL2ZquQ0mgLGNFmgpaXElYdfgTsDBCkIjFb5w055gV?= =?us-ascii?Q?qE3VhzZ+zTIcxLataC2l/XOqx6jffdInerMnYk1y9k7n3eTBA1EVWeT6C2z2?= =?us-ascii?Q?TA3WfhFN84chPw/WPKxeH2B4elqyGXcW+ujEkzCffE8iAazGaQT3N9q0Mudb?= =?us-ascii?Q?9G0syFrvk2ZLTk8lxHRWsIjFAH0cQLW9iODxvWTSsPDavqrIouXs+jZbuzTJ?= =?us-ascii?Q?tAe6CTEOTY3j4TT1YjiHhSnFHtgpj+wfvTDEWzn9OqJHYAXxuQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DS7PR10MB5232.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/Ms/TAy+MeK4YuND5+Peop+BkQVJWIWg4LL0iWcrD40Y93ceFQR9sRUKiXjX?= =?us-ascii?Q?z/oc+u4lOrt6BlsABDiSteijRZVfoSQlXBlTR9pT7wzn7uqwmPNgks1icrTs?= =?us-ascii?Q?yTKObszVRdYllSLgDt4s8iwGovoS+IS+QwnlbWFU1KVeCYJhk2hbzOkoEBWN?= =?us-ascii?Q?MdH5bCU/QAk/HAJUzlwpr7cmJgClZsmhBSmkOaK+16JGlGVnKpaIgMP4Sy8l?= =?us-ascii?Q?Mh89Hui3VzRmICyX9SGTUIC/hloaWxGIj0PfTVLoEBtt8wCDzbjos/OUlIeR?= =?us-ascii?Q?slSwmiK3TJuOGtcnqKMjq1w+KHaisnT5oHH+UqYvVUigjwCoAOEUx/4iBL/6?= =?us-ascii?Q?cxjAxv+0/5yCbREk3bfo4VDvzkbnAKhLrUvUjzBs8uEwd3gyOd1lpTv22pXP?= =?us-ascii?Q?lsuLu4/SURuN8OLPSPKhu42E7nX3YCXm7DcfdTrYrwGyAEOqFoYaWpfiULq5?= =?us-ascii?Q?U5qR6gV4rNGP/MX8vAFBq9o6JNKfTfTEynSvoCXqHup56BsDrfqm6x8CDSZY?= =?us-ascii?Q?JhB6VBHT4NdM5HY5bWtN3/VLdYKWTSH+R05UriAMQcn3WA8eZc4aErCieYYa?= =?us-ascii?Q?E9/xETakUcxrlx8FANfnNUuVPsDjCidqx/AklmA9v0KM7XXRaAJIY3P5R/oU?= =?us-ascii?Q?4XRnhigsTFz4iYBzOxYyWONjNKpOTDCUUVQrFmUnV7M8TshUHt5FxJCtHb8C?= =?us-ascii?Q?9k5ItMmzwQBoa/i5ugNbi0CsRXhuZle3CuJNG9riX5oRcRP4TOJ/dXHQpSCw?= =?us-ascii?Q?cukX/R51/VD2KLx917kfbBIUBrR76PlMu/00kRK1p6cGZnwo9IDJPDz7hXM9?= =?us-ascii?Q?n+PfZtUk5C4//egUDwc89E/vXtaDu72UmX8bQ0EQgrqEl2TKhACe/G/3NLGb?= =?us-ascii?Q?3W39qleI7m6OkRm+ifx6s6hOnCpZsTm06xtVBZMiaO6Po7awiVQ80ePv6OKp?= =?us-ascii?Q?grlG0/WVzbPrxgCpAt12B9p9OhJOYvnOmSRxqDqGiAAH1g6clDl/8vTkgGkK?= =?us-ascii?Q?4UQJzkdD4X6U+0sBPe0aNgUCoDhsVxUIwzKoXkkehuB2kUj+5ygZVFyWOIB6?= =?us-ascii?Q?sEB26zx02g3q/Q9R1PJPwKiXohl3y2Cm47Q9KuJTv95CUlKp003gNUjHeZSr?= =?us-ascii?Q?9kynTId+pFUKcojA0Z10iDsmIcNln5uoc4rIe34ZqZG7h8vpbwOTDFLHmoa/?= =?us-ascii?Q?cX09+y/8Nhp5cw9m9p5ZC6+ljq3B54Z0dzm+o0eGpJutSDbIPK1lYuLUGnmi?= =?us-ascii?Q?TMeuy9F8ffuNEMy8Pcnu8B/Whg5xzePM5c4NTH8vBkQW3Efi0SbgPF5pDHcP?= =?us-ascii?Q?xFI6tDd1Wp6DKjXajIH3TkzE40g/mVDedzbK37Bbgdi/HYxF5qvUjs2kdMfn?= =?us-ascii?Q?k0ApTzzwUPJuHYOV6c7ax9XWfOkiLnPqKvPG2NphqS0cZbVTNF7O8RE5cdAT?= =?us-ascii?Q?gY3hx8nGnk0igZpGrlKLJgiTVwDIuEEtGzrv3NeQWPkx49Qu2MO5o4uMZuUJ?= =?us-ascii?Q?fioD33bW4Q2E47fQrcAp6uyTfdHWokakiFnni6If8bX7lYeXTvfwf9+TAzK4?= =?us-ascii?Q?DFT8LswsjhkMh4Eaj5LxTykwRtHAYsT3coVNVy8R?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: UbeUEXNq6JjQ2hDBwEhBgiGRhqw5p2FZwK5MYFlnL9SodATrXNurV2LyycgzAkSGOe8bsgJuX+oTphDvBYZr2fABGXk9DG3I0MHhTOAR216KJRVyPohuHQT6ZYHoeuQl0j8VONV0gkQ4XsxzDGDCZfsf7s7iKfjqYtLOvwV+RVuIq76jHiJEwFdaMbvrNKkCBYCWvAznvE6IAZzQMgCpyWy0YzeSnzm8weyp+Yw+WcQvPIusEBxqnt8NhwnmtRTCfvXA/wqtx3Xsf74tg2CR2E3sjU1lxS8yKxj258leW5qRuAAZDzMwY2X/p7vg/LGiL1N8zglfpeBMO04jPBLN478TUaZf3WboHK/+6xFKr0Oxpot9myjMJdBU0qivi8PA3Z2bRwtq2o6tEllD9DIAB4LDA0juFOg/H+4m3WWvQggPZM1WDbUJCFmtz8wGHZMYHr4/zHvk3eGg3c0gFHOzSqD2g2+e61iFvEBuxG7Acn0mK5mB6gXOG3BwkPF6rOBAfJY8ts5TXG1GwMYdcI2JdweeCbDCFHKuLPPeNcx63wQ777T8VASRzj+m9qyIn9kS/vr8P2Q6fVFB2Ml3rtOkP2Ipva9Vh2XJZ9mvsbQjJjA= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5232.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f7630142-444b-4f69-32df-08dd6d466ff7 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2025 15:45:45.0012 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ACKzeG7ruEPCmn+q96IlmNETiWV3yds50zZVORYcH2EJ3hSaB/P7buDLI/93PjK6glOsQxjyalsEYQbXWmcRsQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6315 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-27_02,2025-03-26_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2502280000 definitions=main-2503270107 X-Proofpoint-ORIG-GUID: 95xZM2sZEUf8X-pHmg-UDOVqOOnVsWW- X-Proofpoint-GUID: 95xZM2sZEUf8X-pHmg-UDOVqOOnVsWW- X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: "77224@debbugs.gnu.org" <77224@debbugs.gnu.org>, "eg642616@gmail.com" , "juri@linkov.net" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > > I see your point about sluggishness and I am very careful myself to n= ot > > > enable modes which add expensive computations to the > > > `post-command-hook'. Nevertheless in this case using the > > > `post-command-hook' is the right thing, such that the `cursor-type' i= s > > > changed effective immediately, as had been done before in CUA, see > > > `cua--post-command-handler-1'. The computation in this case is not > > > expensive. > > > > I disagree that the cursor must change "immediately", in the rigorous > > sense of that word. I think if it changes after 10 or 20 or 50 > > milliseconds, that's "immediately" for any practical purpose. >=20 > Btw, a possibly even better way is to modify the cursor looks from the > hooks of the relevant commands, like overwrite-mode. If some of them > don't have a hook, we could add a hook. This is better because it > doesn't unnecessarily "punish" Emacs anywhere else, only the commands > that could affect the cursor. >=20 > Does this make sense? It does make sense, to me. However, FWIW (haven't read all of this thread): Based on input from Juri and others many moon ago, library `cursor-chg.el' = has used pre(post)-command-hook since 2006 to optionally change the cursor = shape for overwrite/read-only, idleness, and/or use of an input method. Min= or mode `change-cursor-mode' does all but the idleness, which is done by `c= urchg-toggle-cursor-when-idle'. I agree with the general motivation not to overuse pre(post)-command-hook, = but FWIW I haven't noticed any problems with the use made of it in this cas= e. https://www.emacswiki.org/emacs/ChangingCursorDynamically https://www.emacswiki.org/emacs/download/cursor-chg.el From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 12:02:51 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 16:02:51 +0000 Received: from localhost ([127.0.0.1]:51002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txpgw-0007O9-SA for submit@debbugs.gnu.org; Thu, 27 Mar 2025 12:02:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56028) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txpgs-0007ML-OY for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 12:02:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txpgl-0000tK-CO; Thu, 27 Mar 2025 12:02:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=eQ0A8T3tuUHH5vv5sxh+XiUZUo/KqoyVsXSAgiq6vSg=; b=ZffZNs7Xt0D0vQLOpp1e 9nzEfbc5kiF0Q+IZt1nndGdF98CLYamMwFlbQQeD30xVhkVez/77NXnMrLXfhFAV9e6Us7ykDNjBQ XVve656t9frUatqrzQMUFPgl3PwZHneciuDD4bWUjjg1s+on0+9i+aHXnWPBcxQRAf9qNOnE48Nf7 eibvcJwu7Os7ExG39znxcr+R41VzXe1x9/DlH1+1ZSmKu7c8uc+HHEVXvC2O9aUIjNI21rlzXTSF8 WnNQktRU6xe0fYVej3Pa+DbMCseMOJl6YPM9YTKtr0GQOzCg7fUAPAWFYS0KPIXCUUGtBcI3+BrAi patHfGsMKwD6Eg==; Date: Thu, 27 Mar 2025 18:02:36 +0200 Message-Id: <86y0wqbgwz.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Thu, 27 Mar 2025 08:53:25 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <86a596d7l5.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez > Date: Thu, 27 Mar 2025 08:53:25 -0600 > Cc: mail@daniel-mendler.de, 77224@debbugs.gnu.org, > Juri Linkov > > Eli Zaretskii writes: > > Btw, a possibly even better way is to modify the cursor looks from the > hooks of the relevant commands, like overwrite-mode. If some of them > don't have a hook, we could add a hook. This is better because it > doesn't unnecessarily "punish" Emacs anywhere else, only the commands > that could affect the cursor. > > But what if user prefer using a lambda instead a function? For example for a specific mode or action from a > key binding package such as evil or meow Sorry, I don't understand: what lambda? Aren't all the modes you want to catch normal minor modes with a hook? > also i don't know if buffer-read-only have a proper hook. read-only-mode does have a hook. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 12:04:25 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 16:04:26 +0000 Received: from localhost ([127.0.0.1]:51006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txpiQ-0007bS-Jz for submit@debbugs.gnu.org; Thu, 27 Mar 2025 12:04:25 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:53067 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txpiM-0007Zh-I3 for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 12:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=tqNVSYAhp3jy8ZjzelE5xoiWFxuzfkLq8XYxG88famM=; b=Wwo28GNR69lR/IPoTw6hywWdOM 1pDC9hDLNWLlaH44+TkqYVtUyYQz1C5mTuLZd3kpGwX2H4+mnN+RUoG07E/k+PvIhZK7uOOdG85QL hcuE/85m4I/x96gFWu7kF6NGEMKznChYQ4J7aWvDK1g0CJt7edPtte00oI07ils9rlb8=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86cye2d8t6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Mar 2025 13:14:45 +0200") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> Date: Thu, 27 Mar 2025 17:04:09 +0100 Message-ID: <87a596a29y.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Thu, 27 Mar 2025 10:42:21 +0100 >> >> Eli Zaretskii writes: >> >> >> The problem with the idle timer is that it might not run immediately. >> > >> > That depends on the value of the SECS argument to run-with-idle-timer, >> > doesn't it. >> >> No, there is no guarantee that the idle timer will run soon enough after >> the given time if Emacs stays busy. > > If Emacs is busy, the post-command-hook will not run, either. When a > command exits, it return to the main loop, and unless the user types > something before that, Emacs then becomes "idle". There is a difference. When Emacs executes a command and hangs during command execution it is expected that the cursor does not update immediately. The cursor will however update after the command has finished. The commands which we talk about regarding cursor changes are usually executed quickly, like enabling some modes like `overwrite-mode'. >> > Sorry, I object to adding stuff to post-command-hook in these cases. >> > Emacs becomes very sluggish, and we should avoid that as much as we >> > can. >> >> I see your point about sluggishness and I am very careful myself to not >> enable modes which add expensive computations to the >> `post-command-hook'. Nevertheless in this case using the >> `post-command-hook' is the right thing, such that the `cursor-type' is >> changed effective immediately, as had been done before in CUA, see >> `cua--post-command-handler-1'. The computation in this case is not >> expensive. > > I disagree that the cursor must change "immediately", in the rigorous > sense of that word. I think if it changes after 10 or 20 or 50 > milliseconds, that's "immediately" for any practical purpose. No, 50ms are not acceptable for the user if they except an immediate response to a key press. I have seen bug reports to my packages where people complained about latency in the range of 10 to 20ms. The problem is also that idle timers are not bounded. If the user continues on typing, Emacs won't become idle and the cursor can change much later. This would look like a bug then. Again - CUA also used a `post-command-hook'. Why not preserve this, given that the mode is essentially extracted from CUA where it works well? I see your point about using specialized hooks though (e.g. `overwrite-mode-hook'), but this will make customization much more difficult, and for some variables there might not be a hook. Regarding Emacs sluggishness, the `cursor-indicators-mode' is an optional mode. If it increases sluggishness unnacceptably (which it won't), users can turn it off. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 12:30:19 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 16:30:19 +0000 Received: from localhost ([127.0.0.1]:51059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txq7W-0002jP-H4 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 12:30:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60276) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txq7P-0002di-GA for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 12:30:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txq7H-0004sB-Rf; Thu, 27 Mar 2025 12:30:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cdG6dQqrFyPHrvjwgNRpqc6ZxyLSNFvWzUQoLWz2L4Q=; b=FluXTE3d9E6m Mn6mxFFjDAeAXjLAJjlf9y3t3YP38Kkz7NsqqAITxQyXpMFyDuz8rrlok2g+7SbAeabngYJ1b6leS Ed3GU5xc2KFIItDpOBDg3nLxzo9rn6WscGjVsar6jQwnX7Sq5HvONISWaS8EN8HRP7qBW5u5btE5f Cu21xZT9Qn4NlFZvSi6lboAaK9RTu+OcLoSPH56QC3LVA/XpZJnGE3MIDk0yzJr77RafCNrJgQ5X1 C7BuzPEVLeECyu+AT0oSpcj0y1ZU8V3b4DRNUIVul/Obfn1RiCfhY0/I6XJgHt27IalFHNbC5MFYs 1tIe77RenXe2E4XqV+wnUw==; Date: Thu, 27 Mar 2025 18:29:59 +0200 Message-Id: <86tt7ebfnc.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87a596a29y.fsf@daniel-mendler.de> (message from Daniel Mendler on Thu, 27 Mar 2025 17:04:09 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Thu, 27 Mar 2025 17:04:09 +0100 > > Eli Zaretskii writes: > > > I disagree that the cursor must change "immediately", in the rigorous > > sense of that word. I think if it changes after 10 or 20 or 50 > > milliseconds, that's "immediately" for any practical purpose. > > No, 50ms are not acceptable for the user if they except an immediate > response to a key press. 50ms was just an example, and it is actually quite improbable to be that large. post-command-hook is run by the same loop that decides that Emacs is idle and runs timers, so the difference in practice should be very small if at all. > Regarding Emacs sluggishness, the `cursor-indicators-mode' is an > optional mode. If it increases sluggishness unnacceptably (which it > won't), users can turn it off. Experience shows that many users turn on a lot of features which rely on post-command-hook, and then complain that Emacs is slow to respond. Telling them to turn off features they like doesn't really work. Anyway, I think making the cursor change from a mode hook is a better solution. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 12:40:12 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 16:40:13 +0000 Received: from localhost ([127.0.0.1]:51073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txqH6-0003vO-6y for submit@debbugs.gnu.org; Thu, 27 Mar 2025 12:40:12 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:34589 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txqH2-0003p3-Ks for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 12:40:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=S7CASjzTyGJ5+hoYyjBAWTx6hXPwIc3E3j2BY2XgjB4=; b=NeG8sYr+y0KFd6HFaFgkFsD7wO DRv+wBdQ4KGYAeP2pXrH4Binlv9kNsN0WLuyg3i0n2XArKSgrmdcdvCNCGWGz1Oq3fMyL01SAnUsy taX64RALqCIZUe091Ma4ioVcqN13BEJAEI6TqyrET/r07TcRbIFzJ9TwVmZmRemWDd8Y=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86tt7ebfnc.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Mar 2025 18:29:59 +0200") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> Date: Thu, 27 Mar 2025 17:39:59 +0100 Message-ID: <877c4aa0m8.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Thu, 27 Mar 2025 17:04:09 +0100 >> >> Eli Zaretskii writes: >> >> > I disagree that the cursor must change "immediately", in the rigorous >> > sense of that word. I think if it changes after 10 or 20 or 50 >> > milliseconds, that's "immediately" for any practical purpose. >> >> No, 50ms are not acceptable for the user if they except an immediate >> response to a key press. > > 50ms was just an example, and it is actually quite improbable to be > that large. > > post-command-hook is run by the same loop that decides that Emacs is > idle and runs timers, so the difference in practice should be very > small if at all. The `post-command-hook' is guaranteed to run after a command while the idle timer is delayed until no new events are in the queue. This is why I argue that the delay can be too large, such that it will become noticeable. >> Regarding Emacs sluggishness, the `cursor-indicators-mode' is an >> optional mode. If it increases sluggishness unnacceptably (which it >> won't), users can turn it off. > > Experience shows that many users turn on a lot of features which rely > on post-command-hook, and then complain that Emacs is slow to respond. > Telling them to turn off features they like doesn't really work. I agree that this is a problem. However in this case the PCH will not cause problems, as has also been noted by Drew and as has been shown by CUA over the years. In contrast the idle timer will cause problems. I am actually looking forward to using `cursor-indicators-mode', but if it operates with an idle timer, I don't think it will indicate the editing status reliably enough. > Anyway, I think making the cursor change from a mode hook is a better > solution. As has been mentioned, the problem is that not every scenario is covered by hooks, while the PCH is a potentially universal solution which can check arbitrary conditions. But if hooks work sufficiently well for most scenarios, then why not. I think Stefan and Juri should chime in with their experience about this, since as I've seen, they both want to replace some custom cursor code with the new mode in their configuration. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 12:56:35 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 16:56:35 +0000 Received: from localhost ([127.0.0.1]:51113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txqWw-0005io-0k for submit@debbugs.gnu.org; Thu, 27 Mar 2025 12:56:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37904) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txqWt-0005hy-Cr for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 12:56:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txqWl-0008FR-P7; Thu, 27 Mar 2025 12:56:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8kfbPiaBz9uv83sIjKtvBAAfzbPZvxzKeIuybSLfolo=; b=KY07OtUwa+bK nugw655xZohK+PLdYpSCVXh2QShiRok1mX2zdoEUqXbXihZkmwWF3SYU2O96pRdim4YNJL9YcC0qW nvlXsOWM7BXJlutf7Ot2wcZPRCFAye8eyEBld8MIcOmD5go9fvJ8YSZYLdJh4yRGq6t3fZ1CBz7gv sT8d0KQNHdSsV/zlDtJZabsWcvzMxpCFruwddlw6uAG5IYpfcmAYjB1b7nSul27pUOKfWMFuCfNqP wvNo01kqFQ60klvquW4y99HoNzYrDO4yRoEu/4TRZQMBj8mCyjw6KpS65Bw6cPe46kXBsIIDThqyn tEJliBqjJLKcsT/FxMbTOQ==; Date: Thu, 27 Mar 2025 18:56:21 +0200 Message-Id: <86pli2befe.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <877c4aa0m8.fsf@daniel-mendler.de> (message from Daniel Mendler on Thu, 27 Mar 2025 17:39:59 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Thu, 27 Mar 2025 17:39:59 +0100 > > Eli Zaretskii writes: > > > post-command-hook is run by the same loop that decides that Emacs is > > idle and runs timers, so the difference in practice should be very > > small if at all. > > The `post-command-hook' is guaranteed to run after a command while the > idle timer is delayed until no new events are in the queue. No, the idle time is run immediately if there's no input. Emacs doesn't wait or delay the timer. > > Anyway, I think making the cursor change from a mode hook is a better > > solution. > > As has been mentioned, the problem is that not every scenario is covered > by hooks, while the PCH is a potentially universal solution which can > check arbitrary conditions. But if hooks work sufficiently well for most > scenarios, then why not. If there are cases that this indication supports but there's no mode hook for them, let's discuss those cases one by one and see how to solve them. I see overwrite-mode, read-only-mode, and input-method activation, all of which have hooks, AFAIR. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 13:10:32 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 17:10:32 +0000 Received: from localhost ([127.0.0.1]:51136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txqkR-0007Ar-L8 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 13:10:32 -0400 Received: from mail-oi1-x243.google.com ([2607:f8b0:4864:20::243]:61697) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txqkA-00072Z-Qb for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 13:10:18 -0400 Received: by mail-oi1-x243.google.com with SMTP id 5614622812f47-3fa6c54cdb2so830183b6e.3 for <77224@debbugs.gnu.org>; Thu, 27 Mar 2025 10:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743095409; x=1743700209; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=pAr6HuZ30kpTiC+9rOTNNmm0ucFxb+umdhduVcSEUZo=; b=f8snBIGeDkt297uqb/rPR9PRHo7D31XxSTKXfa5VgTZHAMW3/wrpMvbg4k/iuLwnQK +Uo4ofkFmnK95gbOAh2ZKa+uTwREefHEc6JaBVUJILEjmJOO3+slaSxGwNoRtRyN1JrL eQ7kr7pwCGwRWwdOLBI8diZeFrr+DsLSopZTjI95jtLVbGHA1qsijADEr7qIq5+k+w6i 2cZZjILzRZwvB0mZ7bzAHMxZgxkT9gUFBGfubsdfbBhU07wIL+R6IXi7VbY4UhvY1oti +Sx5BY04erQnopf2rizhLz+u9MGYKWtrTBmZdWAL7Ru049IxzvcA5gabj4lLqe2U5XbR EdTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743095409; x=1743700209; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pAr6HuZ30kpTiC+9rOTNNmm0ucFxb+umdhduVcSEUZo=; b=mNJ9cHnLNMfC5EKaNTC9/K9DWnzr2T4uliBNHbozAJ+Go0ALcGBtQHA6Ml8Qhp2zqb xpzjxUJWFlLpc2GEfi4AqeX7ZeU46QlpM1enoX2T2lrMk3pyGD0ndHX+Ph4cK55hBbtl 5lomvWm3vvBTgDd8NgMcmN4Aa4j71NKbDD6Qq6SthDUHcwBsISzbC2+eT5J33xeSgCfH N6IG36WpUuO3JoYHmrrmkdTJ5JH7rCR0OYu5752kNS82mhDR2V8VXJyx/dy0yMWvf9+a QZSxXeWKJdyHv38eKqsRCbI7DleNiBbdPeNbY1l/gbteevmJ/FZeKZh4mPkp4UoUa/vU fCyg== X-Forwarded-Encrypted: i=1; AJvYcCVug1Ush69APpRS8L0EBGApIwCqXn5KHCisLRGwNcM8IuHXqrxSJMgjwH18DhY0rByDNVPv/A==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwnevfTu8vgGC7U9NPk0GefITCl7ZFwmeuns97Q3eagYljPIpI1 tTPJ+15cHQ72jHM8RLPt4zOubwYViMChKo40ItWM4oNB1K6PdaoKlMAuQj5H X-Gm-Gg: ASbGncs0+0RTIWEjoFAnfbhfZ991Cuj2YD1g31YtnMHGMsSJVdWHHL8+W/k2hkESYTt R2BeTxDYOgqmdUz8l9zGujf+ZGAzVz9HxVRNPoyUUiGcD79JYsfr9sM80f+tIUDvs5aYl8nmmeW 6r7JrHekNmXN9Fsbbm9Ws52VwFLxKvSF1Ly4GFg3zZRNC9TGd5tKTXAF5j8k0zRRSN7WOstIU7z i6WK6/tMFZ7DubfHNwLKRKNk/UCtGnpSQmH3/qth1JifBjnfJJudPcSHpVi9r62GCrviOInKJfk GxFLz2ES4wno X-Google-Smtp-Source: AGHT+IHwI/W/0AuTPfJXVTqTJDUtEUBjkly3f31RPEY1A2FcibWKcA1SEFXPC2gUzutwUlHPJWNv0Q== X-Received: by 2002:a05:6808:1694:b0:3f7:d16c:e283 with SMTP id 5614622812f47-3fefa5248c0mr2566957b6e.11.1743095408533; Thu, 27 Mar 2025 10:10:08 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-602845008c9sm26043eaf.10.2025.03.27.10.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 10:10:07 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86y0wqbgwz.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <86a596d7l5.fsf@gnu.org> <86y0wqbgwz.fsf@gnu.org> Date: Thu, 27 Mar 2025 11:10:06 -0600 Message-ID: <87zfh6z9g1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, 77224@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Elijah Gabe P=C3=A9rez >> Date: Thu, 27 Mar 2025 08:53:25 -0600 >> Cc: mail@daniel-mendler.de, 77224@debbugs.gnu.org,=20 >> Juri Linkov >> Eli Zaretskii writes: >> Btw, a possibly even better way is to modify the cursor looks from the >> hooks of the relevant commands, like overwrite-mode. If some of them >> don't have a hook, we could add a hook. This is better because it >> doesn't unnecessarily "punish" Emacs anywhere else, only the commands >> that could affect the cursor. >> But what if user prefer using a lambda instead a function? For example f= or a specific mode or action from a >> key binding package such as evil or meow > Sorry, I don't understand: what lambda? Aren't all the modes you want > to catch normal minor modes with a hook? Not only minor mode, also functions (function symbols or anonymous ones). for example if user wants to change cursor appearance if a text at current cursor position have an overlay or whatever, can do it defining a function in their config: #+begin_src elisp (defun my/cursor-change () (string-prefix-p " *" (buffer-name))) (setopt cursor-indicators-conditions `((my/cursor-change hollow "yellow"))) #+end_src or #+begin_src elisp (setopt cursor-indicators-conditions `((,(lambda () (string-prefix-p " *" (= buffer-name))) hollow "yellow"))) #+end_src The current code only check if symbol is a variable or a function symbol (since minor modes also defines a variable with same minor mode name) or a lambda, and it must return =3Dnon-nil=3D. --==-=-= Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

Eli Zaretskii <eliz@gnu.org> writes:

From: Elijah Gabe P=C3=A9rez <eg642616@gmail.com>
Date: Thu, 27 Mar 2025 08:53:25 -0600
Cc: mail@daniel-mendler.de, 77224@debbugs.gnu.org,
Juri Linkov <juri@linkov.net>

Eli Zaretskii <eliz@gnu.org> writes:

Btw, a possibly even better way is to modify the cursor looks from the=
hooks of the relevant commands, like overwrite-mode. If some of them
don't have a hook, we could add a hook. This is better because it
doesn't unnecessarily "punish" Emacs anywhere else, only the commands
that could affect the cursor.

But what if user prefer using a lambda instead a function? For example= for a specific mode or action from a
key binding package such as evil or meow
Sorry, I don't understand: what lambda? Aren't all the modes you want
to catch normal minor modes with a hook?

Not only minor mode, also functions (function symbols or anonymous ones). for example if user wants to change cursor appearance if a text at
current cursor position have an overlay or whatever, can do it
defining a function in their config:

=
(defun my/cursor-change ()
  (string-prefix-p " *" (buffer-n=
ame)=
))

(set=
opt cursor-indicators-conditions `(<=
/span>(my/cursor-change hollow "yellow")=
))

or

=
(setopt cursor-indicators-con=
ditions `((,(lambda () (string-prefix-p " *" (buffer-name))<=
span style=3D"color: #bd93f9;">)
                                        hollow "yellow")))

The current code only check if symbol is a variable or a function
symbol (since minor modes also defines a variable with same minor
mode name) or a lambda, and it must return non-nil.

--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 13:46:45 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 17:46:45 +0000 Received: from localhost ([127.0.0.1]:51219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txrJV-0005Og-1R for submit@debbugs.gnu.org; Thu, 27 Mar 2025 13:46:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46028) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txrJS-0005O9-P2 for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 13:46:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txrJL-0006uB-NS; Thu, 27 Mar 2025 13:46:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=5N86iZ5fOdK8Lx8vSj/fBLDvm5W9W4ICwgDg5QsJF9M=; b=RIcfGl1CYrKr9qVSSmoC z9ubBfwVmxEPlnw/ZSRx/C8d4V6080vbSKfOFaV/UaAV8QawijIVfDflM764ir5MxYVWlz0LAUjja TFqI+bRQKqbH4wyKCNJ7OTjYdfwDBbS/o4y5X8OMA/tgbJTp+710lLeSuc89AHeP50Kumw/DMsNfg 53qK21bv+tu2GRM+MQmkj/2iyAdupAS6QEN+5dJVvjKV6bbcmfZCu4kLo9X6uNUKOsS0Wa0wnwiQN ChqsJrtg8lp/ZsYxLj5WIx00ruq+OIem23/pjqQV7Rq3++lVyWm0R7To/iRNJPZo74i9YoXqOnAL5 +zP1oA5q4sPhfA==; Date: Thu, 27 Mar 2025 19:46:34 +0200 Message-Id: <86msd6bc3p.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: <87zfh6z9g1.fsf@gmail.com> (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Thu, 27 Mar 2025 11:10:06 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <86a596d7l5.fsf@gnu.org> <86y0wqbgwz.fsf@gnu.org> <87zfh6z9g1.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, 77224@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez > Cc: mail@daniel-mendler.de, juri@linkov.net, 77224@debbugs.gnu.org > Date: Thu, 27 Mar 2025 11:10:06 -0600 > > But what if user prefer using a lambda instead a function? For example for a specific mode or action > from a > key binding package such as evil or meow > > Sorry, I don't understand: what lambda? Aren't all the modes you want > to catch normal minor modes with a hook? > > Not only minor mode, also functions (function symbols or anonymous ones). > for example if user wants to change cursor appearance if a text at > current cursor position have an overlay or whatever, can do it > defining a function in their config: > > (defun my/cursor-change () > (string-prefix-p " *" (buffer-name))) > > (setopt cursor-indicators-conditions `((my/cursor-change hollow "yellow"))) > > or > > (setopt cursor-indicators-conditions `((,(lambda () (string-prefix-p " *" (buffer-name))) > hollow "yellow"))) We have buffer-list-update-hook and window-configuration-change-hook, which I think should cover these. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 14:00:16 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 18:00:16 +0000 Received: from localhost ([127.0.0.1]:51252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txrWZ-0006iU-RP for submit@debbugs.gnu.org; Thu, 27 Mar 2025 14:00:16 -0400 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:44827) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txrWW-0006bG-Jg for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 14:00:13 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 860164433D; Thu, 27 Mar 2025 18:00:03 +0000 (UTC) From: Juri Linkov To: Daniel Mendler Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <877c4aa0m8.fsf@daniel-mendler.de> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> Date: Thu, 27 Mar 2025 19:45:56 +0200 Message-ID: <87semywfkr.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduieeltdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejjedvvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghgieegvdeiudeisehgmhgrihhlrdgtohhmpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepmhgrihhlsegurghnihgvlhdqmhgvnhgulhgvrhdruggv X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Eli Zaretskii , eg642616@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I think Stefan and Juri should chime in with their experience about > this, since as I've seen, they both want to replace some custom cursor > code with the new mode in their configuration. I tried the patch with 'run-with-idle-timer', and even the delay 0.1 is noticeable and causes the feeling that Emacs became sluggish and can't update the cursor immediately. So I'd prefer to use 'post-command-hook' that updates the cursor immediately. I already used this for many years, and there were no problems. As for adding more specific hooks, this is not simple to do since the cursor color depends on the current buffer and should be updated every time after switching to another buffer. And even with adding it to the display-buffer hook the complexity will explode. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 14:25:13 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 18:25:13 +0000 Received: from localhost ([127.0.0.1]:51296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txrui-0000d6-Ht for submit@debbugs.gnu.org; Thu, 27 Mar 2025 14:25:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50338) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txruf-0000Xe-Dc for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 14:25:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txruW-0003Zw-12; Thu, 27 Mar 2025 14:25:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/uY1ow7ciAcJS2pWCJSW2/WMIkpzuAULx2KcjhFhuCo=; b=QdeiTD0bMbgp 11FM7KAkWcSB+uaZMzOQukyYG6Ro/whNbJJSJXDtbYuQ2zWKL9TRgn5E3r3DvU4aQKERrFm64iOCD 8ioAT4xaUzJPUUaL4mcGeMk3Hql63vO2sUMa8OlnHLlFgAYpwhQqhSrRJHvdDMWqB0fn402rtloQm U+EJPpoYqA8aNFBCetfV1LVbuHgLmMmtUImV8fVvKsnvtHNOrLhvM3kG868NNbHishOrJwCZGMn01 VVoPaaKPUhDES5vNL1VQdc478zN5hxNHTVweTN5+/hLdKv3gbhGhFOsl1tpzG6ZwObIqqSN50vIoo ZdBa6SetNLGFMcqF0feJZA==; Date: Thu, 27 Mar 2025 20:24:54 +0200 Message-Id: <86jz8ababt.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <87semywfkr.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 27 Mar 2025 19:45:56 +0200) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <87semywfkr.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, eg642616@gmail.com, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , eg642616@gmail.com, 77224@debbugs.gnu.org > Date: Thu, 27 Mar 2025 19:45:56 +0200 > > > I think Stefan and Juri should chime in with their experience about > > this, since as I've seen, they both want to replace some custom cursor > > code with the new mode in their configuration. > > I tried the patch with 'run-with-idle-timer', > and even the delay 0.1 is noticeable and causes > the feeling that Emacs became sluggish > and can't update the cursor immediately. What about the delay of zero? From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 14:27:33 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 18:27:33 +0000 Received: from localhost ([127.0.0.1]:51315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txrwz-0000n6-Db for submit@debbugs.gnu.org; Thu, 27 Mar 2025 14:27:33 -0400 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]:61825) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txrww-0000mp-FN for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 14:27:31 -0400 Received: by mail-ot1-x341.google.com with SMTP id 46e09a7af769-72c03d237a7so609844a34.3 for <77224@debbugs.gnu.org>; Thu, 27 Mar 2025 11:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743100044; x=1743704844; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=y/7u6oSjsS9xyxdFZ8ZUEQXgnfOIkPtylYGI6tvkwpk=; b=JQFf8ELj+wBNHHgaqXGHasAbWAOULCNYu5OcYDHAYTL6C1zzs7T6whPxtc9AZ3oLJ5 bTHktB50lqzBNR3IsnPsI/KkmtSU09d0kuquAouKFd1d+fHrjBiUM8ZHZljrTXdBE6KY L4NfYjGgJ5MpeFwGIuoXuP25vt8gJNrwuSHvaRgvcqmcDvJcb3e1RrNxPSczv1k+FtPI dyrcrLvV7kzdOaOoYCbJOOpiXqPC4wXB1wy/ke+NNNhf81q/ahTCJa+696BrNm8rITsp vsD8tTE0HEJwEGaC6aNJxOshY0PcdXxmvMpweVgIKnJLdd6CkjJwPOOqTEwFHN111lLV qdvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743100044; x=1743704844; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=y/7u6oSjsS9xyxdFZ8ZUEQXgnfOIkPtylYGI6tvkwpk=; b=sgy7Z4I1rk/yiQjYjvp0yVwKhUdfONHS1WA6Qy2Z2uckUK/4zclAfk2AWzUCtdKa8o bE/SL4jCOddAFBMLHD69E88WX52mV2fvadqsbUXGAudn2MDlah3LBUgKS3/tQgXi2nzq C1TDt6fESfQwT/osxbjjsmRREMEYD4cUyWjBOeew/lmRE9fnf0RBZzWbTZKDYrlu5BHD G52hPb34cMDf7j5bagIUIMgacSZJ3Ne+MXwGdTDFubDva2jT02chUAunM4v934vBuXcp 3LGWorKG+AX2agPPGvIci8J4YCttHkKJFZ9QK/ahwYwn00fUxIBqt4WYpLd4M5yIPxM5 JNVw== X-Forwarded-Encrypted: i=1; AJvYcCXjmRJfH+KREVqn6Zq1vPwaSeCMtsLXiyoh2xvt3PLRcw6l4rUWawI1sMhk7Qiv+Vx6bBBXfQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyFz0ZuUicEkV5FRtvvnCMOw0L7nv1IX/t0a6bzPdK9S5FRrVva hKB9RkHMd7MBSm3h2W/jemNivx6Xy8iZdEWlrLqb930aHwkqvtL1N95Wt/4t X-Gm-Gg: ASbGnctMNqnJMphztQeJZqqTJwSR7fILpz2d7d+JRfXHYSqoiBGZQWUrWSccZXR/hpj 2k6072IJ8yf92OxbGr4H9E8c7Q8DRRmju9tTWt1npmIJf1RGlYM8/VrcxQiKNJ8lERz4iYz8Nmh TFW8ukICncHFH19brITRBR+AKR6ga8Z473OJVorapyxBhAVFrydux5Sn6dv5t3ge70r/ex/QuJM JYy+wcJg8jhlayQglwA2GFjPtndomszGWjhE6ArLagXvMOSncIznPvAoXohL48sFyYWzmcs791j WpnmkZUWP0wX X-Google-Smtp-Source: AGHT+IHeXC9tzsASZ/kNhKdvEW3rQ4u5thPQH9+2XEi7kni0QJKSB5HBANUju9c8pOUfQjN5CywapQ== X-Received: by 2002:a05:6830:d15:b0:72b:872f:efc8 with SMTP id 46e09a7af769-72c4ca44954mr3689117a34.24.1743100044178; Thu, 27 Mar 2025 11:27:24 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c58267f54sm78126a34.55.2025.03.27.11.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 11:27:23 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86pli2befe.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> Date: Thu, 27 Mar 2025 12:27:22 -0600 Message-ID: <87pli2z5v9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: Daniel Mendler , juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Eli Zaretskii writes: >> > Anyway, I think making the cursor change from a mode hook is a better >> > solution. >> As has been mentioned, the problem is that not every scenario is covered >> by hooks, while the PCH is a potentially universal solution which can >> check arbitrary conditions. But if hooks work sufficiently well for most >> scenarios, then why not. > If there are cases that this indication supports but there's no mode > hook for them, let's discuss those cases one by one and see how to > solve them. I see overwrite-mode, read-only-mode, and input-method > activation, all of which have hooks, AFAIR. But the problem with using hooks is that modes sometimes defines a specific name for hook or use different hooks for that, for example overwrite-mode only defines overwrite-mode-hook, however input-method defines input-method-activate-hook and input-method-deactivate-hook or mark/region have activate-mark-hook and deactivate-mark-hook. --==-=-= Content-Type: text/html

Eli Zaretskii <eliz@gnu.org> writes:

Anyway, I think making the cursor change from a mode hook is a better
solution.

As has been mentioned, the problem is that not every scenario is covered
by hooks, while the PCH is a potentially universal solution which can
check arbitrary conditions. But if hooks work sufficiently well for most
scenarios, then why not.

If there are cases that this indication supports but there's no mode
hook for them, let's discuss those cases one by one and see how to
solve them. I see overwrite-mode, read-only-mode, and input-method
activation, all of which have hooks, AFAIR.

But the problem with using hooks is that modes sometimes defines a
specific name for hook or use different hooks for that, for example
overwrite-mode only defines overwrite-mode-hook, however input-method
defines input-method-activate-hook and input-method-deactivate-hook or
mark/region have activate-mark-hook and deactivate-mark-hook.

--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 14:35:54 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 18:35:54 +0000 Received: from localhost ([127.0.0.1]:51327 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txs53-0001Co-Ho for submit@debbugs.gnu.org; Thu, 27 Mar 2025 14:35:54 -0400 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:44434) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txs4z-0001CY-0c for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 14:35:50 -0400 Received: by mail-oi1-x244.google.com with SMTP id 5614622812f47-3feaedb6670so777279b6e.1 for <77224@debbugs.gnu.org>; Thu, 27 Mar 2025 11:35:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743100543; x=1743705343; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ASIP97p7J05zMWWyNFJMSX09KUqL/cD/GgDlDzKcrIM=; b=SCqAg0DhZi1b4zFfkx6J8ot0b0ahOCDljN+JQxrVNWA5XV1xF1VmRPf6TyVR0WYU19 XCW4BsypH9pkJWEGpiqMUHR7YmzzLYDTMaFRBnruLL0tXwaLHdxnrFoqXL7nSet9mR/p blo3YTiyYJAVlvOJHEww/Oh436UoVAE6F4zfJtgBLHIjQPn2BWXGDyRFzM/GdwMSC5I5 ubgWYKiWh3Viauag3YM9DlRbrO9fTk+0fjOfIawOrWildbYn8cX17SxjK9bSwMUt6mcT RE/2EaR5lihUeqigwGUHjjw5nBG9sgtbkaRQYS32wDFOnmbQFFREkLK7FHWEQHiRkQnj 1Gow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743100543; x=1743705343; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ASIP97p7J05zMWWyNFJMSX09KUqL/cD/GgDlDzKcrIM=; b=Nj8QgC2rQq94lSz4z78ADd4k2Pt01JmAafA5K0iTpNYN8qi6cIDGnxxcfDkvu/Spzi dCk1BFpMmeHrbY1UwYkcphDtiAYdgmKGxPQgRxN5hbKpsUyT6PcR6byeiq5JO2z+AT9K DIkP9N4bap9o5EyJ6FodMg0UmymLY5pVmUrezISR2HkToQzNE55ZjrWpLg24XF77NjIk MxQX5k4If3VDI52TMDBkcYLoy5TNJc2GknPLK4wcrKLq7w/0RYjok0yzFrc57djP8hmN AI61zRYJ8eSKjS6vry31WvV3OxDpgb8cRZXw32kknq9AWmcNHa9O5LiNhRdmeXDeZTf8 o3gg== X-Forwarded-Encrypted: i=1; AJvYcCX4ElQyQQuWeNfAs9ZiDSajxRQgNgXPthQ2arXSxbUOTgAgPF2sSftH7HS+POC4el4OK3c+Fw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyyx5KWaqV2pvvfLPzonANGhAvE5CUaZ+4ShkPd7NUy54J53LoX nBWVMCanWbHoeCcLfN8uf+4/nzDmQOp1zRLGyLAhu8e0nbmHlaWL X-Gm-Gg: ASbGncvX8oI+KIal0oDrXleOUQhTSmIfyS3XYDb9JkH1bkRsx16tb25wfSyCXdSdmrY HHldxT+TFweZOCoLSJ1ItqAn9O6NBnTtZJhcxJJ8I2LDsp5uDAJA+CjJj4F61gxbco8nzWMDNQV /4r2hvkAkE2ZVRM8KRDzt904/sZKvXZdK8wXgrQ68Bkrtw9KLJYsLVYoch16c1t8yFr4NVOlAgm ppYrMXja0SJY79DI9OgkhtrgDl17Cu0lJ/uyxarqhyuOYM6xztgMHlF8ibUuaDlHrG1WM/sWJ2I nmiJ1tTPaDCa X-Google-Smtp-Source: AGHT+IFIWcGChHWXHsV2qzJfIAXVRa+PiyM05c6H68+SWakEdM7y4dEtwsVKYZlD6H9QEOsk+2P9CA== X-Received: by 2002:a05:6808:3844:b0:3f6:7b62:942e with SMTP id 5614622812f47-3fefa3ad594mr2837422b6e.0.1743100542841; Thu, 27 Mar 2025 11:35:42 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ff05167347sm30620b6e.6.2025.03.27.11.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 11:35:42 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Juri Linkov Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87semywfkr.fsf@mail.linkov.net> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <87semywfkr.fsf@mail.linkov.net> Date: Thu, 27 Mar 2025 12:35:41 -0600 Message-ID: <87jz8az5he.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: Daniel Mendler , Eli Zaretskii , 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Juri Linkov writes: >> I think Stefan and Juri should chime in with their experience about >> this, since as I've seen, they both want to replace some custom cursor >> code with the new mode in their configuration. > I tried the patch with 'run-with-idle-timer', > and even the delay 0.1 is noticeable and causes > the feeling that Emacs became sluggish > and can't update the cursor immediately. I think with 0.005 is most that fine, it's not immediate but also not too lazy IMO. Anyways the user can change the delay to 0. --==-=-= Content-Type: text/html

Juri Linkov <juri@linkov.net> writes:

I think Stefan and Juri should chime in with their experience about
this, since as I've seen, they both want to replace some custom cursor
code with the new mode in their configuration.

I tried the patch with 'run-with-idle-timer',
and even the delay 0.1 is noticeable and causes
the feeling that Emacs became sluggish
and can't update the cursor immediately.

I think with 0.005 is most that fine, it's not immediate but also not
too lazy IMO.

Anyways the user can change the delay to 0.

--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 15:13:38 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 19:13:38 +0000 Received: from localhost ([127.0.0.1]:51383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txsfa-0005tx-Du for submit@debbugs.gnu.org; Thu, 27 Mar 2025 15:13:38 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35231) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txsfX-0005td-8W for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 15:13:35 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 23CFA442AC; Thu, 27 Mar 2025 19:13:24 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86jz8ababt.fsf@gnu.org> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <87semywfkr.fsf@mail.linkov.net> <86jz8ababt.fsf@gnu.org> Date: Thu, 27 Mar 2025 21:13:06 +0200 Message-ID: <87pli2qocd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduieelvddvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejjedvvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghgieegvdeiudeisehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhgrihhlsegurghnihgvlhdqmhgvnhgulhgvrhdruggvpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, eg642616@gmail.com, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > I think Stefan and Juri should chime in with their experience about >> > this, since as I've seen, they both want to replace some custom cursor >> > code with the new mode in their configuration. >> >> I tried the patch with 'run-with-idle-timer', >> and even the delay 0.1 is noticeable and causes >> the feeling that Emacs became sluggish >> and can't update the cursor immediately. > > What about the delay of zero? Ok, will try zero for a while. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 15:25:41 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 19:25:41 +0000 Received: from localhost ([127.0.0.1]:51417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txsrE-0006X9-RE for submit@debbugs.gnu.org; Thu, 27 Mar 2025 15:25:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40288) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txsrA-0006Wq-7g for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 15:25:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txsr3-000326-2z; Thu, 27 Mar 2025 15:25:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xZiyZIhdg9yQRybG9pX1oDipf3DffQyQBau+Hunkegg=; b=JnchDMyg/w3wHTyvjqGK B7QmQ5yKFQREe/1COySo1SxrZCnu0NWMnDpCwtN7i9CMVNTcxgkOd7e0fsjPm92f4UXe9iS09LHB7 0tsCCnGvwI8m4ykW2oJfLLRTuydhI5+GEIO+ygnZmdjNDooQRTUCGiqtabtsbRNFWT7cq56iYqecK p1h/iz7ZIt4xCK7Te+DrBZK4yj9cNqPhX9JWCfUWFdbQ8sX1KZ0UKJBfJHLGklIhvDRS+9xuUS4ow AaRj8s/TerEIqD1JDdbswE+0QxBnH6y/lZfedR8lZC8b2UK+NWZVUxSYBiQHvVaPO9KIFYHkPpQ3d YI2ZTWSuCH5QaQ==; Date: Thu, 27 Mar 2025 21:25:22 +0200 Message-Id: <86iknub7j1.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: <87pli2z5v9.fsf@gmail.com> (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Thu, 27 Mar 2025 12:27:22 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <87pli2z5v9.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez > Cc: Daniel Mendler , 77224@debbugs.gnu.org, > juri@linkov.net > Date: Thu, 27 Mar 2025 12:27:22 -0600 > > Eli Zaretskii writes: > > Anyway, I think making the cursor change from a mode hook is a better > solution. > > As has been mentioned, the problem is that not every scenario is covered > by hooks, while the PCH is a potentially universal solution which can > check arbitrary conditions. But if hooks work sufficiently well for most > scenarios, then why not. > > If there are cases that this indication supports but there's no mode > hook for them, let's discuss those cases one by one and see how to > solve them. I see overwrite-mode, read-only-mode, and input-method > activation, all of which have hooks, AFAIR. > > But the problem with using hooks is that modes sometimes defines a > specific name for hook or use different hooks for that, for example > overwrite-mode only defines overwrite-mode-hook, however input-method > defines input-method-activate-hook and input-method-deactivate-hook or > mark/region have activate-mark-hook and deactivate-mark-hook. If there's a single hook, it is called both when turning the mode on and when turning it off, so I'm not sure I see the problem. Anyway, I think I'm done arguing. I'm quite sure you all understand my opinions and suggestions; if you want to disregard them and use the post-command-hook anyway, feel free, but don't be surprised if someone then complains that Emacs became a tad slower: it's because of all these features that take the easy way out and use post-command-hook, and by that add yet another one of those small slowdowns, which add up and up... From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 16:17:44 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 20:17:44 +0000 Received: from localhost ([127.0.0.1]:51495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txtfY-0000Sh-G7 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 16:17:44 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:34123 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txtfS-0000SN-9W for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 16:17:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=byP74CLiKgIVYjs+xBmOMXWFZ/zIgDzSUFYBi0WRk4I=; b=nxeOT4/2KiBmzXZCAiGI32Fsdf mIwO45Bq3cm6N001UmP0N3/tgISZvTFYedmLWRdtuUBtVdcBXzhg/uz4lqRtYKw/1p7JQb3fz0t0m 9AzhmIktXo1tg7AvABgHXBnkf4/VnoPpKzVkzyyi5BAr75y7h/fMMHwcECBv8anyANPU=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86pli2befe.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 Mar 2025 18:56:21 +0200") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> Date: Thu, 27 Mar 2025 21:17:25 +0100 Message-ID: <878qoq5iui.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Thu, 27 Mar 2025 17:39:59 +0100 >> >> Eli Zaretskii writes: >> >> > post-command-hook is run by the same loop that decides that Emacs is >> > idle and runs timers, so the difference in practice should be very >> > small if at all. >> >> The `post-command-hook' is guaranteed to run after a command while the >> idle timer is delayed until no new events are in the queue. > > No, the idle time is run immediately if there's no input. Emacs > doesn't wait or delay the timer. We are saying the same thing here. Yes, if there is no input, the idle timer will run immediately. But if the user continues typing and events are in the queue, then the timer will not run for some time. A delay also occurs when an asynchronous process runs and fills a buffer in the background like the *compilation* buffer. Then the cursor update will lag behind. I am with you that one should not carelessly add `post-command-hooks'. I use various modes which use `post-command-hooks', idle timers and regular timers, each for their proper use case. For example `post-command-hooks' lead to sluggishness if they were used for auto completion, spell checking or help at point (like Eldoc). For such use cases idle timers or regular timers are the better tool since they defer the expensive computation of completion strings, talking to a language server, completion backend or a spell checker. Here we discuss changing only the color of the cursor, a much much less complex operation. The `cursor-type' update and checking a few variables to find the color is a cheap operation which will not lead to sluggishness. If this were an expensive operation, I would look elsewhere for places to optimize, but avoiding `post-command-hook' is not the solution. Daniel From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 16:32:27 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 20:32:27 +0000 Received: from localhost ([127.0.0.1]:51521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txttr-0001Ac-05 for submit@debbugs.gnu.org; Thu, 27 Mar 2025 16:32:27 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:47205) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1txttn-0001AI-9N for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 16:32:23 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-22401f4d35aso33754135ad.2 for <77224@debbugs.gnu.org>; Thu, 27 Mar 2025 13:32:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743107537; x=1743712337; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=x1dsDPJbWq5m/yxj29hPc0nnXV0NdKnnJ+P5ll8JtjU=; b=TaseePNzixY4QexJZ6LWkdWvLF4YMaV718Tki01DV7I4sdM5jzYZ6pwziqmENdtuu8 7WaSCQqPwp+PHgrh2QJvQ36cSeO/HPaOHfoGsxW5AoIRWrwIaOvWUfiOfLCZZqteniCZ tDZMXfNp6ImgTfG/q2vBug4tUbp6I21u3AGan85MKtgc/J5hCH7xHa2T1ai+EqGZsN4U r/dWmmxm0TVmlAp/ruN4/vexYi4Ix6kShbGQcnUHf5Q1DSwgKLCPj4ADFfJ9I0xHm1je Hg2/bNOjXx3Jtg9UhHGNpvK4BXtwqQZFZB2Pr7wT3lXYQ0KKvpLopSS2t5YW1gTcpPe3 lp+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743107537; x=1743712337; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=x1dsDPJbWq5m/yxj29hPc0nnXV0NdKnnJ+P5ll8JtjU=; b=DfNNSO7vNQTkeOwT9dTPDoew6Vg754TvAxXGDjCy2/TPaQK93UbzVQ01mYfXlGu6vK WuAJ54xriwFOpHMM5EVEmSqrIjUQFqMJaOFcrpH+Yb/hFRwkpRrO5yMhuhvlHyXlUlVy dxvsdjzQ22JshEDUfUqKZmXVzXhh9GpnfHLYASQeMEErd5SzLvvLm6eiIuLPk+kR9Fmg F45csZDqJy0rLL4UmORUJ0dl76hBYePywpZ0tdgqqBoljYsa3ayc4CqL5sQPEe3hloPe xY3P/YWhkcHcYzouNdy6Umh02LZayfPGoS/7xUO3hf91bJMcadYI9d8sS4qDS3Oi7HFn pQDg== X-Gm-Message-State: AOJu0Yyv2dXgkDqnOtgJ/uRHp2WvD11s5nsHbVV33zmJhRKAqHfL6rZ7 RmB/zxvvTftUk2oTAtLbT9MMwCdyACh1C+Xxp70tJ3mMc5cEV8HR X-Gm-Gg: ASbGnctx9IJoCgphCFCuCU93kYuiE2K7ibLu/iS7/J1Y1y9L0QjPPj6jVZiDx7QoGEF VMuyy0UJlhSFzuCUJ5LTOdrykkunKhfT4A7tHqV4w9D2vuVLZVMwXHQqkkHr49xv4N5MC6ZrZ9p QvCGofOGrB9NJEu6niHtZls5n9SMrOa5zApMNIrKd6+K/1VSQo+PtMqvVe6MLDFSIXvy1J1YV9d 3zHvKhQg/o47u1YbQClVq6mQiPGGEC6QRsg3yTihzRLZWn07MzljBFUcCoacbAQjB79U8YoyOF4 Veq7P9Evgf7bD8LCO38n4JBbY9ME3oLTEA/aug2j9VizGkz7dZa/Y3jUys/GIaYoFZ+P1jEwoQ7 Us3dynp5uR47OAXldeFgitrKc X-Google-Smtp-Source: AGHT+IF9lMyZ2Pl1qCNLwpNE9Ic5cws4DvNiyhDYZFm1II40amkQJWJ9g5Lr+IcQMVdfGdZqUi4Vqg== X-Received: by 2002:a05:6a21:3a46:b0:1f5:619a:7f4c with SMTP id adf61e73a8af0-1fea2f4c253mr9741863637.29.1743107536809; Thu, 27 Mar 2025 13:32:16 -0700 (PDT) Received: from [192.168.1.2] (syn-023-240-109-202.res.spectrum.com. [23.240.109.202]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7397106b01asm273378b3a.102.2025.03.27.13.32.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Mar 2025 13:32:16 -0700 (PDT) Message-ID: Date: Thu, 27 Mar 2025 13:32:16 -0700 MIME-Version: 1.0 Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' Content-Language: en-US To: Eli Zaretskii , mail@daniel-mendler.de References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <86a596d7l5.fsf@gnu.org> From: Jim Porter In-Reply-To: <86a596d7l5.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/27/2025 4:41 AM, Eli Zaretskii wrote: > Btw, a possibly even better way is to modify the cursor looks from the > hooks of the relevant commands, like overwrite-mode. If some of them > don't have a hook, we could add a hook. This is better because it > doesn't unnecessarily "punish" Emacs anywhere else, only the commands > that could affect the cursor. > > Does this make sense? That makes sense to me, and is approximately what I have in my own configuration to do the same sort of thing as this patch. I update the cursor by adding a hook to 'after-change-major-mode-hook' and then adding variable watchers for 'buffer-read-only' and 'overwrite-mode'. That was the most-reliable method I could find at the time. If there were appropriate hooks for read-only/overwrite, then I think that would be the ideal solution. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 16:42:01 2025 Received: (at 77224) by debbugs.gnu.org; 27 Mar 2025 20:42:01 +0000 Received: from localhost ([127.0.0.1]:51545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txu34-0001cJ-Aa for submit@debbugs.gnu.org; Thu, 27 Mar 2025 16:42:01 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]:41568) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txu2x-0001c3-SJ for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 16:41:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: References:In-Reply-To:Subject:CC:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DR+s+MO9eKJedPblRkdogF9UD47g/Ap8ilT5MINlC+s=; b=Hr5SdC8sYpMAar6G0Pq/Lss/pU uwcEeXxFciUKQdUlOfr0OmxovBVbrhRAEp5uBFyfQiFZ76nsdwPp1v7EX/izB3oPYGwg7kiSbsTGt WGbQDJdrKTfqN+q1VIduEbxXI85FkmAM+jgTO1dzkfOk30sZ4q93pN7OFvYm00a1MDCYXer6EKVyO w3ezhJ0hUeJM9a/Scxor2weGeO0HZeN4E+5iUWm8O49aTTSfK9TrO7Sh6w+leG7OgQfT/ZncvUz3B jj2bROqcXc2vbQiud3c7bN7BNSEq6oQw3lDSBxS5tyGrZNwTRxHwAMsW03C47G0CT/ZUQ6NruwnxA orKJki8g==; Received: from 2603-9001-4203-1ab2-6547-8c8c-bd19-5cb4.inf6.spectrum.com ([2603:9001:4203:1ab2:6547:8c8c:bd19:5cb4]:47182 helo=[IPv6:::1]) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1txu2R-004FNd-1w; Thu, 27 Mar 2025 16:41:19 -0400 Date: Thu, 27 Mar 2025 16:41:39 -0400 From: Daniel Colascione To: bug-gnu-emacs@gnu.org, Eli Zaretskii , Daniel Mendler Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' User-Agent: K-9 Mail for Android In-Reply-To: <86tt7ebfnc.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> Message-ID: <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On March 27, 2025 12:29:59 PM EDT, Eli Zaretskii wrote: >> From: Daniel Mendler >> Cc: eg642616@gmail=2Ecom, 77224@debbugs=2Egnu=2Eorg, juri@linkov=2Ene= t >> Date: Thu, 27 Mar 2025 17:04:09 +0100 >>=20 >> Eli Zaretskii writes: >>=20 >> > I disagree that the cursor must change "immediately", in the rigorous >> > sense of that word=2E I think if it changes after 10 or 20 or 50 >> > milliseconds, that's "immediately" for any practical purpose=2E >>=20 >> No, 50ms are not acceptable for the user if they except an immediate >> response to a key press=2E > >50ms was just an example, and it is actually quite improbable to be >that large=2E > >post-command-hook is run by the same loop that decides that Emacs is >idle and runs timers, so the difference in practice should be very >small if at all=2E > >> Regarding Emacs sluggishness, the `cursor-indicators-mode' is an >> optional mode=2E If it increases sluggishness unnacceptably (which it >> won't), users can turn it off=2E > >Experience shows that many users turn on a lot of features which rely >on post-command-hook, and then complain that Emacs is slow to respond=2E >Telling them to turn off features they like doesn't really work=2E Nor does telling external package authors not to use post-command-hook=2E = I think there are two worthwhile approaches: 1) time the entries in post-co= mmand-hook and alert users about slow ones, and 2) provide a "do something = when X, Y, or Z changes" API that authors could use when they would otherwi= se put something on PCH and check X, Y, and Z internally=2E Internally, we = could DTRT and omit running those hooks when the relevant conditions haven'= t changed=2E For example, instead of putting something buffer and focus dependent in PC= H or fiddling with buffer and window and frame hooks, you could write somet= hing like (call-on-change (:buffer :window :focus) #'my-thing) or something like that=2E It's not that you can't do the equivalent by manually adding my-thing to t= he appropriate hooks directly, but the convenient one stop syntax might gui= de people away from PCH=2E > >Anyway, I think making the cursor change from a mode hook is a better >solution=2E +1=20 > From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 16:48:39 2025 Received: (at submit) by debbugs.gnu.org; 27 Mar 2025 20:48:39 +0000 Received: from localhost ([127.0.0.1]:51568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txu9W-0001ug-Hv for submit@debbugs.gnu.org; Thu, 27 Mar 2025 16:48:39 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56470) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txu9O-0001uC-Jy for submit@debbugs.gnu.org; Thu, 27 Mar 2025 16:48:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txu9J-0008R1-8H for bug-gnu-emacs@gnu.org; Thu, 27 Mar 2025 16:48:25 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txu9G-0005yI-Ir; Thu, 27 Mar 2025 16:48:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: References:In-Reply-To:Subject:CC:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7W0lMmcYGrq9215poGXmQMBRSfVYhZVbTZOOumdZIO4=; b=oM1iv/qDy2IgSExxwaXfmZK1bG g6x3DGNLsLHy4kvHlOaoO9tonJy923iogB34bVC0c0b2kQxAEjAPU0KURUDmcT6qLvuVCtdhlRnU0 plIDNs3Dkcai1C52LN/rJWZh9a6g68fKdwGyFKxIQl2L2Puzj4g5sUhdYx8bPJoq1KmlQqs/XIPdE bg7CN/wVu7ZiFbTcjIp17quqP+XrbCa1e8WQf1UscI4m4+exgsSPu1tWgqZM0WR6dJGqQpid1yMjC uzJ7r9f5//NLGTRneqHn5vTt5ZghS/XHdz6HpV0NCU0WzIcWzFK3bkqEx/p8j00GIvi56EBNEtEEG DdBPV45w==; Received: from 2603-9001-4203-1ab2-6547-8c8c-bd19-5cb4.inf6.spectrum.com ([2603:9001:4203:1ab2:6547:8c8c:bd19:5cb4]:39814 helo=[IPv6:::1]) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1txu8o-004FOx-0d; Thu, 27 Mar 2025 16:47:55 -0400 Date: Thu, 27 Mar 2025 16:47:03 -0400 From: Daniel Colascione To: bug-gnu-emacs@gnu.org, Eli Zaretskii , Daniel Mendler Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' User-Agent: K-9 Mail for Android In-Reply-To: <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> Message-ID: <93E6AF16-CA6C-443F-9712-B395E2403F60@dancol.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2600:3c01:e000:3d8::1; envelope-from=dancol@dancol.org; helo=dancol.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) On March 27, 2025 4:41:39 PM EDT, Daniel Colascione = wrote: > > >On March 27, 2025 12:29:59 PM EDT, Eli Zaretskii wrote: >>> From: Daniel Mendler >>> Cc: eg642616@gmail=2Ecom, 77224@debbugs=2Egnu=2Eorg, juri@linkov=2En= et >>> Date: Thu, 27 Mar 2025 17:04:09 +0100 >>>=20 >>> Eli Zaretskii writes: >>>=20 >>> > I disagree that the cursor must change "immediately", in the rigorou= s >>> > sense of that word=2E I think if it changes after 10 or 20 or 50 >>> > milliseconds, that's "immediately" for any practical purpose=2E >>>=20 >>> No, 50ms are not acceptable for the user if they except an immediate >>> response to a key press=2E >> >>50ms was just an example, and it is actually quite improbable to be >>that large=2E >> >>post-command-hook is run by the same loop that decides that Emacs is >>idle and runs timers, so the difference in practice should be very >>small if at all=2E >> >>> Regarding Emacs sluggishness, the `cursor-indicators-mode' is an >>> optional mode=2E If it increases sluggishness unnacceptably (which it >>> won't), users can turn it off=2E >> >>Experience shows that many users turn on a lot of features which rely >>on post-command-hook, and then complain that Emacs is slow to respond=2E >>Telling them to turn off features they like doesn't really work=2E > >Nor does telling external package authors not to use post-command-hook=2E= I think there are two worthwhile approaches: 1) time the entries in post-c= ommand-hook and alert users about slow ones, and 2) provide a "do something= when X, Y, or Z changes" API that authors could use when they would otherw= ise put something on PCH and check X, Y, and Z internally=2E Internally, we= could DTRT and omit running those hooks when the relevant conditions haven= 't changed=2E > >For example, instead of putting something buffer and focus dependent in P= CH or fiddling with buffer and window and frame hooks, you could write some= thing like > >(call-on-change (:buffer :window :focus) #'my-thing) > >or something like that=2E > >It's not that you can't do the equivalent by manually adding my-thing to = the appropriate hooks directly, but the convenient one stop syntax might gu= ide people away from PCH=2E Also, we'd be able to coalesce and debounce calls to these change function= s=2E From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 27 20:49:42 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 00:49:42 +0000 Received: from localhost ([127.0.0.1]:51963 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1txxuo-0008Dq-EA for submit@debbugs.gnu.org; Thu, 27 Mar 2025 20:49:42 -0400 Received: from mout.web.de ([212.227.17.11]:42629) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1txxul-0008DZ-7O for 77224@debbugs.gnu.org; Thu, 27 Mar 2025 20:49:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1743122972; x=1743727772; i=michael_heerdegen@web.de; bh=UIDQm8GgVpragslBQILHtHA5rHzSQkEshzpfPzrP2F4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=mbqlrWoyUMxymzzMKe6JrtDK6OcPJl8UZkBE0cfhSHQ7JWmLaOTatTwan87dZgCB GjdI7tw5PjWnbDNyDwwm/OefXbn5+sSFkoD8F0TJAxwCmeNxJbjD7KbBL2+zOc/ja jfepkd80hRIhbQltSjuqoB1HJ7ZkWdSaz7Nh8BJdlQX+JVOCuuwpGGC8ERr3UKNAM HtgtFcGXBypfpoqWy3kwQ0kGnRkOw2gAZF+GWVRVxLuKZycORxXuVuCFJemfZuAzR mtkMdOjYNjovhFt4SJVpnnE1tJa5wveB9H5/5oV64M7DyhZB++TFBFuuM1jod7kRm Q9xBinfgTRkXnWAxbw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.201.136]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MTOli-1tYZqC35A4-00U4gq; Fri, 28 Mar 2025 01:49:32 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <8634f0dkhq.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> Date: Fri, 28 Mar 2025 01:51:03 +0100 Message-ID: <87ldsq7zbc.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ElsFRiSRAiq2el/n6kelZXhwsk2Z4opaFHMrhQItPo0dx7A9Tcq VMY2euJq0/5eOU6i+yA70dltqPUg4E6GM4fQNTG28T+HLrX7gW3kyxpVV+PbzWEkZRHOZfJ FQcWS7bs1IesnKyG9CVsiYSEGaz2CHj0/ZHmHGKQfhqSo/uG0e/u7ni0dV3geVvN2eH8VUq IkCN31ClyP5MmauuevGHg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:fdzsq2nvuEA=;asMHFyXPb7tBhLHIj36VxrrOska nEqm18BO+IrLPdqVfYtS0/otIfrhm+y9doxOv5/woj+DdSQ8nPyP7/QaIP6MfQb3DFQk1V2Z+ 78db6+iduBfwP9+nd7OGooN+vC/QybP0B7rMTMpWfKiUg0aNiXnemwMhDZafGzPE2rJXLfFxY 3jwGMI7yfqfC27Gqj9Gal7FG8u4m65r7W3rRGtc8hhuNiIW3Kl71AHhgoUwInxKKGm4wzOCkX 3knUmwNsTw3d1jIRnBieHdhDkmkVLl6yyNWPbQNFZJdmRBaE6X9DT9VyC4LlKQcR27REmIfHI s4pfPaB2wdg0kGvAX/xjZL5Z0ETQZdo5lSzO/25dyt439VhK7S2BpHps3/9WgCzTECshD4MWW GNhy0YYlPtCnZnprjn3pf6A2bJEQSdLgfPfIQYFoxOCd8iCkZWkPcbYjgQ3B8SsfAH+YSUda9 jRSHI8X8gSzxN3YSXFFhQdnC7zs8O6IOnCk8cVL98NjMPoTA7c0c8HdyX/ppxlVRjjErS6+V4 WdATYWDhKLozofxMsmn9S3BC7fYeaOHKNny/8KFn47vqg7zuzaz0SB+Dsw1W4K8LluVYokw1k 7NdSbqGczXyb/90qE4WsSqpr5MAZ5dCZjJHfY7hNbGPWltnwh8+H4628xbEdX8tO53nzNpWFG 2PvNZ5HeER6PNH/No1x3xs4VASNhL3QqfsDMN46v7gmG64kuQVGgBnqg1AIwfwGZYGGrDAxPe loUhfkhL9qudn/Sz8shHt27NM+7Z8TtQexrt8ODwEzNX95Oiguxj8g97X7VXerVqmN+cg3bPk oHfH0JE39yjwaM73ot9gUIvcbpH9/efmdpdKudDlfYWKlIy1g62jDkuXRe6Z96QKnKAy7RYRW Y+Kxbollqdf7qRfi+B7tsfR0BLN3AgHCH5jaQTFaZGN6/5hC6rdu1qeYO3Mo8XNXhGebQmhp7 jO0H//XnStDpyKXK54ZR/iHUyhVQ0eqlJIIcFadq1leGq+Xg/de7kE7XsiFYORZdPu8xMwWrz w3Vv5JwMX3ykkMCQFlXqIG/ZhWlU9g2g4UmCHdmipyP5ZzyEdT9Tl6+UIMQ03l5K1qYt+Bc3m 0OJMUi8phvRBw8N9B98vUdkvIn+uvpTVycrGji1b9NcIFGWk59Z38MwgmI47OtCBcUP8CYljJ RPEMqzmmd4tTAuUQ2AcE8XqHE8R1Tl1/0pDvCoIFagnWg0hNpek0hcyJLPJow/vA6lMQT7OXy lqv5TRSALCfERZsNlj9L3QD1JOeB3N49BHcH0KiBtAEzB/JKLtwKb0OC5Xo9TwB88BYMUMlF6 mWck3E1YhGKMjLXloE5mIcahlnFKr/3Sy/blKARFbRdyRAa7SRGgAa3F1H+5dLJKdf6kj7xGy 2yjhfsYn1fuR9fQbgKkPsJmSpYARaepzXKiCpqp4Zwar0F8LPJYdfePofBXxZl6yOvug0Ge5h vF9S5RyeUt5dJ6L7ilAaYJSYIgsM= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > Would it be better to use an idle timer instead? post-command-hook > tends to make Emacs sluggish. post-command-hook is the most general, and thus the simplest way to implement something like this, but not necessarily a good way. A solution using such a general tool like post-command-hook also comes with problems. What if something adds something to post-command-hook that changes one of the conditions that should trigger a cursor type change? And yes, obviously, the conditions are checked much too often when using post-command-hook, and yes, people will complain because they are will add conditions where checking is not that cheap. Timers are a bit better, but are also far from optimal. I would really prefer to use other hooks. If we miss a hook, let's add those hooks we miss. Nearly all uses of hooks could be replaced by adding something to post-command-hook, but the other hooks are there for a reason. What's different in this case that justifies this measure here (the question does not go to Eli, obviously)? If we can't use other hooks, are there other alternatives? Variable watchers have been mentioned - would using those be possible? Or, could we at least try to use the buffer local binding of post-command-hook, at least for conditions that are buffer local anyway? Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 02:49:07 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 06:49:07 +0000 Received: from localhost ([127.0.0.1]:52535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ty3Wc-00005T-Hs for submit@debbugs.gnu.org; Fri, 28 Mar 2025 02:49:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34402) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ty3WW-00004r-So for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 02:49:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ty3WP-0004dB-Mx; Fri, 28 Mar 2025 02:48:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Qy0bSPaDOR/FadewCm5OWfV0F+OECa8d0HAchJZjgVM=; b=GA3q9KiLyptc 01fOOFqwynJUYoz8V3UUjlspmDsI6P71VH75cOlcZTlKOs00zmeTK5kSnw5PBOOkP3q0lA2KbLC7v GwwuLuXW8b+OtIeB1HnbbTc9vsl5ATLVXrcf4Opu608JOuzU3dHVAWWu2OGZZwS9QTtLACfay34lH E+pjnmQg6lXmM+iCEmFEuUVUSTn5MTri8qyF6QSPO48jjr9g1y8WeldTRRVNtoi8n65rfX3AkKpCX 5gcXL1nFZdn7kIGY6PDwraWEL7yGWq2QnTKl7Fe5lV9RCOAQ5XSTgubNykqWNCA+g8gUN/+/uu08F mCkQqXeMnjCIz/w0/9knKw==; Date: Fri, 28 Mar 2025 09:48:49 +0300 Message-Id: <86bjtlbqge.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <878qoq5iui.fsf@daniel-mendler.de> (message from Daniel Mendler on Thu, 27 Mar 2025 21:17:25 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Thu, 27 Mar 2025 21:17:25 +0100 > > Here we discuss changing only the color of the cursor, a much much less > complex operation. My point is that when the list on post-command-hook is long, it takes Emacs time to process all the functions on the list, and the longer the list, the less responsive Emacs will be. These small insignificant delays add up. How long is the post-command-hook list in your production sessions? Should we poll users to give their data? Just yesterday someone complained on Reddit that Emacs is too slow, and I have no doubt that features that use post-command-hook are at least part of the reason if not _the_ reason. So I maintain that we should try to avoid post-command-hook for operations that should happen very rarely (this case is one such case: we only want to run this code when something is turned on or off). Even if the reaction to the change is a bit slower, it is worth our while to pay that price: users will be a tad happier with Emacs response times. And if there are alternative methods of doing the same, like the respective mode hooks in this case, we should use them without thinking twice. Ideally, post-command-hook should only be used for stuff that really must be done after almost every command; for any other cases we should look for other Emacs features to do the job. Emacs is a very old program, and if we do it right, it will live a long time since. We should realize the long-run effects of (ab)using stuff like post-command-hook, and try to imagine how much more stuff will be accrued in post-command-hook 40 years hence if we lower our guards in this regard. But I repeat myself. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 03:07:15 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 07:07:15 +0000 Received: from localhost ([127.0.0.1]:52557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ty3oA-00011g-TR for submit@debbugs.gnu.org; Fri, 28 Mar 2025 03:07:15 -0400 Received: from mail-oa1-x43.google.com ([2001:4860:4864:20::43]:61564) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1ty3o6-00011D-Ef for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 03:07:13 -0400 Received: by mail-oa1-x43.google.com with SMTP id 586e51a60fabf-2a01bcd0143so2054297fac.2 for <77224@debbugs.gnu.org>; Fri, 28 Mar 2025 00:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743145625; x=1743750425; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KB3aacvJLrgHpwY6nUAQOXnQQYG5+QbRK8mJGbrv5B4=; b=j+tcKmlVmXqeCxK0d4UNfkDVNeHRPnJk38bw3vpE+EYcVBbDsyPsU9733wtdiCTP2w U47b24+Lq4J2G6pOHACNBayIEigUYNyF98Cg7Gl/kGr0LKVu128GJFLwvxId/3J7JWcx FAGuK+2qWC1cf9EX+J41PKGfhBZsFK1FxFqGxnj+1qvOCNiOLWLcAUCxTxfhIMJxxp5y 88Mch9+7pVEQKfgPjWLyfo21freDXyJsJ+mk1g1KcmgryQ+lwzfqjZ2FOGJVhbYW3zeg meNdxe5vUQWr04jFN6CdVNgqhsg7OG/GhSZ3gfF2j67ZUd34DB/yIh6s3RU/YTOfBmAj OLIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743145625; x=1743750425; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KB3aacvJLrgHpwY6nUAQOXnQQYG5+QbRK8mJGbrv5B4=; b=GDJNY2LsuRf7o4LrpMWg276zSHFf3rbfPZOP/RmhJ9uSs8ivoug6hqHIs4iX2pmCPm /Q1eYSYLSOzuVtc5AG42EBEZiwSC20tWe982frsdyBYa7kDIHvzt6auHadpiX9aCC7jb zWGVCXNmiaRBhWCKmhvu7seDtsI58F4Al53N0uYFS+GN3LioMGkCVrNqQzVMawRiOg3S mbhCvhtpBtPwO8wPr+q8tnW41B3WxWvhn5Eoi+v/YQZf8fj3RhX8HmxfuJMF9xLKTXIA T5I6kSv7xL7zqHhIB6VswLO9GpC9PrymqNluF5EMJwXdfHrWhNwnTMVtl85UAcLxZNMR qQTw== X-Gm-Message-State: AOJu0YwqqubFPc2x8WZK5njBIwwskiF/a7ChIMGat9dgy7UIAUd9a7BO fnrwV0y9CUlW15m7qc6ubYaNliUVXmPfuc6+3WkZlBs/tJlzveOU X-Gm-Gg: ASbGncsoXxVE1OxAzmddzDAM8IzikQtxTfzgFgOwJnL69Kqp+xJb0wtnDe4C207UFdM ZVo99qNl9/SikYcQ1CEa267o1wh+qBEZatvM7xItB2JLvEFxFYNkD/q/jUYod1Epc5I27UWA6LW Y0sDLmcWa5+budWtcD76xHOltV4iv33bRtLJrutJ0kyG3wOz/0+Q4ElgQe4fenNRkcOzVYpEWly pmhjlYxV4hr6qk5KBkTWCoycsN09NWzWywSSgZSPd6ZtbikUFZ+VsH3IbBfNsTvAjcjN3tO4Thj 37FIwOmrQLLm X-Google-Smtp-Source: AGHT+IH2QqZZjr3YNgEPEinE884lzBL6vjaK0m9AGFFYhE7n9pso20rUHnt3B8x3qgwPLJNV0YeCKQ== X-Received: by 2002:a05:6871:1cc:b0:2a3:d9b3:3d01 with SMTP id 586e51a60fabf-2c8481de2d5mr4653294fac.29.1743145624451; Fri, 28 Mar 2025 00:07:04 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2c86a855d21sm307927fac.34.2025.03.28.00.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 00:07:03 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Daniel Colascione Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> Date: Fri, 28 Mar 2025 01:07:02 -0600 Message-ID: <87a595tyzt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eliz@gnu.org, juri@linkov.net, mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Daniel Colascione writes: >>Anyway, I think making the cursor change from a mode hook is a better >>solution. I've updated the patch which should use the mode hook instead using =post-command-hook= or idle timers (and allows (implicitly) to user use post-command-hook (but that is user responsibility add it or not)). Also this should refresh the cursor while switching windows. However I've deleted the function/lambdas support as conditions because i found it problematic. I've test it only for overwrite-mode, I ask if anyone wants to give it a try. --==-=-= Content-Type: text/html

Daniel Colascione <dancol@dancol.org> writes:

Anyway, I think making the cursor change from a mode hook is a better
solution.

I've updated the patch which should use the mode hook instead using
post-command-hook or idle timers (and allows (implicitly) to user use
post-command-hook (but that is user responsibility add it or not)).

Also this should refresh the cursor while switching windows.

However I've deleted the function/lambdas support as conditions because
i found it problematic.

I've test it only for overwrite-mode, I ask if anyone wants to give it a try.

--==-=-=-- --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-New-package-cursor-indicators-mode-Bug-77224.patch Content-Transfer-Encoding: quoted-printable >From 275d3ca5fcea03890e422b845477735f3c30d9ad Mon Sep 17 00:00:00 2001 From: =3D?UTF-8?q?El=3DC3=3DADas=3D20Gabriel=3D20P=3DC3=3DA9rez?=3D Date: Sat, 22 Mar 2025 22:56:01 -0600 Subject: [PATCH] New package 'cursor-indicators-mode' (Bug#77224) This minor mode changes the cursor appearance to indicate buffers states, such as if overwrite-mode is active or current buffer is read-only. Acts similar to 'cua-enable-cursor-indications' * etc/NEWS: Document new package. * lisp/cursor-indicators.el: New file. --- etc/NEWS | 10 +++ lisp/cursor-indicators.el | 164 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 174 insertions(+) create mode 100644 lisp/cursor-indicators.el diff --git a/etc/NEWS b/etc/NEWS index cc63d03eafe..2745d467722 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1566,6 +1566,16 @@ This user option replaces 'follow-mode-prefix', whic= h had to be set before loading Follow mode. This new option allows you to change the prefix even after it was loaded, using 'customize-option' or 'setopt'. =20 +--- +*** New package 'cursor-indicators-mode' +This provides a new minor mode, 'cursor-indicators-mode'. +This mode changes cursor appearance (color and/or type) to indicate +different buffer states according to 'cursor-indicators-conditions'. +The mode have cursor indicators out the box for: +- Overwrite mode +- Read-only buffers +- Input method activation + --- *** cdl.el is now obsolete. Use 'shell-command' and 'shell-command-on-region' instead. diff --git a/lisp/cursor-indicators.el b/lisp/cursor-indicators.el new file mode 100644 index 00000000000..c97e6d0748a --- /dev/null +++ b/lisp/cursor-indicators.el @@ -0,0 +1,164 @@ +;;; cursor-indicators.el --- Cursor indicators for some states -*- lexica= l-binding: t; -*- + +;; Copyright (C) 2025 Free Software Foundation, Inc. + +;; Version: 1.0.0 +;; Author: El=C3=ADas Gabriel P=C3=A9rez +;; Package-Requires: ((emacs "26.1") (compat "30")) + +;; This program is free software; you can redistribute it and/or modify +;; it under the terms of the GNU General Public License as published by +;; the Free Software Foundation, either version 3 of the License, or +;; (at your option) any later version. + +;; This program is distributed in the hope that it will be useful, +;; but WITHOUT ANY WARRANTY; without even the implied warranty of +;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;; GNU General Public License for more details. + +;; You should have received a copy of the GNU General Public License +;; along with this program. If not, see . + +;;; Commentary: +;; This package allows changes cursor appearance (color and/or type) to +;; indicate different buffer states such as if current buffer is +;; read-only or if overwrite mode is currently active. +;; +;; Usage: +;; For use this mode enable: cursor-indicators-mode. +;; By default it will set cursor color if overwrite mode is currently +;; active, if buffer is read-only or if input method is active. +;; +;; To change this behavior customize `cursor-indicators-conditions'. +;; For example, change cursor type to bar when there is a region active: +;; (setopt cursor-indicators-conditions '((use-region-p . bar))) +;; Or change both cursor color and type when current buffer have a +;; specific name: +;; (setopt cursor-indicators-conditions `((,(lambda () (string-prefix-p " = *" (buffer-name))) +;; hollow "yellow"))) + +;;; Code: +(require 'compat) + +;;; User options + +(defcustom cursor-indicators + '((overwrite-mode-hook overwrite-mode "red") + (read-only-mode-hook buffer-read-only "green") + (input-method-activate-hook current-input-method "blue") + (input-method-deactivate-hook current-input-method "blue")) + "Alist of conditions to which cursor should change its appearence. +Only used when `cursor-indicators-mode' is enabled. + +Each element is an alist entry in one of these forms: + (HOOK CONDITION COLOR) Change cursor color + (HOOK CONDITION TYPE) Change cursor type + (HOOK CONDITION TYPE COLOR) Change cursor color and type + +HOOK must be a hook where conditions will be trigger. +CONDITION must be a variable that must return non-nil. +COLOR is a string specifying the cursor color. +TYPE specifies cursor type. + +Valid cursor types are: + `box' - Filled box + `bar' - Vertical bar + `hbar' - Horizontal bar + `hollow' - Hollow box + +Each element in this alist takes predominance according to its order. + +If none of the conditions return non-nil, the cursor will use default +cursor type and color." + :group 'cursor + :version "31.1" + :type '(alist :key-type + (variable :tag "Hook") + :value-type + (group + (choice :tag "Condition" + (const :tag "Overwrite mode" overwrite-mode) + (const :tag "Read-only mode" buffer-read-only) + (const :tag "Repeat mode" repeat-in-progress) + (const :tag "Activated input method" current-inpu= t-method) + ;; User-defined conditions + (function :tag "Variable") + (variable :tag "Function")) + (choice + (color :tag "Color") + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (group :tag "Color and Type" + (choice :tag "Type" + (const :tag "Filled box" box) + (const :tag "Vertical bar" bar) + (const :tag "Horizontal bar" hbar) + (const :tag "Hollow box" hollow)) + (color :tag "Color")))))) + +;;; Internal Code + +(defvar cursor-indicators--default-cursor-color (frame-parameter nil 'curs= or-color)) + +(defun cursor-indicators--change-cursor () + "Helper function to `cursor-indicators--update-indications'." + ;; Check if KEY is non-nil + (dolist (el cursor-indicators) + (let ((con (nth 1 el)) + (type-or-color (nth 2 el)) + (color (nth 3 el))) + (when (and (symbolp con) (boundp con) (symbol-value con)) + (cond + ;; Set cursor color + ((and (stringp type-or-color) (not (equal type-or-color (frame-pa= rameter nil 'cursor-color)))) + (set-cursor-color type-or-color) + (setq-local cursor-type (default-value 'cursor-type))) ; Set to = default cursor type + ;; Set cursor type + ((and (symbolp type-or-color) (not (eq type-or-color (default-val= ue 'cursor-type)))) + (setq-local cursor-type type-or-color) + (set-cursor-color cursor-indicators--default-cursor-color)) ; Se= t to default cursor color + ;; Set cursor color and type + (color + (when (and (symbolp type-or-color) (not (eq type-or-color (defau= lt-value 'cursor-type))) + (stringp color) (not (equal color (frame-parameter ni= l 'cursor-color)))) + (set-cursor-color color) + (setq-local cursor-type type-or-color)))) + ;; And exit from loop. + (throw 'c-i-exit t))))) + +(defun cursor-indicators--update-indications (&rest _) + ;; C-I-EXIT is used here for exit from loop. + (when (and cursor-type + (not (catch 'c-i-exit (cursor-indicators--change-cursor)))) + (setq-local cursor-type (default-value 'cursor-type)) + (set-cursor-color cursor-indicators--default-cursor-color))) + +;;;###autoload +(define-minor-mode cursor-indicators-mode + "Change cursor type and/or face for indications. +When enabled, this mode changes the cursor appearance to indicate +different buffer states." + :group 'cursor + :version "31.1" + :global t + (if cursor-indicators-mode + (progn + (add-hook 'after-change-major-mode-hook #'cursor-indicators--updat= e-indications) + (add-hook 'window-selection-change-functions #'cursor-indicators--= update-indications) + ;; Set indicators hooks + (dolist (key cursor-indicators) + (let ((hook (car key))) + (add-hook hook #'cursor-indicators--update-indications 100 t))= )) + ;; Remove all hooks done + (remove-hook 'after-change-major-mode-hook #'cursor-indicators--update= -indications) + (remove-hook 'window-selection-change-functions #'cursor-indicators--u= pdate-indications) + (dolist (el cursor-indicators) + (remove-hook (car el) #'cursor-indicators--update-indications)) + (set-cursor-color cursor-indicators--default-cursor-color) + (setq-local cursor-type (default-value 'cursor-type)))) + +(provide 'cursor-indicators) +;;; cursor-indicators.el ends here --=20 2.49.0 --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 03:18:09 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 07:18:09 +0000 Received: from localhost ([127.0.0.1]:52579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ty3yi-0001Xn-K2 for submit@debbugs.gnu.org; Fri, 28 Mar 2025 03:18:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37390) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ty3yg-0001XN-IT for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 03:18:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ty3yZ-0000iP-Rn; Fri, 28 Mar 2025 03:17:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9XKdFaS5q0O+JFHNpzuePCCGtVkPwJndkt9GcEOBSKU=; b=BnAgms6t9oyR M+OSuNecRJwrpcizkVqWqhbAAD6lT1oHGtsMS2ox/24QNpglTH4PMvYCl7FG9WED9imcLix4UH6hq 1E7eMRwCUAvZhXsd08AE+v9NcFSTuDlRXj5UdJBynR9o5sYgLztsahrxukOefzt0IsfVbkH2d/VVW QgrpiKkRkw61rVqkEuf3R2nqdarbE0tggPToiDOAkNAJxLNkZMfK0VwPetaNnlUA7c6Xgl/LL6lPo LHIKxEbAcLw7kwckjuiz6kvNq6mUYQoStQQPeN1FNImxZnvc2r5cDm8ppuX0iGczMmE9wXKfKOq9l 5VqPCMFR6H3eVkLL6OtNWQ==; Date: Fri, 28 Mar 2025 10:17:51 +0300 Message-Id: <868qopbp40.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione In-Reply-To: <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> (message from Daniel Colascione on Thu, 27 Mar 2025 16:41:39 -0400) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, eg642616@gmail.com, juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 27 Mar 2025 16:41:39 -0400 > From: Daniel Colascione > CC: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net > > >> Regarding Emacs sluggishness, the `cursor-indicators-mode' is an > >> optional mode. If it increases sluggishness unnacceptably (which it > >> won't), users can turn it off. > > > >Experience shows that many users turn on a lot of features which rely > >on post-command-hook, and then complain that Emacs is slow to respond. > >Telling them to turn off features they like doesn't really work. > > Nor does telling external package authors not to use post-command-hook. Well, I could at least try ;-) Who knows, some of them might even listen... > I think there are two worthwhile approaches: 1) time the entries in post-command-hook and alert users about slow ones, and 2) provide a "do something when X, Y, or Z changes" API that authors could use when they would otherwise put something on PCH and check X, Y, and Z internally. Internally, we could DTRT and omit running those hooks when the relevant conditions haven't changed. I'd be okay with developing 1), I think it's a good feature, given the proliferation of features that use this hook. As for 2), I think we already have that: add-variable-watcher. We already use this for a small number of features. Does that fit the bill? From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 03:32:37 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 07:32:37 +0000 Received: from localhost ([127.0.0.1]:52618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ty4Cj-0002KI-6e for submit@debbugs.gnu.org; Fri, 28 Mar 2025 03:32:37 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:46043) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ty4Cb-0002JY-Qt for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 03:32:30 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8B7B344351; Fri, 28 Mar 2025 07:32:21 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86bjtlbqge.fsf@gnu.org> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> Date: Fri, 28 Mar 2025 09:25:02 +0200 Message-ID: <874izdsjop.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujedtjedtucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepgedprhgtphhtthhopeejjedvvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghgieegvdeiudeisehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhgrihhlsegurghnihgvlhdqmhgvnhgulhgvrhdruggvpdhrtghpthhtohepvghlihiisehgnhhurdhorhhg X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: Daniel Mendler , eg642616@gmail.com, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > How long is the post-command-hook list in your production sessions? > Should we poll users to give their data? I use very many Emacs features, but my post-command-hook is just (repeat-post-hook my-change-cursor) From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 03:32:37 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 07:32:38 +0000 Received: from localhost ([127.0.0.1]:52620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ty4Cj-0002KN-Ge for submit@debbugs.gnu.org; Fri, 28 Mar 2025 03:32:37 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]:50815) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ty4Ch-0002Js-OT for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 03:32:36 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id DECF2433EC; Fri, 28 Mar 2025 07:32:25 +0000 (UTC) From: Juri Linkov To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87a595tyzt.fsf@gmail.com> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> Date: Fri, 28 Mar 2025 09:30:03 +0200 Message-ID: <87msd5r4z8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujedtieelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohephedprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopeejjedvvdegseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepuggrnhgtohhlsegurghntgholhdrohhrghdprhgtphhtthhopegvgheigedvieduieesghhmrghilhdrtghomh X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eliz@gnu.org, Daniel Colascione , mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I've updated the patch which should use the mode hook instead using > post-command-hook or idle timers (and allows (implicitly) to user use > post-command-hook (but that is user responsibility add it or not)). > > Also this should refresh the cursor while switching windows. > > However I've deleted the function/lambdas support as conditions because > i found it problematic. > > I've test it only for overwrite-mode, I ask if anyone wants to give it a > try. Please note that this is insufficient for 'repeat-mode'. Currently it requires adding an advice to update the cursor on the repeat timer events: (add-function :after repeat-echo-function #'cursor-indicators--update-indications) since need to update the cursor when the timer is fired: (run-with-idle-timer timeout nil #'repeat-exit) (defun repeat-exit () (setq repeat-in-progress nil) (funcall repeat-echo-function nil)) This problem can be solved by adding a hook: (defun repeat-exit () (setq repeat-in-progress nil) (funcall repeat-echo-function nil) (run-hooks 'repeat-exit-hook)) Then 'cursor-indicators-mode' needs to add this hook: (define-minor-mode cursor-indicators-mode ... (add-hook 'repeat-exit-hook #'cursor-indicators--update-indications) Then maybe it's possible to add more hooks for other features as well. The drawback of this approach is that specific hooks make the cursor updating less reliable than with using post-command-hook. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 03:38:05 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 07:38:05 +0000 Received: from localhost ([127.0.0.1]:52652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ty4I1-0002bc-BX for submit@debbugs.gnu.org; Fri, 28 Mar 2025 03:38:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49888) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1ty4Hz-0002b3-9V for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 03:38:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ty4Ht-0003Yt-Vn; Fri, 28 Mar 2025 03:37:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=O/T81Zuzv36V222FUhesTwuNGbxgNEF1lHg/ijU4CeE=; b=BCKlNKJNB13E SI/5IK9bmOHrcnaWZKDBEqjRp2iuj4nDfb+YU6f0Z51kn5BIxOfSek1+iid6Wkjg9i+LeHOLaUrYW Twkf3VhY/Eq9abVqnMSmavXrFphnUU+4EcGoan41mlrSkTC3Pn+MidNlEHoFP37hLIzAOwLFT86E0 8TrI4n6/jMR2Kylqt1D+SZZ4dm+NdVH8A+2R25QG2odeEl2D0pKBX3+agYEo+JsmoVq4pzYHvJ7m3 EqMB1TG/n8QcAhwT9vWljSeRZL5dyKQywrI2J8UlZf/WHIk8kR89jfU1aDRyEhgL4JiWPdFFjQLij 16z0ArF7aBXnHKF2F9X+Ew==; Date: Fri, 28 Mar 2025 10:37:48 +0300 Message-Id: <861puhbo6r.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-Reply-To: <87ldsq7zbc.fsf@web.de> (message from Michael Heerdegen on Fri, 28 Mar 2025 01:51:03 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <87ldsq7zbc.fsf@web.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Heerdegen > Cc: Juri Linkov , 77224@debbugs.gnu.org, eg642616@gmail.com > Date: Fri, 28 Mar 2025 01:51:03 +0100 > > If we can't use other hooks, are there other alternatives? Variable > watchers have been mentioned - would using those be possible? Yes, if some change should be triggered by a variable, we can use variable watchers. IMO, it would be better than either the idle timer or post-command-hook. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 10:28:34 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 14:28:34 +0000 Received: from localhost ([127.0.0.1]:55041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyAhF-0005wj-Fx for submit@debbugs.gnu.org; Fri, 28 Mar 2025 10:28:33 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]:50398) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyAhC-0005wQ-9G for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 10:28:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KwdSHQmpOc/DEkqOEf9xCg1wzRTjrPA0R2SLf+wLzmY=; b=U2tCPpv+jLDTSNyr+TKYO9BHRQ ULb/6V8fHPelBLBCq06kUvbmU0/ITrDLnpmdwLt6vd481Vpp0VN1SWxv5UuLy5xdNYg44ch1uicwC kVM9dFW9uOH12p5Na1vrSy99VsoSkMm6oZ5jeGQYsUbQWoScdZOFRt8mv/InsQ/t2X0sqlyq561ew ehcQ+1MvumDuAgxq5f+p3QhNnahl5lRfKvyZp+WqGuNjjCiTGQYxwFhJq3KLPFbbrSAYU4i0+tQhV d2OYF1WimM6pcf5fg9+zyr2MadL+w08bQTV7OnicHnx2lfBbu0UyWuwyRnwGvQtjM1Qd9RfVcJgbz 2eVSWGYg==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from ) id 1tyAgf-004KBU-39; Fri, 28 Mar 2025 10:27:57 -0400 From: Daniel Colascione To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <868qopbp40.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <868qopbp40.fsf@gnu.org> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Fri, 28 Mar 2025 10:28:21 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, eg642616@gmail.com, juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Thu, 27 Mar 2025 16:41:39 -0400 >> From: Daniel Colascione >> CC: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net >> >> >> Regarding Emacs sluggishness, the `cursor-indicators-mode' is an >> >> optional mode. If it increases sluggishness unnacceptably (which it >> >> won't), users can turn it off. >> > >> >Experience shows that many users turn on a lot of features which rely >> >on post-command-hook, and then complain that Emacs is slow to respond. >> >Telling them to turn off features they like doesn't really work. >> >> Nor does telling external package authors not to use post-command-hook. > > Well, I could at least try ;-) Who knows, some of them might even > listen... > >> I think there are two worthwhile approaches: 1) time the entries in >> post-command-hook and alert users about slow ones, and 2) provide a >> "do something when X, Y, or Z changes" API that authors could use >> when they would otherwise put something on PCH and check X, Y, and Z >> internally. Internally, we could DTRT and omit running those hooks >> when the relevant conditions haven't changed. > > I'd be okay with developing 1), I think it's a good feature, given the > proliferation of features that use this hook. Yeah. SHTDI though, and I'm not going to be able to get to it soon. > As for 2), I think we already have that: add-variable-watcher. We > already use this for a small number of features. Does that fit the > bill? No, because variable watchers are synchronous --- also, they're hacky: they let you run arbitrary code at nearly arbitrary points. Like advice, they're a last resort and a debugging aid, and ISTM if we're using them to implement features, something is wrong. I think we're conditioned to understand that named functions can be advised, but most people aren't thinking of arbitrary variable assignments as extension points. The feature I'm proposing is higher-level than that. For example, for my personal use, I have something that sits in pre-redisplay-function and scans all the windows for applying highlights based on current buffer and window selection. I should have written this thing using the appropriate window configuration change hooks, but didn't, because I'm lazy and my approach is fast enough for me. ;; Don't do this. (defun window-highlight--pre-redisplay (_window) (window-highlight--rescan-windows)) (add-function :after pre-redisplay-function #'window-highlight--pre-redisplay)) What I'd have wanted instead is something like this: (run-when-changed (list (selected-window) (selected-frame) (frame-focus-state)) #'window-highlight--rescan-windows) Here, we'd run window-highlight--rescan-windows only when one of its dependent conditions (e.g. selected frame) changed. After any number of window and frame changes, we'd run window-highlight--rescan-windows *once*, immediately before its effects would become user-visible (e.g. just before redisplay, or after commands), and we wouldn't re-run it until one of its preconditions changed. It's certainly possible to do the same coalescing and change detection manually, but it's inconvenient. It's easier to just throw something in pre-redisplay or post-command-hook, so that's what people do. Level-triggered control is easier to reason about than edge-triggered control. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 11:40:41 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 15:40:41 +0000 Received: from localhost ([127.0.0.1]:55243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyBp2-00015M-Lz for submit@debbugs.gnu.org; Fri, 28 Mar 2025 11:40:41 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:44849 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyBoz-000154-Co for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 11:40:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZmIkepyiU2y96Ah/oqA2K/FyCmK11CqqYrgm7VlbmB8=; b=BiQHt8mT3YFRKlhuRmDat1GNtL FojHwQlOrzmw0X27MZQlnFMLPuVrWqPq+nAViddVwYLVRA7vRQkAIdGjFKa9HY/uAdbi3Dt3pqIol NPjnQpn5fXashfzPdVvHPA4Gu1wua/lWA1rDBCDCY2vnIyTkf3XIAJwZpFghQcbYxNRw=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86bjtlbqge.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Mar 2025 09:48:49 +0300") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> Date: Fri, 28 Mar 2025 16:40:29 +0100 Message-ID: <87msd5rwnm.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Thu, 27 Mar 2025 21:17:25 +0100 >> >> Here we discuss changing only the color of the cursor, a much much less >> complex operation. > > My point is that when the list on post-command-hook is long, it takes > Emacs time to process all the functions on the list, and the longer > the list, the less responsive Emacs will be. These small > insignificant delays add up. I see your point. But not only the length of the list but also the weight of the specific hook functions matters. A handful of insignificant delays add up, but will still stay insignificant. There are not that many hooks installed in the PCH list (see my list below). In the reports where users complain about slow Emacs, it seems more likely that one bad hook outweighs all the others. > How long is the post-command-hook list in your production sessions? > Should we poll users to give their data? Just yesterday someone > complained on Reddit that Emacs is too slow, and I have no doubt that > features that use post-command-hook are at least part of the reason if > not _the_ reason. Indeed. PCHs are a common reason for slow down. Even worse are functions which run during redisplay. Heavy custom mode lines seem to be the main problem here. My `post-command-hook' list looks like this: Buffer-local: (jit-lock--antiblink-post-command eldoc-schedule-timer corfu--auto-post-command jinx--reschedule whitespace-post-command-hook hl-line-highlight t) Global: (ibuffer-auto-update-changed repeat-post-hook) I don't have any problems with these hooks, since they are either cheap or only schedule some timers for more expensive operations. At least I don't notice any sluggishness and the PCHs don't appear in profiles. Daniel From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 12:02:35 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 16:02:35 +0000 Received: from localhost ([127.0.0.1]:55279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyCAE-00021U-Pm for submit@debbugs.gnu.org; Fri, 28 Mar 2025 12:02:35 -0400 Received: from mail-qk1-x735.google.com ([2607:f8b0:4864:20::735]:57771) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyCA9-000211-68 for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 12:02:32 -0400 Received: by mail-qk1-x735.google.com with SMTP id af79cd13be357-7c55b53a459so239309185a.3 for <77224@debbugs.gnu.org>; Fri, 28 Mar 2025 09:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743177743; x=1743782543; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LiKQ6OhYd6nShG+nQ9B5Xxjr4M0Mf6i9mYrCm8H5lE8=; b=CxfbTdSg7J9KG4oLE/3O+rubj/VAEWb0pwbdSYrXCXSnkIWvaIcOnV7u+bQgXbmdbH 8apmYwLGzw0/f2QbZ8iUxs0OUfOyV/QFZiHtcN9LI7G6E6zAKE+YvbiaFl5YLX/1kwq7 jCw1khvJ48TIJs78z4H+2sZH8oArvlzly8vCjw4HRlpnjtN38O2tUTr+8i3pE4V5aSje 3epqLfLceFD5ZM0uEr5Rh+D8ERodHQUFZ8fdYeOuRL32dDb6FBOpH/BdmJcamn/5MHgU /Yr5ccCsKUR+2OOL9LBZEQ22AsHBtWh6OIHX9fDVeSXtoiUzpYF0JyQaDH3PJi/oFTUk DJkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743177743; x=1743782543; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LiKQ6OhYd6nShG+nQ9B5Xxjr4M0Mf6i9mYrCm8H5lE8=; b=kV2o1W9yd5z0MRHU9SdSgFmrwCddOVkTNEgC1PBo2IP+R9AG6PPuhpYJQdKQn1oWvy AfoxyPWYsNHCOpQVyMv/czoy44EphhbAKF0I9Gxerl5BQDVHfx0Ta5jrB4mSQMx0jMJR i29oDs7Rw01LR5zZEf3yNLG6DUCYgB2Wlm1jpcdNvERksXnQLTz96w/CdbpYcj+ZxyPc fdoIyR6k35G1R4TIDyYIyAg5clCQvk7otfFnnOWot4i766fvUoY1mOzDXhkUX7/b0czx wMBh3f+JsuN9e664MHD4yAXCJJ/O5VFj0mBshlfcTR7DONhNeEx7tevqIGxjgt7/ELgS KHxA== X-Forwarded-Encrypted: i=1; AJvYcCV1FRY1uBjf5r9QNUhMnJWzns6zRLNaWew185+YwdoaUXxnj70Nu7vQer5jpfxBuI6rBzbwXg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzDT30CM5GPFcyo64St/Q9+plD0OY6p+ZCy6qoUTJpywheYXWnY 4S8JCUPsJ+AzFFxiM8kWXVXwJ20BfdRlYJ8Qu4y8oOySg0DWAPMsFDZS8fCEyzXacCwaYqCQGoH s1EHsv/qaDb7HacP9rENF5fCB/kg= X-Gm-Gg: ASbGncs7kCYv1ybxqRpuWA+x5CgCfNPpQT5932XJxSjGdwz20bcGxmdIpril3h+sl4N QG5oAsE9BkNojM/iopHs7jZbGmJQ/9nRyt/wTIoXWnR9kgzfSInxAGjZS0xClRwisqogtxYzhtV VoO5aE+pBoosjkLqcDOxMsBFmx2g== X-Google-Smtp-Source: AGHT+IGqrYXd022XFC8m3cgoZn0csDywKmD9H+DS1A3KZ27c+l1HXkmj7sM4xc6Yyy1g2+noQZizbVM1huI7pjLzKSU= X-Received: by 2002:a05:620a:44c1:b0:7c5:4d2e:4d26 with SMTP id af79cd13be357-7c5eda8cd34mr1252071385a.51.1743177742615; Fri, 28 Mar 2025 09:02:22 -0700 (PDT) MIME-Version: 1.0 References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> In-Reply-To: <87msd5rwnm.fsf@daniel-mendler.de> From: Ship Mints Date: Fri, 28 Mar 2025 12:02:11 -0400 X-Gm-Features: AQ5f1JqmxXvo0IXzuZtm0_gXrITq-4Qud7nu134VYX_gvWopNiY5Dw0qLbber-o Message-ID: Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' To: Daniel Mendler Content-Type: multipart/alternative; boundary="000000000000210a280631693292" X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Eli Zaretskii , eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000210a280631693292 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 28, 2025 at 11:41=E2=80=AFAM Daniel Mendler via Bug reports for= GNU Emacs, the Swiss army knife of text editors wrote: > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > >> Date: Thu, 27 Mar 2025 21:17:25 +0100 > >> > >> Here we discuss changing only the color of the cursor, a much much les= s > >> complex operation. > > > > My point is that when the list on post-command-hook is long, it takes > > Emacs time to process all the functions on the list, and the longer > > the list, the less responsive Emacs will be. These small > > insignificant delays add up. > > I see your point. But not only the length of the list but also the > weight of the specific hook functions matters. A handful of > insignificant delays add up, but will still stay insignificant. There > are not that many hooks installed in the PCH list (see my list below). > In the reports where users complain about slow Emacs, it seems more > likely that one bad hook outweighs all the others. > > > How long is the post-command-hook list in your production sessions? > > Should we poll users to give their data? Just yesterday someone > > complained on Reddit that Emacs is too slow, and I have no doubt that > > features that use post-command-hook are at least part of the reason if > > not _the_ reason. > > Indeed. PCHs are a common reason for slow down. Even worse are functions > which run during redisplay. Heavy custom mode lines seem to be the main > problem here. > > My `post-command-hook' list looks like this: > > Buffer-local: > (jit-lock--antiblink-post-command eldoc-schedule-timer > corfu--auto-post-command jinx--reschedule > whitespace-post-command-hook hl-line-highlight t) > > Global: > (ibuffer-auto-update-changed repeat-post-hook) > > I don't have any problems with these hooks, since they are either cheap > or only schedule some timers for more expensive operations. At least I > don't notice any sluggishness and the PCHs don't appear in profiles. > I have experienced issues in the past with PCH entries and cleaned it all up ages ago and try to keep an eye on it. One culprit was the pyvenv tracker which I rewrote a private copy of to use a different method that achieves the same effect with less overhead. Out of both curiosity and to butt in on this discussion, I posted this casual survey on reddit https://www.reddit.com/r/emacs/comments/1jlyek0/show_your_postcommandhook_c= ontents_to_help_emacs/ Perhaps we'll see that the bulk of people's PCH is the usual well-performing suspects. I posted mine. -Stephane --000000000000210a280631693292 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Fri, Mar 28, 2025 at 11:41=E2=80=AFAM Daniel Mendler via Bug reports for= GNU Emacs, the Swiss army knife of text editors <bug-gnu-emacs@gnu.org> wrote:
<= div class=3D"gmail_quote gmail_quote_container">
Eli Zaretskii <eliz@gnu.org> writes:

>> From: Daniel Mendler <mail@daniel-mendler.de>
>> Cc: eg6426= 16@gmail.com,=C2=A0 77224@debbugs.gnu.org,=C2=A0 juri@linkov.net
>> Date: Thu, 27 Mar 2025 21:17:25 +0100
>>
>> Here we discuss changing only the color of the cursor, a much much= less
>> complex operation.
>
> My point is that when the list on post-command-hook is long, it takes<= br> > Emacs time to process all the functions on the list, and the longer > the list, the less responsive Emacs will be.=C2=A0 These small
> insignificant delays add up.

I see your point. But not only the length of the list but also the
weight of the specific hook functions matters. A handful of
insignificant delays add up, but will still stay insignificant. There
are not that many hooks installed in the PCH list (see my list below).
In the reports where users complain about slow Emacs, it seems more
likely that one bad hook outweighs all the others.

> How long is the post-command-hook list in your production sessions? > Should we poll users to give their data?=C2=A0 Just yesterday someone<= br> > complained on Reddit that Emacs is too slow, and I have no doubt that<= br> > features that use post-command-hook are at least part of the reason if=
> not _the_ reason.

Indeed. PCHs are a common reason for slow down. Even worse are functions which run during redisplay. Heavy custom mode lines seem to be the main
problem here.

My `post-command-hook' list looks like this:

Buffer-local:
(jit-lock--antiblink-post-command eldoc-schedule-timer
=C2=A0corfu--auto-post-command jinx--reschedule
=C2=A0whitespace-post-command-hook hl-line-highlight t)

Global:
(ibuffer-auto-update-changed repeat-post-hook)

I don't have any problems with these hooks, since they are either cheap=
or only schedule some timers for more expensive operations. At least I
don't notice any sluggishness and the PCHs don't appear in profiles= .

I have experienced issues in the past with PCH entries a= nd cleaned it all up ages ago and try to keep an eye on it.=C2=A0 One culpr= it was the pyvenv tracker which I rewrote a private copy of to use a differ= ent method that achieves the same effect with less overhead.

Out of both curiosity and t= o butt in on this discussion, I posted this casual survey on reddit=C2=A0https://www.reddit.com/r/emacs/comments/1j= lyek0/show_your_postcommandhook_contents_to_help_emacs/

Perhaps we'll see that t= he bulk of people's PCH is the usual well-performing suspects.=C2=A0 I = posted mine.

= -Stephane
--000000000000210a280631693292-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 12:32:48 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 16:32:48 +0000 Received: from localhost ([127.0.0.1]:55333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyCdT-0003N0-Mn for submit@debbugs.gnu.org; Fri, 28 Mar 2025 12:32:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55338) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyCdR-0003Mk-H5 for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 12:32:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyCdJ-0007j0-UU; Fri, 28 Mar 2025 12:32:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CjL2ybXZG+QdowPfIYO9CCBP50aVxlxYh/4flI6wfIc=; b=P2LhZiolUlIB An7l1JjOicE7K9FcwnSb91g/vRJgTCGGj/PB5hDKdsJmPd5IR4Fsqic1hMUQQBVhcxd7n/YP5L/ND o94hI/BLIC86Tkz444VWgkXDY+Z+Lill5nupoVUoY5uLQ5EYRoNJZzhyO0S0mAj/wRqX/w9UEqcGy lN5AFSR9d15f6Qm476I7JyJ3AMLC14udDYfUlCf4/LmO5XgCrdDHbwaqS9ueRAJhq8ar8E9iQlL7J 1HugZPy0xUp2Db7weIVEdKG9Y0DMssPuwdB9bijtNa8Ua5RftStkBvYT2zNn1GtW4EeLG4F1J/v4R zJR5Yq5163laWfq2Ink+dw==; Date: Fri, 28 Mar 2025 19:32:35 +0300 Message-Id: <86frix9kv0.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87msd5rwnm.fsf@daniel-mendler.de> (message from Daniel Mendler on Fri, 28 Mar 2025 16:40:29 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Fri, 28 Mar 2025 16:40:29 +0100 > > Eli Zaretskii writes: > > My `post-command-hook' list looks like this: > > Buffer-local: > (jit-lock--antiblink-post-command eldoc-schedule-timer > corfu--auto-post-command jinx--reschedule > whitespace-post-command-hook hl-line-highlight t) And in Org buffers? From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 12:49:54 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 16:49:54 +0000 Received: from localhost ([127.0.0.1]:55357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyCu2-000467-Gn for submit@debbugs.gnu.org; Fri, 28 Mar 2025 12:49:54 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:60087 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyCtz-00045s-GA for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 12:49:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QfCGtxS40BoaHNjg/bAr7VuG0/emh7rGgoS4VgUASkY=; b=unipgFxhI3A11glY+hJed1TmE0 MgU7mc2J7cxUBiFSysgZnXIFfcROrq6OdW6tQWVM6QUSPnJLjNFDg+ZrHl7QtEaJRokSs3sj7n6JL gSv4UXoxf0iSr1aJYKaEG7WQ2P90a+CvZ+kcuWhSNGEn3ERqAsKmDUsO+4ZBpqcDxFgY=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86frix9kv0.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Mar 2025 19:32:35 +0300") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> Date: Fri, 28 Mar 2025 17:49:44 +0100 Message-ID: <87frixaymv.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Fri, 28 Mar 2025 16:40:29 +0100 >> >> Eli Zaretskii writes: >> >> My `post-command-hook' list looks like this: >> >> Buffer-local: >> (jit-lock--antiblink-post-command eldoc-schedule-timer >> corfu--auto-post-command jinx--reschedule >> whitespace-post-command-hook hl-line-highlight t) > > And in Org buffers? The first list was from the *scratch* buffer. This one is from an Org buffer: (eldoc-schedule-timer corfu--auto-post-command jinx--reschedule whitespace-post-command-hook hl-line-highlight t) Daniel From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 12:58:51 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 16:58:51 +0000 Received: from localhost ([127.0.0.1]:55372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyD2g-0004VU-Tj for submit@debbugs.gnu.org; Fri, 28 Mar 2025 12:58:51 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:41988) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyD2e-0004VC-9h for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 12:58:49 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-30185d00446so3373111a91.0 for <77224@debbugs.gnu.org>; Fri, 28 Mar 2025 09:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743181122; x=1743785922; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=suLdeU+Qre03xN2jVaFzghuvZHM9i3XFgYAQdUMEYY8=; b=cQeQVns5geixko5P0jSI8kaqzP/lRgPClwLRTsw8tGqs4Uf6ZuCk7uvS5pe1aNN07Q CZxhUOYIuQKkjXB6YG/D+oe6niXNPjPheJKWquFpo3jmPbcc9oBelKPNM1pTVxOwWZAs X78ftHFeuRgHmO9kt4QB/zD+mmH4tI/+hWX6vBG9jk65dTwu+q5+IoSo1btYtGkLLq8Y 7N5N7OUXxa+b/h2DTL9appCxnQLgsclS1rPJx0AYG46JYPykfARLGp5dF3i3U4iEj5V6 usblxgfeGawLB+sFHHAXtqRqiXxaqlrKY/rT8s/xV4WEqkku4Oe7u4QYl5YH9SWHq65W UIzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743181122; x=1743785922; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suLdeU+Qre03xN2jVaFzghuvZHM9i3XFgYAQdUMEYY8=; b=VvZC6S+lffPAmg+uk8wTXWkS07ySrMPUMfxCXeo9DW2CfDbPb/nHZiMVrmTaQ3MZ9Z xmBcPbSo27KlLFRVjOXN21mRAVwCfPQTzdECAdLI0KqnKtf0tekBoLmsEshDL9YIwdqi XldC8JTSICXhTBVGdJYBwMuY9qVfbd6PieKR3uylVoAjfBAUndcecdpjeCDcNoXx2qtI RVWMiYGfFTvJIdDxSBrqGL6YYqnoKRTv0TozFHq4JT2yH9mR0T4Tmj57CfBSafTcxiUq 7wI6W5x1QSAKTHeJhAXT3bo4orzyXI5wGqtZgRlMKoBPn84RRX9Z4qMvE3zt37zvnHEQ kVrQ== X-Forwarded-Encrypted: i=1; AJvYcCVM1efhNh/dk28HmXO1bwAlMsdMng0l+1W+I80Gs+NF3Sll7Uuf3EHJfjj4/liDS1wCnEnDGA==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxB5I1E3jAD3mTGj0No3KbtO2RXqsOaIMr7tWWWzeUVKPy5PbsJ umdnfT6I/e3NqBMN3shBfvK58EDQkdmkLCqksWavIylZZvHUQPEH X-Gm-Gg: ASbGncvdR7Lpthjq4Z9aUxYvEtRz8QxmMM3FcSgixvGkoQSKhxnxI5N/tpIRpsTp3tL r42Ev+r7Hp6T5XWU9Vf6pypNNoLV0AS69Ib3buEsyZsuDPtumSb5lAK/3Wrda/m5Y4MbGmvFNuy vszu+mck6N/JgmHbqGt4pehh1ItF+LFx0/5pMvIq+IsqGve9YMe19MHkroRYvoJAjbigABT4/tW JTUNaWv39Nl7+5n2zOqel9oJARB6PVN9DUWIEjcaBEVzROpCdrdGHd1xVPIjzx/wQ2RMM67nqA4 YQS9X7EILARSMKEWnRNxCI5A2SiiC2FZDy4DhGa236DyvHnscMSQVA== X-Google-Smtp-Source: AGHT+IGsS4HxiZ0Kr9dnoSdzDXG4fI1/W2fsEAw/MKz3nLODJX/BLShdzHfJa+b7BCVXO6GbU6Delw== X-Received: by 2002:a17:90b:2dcc:b0:2ff:53d6:2b82 with SMTP id 98e67ed59e1d1-3051c9519damr5908488a91.11.1743181121896; Fri, 28 Mar 2025 09:58:41 -0700 (PDT) Received: from localhost ([169.231.47.234]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30516d56344sm2133497a91.17.2025.03.28.09.58.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 09:58:41 -0700 (PDT) From: Karthik Chikmagalur To: Eli Zaretskii , Daniel Mendler , 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86bjtlbqge.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Mar 2025 09:48:49 +0300") References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> Date: Fri, 28 Mar 2025 09:58:39 -0700 Message-ID: <87pli1hz28.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77224 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > How long is the post-command-hook list in your production sessions? > Should we poll users to give their data? Just yesterday someone > complained on Reddit that Emacs is too slow, and I have no doubt that > features that use post-command-hook are at least part of the reason if > not _the_ reason. Here is my post-command-hook in an Org mode buffer in Emacs 29: (yas--post-command-handler org-latex-preview-auto--handle-post-cursor visible-mark-move-overlays dot-mode-loop corfu--auto-post-command t) That's the buffer-local value. In addition, the global value is: (global-font-lock-mode-check-buffers global-eldoc-mode-check-buffers global-prettify-symbols-mode-check-buffers magit-auto-revert-mode-check-buffers c-post-command repeat-post-hook mode-local-post-major-mode-change) ----- And here are the minor modes I'm using that are installing these hooks. Modes from packages I've installed explicitly: - org-latex-preview-auto-mode: Detects and previews LaTeX fragments in Org buffers as they are typed. (I authored this mode, it is designed to be as nonintrusive as possible.) - yas-minor-mode: for Yasnippets (template expansion) - visible-mark-mode: Highlights the position of the usually invisible mark. - dot-mode: Vim-style repeat operator for text insertion. - corfu-mode: Autocompletion as you type. The following modes are from built-in Emacs packages: - font-lock-mode - global-eldoc-mode - global-prettify-symbols-mode - repeat-mode Of the remaining, I use Magit with its default settings, under which it installs `magit-auto-revert-mode-check-buffers'. I don't know why `c-post-command' is in the global post-command-hook. I haven't even edited any C files in this Emacs session. I don't know why `mode-local-post-major-mode-change' is installed either. ------ Although my Emacs isn't so slow that I can't type comfortably, I can definitely perceive some difference between Emacs' responsiveness with the above settings and `emacs -q'. I would very much like some of these to be moved into different hooks that trigger only when required. Daniel's idea for something like this: (call-on-change (:buffer :window :focus) #'my-thing) would be very useful. > So I maintain that we should try to avoid post-command-hook for > operations that should happen very rarely (this case is one such case: > we only want to run this code when something is turned on or off). > Even if the reaction to the change is a bit slower, it is worth our > while to pay that price: users will be a tad happier with Emacs > response times. And if there are alternative methods of doing the > same, like the respective mode hooks in this case, we should use them > without thinking twice. Ideally, post-command-hook should only be > used for stuff that really must be done after almost every command; > for any other cases we should look for other Emacs features to do the > job. For this reason I try quite hard to avoid using post-command-hook in my packages. Karthik From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 17:13:21 2025 Received: (at 77224) by debbugs.gnu.org; 28 Mar 2025 21:13:21 +0000 Received: from localhost ([127.0.0.1]:55734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyH0y-000851-Ll for submit@debbugs.gnu.org; Fri, 28 Mar 2025 17:13:21 -0400 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:54453) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyH0v-00084i-9M for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 17:13:18 -0400 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-7c5ba363f1aso373513685a.0 for <77224@debbugs.gnu.org>; Fri, 28 Mar 2025 14:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743196391; x=1743801191; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=Bnd5VtHEHNl9ALhd5Hwq4F9CR0ohe3QzwBu/mk302lU=; b=BSCKQ9TvHtlrxCqZmcVe5A5OA1sMmtUC/b3xFmGeCRR/jr/2VxYL9ONgolgjvvGCNI xTz1nFUN4Yk3TB59IxATCe1nZ+uEEerzCqwEwsmVl9xggstxmiCMiVva6tSTs6YVj/UQ gmtTLBD+Ae75vTTyOu7GNVujSFGxN2X93vs9JSViix+pdM8SVYtK7bJ+B4Dt3XQ0tfyV 9KjJM1tRpIri38hCIWGfNALfGVa79RzAAlBLeXCPNL37k2oojHulSRM+u7swTm48HD3q 9x75b0Vs6dMzdmEJdVYYJEtXbtvzrKr8MJM6eqbubrmuKAZDyCCKyFDgnxlNRJ4Q4MtS upGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743196391; x=1743801191; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bnd5VtHEHNl9ALhd5Hwq4F9CR0ohe3QzwBu/mk302lU=; b=K+vps+0tfZlyFmnuUUxkoZ59T1w1eip6Y3foZyY2/l2XQJ4H43pzOBKQMps/j+zH5V ePoVk8Y6aqjTf565qTmE9xiy7BApWjb4zGcUTaY+Nq1USpyXByda8KAuhCB8RdhVq8y0 CUMN0H6tpPtLs5liSefgh/pnMjx/bQeY/0d/yVwZWdKcPCHgOktS91i99rOr3utcvnAw MbFsVPE0nrKMT6CTtQ8QWDA+iu1zRjpMrwN9bUuQ92j3HtnAERpcEZ2gssV/y1VPZSTK PI27SfgJuUikMbZSoRxj22UnfaWhLPYNPWKMabCl6zlxsue5TzSqlbBAJOFuzl+Nw4On 9zeQ== X-Forwarded-Encrypted: i=1; AJvYcCUl4NEIwMHuZ5XthTYmD5zWJYCuUlVQ1Qr8NF/B3Yo0DrhfAxTpyhM621ti2GuONuhqHDYI8A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yyuq/efQ8f1glJ+HK9Zq9Kx+cEdHTv+x3vd9mkfOSqlXt8zpcMj bJ3T8fjsAcXDrs5y0eZ+eh1pjsZkFMrcMfMsHPNzoq6Yjy1Ydtzb X-Gm-Gg: ASbGncvRT8+i0q3a6CDEK8srZwE6feDpG9p5SDk2Q6k1KGIbY+8Gw4viokIVzJEBm53 jNB6y4LxLTtIRpXw1hqBIf+75CEBWJL4QHBlcbEzgePcJd4MrnwPpueApEH+M2ryXYAU1Qk1ymE 0bUtHJnLtKtjQbL4OoDJu/Tu+FdXCXH7L0pJVeJF+Iy0DJdM0SjLVEbzK1c/+DyPcEdwq6Nnqle LJcmzPDM2V6qTR6V2d/89yT4MoPiHedfhzZ8uNzVRCQDv3JR3zzctMip/+v5cF600ffpxEFKyRG zTYJoqYq5VQ3QOMSSs6enOMiW0NgmVAVLxeTM92Vatkfq5da8WMEdjA/WprjUhcbywTJxCW1YBc TgfkH X-Google-Smtp-Source: AGHT+IF1FyiQWArFvwoWLBSRI9xP+bqBRunrKo1/SWhIfn9vzxroH4yySL47JLVfpf5z8lHt+nbIbw== X-Received: by 2002:a05:620a:280d:b0:7c3:bdce:d1f7 with SMTP id af79cd13be357-7c690891588mr90037085a.58.1743196391240; Fri, 28 Mar 2025 14:13:11 -0700 (PDT) Received: from smtpclient.apple (bwi-cc2.slicewireless.net. [76.76.25.7]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5f7764e8dsm164701385a.88.2025.03.28.14.13.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Mar 2025 14:13:10 -0700 (PDT) From: JD Smith Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_5AD74124-9F29-40F5-9C93-E462796AB6EF" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' Date: Fri, 28 Mar 2025 17:12:59 -0400 In-Reply-To: <87msd5r4z8.fsf@mail.linkov.net> To: Juri Linkov References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3826.400.131.1.6) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= , Daniel Colascione , Eli Zaretskii , mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_5AD74124-9F29-40F5-9C93-E462796AB6EF Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Mar 28, 2025, at 3:30=E2=80=AFAM, Juri Linkov = wrote: >=20 > Please note that this is insufficient for 'repeat-mode'. > Currently it requires adding an advice to update the cursor > on the repeat timer events: I solved this problem by wrapping the `repeat-echo-function' and = `after-focus-change-function'. https://gist.github.com/jdtsmith/a169362879388bc1bdf2bbb977782d4f=EF=BF=BC= Emacs: change cursor color during active repeat-mode commands gist.github.com= --Apple-Mail=_5AD74124-9F29-40F5-9C93-E462796AB6EF Content-Type: multipart/related; type="text/html"; boundary="Apple-Mail=_95FE29A4-2B04-4591-9268-BE4AE14C8FA0" --Apple-Mail=_95FE29A4-2B04-4591-9268-BE4AE14C8FA0 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Mar 28, 2025, at 3:30=E2=80=AFAM, Juri Linkov = <juri@linkov.net> wrote:

Please = note that this is insufficient for 'repeat-mode'.
Currently it requires adding an advice to = update the cursor
on the = repeat timer events:

I = solved this problem by wrapping the `repeat-echo-function' and = `after-focus-change-function'.


3D"gist-og-image-54fd7dc0713e.png"
= --Apple-Mail=_95FE29A4-2B04-4591-9268-BE4AE14C8FA0 Content-Transfer-Encoding: base64 Content-Disposition: inline; filename=gist-og-image-54fd7dc0713e.png Content-Type: image/png; x-unix-mode=0666; name="gist-og-image-54fd7dc0713e.png" Content-Id: <1688FF8E-02F2-46FD-BA32-69FEE48BD037> iVBORw0KGgoAAAANSUhEUgAAAoAAAAFACAYAAAAszc0KAAAAAXNSR0IArs4c6QAAAERlWElmTU0A KgAAAAgAAYdpAAQAAAABAAAAGgAAAAAAA6ABAAMAAAABAAEAAKACAAQAAAABAAACgKADAAQAAAAB AAABQAAAAABvE1SKAAABzGlUWHRYTUw6Y29tLmFkb2JlLnhtcAAAAAAAPHg6eG1wbWV0YSB4bWxu czp4PSJhZG9iZTpuczptZXRhLyIgeDp4bXB0az0iWE1QIENvcmUgNi4wLjAiPgogICA8cmRmOlJE RiB4bWxuczpyZGY9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkvMDIvMjItcmRmLXN5bnRheC1ucyMi PgogICAgICA8cmRmOkRlc2NyaXB0aW9uIHJkZjphYm91dD0iIgogICAgICAgICAgICB4bWxuczpl eGlmPSJodHRwOi8vbnMuYWRvYmUuY29tL2V4aWYvMS4wLyI+CiAgICAgICAgIDxleGlmOkNvbG9y U3BhY2U+MTwvZXhpZjpDb2xvclNwYWNlPgogICAgICAgICA8ZXhpZjpQaXhlbFhEaW1lbnNpb24+ MTAyNDwvZXhpZjpQaXhlbFhEaW1lbnNpb24+CiAgICAgICAgIDxleGlmOlBpeGVsWURpbWVuc2lv bj41MTI8L2V4aWY6UGl4ZWxZRGltZW5zaW9uPgogICAgICA8L3JkZjpEZXNjcmlwdGlvbj4KICAg PC9yZGY6UkRGPgo8L3g6eG1wbWV0YT4KMyImCQAAQABJREFUeAHsvQecXFd59//s9LZFq2Z1y7It uahZtuVesbFNQmyKARtIQrFNC6G8YNqLQ0xP/oS8hlBfQiAxBAhgILwE44YlY4wtF0kukiVZVm+r bbNTdmb/z+/M3tXM7JR7p+zeWf+OPquZuXPuc57zvXfu/d3ntLb5i5aMyGgaGRkRn98vXdOmS5vH Y7aOZLPS23NY0um0tLW1WVnLvsJGOBqVWHvnaJ423TcpfUePyEh2rKiy++e+GNH9u4wd2NOCZWig Xwb7+8z7Kjubr+F/Z1e3qQ82wE5/71FJJoZs1yMQCErHtO6x/NlsRnqPHJbM8LBtP+z4yjwkQAIk QAIkQAIkMJEEcipvtEQIvHA4Ih6vd8wHvA9FomMiaOyLMm88KryCoXBe/hHx+wMSCAaNCCuz29hm CDWvzy+BUOhYft0WikSMmDOCcCx36TfIE9T9IWatBL8iWg+82klggTLz83u9PrUbEbsy1k45zEMC JEACJEACJEACE01gnBrKF02WM16fz3bEC4LJ6/EWiKQ2adNtasNm8qro9KiN/NTW5hm3Lf/74vfw QYsdSxCFELP5gm7syzJvIPiKkxMWxfvyMwmQAAmQAAmQAAm4gUCBAIRISqfS2l5a6FpGm3/RFGwn ZTRfJpNR7XVMfY2oweGMNpvaSIi8YX80t2oYcXSPNlN+Rm3YaYbGTunhwnqgSRg+wLatpCyGYaMo mW36HRMJkAAJkAAJkAAJtCqBAgEIcTUUH5BEIq71yYmcZDIh8cGBPDlXuaoQioMDfabfH3JCVMJm OpGwLd7Qxw79/bKjYi2TScuAfjZ97yoXb75FPdLJpAwNDo41I+NzXG3AH1tJtWdc90f9TdL9Etp/ MDkUt83CVjnMRAIkQAIkQAIkQAITTKAtfxCIVTYElGnq1A0QXbZFk2VAXxFx82mTK/YdxqCJGpJp ClYbJiJoN3JXVA6atBGNRPTPbhQz30QjWOTb43sSIAESIAESIAESmGwC4zu5qUdGtGmzby4KaDXD OnMVYiuNZtw64mUQfvWOuB2utx4QsMaGs/ozNwmQAAmQAAmQAAm4lUBBE/B4J2sTf8fs1Lu/Whrr B3jMqvN3DfDDeaHcgwRIgARIgARIgARcSaCKAHSlz3SKBEiABEiABEiABEigDgIUgHXA464kQAIk QAIkQAIk0IoEKABb8ajRZxIgARIgARIgARKogwAFYB3wuCsJkAAJkAAJkAAJtCIBCsBWPGr0mQRI gARIgARIgATqIEABWAc87koCJEACJEACJEACrUig5DyArVgR+kwCJEAC1QiYuUV1flFMMo8/t6Ws tZSmTn/lwxrsLkv5E/vDP0yU77bk9mNsMTSLDOg56EaGWLwBfprFGHRRB6apScDb0dV9W3HVcOCt nzUWTqvlBG2UDcu3WnzQM9jsbi3+VouNRtTDqgNfSYAEJo8AhMHChQvltNNOk1QqKQMDA+Jx0c0N 4q+zs1NWrlwp0WhUDh8+XNO1t9mETz31VFm0aJH09PSYVZ5qua42y0cc49mzZsuKlSt0Gc+k9Pf3 u+4Yh8NhWbFihTnWYGjuMS4S0mB44oknysknnyyDuhzq0NCQqxg269x5KdotKQADgaCEYzEJhsJG CGZ0GTUnK3rggoB9w7Go+NVWNpPVkzzriG+b1yORcExCeiH0ef1qw/mSdF6fXyKoRzgi3jaPLgeH lUmcpUAoJOFoTPCKZK1P7MwKc5MACUwmgbSu5gPh98UvflH+8i//Uk466WR58MEHXXNzg/gL6LKV //sTn5D3ve99cvnll8uWLVtkx44drolUguG1114rn/nMZ8wrxOpDDz3kGgGDqNUJJ5wgn//C5+Ut b3mLEdJPPvmkEdJuEPoQeoFAQN773vfKrbfeKi9/+culr69PNm3aZIS+G4Q0jvFFF10kX/jCF+R1 r3udnHD8Yvn9g7/XB6aUKx9GJvOaMhXKLojt4gT1+QPS3jVNIpGYhCNR8z4QyIkfWxVWG6FwVDrU RlhfIyqeYM/jsd/cgh9CLNYh0Y4OtRGRWEenCrkOFaNWXLK6Jx6vTzqmaT2i7TkbnV3qVwTr3FXf GTk0X1Cf1Do6tR7KIQIW+h5rC9u2Ya8k5iIBEmgyAUQ1zjrrLFm6dKmJDCHKdtJJJ5l1xptctC3z 8G/W7Nly9tq1Jqp23HHHySWXXOKayAvuDWgOhDDt6uoyYgDvO/Qaje/ckMBw9erVoxHelHm/Zs0a I17c4B9E/jS9J1nHtbu7W6666iojCt3CED5CmM6dO9f8Ns5ae7bMnz/fNb8TNxzHqeRDgQCE8ILY wQ8dJyT+8OQUiqhwspk8um9IhROSZcOnkbhgMGjrQoF9ILKCwfDY/ogehsIh8ep2fF89qXgLan6N HFo+mLqpALT9JKgsQqHR/KMsvBqVhCi040F1H5mDBEhgogjgmvb000/LgQMHJKhRmL1798ru3bvt Xw+a7CiuS2gO3Lp1q/j1Ooemyycef1xwQ3ZDwvUTAuupp56SZCJh+ic+rv6hGR3fuSGB4fZt20zE D5G2PXv2mCiqW/pSwj8r4of3aKJ+4oknBFE3tzCEH48++qhp+sV5iAg0fjPwl2nqEWibv2hJgZ7p nNYtARVPltDCCYH+Mr09R2xFviAAu6ZNFw86MI+KNdgY7O+TwYH+qic6yoV461AbaqCAOHxIJRO2 bETbOzRq2D7mA5qw0Xx7tOeQ7Wbcru7ppgk7n8XQUFz6j/ZU9aHAcX4gARKYVALWg+BajbAh8vfI I4/IM88845rmVcCBwJo/b55crJE/CNQHHnjACEC3iAMwhLC67LLLTOTvnnvukYMHD7pGHFjXaUR3 ly9fLo899phpXnWTeMExnjFjhmEI8XzvvfcaIeimY4yHpfPPP1/mzJkj69evl507d7rmGE/qRWQK Fl4oAPUHHtIIYKwDIf5jtR3o65Wh+OCxDRXeQfN1aBMBmoEtAYen2N6jRyStTzx2TnT8YDtUiPr9 wZwN9SWtfRD6VADaeSLGhcCvF6pOCNG8JxfUoV/rkle1SjXR5mNthm5XEZmX+rQeCe0Ua6ceebvx LQmQwCQTwHXBGt2I64JbIkP5WOCfdY1DBMZt1xkwTKuPeLiHUMCf2xIiavAT7MDQbQkiEH9IOAfz 71Fu8NUcY2WI5FaGbuA0FXwoFICjNULfvaA2uSIh3I+olxXNG81S8QUnNAZOQISN6ACQoURcUmrH SUIzMPoPoi9fJp1SARrXi3dKTdiTbygroM3OYe3L2OZpU/EJGwNjF1c7vuDkR5M4BsUgJRNDORZ2 dmYeEiABEiABEiABEnApgZICEE8A1lPJCPqg5IcDbVYEjbewYfa3uU+pbLBhnohh0L72y5nSeqj6 MwIQNpzubozgSdIMYBkxfrjtibwUM24jARIgARIgARIggUoESs40CpEDEWhSDeIP+0Fs1Sv+YMdq DqlJvRnfdTBL9ti8hrDpKBkWuY7YFH+OyDEzCZAACZAACZCASwmUFIAu9ZVukQAJkAAJkMDUJqDB F4RfEISxWuNaLfiA4E8WrWcaQMn3vZXrhGAU/J9KdaIAnNqXEtaOBEiABEigRQhAZKxavUYWLV4s hw4ekL06lc3OF14wM3G4cdBSMVYIJAxwwVyR8xcslOPmzJWYzsiBwUJJncGjV6c62r17l+x6caeZ n7El6jQqZjt1LmHUac68ObpSz7E6HUWddu3UOr1opvRphTpZx61kH0DrS76SAAmQAAmQAAlMDAEI qC6dAWP69Olmqbg58+brSliYw3KTPPv0M+rEsf75E+OR/VIwzZpfB16uOuMMWbDgeJ35o0cO7N9v Zt7AKlzBYEAnwp4uc3ViaXQS27zxSdm65VmNqGk//Rq7mtn3rracELMhXdVs9Zln6eTY83QauSNa p31mns5MVuukA0RxvOYvWGAink89vkF2bN82LkpYW+nN34sRwOYzZgkkQAIkQAIkUJUAhFDPkUNy WKN/EINYVOHkpctk5ao10q4rYm340yMmwmYN0qxqcIIyIHLZrksDXnDhxSr0grL+wQc0erk7Nw5g TNyhSVvMylxLly2TM1RUYTnBxzc85soBlhC0nbqK2YUXXWwGgq77/f2yf99ewz9fsOI4bXwyIstO OVXWnne+EYRPPbHBlXUqPh0YASwmws8kQAIkQAIk4AICx5pUp8llV1wpRw4fFggRCK58ETKZriJK FovF5IqrrpHDhw7Jw39Yb6aP8+oMHurkONesOk2fMVMu0eUE9+/bJ39Y9+BY/7pxO0zCBszHOU0j ey97+VWmGf6PWifML1lu3kurTrNm6xKOl71M9mgz93pdQ9mjU9C5OXk7urpvc7OD9I0ESIAESIAE XooEIPIQ7RvSxQd2ax+z5StXG7H1ovahc0MUEMIH8+1efMnlpn/f+t8/YCZbN0KphPjDMbTqFB8c lD27dmmT8Zm6/KvPCC231CkYCsnFl14uh3QZvPXrfm8Edznxl1+nAV3xbM9uPU6rVptJvvdpFNQN dSr326EALEeG20mABEiABEjABQQgIhK6EMFBFSRnrDnTrEZ16NDkL8MHAbj23PNNU+69v/utZEYy tgUP6oQFHlCPs845T/vV9ZkIpxsEE5qysRjF/ff+zhx9uz4h36AKWwwMOUe5oM/g0aNHbTOZ6FON AnCiibM8EiABEiABEnBIAOJioL/frB185tlrdTTt7kldlnRYm0QXn7BElp5ymtx79/8Y4eM1iybY rxjq1N/bp30FM7JaI4G7NCKI1ccmq3kbTb8naZ/LE05cIvff8zvD1674s2qNSGFfb6/5iDq9sGOb aT6erDpZfpV61Ub68QmqHs7iD++dp9w+psImDFyLjVypGCFUczL1QMi5Dhta+DEWNXvCHUmABEiA BEigLgIQF88/v0UOa1/ANWeeXZetenbGPH+RWFRWrD5Dnnpygxw5crhs/7hq5Xh9Xnlm82YzsnaV 2hsZyS28UG2/Rn+PfpXoy7hi1Sp5/NFHTRTPo7xrSThOT2/aKPH4oJy6fIVpQq7FTrP3KRkBxPq3 mLsnFI5o6LJNoPSdJI8+BWAd30h7u44ICpsDai1+bdeOz+eXmI56gh2sKZzJDDteWSSgw7dhA/Xx 6qLbw8NaDweCFsIxHI1KNJZjAS1rbNitBPORAAmQAAmQQIMIWEGZoyq4lq9cZYQXok1Oo1T1ugOx tHrNWRKJROThh9aPBUlqsWvVqafnsJyuYunw4UNGDE5GndactVY8eqN/VEdbm0EstVRI90GdMIq4 R5t/EQU8sH+vDAwMTPhxquZ+QWgM0b4gRJMOzfbp/DY+FV7R9k4jBJ1EAqMqHiOxdm1DD5gOou2d 00x7ul0bbRoWjumki/DFq+3wQRWi7R1dOhS7wN2ydUM5KLtdbfhRD7UBIRnVP7sJNiD+IITBAX8Y 5g6f7NbDblnMRwIkQAIkQAJ2CEAYIQL4zNObNVq1uubIm52ySuWB+OvS6VGWnHiybHjsUTPoA4Kn noQ6Hdp/QJtLt5tBIZMh/jD34gknnigbHn3EiLd66oN9ET08qHMG7tmzSyOla1QU1mux8fsXKCoc RET9tPE3FylTEYRtQZ2LyO4BQaUhvkzS/SGWPBpJgxCzk5Dfr4INEUAjtPQzonYQcZhh2674wlxE bRiCrftiH5gJBEPmoNjxA/UO5NXDGFAufp3MkokESIAESIAEJosAolPP6uTQMQ20LDp+sWkhmyhf 0Px76unLdUDKfjOKt1ErX0A7PLN5k3RooGXe/AVGWE5YnVQgnHr6Ctmr/SoPHjzYMFGNoNWTOjn0 zJmz9DidMKF1ssOuQACqWtLZrDPj9sMBtyu8kDcnlvLMQPlCgdlMubKK8uOj/tkR0chj5knKy616 LlcH236ARZEPcCE7fpvNajEbCZAACZAACdRNAMICU8M8oyLw9BWrTIDF7j26nsLRlQsTUi/QJdE2 PvmEbV1gp0wEmfr6+uS5Z56WldoXMKCtbhNVp+kzZqjonC+YwLmRZaJOvdoMvOW5Z+Q0FZjo79hI +3a4VspTIAChdxI6hBkHGREw/GV1dE5Ch2qr15XsjH0H4ZVIDuUqOWoDfQiTyeRYnkpvUOZwOmWG vOM94qZ4xTqCad2Oz9USPE1pfpRr2QD0xFDcfmdMsEjk8sMG/tCmn9Sh+EwkQAIkQAIkMJkEzIAQ XUotoK1SJyw50dy3m+0P7qNLTzlFDh46YJo34UMjE+xtfe5Z7a4VNYIMeqLZydRp6SlmQmpMZN2M OqG5PhgKmsjmRNTJLrOCQSBG5ChwDIUGlOH0sMQH+iWdsie8UChsDKfSgnXyVG2ZRawH1UZWB3Hg O7spnUoaH4wAVSEWHxywLUJRDvw3NrTArNZnaGjQCDq75auzktH9MOhDTRlRGh/sPyYqbRtiRhIg ARIgARJoLAHc51J6r/Vr16jjlyyRbVu3mvuek/usE4/Quoe+f2etPVf+9Mc/NGWgBnxHsAjRvwWL js+tq+vESYd5Ica6te/fylVnyB8ffkhH7cYd6RQ7xaFOmMMRg1EXLFwk27c93/Ay7PhRKk9BBNDK AOHU33tU/3py4s/6wvbriCQ12tan+w/09RohZXvX0YwQcBCffbqg9JBGJU3TskMjiGSifPiR1HA5 mpCdprSejOAAHkYIOzXA/CRAAiRAAiTQBAJoYty6ZYsEAyGZq02YzYwuZXV6llNPP12baXt1VOt+ 2+MCnFYbgmnLs88YsXncccc1NbIJnbF8xUo5oiOQD2qdmiWecZy2b91ixObMWbOaWicnvEsKQBgA iHph1G3DDT40iIWTg8K8JEACJEACJFCNAO6xWEFj+7atcsqpp9V9zy5XHlriurq6NYJ1vBnUAKFZ rz4oVxbEEia83rXzBVl2yqlaTrmc9W1HgKh7+gyZO2++bNr41Fh3s/qslt4bU+NhRRAs53fKaac3 jV3p0stvLSsAy+/Cb0iABEiABEiABNxAAIJpm04OnRNoC5sSXcpmstr371Rdtu2ArnW7q+H95Io5 YpDLs9pvbtbsOSrQFjSlTihz+cqVpj779+xpfp1UyaJOc+fOkxkzZzZkqplibk4/UwA6Jcb8JEAC JEACJOASAhi00NtzVHbqHHqn6+TQEISNTIj2TeueLguPP142Pfmk6WfYSPulbKEOR44c0YjZTjPl TKk89Wyz6nTccXNls67YUUPvMMfFo05Y93i3CmhEAd2QGnumuKFG9IEESIAESIAEXkIEMIfe5s0b JRZtN30B0bzZqIR+cqctX64is0f27dvX9EiZ5TeamJ966gnp1AUd5syb19AoIOp0+ooVsm/vnobO +2f5Xu4Vddr0xBMyZ85cmTm7uf0by/mQv50CMJ8G35MACZAACZBAixGAsMB8c5s3PSUrV55hFlJo RBUQKeuaNk0WLlosmzY9qSYnIlaW89xEAXXFk206eGK1rqTRqOlZUCfM+7dgwSLDq0ldDEviN1FA XeruxRdekFVaJ3yezDS5pU9mzVk2CZAACZAACUwRAhBIGD2L+eaW6JJmmM6t3oRIGdbH3b1rp1n1 o1EizK5fKO9ZnRg6ovMCLlrcmJU0dHirnHHm2brs3DY5pKt+TLQIQ3mIbEJYn3DiSTq/cdoujobn owBsOFIaJAESIAESIIGJJYAoYCKRMKN0V+lKGl1dXXVNC4N5cDFvXacuzfb4hse0MhMZK8uxg1ga 1DmAn3zicRWiZ0usvb2uOmFxiMU6Z2K72nnC1GlijxFKQ536e3tlo4pAzD+ISa8RlZyMRAE4GdRZ JgmQAAmQAAk0mAAiZtue3yo92l/vzLPX1mwdggTrDJ+19hzTTNqnzcsTHSmznEe5z295zkwNs+qM NdZmx6+oE9YZxjJzT+kydv061cyk1QmRTR0RPKBT+Kw+48wJGVhTCljBSiD5GRD6RcJTRa2pUTbc 4EO9LGplyP1IgARIgARIwA4B3Ctx3z148IBZexaDQzDQwYnQwf6wc+Gll2ozckZX/XjY0f52/HSS B75AvB08cMCIpYz6dGD/Pkc+YX+wuPiyK0xEccOjjzSsT6GTulh5UScM1DmqQn31mWdJUldbO6T1 c3KcLFv1vJYRgG3i8/sUkE/B19bps63Nozb85kSyhKBTR3HAfD6/7jaiJzVCpM7FKPb36lI5OT1b Q130QMEGfBmpkYXTejM/CZAACZAACdRCAOICq2f1ajPj2vPOl4SugmW3rxvu1fjDcm8zZs6Qe+++ 2yznCpuTmVB+PD4ogwMDcs5558mArhJ2WAeI2BFMEH8qROTc8y+QDm36feC+e0y/u8muE3xHfeJ6 rODbER0cgsmi7dSpUcdinADEBIztHV0Sbe+QUDgifhVxWALNtojTk8cXCGqotUvC0ZiE1QZspnXN QttJbQR1v3btw4D9Q6GQri2clQw6S9o8EXFwUYdYR64eWFsQ6/pmMTzepg0I4HatR1RD4WDhUyGZ TicnciCUbWTMSAIkQAIkQAIggIBFnwpA9Alce+55kkomVAQeEiznVk5goM+fX++T515wocyfv0Du +d1vzbJvEz3wo9wRhN9He44Y8XamCtQhFbaHDx0y2qRcnTAQJqB65PwLL5ZZs2bLfVonNP26qU5H jhxWXZKVs885TwbjAyoED1esUzk+tWwvEICqu3S0TcyMuIExiChE8fSdYE1cOwE4IyBVNAG6ZcOv 7yG+8FdNdUNoIuLWrotOQ4DhuQMns98f0JM4qRHJjC0bwVBYBWCnyYsyEQX06nIsKV3n2E6CHzHd PxSJmOywAR+wJnFKBXG1etgpg3lIgARIgARIoBkEIIoQ+Tuskw9jJC9W1EAUDcusISpm/eFeh7zz Fy6Qiy+9TDzaenf/fb8zzZNuEUoWH+iLAwf2m0EUqNNxc+dok26/RtIGjTYwddIgD9r6vJp30fHH y0VaJ9y377/3bhW0fa4Rf2N1Um1xUOsU18Eua846R2YfN8ccI0QG0UxsHR8rfyNf2+YvWlLQLto5 bboEgsGxiB+EDgRPny6WDEeqJZwwsOFRwaU7mOwYdj040Kd//VWFE8oIasSvo2u67ltYXt/RI5LU J5pq4gs2Yhr9C8diBSYQ/evVetidJLOre4Z5IrLqjXIRTu/r7bGjhauh4vckQAIkQAIk0FQCiIJN 0ylHVulgg9lzjpMeXWED/emGhuJ6L9UWv/aYio65pqVt2/PP6yjix0yUzW3iLx+SqZOuTrJ6zRqZ rRMqH9bmU9QpkRhSMevVVswOmT3rOAmqltm69Tl5SkcRZzLD5rt8O256jzpNnz5Dj9MZugTecbpq yCEj3hEhxLyB1XRPLXUpEIAQOu0dnabpNl/0DMXjqrhV9KgAqpaQBwIQoWTLhu4o/Ud7VDzhhKts A/ug2blz2gxtOj6WF8reiDcbzcCwEYpETfPtmAjVcp0IWdjo0Cgkmn6tesB3iNhBHblTrR7VOPF7 EiABEiABEpgIArh/4j7WPX26ad7tnjFTIqOtWxiJulfXwsVgkYH+AXPfbYX7G+qENF3rNHfefLO+ bjisU6poPfv7e2Xf7t26csle7S84YCKcrVSnGTpRNeoEIYhpcB5av04js8f0UKPOmQIBCKMIBbd3 TjMCDp/RbAvxBnVqC6DCD2gEL6b9CKHEEYJLqiof6OsdE1KwWy2FVcChDx/KxIFGBDGhQtRuwn5W P0a8h/8DKmLT6ZSasAcSff5i2pydG4giktL+fwPaSdM68ez6wnwkQALuIICbIP5wTcCfGxOuL273 D9zK9buabKY8xuWPAM4t8EHK/Q7wLvc7wDlnHVOLofUZudyaiuukP56xO7xHg0iIcrZaGqsTjpXW p1nR2HECEKBw0H3a3w2nBQQTnHGa0OcOwgmjdx0NIskrCD5AhGHyRghRpwknNPrtebwYhJKy3fSb Xw76HMAGEligLwETCZBA6xFA1w9cEzCoLK4Pk7io4rNbEm668DEcDpvWClx3m3Xhr7XOeJDGgDrc I9AJH601bkqWcAlqv/Mh0xzoGRM1bvETKz+EgiEzIAOtUm5jiHMQxxfNp4PaDw33YDf9TtxyHKeC HwWDQKwKmQuRCi6MCirshWflqP4KoYRRu7BRa8pmh01fhNwUMLVZQbs/fnCoU00JF+VRFjXtz51I gAQmnQBuamgq+vCHPyxve9vbpLu7Wx5//PHRKMjki0BLuLzmNa+RW2+9Vc4++2zZvHmzmcrDLVEY iL/TTjtNPv7xj8urX/1qI6K3bt3qGoEFhhDP73vf++SWW26RRQsX6oS/T5rrv1sEDET9lVe+XD7y kVvlsssukxdffFH279/vGob4nSxUbh/72MfkxhtvNKtUbNq0yTW/k0m/kEwxB3SkRpnUiCfjum0g fFvGP9ubG2Cjfidse8uMJEACjScA8XLJJZcY4YKb8Lx58+TBBx+UjRs3uiICgxvvnDlz5KabbjKv q1atkhe04/cdd9zReBh1WLzxhhvk8ssvN11qsETYQw89ZISgGwQWHvQv1cmLr7/+ehO1OnnpUtmo IvpXv/ylifrWUe2G7IrzDg8et9xysyxV38AsqTNb4KEE4tUNDPE7Ab9rrrnGRKPnz58v69etk+e3 bTNMGwKCRlxDoPUax12Djo6QAAm0CgHcYDELAG7CSHhFZA3b3ZLgE4QghIDxy0W+gRGeg+GjJVYs X93CD37AP/yZ92Bp3rnjP3MOqm8QWVZyWzcE+GX9TnAeQlTn+2v5zdepQaBkE/DUqBprQQIkQAI5 AhB723fsGBMHd955pzzwwANGBLoh8gL/MFoRKwGEtO/VuvXr5V+/+13Tz84tTcAQMM/rNCFYvH7f vn3yta99TbZpZMgt/sGPvXv3jgmWn/3sZ3LXXXcZQe2WY4y+p3t0xC0YogvCt771LV227aBr+nqC 4bPPPmui4jgfv/e978mjjz7qGv94PWssgZKDQBpbBK2RAAmQwOQTQGQIERf0E7MWgneDMLDIQGAh qgZxgMgL/tw4CASDAzAwwBogYPnvhlcwRMIUJxBb+OwWgWrxQUQN5yCONQaBgKWbEvzCwBQcZ/xO 3Oafm1i1ui8UgK1+BOk/CZCAbQIQBG4UBfkVgFCFMHWTOM33zxJZbvYPPpJh/lFz9r4VfifOasTc pQi469GjlIfcRgIkQAINIuBmUWBV0W0RK8sv69Wtwi/fv1bw0fLXja+t8DtxI7dW84mDQFrtiNFf EiABEiABEiABEqiTAAVgnQC5OwmQAAmQAAmQAAm0GoGyAhDNEPU1ReQ632I939omWsjt5TXLyQFr LVbQDwT1yC1JZ/VdcXqQ6mfhtETmJwESIAESIAESIIHmERjXBxBt/+FouwR1uSSIrpROVDmoI4Hs C7AR8eoScNFYu44e8pvlbrCGb2LI/jq+EGoBHYEEGxBvWM0jrkPSU6mko47RoXBMwjoaDHXCMm6o RzabsUcTo8d0CblwtENHQwWM/EwmEuoHWDCRAAmQAAmQAAmQQOsSKBKAupROJKrCKzZWI2s93zhE oAqp6qnNCLdgOILVpgWxN2+7zywJZ1fAYR3hWHunrkesawljf/0MIdjbc8SWgMsJyJBEOzrEM+oz bMFYf9/R6lXQHCg3HIlJRKdksJIv5jdD9xPxQUdC1NqfryRAAiRAAiRAAiTgBgJFTcBt4g8g8gft lpsuAe/9urC2Kim8rZowb1VONOb2hx2PNsP6dQFxOwn5Me8Qooh4DxGJV4hA/JltNgxhwXJoP+TH XzY7Yuphd14tRA39/pzPlg0Ua7ceNlxkFhIgARIgARIgARKYFAIFAjAnlMY3kWJpGFVRthzEHFaw UyAX9YO1PE81IxBt2Qxs5JbzsfLnRJjOj2VtqPKaUT80ZDmWKycGsUyQvXpohUW9GNvfelPsl7Wd ryRAAiRAAiRAAiTQKgQKBCCcHhoclGHtc2fNA4RZwYe0ybOEFipZx6wKtyHt72dEoKou0/9O++6h L+ExOVZy19GNbbqUT1qSiaExHyDkkmpzWGfGN2G9SrvrdxB7qWRC0jrLulUP+BWPD4wTluVMQe+C BcSvZSOjM7gn40PlduF2EiABEiABEiABEmgJAiVXAkFTKwZhQHilVUg5XgxaFRiWkkET6ohG4pIq AE0U0QESlY4S0IEoXp9Xy88YPyAqnSSPNkcHgiHtP6j1SOnSSuqH04S+gwFtAkfR6VQNLJwWyPwk QAIkQAIkQAIk0GQCJQUg1I4ltUzUDiE1hylfrCGCVlPK96NGG/X7gT6EOe9rrkdNledOJEACJEAC JEACJNAcAkWjgEcLUbFVo2Qb87IhYskVfqAZe6xafEMCJEACJEACJEACLU9gXB/Alq8RK0ACJEAC JEACJEACJFCRAAVgRTz8kgRIgARIgARIgASmHgEKwKl3TFkjEiABEiABEiABEqhIgAKwIh5+SQIk QAIkQAIkQAJTjwAF4NQ7pqwRCZAACZAACZAACVQkQAFYEQ+/JAESIAESIAESIIGpR4ACcOodU9aI BEiABEiABEiABCoSKD0PoO5iTaBcz3x+ddsYnQjaTMNX42R8dfvQIBYVjwK/JAESIAESIAESIIEJ JFBSAEL0meXP1BGsy4vl3JwmLMPm0yXlRrIjksYavmNri9i3hGXYYAfrEWfUDyxN5yyhHgFp06Xg htPDks1mnO2OEj0eCfj8RhAbFtayII4tcQcSIAESIAESIAEScAeBcQIQgqu9o1P8KpywAtpwKiUD fb1GhNlyWQWSX9ffjakNr9qCXkomBmWwv38sqmjHTigSlUg0puv4elS4ZSU+0C+JobidXU0eiNho e4cEQxGzkgfWMx7o75XhpK4HbDOa6FXhF2sHCxWyWg+sJTzQ11eTkLTtODOSAAmQAAmQAAmQQJMJ jOsDGFbRFVABh2gb/uF9JNZu2w1EzKKa36fiCQlaKxSOSiAUtCUA0WSLyB9sQPwheTxeI+Zg02rS NV+U+09tBIJhU66l9fwBFXNqE/7ZTVHDIqDZsRxcm4pJtRmJ2PPBbiHMRwIkQAIkQAIkQAITTGCc GkKzbXFCJM9uX0CINvyN5DX5Qkh6PePtFpdjfcb+bW35ro2Y8iEE7SRELk092vAul9AUjf0tUWlt r/SKaGhx8nq1HpaqLP6Sn0mABEiABEiABEigBQjkqyzj7nA6Nc5t9OGzFXnTPdFciz57+b31IMPQ BGsnQWhi/8L+em3mcyYzbFuIor9efsrZRT9Ae/0ZIWBzNvJrIupbWtrQHsxEAiRAAiRAAiRAAi1K oEAAQuQNDQ5KMjmEYcDmL5VMmG35Eb1KdcWAkfhgvw66yAkw2EzEB0z/ObtRxIyKRfT5swafZFUQ 4jMEoJ2EcuB3YjA+JlzTKggH+wf0sz0BiABmPD4oqVRCi4TgG9G+jEOmHyLln52jwDwkQAIkQAIk QAJuJdA2f9GScXoGAgr98KB7xkYBO2n2VNHn0aZknzaXIuJWHI2zC8OrNrzabAvhh6hgLcnn11HA iCqqAMxFFQsjetVsWiwAKWMioRCQzmxUK4PfkwAJkAAJkAAJkMBEEigpAHMOWLqwHrHTKBv1+IDa wI96bOj+xkQ9NnJU+T8JkAAJkAAJkAAJTDaBCiMzGiF2pooNrUcjqjLZR5vlkwAJkAAJkAAJkIAS KOgDSCIkQAIkQAIkQAIkQAJTnwAF4NQ/xqwhCZAACZAACZAACRQQoAAswMEPJEACJEACJEACJDD1 CVAATv1jzBqSAAmQAAmQAAmQQAGBCoNACvLxAwmQAAm0NAHMSZpOpSWTzZh1ygO63rnbEibdx6T5 WLEI/mEaKjclTOuV1PXU4ZdfpwrDKlFuSyldvx7ThoFhMBh0m3vm+OI4K0QJ6jF2sjrVRFQGvxMw xLHGilo4zkxTk4C3o6v7tqlZNdaKBEiABHIEcFNDetnlL5Nrr73WTDK/a9cuV918IfxOOukkedOb 3iTz5s2Tbdu2mZuwW0QgBEFHR4dcf/31cv7558uePXukv7/fVQyxeMDatWvlVa96lRHQOMZu4Yfz D8IUx/aGG26Qk5culV0vviiJUUGN7yc74XcCwfeKa14hL7/6KhnUhSH2HzjgqmM82YymUvmMAE6l o8m6kAAJlCSAiMu5554rn7ztkzJz5ky5/LLL5F3vfre8qDfgUuuflzTSxI0QBu3t7fLRj35Uzjvv PLMKEYTLT3/6U9dEYIbVxzfeeKPcfMstRhAsVQHzsY99TMDWDSILAnrF8uVy++23G5EFgfr+979f nnjiCVcwhIAOhULywQ9+UK666ioTZZs5Y4Z85StfcY3AwrG87rrr5CMf+YhEIhG5UIU+fidHenp0 UQb2GGviJWBSTJc5oqMTH+OpefTJ2al3uSfu2vdHeZYN6+ndqQ8mv/FfF7KrsR65+tdXj5r85k4k QAINI4CbLwRLd3e3iVrNnDVL5s6dayJsDSukDkPwb9q0LlmyZImJugSDIVl++umuEQa4fvq0uRdR K7wfGhqS5Sq2otFo7dfWOniV2hUi+kSNoELgDwwMmNdly5YZgVoq/0RvA7fOzk5zHoIf0vIVK4w4 xfF3Q4KPq1atMk3ng/G4zF+wQKZPny5YjpVp6hEoKQCxfFpMQ/3Rjk7xB4I1/cCDobDE2rsk0t4h nhr6ibS1eSSsF5f2ji4JR6I1PWGiXJQfUxsh9cd50nC41j/a3qksOnLL4zk3wj1IgAQmmQCifOse fFA2b95sIn6PPPKIPPP0067pw+bVZTP37dsv9957jyG1e/duufvuu10jUBHhQ4Ttt7/9rfT19Rm/ fvWrX8nRo0ddI1JxjNevX28ifni/YcMGWbdunWv6AaKv3+HDh81xTWmzL9j9+r//20QC3dIPEH06 f/nLX5rIOHqf3n///ea9G/t6TvIlZUoUX7QUHNr/g9Le2SVYh1fjXjKSyUpf7xHBCWsnzI8niEis XUVTuy6e0aY2ch2v+48esX0xQzlRFW4hCD/4oH8J7YswONBnW4x6dA3hjmnT9GLvN37Dr4G+XkkM Daq16h2rkT+gorFdRbAlYLN6Aew72qNPlClbLLQgJhIgAZcQgIBZoBEN9MF67tlnpUdvwG66sSEK hIgaolYQCtu3b3eVf9ZhhH9oyty4caOrxAv8A0NErBYvXiw7duyQgwcPuooh/AM79PXEQIutW7ca n+3cWy3+zX6Fj8cff7zM0ObpZ555xkRT3SJQm133l5r9IgEo0tE1TRC9gwBCwomZTCaM8NGNVfng ROnqnpETkHk2+nt7ZSg+UFU4GeGlUbfO7unjyuo9csj8aKr9WGDDEqFGPRpLbZIZTktvz2HbQlQH yCiLUAGL+GC/Csm+qvUY5zw3kAAJTDoBNBPiBgfh58abGq5dEKrwzU3iNP/AwT/4iShbtWtx/n4T 9R7HF8fZzccY/iHBRzcydPvvZKLOpalezrhBIG0lOno6OkFVMCIVSEX94PFUj7pZsHPlIX+BFVWj JVusrd0KXj2jfhzbOJL7oY3bfixH8btSN4hSfIr342cSIAF3EsAN163CCsRw7XP7tBsQfm5OuG6X una7xWccY7czdPvvxC3HstX9KFBUeKpLJoZyES89SXGiQoKh+VfnTbBV14w+Haa0idQSYLCR1X3R bGonIf+wRuoyppk1597YNt2O93YSfB7Jjoo+3QH7pdJJ251ZFYXWO2GKMmXq/ubpXOcRYyIBEiAB EiABEiCBViZQMA8ghE5Gh4FD/CBiN6LCDX3vEnH0m7OXYAMCDqlNbQwPZySufffs9iHEfkZoqR8e LwSgCrdUUuI635QVNkeeSgk+ZHWy12wm15SCfohJHXU1qCPDTOUq7Tz6nZow9YAv8AOjoIYGBo1A trE7s5AACZAACZAACZCAawmM6wNoeWqF0NGfotYEGxCTEJI1JVVhiCTW4wPEYE4Q1uiDOt4IFjXV nzuRAAmQAAmQAAmQQBMIlO3MUY/osvys24aqxywUZB0JETz81ZPqrkc9hXNfEiABEiABEiABEmgw gYI+gA22TXMkQAIkQAIkQAIkQAIuJEAB6MKDQpdIgARIgARIgARIoJkEKACbSZe2SYAESIAESIAE SMCFBCgAXXhQ6BIJkAAJkAAJkAAJNJMABWAz6dI2CZAACZAACZAACbiQAAWgCw8KXSIBEiABEiAB EiCBZhKgAGwmXdomARIgARIgARIgARcSoAB04UGhSyRAAiRAAiRAAiTQTAIlBSCWTrPSsXfWFruv ug6v/jOppomYcyVbNmqZzNnax7Jh1/OCfHm+186iwCI/kAAJkAAJkAAJkMCkEii5Ekg4EpVQKKyO tUkyOWTWAs7TQZUd1oxtXp9EohHx+4NmGbhEPK52EpX3K/rW6/NLJBYTr8cnw7qm79DggGSGh4ty Vf4Y1DqEo1EjRNNpXU9Y1wK2RGHlPUe/1WXkwAJ2dEE7Seh6womhuK1dmYkESIAESIAESIAE3Eqg QABCHIUiEYm1d5r1c+G0P+CXkeyIDMUHx7ZVrIyKpqgKNwgnRMwQA/T5/ZI5kpF0OmXLRpuuIRzr 6JRAQAUk9peACkGv9Pf22FsXWOvh8wekvbPLrOMLG/5AQP/3yGB/r75WT2ARicQk2tFhxTGNzayu a5xUIYj1hZlIgARIgARIgARIoBUJFDQBQ9QEg2EjbiCActEy3aYRMLuCx6PiDcLNpFEbbW1e8QdH t1WhhDJ9Gv3zq4Az5etnfWMEHKKCOZ+qGNGvA8GQtHnajtnQbUH1Af7ZSahvQPND5qFM/Fnb7OzP PCRAAiRAAiRAAiTgVgIl1BDiZYUpJ4AKt5X7hL2LLSBYZle4wW65vOW2j/PFROfgRWGUrtivcfvl bShblkZDmUiABEiABEiABEiglQkUCUD0c4ubZlZEu/CXzWbNtrY2e8Inm8lIKjFkmFg20HcvlUza 4oR9MsNpzZ8w5edseCSpNrEdn6sliLdc/uExG/A+OTQoGfXPbkok4mORP5QLFk77Mtoti/lIgARI gARIgARIYKIItM1ftKRQ2aG5VZtPg6GQ+jBihFsqoQM4bAgvy2mIJTTBot/dCESTirdhhwM40FQb DEfE5/WaQSDodwcB5iT5/D5t9o2YpuDhVEoSo8LUiQ00A+NPsUhaRWkqBSFbXYQ6KYN5SYAESIAE SIAESGAiCYwXgKZ0aEJL5OS/t+8aonC5aF1t+6Mky4b1ar/08Tlrt5HnP1SgAyE83gtuIQESIAES IAESIIHJJ1DUBGw5ZIk/fM5/b31f/fVYU21t+5uSR8XWMVvVyy2Xo3Ybef5T/JXDy+0kQAIkQAIk QAItRKCMAGyhGtBVEiABEiABEiABEiABRwQoAB3hYmYSIAESIAESIAESaH0CFICtfwxZAxIgARIg ARIgARJwRIAC0BEuZiYBEiABEiABEiCB1idAAdj6x5A1IAESIAESIAESIAFHBCgAHeFiZhIgARIg ARIgARJofQIUgK1/DFkDEiABEiABEiABEnBEoLkCEBMn15kwgXPdqW4b8KEBftRdERogARIgARIg ARIggfoJ+EqZwNTHXp/PSJ6sLuFWi/TBxMvGhoovJ+vv5vuD5eA8Hq8uAZdxvAycZcerS8m1tXnU B62HUyGo+XP18BsGWNM4JwTzJoe2CuIrCZAACZAACZAACbQIgXECEGIp2t5u1gKG8EsnUzLQ32vW 9LVbJ5/frzY6BK8j2RFJDMUlPjiAtd1smhjR9XfDxgYEHMTbYH+/pLCWr93VOFSjRaIxCYWjuhaw CsB0Wvr7eiUznLbpg4hHy461d+rayEGzD8of6O9zLiRtl8iMJEACJEACJEACJNB8AkVNwCMqmqIS jqhoUiHo0b9QOCJRFVJOomfRWIcEAiFdRK5NI3getdmun4O2bKAcr9evwqvDRBCBwOvTzx2d5tWO H8gTCIQlEms35SNe59fyIWztxu5gA/sHIxETBUQkMKRc8GfHh+YfOpZAAiRAAiRAAiRAArURKBKA beILBIosqSAL+E0UreiLkh8RscPfSF7DMUSXT5uU7Savz6vRN81vRQz1FUISdu0mv7+wPIg2n9ps s2kDgs+nwnPMh9GC4RsTCZAACZAACZAACbQygQIBCJGUGc6Mq4/p+2aJsXHfFm7IZrOmv15BpE0/ 2O0HiP2ymYzqrmyBYfiGvoAFdgtyFH4w5Y0cy42WY/g2on92Uymfsxn7+9sth/lIgARIgARIgARI YCIJFAhAFDwUH5DhdGrMh2HtO5cYHLTd7AmRNTQ0WDBoI6l951KpxJjNim9UqQ1rP72huJY5mhGv Q+rDsPYFtNMHEGIvlUzon/YZHE0Qj3Gtm93mW+SDD8Nm4EfOSDqVkuTQMZuWbb6SAAmQAAmQAAmQ QCsRaJu/aImls8b8xsjbQEgHPqgISqnoQUTOacIAEJ8/oBG3jLHhJPJmlRXQwRdebbaFCE3niVLr +2qvaMaFjTatz7DWA8LSacJAkEAwZCKHYIH6MJEACZAACZAACZBAKxMoKQBRIStSBhFVa6rfhvYk VHk6uT40hkWtDLkfCZAACZAACZAACTSaQOFIiTzr9Yguy0z9NnQcce3607hRvw/1CVCLBV9JgARI gARIgARIwC0ExvUBdItj9IMESIAESIAESIAESKA5BCgAm8OVVkmABEiABEiABEjAtQQoAF17aOgY CZAACZAACZAACTSHAAVgc7jSKgmQAAmQAAmQAAm4lgAFoGsPDR0jARIgARIgARIggeYQoABsDlda JQESIAESIAESIAHXEqAAdO2hoWMkQAIkQAIkQAIk0BwCZecBrH8S5/onUB7zAXWvcULAMRs17o+i G2EDdphIgARIgARIgARIwA0ESgpAj8ejS8GF1T9dCi6JpeB0DV6Hyefziz+oS8FlspJMJlVEZR1a EAmGQuJVO2YpuFTS8f6YBDqk9WjzegTr+MKO0+Tx+SQYCCoJZZFI6hrHXArOKUPmJwESIAESIAES cBeBcQLQq4KnvbNLIOA07CbZyLD0He1R8ZSyFYVDtCwUDkuso1ODdmhhbpNgKiF9vT26ju64ZYfL 0ojGYhKOtpv9IUTjgwMSH+gvm7/4C4i/jq4uFaEh7C5ZFaCDvb2SSAzZXloOaxmDhVfXA0bKhNNa j6OSGXYuiIv942cSIAESIAESIAESmCwC4/oAhqMx8avwyaURjcD5VIhFoeNsJY+KpYja8Hhyognq KxAMSjAYHmtKrWQIAtLv90soEhvNlhON8MGn263m2Eo2NJMEwxHxB3LiD3m96k+hXxUtqNcjEo5o mVp/K0EQhtSuLR+snfhKAiRAAiRAAiRAAi4jME4Aer3HBI/lK0RdLppnbSn/6tHIG/IWxPpG2lQQ jiuqrJE2zVtcnlq1bQNlm/LyRCtEG+x6PHkby3oAvds2FvnLz2aEbR39CfNt8T0JkAAJkAAJkAAJ TAaBAlUGkTSsfe0Q/cpPaW3+zWbt9eFDvkwmYwSUZQP27Pa/gzxDEyv6HaIZ1yR9hU1styffJFde XjVgCz5ktE+inWRYlOgzaJrClRMTCZAACZAACZAACbQqAW9HV/dtlvOWSEL0LNfvbUSSQwlHfe9g C0INUUNE20ZUEMbjA5K02/dOhRrEV0YHW6AfInzKDKdlcKAvJ+r0c7Vk9hkduIJBJEgpFbaD/X1q 254ANCxQD2069uogEojYRDwuQ/HBasXzexIgARIgARIgARJwNYG2+YuWlAxn5ZqCVYhp5K3WBBGI /nh2o4fF5aAZ2KPiK6s+QBTWknJNwTqYpd56qPDMqiBkIgESIAESIAESIIFWJzC+w99ojTI1TP1S DKMe0QVbiNZlhu1F7IrLtj7XKj6t/fFabz3ybfE9CZAACZAACZAACUw2gYI+gJPtDMsnARIgARIg ARIgARJoPgEKwOYzZgkkQAIkQAIkQAIk4CoCFICuOhx0hgRIgARIgARIgASaT4ACsPmMWQIJkAAJ kAAJkAAJuIoABaCrDgedIQESIAESIAESIIHmE6AAbD5jlkACJEACJEACJEACriJAAeiqw0FnSIAE SIAESIAESKD5BCoIQKx9Udvky2Num8mb67CB/a2/MaMO39S7vxaX41BHPRy6zOwkQAIkQAIkQAIk 0EwC4wWgEW0ifn/A/GFJtFoS9vMHgmItxebcxohZTs4fDJpXIwSdGxGv32/8qKkeysLUwx80LFB8 rSuS1OA6dyEBEiABEiABEiCBphAYtxIIlk6LdXYZ0YQS0+mUDPT15pZBsyMGVTRBtEXbO3PrCevn ZDIxug6vzSia7hOKRCQS6xCPLgeX1XWB44MDkhjCOrz2BWm0vUNC4YgBh/WJB3Qt4GFdE1hVndlW 6T8IPZ+Kx5ja8KkYRkonk2pDWej6xkwkQAIkQAIkQAIk0KoExkUAw7GYBEMRE/lC9CsYDEkkGpOR 6popx0AFZCTarhEzf86Gfg6FoxLQaKCd6JklvIz403WAofc8Pp8KShViPr8tG2i0DYbCEla/UQcT xQsEJBpr1/fjqlz62Gm54Yj6rfW3bATDYQmqoLRTj9JGuZUESIAESIAESIAEJp/AODWUi3YVRuq8 KsAgguwkrwo+r9db0HsQe8KG3eTR/T0eL3RcLmk0DuV7vPZsaHYjFvPLwzav7t8GUWkjqWwUn9c/ LqfXp34xkQAJkAAJkAAJkEALEyhQQ4hsDafT46qD5lMNe43bXmoDmkfxVyAX9UMmkymVfdw26MxM JqvFFeYfGckaGzZ1qAwPaz3yXMZ+aEp20nybyWq9i1LWZj2KduNHEiABEiABEiABEnANgQIBCK8S 8UHT1y3nYZukUykZGkTfO3sJAgv99fIFX2JoSFLaD7BAFJY11yYZFW9Dg/ExzQlhGh9QmxB1NqxA 7KG8VHJotBS1qcItPthvW8iiTNR7OH1MBKa1/2BS68JEAiRAAiRAAiRAAq1MoG3+oiV5cbJcVTAQ BAMgkIZTaclq9M1pQlMpRgCPqCBMq42CcJxNY2iO9miTLaJupSKTVc2oEjR9EbU+2D87rFFFeyp0 zDSaon1+nwkmZmBD68NEAiRAAiRAAiRAAq1MoKQARIWsgQ52+/6VglC/DZ2BT+Xp5PrQGBal+HAb CZAACZAACZAACUwGgbKjKuoRXVZF6reBEbyWtdpe6/ehPgFam9fciwRIgARIgARIgASaR2BcH8Dm FUXLJEACJEACJEACJEACbiBAAeiGo0AfSIAESIAESIAESGACCVAATiBsFkUCJEACJEACJEACbiBA AeiGo0AfSIAESIAESIAESGACCVAATiBsFkUCJEACJEACJEACbiBAAeiGo0AfSIAESIAESIAESGAC CVAATiBsFkUCJEACJEACJEACbiBQdh7AeidxtvZHJWudi89tNmqthxsONH0gARIgARIgARIgAYtA SQHo9fkkFAppnjZJJBKja/Bau9h7DQRDEggEzTJyyaG4Wc7N6azOoXDELEmHZdyS6ofT5eQ8Xq8E tR6eNq+kUgmzrrE974/l8uqSeCGtC8QofMhkjq0NfCwX35EACZAACZAACZBA6xAYJwB9un5ve1eX 4BUpGA5L/9GenHiysSwHhFI4EpVoe4dgTWEs5RYIBo0N2+voajnRWLuxg6gbbPj8AxLv7zNr8trB i7I7OrUeKkKxmEgoG5FB3X8oHrepQ0dUwIYk2tkpPq+uBaw+BFWQgsXwMNY2ZiIBEiABEiABEiCB 1iQwrg9gOBoz4g9CDn9eFT/YZlM1GdEHAZgTf6qaVLL5/UEJaCQO9qol5IH4DKkNpNw+OVHp02ic HRuaScsLq/gLwIDZB/5YflXzIfd9m/qgEUgj/nL18GlkFILYlg/2CmEuEiABEiABEiABEphwAuME oMc7bvZdSyIAAEAASURBVJO0qXgyYTQb7kFomahdXl4EDj1t4+3mZSl46/HoGsAlCmyzaQNyzQuf 8xJEG/yCbbvJ4/GOy2q2oUJMJEACJEACJEACJNCiBApVklYilUyOVgUiJyd00qmk7ahXJpMxTaSe PJEE8ZXWfnx2EkTa8PCw6WuH90h4Rd87bLe2VbOVSqVGuwwes4GmW/hnJ2ncUH1WG2PpGAtEFZlI gARIgARIgARIoFUJeDu6um/Ldz6jIgn6xqsDKLIjWUnEB2VocDA/S+X3unNOqHlMMzCEW3ygX4Vl wrZ4g2CEH/BBd5JhFWKD/f22B2BAJGZV6KHPIZqwkVKJIRlUP+w23yICCR/wisEksBUfHBAMaGEi ARIgARIgARIggVYm0DZ/0ZKS4SzTh09rNqLCp7aUa26FmBxRIek46Y5o8m3TJmn4kLORi8I5sYXm a+xlewBKCeP1syhhlJtIgARIgARIgARIYJIIjBsFbPlRj2DK2RhR0VVSW1pFVH7VKB6aYUfGmmyd iz8UYMRj5ZKqfls/i6pFMAMJkAAJkAAJkAAJTBiBcX0AJ6xkFkQCJEACJEACJEACJDApBCgAJwU7 CyUBEiABEiABEiCBySNAATh57FkyCZAACZAACZAACUwKAQrAScHOQkmABEiABEiABEhg8ghQAE4e e5ZMAiRAAiRAAiRAApNCgAJwUrCzUBIgARIgARIgARKYPAIUgJPHniWTAAmQAAmQAAmQwKQQoACc FOwslARIgARIgARIgAQmj0BJAZi/XFr+e0duYgkQswYH9qpvQmhH5RZktsrVSaSNPwVf2vqQX//8 97Z2ZiYSIAESIAESIAEScCGBkiuBhMIRCYXDRrcldA1fp+vfYgm3cDQi/kBAV+IYkaGhQUmnUo6q jzV8w9GoeH0+XVs4LQldjzgztiqIPVP+QEjrEdE1idtM+UO6rrFTEReORCUYDBktmxgakqSuKcxE AiRAAiRAAiRAAq1MoEAAQhyFQmGJdXaKR0Uckj8YNNGzxFBc1+atvhwbbETbYxKJxsbifr6gX3qP 9EhGhZydhHJiHZ25suFDICg+FYR9R3tsCrgRFY4Bae/sEo/Xa4oMqIiD3cGBPv1srx4RFaCxjq4x l/3+oCkfItAOi7Ed+YYESIAESIAESIAEXESgoAkYoiYU0YiZij8IOfyNbfMUZC1bBZ9G7EzEDDl0 f/x527AtJ57K7jj6Bcr0+QMmemjtj1eIQL9ux/fVErLAB49XfcYH/cNLIBjWaGCB5i1rCvUOan6k MRYaSQyEVBAzkQAJkAAJkAAJkEALExin6lQqja+OEVAlto/PacRSic1lt5fKWy4+V9K3EgaO7Z/3 Dm/bYMFePYzZY7sfK8XB7sd24jsSIAESIAESIAEScA+BAgGISFciPiTZbNZE/hAFy2ofvqT2fdM4 mC2v0U8vqf0GkbA//jLZjKRSSVv7I386nZJ0Mmn21f9gSPvwJbUJeTi3rYoleJpSH7LDGZMfNpGS iYT2Scya99X+MyyGNL8yseoBLrDLRAIkQAIkQAIkQAKtTKBt/qIl45RdQJtbgzp4AimZiKvosSfe LBAQTNjfDAJRQYj+g8Mq3pwkjzY5hyIx8fm8MpzWQSBqAwLMSfL7/caPNrWVSqZMXVTROTEhwVDI NB1jp4SygDBlIgESIAESIAESIIFWJlBSABZWCIKpVFtoYa6p++mlXv+pe2RZMxIgARIgARJ4qRIo aAIuDeGlLP5A5KVe/9JnBbeSAAmQAAmQAAm0LgEbArB1K0fPSYAESIAESIAESIAExhOgABzPhFtI gARIgARIgARIYEoToACc0oeXlSMBEiABEiABEiCB8QTszYo8fr+X3BZMB4NRyJgWZ2Qka6aHwTb8 WcmabgYjmPEer9Z7Kw9fSYAESIAESIAESGCyCVAAVjgCmNMQfxB+YV0buatrmnRP65I5c+fI7Fkz pUuXmovGorpMndfkG9D1ivv6+mX//n2yb99+6Tl6VI72HJWBeFy8Kga9mg9/TCRAAiRAAiRAAiQw mQQoAIvoQ/ClUildS9gn8+bMkVNOWSpnn322LD/tVFmwcKEcN3uWhFQMQvRZEb8iE2bOQ9g4eOiQ bNu2XZ599jn5wx//KE89uVH27tur9tO6rJ1f5zgk/mJ2/EwCJEACJEACJNB8AjbmAWy+E24oIZPJ mhVIZsyYIWecsVouuehCufzyy2SeRvuwjnG9KaWTWe/ZvVvuf+BBuee+++TRRzdolHCfBAIBRgXr hcv9SYAESIAESIAEHBGoIACtvm11zIOH/nGjy7A58io/c5NtIOKHVUrmqtC7+qqXy+uvv15OO+2U pkbnUOZzW7bIL3/1a/nPH/1Ydux4wUQE2Tycf+D5ngRIgARIgARIoFkEygpADF5Acrr8GvbBwAgs v+ZR8Qf9NjKS0a3OhCRs5AZQeHR/DL7IrU8M+/YT/NCmWv2X1fWI8xPspzUq194ekz97xTVyy81v l2VLl+ZnmZD3z2/bJv9+5w/kBz/8kRw8cNBEG8s1LU+IQyyEBEiABEiABEhgyhMYJwDb2jwSibWr EAkZzYZ1gAcH+mTE5jq8EFY+f0Ci7e3i9/mNGMQ6vvHBAUcwA1o+/PCqgMtkhyU+MCCpxJCjiGIk GjNrAXu0Tum01qO/TwdrDGvELydIr3r5lfLe97xTVqxYbsSmIwcbnPnJJ5+Sr33jm/Kzn//CMGP/ wAYDpjkSIAESIAESIIExAt6Oru7brE86qYmEVTRFou0aOdO4mUbw/NpHDRE4CEE7kSlE/WIdXRIM hY2ARAQO/dyGh9OmqbWaDSMgdXBER+c0FZJ+Y8Pr9akffuODnUggbARDIWlXP0wEUIOPPvS106hk r47MRXPvJz56q3zof71fFiyYb6teFqNmvc6ePVuuevkVsnD+Anly40Y5dOiwaYauxqtZ/tAuCZAA CZAACZDA1CVQIADRVBrVqFt+9MkSIElE32wkj46OReTNakLGLrCb0X52aR0Za9mrZAoRxHAkWpAF kUmIUETwqtlAY3MwHBF/MHDMhorCpJZ/uo7m/dI/fF6uvvoq0+/uWIbJfwdmp59+mpx15hrZufNF 2fHCzpaZRxCiG38Q6NYrBtbkPleeN3HyydMDEnBOwJznOO/1nMd5npsyCr+DY+d7vtVq1638vHxP AiRAAs0mUDAPibmgqcAS0eZfjQZaKas3cnxn5wKGiyHyFiRVZLhA2k24gJri87oNwiZs520qa25k rDzkzgkTXJyvvvIK+eitH5BZM2eW3dcNX5yxerX83299XW771Kflzh/80IwSzhfUbvARPoBp7qaX lZBGXDs7OyWsrxg1jfkRTR9O5NPjNqhzJKLPZSqZkqFEQuI6N2JCX3FOIR8eOuycX26pe7Ef1Xwf 95soNlDhcyXb9ditUGRDvqrkNwpws+/lAOB8x6Ax1C0ajUosFjPnPN7nZgvQvsX6Pc5vnOsJfWgd 0i4wg4Nx81vBuc75QMvR5XYSIIGJJFAgAFEwLlY+vYH7tNkVCZG7RHzQlvBCfoi0oaFBiXk7zEAQ SMF0KqkXwwS+rppwYc2oUEgk4mNRQNwo8Dmjzch65a1qA+IR/QWHtRka8/ml08Pymlf9hXz4A++V SCRSfX8X5ICY+vxnb5dZOuH0/7njq0ZAu0UE4gYIMdfV1SWnLFsqZ511phlAc9KJS+Q4nTuxu3ua aW437feGZU6E9/cPSE9Pj+zbv1927dotL764SzZv3ixPPLVRJ8/ebwQhugu4pZ52TgOcm0m9yVcT MxC4mPvRSYLYwHyS1RKEh9uYQdxj1ZxKyefLdQ+plMct3+FY4JzvnjZNTj31VLnowgtkmc4Ruvj4 42XOcbPNdQWtFLmUG2B2tLdXu3Ickj179o6e60/LU9q9Y7uO+u/V79Ba4m/xBx+3HB/6QQIk4JzA uEEgMIEnVPSZQxrWGxAufk4SAoDos+fTQSBZ/QABCGHoKKnQy82R5xttPlYbjgxAK7apAPTL29/2 Fnn/375HQnqjbLWEyOkdX/kX+cI/fElFRnZSb/TwBTfBpTpa+rWvvk4uvvgiOWHx8TqSur1mrBA4 hw4flmefe05+8cv/ll/84lf6ADFUMRoIAYpz0hJd5nydhBspeKDuN7zhdSb6mS3zO8GI+HXrHpLf P7hOReC4Z66S7PDQctqpp8grXnGVslBhgR9VUYJdRJp+9OOfqIA+4Ir5JHFMIHbfeOMb9NxYrNHf 0tcOHLNHHnlUfn7XL1zhdxHasY+oD87RefPmmTpdc/XLtd/wAolpxM9pgi0IvxdefFEee2yD/NdP fyYbNjxhzFSLljoti/lJgARIoBqBkncj3FyH9caCVMuFCUG6YRUK6PNXqw3c8EzUEPc9E/Qz/xl7 dv7DxRY3x3fccpOKv3e3pPhDPRHZefe73iGIJiASiGhPLcfEDrNKeZLanNXV1Sk33vB6I6jnaqSv EQkiH7bwd4kKyund3fLlf75jtDmtsARLgC5atEguOP88WbhwgRGLf3zkT+aGikgc7E1UghBdMH+e vP99760qCNDt4Hf33KP+5UbGV/MxpQ9N5513jp67762YVU9zefrpp01EFaJqshOOEZZNfNc7b9HI 2HEV3Vlywgnyq//+tYluT8Y5XdE5/dJ6yHjd9a/V2QLeJSdqhLuehDoiao6/lcuXm4eor3z1G3LH V//FPMyUY2BF3HGscYxxDpXLW49/3JcESOClRaCkAASCRlxg6rehos+Z7hs7eul0Si6/7FK9cEP8 oU9j6yaIQNRj9+49Ok3MXRMqckANERBE+m7/+9vkZZdf1jyQeoND02GpBGGBm98bXn+9vOdd79Rl +ebrPJO5Jrd4fEh+/ZvfyBe++I/ygg6ccdrUWqo8u9twbDJmWqHKe2TRr9VhwkNMtYTR9TX/SKoZ r+N7O60GdgZ01eFCXbvCf/Rrfcc7bpL3vvtdZX9z+E0e1gj2Ee3agAcQJHQ7QYQQ3U06OzoEqwtF o+O7nsR0wN2qVSvMQ145Xoi440HnvHPP1YeigGC6qMefeNL8Fuq/vtaFiDuTAAm0OIGyArCV64W1 dk866ST5hy98VmbOnFGxKkeP9uqT/rBpwkPT1UQnXPj7dX7C4eGsTJvWVbY5rLOzQz6tAmzX7l3y pz89VvaG1Gj/EflbtuxkuePLXzLzJTbafr49DBR59NHH8jeZ9xBC4PTOd9wst37og+MYRSJhefV1 18oiXav57Te/wzXNoeMqwg0tQcASf7d/6jbTvF/sNM7Tu393j/z27t8ZMbZ37z7zkGQJdggzPBig uX/G9BkyT6PEp2i3ibPOWqMj/M+UOXOOG3vAhsArl/AdJqf/6h1f1n6Hp5hsR3Uaq09/9vPyve// x4Q+6JTzsdJ28KBIrUSI35HA5BKYeMXT5PoiUgRB8ImPfVSfnBdWLA0DEd7x7r/RfjlH5WQVjOes XWv6tZ245ISmX7gQOXjg9w+avy26LBymqLn97z5pyi/nNCIJH9f5C298019r02dC+1o1t8kPkb8l SxbLl7/0j00Xf6hzT89RFbh7TOf4fAZoAjvllGWm6blSM+eZa86Qt/z1X8nff/qz40SiZS8nJhGN Kx9ds27gvHlZ1Jy9Qvy0KjucHzjfbrnpbSXF34bHn5B//P/+Se655z4Z1gdH1LW4vrBhdVd4YXCn DvrYIQ9q/8//+6/fFcz3eemlF8tVV16pUb21KuLKd1nAA+lb/vovx8QfjgKajz/wvr9Ve+uN3YmM dlc7Cyx2ENBggsUEzIwO1Xbk9yRAApNCYMoJQHPxvvmtcuWVl1cF+sijj8r6hx7SkXgBHY36jNyl AxBmzZwl5+qF+c1vfqNccN65Db+Rbdb+Wv/6r9+T+x54QEcGvqiRg2ETKUDz0U9++nO56KILK5YJ kXrz298qX/ryHRX7DVWtfJUMuIij2ervPvkJWb1qZZXcjfl66/Nb5cjhIzoCvVDY4sZy6SUX25q+ 5+qrrpRvf/s7sv/AATMYId8z2EH/qe5p3ejjoF+VEoFYNjArR44cMVHH/P35vjoBMA6Fjs0iUH0P d+VA1O1lL7tMbtG+w8Xpu9/7d/ns575gzg30xfXW8ACG0e7/9m/flx/96Cc6J+lppuWhlFgGR0wt g3XJixNG2S9ctECwjKRbEvxFEzW6iqxauVIuV4bo8/rDH/7E/Obc4if9IAESOEZgSglANP2iqeTm m96uXQerdx78kw4eQD8yNNXgDxexw0cOm3529953n64R/AojthB9QrPPQZ3S4QWdoHnnCy/oVCYH zBQPCY3EQbxhxZSAXgAxTQSe8hdpv5352vSDwQ2Y0gWC4hvf+o58/9//Q/bt22/ECZ7wI5Hc1CAQ Hc8++5wMDAya9YmPHaLCd7hZYGDLI9pU+sADvy85WKJwj9o+4UZ4kwpN9KOcqLRp09OS0MEPmEsw P4GT3Q74YN89vVv27N07TgCiORvTd3zx859R/adrTJcQgOCL+dve/d73aVP7o3peOJu6Jd/vl+p7 O789N7LBQ8/06dPlIx/+kHQUjWzHWt23/d3fm0FHufn+aqsBItgYJIPZER7bsME87OEcKyUCEYE/ fKRnXEE4j/GgVGqfcZknYAOum4j4/e3fvEfedOMN0qVdWZCeeeZZ8zA1AS6wCBIggRoITBkBiIsQ Lq7v0n5iiOJVSxBcW7Y+b+YqtPLiggqxgT80sUKsPfzHR+Rijcpt06ftp/WChmkcEGXEzQJ/iCFZ UhPvsXax15ub2BgX+hOXLDFP8c8+t0UefviP5kIZDhcKHJSPMvft26edyY9UFIDI26Edy2/WJioI FAg1XHwbmVC/k046Ud6qzamVmlwrlQm+6K+Epm3cyGAHc54FAkGdPDdaUljhhugdHdhRbBv1tJX0 PCih68yuOEfQhIYpPaoldN5HfqaXDgGc9699zatkua7Gk58efewx+dTff9oMUGrUAwGWzKw0Yh3X Igxu+vf/uFPOOfss85uHTzgnf/yT/9Jpk7aMe8DJ93mi3+Oad/LJJ42JP5RvBkdZF8eJdojlkQAJ VCUwZQQgonAYoXrNNVdXrTQyIMoDMVfu+gRRBQG3Q/vvYI46NEtCpGE7/ioJI1yk8YfZ/3Hz+MPD DxvBU+mCD5uDOuF2MpEbSVitEpdpk+gV2szyXz+7SyLqZ6MS/IZ4+6u/fJNZJ9mJXRwDTMly7333 y9bnt8mhg4d01Y8hQZTURFk1ShrWybk7dTqZudoR/pRly2TlyuX6eoqyGjDN8B69kRQn3JgRHbWT Xty1yzT/Yv3oUgl1q5ZQnp181ezw+9YhgGM+e/Ysef3rXlvg9BGNwN32d7eb6D9GBU9kgtj8n/+5 W9769nfIdde+0qyuc5/+tn7281+Yh09cM9yUwJCJBEigdQiUvku2jv/GU4gWiDM8vdsVQ2j+s9OE Arv4c5Isu/oQb57yKwm/fLvYD/vYSRCg1117rfzmf36rYsVeXezYRVQTTdfX6FrJTtK6devlX77+ DZ3seL1pJsO+1g0K9dJDpCknjK334Irm3hUrVmiEo92sEFJKWMPO/drcDXG3YP58GCqbfnv3PXLw 4AHlPrE367IO8YuWIIAI87nnniNLTz65wF90BcFDTT3NvgUGHXzAtQC/EQwWQ19l/I7gJ7ZZvy0H 5piVBEiABAoIuOsRssA1+x/w5LnmjNVy5RUvs71T0DRFxlzTzIeIEyIM6EtoN2Hi5AvPP9/cFOzu Uy0fBOB5eiO000wKW2CPlUre/Ndvk//3m9+ayARulvhDBAN/uGHl+ln6jSBGZ3F8D7GHJmLc3P77 1//P7GuJ53w/sf+WLVvli7oaCib3LpcwiOdrX/+mlhWwLaTL2eL2lw4BPEDifLzkoosKhBUi8v9+ 5w9z3TzsPpk1ARsGLkHw4beBh0mKvyZApkkSeAkSmBICEBfwP//zPzMLs9s9hmhqtObWsrtPM/Ph yX6eRremd0+3XQymu3mdNllBSIFBvQk2INguv/TSsk3jxWUg6vfZz3/RCDM0mZcScMX75H+2bmrV mtdw4/vPH/1Y3vM375OnntpoxKJlBwNsvvmtb8uHbv2IWWuYN0iLDF/tEMDD1xwdrHXhBecXZH/4 4Ud0qbbHzW+i4At+IAESIIEpQMBZ26YLK4yI1UxdZgv94ZymlStXOBYsTsuwmx/ia9nSk6sOACm2 d9ZZZ5q1SXfu3Om4qbrYFm6Ex+nC9qtXryr+quTnTZuf1mbfb5r+cojSNTNBKKKMX+rSYX/QgTnn rD3bTKiLwTpYHWHjpk3mWELAMrUuAZyD+C3knmdyXQZw7PFnRcEaXTtEsc84Y5XpA5hv+3f33mdG 5WNam6mW8h8YwZaJBEjgpUeguXftCeCJqV/OPPMMswqEk+J6dOmmH2lEyS0XP0S41q97SDZt2qyj hk+1XRWst3rB+efK97Zvr1sApvVGeMIJJxgRWN2BEfnmN78tBw4cHDdtS/V9a8uBKCluXJhL7T9/ /BMzyhDHD01kOeGXu5GV6kdoHef8G18lL1AWmqfHJS0Po5kte+O+d8EGiCg7HfLBrFo90ulhZV55 4IxHR77XMyk5fMWDHAQepkxCf1As39jeHjPH9Whvn66W02+mXTJTLqnfjYzyYkqWNatXm+ZV6/BZ q9I0shzLttNXXOPGjsHo+efULzC2xLUpf9QOligsXsoQ5wR+Q6V+R6V8x7GDf7Cfn7AdMwCU9VUb LbQo/T3pQxs1aD46vieBCSHQ0gIQUQL0LTv/vPNsX6xAFReqb3/nu3LPfQ9IwCURI1xsd+j8gp/R 5tSv/8sdZi1Ru2fABeefp1PW3Gk3e/l8ChRRSPSHqpae11G+iJBMFD/clJYsOUG5xPT44c5R5CFa wHXbnt27pU/FgiVscBPC8c5ksirokrZEMvY9Tkcpn7B4cWH91H5ab8aHdO3X4ptdkTeT9hECF9MM zdD57MZDGnVL64Gb/sGDByVTdNMudhwjYzGwqpxwBqs+XcqwV0WaxbzYRrnPOI4QdNN07swzNOqM QRiYguWEExab+fhCOA/V/rCK8Z06aTpW4cAgn3vuuVd6+/okqA9NTsss9sXw0r63ixcfX/DVfn2w 2alzfmJ6k8lK8A3XBfwm8YCIUxxCa7ee45gv1E7dLXHd3d1t6ogVjxYdv1Da9XcU0YmmMyoMh4aG zAwEB/R82LEdK5ds1/WNj0hfX7+pf3F0H+d+7jcF4TdiRPvJJ59oIvL5rDp0+cqF2q0FvpdK8D+T zegcqT2u/T2V8pvbSGCqEGhxAZg182OduWa1o+OBEaVousTULnYuoo6M15EZF8q7dX3Rn9/1C7nx Da+3bem0U081E1Af1Zti8Soato1oRlzoT1VbdtL6PzxsInF2xKIde5XyIBq3bNlS+ebXvyqzZ83S m06Z3CpsvvXt75jVGqz+iJjYd978uXKmRnhWrFiuTX3VzxXcdD9z+6dU7CECqEZHk96vzPyQ173m esEygs5TOcdLWXKS99j+uOG/+U1v1fkwbzGel7KCeiAy8+a/eqs8tXFTSVEM4Yz5Jr/xta/ISScu KcsctjBK9W/+9v1GZB/zpPo7zLX4oQ++X175yj+T+fPmmxVESu2F3wXm08TfdX/xSjO10h1f/br5 reBY1fMbhoDBijcLFhSOLn9aV+xBFLBs9KqUow3ehmOA1UC+/KV/kMUqipEght+t/WDvwcNXGWGF fKhXOp3SCdRPlDfe8Aad0P0SfaiZYx4sK9UJXSpQ79179shjj22Qf/v+93UKpi1jD9iwC2E+Z+4c XSFolazVOQpX6UpBC5VfLBZD0WPprbqM3Ru0j3Kl47NX5z5945vfYqK7OJZMJEACE0egpQUgLpBz 9UK0qMqav/k4cQHDPFo9+tSJC7+bEi6UeLL+0Y//S16pg1raiy6o5XxFv73Z+ndYB0PUKgDBBRfg xYsWlStmbDu4Yy3SiUrwLRqJmqXgIEoqpWm6CgHyQ+BceMF58tlP326mtYEgdJKKV4Kw9kXEDE3A TtOI7pdOZ/QPTaqlZFmhReQFZ6cJ59CsWTM1gqbL3VVIiIhGIpGKvqBZF+cWokeVElZfwbkDm07S mWeuEfRhdZLwkLL27LM1Uni6GXz0tW98q65I4LFzq3DyeES4E4lERZHlxO/a8qq61hTR6xTEMhIE PlhXOodMhE7PsTfqqhxYNxjXSLsJ0WMTQZ4xXVbqAxNG3X/q9s8aIYzTNhwJyec+/fdmhSBEbisl CMJiUVicH+dMWxuFXzEXfiaBiSDg/E42EV7ZLAMXuuO0D1y1C1G+OawR+yddAxhNx25MiKhhhY/H dALpi3VaCjsJN/ITtXl0sw7KqDXhhoKL9cyZ1UchD+mNccuWLRWjI7BX6SZVyU+ImOKoAZq+7Aii rBEh2rSk4mn+/AVmRZNKZTn9Dk1m1eXbeKvnnLNW7vjnL5WMto3PnbvRYwnCWhJ+F9US+Ng5PnaY 52xVK3H898XHeHyO8ltwzn/of31Al2bcaaYfQnNwLQmsZs6aMa7bw779+1RsZXQ75rCs5YjX4k3p ffKPJ95X8gffISr7rptvlg9/6AOjfWML7SIPhB3EZJv2u8QDDUbhlzoeud9ibn/sh+mzEEnHNbf4 HEJkMT+6iPyVzh/YRhcA0d82EwmQwMQTcKcKsskBFxD00yp14SpnAiJp+/YdJS+M5faZyO3WRfGB 36+zLQARFVm6dKmIzoOXuwHkIgdO/MaNBc2luLFWS+iDdKSnt+BiX7wP6mHHVvF++JzVfkEJXRHF yXEtZ6fU9snYdpI2xeGPqXEEECH/5Cc+bgZO7d27b6yZ0kkJOO+7p3WPux709g2oOJp88eekLsiL yPef/dkr5NYPf7DgYQOD3u5/4EGz/jD6NmJQDbpWtOkAnqAOosJvFaJunkYLIfBO0S4Xc+fOLWDq 9WJ5urjc+pGPm4dFXGuQ8Iqo5DvfcZOJzpqN+h8Gav3XT39e2I/W+lJf8ftGlLV/oE+vJYwC5qHh WxKYEAItLwDR98RJ2rr1eXPhqzbvnBObjc6LUYnbtm03zcH5T9SVypmuzXRtZdbRrbSf9R065Hfo qMugRgKqJYz8HRqKlxVosHXzTW+Viy68UG8Ozp7ucVPATewr//IN+cMf/jDJTXDVSPB7EMBNHKJ9 MtIS7Rt3o/Zx++znvlAgVuz6AvGCpQnzWwQQGRvIG0hk19Zk54OYxSjqt73lrwrEH1oU/k7XMv7T o4+NReSKH67AAXLOq1E8iLnu7mk6u8B50q9CGA+YVn6wWbf+D7nftf5WkbBvQFtUXvPq68xn6z/0 Hfz1//uNiS5a2wpetUCYQF/GUVMFX/MDCZBAcwm0rADERQfNF7N0UICTtGfv3oqRKye2mpUXF+FD hw7pyLy47X6AiN5B1GYyta3Hiekg2tsx/Ub1EcBHj/aam751UyjmgJGT6Ky/fPnpxV/Z/oybzIMP rtObg+1dmHGSCFjNkuXOh2a7hXVyv//9/5A9OqDAaf9MvYxIRH83+Q9aEDlxHRmrHREcu44mTTzA 2d0Tosuj6qcRg6ng98UXXShnad9KKz2/bZvc8q6/kR07dpi1zSHm7CSMzP3RT35qeBbvg2mX8hOu xRDQ+QzxPfojo161Ns/nl8H3JEACjSdg72rQ+HIbYhEXzi59eneSMOVBKyTcRDBwwG6aphzC4aA2 7WizTi2P01oeLvQevWhXS2CIwQwebSIrl9C8VE+q1HfIrt1mNCvlohXl623XN+YrJIBpTQ7r9DoQ UD4VExjtjRGwdtLCBQsEk7rvfHFXDQIwqwMbCrs9QNBk8SDl4DBjH6xrfeuHPqh9T+eb6L0d3yGa 9upD6T9+6cumebVYRNmxgTwoH38X6NKQ+ZOhY8DbCzq9lNNBUPAD9ZnqCcxwrUJ9i4WuW+oOYY+H LDvzdk6Gz/ANPiJyjD83Jut+hGNc0/2xyZXC/Q5/5h6s5+JEpZYWgNA5dm8SFlA3HnzLt4JXvTA5 SVj/tp4fHy6EIR0pa+ciaEV8HN0hnVSmAXlxQceE0VitJHfM9aauTdPTurp0neO5FUsACwwuwHQY hecL+iwlzV/h9orm+GUZAmg6fmzDBrn33vv19XF5ftt20zcNa0VjaqM3v/FGueaaq6qe1zjvMY8g 1pOuJZV+6HGg/kYLRfQR/i4+/nhHbuzavUf++Y6vmpt8rQIQBeLhBKO28xO6vDi8lOTvPqXf43eO c2fx4sWmyR8DBOu5hjYDFq61GGWPWQlwTYJIcNO1B/6h5Qlrx6PV6ujRo65iiGOMv+Mxu4UKhl27 dpnPbmKIY4rZLTCgFf3rcd+ZqPOwpQVgLT84jHR1Jq1qKaW+fXDC4mKe/yRfzaLPn5sPDfvWmtD0 XM8NqNZyG7+fjlbUpqd16x+S177uhrFIZTyekNe+5lXy+c/eXrFI/CA/pX2mHly3Xo/BsTZoPHAg 8hmPD00RThUxNP3L++6/X2665d06qfGAueDhfMf5B2F47333y0M61+TXvvJ/dFDDNVV9wVx0uIhi kILTc3hEj3cjEn558N1pwj71/G5NeVo4Iqf5y9bh5oxofS0NAk7r0Ir5wfyGG26Qm97+dhOF/d+3 3SabNm609RA8EfVF1Op0ne7oU5/6lBEH3/72t+U73/nOhImDanXE+YXBQx/84AflyiuvlI3K7jZl iIj2RAmYaj4iMnn11VfLBz7wASOcv/zlL8svfvEL1xxjMJwxY4Z88pOf1CmxzpL77rtPPve5z+nE +pUHWVart93vJy7WaNcjh/lwgJ0ks0JCHSLJSVm15kXzL25meLKym5LJVH1Ph3qXwPQuVqi8UrmY H85bofm30r4T+R1+XHgiRX8m/PX0HDFPV3Z8GByMj+6D/XJ/sIHRk9rgZscE81QhcOTIUSNQcBPB uY6bBp7MIeDQZInm4K987WvmYljFlIm6oTXAqZDCwCn0tc1PJjpQi2rSfWqdhzO//Jre68MJHlww gMpK4GgxcVPEw/JvMl/BChGX17/+9ablY+myZfKKa64x599k+pVfNq5fV111lU6Cv8wIrVe/+tUm Ggjf3ZBwr8DsE9coN/x+zznnHLngggtMc7Ab/MO1AA9E1/7FX5ixAjNnzjTHG9cWp9eJZtUHx3Lt 2rVykU75husfhPTZOs+pmR6pWYXm2W3pCCAGmOKJ30lyMimqE7uNzKvXctOU4+SijShCPRcGlIkf dNbGxaVLRxpitDDKdOJjIxnZsQXf8p9E8d5udAj5kD9/fztllsuDi7nT4wP/7TTJlyvT7dvBuNLx QBR386anZb1Gcq+++qqK1YnpCPZZM2eYZv+KGYu+hM5L4bzX7gFWn1Ywhyh1cpPAsUK07aMf/6R5 eNOdi0rKfcR622frk/4733HzWHklMzrciPLxe9ytzcn56bJLL9GJ7+9SYZjWaHZLX+7zq9WQ9/hN 4g/skKyHXxx3a1tDCqrTCH4j8Ad/lX4vdRZT0+5glc8Q792U8DPEYFGwwy8S/eoxdsBNxxi+gRuO LV7zeTabZUtfETByFetXOkmLtC9Al/YDG0A7uwJ3Y8KJYOb1c+Bcny4DV8/ceSgzrkwQQcDNr1JC dBI350oDatCEzXSMwL0a2r/jK18zka0y2mAss14PTDPz9a99tdzwhteNbX+pvcGFEaNxn3xqY1UB iObjbl39xOkNCGVgVPvwcNp0uwBjSwCWE3HljgME/v2/f7Di4C3zZK9lvlNuUjM54VHOntPt+A0/ 8OCDugLIG8a6j7zyz18he3RZt29++zumac668SEv6o5X673T8lo5Px7sDmifv+9+97vy1re+1fRf Q9Mgzp9GPfTVywfH5a677tIVWVaYZfzuvPNOVzWv4hq/efNm+elPfypXXHGFzse5SZeFfMA1D604 v3E/+8EPfqDrVM8xou/fvvc9c+930r2q3uNYaX+ca+vWrdNlLe/WfsyrdYnHeyd0+rOWFYA4uLiY YU46J2nRwgVm3c+n9KbiVRHjtoQLUEd7h6zRk8FJ2r//gAkb13pi42LT29unoi6hArlyyfPmzzMT waJptFRCHe655z5z886/iWI7+jucqGvLvtQSOvr/5n9+a6baQRN/pYTW9d7eflnjcI3rSjZb9Tv8 xsHOEi7l6oGm11hU+/dWRjtu99x5rwJQxVv+IwuWXkOZTlO1KU9w3Qrk9St1ar9Sfvz277//96b/ 5JVXvMxkxbb3vPud8rLLL5N79CHk2Wefkx0v7NSlMI9IQpvY0f8Sv/uk3ii9OhkzpnDCTQl+TvWE Ov74Rz+Sh9avN91fMIih1utnM1jBF6y49D7tvxbVh3IMEMD56pYEfoia/tM//ZP88Ic/lIMajEGL nFsENDjhYe5eFVUQqmC3D1NFKVe3JPiE++gnPvEJ0yUB/SfxkDhRDFtWAOIAQlA8v/V5R8cS0b81 a86QDY8/Ie6Tf7mZ/C+84Hw5+eQTHdULi7dXu0lWMogTET9g3BCqJYi42bNnmVFppfLiwvC5L/5D 7oeWdxNFNOfVr7pOvnrHl111IStVh0Zvww8a/WQQOa0mLHDvDYXSrnmSbjQLJ/ZwXqLfJX7rlS6K OOcqfV+uTOumkNAHn0jeetGzdT1lfNdKCQwwghCTPs/R/m3583CecsoywR8SmoqRD60gPT1Hze8e I0wfe2yDbNy02ayUhJsQIjywOVWTqZvWb+eLL5p61nL+NJsNBAzE+mEVp3jvtgSG6Ie/Q+eZBD+3 MkS0F8mN/sEnRCq3b98+4Qzdd0Y5PMNf1GHdeApxouovu+Ri+cGdP8xN2OrCCxye1p3M25U7eXY4 JFeY3dw89OntkM7FdtJJlcUnbgwrdJLnhx/+Y6GRvE+4eRYP0EGUBTdyJhJwRMCmBsmtZeHIsrnx 46Hn8JHDZvULa+9FixaOifVWEkH4bW7Vh+J3vvu98omPf0Quvvii/7+984CTotjW+PEusCo5CksS liUtEhTlCoqYEPQhKAaCgApIUkBW8fkURBBUEDHLVTArQeUiYgBRVAyoBAUlL+yCEiSpgKKAvvPV 0tAzO3lne3q3v/ox7Mx0T3XVv7qrTp0651SuQMyYiOCF4PE1a9Swqixy4w2yV52m5s2bL3PmvmO0 ieEE7+M/Lrjv3ChY2WmiL3XzZATPh9sZulHws7dxohgWrCmunZi+R6Nu275N1bo50r3f4aAf22in 2LbtRY552gQtiN8BCLIN1OOrXbu2fkdCf4QN07p16/M0W8cNCIFtzdq1oS+mRzEet2p5tnnog2mz kJ/Vcdn/4nsmEnALAdyPMHvwd55IT09XW1j3eAtGw8sIgZmZ0rtvf+navadMff4Fs1/ybtUkhUuI k9nl2mvkuWf/IxMeHGfspf0ncuHy4HESIIGCQaBAawCNALjtZ1WdblS7vqoRE8fsd+iQW+Srr5cY J5JiLrAJwEwbISn69LlBqmlQzWgSljB2xmGJAB39qlVrIrp0ixZnSe1ap8qGzI1RaV8jypwnkcBR ArDCi2RLNthVYgIV7fwCAiBMEzbpEhYmhlaqmlJFUlJSZPXqNa7Wvljl9f8LjQwmZ4hl+cWXi80+ 39D2oU411A46RY3iK1epLCm6VIxAw/jevsUb+shuXbtI8RLFZVjGHWbZ2M1aKP/68zMJkEB4AgVa AET1Dh78Qzu5LzWOzrnha2s7o5HO8O+4PUPDNow0mq9EqoitwQub2nfV2Xe0aYUG4IQ9D2yYgmnk IskTHfyaNWvVDvCAOnmE3oarfLlyGqD3Mpn48CMUACOBy3NiI6BCzIkn5cQIDJUBJi/79x1QaTE2 DTNsgntcp1sx6aoCEvbFbtz4NIGzWDTmJaHK6PQxCLdwSkGfgLiWK7//Qb79boUWA/aSOcuK2AWl fNmy0qxZU+Mocknbi6WihtOx0uUdOqhX4tcyRb2IIRQykQAJFB4CBXoJ2FpOXKShDyJxXvBvtu7d usjoUSNMBw/tQSISQkdg8Lr2mqvlvnvviXqwOfL3Efnww49MSJu8CH+oO7QG8DrbvGVzRCiu79lD nVXSjHYgoh/wJBKIkgAmR4g7GS4d1h1aED0/Em2hf16475cuXSZ7dh9fIkXfckGbNiZIcF6fK//r Of0ZdcHkDoIshDgEx8V7M+lVvlg9mPvOuzL41gy5Zcit6nCw+1gRIU530IkeQkPRfvcYFr4hgUJB oEALgGgB2Lus0mUavKJN6Biv79VTxt032iyDIK5dtMF6o72mdT46U3jjwb1/8KCB8sC4MWa5xToe 6d/16zfId9+tzOnMI/1RkPPA41eNJ7h48TdBzvD9GvuO/t//3mGMyeE1WNAHSnvtClNd7PU6/j76 ECfHf+vcuyJJRaSqLk+GS7j/dqsDk97CUSfEA926dZusWLHS57etW58jdevUyeXM5HNSAf+AZx6C IJzO8PpgwUcybcZMn1qBP7SCFAB9sPADCRR4AgVeAEQHBsFt9uw5QRsDAZJ36+w+2K4h0AS+MfM1 GTr4ZrMDBwYTeNZCGIynIID8oGmE4IfO9pqrr5IZ01+Ru+68w2zZFLQCIQ7MnfuuCWgajyVssEQZ 3547N2Kt3mWXtpNnJj8pTZo0Nk41FjfsrAB21guDB/LGy+0JkeOLFnNPrKhoeUWiBYPWq7Rq1kIN 6vG896OtA85H2UrpDh9nnB4+JuZWje+F5zsWOzXc9wg18556v9rrDIeInj26m3LYv4+lLgXhN9gh AbuFvK3aQDzHVipVqqSJURbqXrHO5V8SIIGCQ6DAC4BADeFn3vwFsnHjplzkYfuSMfwO6dT5auMR 95DarEFT4J/SdKZ/9113qiA4TcbcO1JatTrbBC1Gp4eBBfvkRtsBYtCAMInf4y8GXAhKtw0bKjNV 8HvisUkm+rdxq/UvUASfEfx5ztvvxDToBcseS0MrVq6U71etDnZKru9bn3uOvPzCVBmt3Jo3P13D aZRTzWyOEToEPgywEHixVVdlNTjHZzcnaIQaNmxo2rwgDvwwCwiXICid1riR3pfHB3rrN2gzow0/ fES3Tcq/LgJsMRk6pMu3gTjDOSP9tHRji2eVLdhfeMHDDjYWARB5QiBepLt4IBCrPbVXj3x45tsF IvvxwvYe/BAQ+bC2vZWSlA1WWphIgAQKF4EC7wSC5oAAmL05WzVX78qQwYN8WugkNSBvlN5Q3nn3 PbOl1Oe6r+iizz6XUSPvkmZNm/qciw+1a9WSfjf1lRtuuF5Dq2wwEcSR97ZtOwS//VHjDkYyyBjt hc6csRdnVfXqhbddeqN0adiggWr7Ts513Vi++O/st2TtunVR2w2Guhbq9ptqQ1544SVprOWNtOPH xuoD+t0kvXpcp3aEGzQ8z3Zjl/n3kb913+BkY1QPwRB8EycA5uyXGqr+1rFrdRu2xeo9+fU3S3Tw P2TaPEdI+cfEh4vkHrDycvIvYi0illskqdPlHeT99+fLt+oAAQ90yOWoY7lyZeXM5mfIlVd0Mhrx SPKK5ZwWLc7U0HO99Hn8wjxXsIVFOSzOeG6HZ9wakXZ8rYYvgtCKiUYsCQJgtnrTv/Pe+9K3943H soCHbMawITJ4aIbR3ru13Y8VOA5vsOxun6OhPaKd/KIYph0LhqVBHKgxCxIoeAQKhQAIgQKaq2m6 HU2nTh18gpuiw4Zg0qxJExk99n5j7P2ZCoADBg2Rl56fYpwYAjUbQsM0Sm9gXji+bPm3Zp++nMEp 0C9yfwfBoVXLlvmynyu0mDNef9N0svEWqJKLJZsN5Fuf28osU+euWfBvYCwOLSdebku4F/ZoLDRo Y7EjR6gEQfXlF58zAiDsS7FzQjn1liypQv2kRx7LFTcuVF6OHtPBetfO3BruQGWA1vul56fK519+ qRMo3Q1BTzqlUiVJb9hAd41ooMJU/np9gvGkiRPMjjJrdIuyTRuz5Bd15MAyZC3ds/vss1uYPTwD ld3+HdoT3rp5Ec7wDGEJ9Jlnn1Nv2Aul1qk1j10CThDQME6YOMloCvNynWOZuvQNTFQaNKjvM/H7 Q1cw8NyE6mfQL/qbd5QqXerYxCnUb12KgsUigUJPoFAIgGglzOAzNSbdjJlvyPDbhuVquH//u4U8 9shE6da9l2D3kMzMTLNd2eQnH/fp7HL9UL+AZgHhThAsNtJQCBgkEE7lyacmS5s2rU3crUB5x/rd G2/OMptvhxNkYskfnTUGgkmPPiEtzjpTaupgXBgSQl/8+ONPgsDZ2MouXCpVqpQJjYGdWexp1qzZ smXLj/avXPMe9112drb89ts+ge1WuFS1aopcc1XncKdFdRzP4r+woXGECfHpfHakiPB31mnYI3Wd eq/n1Q7WaAGV3RNPPiUP3D9Wimo9kPA8YD/d7bqd1KuvTDOCDiacsaZoJpG4Ru7zg6vVrHNjEbgg wKFena/s5MMSqx9wkgkm+OJaCKa9c+cuHyTpakaRnFxUeSHGaeT3g08m/EACJJBvBPLPwCffihw8 Y3ReU597wWhtAp1VJzVV7tWwLxDicO77avT9zLNTA53q8x20CwioGq2wBU1G5saNZmnaJ8M8flii ISuefmaKEXrzmFXQn4PPhg0b5K4Ro0yYiKAnFqADGMCwNL16TfjdToJVC4NZsIEw2G+c/B5CEDSW WSrIJCKpIsgs+SfpMqJT6a05c9VEY3tcngfc99NnvC7Tps/wKT6e/XFjRsukSRPMVokQeIzDk9oI h0oQyLB8Cps6TKr+VOeKSIVjyEyw5/xT7SSthPZNTj7RbGNpfWf/C5MNOAFBK4oVCAh1cMgKllA+ nIPz4fw05OZB0r7dJT6nf6EaYkyaQgnYyAPmKPYEDe7FF19sJtCWYGo/zvckQAKJJVCoBEB0UHv3 7pUHJzxkDMIDoW178UUCz1Vj1K394sO6nPcfFaZgjB4sfafhIbAEGO0sFuej08eeufHqAKGNHP/Q w/KTarJCdcjB6hLN9xCU53+wQG4dNjzX7D6afGI5Nz+ELOT5++9/qOPM23Frj1jqFu43EKJQ1mgn HMjXegY+/viTcJeJ2/Gc5+Kohgd/jLwRXOiI24U1oy36HLw2fWZchD+UC9whsN1//3hZuNCXIXbK 6KLxOqe98qKZSDZXO8nSqiXGM35Al0lxb1kvPKd4QTCCWURKSmVjFtHvpj4yaGD/iCYRKMufGsFg z97jNp1o3wb165nvIbTZE8pxTquWMvnpJ+SGXj3UwaypLumfoiscRY2AB2c0q3zm/dHylSlTWhDz cOozT0tGxlAflpvVNGDm62/odzkBsu3Xs7+H9hQBo7FUbKWTtP8YefedcokKgUcsZzrD5aBh419+ 63f8SwIk4AwB56bpztTHLOd+rjuDTJ78rGTcOtjMau2XRgeK0A6Id4Xg0RD8Ro8ZJ19//Y107Hi5 pNauJSfpHqDwjsSSxrfffWc6wEidIezXwntc72ddOoJHI2L+5TVBMwFvxWJqp+dEghAy/4MPZIgG iR11zwipm1bHicvqEuZvKnDH/1IYDN9Wz+nLLm0vF15wfvwvEKccIVRhUI0lwWvztWkzpN0lbYPa uMaSb7Df4FmBoAOBxckEgechtcvbvHlzWDOOaMoF7nCkGXb7cI1zOVyu9lsir1atmgwa0E9uvL6n 2V0DmvLde/aaSSXaDa+TTLDlYlJCw9icUrGSVKte1cQzDOSkAq/zQLc68oEQif254Uxmpeuu62bi dWJiitUJOP7g99D0lVa7O0xw8ULfBk1wdvZm9ezdfay/gzCGvLFzEIS/umlp6vXeINeEA/3jeJ1M r1233qyYWNcP9BfM1qnz18uvvKaOeDcfOwVL+1OnTNYoDR8YZ6OtqqmFsw/6lQO/H5DP1AEI7Yjy MJEACThLILYRxtkyRnU1dCQYiB5XO57U1NpyRafLc/3+jNNPl/PbnCdvzvqvWQ6Gdm6Oxr569/15 gi3OTi5eXA5qx/vLr79pB/y7GYhjHYzh1YjwFOiM8yoAfvLJp/LA+ImmPpEuI+WqfAxfQPj94MMP dUk4U/r366sD4pXGqzeGrML+ZKVua/fqa9PlPW0LuwYs4gEizDiCe2OfDmwjRo4ydpkweC9sCbZr Gzdl6fL9PfLUE4/5bO0VS10hhKxQQeM09QqHNss/HT70l49GFUuQwRK0a1iyrVu3jjqbNAx2Wtjv 8cw+/+JLZnKGZdt4J+SJZeXbht9p9sfGfe9vNwph7qwzm5tXXq6/fUeOUBToHke/M2vWW9Kty7Uq rJUxl6miHvf3jR6lpgxr5IrO15oYhli+tRLYIC9o8OvXq2de1rFI/2ICNuKee2XmG7MiEq6tfvex J54ynuPY2chKuGeu6NTRvND+Gh1Udy5KMvcUtIaYQCQlBb9nrHz4lwRIIL4Ejvca8c03oblB64ZO 5f4HxqujxKpcZcHxW24eINWrVzMzbJxwos5I8f0eXULeouEgdqmX7ZEjh00nGqvwZy6s/Ro6ZLzy kmBfM/LeMWa7qzyVJ4ZCmMFE7Y7gPDPinlHS+6b+Rnj2N/qOIWvzEwjHaCe0V5duPdSO80WjrbBr lOJpe2fsG9VhaMitt8lCXSrFoBRpgiOJPYENbD3Dpejj6f0TkUataJGiAbUnycnFTLijocNukw3q 8BRLwjIhQiYNvHmIEYQQUD1Q8hHA9D4/8g+0gYGXDNGmL7/6mtzYp59MUXvdn3/eGSjLkN/t1SXR SY8+LveNfcBo+NEG+ZFQL2irnnx6snS7rqe8oRNGBJSPR8JS6edfLJaRo0brfXi70Yah//FPKMMP q1YZW2X/JVNoeu39CjAghBNWHGJN0MYh3NWAgYNVuH7TCH+R8sWzgXsGE4/nnsczrHsz+yW0P4Q/ JHhdI+VT85m8+R8JkEBwAidUq5maN8kkeN4JPwI7v3p16xrv36ZNm+Qqz1e67Dtq9BgT4gXyGTok u9CBzhXLKrB/sX+fK6MQX/ylHWr9enXlzdenS4Xy5UOcGfzQpqws6dtvoG75tsIIpMHPzP8jYAKu Scqk1qm1NJZiYzm31TnSuEkjUz8Eu7Zr7gKVCKE+MJBu2rRJvlz8lS6/L9FlprXG0BzCrf9AiGtC m4FwHDVqVDfLjYHyheJpwYKPDKdIhGS0DUKdnN/6PLn6ms7SSDVSlTQMCvZK9U8Y2H5Wk4Bly5fL mPvGyY4dO83AhSW0Xroncvny5YILkv+cIPMXLDBL9z7Ckv9FbJ8PHz4kzZo1k44d/kf+ZQSD3I8p BmYEOn/p5VfVS3NrwCVjCA1VqlRWjXcbubrzFVJbTRxQR3/GuDQ4Iwhw5sZN8qmaGcCO8IfVq+XA /t9V83eSCWeUpsuFf9sCTeO5WKxtOPed98z1kQc0xtD4IP6lz7mqDd+3f5/MUCeL3SoAoUZpqanG 0/qCC9qYGJEVKpQPGMsPtr1YPvxo4UKjQcSEAdeO9bnUS0eVIBjhWjAROV1XENqcd67UV1u8smXK qrd1KXPP2MuC88EekxusAECjlpW1WR10VsuaNWuNc9iWLT+aiQ7uiVD3K5jihVWLm/r21j4tTcpX qGAiGXS84irVAO4/xgFlqF6tqtH6QcPa7PSmRtNdsmRJ4xWO58hq+8M6wcX9s089xrGTyqefLjJt CScz3O/hnuNgAK0JVaP0dLn00kvM8jXuOezpbOUJwfobjbHZ4/reZhJuZxcsX35PAiQQXwKFWgAE KnTCaWl1dCnsUWnSOHdsuj1quzNv/nx59715RlOCDhsee+iQcmxkyqjn6DZjDxhLJ5VXARD2TQMG DZZvliw91nnG9xaILTcMSOAELSkGLwyCVXRv4IoVK5r3CPpcUu2fkCCoHNFzsfSK+IXbd+wwy2t4 j4ESCXmE4ovrYccIzSpkQh7WABfyxKMHMVhhMML1U1KqSI3q1Y/WobRibCynAAAKlElEQVSUKHGy DuC6jeCe3bJj+w7jcLBdB0okq6woF+zftJbmnzno/5+eAwbRlAtZIF/kH7LSehwCoqVN8b80PqN+ yKu4mjZU1TpWP1rHCiq0olwQxH5VoRw7y/ykgmRWVrYRAPBbCCfmHFPPo4GaccBKR+VSu5NATlsF tuvCMXueKBsmWdBYplSpokJjitlJprQK1qgT2vwXtceD8JednaXl/M1cGe2FcjmZUHarvKgv7m8I NpjYwWwEtnxWOgjhT5fOIfyhzBBg0Rfl/P5vcy/AUzpSUw6LKSYsNdSuDvvzIj/EJ0WeFgurjGhv 3G9FVDtdqmQpE9zbMm+xwtsc0kkGygZt5Ha9v7HUjxTuWbTqGOqvVV6Uq0SJEqZdK6rQapkQoF/c of0AQnfhXCYSIAHnCRR6ARBIsRxcr16aPDJxvJxxxhkBKaPDhFYKS7/oWNEJQquDzr13n/4yTx0h rNlrwAyCfJkXARDBcW9XG6TFX32VcM1fkOqZr9GB4wWGEKgwoKPj9x+frY7eEtLw1xq4QuXvxDGr /KYOWheIFihbzth0XIDDoBqozFbdApYVLAIeiOzLUHkHKkuwXNE2cAA4ogID6mUXPqxroH54WQKu f17WefbvoymD/Xf298gX7HPuIfDGUfyXIxxgSTkvmnj7teLxHuW1ygyu/lzAxP6y7vW8ssKzhUlX Tmw9DbmjpiuhEsplPZM55bSbO2DFI2fVA+UL1uah8o/kmLnvjvYNxzlhQqR7busEg4kESCAxBMIb LyWmXHG9KrQLa9eulz66jHrPiLulU8cOufLHoFepUkXz8j+oXb3/V/n++RNdjrnr7pHGAw/LNm5O 1kCXXwOIE3VHHSD04xVLyuvAHuqa8crbGuQtDVCoawY7Fq+y+OefV/7++eX3Z5QXL6fv+RyBragK TpHVEGXMEeojOz8/zrLuu/zIm3mSAAnETuD4mkXseRSIX0II3KbLHEM1nMn4CQ8bzzlHCq4zcDgA hFqis5cDS6KPP/m02vwN0CXpja7W/NnLzfckQAIkQAIkQAIFh4BnBEA0CTQfWJJ9RD0Ie/ftL18v WRJRSx1ftojodJ+T8FsIn5EsdaxatVr6D7xZHnhwgjHsjuQ3PhfjBxIgARIgARIgARKIgEBs610R ZOzWU7AcAqHsY42p9/0PP0hXja/Vt8+NUvmUU4IWOdZlwaAZ+h1A6BnEvpsy5Tk1dt9m7Hry+5p+ ReBHEiABEiABEiABDxHwnACItoVdDIynsb/l4xq4FFs+Xde9q1x80YUmNqB/+8N7Mk8piK0QvOCw 1do0DYuxdOlyY5Dtdnu/PHHgj0mABEiABEiABFxBwBNewOFII64dtIKpqbXl0vbtpOPlHUz8QCzd InxD1+69zJZwsSzJYpumU9S5ZMa0V038LnzO1MC878+bL7Nnz9G4YGvMtcN584WrA4+TAAmQAAmQ AAmQQKQEKAAeJQUB0ApjgqCpTZs0kTp1UnUbqNWydNmyPHn7IV8EZcW2Udka1w+xuxADD95xWJKG RpKJBEiABEiABEiABJwiQAEwAGnErYJW8G8VChHcNR7aOeQHQRAJOyVA8GMiARIgARIgARIggUQQ 8KQNYDjQ0MzF2xYPQh8TCZAACZAACZAACbiBgKfCwLgBOMtAAiRAAiRAAiRAAokmQAEw0S3A65MA CZAACZAACZCAwwQoADoMnJcjARIgARIgARIggUQToACY6Bbg9UmABEiABEiABEjAYQIUAB0GzsuR AAmQAAmQAAmQQKIJUABMdAvw+iRAAiRAAiRAAiTgMAEKgA4D5+VIgARIgARIgARIINEEKAAmugV4 fRIgARIgARIgARJwmAAFQIeB83IkQAIkQAIkQAIkkGgCFAAT3QK8PgmQAAmQQEIIYA/4Q4cOHdum MyGFCHNRbCGKMro1WQyxhapb0+HDhwUvtyawQxuDpZOJAqCTtHktEiABEiABVxDAYHvCCSdIzRo1 pEyZMq4UAiH8oWw1tIx477SAEK6hLIYoH7ZPtfa7D/c7J4+jTJUqVZIqVaqIG4VUlCk5OVlOPfVU KVq0qKNlTCpVptwoJxuD1yIBEiABEiCBRBOA8NLl2i4yYuQIad26taxcuUJ27dol2AveDQkaofr1 68u4seOka9eupkgrV640QqsbygfBBXvcDxwwUDIyMiQ9PV2WL1smBw4ccBXDli1bytixY6VDhw6y bds2yczMlKSkJDcgNMIeBPwRI0ZI//79pXr16rJ8+XL5888/HWlnd9zprmgKFoIESIAESMALBKAV gkaoR6+eUlG1Q82aNZPLLr3MDLpu0bKhjO3bt5fmZzaXypUrS/du3SRFy+wWLRsEVAh9Xbt1NRq2 tm3bynnnneeapVa0I7SSPXv2lLS0NKlVq5b07t1bSpQo4RpNKpalIaCCXdmyZaVjx45y1llnyV9/ /eXIY0gB0BHMvAgJkAAJkIBbCBghTwWEJF0CVmnAFKuYLsO5LRUpUsQUCeW1BFPrrxvKCm0pltFR JiVpNIL47IZkcUIZ7e+hubQ+u6GcJ+p9Z5UxSctaRLWTTpWPS8BuuANYBhIgARIgAccIQEjZp0uV ycnFpGHDhmZpcOrUqbJ161ZXLQ9CE9SoUSNjGzZ9+nT5dNEiIyy4QciC0LJ3716pVLGi1FT7tWVL l8oLL77omiVgMAK/gwcPSpMmTWTfvn0yZcoUWbVqlViCtWM3XIgL7dmzR+rUqSPly5eXhR9/LDO0 naEZdKKNT6hWM9VZt5MQIHiIBEiABEiABJwgAC0LBlksY/7666+SnZ3tGuHPqj+We2vWrGkcQSC4 4LMTgoF1/XB/oU0rXry41KtXT7KysmT37t3uY6hlrJOaaqqyYcMG15UPwh7sAGvXri3r16+X/fv3 O1ZGCoDh7nAeJwESIAESKJQEIATClg3aLDdpheywISBA0IKHqJuEP6uMKBsYgp9bnCussll/UT4k MHRjAkO0MxjiXnQqUQB0ijSvQwIkQAIkQAIkQAIuIeCcqOmSCrMYJEACJEACJEACJOB1AhQAvX4H sP4kQAIkQAIkQAKeI0AB0HNNzgqTAAmQAAmQAAl4nQAFQK/fAaw/CZAACZAACZCA5whQAPRck7PC JEACJEACJEACXidAAdDrdwDrTwIkQAIkQAIk4DkCFAA91+SsMAmQAAmQAAmQgNcJUAD0+h3A+pMA CZAACZAACXiOAAVAzzU5K0wCJEACJEACJOB1AhQAvX4HsP4kQAIkQAIkQAKeI0AB0HNNzgqTAAmQ AAmQAAl4nQAFQK/fAaw/CZAACZAACZCA5whQAPRck7PCJEACJEACJEACXidAAdDrdwDrTwIkQAIk QAIk4DkCFAA91+SsMAmQAAmQAAmQgNcJUAD0+h3A+pMACZAACZAACXiOAAVAzzU5K0wCJEACJEAC JOB1AhQAvX4HsP4kQAIkQAIkQAKeI0AB0HNNzgqTAAmQAAmQAAl4nQAFQK/fAaw/CZAACZAACZCA 5whQAPRck7PCJEACJEACJEACXidAAdDrdwDrTwIkQAIkQAIk4DkCFAA91+SsMAmQAAmQAAmQgNcJ UAD0+h3A+pMACZAACZAACXiOwP8D72BFj4OMbiwAAAAASUVORK5CYII= --Apple-Mail=_95FE29A4-2B04-4591-9268-BE4AE14C8FA0-- --Apple-Mail=_5AD74124-9F29-40F5-9C93-E462796AB6EF-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 20:40:50 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 00:40:50 +0000 Received: from localhost ([127.0.0.1]:55999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyKFm-0004IS-78 for submit@debbugs.gnu.org; Fri, 28 Mar 2025 20:40:50 -0400 Received: from mail-oa1-x41.google.com ([2001:4860:4864:20::41]:53462) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyKFh-0004IB-2A for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 20:40:47 -0400 Received: by mail-oa1-x41.google.com with SMTP id 586e51a60fabf-2c7b2c14455so1597912fac.2 for <77224@debbugs.gnu.org>; Fri, 28 Mar 2025 17:40:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743208839; x=1743813639; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=00UvM0eoGvnoQKe8DtuKGmUpZqnhcBhld7sCsx2P11Y=; b=UmXCGyePmAywCQElkCpNve1tN+dhyJOO965ZSt+ZJqBoMLix9q48z9QSWMC49OcSrF hFT3ePtiz7/go5aTRCT2JGwrhU3k1v4JcwojKMzFR+RQx964jKIQN8IjjWRV5zK3SrDy z8HGPq9KNyR9o/BSnGSL4GfmzcT5Ml0byeZKUd+tQ9Bb5rK2BYLWdiDNCW2wPvlG28m+ 5V+NM0gxtC7r3goPAOYHVmONpwXFxht+aIED5gJ1yIpk5OLoU+n52P5iEckUWJ9NAn0c BkY+Irn1Nkm13SqS6RERCHfkFLNtir2M21k4SnaR2p4U4KRKdHop4Zu3C1ZrEc0ugRXW hyuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743208839; x=1743813639; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=00UvM0eoGvnoQKe8DtuKGmUpZqnhcBhld7sCsx2P11Y=; b=HlFwNYG01tLUZ6Q/htdpvUwVWk7fjjl3s5HSkw6xY3xaFIlOrL3HOjJeIKJyB3XBDg APiC4mECcPFJd9BGZZtfxStpp2TqOsV0SfQKMwCvjLFFN4PGpcYstuNiru/GHIFyT0qT b1Ft8kx4ZMK4Vr11CTXpI+GR30LMvxoaEs6p8ig+v26lemr9I5Vv2n40NGM785mkwmrg jjqdl7QeW1y+gvUoyoGMpZxGqqR6dIIEKQcNW2K4xuDyI8LCCu0EAaJH4D48brIAyonA mndsClHx+piDf2ZgsYJaLvOOkIcfderdKtN4c7fuY8CIAD645eiKKl19VXR3nLrGPU1r 6i9Q== X-Forwarded-Encrypted: i=1; AJvYcCUPra1PX9Bv6jYynkNczF3LGhIwvQVulF0EB/aZh5xds69n+PEd3NwexAcCud0TzVtFINW34Q==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxoLEst4tyhZ5QDigqEWCtkR3+ZCN0lVRX1ZHAkkioNWMfKLAnt 6emgCq6mf1wI1DSVEVjuVxFc8ScVTHzBrOrK/cDljecasfOhQfIWLzqeqGk5 X-Gm-Gg: ASbGncucIao237lsuyFjjeTrD3XKMiZsfd80V18DxjVBy76s0DC+lRnMvyignHzBWAb /4CYwbtVhQn6bT5LfFNFe7b/bZ27PYFFRVqrqphWZvyuBiqw2ZMwEUhMQ4fImJ7ZH/rIZeCkp0a jphc5JQEmdAsF92SzCelJjrdvjBK8jnBi0zOW64jHqI0oCMsq2OfPAjI239yxxFblcvm4zunil/ UxLOw3NFq/9Md4WDSVwmmSxouVdShQLN/pyHjjlUV2gddGW5a4RUTZqsZNwFiB7NiYtv32uHqgM h6zjo/stvTrO X-Google-Smtp-Source: AGHT+IFGoeZmviP9oaPM1Ft4rpo0oWySH0IB7PQx+4VuX8UGceHwQPuOJErtl8QR2GHZpMoLl2sZJA== X-Received: by 2002:a05:6870:14c7:b0:2c1:b58c:c0c with SMTP id 586e51a60fabf-2cbcf816ce2mr740605fac.34.1743208838569; Fri, 28 Mar 2025 17:40:38 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2c86a8f514asm666685fac.41.2025.03.28.17.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 17:40:38 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Daniel Colascione Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <868qopbp40.fsf@gnu.org> Date: Fri, 28 Mar 2025 18:40:36 -0600 Message-ID: <877c48654r.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, Eli Zaretskii , 77224@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Daniel Colascione writes: > The feature I'm proposing is higher-level than that. For example, for > my personal use, I have something that sits in pre-redisplay-function > and scans all the windows for applying highlights based on current > buffer and window selection. I should have written this thing using the > appropriate window configuration change hooks, but didn't, because I'm > lazy and my approach is fast enough for me. > ;; Don't do this. > (defun window-highlight--pre-redisplay (_window) > (window-highlight--rescan-windows)) > (add-function :after pre-redisplay-function > #'window-highlight--pre-redisplay)) > What I'd have wanted instead is something like this: > (run-when-changed > (list (selected-window) (selected-frame) (frame-focus-state)) > #'window-highlight--rescan-windows) > Here, we'd run window-highlight--rescan-windows only when one of its > dependent conditions (e.g. selected frame) changed. After any number of > window and frame changes, we'd run window-highlight--rescan-windows > *once*, immediately before its effects would become user-visible > (e.g. just before redisplay, or after commands), and we wouldn't re-run > it until one of its preconditions changed. Can your proposal also handle whether user moves cursor? Another reason why post-command-hook is used is mostly for run code when user moves cursor position. post-command-hook would run code even if user/cursor is idle and even for every /(unrelated)/ function in background, which can lead to high resource consumption. I think having alternatives like this for specific commands (or actions) could help reduce the use of post-command-hook. --==-=-= Content-Type: text/html

Daniel Colascione <dancol@dancol.org> writes:

The feature I'm proposing is higher-level than that. For example, for
my personal use, I have something that sits in pre-redisplay-function
and scans all the windows for applying highlights based on current
buffer and window selection. I should have written this thing using the
appropriate window configuration change hooks, but didn't, because I'm
lazy and my approach is fast enough for me.

;; Don't do this.

(defun window-highlight–pre-redisplay (window)
(window-highlight–rescan-windows))

(add-function :after pre-redisplay-function
#'window-highlight–pre-redisplay))

What I'd have wanted instead is something like this:

(run-when-changed
(list (selected-window) (selected-frame) (frame-focus-state))
#'window-highlight–rescan-windows)

Here, we'd run window-highlight–rescan-windows only when one of its
dependent conditions (e.g. selected frame) changed. After any number of
window and frame changes, we'd run window-highlight–rescan-windows
once, immediately before its effects would become user-visible
(e.g. just before redisplay, or after commands), and we wouldn't re-run
it until one of its preconditions changed.

Can your proposal also handle whether user moves cursor?

Another reason why post-command-hook is used is mostly for run code
when user moves cursor position.

post-command-hook would run code even if user/cursor is idle and even
for every (unrelated) function in background, which can lead to high
resource consumption.

I think having alternatives like this for specific commands (or actions)
could help reduce the use of post-command-hook.

--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 21:03:28 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 01:03:29 +0000 Received: from localhost ([127.0.0.1]:56026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyKbg-0005Kk-K8 for submit@debbugs.gnu.org; Fri, 28 Mar 2025 21:03:28 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]:50492) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyKbd-0005KZ-HL for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 21:03:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: References:In-Reply-To:Subject:CC:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zGxBu3QI0cC0QyvyLo4uXdDXuf32YJTKW51qXk0jkfM=; b=p7nZY/5gD+WUKUN0fqBxsD05IL jjtC0QgRq6ef6xd0obmj1ruKjA1V12v4/Bevy/dmnT5Y1AHrthof1FRKV2LWdkf2jI6aFkR1oQW/w NIR8qaFfYFn9npW7u4KQYLT8PdY4NlKp5X8LVyrKZPCMCuk8irmrYG2te7eVb5lAwmbgQ+6hlFpMR GCV+RHLsHKmkxxhyFKQuUj9cKLZueJE4Xe3GWcKcVpYEchj1enGl4ri2kLowWIFhwToAh+w1PdJtu yMo81n2RxDSQcH3CuNWSvSbRqEIHfKDF1n2//qBgZEuOa+zNGmWAGFyd/aeqVK8V6Dt+02OBIqxLC +6zcexMg==; Received: from 2603-9001-4203-1ab2-a595-5aa3-b7d5-1847.inf6.spectrum.com ([2603:9001:4203:1ab2:a595:5aa3:b7d5:1847]:35344 helo=[IPv6:::1]) by dancol.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tyKb4-004Mlv-2r; Fri, 28 Mar 2025 21:02:51 -0400 Date: Fri, 28 Mar 2025 21:03:10 -0400 From: Daniel Colascione To: =?ISO-8859-1?Q?Elijah_Gabe_P=E9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' User-Agent: K-9 Mail for Android In-Reply-To: <877c48654r.fsf@gmail.com> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <868qopbp40.fsf@gnu.org> <877c48654r.fsf@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, Eli Zaretskii , 77224@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On March 28, 2025 8:40:36 PM EDT, "Elijah Gabe P=C3=A9rez" wrote: >Daniel Colascione writes: > >> The feature I'm proposing is higher-level than that=2E For example, fo= r >> my personal use, I have something that sits in pre-redisplay-function >> and scans all the windows for applying highlights based on current >> buffer and window selection=2E I should have written this thing using = the >> appropriate window configuration change hooks, but didn't, because I'm >> lazy and my approach is fast enough for me=2E > >> ;; Don't do this=2E > >> (defun window-highlight--pre-redisplay (_window) >> (window-highlight--rescan-windows)) > >> (add-function :after pre-redisplay-function >> #'window-highlight--pre-redisplay)) > >> What I'd have wanted instead is something like this: > >> (run-when-changed >> (list (selected-window) (selected-frame) (frame-focus-state)) >> #'window-highlight--rescan-windows) > >> Here, we'd run window-highlight--rescan-windows only when one of its >> dependent conditions (e=2Eg=2E selected frame) changed=2E After any nu= mber of >> window and frame changes, we'd run window-highlight--rescan-windows >> *once*, immediately before its effects would become user-visible >> (e=2Eg=2E just before redisplay, or after commands), and we wouldn't re= -run >> it until one of its preconditions changed=2E > >Can your proposal also handle whether user moves cursor? > >Another reason why post-command-hook is used is mostly for run code >when user moves cursor position=2E I don't see why not? You could put (point) on your change list or somethin= g=2E I'm imagining that we just recognize forms in this list specially and = add the appropriate low level hooks internally=2E >post-command-hook would run code even if user/cursor is idle and even >for every /(unrelated)/ function in background, which can lead to high >resource consumption=2E Yeah=2E Tragedy of the commons=2E Too many sheep grazing on the communal E= macs event loop=2E > >I think having alternatives like this for specific commands (or actions) >could help reduce the use of post-command-hook=2E > From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 28 22:53:27 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 02:53:27 +0000 Received: from localhost ([127.0.0.1]:56172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyMK7-0001tH-4Q for submit@debbugs.gnu.org; Fri, 28 Mar 2025 22:53:27 -0400 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]:44272) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyMK4-0001t3-0Z for 77224@debbugs.gnu.org; Fri, 28 Mar 2025 22:53:24 -0400 Received: by mail-pl1-x644.google.com with SMTP id d9443c01a7336-2255003f4c6so56409445ad.0 for <77224@debbugs.gnu.org>; Fri, 28 Mar 2025 19:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743216798; x=1743821598; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zbwPHPqqPRPuNHvob2RGYI5DEBxSZuuCwtGdF2nz3n0=; b=CDKMolHHzRjGT8pmickaf64c/eP3spumi1pKYZrynqNERNzeb9NBRNoEiZDPY8vztj BiFRb8nr8MaksHe5+F2s/BBx7kXV1IqUzjHTAHZfN0vrz1iYWjMMXdepbNM2H54mZ/pc L1Kf04K4BnWfxMqB1YTBiFMHsNuZQCx0unfudiCWciLb4m4pVd1I707NimQXQh2Ba9Ap f4E6MIkz6+EscCUMuLPVTwjQZhw4YTMiKRikpVkHA93Z+93ViSD7UA9HOahqgb+bDTgS CHJUOF3xZP04InUaMxpfi9KZL0eyFnv/2WMo7Nj7ng0tZTmPoKvr0aeWsf4D1jGH1jaP Vrag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743216798; x=1743821598; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zbwPHPqqPRPuNHvob2RGYI5DEBxSZuuCwtGdF2nz3n0=; b=NorsdWTlbDhmgcyItLPhKUjt4wzr43iiPxJKKXLDDdn+IZZblSt1bZdT+wyrNpb/Gh IdOyKnMp8R5yF/2UQw479hmsonoAFm5yUfT8y77yVRcDUYvSM2h3jj3Bx8uM8YBSWcNL T0WGio5ncmxi9e3+EhFL4KTSbt6B5PhN7oJ8y6ocj2YPbQbbUbgadUWhVfxnPKTP3Zrw OtaM10z6pGQuloSiLfJlUhzYPN+dLxcYa405HWns6laU3QJXHiZXgxDIu/ccJp8XIsPT d/TrLYzltktsXQzRcARzKadp0C4dsceoHGV7UHWccgd/Q6kuaotwUyjbA7i14gCCelBl /8CQ== X-Forwarded-Encrypted: i=1; AJvYcCV2OmgngvE+iXWwLRleLdYdGWA2jPHqvBFB9BveqYOKDpGn8RhQJ/3DzZPA63zlV3zf1oB3xw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzjM+djwum/Fjlox+oSL8BZfGrZ7h3Ul6L9fKewRze7LdLcqLZK JiYtKfxxwFwGHHMs9JlQfRySIybCZ+AkRovdn9cH25EVSdLyxrXW X-Gm-Gg: ASbGnctq+4Tl0ISu2fYx3MXTLY7jkhWTvam0S+CDjS9ryepH9G2Jf/N+NgIP8CSjGB/ kcmIGl25QahdUOVioB7gPv5DRdz42N6uQci7+3PdErJFNfC4ciEDWO38h/s+qiOs4cFrxqYkb+U nPrwX41QRCuSPlseQVWJyNlwCy9O4aAvpjLSdY6RgOxGOxuE+H5+FtKWbnNHXxqZvfIXO96oQh8 heXNAhLSU0ID7iRr0fkcug0xsXtvgLVI8G3n1qX8VFm/HGAVH7dT3HkLyQVRyWIB0QkGJhQtPY8 Sw/JLWaRJRGpgL3/99etrLSHnkSiZ3uUHE76HRuBAQ== X-Google-Smtp-Source: AGHT+IHejS915gma/9VloUaWHaNs7QMOUEhURQnwHZGM5HnaT2uPDnXgMgMLzMjn5auslN+m7GRMfg== X-Received: by 2002:a17:902:e550:b0:224:b60:3cd3 with SMTP id d9443c01a7336-2292f95f452mr24738415ad.19.1743216797773; Fri, 28 Mar 2025 19:53:17 -0700 (PDT) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2291eee234esm26211025ad.96.2025.03.28.19.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 19:53:17 -0700 (PDT) From: Visuwesh To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86bjtlbqge.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> Date: Sat, 29 Mar 2025 08:23:13 +0530 Message-ID: <87wmc8k0o6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: Daniel Mendler , eg642616@gmail.com, juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=AE=E0=AE=BE= =E0=AE=B0=E0=AF=8D=E0=AE=9A=E0=AF=8D 28, 2025] Eli Zaretskii wrote: > How long is the post-command-hook list in your production sessions? > Should we poll users to give their data? Just yesterday someone > complained on Reddit that Emacs is too slow, and I have no doubt that > features that use post-command-hook are at least part of the reason if > not _the_ reason. CAVEAT: I am aware of the ill effects of having too many things in post-command-hook and generally avoid it unless strictly necessary. In the message-mode buffer I'm writing this from: (t flyspell-post-command-hook) In Org mode: (prettify-symbols--post-command-hook t) In f90-mode: (jit-lock--antiblink-post-command eldoc-schedule-timer t) In elisp-mode: (jit-lock--antiblink-post-command eldoc-schedule-timer reveal-post-command t) Global value: (transient--post-command-hook repeat-post-hook) I have no idea why transient--post-command-hook is in there. I don't use transient at all. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 03:03:05 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 07:03:05 +0000 Received: from localhost ([127.0.0.1]:56500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyQDh-0005JK-02 for submit@debbugs.gnu.org; Sat, 29 Mar 2025 03:03:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44064) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyQDd-0005Ih-AW for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 03:03:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyQDW-0006QX-4A; Sat, 29 Mar 2025 03:02:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zr4yMEVjVV8O/KWGNbF26f55qPyoL9cS56PevA2+Ty4=; b=Dm6pqc7IWZwk JrbCAu37fll6SsrDwj0FLyEoXOUtASZ+H8u2I0pGOXZcBGOh19BNAjSR9l6ybzx6+PWGS5Go2tzqN 5bmJiXTSCu6ZlXD4Tyql6FS/tdlhrPDuqqedPDrXIDd7fjpOuS5VmdL/dgmvyJdxtdqw2u3C+lNfc cdquM8IX2Ys2nj9PUDFUSrSZKBLu+UlGqZ1iLGWLO+FGWd7Pwi7JXksSBcAU9SoLnboqMqdMJ2dG/ dxOS2JdG5gxFKR55uAOvpbyYgzhvK6ugMVaRkKQNBEVvIFtGr+FOJSvlSRSl6KM7L+vIuKeBl/43i 4/MMIICBM7JHWwoQDouljA==; Date: Sat, 29 Mar 2025 10:02:50 +0300 Message-Id: <86ecyg9v51.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87frixaymv.fsf@daniel-mendler.de> (message from Daniel Mendler on Fri, 28 Mar 2025 17:49:44 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> <87frixaymv.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Fri, 28 Mar 2025 17:49:44 +0100 > > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > >> Date: Fri, 28 Mar 2025 16:40:29 +0100 > >> > >> Eli Zaretskii writes: > >> > >> My `post-command-hook' list looks like this: > >> > >> Buffer-local: > >> (jit-lock--antiblink-post-command eldoc-schedule-timer > >> corfu--auto-post-command jinx--reschedule > >> whitespace-post-command-hook hl-line-highlight t) > > > > And in Org buffers? > > The first list was from the *scratch* buffer. This one is from an Org > buffer: > > (eldoc-schedule-timer corfu--auto-post-command jinx--reschedule > whitespace-post-command-hook hl-line-highlight t) That's already problematic, IMO. And then some people might enable flyspell-mode on top of all that. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 03:52:21 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 07:52:21 +0000 Received: from localhost ([127.0.0.1]:56609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyQzM-0007lA-HX for submit@debbugs.gnu.org; Sat, 29 Mar 2025 03:52:21 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:34567 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyQzI-0007kr-3p for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 03:52:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=eRsl79X+ot/gZ+E2idrTtwff1NsMi6Bi6TIzenV7W7A=; b=RdQTEWNCs7NSaRYb0PoNpfNKr1 cSTMfY4k8JJDRx+aTH9qLRMKHlprnzikgje3w9oOyp+urj4S2cOA2GqAdddeF9Lr6pKr1CxUSxd9R oOnBV3rdvYHaZpGivC8ZXnGklETf7vEGGFETIdLxLRjRlN0mi+Wc0nh3OC6HTka0hhks=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86ecyg9v51.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Mar 2025 10:02:50 +0300") References: <87iknzxski.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> <87frixaymv.fsf@daniel-mendler.de> <86ecyg9v51.fsf@gnu.org> Date: Sat, 29 Mar 2025 08:52:09 +0100 Message-ID: <87friwxoie.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Fri, 28 Mar 2025 17:49:44 +0100 >> >> Eli Zaretskii writes: >> >> >> From: Daniel Mendler >> >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> >> Date: Fri, 28 Mar 2025 16:40:29 +0100 >> >> >> >> Eli Zaretskii writes: >> >> >> >> My `post-command-hook' list looks like this: >> >> >> >> Buffer-local: >> >> (jit-lock--antiblink-post-command eldoc-schedule-timer >> >> corfu--auto-post-command jinx--reschedule >> >> whitespace-post-command-hook hl-line-highlight t) >> > >> > And in Org buffers? >> >> The first list was from the *scratch* buffer. This one is from an Org >> buffer: >> >> (eldoc-schedule-timer corfu--auto-post-command jinx--reschedule >> whitespace-post-command-hook hl-line-highlight t) > > That's already problematic, IMO. And then some people might enable > flyspell-mode on top of all that. In my experience, there is no problem, neither in Org nor in Elisp buffers. I wrote in my other mail: >> I don't have any problems with these hooks, since they are either >> cheap or only schedule some timers for more expensive operations. At >> least I don't notice any sluggishness and the PCHs don't appear in >> profiles. Enabling Flyspell on top is not a realistic scenario since `jinx--reschedule' comes from the Jinx spell checker, which is an alternative to Flyspell. The spell checking takes place later when Emacs is idle. The functions `jinx--reschedule', `eldoc-schedule-timer' and `corfu--auto-post-command' only schedule timers. The `hl-line-highlight' moves the line highlight overlay, such that it moves immediately with the cursor and does not lag behind. This is a similar scenario to changing the `cursor-type', where the cursor type should immediately reflect the editing state. Yes, we will check the cursor conditions too often, and often unnecessarily, but this does not cause slowdown as long as the check is sufficiently fast in comparison to the executed command. The only seemingly problematic hook is `whitespace-post-command'. I haven't checked it in detail. It looks complex but it mostly seems to modify some overlays and trigger fontification. Potentially some of the work there could be deferred. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 03:52:34 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 07:52:34 +0000 Received: from localhost ([127.0.0.1]:56613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyQza-0007li-4g for submit@debbugs.gnu.org; Sat, 29 Mar 2025 03:52:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35362) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyQzP-0007l7-K8 for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 03:52:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyQzI-0004P3-7V; Sat, 29 Mar 2025 03:52:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XMOW9yHaApX3S5FlZ2lyXSj5UL/d+zRK8Ww8KVdQvZs=; b=e4XWu9dfhvHv iDypZz9HOIRt3p6xyRAXHrP/3AbGgI7yc9EGa3i+hrRxxdKkIZa7FpKChhL3d0kioCl3jeLDwWqEF 8H6AAYcyYtDP1NZCuA/YKOfHvKsjUHXxlzc/05/6fAp9wnFg4CRcxUfyotCJ7/4ojGfrII90peDir cl5a16LC/4H3TeFu+UYSsQCTf53kz0SJxXX0tpS45De6ncSjIMOSQIq9EPqfRZb4j1SIuaiUBBntJ JulHTM/V6NV8raTwDwYvDoIU1cD5r/p54ktNGBOnrcBqUQTxvQiIoug6QXvowlziJSY9X7K3bxiA7 614XVDDxRd8f4tuHIh2Jrw==; Date: Sat, 29 Mar 2025 10:52:12 +0300 Message-Id: <865xjs9sur.fsf@gnu.org> From: Eli Zaretskii To: Daniel Colascione In-Reply-To: (message from Daniel Colascione on Fri, 28 Mar 2025 21:03:10 -0400) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <868qopbp40.fsf@gnu.org> <877c48654r.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 28 Mar 2025 21:03:10 -0400 > From: Daniel Colascione > CC: Eli Zaretskii , mail@daniel-mendler.de, juri@linkov.net, > 77224@debbugs.gnu.org > > >Can your proposal also handle whether user moves cursor? > > > >Another reason why post-command-hook is used is mostly for run code > >when user moves cursor position. > > I don't see why not? You could put (point) on your change list or something. I'm imagining that we just recognize forms in this list specially and add the appropriate low level hooks internally. > > >post-command-hook would run code even if user/cursor is idle and even > >for every /(unrelated)/ function in background, which can lead to high > >resource consumption. > > Yeah. Tragedy of the commons. Too many sheep grazing on the communal Emacs event loop. Yes, for this kind of feature to work in Emacs, there should be some mechanism that would scan all the important changes (whose name is a legion), and signal the relevant changes to potential clients. That sounds like one giant end probably quite expensive post-command-hook, doesn't it? From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 04:00:55 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 08:00:55 +0000 Received: from localhost ([127.0.0.1]:56629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyR7e-0008DH-Os for submit@debbugs.gnu.org; Sat, 29 Mar 2025 04:00:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53456) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyR7c-0008D1-4p for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 04:00:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyR7T-0005G7-74; Sat, 29 Mar 2025 04:00:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1y4cWuyV0JU6Q8QGNOKCgJtBeHjFJxnmLHMSaFASYlA=; b=Mn86QPCWh8qS xJ2blavh7z12+PSV8wkjJ1Jzw9E6LTi3wEWbzcxlBH/B2VVZ0YFFx7MQB8cCvmGdWu0y2HA71b4Hh oi+Fbx0IltPpiADzyCetnNLbUrNa5LknZRwKTaD8B5Qf8jBc2+6sAkG9dM0IJKnAG0I1l4g+kniTS rI/twDQwQ3ZyigIerHBem+4aB8PcOFwseC1EZkUrJhYN2a3ZClROvEz1VBRoBlyJKsk5+/9s6LbGM eQVsLcP0qTcnLuOP5xv9eBq83GCzSlh2KrsZ8ID/AFHoyFAsmIsxyonAdbLhIsPbfXTxsPWdWlmXP verzAO2BquPsB7h8D97Fkg==; Date: Sat, 29 Mar 2025 11:00:38 +0300 Message-Id: <8634ew9sgp.fsf@gnu.org> From: Eli Zaretskii To: Visuwesh In-Reply-To: <87wmc8k0o6.fsf@gmail.com> (message from Visuwesh on Sat, 29 Mar 2025 08:23:13 +0530) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87wmc8k0o6.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, eg642616@gmail.com, juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Visuwesh > Cc: Daniel Mendler , 77224@debbugs.gnu.org, > eg642616@gmail.com, juri@linkov.net > Date: Sat, 29 Mar 2025 08:23:13 +0530 > > Global value: > > (transient--post-command-hook repeat-post-hook) > > I have no idea why transient--post-command-hook is in there. I don't > use transient at all. Maybe you used some feature that loads transient, like emoji-insert? From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 04:17:43 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 08:17:43 +0000 Received: from localhost ([127.0.0.1]:56666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyRNv-0000Zh-AD for submit@debbugs.gnu.org; Sat, 29 Mar 2025 04:17:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57956) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyRNs-0000ZP-22 for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 04:17:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyRNk-0007Fb-Ua; Sat, 29 Mar 2025 04:17:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xilsB6UBOgw5uwMnmBAsldjeHXn/Radb1Vqvo3lZmB4=; b=r0Kx9kEeP8/g lrBY2CIk29MXJm6j21moAhzgIvVV9/A82D0yY/T2H5tU4AZmbYbWaj4I5AHlVp6IkewcTUt0UjDjr jQVPHo7Nbm9JEdepie2DmORbSkiEdQm0YF+5VTmLGIf0khH5feyIEqw5x7LNM1AFrLoEgZG/ZjBpI XPnn+GJouXQ1r++lTzaW7zwhwzM8cpRr6yHutWdWWztEgr1H1ERrGy9BwjVGdVYj9JdfPtucRS4/+ pQYYiAPqjKXTB++H6Stqo1kcvN/JBRP+vZbSBN5MHLB7W/F9o92syKc08oZ31GU6AxenewTL/dpTn pxnNTcZI7AZu/iS73YCw/Q==; Date: Sat, 29 Mar 2025 11:17:30 +0300 Message-Id: <861pug9rol.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87friwxoie.fsf@daniel-mendler.de> (message from Daniel Mendler on Sat, 29 Mar 2025 08:52:09 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> <87frixaymv.fsf@daniel-mendler.de> <86ecyg9v51.fsf@gnu.org> <87friwxoie.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Sat, 29 Mar 2025 08:52:09 +0100 > > The `hl-line-highlight' moves the line highlight overlay, such that it > moves immediately with the cursor and does not lag behind. You may not be aware, but moving and changing overlays disables some redisplay optimizations, and in many cases can trigger an additional immediate redisplay cycle. So doing that after every command exits in practice means every redisplay cycle is adversely affected. > The only seemingly problematic hook is `whitespace-post-command'. I > haven't checked it in detail. It looks complex but it mostly seems to > modify some overlays and trigger fontification. Potentially some of the > work there could be deferred. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 04:32:22 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 08:32:22 +0000 Received: from localhost ([127.0.0.1]:56699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyRc5-0001Kf-W9 for submit@debbugs.gnu.org; Sat, 29 Mar 2025 04:32:22 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:59979 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyRc2-0001KN-SJ for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 04:32:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=peqIGjzBAPFIEbTEdODnuE5BupgQz073mmrWKiXV61Q=; b=h5QtuwBsGkgIxUnoTWyBQ3c4RI 1aYC6ac5PTOsAYTJBeekMJ8YckF3xydG5GPIokGcbAfyjfT2tFMOXZy/lMtfRPkOPyb8/bvMnL72H ExtGwWLwTY4MJ/+1PmTAZXoZ8ZzdtrZLlUjpul6QhKfz+rGIR67ApXJjFN4Uq6qPIN1U=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <861pug9rol.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Mar 2025 11:17:30 +0300") References: <87iknzxski.fsf@gmail.com> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> <87frixaymv.fsf@daniel-mendler.de> <86ecyg9v51.fsf@gnu.org> <87friwxoie.fsf@daniel-mendler.de> <861pug9rol.fsf@gnu.org> Date: Sat, 29 Mar 2025 09:32:09 +0100 Message-ID: <87bjtkz186.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Sat, 29 Mar 2025 08:52:09 +0100 >> >> The `hl-line-highlight' moves the line highlight overlay, such that it >> moves immediately with the cursor and does not lag behind. > > You may not be aware, but moving and changing overlays disables some > redisplay optimizations, and in many cases can trigger an additional > immediate redisplay cycle. So doing that after every command exits > in practice means every redisplay cycle is adversely affected. I am aware. What do you suggest as an alternative? It would look odd if the `hl-line-overlay' would not move directly with the cursor and would lag behind. Some specialized code could handle this overlay such that it is treated more efficiently together with the cursor itself. But in practice not much would be won given that the `hl-line-overlay' has never caused noticeable problems. Maybe it has for others and likely in files with very long lines? For files with long lines I still use `so-long-mode'. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 04:51:26 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 08:51:26 +0000 Received: from localhost ([127.0.0.1]:56752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyRuX-0002Q1-NL for submit@debbugs.gnu.org; Sat, 29 Mar 2025 04:51:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44588) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyRuU-0002Oh-Bw for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 04:51:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyRuM-0002cr-1B; Sat, 29 Mar 2025 04:51:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i3mkfwgPv3RB/5fVaqUZLKOIToltYjnF1DnZU6z1olk=; b=OpNbOa3h2vJk xsqv9FJlbU4UnYmHJPfbGumPiD4kPvfpF3/qyPMc7krAVo8mZ79AF3AkDep78pR2wKVz5NLuu0N/A XwFVHSRrBDGBXBPLkBneDMUzxB0QYZqb+ZGFvgso6JMsDbTDetuGLuq9ogXsboLsuUEoGMoIOHWoX /EB5kAvSsWtyyyBLc6AURxGwONolPolWuDjuNb4XtkvWKjVWgZRzpQFiY/dR3ELmyE2cCT8HJzKH3 VcTSiulGJ0weczloIplyYW7lGvRbqoc1XZL+Xe1IdmD6L8gbllGGTfUWbKDX0xcTYfc0zUiNG5/s4 m9rwoKhRq5euWT45iBrP9Q==; Date: Sat, 29 Mar 2025 11:50:32 +0300 Message-Id: <86wmc88bl3.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87bjtkz186.fsf@daniel-mendler.de> (message from Daniel Mendler on Sat, 29 Mar 2025 09:32:09 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> <87frixaymv.fsf@daniel-mendler.de> <86ecyg9v51.fsf@gnu.org> <87friwxoie.fsf@daniel-mendler.de> <861pug9rol.fsf@gnu.org> <87bjtkz186.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Sat, 29 Mar 2025 09:32:09 +0100 > > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > >> Date: Sat, 29 Mar 2025 08:52:09 +0100 > >> > >> The `hl-line-highlight' moves the line highlight overlay, such that it > >> moves immediately with the cursor and does not lag behind. > > > > You may not be aware, but moving and changing overlays disables some > > redisplay optimizations, and in many cases can trigger an additional > > immediate redisplay cycle. So doing that after every command exits > > in practice means every redisplay cycle is adversely affected. > > I am aware. What do you suggest as an alternative? It would look odd if > the `hl-line-overlay' would not move directly with the cursor and would > lag behind. I could suggest one or two alternatives, but is it worth our time? is someone actually considering any such changes? My point was and remains the same: adding more and more features to post-command-hook is something to be avoided. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 05:18:49 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 09:18:49 +0000 Received: from localhost ([127.0.0.1]:56797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tySL3-0004J2-3V for submit@debbugs.gnu.org; Sat, 29 Mar 2025 05:18:49 -0400 Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:57149 helo=mail.qxqx.de) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tySKz-0004Ih-Oj for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 05:18:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Dm4OBKetEG1z6BF47WuEKpE8r/DQ8lDx1rYr7cXMf7M=; b=RD1wSA+CgwGHpxJv9yOcGxxgZN AWuAD0xReBq4d9tATEe1+0s6reD7Y7RZfv54/lznjLvrkADOMSORs/buMkqU0L27ZM1a6w5oG7tIB Y8mnv0Uua+1htNkVNejrOpwKuXoro7s7C+H0vDVony51cZzeeRygzk+T/jDJBLvlaQx4=; From: Daniel Mendler To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86wmc88bl3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Mar 2025 11:50:32 +0300") References: <87iknzxski.fsf@gmail.com> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> <87frixaymv.fsf@daniel-mendler.de> <86ecyg9v51.fsf@gnu.org> <87friwxoie.fsf@daniel-mendler.de> <861pug9rol.fsf@gnu.org> <87bjtkz186.fsf@daniel-mendler.de> <86wmc88bl3.fsf@gnu.org> Date: Sat, 29 Mar 2025 10:18:37 +0100 Message-ID: <87cye09ouq.fsf@daniel-mendler.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: >> From: Daniel Mendler >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> Date: Sat, 29 Mar 2025 09:32:09 +0100 >> >> Eli Zaretskii writes: >> >> >> From: Daniel Mendler >> >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net >> >> Date: Sat, 29 Mar 2025 08:52:09 +0100 >> >> >> >> The `hl-line-highlight' moves the line highlight overlay, such that it >> >> moves immediately with the cursor and does not lag behind. >> > >> > You may not be aware, but moving and changing overlays disables some >> > redisplay optimizations, and in many cases can trigger an additional >> > immediate redisplay cycle. So doing that after every command exits >> > in practice means every redisplay cycle is adversely affected. >> >> I am aware. What do you suggest as an alternative? It would look odd if >> the `hl-line-overlay' would not move directly with the cursor and would >> lag behind. > > I could suggest one or two alternatives, but is it worth our time? is > someone actually considering any such changes? Please do. I would like to understand your ideas. > My point was and remains the same: adding more and more features to > post-command-hook is something to be avoided. Your argument from above does not matter in the case of `cursor-type'. Since most commands do not trigger a modification of the `cursor-type', the only cost that gets added to the `post-command-hooks' is the inexpensive check of a few variables or conditions, which will not affect redisplay. I still do not understand why you are so strongly against a `post-command-hook' in this case. I see that you are out of principle against `post-command-hooks'. This makes sense given that these hooks can be abused easily. However in certain scenarios, after careful consideration, they might be acceptable. As Juri mentioned, a `post-command-hook' allows us to reliably change the `cursor-type' based on arbitrary conditions. In contrast, if we use multiple hooks, which are registered in multiple different subsystems, it is easy to miss relevant state changes. Daniel From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 06:07:32 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 10:07:32 +0000 Received: from localhost ([127.0.0.1]:56990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyT6B-0006qZ-VD for submit@debbugs.gnu.org; Sat, 29 Mar 2025 06:07:32 -0400 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]:53263) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyT68-0006qJ-VZ for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 06:07:29 -0400 Received: by mail-pl1-x642.google.com with SMTP id d9443c01a7336-2239c066347so69537595ad.2 for <77224@debbugs.gnu.org>; Sat, 29 Mar 2025 03:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743242843; x=1743847643; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=2tQ91IV7NpHHPG5KQkMB5+xv9SvIQzlVw9LARGq16vI=; b=H1GTrE/YMXOKoGltbMCwUGlBYa5XbNO463Ing0ugFTb9CenVLS101cX0S3pv+14a2M FWVLKoneOOyzBhOfFPxTsn6gPjMRo33P3xsjM+y4NAuVw0za4f9Ih/DhZpO1GSvm04EK BotOjX/6Cwpg84l/w/hPYPLvEbgAPbwmvPx650o3vfPb8DU8XLPF8F5+IEooBmFmeiHb TQDlVVLr8Pgwi21TFLvNgwp5Z9Krm3TCriB5Q2bs1yU9ufXuMdPKekLxrQg2H1eew/P7 bDIny5Wx/kuFeYfM8pQ9oTijJ2BPxcmsyqTNrYpuV5PxFmZRoHLbkcFxRx0hnQQ3RCHh Zc9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743242843; x=1743847643; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2tQ91IV7NpHHPG5KQkMB5+xv9SvIQzlVw9LARGq16vI=; b=gruqvTKre3k2KxWgJnKP8xto3hjj6Ngh9Jhz1oUz74d6VI/RnLcZDDnYj9VzYwdQbG C4wjZJpmChuiC1AjaeyuxE/FA5Dwfp43KEkILWykKrrs4tvxzK12645ttJSzBSjbIg52 B8C9EVLAICeLEH4bpumOuDiE6BSjnG69n+yX1f4UlwmeOi+7SYaA/9AIwckkf24wNTrf H9Rg2PGXKWMNRsV8bIJpB1dBo5kxTAgb0QcrQqcXMtgEbaV0ZraruL4ssZeULLZ1Ntj3 Qhwyu1QA67B/XzvP+ZBoYylVJJgZMVv8++pufp9X9N7V22QTSBY5lHIaHdYxi7Ng2qIA 1Vbw== X-Forwarded-Encrypted: i=1; AJvYcCVi6URa9OVCWSVrwf6WLYwa3QgbAtuBlRZWlcqBTVKRpW1zgaZQJIrQ364agxuu/3i29X9b1A==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yz5KqUhZChgmFSaz44eoK+5Fuw+AaGG0UYeT7/abwXwjbeJxUhQ U49YKtArwnxbycJcWHdNpetyp27PBEoiwFCR2vzIym8FzggB0oCf X-Gm-Gg: ASbGnct8attUeNawo2/vTlFyxD2RmrT6351ea20nBcLwfb+l7I3TIKfcEK3jFtvFLCL dh74jrWpIeAUtCs/jIkGJogmxiCEjtfio16P+QuSD0bxvzyH+1ghVfPyIIiMDK0BDdaeR8kkCiY uufpOemU3AavnRFUj/1FB2pNQPzwApigeWXUncYYh+IN6TnPM6fwVVOQx92agKMy+mZZ2qOsKnk od24F4V3iZhotY42q7BDmVVJlI7KK3LcQvMeJWkjyH4L2HGqGe0Wg+KqbYbRca6wpz22J3jT4iM MCpR7buUG8nnsrj5/xgd0PFYpEIGrHyu0z9kCv6J91GHlA== X-Google-Smtp-Source: AGHT+IELd00OOzu6wwzRRO335j7Q/vPJ+f0u5ueuMPm5YXv4IJ9kATWQxWJElkNkuiuEnzMW7r58/A== X-Received: by 2002:a17:903:1c5:b0:225:adf8:8634 with SMTP id d9443c01a7336-2292fa0f1bdmr29734935ad.51.1743242842924; Sat, 29 Mar 2025 03:07:22 -0700 (PDT) Received: from ?IPv6:::1? ([2401:4900:120e:c4da:d85a:dbff:fe3a:41b6]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-af93b67e754sm2979708a12.6.2025.03.29.03.07.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Mar 2025 03:07:22 -0700 (PDT) Date: Sat, 29 Mar 2025 15:37:13 +0530 From: Visuwesh To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' User-Agent: K-9 Mail for Android In-Reply-To: <8634ew9sgp.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87wmc8k0o6.fsf@gmail.com> <8634ew9sgp.fsf@gnu.org> Message-ID: <348B3268-0379-4265-BA5D-300A3E16010F@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 77224 Cc: mail@daniel-mendler.de, eg642616@gmail.com, juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 29 March 2025 13:30:38 GMT+05:30, Eli Zaretskii wrote: >> From: Visuwesh >> Cc: Daniel Mendler , 77224@debbugs=2Egnu=2Eo= rg, >> eg642616@gmail=2Ecom, juri@linkov=2Enet >> Date: Sat, 29 Mar 2025 08:23:13 +0530 >>=20 >> Global value: >>=20 >> (transient--post-command-hook repeat-post-hook) >>=20 >> I have no idea why transient--post-command-hook is in there=2E I don't >> use transient at all=2E > >Maybe you used some feature that loads transient, like emoji-insert? No, I never did=2E I essentially never use any transient based command si= nce it is far too complex for my simpleminded brain=2E From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 08:15:58 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 12:15:58 +0000 Received: from localhost ([127.0.0.1]:57413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyV6T-0001vk-HF for submit@debbugs.gnu.org; Sat, 29 Mar 2025 08:15:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56730) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyV6R-0001gj-1i for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 08:15:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyV6J-0001qp-7A; Sat, 29 Mar 2025 08:15:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xVbUbxcBQ54hrUUqq5sNwyJ07yGyCSDE+hHVWKHl1gg=; b=hFTTREnbPmZy N0WzsvnlJiupextQt+7zBH00DpuemYg86LqzfwMZZOok7jLAo+x+QMlnNYRyneF3CIrJzMfsSvaW8 GouR/MdVE7u/cGrRMCoaFgTVEpi5u1kZQ0YmYM4LgjZ5nJwhHnA9IRbOF4UaERGsglbH+dRoZa50Y eqfYtt7/0G7kAxEjYdM41WyTScoMADlpUtmqV2RVltw3OC0vRagmRY2vEMuy7GzmFriluz/Lm8KRn 8Gh7CHOfYUxgXwb7FKyjN2u6whRyZSisUoJ9anfiQHhyRlnEOklQETsdTlqsh01eWxLqvT4spatHI NyyuI+ViiWPTXIykcVOf9A==; Date: Sat, 29 Mar 2025 15:15:41 +0300 Message-Id: <86friw6niq.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <87cye09ouq.fsf@daniel-mendler.de> (message from Daniel Mendler on Sat, 29 Mar 2025 10:18:37 +0100) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> <87msd5rwnm.fsf@daniel-mendler.de> <86frix9kv0.fsf@gnu.org> <87frixaymv.fsf@daniel-mendler.de> <86ecyg9v51.fsf@gnu.org> <87friwxoie.fsf@daniel-mendler.de> <861pug9rol.fsf@gnu.org> <87bjtkz186.fsf@daniel-mendler.de> <86wmc88bl3.fsf@gnu.org> <87cye09ouq.fsf@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eg642616@gmail.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Mendler > Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > Date: Sat, 29 Mar 2025 10:18:37 +0100 > > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > >> Date: Sat, 29 Mar 2025 09:32:09 +0100 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Daniel Mendler > >> >> Cc: eg642616@gmail.com, 77224@debbugs.gnu.org, juri@linkov.net > >> >> Date: Sat, 29 Mar 2025 08:52:09 +0100 > >> >> > >> >> The `hl-line-highlight' moves the line highlight overlay, such that it > >> >> moves immediately with the cursor and does not lag behind. > >> > > >> > You may not be aware, but moving and changing overlays disables some > >> > redisplay optimizations, and in many cases can trigger an additional > >> > immediate redisplay cycle. So doing that after every command exits > >> > in practice means every redisplay cycle is adversely affected. > >> > >> I am aware. What do you suggest as an alternative? It would look odd if > >> the `hl-line-overlay' would not move directly with the cursor and would > >> lag behind. > > > > I could suggest one or two alternatives, but is it worth our time? is > > someone actually considering any such changes? > > Please do. I would like to understand your ideas. One idea is to use an idle timer. Another is to reimplement this in the display engine (which tracks the cursor position as part of its job). > > My point was and remains the same: adding more and more features to > > post-command-hook is something to be avoided. > > Your argument from above does not matter in the case of `cursor-type'. > Since most commands do not trigger a modification of the `cursor-type', > the only cost that gets added to the `post-command-hooks' is the > inexpensive check of a few variables or conditions, which will not > affect redisplay. > > I still do not understand why you are so strongly against a > `post-command-hook' in this case. I see that you are out of principle > against `post-command-hooks'. This makes sense given that these hooks > can be abused easily. > > However in certain scenarios, after careful consideration, they might be > acceptable. As Juri mentioned, a `post-command-hook' allows us to > reliably change the `cursor-type' based on arbitrary conditions. In > contrast, if we use multiple hooks, which are registered in multiple > different subsystems, it is easy to miss relevant state changes. I think I already said everything I could, and repetition will not help. So I will respectfully bow out of this discussion. From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 13:57:04 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 17:57:04 +0000 Received: from localhost ([127.0.0.1]:32969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyaQZ-0004qO-Fg for submit@debbugs.gnu.org; Sat, 29 Mar 2025 13:57:03 -0400 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]:44192) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyaQW-0004pp-Oc for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 13:57:01 -0400 Received: by mail-oi1-x241.google.com with SMTP id 5614622812f47-3f68460865aso2050771b6e.0 for <77224@debbugs.gnu.org>; Sat, 29 Mar 2025 10:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743271015; x=1743875815; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=9bKa8z9xyAJ/TdRXcmzNkNvxsDkZgoGhXQSdKWhy4Hg=; b=hjvymHSrGdP9lpGbB1EJe8jGUalYcoEh2TKSRnWUUuavacqGN3QzxLVknqYnPujvpY KdplqVsB65W2PYpbxJwX7IrqwgJAJLdlnOLrCmiXXyimHnBBLS7IELJ8X2h8wi/CP9Jc h39JzhDmSqfE4DS65zJNCv6WL4hUvd3dwb9SFUgLMa3LGq6/kjasDVZMsZcthdy1hOhs m5ZBJHvBKsoqQL2H4klxqVsHl8uVGn9qliDkw+blhNVhMYp/eyCXjrFiM/sZsptspA8a Af+Vmua5sOtXoHk+3QBf07PeKFXSCm/MsY2pu63x/YBH6R9HElsFGbAkfaV+jOVdppvw l0Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743271015; x=1743875815; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9bKa8z9xyAJ/TdRXcmzNkNvxsDkZgoGhXQSdKWhy4Hg=; b=Gj8cwJqn1/Cvbpr7ywf1XcxqoE8apI9YWT//H8V67TdlUPqvA3bR3WGVp0wt2wRdxO La7C8tFd72fu37MoK2TPOmouUvd32uZMJ5LXgdN5wrMjwh9jLA/vm+equQ+gO2ml5hGu jCM2EM8FyLqCZcRrdILbSH9IF2UZLg3VTPO/QXLp30r8Nrsz1dMU2R/ABC3R3h4rwws/ P4lRTKxyVavlLQ0V8JdDglNfUxli4H9ad//NIsrPEqgAiu0UwV1NMvnzZFiFMix+f+ya G8yvoJitKiHjYuBC8VxZlh19ZJ3if6F80Jw1aHAOWGcMPjntR1j1Gz5D3ghR2GjooCSP 2W0w== X-Forwarded-Encrypted: i=1; AJvYcCWILGOSODvLaaN0qdYj0J16usRNU9xnx52NexpjuFEqL54zyBNuD2oZRkfXqigxgmnOA8ywkQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx39DBrg2ngFT50OqZWYP2ZsqWphiKAt7i3MebG0rzMmpTUxFIs /qVg11MWvRvt2hPHo/Dy+++ha22PmZkC5CLgoelHd6HNVArIf3Kf X-Gm-Gg: ASbGnctTJ0v+ecaJR4JWvfH6mgtgUixxjEHdrSQibo9YtCr5567Etl+6FzFpmSpszBK T2OuTR/H9CzZi1Up3yAPvSj3WuACKpqaQ9anWlQJE6zWWlUnlemwZCc40kfEKvujIy7qsjqq9pa wwLplhwTMkew1ouvVGBjl+Z8EIIy3YU8A4pczaNWUQ1UR+SxE47Uai+W8k6sFJX5kCq+WtJPW7L O9YwaZRhVAI53TwAid9gr8bRgDY2+fYgSb1iS+PN8NK2jYoEXPzFC789wqNxf2jLNptavK8IEEr j73sQBFzGJhY X-Google-Smtp-Source: AGHT+IHBiVhszbuY9TjKBbr5LSui5eMC88M8V+dQUkP7ondoHJt07HaTO4WckEzC4xpW3BqBk4t6FA== X-Received: by 2002:a05:6808:d54:b0:3f8:b73b:682d with SMTP id 5614622812f47-3ff0f5d9d1fmr2128833b6e.32.1743271014800; Sat, 29 Mar 2025 10:56:54 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ff05295402sm794647b6e.43.2025.03.29.10.56.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Mar 2025 10:56:54 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86bjtlbqge.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <877c4aa0m8.fsf@daniel-mendler.de> <86pli2befe.fsf@gnu.org> <878qoq5iui.fsf@daniel-mendler.de> <86bjtlbqge.fsf@gnu.org> Date: Sat, 29 Mar 2025 11:56:52 -0600 Message-ID: <87wmc7pvob.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: Daniel Mendler , juri@linkov.net, 77224@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Eli Zaretskii writes: > How long is the post-command-hook list in your production sessions? > Should we poll users to give their data? Just yesterday someone > complained on Reddit that Emacs is too slow, and I have no doubt that > features that use post-command-hook are at least part of the reason if > not _the_ reason. this is what i have in every prog mode: (eldoc-schedule-timer treesit-fold-indicators--post-command jit-lock--antiblink-post-command fill-indicator--set-warning indent-bars--highlight-current-depth goggles--post-command corfu--auto-post-command yas--post-command-handler whitespace-post-command-hook t eldoc-box--follow-cursor) Most of these functions uses this hook for run code when cursor changes position since there is not a hook for that (yet). I think there should be a entry in etc/TODO for hooks when: - buffer content changes - cursor changes position - undo (and redo) commands are used. - rendering/displaying frame content (thus the code would not run for every function). This would reduce post-command-hook usage and help Emacs ecosystem a lot. --==-=-= Content-Type: text/html

Eli Zaretskii <eliz@gnu.org> writes:

How long is the post-command-hook list in your production sessions?
Should we poll users to give their data? Just yesterday someone
complained on Reddit that Emacs is too slow, and I have no doubt that
features that use post-command-hook are at least part of the reason if
not the reason.

this is what i have in every prog mode:

(eldoc-schedule-timer
treesit-fold-indicators–post-command
jit-lock–antiblink-post-command
fill-indicator–set-warning
indent-bars–highlight-current-depth
goggles–post-command
corfu–auto-post-command
yas–post-command-handler
whitespace-post-command-hook
t
eldoc-box–follow-cursor)

Most of these functions uses this hook for run code when cursor changes
position since there is not a hook for that (yet).

I think there should be a entry in etc/TODO for hooks when:

  • buffer content changes
  • cursor changes position
  • undo (and redo) commands are used.
  • rendering/displaying frame content (thus the code would not run for every function).

This would reduce post-command-hook usage and help Emacs ecosystem a lot.

--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 14:26:51 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 18:26:51 +0000 Received: from localhost ([127.0.0.1]:33020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyatO-0006Pi-Sr for submit@debbugs.gnu.org; Sat, 29 Mar 2025 14:26:51 -0400 Received: from mail-oa1-x44.google.com ([2001:4860:4864:20::44]:53469) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tyatM-0006PS-P5 for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 14:26:49 -0400 Received: by mail-oa1-x44.google.com with SMTP id 586e51a60fabf-2c7b2c14455so1901308fac.2 for <77224@debbugs.gnu.org>; Sat, 29 Mar 2025 11:26:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743272803; x=1743877603; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=Xi3VhtJrohxGJCBwa21uwBeIJ6bphUKcKZOUp8EqogQ=; b=liPBICcFTOpcmBLDgIQEcPbyhF48cxdeIQY5eNwPUjjhghOA4iJVG593kVDLgmbQuu nd1Aqu/D727ec9Z9otR1OQ+wwOzXOuvpfuBqCwr7Al3bKhpV/Ex+yS0DMuXt0J8ajoHO VXp+fow237TBvuQWJfQ1HgXvgK/Y+xWpzVOJPWV1oI9o/vT8fD4D7lAhEpfq/FcB4CCP HXKbWlgW5LJ0vpOiDSIX7pCX3PvxlagCNwxSHZa8g0cfJVpzeg1VuhOZBohhxAfElktg Wc3g8UvfOrkBfGP16omuLItmAR9gsswTcRX+Dzv2iOyc2zxsHZMej4+2neMHGqdl8ibS Ie5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743272803; x=1743877603; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xi3VhtJrohxGJCBwa21uwBeIJ6bphUKcKZOUp8EqogQ=; b=H7wRl1tEMkUtWzsJiRwNGJZdRHT9txeMeBe+cAaHBjc73INbDfHlnEQ5smV5DmxhD1 nCuKC/XiTQYWhwSS8ZLVe/53+v9Jesi867YVNZwRyMOSKC9kcIr4Ai3vQg0YE252RYLz hhGaYZI08o2PUIrnJrJJtuIsFwQy+xLeT4XSKxLiD1uhFLi3u3bjVGmPO4qOAfitERyy 8vuleMy8KllJrszfUZJbFdCQ/7WaTuS3YoweuLz+K2oBSvmwPf2FxucM2n7XgQ/iSgw8 9Bc2eRBdF0x+mAr1c+yxwo7xhn2Vg1XBM4zYpIiDyuC4UJki5w9/vhGXZbQB/3SoydpG cGOA== X-Gm-Message-State: AOJu0YzgUA0KeUN7E9QufUi20zQ84tdJ42w+Lbujmaw6bqyHbEm3Am4D STEwnHzUrUppvt3dK1hZOdbOVA8qS4/tEnTYmnOxisANYdNr2ESF X-Gm-Gg: ASbGncthMJjzRPp2paei5Dl5C2Exwx8uuRo7RpK1efBIStYocExBw5uKibrQZcGxWBk Yo370pAa+DI+YskReQ/ru7vf0MSxOWCW00Xjw4VovH6ckR/BjFwzfPeRju1aXEsxwv9l/DFl8ZC +MoRq8FM0MtDKeqnlE24gEO32syf9Vn14LDVRt6jCCx+Xax7uXOI9ZObOyIlF+JOZBi/Q5Y6Nz4 Q0C7GxcJOp0cyJj3p3FUuSTR2Jf8PvDD8zwpK4sixmWnuQtCv9wIB2/b7BM96NuBHZyX8kemy2J /1piv6u3Gx4y X-Google-Smtp-Source: AGHT+IHb0bD9QSYgllxTdKK79wiqK8Mllj7AzfDPjyimMP7cZdbTS11Oz6axxwHIoorUT1hp4WuToA== X-Received: by 2002:a05:6871:d08a:b0:2bd:456c:923 with SMTP id 586e51a60fabf-2cbcf4fbbe8mr2291142fac.11.1743272802760; Sat, 29 Mar 2025 11:26:42 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c58266ea9sm819444a34.44.2025.03.29.11.26.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Mar 2025 11:26:42 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Juri Linkov Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87msd5r4z8.fsf@mail.linkov.net> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> Date: Sat, 29 Mar 2025 12:26:40 -0600 Message-ID: <87r02fpuan.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, eliz@gnu.org, Daniel Colascione , mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Juri Linkov writes: >> I've updated the patch which should use the mode hook instead using >> post-command-hook or idle timers (and allows (implicitly) to user use >> post-command-hook (but that is user responsibility add it or not)). >> Also this should refresh the cursor while switching windows. >> However I've deleted the function/lambdas support as conditions because >> i found it problematic. >> I've test it only for overwrite-mode, I ask if anyone wants to give it a >> try. > Please note that this is insufficient for 'repeat-mode'. > Currently it requires adding an advice to update the cursor > on the repeat timer events: > (add-function :after repeat-echo-function #'cursor-indicators--update-indications) > since need to update the cursor when the timer is fired: > (run-with-idle-timer timeout nil #'repeat-exit) > (defun repeat-exit () > (setq repeat-in-progress nil) > (funcall repeat-echo-function nil)) > This problem can be solved by adding a hook: > (defun repeat-exit () > (setq repeat-in-progress nil) > (funcall repeat-echo-function nil) > (run-hooks 'repeat-exit-hook)) > Then 'cursor-indicators-mode' needs to add this hook: > (define-minor-mode cursor-indicators-mode > ... > (add-hook 'repeat-exit-hook #'cursor-indicators--update-indications) > Then maybe it's possible to add more hooks for other features as well. > The drawback of this approach is that specific hooks make the cursor updating > less reliable than with using post-command-hook. Well, then I think the best solution for this would be to make this package (cursor-indicators) part of the C code. I'll see what I can do. --==-=-= Content-Type: text/html

Juri Linkov <juri@linkov.net> writes:

I've updated the patch which should use the mode hook instead using
post-command-hook or idle timers (and allows (implicitly) to user use
post-command-hook (but that is user responsibility add it or not)).

Also this should refresh the cursor while switching windows.

However I've deleted the function/lambdas support as conditions because
i found it problematic.

I've test it only for overwrite-mode, I ask if anyone wants to give it a
try.

Please note that this is insufficient for 'repeat-mode'.
Currently it requires adding an advice to update the cursor
on the repeat timer events:

(add-function :after repeat-echo-function #'cursor-indicators–update-indications)

since need to update the cursor when the timer is fired:

(run-with-idle-timer timeout nil #'repeat-exit)
(defun repeat-exit ()
(setq repeat-in-progress nil)
(funcall repeat-echo-function nil))

This problem can be solved by adding a hook:

(defun repeat-exit ()
(setq repeat-in-progress nil)
(funcall repeat-echo-function nil)
(run-hooks 'repeat-exit-hook))

Then 'cursor-indicators-mode' needs to add this hook:

(define-minor-mode cursor-indicators-mode
…
(add-hook 'repeat-exit-hook #'cursor-indicators–update-indications)

Then maybe it's possible to add more hooks for other features as well.

The drawback of this approach is that specific hooks make the cursor updating
less reliable than with using post-command-hook.

Well, then I think the best solution for this would be to make this
package (cursor-indicators) part of the C code.

I'll see what I can do.

--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 29 14:40:50 2025 Received: (at 77224) by debbugs.gnu.org; 29 Mar 2025 18:40:50 +0000 Received: from localhost ([127.0.0.1]:33036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyb6v-00079V-Ev for submit@debbugs.gnu.org; Sat, 29 Mar 2025 14:40:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40002) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyb6q-000798-WF for 77224@debbugs.gnu.org; Sat, 29 Mar 2025 14:40:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tyb6j-0000Gh-94; Sat, 29 Mar 2025 14:40:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=qOvou2tJ8KdvLftonrwyV1b4qWEbFBPpsTANuvhvNAI=; b=loiXymz4iBghNAW6bOaA By1leSXtTLC72qgtOB04liNbGc0oOD05NDHS/4UpOGAWeAfVOUQr4SF7uFwgFiP+s37n/Dcyk65Oo WI8GjhLGKmoNx3jCsDUdDOpZ0pxwiNyw9SM6ev12Oe9jiT2kya5YU5Rd40Kd6gwzzbZ9TOKp4vZz2 mToY7lPQTC1DTW+46Vs9I2hJXAegT1S+8BHfBWJumvnmpHpfVmTGJWBwvKt3Ka+NO8aM88eTD+6VZ kuFmYtUeYcrRzrjY5k3dij9wZ0IirpA4m8sb7sKloSYZaOAil5gHAKnftSFE2npA7e5E+I4ct2rw5 qzywOiS5xuAGYg==; Date: Sat, 29 Mar 2025 21:40:27 +0300 Message-Id: <86tt7b65pg.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: <87r02fpuan.fsf@gmail.com> (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Sat, 29 Mar 2025 12:26:40 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, dancol@dancol.org, mail@daniel-mendler.de, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez > Cc: 77224@debbugs.gnu.org, eliz@gnu.org, Daniel Colascione > , mail@daniel-mendler.de > Date: Sat, 29 Mar 2025 12:26:40 -0600 > > Juri Linkov writes: > > I've updated the patch which should use the mode hook instead using > post-command-hook or idle timers (and allows (implicitly) to user use > post-command-hook (but that is user responsibility add it or not)). > > Also this should refresh the cursor while switching windows. > > However I've deleted the function/lambdas support as conditions because > i found it problematic. > > I've test it only for overwrite-mode, I ask if anyone wants to give it a > try. > > Please note that this is insufficient for 'repeat-mode'. > Currently it requires adding an advice to update the cursor > on the repeat timer events: > > (add-function :after repeat-echo-function #'cursor-indicators–update-indications) > > since need to update the cursor when the timer is fired: > > (run-with-idle-timer timeout nil #'repeat-exit) > (defun repeat-exit () > (setq repeat-in-progress nil) > (funcall repeat-echo-function nil)) > > This problem can be solved by adding a hook: > > (defun repeat-exit () > (setq repeat-in-progress nil) > (funcall repeat-echo-function nil) > (run-hooks 'repeat-exit-hook)) > > Then 'cursor-indicators-mode' needs to add this hook: > > (define-minor-mode cursor-indicators-mode > … > (add-hook 'repeat-exit-hook #'cursor-indicators–update-indications) > > Then maybe it's possible to add more hooks for other features as well. > > The drawback of this approach is that specific hooks make the cursor updating > less reliable than with using post-command-hook. > > Well, then I think the best solution for this would be to make this > package (cursor-indicators) part of the C code. > > I'll see what I can do. Let's please discuss your ideas before you implement them, to make sure you don't work on some ideas that we might object to. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 30 14:01:30 2025 Received: (at 77224) by debbugs.gnu.org; 30 Mar 2025 18:01:30 +0000 Received: from localhost ([127.0.0.1]:38045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tywyQ-000065-3N for submit@debbugs.gnu.org; Sun, 30 Mar 2025 14:01:30 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:39399) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tywyN-00005q-4u for 77224@debbugs.gnu.org; Sun, 30 Mar 2025 14:01:27 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id DCE1C44376; Sun, 30 Mar 2025 18:01:15 +0000 (UTC) From: Juri Linkov To: JD Smith Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> Date: Sun, 30 Mar 2025 20:55:20 +0300 Message-ID: <87a592h9hy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddujeejjedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgfgsehtkeertddtreejnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecuggftrfgrthhtvghrnhepiedvvefggfetudeklefggfeugeehheeuueffudelieelveehkeelffdtudetgeelnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohepiedprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgtphhtthhopegurghntgholhesuggrnhgtohhlrdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepjeejvddvgeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvgheigedvieduieesghhmrghilhdrtghomhdprhgtphhtthhopehjughtshhmihhth hesghhmrghilhdrtghomh X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Elijah Gabe =?iso-8859-1?Q?P=E9rez?= , Daniel Colascione , Eli Zaretskii , mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Please note that this is insufficient for 'repeat-mode'. >> Currently it requires adding an advice to update the cursor >> on the repeat timer events: > > I solved this problem by wrapping the `repeat-echo-function' and `after-focus-change-function'. > > https://gist.github.com/jdtsmith/a169362879388bc1bdf2bbb977782d4f Interesting to see that you switched from `post-command-hook' to `repeat-echo-function' and `after-focus-change-function'. So we could have an option that allows switching between 1) idle timers, 2) 'post-command-hook', 3) a list of more specific hooks. In any case we still need to add such a condition: (if (memq 'repeat-in-progress cursor-indicators-conditions) (add-function :after repeat-echo-function #'cursor-indicators--update-indications) (remove-function :after repeat-echo-function #'cursor-indicators--update-indications)) that have to be added only when the customized value contains 'repeat-in-progress'. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 30 14:04:47 2025 Received: (at 77224) by debbugs.gnu.org; 30 Mar 2025 18:04:47 +0000 Received: from localhost ([127.0.0.1]:38049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tyx1b-0000CV-9B for submit@debbugs.gnu.org; Sun, 30 Mar 2025 14:04:47 -0400 Received: from dancol.org ([2600:3c01:e000:3d8::1]:60920) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tyx1Y-0000CL-RV for 77224@debbugs.gnu.org; Sun, 30 Mar 2025 14:04:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Wz/oZUfCW0V5fOYjfzSpv8T62QexXB0X/Rt/opwG4y8=; b=cWCjsQbvGs1y64gDzAfTZFRGtp AQPhFfZETw4TDp9oXFcfINlX2b9xQviev8O0tMauHwQEdLwo8/k6jC/5UCWxvytWlEWDCRYA6EINl 2dDTiNpmu+/C1I/yW96Uz56DqEb5bes/s5WuBivKY1DbkpBu6Gsl148c4VKqocABE/EkEPYoHdgQl tM7wNFAFKre89OzyqULbopvO1RPwW5KdpV0jhGnpaLLLMV1dBgCq3ctOs9kuXHFSnyI3UgTF+UeTZ HX2sgN8B9xDYVnEjd7wswjePPJWNDJCI9NVKg5DfhtEYPIFts2FpUJQlVYyFwQDt0ksy5uMWbBqrh xnPiY6ow==; Received: from dancol by dancol.org with local (Exim 4.96) (envelope-from ) id 1tyx15-004YQX-1r; Sun, 30 Mar 2025 14:04:15 -0400 From: Daniel Colascione To: Juri Linkov Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87a592h9hy.fsf@mail.linkov.net> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87a592h9hy.fsf@mail.linkov.net> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Sun, 30 Mar 2025 14:04:40 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Elijah Gabe =?utf-8?Q?P=C3=A9rez?= , Eli Zaretskii , JD Smith , mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Juri Linkov writes: >>> Please note that this is insufficient for 'repeat-mode'. >>> Currently it requires adding an advice to update the cursor >>> on the repeat timer events: >> >> I solved this problem by wrapping the `repeat-echo-function' and `after-= focus-change-function'. >> >> https://gist.github.com/jdtsmith/a169362879388bc1bdf2bbb977782d4f=EF=BF= =BC > > Interesting to see that you switched from `post-command-hook' > to `repeat-echo-function' and `after-focus-change-function'. > > So we could have an option that allows switching between 1) idle timers, > 2) 'post-command-hook', 3) a list of more specific hooks. > > In any case we still need to add such a condition: > > (if (memq 'repeat-in-progress cursor-indicators-conditions) > (add-function :after repeat-echo-function #'cursor-indicators--upda= te-indications) > (remove-function :after repeat-echo-function #'cursor-indicators--upda= te-indications)) > > that have to be added only when the customized value contains 'repeat-in-= progress'. This is exactly the sort of complexity that nobody but those on this thread will care about and that we need to abstract behind some stupid-easy DWIM interface. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 31 19:41:25 2025 Received: (at 77224) by debbugs.gnu.org; 31 Mar 2025 23:41:25 +0000 Received: from localhost ([127.0.0.1]:43512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tzOkv-0001GH-2m for submit@debbugs.gnu.org; Mon, 31 Mar 2025 19:41:25 -0400 Received: from mail-oa1-x43.google.com ([2001:4860:4864:20::43]:46444) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tzOks-0001Fa-Tw for 77224@debbugs.gnu.org; Mon, 31 Mar 2025 19:41:23 -0400 Received: by mail-oa1-x43.google.com with SMTP id 586e51a60fabf-2bd2218ba4fso1917186fac.1 for <77224@debbugs.gnu.org>; Mon, 31 Mar 2025 16:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743464477; x=1744069277; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=T98btavddOGMt7fKYxLpokBaOEAWeUgbOUbB0XQJ3hg=; b=Pl8vTEX0x61GJDe+kipNeNY47X2s78VNX3G1kDBojwKfk/u+X3qZ2KOcqsBk1ei7Ay v4NEkhs6APhGuj+a7JQVvg8dMQFJLb7lJhniDSe3ObTzwInKV1YUqmaKCwqmkESQNiKx BkAKQgRan5dZ6G/G80+TZO5ZML5oQGvM0UjSYEJgkvcMTK85esLA0eGJoMQ1M5Q3KVmJ 0nqJWugE6a56ABSnWfItYpfvmjLX8DZYvUu4EFdR0XOfjZpsOwu5IvDYNrXFWSh5rwYl Bp4CeK0Yd+cR/+HDYlcKqIQ/Q/FQP6tZGPhHmvBO3nSZQEzwZFKEhacJhPgd6IUZXqcs I/Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743464477; x=1744069277; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T98btavddOGMt7fKYxLpokBaOEAWeUgbOUbB0XQJ3hg=; b=MUIfiO+M8Vfs1nnupGqSBrWsVmZtN5xRz6L50DAA1BOEQY9b/YxK66LSQNb7IeDcY0 q/aNn2SfTkLAqAxWT0NVe0qtyxuXilndVUyc5HuC6mdXdrE2cHUUwNUK40q3ApczNPoI 8XuuALLZyTMgxJtKjeF0OgFPFRTxfJ3Z0+UO5SYuH0X6CCUAFS+qiV234VUgJfLp/nmb GGCDha4UmJ1dDP5/6mNI3nnxcJ8TxxDOj9dWuM76Kq7wS9DTY7x1kGBp3nUXjcdES+x/ 2yhP3kP/s2IobpdhzlBjqQavv5/KP1Pn7SJQU2280LLwEjpS7NHGg5/LBbBr4b2I49HD Tgug== X-Gm-Message-State: AOJu0YxiE1SwkRa/r1yisIRY0FIgHeUa9tlKxuBMVEfvaXE32ckFcY1s HdvRMAOeXL09m6WpvFg8wz4FFA/Ygre0gM/zmkBCb2gk9Up3MEuSu37dLAUI X-Gm-Gg: ASbGnct1pkEwn+LIFYYGwOkML7bKGzPf+7agH5X4qEtbMU5zxH7YE5z9xH5cHrHbnq8 Bk5+3gpE7gRDJQDSIWDsR2fXuMhGZfqS4iGkxJg17Det/bwSJ3yp4fipk5tqIN6jAqCwPH7kQOA A/P4FWxTcCB/7cIwWTM9u1lkbDsIxllZV9Bv7ycTnXD15Ud3ZlVsY9rj/2E4TPXQbRaqOPKWiE0 P3Pqf2OaznNswWtj3U6kY42pESof+D0ZijCDCQhEd/K4MuCRfcqACRTio2IyJutf2jljpSslD5J 8r/EGhaP2SgW X-Google-Smtp-Source: AGHT+IHj0/xlrYMMuLCFBsbOIbo7sxBxllRkVrzqKf/hyvE/NfrH1ib6qjNk9kK/i30RRpjilja8Jw== X-Received: by 2002:a05:6870:14cc:b0:2c2:3e54:553 with SMTP id 586e51a60fabf-2cbcf7723e6mr6523431fac.28.1743464476657; Mon, 31 Mar 2025 16:41:16 -0700 (PDT) Received: from fedora ([2806:10ae:e:5fce::1]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-72c58092589sm1663082a34.2.2025.03.31.16.41.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 16:41:16 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86tt7b65pg.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> Date: Mon, 31 Mar 2025 17:41:15 -0600 Message-ID: <87h638ydic.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, juri@linkov.net, dancol@dancol.org, mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: multipart/alternative; boundary="==-=-=" --==-=-= Content-Type: text/plain Eli Zaretskii writes: > Let's please discuss your ideas before you implement them, to make > sure you don't work on some ideas that we might object to. Sure. The code needs to run each time the cursor moves, (is there a function/code that do this?) and each time user changes window (because cursor color is not buffer-local). I think that using variable watchers would be better and keep this defcustom (it will only use variables): #+begin_example (defcustom cursor-indicators '((overwrite-mode . "red") (buffer-read-only "green" hollow) (current-input-method . "blue")) [...] #+end_example --==-=-= Content-Type: text/html

Eli Zaretskii <eliz@gnu.org> writes:

Let's please discuss your ideas before you implement them, to make
sure you don't work on some ideas that we might object to.

Sure.

The code needs to run each time the cursor moves, (is there
a function/code that do this?) and each time user changes window
(because cursor color is not buffer-local).

I think that using variable watchers would be better and keep
this defcustom (it will only use variables):

(defcustom cursor-indicators
  '((overwrite-mode . "red")
    (buffer-read-only "green" hollow)
    (current-input-method . "blue"))
    [...]
--==-=-=-- --=-=-= Content-Type: text/plain -- - E.G via GNU Emacs and Org. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 01 07:43:56 2025 Received: (at 77224) by debbugs.gnu.org; 1 Apr 2025 11:43:57 +0000 Received: from localhost ([127.0.0.1]:46752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tza27-00038Y-AG for submit@debbugs.gnu.org; Tue, 01 Apr 2025 07:43:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52526) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tza24-00037H-Hw for 77224@debbugs.gnu.org; Tue, 01 Apr 2025 07:43:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tza1x-0003cB-Id; Tue, 01 Apr 2025 07:43:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ezkQkSZ9qeXk9DA35D461/B9ebHQVwzwvIq4jtXw68A=; b=QYqZBHplAr8h2xpQ0VQt PqwYGSTR3XaBmumYg28Us2uctKPdUg5SE/3+dNLDEEFO7bX4x8FTkICrv3fvh5fv1z/jb0HwfpyxP vmv76UnMkAp6gJxMicgu1bU1WhAq0QSYQQWtu9JlAOOUX2WU1+Vza6duQ6H4Wm+o/pyYeXCI0mX2M BmnD0W4pngNuzhT5onm3giwoc7I+8DR5mO3II9VY4WFfeTAtWN7cWqVyPxgdaafcOJ9YhfhvAj9mX oo8lBtt51sbSZleabhPdhSBtzZ7iPA//g5NIIWZToU8XOVUHVAP19BdOPfRMdo3LY01Mgk1caJL4B tWOCNzLuzhmRWg==; Date: Tue, 01 Apr 2025 14:42:58 +0300 Message-Id: <86msd02jlp.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: <87h638ydic.fsf@gmail.com> (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Mon, 31 Mar 2025 17:41:15 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <87o6xq6fud.fsf@mail.linkov.net> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> <87h638ydic.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, juri@linkov.net, dancol@dancol.org, mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez > Cc: 77224@debbugs.gnu.org, dancol@dancol.org, mail@daniel-mendler.de, > juri@linkov.net > Date: Mon, 31 Mar 2025 17:41:15 -0600 > > Eli Zaretskii writes: > > Let's please discuss your ideas before you implement them, to make > sure you don't work on some ideas that we might object to. > > Sure. > > The code needs to run each time the cursor moves, (is there > a function/code that do this?) and each time user changes window > (because cursor color is not buffer-local). I understand the general idea, but did you have more detailed ideas for how to implement that? And I'm not sure I understand why cursor movement needs this to run, since the cursor appearance doesn't depend on its position, it depends on state of overwrite-mode, buffer-read-only, and other similar state variables, which don't change with buffer or cursor position. So what am I missing? > I think that using variable watchers would be better and keep > this defcustom (it will only use variables): > > > (defcustom cursor-indicators > '((overwrite-mode . "red") > (buffer-read-only "green" hollow) > (current-input-method . "blue")) > [...] If each state has a variable you can watch, then yes. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 03 19:08:53 2025 Received: (at 77224) by debbugs.gnu.org; 3 Apr 2025 23:08:54 +0000 Received: from localhost ([127.0.0.1]:36145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0Tg5-0004oR-Go for submit@debbugs.gnu.org; Thu, 03 Apr 2025 19:08:53 -0400 Received: from mail-oi1-x244.google.com ([2607:f8b0:4864:20::244]:54615) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u0Tg1-0004oC-EM for 77224@debbugs.gnu.org; Thu, 03 Apr 2025 19:08:50 -0400 Received: by mail-oi1-x244.google.com with SMTP id 5614622812f47-3f8df49e75fso379659b6e.1 for <77224@debbugs.gnu.org>; Thu, 03 Apr 2025 16:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743721723; x=1744326523; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4YrFr4wCaJcsIMVTsv35aBBpDb4JGDCMsFD/XPwCX5g=; b=O4lDC5PHj9ifFka40kS9udOHCH7YPI7XwHWb03gwQ9NhrxqQep47C0bZ+dnmLxyvKG RaL1gGfB5qKhhu25bVncupJnJdTpHu4gpBRQwdVw8xUqpNssgrQtewYYBUsc/AKT95Ok j60h40FkTKYAnQxxPn77HXwqRRHEhRSoVBt6SMMJmcA4HSpqB8+CkPvU3RHH18mXtRRC L81gxwQ0ECmcwUvO02IDdzlGys6IV7j5hJaqdeYo2dh4B0O6iZQyf8E7bA+DyJhRQQ/a H4aQU2zS0rYEG4arUoS0TyMqoe5OgwhA/o5WlGNUckKGoiLEGP6od6iV52ntDbWgoNxO 63mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743721723; x=1744326523; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4YrFr4wCaJcsIMVTsv35aBBpDb4JGDCMsFD/XPwCX5g=; b=rNxrMWmjkjfKspxtGkFh3ZZnrdYAQ+/9gPmCPhMkYwp+ZisLD08D8e6w8GAVtYuEba bPdOgPRBpv3jEyneiBLeFGFzPLirUevOy0s2+rHujZK4N+6zdaNbh38gdMeckcAyiaeg o3lp3UG1bEOVWgJS+m2XmNIOufUYh4mHDwZHeeHJjgR49L3GU9Kz9vNiXy7Y1jljccxO AyLaV+6Oy9GKTuR0Z+c5B684Q67O6Wy6vxuGbeWhk3cR7J8D59ivr+laEtGnwZPz17uI oWd2BS4qojh4n3PaaAvD7araHchl9QQz5jzqiJpnHP5ZrruQcfrwH1daBbprB90iBSTG lpLw== X-Gm-Message-State: AOJu0YzzqtpYoZGdp/qQ5sqDtZA3x8sbFn8iam77Mc3wf1XBIkxQ08oV tWPDOsUtvIwNJF+5gcpvpBEJA2323UqzvWvwjVRhCLu0fokTjdpmgt5uGKvu X-Gm-Gg: ASbGnct3ijy0FFMXQTXS4VgLuDsPGyV7u92DzXX+xWIeYqQf90ojoD+y0uER8ZOyApz 4icA5EzBxkklCk74GMOIXj+PpvcvuAKWfw6oHUW0rM/FGkEIwVZ18MfTtPvwV332N4nc+2p5kzX PLihI5GT30xZvDmp8DNVxKtlx/0Z6DzBtHNT72M3YRo1+tl+WiOMid37bIVtaVoFJh6GU5bjAmC 49Kd7v2BlpEAg76nDX2N2x3CFfRppE5jxd47u6l95gfq5nK8V/KrlYC7rofeFX2CmEBoXXmOf2k vEK0I6FLpyou X-Google-Smtp-Source: AGHT+IFPE4RxRpfKTIgyGdKOc3bH4nQDcb4OLPlEjdwJ5DtpZpiF+/0OncSp2okrtWx3XAolxXqlSw== X-Received: by 2002:a05:6808:80af:b0:3f8:150b:f558 with SMTP id 5614622812f47-4004559363fmr499509b6e.10.1743721723279; Thu, 03 Apr 2025 16:08:43 -0700 (PDT) Received: from fedora ([2806:10ae:e:79da::1]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40040080a6dsm389007b6e.31.2025.04.03.16.08.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 16:08:42 -0700 (PDT) From: =?utf-8?Q?Elijah_Gabe_P=C3=A9rez?= To: Eli Zaretskii Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <86msd02jlp.fsf@gnu.org> References: <87iknzxski.fsf@gmail.com> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> <87h638ydic.fsf@gmail.com> <86msd02jlp.fsf@gnu.org> Date: Thu, 03 Apr 2025 17:08:41 -0600 Message-ID: <87v7rkzvuu.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, dancol@dancol.org, mail@daniel-mendler.de, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: Elijah Gabe P=C3=A9rez >> Cc: 77224@debbugs.gnu.org, dancol@dancol.org, mail@daniel-mendler.de, >> juri@linkov.net >> Date: Mon, 31 Mar 2025 17:41:15 -0600 >>=20 >> Eli Zaretskii writes: >>=20 >> Let's please discuss your ideas before you implement them, to make >> sure you don't work on some ideas that we might object to. >>=20 >> Sure. >>=20 >> The code needs to run each time the cursor moves, (is there >> a function/code that do this?) and each time user changes window >> (because cursor color is not buffer-local). > > I understand the general idea, but did you have more detailed ideas > for how to implement that? Maybe in a kind of loop? I'm still thinking. Another idea is to make the cursor color buffer local. > And I'm not sure I understand why cursor movement needs this to run, > since the cursor appearance doesn't depend on its position, it depends > on state of overwrite-mode, buffer-read-only, and other similar state > variables, which don't change with buffer or cursor position. So what > am I missing? Because I had planned to implement this part of the TODO for this package (since I think it fits for this): (L848) ** Optionally make the cursor a little thinner at EOL and EOB Honestly, I'm getting a little tired, so I'm going to put this on pause until I come up with an idea or someone wants to work on it. --=20 - E.G via GNU Emacs and Org. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 02:17:17 2025 Received: (at 77224) by debbugs.gnu.org; 4 Apr 2025 06:17:17 +0000 Received: from localhost ([127.0.0.1]:36776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0aMf-000577-8I for submit@debbugs.gnu.org; Fri, 04 Apr 2025 02:17:17 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:40367) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0aMc-00056l-Tz for 77224@debbugs.gnu.org; Fri, 04 Apr 2025 02:17:15 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 05F8220452; Fri, 4 Apr 2025 06:17:04 +0000 (UTC) From: Juri Linkov To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87v7rkzvuu.fsf@gmail.com> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> <87h638ydic.fsf@gmail.com> <86msd02jlp.fsf@gnu.org> <87v7rkzvuu.fsf@gmail.com> Date: Fri, 04 Apr 2025 09:04:09 +0300 Message-ID: <87ecy8a2ee.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdduledtieelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohephedprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgtphhtthhopegurghntgholhesuggrnhgtohhlrdhorhhgpdhrtghpthhtohepjeejvddvgeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrghdprhgtphhtthhopegvgheigedvieduieesghhmrghilhdrtghomh X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Eli Zaretskii , dancol@dancol.org, mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Because I had planned to implement this part of the TODO for this > package (since I think it fits for this): > > (L848) ** Optionally make the cursor a little thinner at EOL and EOB With your initial implementation it's easy to customize it to just (setopt cursor-indicators-conditions '((eolp . bar))) (Note that you even don't need 'eobp' since it's always covered by 'eolp'.) So why not go with your initial implementation that works great. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 06:49:48 2025 Received: (at 77224) by debbugs.gnu.org; 4 Apr 2025 10:49:48 +0000 Received: from localhost ([127.0.0.1]:37195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u0ecO-0003YQ-EK for submit@debbugs.gnu.org; Fri, 04 Apr 2025 06:49:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34154) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u0ecM-0003YD-20 for 77224@debbugs.gnu.org; Fri, 04 Apr 2025 06:49:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0ecE-0007MO-VX; Fri, 04 Apr 2025 06:49:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=/Q4VweXn7/sK5QoIZGhccGSX99bqUhI0kO/h54mC80k=; b=dzzXVqk6HicYWt5osfEW uloaHPmKwOsSfqN8ZF1c9Sk8BOgwV7IX9fzsA24Xa6GqlYdIQNjTnm6FT4gyYAYjbAr0e0sIHqKtw H0jzrSO+sZt2+MPwoSZhcJ2dTUY2gLzG3c7vHF5x9WX8ayR3EBnx+V/TccwgT8IjQw8jviUXPKIPq iZ6qMlT1VeAiF7WYaWhcTwe+DlPY3676ASc2GGnTDITSs4W69ThN08EMD053YW2K6ddAmSumT7Sob uCHIcSr5bXDLsfCGb/e9U61EOP3CzcryPSkeTeoT/r/Fkn+jEOfX6rxS2iRg9C+zKH1xDE/tkt7Ys 4+cH82IzdKPg2w==; Date: Fri, 04 Apr 2025 13:49:34 +0300 Message-Id: <861pu8yzep.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: <87v7rkzvuu.fsf@gmail.com> (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Thu, 03 Apr 2025 17:08:41 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> <87h638ydic.fsf@gmail.com> <86msd02jlp.fsf@gnu.org> <87v7rkzvuu.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, dancol@dancol.org, mail@daniel-mendler.de, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez > Cc: 77224@debbugs.gnu.org, juri@linkov.net, dancol@dancol.org, > mail@daniel-mendler.de > Date: Thu, 03 Apr 2025 17:08:41 -0600 > > Eli Zaretskii writes: > > >> The code needs to run each time the cursor moves, (is there > >> a function/code that do this?) and each time user changes window > >> (because cursor color is not buffer-local). > > > > I understand the general idea, but did you have more detailed ideas > > for how to implement that? > > Maybe in a kind of loop? > I'm still thinking. The place where Emacs sets the cursor is well-defined, but calling display-related functions from there could be tricky, because we are in the middle of redisplay at that point. I would first suggest to try using window-scroll-functions for this purpose, maybe they are all you need. > > And I'm not sure I understand why cursor movement needs this to run, > > since the cursor appearance doesn't depend on its position, it depends > > on state of overwrite-mode, buffer-read-only, and other similar state > > variables, which don't change with buffer or cursor position. So what > > am I missing? > > Because I had planned to implement this part of the TODO for this > package (since I think it fits for this): > > (L848) ** Optionally make the cursor a little thinner at EOL and EOB That could be a separate feature, implemented differently. > Honestly, I'm getting a little tired, so I'm going to put this on pause > until I come up with an idea or someone wants to work on it. Understood. Apologies if I added to your tiredness. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 11 12:28:28 2025 Received: (at 77224) by debbugs.gnu.org; 11 Apr 2025 16:28:28 +0000 Received: from localhost ([127.0.0.1]:51485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u3HEw-0001EM-76 for submit@debbugs.gnu.org; Fri, 11 Apr 2025 12:28:28 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:40451) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u3HEt-0001E2-RM for 77224@debbugs.gnu.org; Fri, 11 Apr 2025 12:28:24 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 769E74399B; Fri, 11 Apr 2025 16:28:12 +0000 (UTC) From: Juri Linkov To: Elijah Gabe =?iso-8859-1?Q?P=E9rez?= Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' In-Reply-To: <87ecy8a2ee.fsf@mail.linkov.net> Organization: LINKOV.NET References: <87iknzxski.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> <87h638ydic.fsf@gmail.com> <86msd02jlp.fsf@gnu.org> <87v7rkzvuu.fsf@gmail.com> <87ecy8a2ee.fsf@mail.linkov.net> Date: Fri, 11 Apr 2025 19:21:53 +0300 Message-ID: <87r01yllcu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvuddvvdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvfevufgjohhffffkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucggtffrrghtthgvrhhnpeffgeetfeevlefhleejfeeuheeiudeitdffhfdutdekfeffgffhveehteegueekheenucfkphepledurdduvdelrddutdehrdduudejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepledurdduvdelrddutdehrdduudejpdhhvghlohepmhgrihhlrdhgrghnughirdhnvghtpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhgspghrtghpthhtohephedprhgtphhtthhopehmrghilhesuggrnhhivghlqdhmvghnughlvghrrdguvgdprhgtphhtthhopegurghntgholhesuggrnhgtohhlrdhorhhgpdhrtghpthhtohepvghlihiisehgnhhurdhorhhgpdhrtghpthhtohepjeejvddvgeesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopegvgheigedvieduieesghhmrghilhdrtghomh X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Eli Zaretskii , dancol@dancol.org, mail@daniel-mendler.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> (L848) ** Optionally make the cursor a little thinner at EOL and EOB > > With your initial implementation it's easy to customize it to just > > (setopt cursor-indicators-conditions > '((eolp . bar))) Shouldn't 'cursor-indicators' use 'pre-redisplay-functions' like 'cursor-face-highlight-mode' does? From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 14 00:35:10 2025 Received: (at 77224) by debbugs.gnu.org; 14 Apr 2025 04:35:10 +0000 Received: from localhost ([127.0.0.1]:45197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4BXJ-0001jP-MY for submit@debbugs.gnu.org; Mon, 14 Apr 2025 00:35:10 -0400 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]:61499) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1u4BXG-0001dj-26 for 77224@debbugs.gnu.org; Mon, 14 Apr 2025 00:35:07 -0400 Received: by mail-qv1-xf43.google.com with SMTP id 6a1803df08f44-6f0c30a1cf8so43233756d6.2 for <77224@debbugs.gnu.org>; Sun, 13 Apr 2025 21:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744605300; x=1745210100; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Dw8IRft923QQxhQ3nmqnVjMdodgJrFYM4CdCy5EGWsw=; b=YxE1zJHnXDhV/iLv4nItf5TX2qWqLhE2X7Ucj1OxazpVJYRDhp2JVNAZiF0Tx0wmca MU9rmz4vW+TNNA6H1hXvKTCLoODU6TY7tLj6S7qr8O74cfHnzwvycymlVAPvEhYbCJ4a xn6MaVsg3stt9HZ3S/nl6+fwrHR+sg+oI6NSINyelOdc2RLalxDH/uSqN6N5R0yltlUO VmtW9R1Q3qYrMi8dvWvx8FQqvETwUaEiD1Sb2ngEgt+23qCQI/3wzQ3N/6K/4U+tnifN WX0/076O5MptyrGIEtnhLXoGNqcQCUBUc0kO2R9nMLKSSDqLOdHV6JQcixMiUdcGfZOY 6png== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744605300; x=1745210100; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Dw8IRft923QQxhQ3nmqnVjMdodgJrFYM4CdCy5EGWsw=; b=glS57e74AAO2Pov2SG2qfYZb89NzYvu8Za0dGoBD8Dyw8L58ny23tcTlQse3hHgysv L7PtZ1a6sIXB+txjiN/D25FrkLVfBtupEQaJ+rBrNF6+ktg+1kcC4k3dFUTsEckcZbjI c1v6AMIVE+XNMLbzmqbcN9tI411xOywntz/Ds3cD5rvBcUvbWg6WFY6v+N2qIUJaSgDh 36IwGERyapKe2wjaVVmVyr5pMj953srN6ENNzLzCPP6n8nKjC+GhqQ1dU7IdhdKggD3M jj9o3tUdAkyOOOtge6ctcfXyqmY7wR7VqDpVDiMnaAKTz3dtPW6UkGfu1WXy4yChm1Ao XBAQ== X-Gm-Message-State: AOJu0YwGmE6+yxcz+3kw1jEzE7Uv+Xz3MY0NclZeH/lk5jji2/qBoN/K wSyMVKXZ2HNvVLtQSipSla9Xr9q5lgYYk0jzJhYcXaBxQquGtpRUl+wGRoEvMQRN9gCiO+zWFFq feVomix0e7MzLajpn7lA182R6cO4qcrbc X-Gm-Gg: ASbGncuZZTT4fw0DiJXJGl+1K3B5WcYaRlYInkJP5WOn64j5mXBZt6A00lpwnshJrID a9VbWLRJYRQiEHmLPscVsAKOvDTdAo1letwnhrvgapPLuBhFa2fCUT5Y/6rplzy5937mMaAAEBb n0FSogAKbSi6zO5VWfJlimJI8xsF+q+3tfqGzk/kT+9+JLgblNIA8G X-Google-Smtp-Source: AGHT+IGd8VJP05dzzPplGRWyV99SpufIsFybz7fwMvxImgLni/RfWWcsud5jaZZi4+kHjncEzcc1oxyMO7v9nXj706k= X-Received: by 2002:a05:6214:1c47:b0:6e5:a0fc:f663 with SMTP id 6a1803df08f44-6f223237a0amr149020636d6.0.1744605300207; Sun, 13 Apr 2025 21:35:00 -0700 (PDT) MIME-Version: 1.0 References: <87iknzxski.fsf@gmail.com> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> <87h638ydic.fsf@gmail.com> <86msd02jlp.fsf@gnu.org> <87v7rkzvuu.fsf@gmail.com> In-Reply-To: <87v7rkzvuu.fsf@gmail.com> From: =?UTF-8?Q?Elijah_Gabe_P=C3=A9rez?= Date: Sun, 13 Apr 2025 22:34:47 -0600 X-Gm-Features: ATxdqUFGV_0vMxF0vS_jT6ORQal5JIalsvOWcEiq6Awa9YSMer_3q3-ggSlUMd0 Message-ID: Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' To: Eli Zaretskii Content-Type: multipart/alternative; boundary="0000000000003132010632b59368" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, Daniel Colascione , Daniel Mendler , Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --0000000000003132010632b59368 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Elijah Gabe P=C3=A9rez writes: > Eli Zaretskii writes: > > >> From: Elijah Gabe P=C3=A9rez > >> Cc: 77224@debbugs.gnu.org, dancol@dancol.org, mail@daniel-mendler.de= , > >> juri@linkov.net > >> Date: Mon, 31 Mar 2025 17:41:15 -0600 > >> > >> Eli Zaretskii writes: > >> > >> Let's please discuss your ideas before you implement them, to make > >> sure you don't work on some ideas that we might object to. > >> > >> Sure. > >> > >> The code needs to run each time the cursor moves, (is there > >> a function/code that do this?) and each time user changes window > >> (because cursor color is not buffer-local). > > > > I understand the general idea, but did you have more detailed ideas > > for how to implement that? > > Maybe in a kind of loop? > I'm still thinking. > > Another idea is to make the cursor color buffer local. I got an idea, what about add an advice-add to setq as a kind of variable watcher? setq is the standard for changing the value to a variable, and compared to post-command-hook, it wouldn't run on every function calls, ofc the advice will be removed after disabling the minor mode. Maybe it sounds hacky and could already been talked about in this thread that I've missed, but there are built-in packages in emacs that use advice-add. --0000000000003132010632b59368 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Elijah Gabe P=C3=A9rez writes:
Eli Zaretskii <eliz@gnu.org> writes:

>> From: Elijah Gabe P=C3=A9rez <eg642616@gmail.com>
>> Cc: 77224@debbugs.gnu.org,=C2=A0 dancol@dancol.org,=C2= =A0 mail@daniel-mendler.de,
>>=C2=A0 =C2=A0juri@linkov.net
>> Date: Mon, 31 Mar 2025 17:41:15 -0600
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>=C2=A0 Let's please discuss your ideas before you implement the= m, to make
>>=C2=A0 sure you don't work on some ideas that we might object t= o.
>>
>> Sure.
>>
>> The code needs to run each time the cursor moves, (is there
>> a function/code that do this?) and each time user changes window >> (because cursor color is not buffer-local).
>
> I understand the general idea, but did you have more detailed ideas > for how to implement that?

Maybe in a kind of loop?
I'm still thinking.

Another idea is to make the cursor color buffer local.

I got an idea, what about= add an advice-add to setq as a kind of variable watcher? setq is the stand= ard for changing the value to a=C2=A0 variable, and compared to post-comman= d-hook, it wouldn't run on every function calls, ofc the advice will be= removed after disabling the minor mode.

<= div dir=3D"auto">Maybe it sounds hacky and could already been talked about = in this thread that I've missed, but there are built-in packages in ema= cs that use advice-add.
--0000000000003132010632b59368-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 14 01:15:50 2025 Received: (at 77224) by debbugs.gnu.org; 14 Apr 2025 05:15:50 +0000 Received: from localhost ([127.0.0.1]:45292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1u4CAf-00072l-TE for submit@debbugs.gnu.org; Mon, 14 Apr 2025 01:15:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49546) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1u4CAd-00072U-Et for 77224@debbugs.gnu.org; Mon, 14 Apr 2025 01:15:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4CAV-0006V0-NQ; Mon, 14 Apr 2025 01:15:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=xJ3hZbt8nLMhTQUzL9d32d/Hbjib2E2k4Sp3KW/GXfQ=; b=DvDAPbgC8shSqOkzjqa9 95TnQ2t7MfBPvhmSAXQ7VAAI9Ehy6SXoibwZb0CNEbp5pbTFoqQ5qkmz5WNFEB7yn7qBguGRSW6wz L93Dxce6N4KogMxPJ885BO75b4JKTOPEq3grPVpCl82AbPxMz3vVhAJYfywyjtg+jFQlGteTzozy1 dv0jgx1C0E3PbxhjmD0UGZ4C5MKdFCwcSd1hTPyRtkda7Tq5Vg9Hmg8pYvUVkmctupvUfpbkKzOmB CuNN2K/fRBAcHdcC8B0H4B3lDLFD4E03Fow7mDmAqO/vfCu1s64gz2uED54UZ4o2JbvVmjGNR8422 hIxBmWFqN0uA6w==; Date: Mon, 14 Apr 2025 08:15:35 +0300 Message-Id: <865xj7jpc8.fsf@gnu.org> From: Eli Zaretskii To: Elijah Gabe =?utf-8?Q?P=C3=A9rez?= In-Reply-To: (message from Elijah Gabe =?utf-8?Q?P=C3=A9rez?= on Sun, 13 Apr 2025 22:34:47 -0600) Subject: Re: bug#77224: [PATCH] New minor mode 'cursor-indicators-mode' References: <87iknzxski.fsf@gmail.com> <875xjymh93.fsf@gmail.com> <87ikny2rio.fsf@gmail.com> <86o6xpe2cx.fsf@gnu.org> <87o6xobdcc.fsf@gmail.com> <875xjwyzvt.fsf@mail.linkov.net> <8634f0dkhq.fsf@gnu.org> <875xjvcn4o.fsf@gmail.com> <877c4b81nk.fsf@daniel-mendler.de> <86ecyidg2d.fsf@gnu.org> <87h63ekdxe.fsf@daniel-mendler.de> <86cye2d8t6.fsf@gnu.org> <87a596a29y.fsf@daniel-mendler.de> <86tt7ebfnc.fsf@gnu.org> <44319BF5-31B5-4ECD-95AB-591A216D0072@dancol.org> <87a595tyzt.fsf@gmail.com> <87msd5r4z8.fsf@mail.linkov.net> <87r02fpuan.fsf@gmail.com> <86tt7b65pg.fsf@gnu.org> <87h638ydic.fsf@gmail.com> <86msd02jlp.fsf@gnu.org> <87v7rkzvuu.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77224 Cc: 77224@debbugs.gnu.org, dancol@dancol.org, mail@daniel-mendler.de, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Elijah Gabe Pérez > Date: Sun, 13 Apr 2025 22:34:47 -0600 > Cc: 77224@debbugs.gnu.org, Juri Linkov , > Daniel Colascione , Daniel Mendler > > >> The code needs to run each time the cursor moves, (is there > >> a function/code that do this?) and each time user changes window > >> (because cursor color is not buffer-local). > > > > I understand the general idea, but did you have more detailed ideas > > for how to implement that? > > Maybe in a kind of loop? > I'm still thinking. > > Another idea is to make the cursor color buffer local. > > I got an idea, what about add an advice-add to setq as a kind of variable watcher? setq is the standard for > changing the value to a variable, and compared to post-command-hook, it wouldn't run on every function > calls, ofc the advice will be removed after disabling the minor mode. > > Maybe it sounds hacky and could already been talked about in this thread that I've missed, but there are > built-in packages in emacs that use advice-add. If that's what you want, why not use a variable watcher directly? We do that in some cases already, see the end of frame.el.