GNU bug report logs - #77218
[PATCH] gnu: emacs-eros: Update to 0.1.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77218 in the body.
You can then email your comments to 77218 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Lee Thompson <lee.p.thomp <at> gmail.com>
Subject: [PATCH] gnu: emacs-eros: Update to 0.1.0.
Date: Sun, 23 Mar 2025 19:47:48 +0000

* gnu/packages/emacs-xyz.scm (emacs-eros): Update to 0.1.0, synopsis reworded.

Change-Id: I6e3c9f787a2fc47f20fe39477b0d10ed47d71f93
---
I've written for this email subject and commit message that I've updated
emacs-eros to 0.1.0, though what I found in fact was that the upstream source
had always read `Version: 0.1.0' in `eros.el' despite the previous revisions of
this Guix package using 0.0.1.  Unless I've assumed wrongly I thought that the
convention with un-tagged or un-released upstreams is that the version is taken
from the top-level Elisp source.  No worries if this is not the case.

I've updated the package to use the most recent commit also.  In testing I
couldn't see anywhere it had broken dependents, though I'd hope any breaking
change upstream would necessitate a version bump.

 gnu/packages/emacs-xyz.scm | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f7459c3c32..539206f70e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -155,6 +155,7 @@
 ;;; Copyright © 2025 Remco van 't Veer <remco <at> remworks.net>
 ;;; Copyright © 2025 Skylar Hill <stellarskylark <at> posteo.net>
 ;;; Copyright © 2025 Cayetano Santos <csantosb <at> inventati.org>
+;;; Copyright © 2025 Lee Thompson <lee.p.thomp <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28763,11 +28764,12 @@ (define-public emacs-sml-mode
     (license license:gpl3+)))
 
 (define-public emacs-eros
-  (let ((commit "dd8910279226259e100dab798b073a52f9b4233a")
-        (revision "2"))
+  (let ((commit "a9a92bdc6be0521a6a06eb464be55ed61946639c")
+        (revision "0"))
     (package
       (name "emacs-eros")
-      (version (git-version "0.0.1" revision commit))
+      ;; No tag or release, version taken from `eros.el'.
+      (version (git-version "0.1.0" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -28776,12 +28778,12 @@ (define-public emacs-eros
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32
-           "08chj3a0lw4ygi2sv7wj0i6ihfbi8jhylr8p92inif8b88r6wg3k"))))
+          (base32 "04nkqsvh8c988hc3ajigs206ad64204qdhhqzdvm3k7m7qiiwga8"))))
       (build-system emacs-build-system)
       (home-page "https://github.com/xiongtx/eros")
       (synopsis "Evaluation result overlays")
-      (description "@code{eros} provides evaluation result overlays.")
+      (description "@code{eros} provides result overlays for evaluating Emacs
+Lisp.")
       (license license:gpl3+))))
 
 (define-public emacs-geiser-eros
-- 
2.48.1

Message #8 received at 77218 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: lee.p.thomp <at> gmail.com
Cc: 77218 <at> debbugs.gnu.org
Subject: Re: [bug#77218] [PATCH] gnu: emacs-eros: Update to 0.1.0.
Date: Tue, 25 Mar 2025 09:50:43 +0100

[Message part 1 (text/plain, inline)]

Looks good to me, thanks for the patch !

> In testing I couldn't see anywhere it had broken dependents, though I'd
> hope any breaking change upstream would necessitate a version bump.

You may use ‘guix refresh -l’ and ‘guix build --dependents’ to check for
other packages impacted by your changes, before submitting.

Could you include the no tests flag to comply with upcoming changes in
emacs packages ?

(arguments
       ;; no tests
       (list #:tests? #false))

C.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 77218 <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: 77218 <at> debbugs.gnu.org
Cc: Lee Thompson <lee.p.thomp <at> gmail.com>
Subject: [PATCH v2] gnu: emacs-eros: Update to 0.1.0.
Date: Tue, 25 Mar 2025 10:12:59 +0000

* gnu/packages/emacs-xyz.scm (emacs-eros): Update to 0.1.0, synopsis reworded.

Change-Id: I6e3c9f787a2fc47f20fe39477b0d10ed47d71f93
---
 gnu/packages/emacs-xyz.scm | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f00c5e4b29..a50ca73889 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -155,6 +155,7 @@
 ;;; Copyright © 2025 Remco van 't Veer <remco <at> remworks.net>
 ;;; Copyright © 2025 Skylar Hill <stellarskylark <at> posteo.net>
 ;;; Copyright © 2025 Cayetano Santos <csantosb <at> inventati.org>
+;;; Copyright © 2025 Lee Thompson <lee.p.thomp <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28873,11 +28874,12 @@ (define-public emacs-sml-mode
     (license license:gpl3+)))
 
 (define-public emacs-eros
-  (let ((commit "dd8910279226259e100dab798b073a52f9b4233a")
-        (revision "2"))
+  (let ((commit "a9a92bdc6be0521a6a06eb464be55ed61946639c")
+        (revision "0"))
     (package
       (name "emacs-eros")
-      (version (git-version "0.0.1" revision commit))
+      ;; No tag or release, version taken from `eros.el'.
+      (version (git-version "0.1.0" revision commit))
       (source
        (origin
          (method git-fetch)
@@ -28886,12 +28888,16 @@ (define-public emacs-eros
                (commit commit)))
          (file-name (git-file-name name version))
          (sha256
-          (base32
-           "08chj3a0lw4ygi2sv7wj0i6ihfbi8jhylr8p92inif8b88r6wg3k"))))
+          (base32 "04nkqsvh8c988hc3ajigs206ad64204qdhhqzdvm3k7m7qiiwga8"))))
       (build-system emacs-build-system)
+      (arguments
+       ;; No tests found in source
+       (list
+        #:tests? #f))
       (home-page "https://github.com/xiongtx/eros")
       (synopsis "Evaluation result overlays")
-      (description "@code{eros} provides evaluation result overlays.")
+      (description "@code{eros} provides result overlays for evaluating Emacs
+Lisp.")
       (license license:gpl3+))))
 
 (define-public emacs-geiser-eros
-- 
2.48.1

Message #14 received at 77218 <at> debbugs.gnu.org (full text, mbox):

From: Lee Thompson <lee.p.thomp <at> gmail.com>
To: Cayetano Santos <csantosb <at> inventati.org>
Cc: 77218 <at> debbugs.gnu.org
Subject: Re: [bug#77218] [PATCH] gnu: emacs-eros: Update to 0.1.0.
Date: Tue, 25 Mar 2025 10:14:17 +0000

Cayetano Santos <csantosb <at> inventati.org> writes:

> Looks good to me, thanks for the patch !
> ...
> You may use ‘guix refresh -l’ and ‘guix build --dependents’ to check for
> other packages impacted by your changes, before submitting.
Checked both these, all looks fine.

> Could you include the no tests flag to comply with upcoming changes in
> emacs packages ?
Done and sorted, v2 patch now sent in, thanks

Message #17 received at 77218 <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: GNU bug tracker automated control server <control <at> debbugs.gnu.org>
Cc: lee.p.thomp <at> gmail.com, 77218 <at> debbugs.gnu.org
Subject: control message for bug #77218
Date: Tue, 25 Mar 2025 11:38:56 +0100

[Message part 1 (text/plain, inline)]

user guix
usertag 77218 + reviewed-looks-good
thanks

Items marked as checked:

- commit messages
- package builds
- lint warnings
- package style
- no dependent packages
- synopsis and descriptions
- no package tests
- licenses

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 77218 <at> debbugs.gnu.org (full text, mbox):

From: Ian Eure <ian <at> retrospec.tv>
To: Lee Thompson <lee.p.thomp <at> gmail.com>
Cc: 77218 <at> debbugs.gnu.org
Subject: Re: [bug#77218] [PATCH] gnu: emacs-eros: Update to 0.1.0.
Date: Sat, 29 Mar 2025 09:02:44 -0700

Hi Lee,

Pushed as 4067f2480b.

Thanks!
 -- Ian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.