From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 23 13:54:30 2025 Received: (at submit) by debbugs.gnu.org; 23 Mar 2025 17:54:30 +0000 Received: from localhost ([127.0.0.1]:52528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twPWo-0006rG-Be for submit@debbugs.gnu.org; Sun, 23 Mar 2025 13:54:30 -0400 Received: from lists.gnu.org ([2001:470:142::17]:55162) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1twPWm-0006qz-1B for submit@debbugs.gnu.org; Sun, 23 Mar 2025 13:54:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twPWg-0001GA-2y for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 13:54:22 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1twPWe-0004xA-IJ for bug-gnu-emacs@gnu.org; Sun, 23 Mar 2025 13:54:21 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-5e6ff035e9aso6813893a12.0 for ; Sun, 23 Mar 2025 10:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742752457; x=1743357257; darn=gnu.org; h=mime-version:message-id:date:cc:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=6xBHUSA4p1OtcH1jimlxB3crgN7UUS0CgqYtFOlEZro=; b=m9JIR+8Dn0DLoW1qZzMUWTX7M1JQ3OTBc87JIUmaThTCqKoOitlfFkGwE9NqwOBKnd rKY5Hsgu+Ewxze+M8ZGwVEYpB5x3lj5WNG1yaQgT+0SeISSykdVPzKTGCq5eMDfZn7p0 lQ5U01GLFv0MVVPcRzDFgyyQluSVPh0DsLvGlE1M6ceUOYcWg/HI7fSx12j55cFES7zO 5CoKKidgS8ZCYT+c0+/Z0gwyyaQ4va+nhdZNWEmQ0zTJFYvIXSeLYmJH2X6GW8XXJkAG iqXau5KlwwYf/iF5qzKZffCxvcSpFpsE1j0bJLHtWj3o2h3TnJ0yygLH1S6k7ar1C7ti 2v4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742752457; x=1743357257; h=mime-version:message-id:date:cc:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=6xBHUSA4p1OtcH1jimlxB3crgN7UUS0CgqYtFOlEZro=; b=kRwL08dHF5eJ/UTSCREH5yOiv7m5fvnEgmHivczIKLeSdFpnCihXT7uR6odacD9aOL FHz0ue7XtZ39GYUhRhsBO6gMdwzxuRO70EB2a7e32bC7gcuzlgQ+Yed4wSlrdcGFAFgh KQYNpSVXqL/wIygFSRatn1C3qlzpaawDfcpNiGxIqeUueBikZ/4akgcb5nMbJPpAae8b 23RxP6zbjrmnyKV816+u996BXXWrz83RtESCxpzcQZbV9MvWEdk3aDgfrXqgEdls48MA vZZl9PQnZuL5ILEJxSwN2lo7JwUFHuHz4vZd+VotnjrtnaT1Vb15MfKa7Xbb+dQqjxGm T0kw== X-Gm-Message-State: AOJu0Yz9Rsv8GXTvJ4DqOQh4VfnmwbYeSdnTNdiF6pMwQL6FbSdoHgNP NiNP1X2TlbpCLAjLttu1k4NnCu2abqWDuX7FDUwjsqvzCk2Rp1ik4qg2CQ== X-Gm-Gg: ASbGncsMU/YA5qJdIDVAFtR5nupsM+UWhwOje35/93PUMG1HZeieC6DZzNGL8uiC7pr VLjfRxBBwxGqhIVqx6efyy2/BlXQGplAdHTM8u5FA/nACZBQsrQlh0byOXHJUBvv4DNiOup/qG8 duGid/pe7tdGKOe/SmUdQs9TDjDA1FxrL2WHtE2/NNrjGC31vMfZUPIs0NPDA5wC1r+JppDR78h K64H1O6PAUHJ95rmIJqLn9d8drBTyrBVI1evNJJ+VsJqwHAoaPRtyqEmF3cA3LJNY3BCY8KHF/m IXBueFKDg0NcBc3z8KiZtXxlS6KSrS11CgH26IyOtmB687yfyqpD6FbRmZK8z+c= X-Google-Smtp-Source: AGHT+IGSYsuZdy+kd2+BT4wyhZ1OKyOqFZ3lNq0DkQKFC5SMdAMiDVwTCOLTDvNkqJn80DxHlhSY9A== X-Received: by 2002:a05:6402:27cb:b0:5e7:c773:ae35 with SMTP id 4fb4d7f45d1cf-5ebcd40bd58mr9511501a12.5.1742752457110; Sun, 23 Mar 2025 10:54:17 -0700 (PDT) Received: from mba ([151.81.191.82]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5ebcd0dfcd5sm4757622a12.71.2025.03.23.10.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Mar 2025 10:54:16 -0700 (PDT) From: Filippo Argiolas To: bug-gnu-emacs@gnu.org Subject: 31.0.50; enable-theme-functions fires twice after a load-theme X-Debbugs-Cc: Date: Sun, 23 Mar 2025 18:54:14 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=filippo.argiolas@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hi, I noticed that my `enable-theme-functions' hook always fires twice after either a `load-theme' or a `enable-theme'. Problem is `enable-theme' in custom.el always also enables the user theme to push it on top of the list. Is this desired? Technically I'd say it's correct, two enables spark two hooks, buyt from the user point of view seems a counterintuitive side effect without digging into the code. Filippo From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 24 05:18:59 2025 Received: (at 77215) by debbugs.gnu.org; 24 Mar 2025 09:18:59 +0000 Received: from localhost ([127.0.0.1]:54216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twdxS-0002bA-LJ for submit@debbugs.gnu.org; Mon, 24 Mar 2025 05:18:59 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:53334) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1twdxN-0002al-Sj for 77215@debbugs.gnu.org; Mon, 24 Mar 2025 05:18:55 -0400 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-2239c066347so89504175ad.2 for <77215@debbugs.gnu.org>; Mon, 24 Mar 2025 02:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742807928; x=1743412728; darn=debbugs.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=T6Y6FX14GDkA3aOA33pbStI94V2NIMJwTsblE9ToYzQ=; b=SROpElGFTwr5IQauoXEB6vabD8WPx0Vfq9Stk95Asi95e4qUzbrGMvp4zgc40Aj21Q 9qXO0gIUvXPijgMboi9vjEivtjlC2/BACGhe2eCBi9kP6vGS/niW+YiVqC8s8RzWhUG4 p6FbB6IeScTXwVgtZi953DE/u6GtDfJHQHYRO/aMowBCP7XQmHVtDtLKCf4wnJYr7KEh STnnor1RziTfC468G1J7MFM9KVBomhkH1UUhKIRfeQEXE6ih0CuIRAEikxBSfDljSrug r/ed4xtSh5LTRp/iizC6mC4ar5fPkobqpIdDPdZ48ByqJV1KpoCEf1h5KI7pzN6mGGmf IqoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742807928; x=1743412728; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=T6Y6FX14GDkA3aOA33pbStI94V2NIMJwTsblE9ToYzQ=; b=W8tmGbasygl9EX/haTxzTVklFYpZ+GnMg9Uo4T4R7AdncS/xiIyziOM43pOi87NDYX EemYFXqA5ATW4q4Hsk2qIz7oRa7jyeUuZ212XeYRjk04zAA4rPaZfjRjE/JYsjTyXc5T 03u/RWaAaRH+GiL3AjXWH9EO0ygoYnBnoKw73y+iH9l+zngBduB/pa0dxEwvyO4VObx2 Xl2W4xDvFvNJ9CiCmeYf6b3AjwKkHvOj1q46IEzCGapMwNboemtTNNd+Y2oB9kkQL06D I5m3kOvhFgWTWdVNDT5/uzYIsILDxMP8f3Wq5LzaaPlxC2nFZPLM291emSD3vdSPkStT v8wQ== X-Forwarded-Encrypted: i=1; AJvYcCWkQOe5RMFvb7/b1LhSekMl8JlqUPBsnWqyYALo+ihezXFFWfZDz4cgm1/m2ejKuHAxMAYKMw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YzKwfeN5+n8gOkQvVVvnWgwBrC1ES46R/wJuAAuJ2CKXCRUFJ/D +34czg3wnID9COCEAAGkA4ylx6bJcg77hbaUho0MIZ3pYDKmqjgJYmnp5lwX X-Gm-Gg: ASbGncuOKiD8EVp2fJlIQJfStcbI2BbyOWLI0jAOl96WnkO6IAZQHh8veFGdhu3jHow E2QTL87eti+QOuDJP4ZLRJL+qNZ82YdoljKCv3H/zfYdrCSGfIiS9AYG1BfhAgObldLKorBcwp/ RTs7wQpjwOc8VYHOCDKNWz5pQyk5ZLN8I2Vqovg1nkGTpVv4wsqwjBQ+F19NjXVrbMb2JpfDO3a COFvn9psCx4WaCPDf/fdF01hffDs+soPBedJlnbufySguRxo45/RH1lqBJwOXjb68C8E9avzkBE QymcB8ScW5rTvffTQ8Hf5Lp4vZDBg+RBVuUP79QePBIqyDRUG7Q= X-Google-Smtp-Source: AGHT+IFjMqLSba7bqiyLtIPazHSOi+ZPHcVv81xN4K4TAHPByADy+CE2wO9gchneHtsvKhui+kRa8Q== X-Received: by 2002:a17:902:da86:b0:225:ac99:ae0d with SMTP id d9443c01a7336-22780c7e0eemr229982555ad.10.1742807927457; Mon, 24 Mar 2025 02:18:47 -0700 (PDT) Received: from [192.168.0.234] ([181.228.33.6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-227811da3f2sm65666165ad.187.2025.03.24.02.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Mar 2025 02:18:46 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------ej1aJ0l0690hcocJb7BnJ4nb" Message-ID: <3eee3672-5367-4a59-a46b-94e365ad1a3d@gmail.com> Date: Mon, 24 Mar 2025 06:18:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#77215: 31.0.50; enable-theme-functions fires twice after a load-theme To: Filippo Argiolas , 77215@debbugs.gnu.org References: Content-Language: en-US From: Mauro Aranda In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77215 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------ej1aJ0l0690hcocJb7BnJ4nb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Filippo Argiolas writes: > Hi, > > I noticed that my `enable-theme-functions' hook always fires twice > after either a `load-theme' or a `enable-theme'. > > Problem is `enable-theme' in custom.el always also enables the user > theme to push it on top of the list. > > Is this desired? > > Technically I'd say it's correct, two enables spark two hooks, buyt > from the user point of view seems a counterintuitive side effect > without digging into the code. > > Filippo I think it would be good to avoid it. The attached patch does that. --------------ej1aJ0l0690hcocJb7BnJ4nb Content-Type: text/x-patch; charset=UTF-8; name="0001-Avoid-running-enable-theme-functions-twice.patch" Content-Disposition: attachment; filename="0001-Avoid-running-enable-theme-functions-twice.patch" Content-Transfer-Encoding: base64 RnJvbSA4OWE5YjNlOGU3MDhkNWJkMDk3ZjcyNjVkOGJlNmI0NTA5MDMwNzZjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IE1vbiwgMjQgTWFyIDIwMjUgMDY6MTM6MjQgLTAzMDAKU3ViamVjdDog W1BBVENIXSBBdm9pZCBydW5uaW5nIGVuYWJsZS10aGVtZS1mdW5jdGlvbnMgdHdpY2UKCiog bGlzcC9jdXN0b20uZWwgKGN1c3RvbS0tYXBwbHktdGhlbWUtc2V0dGluZ3MpOiBOZXcgaGVs cGVyCmZ1bmN0aW9uLCBleHRyYWN0ZWQgZnJvbSBlbmFibGUtdGhlbWUuCihlbmFibGUtdGhl bWUpOiBEbyBub3QgY2FsbCBpdHNlbGYgdG8gZW5hYmxlIHRoZSB1c2VyIHRoZW1lLApqdXN0 IGNhbGwgY3VzdG9tLS1hcHBseS10aGVtZS1zZXR0aW5ncy4gIChCdWcjNzcyMTUpCi0tLQog bGlzcC9jdXN0b20uZWwgfCA1NCArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDI1 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvY3VzdG9tLmVsIGIvbGlzcC9jdXN0 b20uZWwKaW5kZXggZDMwOTc1NGFiOWIuLmRiMTA1Yjc2MThhIDEwMDY0NAotLS0gYS9saXNw L2N1c3RvbS5lbAorKysgYi9saXNwL2N1c3RvbS5lbApAQCAtMTUzNSwyMyArMTUzNSw4IEBA IGRpc2FibGUtdGhlbWUtZnVuY3Rpb25zCiAgIDpncm91cCAnY3VzdG9taXplCiAgIDp2ZXJz aW9uICIyOS4xIikKIAotKGRlZnVuIGVuYWJsZS10aGVtZSAodGhlbWUpCi0gICJSZWVuYWJs ZSBhbGwgdmFyaWFibGUgYW5kIGZhY2Ugc2V0dGluZ3MgZGVmaW5lZCBieSBUSEVNRS4KLVRI RU1FIHNob3VsZCBiZSBlaXRoZXIgYHVzZXInLCBvciBhIHRoZW1lIGxvYWRlZCB2aWEgYGxv YWQtdGhlbWUnLgotCi1BZnRlciB0aGlzIGZ1bmN0aW9uIGNvbXBsZXRlcywgVEhFTUUgd2ls bCBoYXZlIHRoZSBoaWdoZXN0Ci1wcmVjZWRlbmNlIChhZnRlciBgdXNlcicpIGFtb25nIGVu YWJsZWQgdGhlbWVzLgotCi1Ob3RlIHRoYXQgYW55IGFscmVhZHktZW5hYmxlZCB0aGVtZXMg cmVtYWluIGVuYWJsZWQgYWZ0ZXIgdGhpcwotZnVuY3Rpb24gcnVucy4gIFRvIGRpc2FibGUg b3RoZXIgdGhlbWVzLCB1c2UgYGRpc2FibGUtdGhlbWUnLgotCi1BZnRlciBUSEVNRSBoYXMg YmVlbiBlbmFibGVkLCBydW5zIGBlbmFibGUtdGhlbWUtZnVuY3Rpb25zJy4iCi0gIChpbnRl cmFjdGl2ZSAobGlzdCAoaW50ZXJuCi0JCSAgICAgIChjb21wbGV0aW5nLXJlYWQKLQkJICAg ICAgICJFbmFibGUgY3VzdG9tIHRoZW1lOiAiCi0JCSAgICAgICBvYmFycmF5IChsYW1iZGEg KHN5bSkgKGdldCBzeW0gJ3RoZW1lLXNldHRpbmdzKSkgdCkpKSkKLSAgKHVubGVzcyAoY3Vz dG9tLXRoZW1lLXAgdGhlbWUpCi0gICAgKGVycm9yICJVbmRlZmluZWQgQ3VzdG9tIHRoZW1l ICVzIiB0aGVtZSkpCisoZGVmdW4gY3VzdG9tLS1hcHBseS10aGVtZS1zZXR0aW5ncyAodGhl bWUpCisgICJSZWNhbGN1bGF0ZSBhbmQgYXBwbHkgdGhlIFRIRU1FIHNldHRpbmdzLiIKICAg KGxldCAoKHNldHRpbmdzIChnZXQgdGhlbWUgJ3RoZW1lLXNldHRpbmdzKSkgOyAnKHByb3Ag c3ltYm9sIHRoZW1lIHZhbHVlKQogICAgICAgICA7OyBXZSBhcmUgZW5hYmxpbmcgdGhlIHRo ZW1lLCBzbyBkb24ndCBpbmhpYml0IGVuYWJsaW5nIGl0LiAgKEJ1ZyMzNDAyNykKICAgICAg ICAgKGN1c3RvbS0taW5oaWJpdC10aGVtZS1lbmFibGUgbmlsKSkKQEAgLTE1ODIsMTggKzE1 NjcsMzcgQEAgZW5hYmxlLXRoZW1lCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoZXF1YWwgKGN1c3RvbS1xdW90ZSB2YWwpIChudGggMyBzKSkpKSkpCiAgICAgICAgICAg KHNldHEgc3BlYy1saXN0IGAoKGNoYW5nZWQgLChjdXN0b20tcXVvdGUgdmFsKSkpKSkKICAg ICAgICAgKHB1dCBzeW1ib2wgcHJvcCAoY29ucyAoY2RkciBzKSAoYXNzcS1kZWxldGUtYWxs IHRoZW1lIHNwZWMtbGlzdCkpKQotCShjb25kCi0JICgoZXEgcHJvcCAndGhlbWUtZmFjZSkK LQkgIChjdXN0b20tdGhlbWUtcmVjYWxjLWZhY2Ugc3ltYm9sKSkKLQkgKChlcSBwcm9wICd0 aGVtZS12YWx1ZSkKLQkgIDs7IElnbm9yZSBgY3VzdG9tLWVuYWJsZWQtdGhlbWVzJyBhbmQg YGN1c3RvbS1zYWZlLXRoZW1lcycuCi0JICAodW5sZXNzIChtZW1xIHN5bWJvbCAnKGN1c3Rv bS1lbmFibGVkLXRoZW1lcyBjdXN0b20tc2FmZS10aGVtZXMpKQotCSAgICAoY3VzdG9tLXRo ZW1lLXJlY2FsYy12YXJpYWJsZSBzeW1ib2wpKSkpKSkpCisgICAgICAgIChjb25kCisgICAg ICAgICAoKGVxIHByb3AgJ3RoZW1lLWZhY2UpCisgICAgICAgICAgKGN1c3RvbS10aGVtZS1y ZWNhbGMtZmFjZSBzeW1ib2wpKQorICAgICAgICAgKChlcSBwcm9wICd0aGVtZS12YWx1ZSkK KyAgICAgICAgICA7OyBJZ25vcmUgYGN1c3RvbS1lbmFibGVkLXRoZW1lcycgYW5kIGBjdXN0 b20tc2FmZS10aGVtZXMnLgorICAgICAgICAgICh1bmxlc3MgKG1lbXEgc3ltYm9sICcoY3Vz dG9tLWVuYWJsZWQtdGhlbWVzIGN1c3RvbS1zYWZlLXRoZW1lcykpCisgICAgICAgICAgICAo Y3VzdG9tLXRoZW1lLXJlY2FsYy12YXJpYWJsZSBzeW1ib2wpKSkpKSkpKQorCisoZGVmdW4g ZW5hYmxlLXRoZW1lICh0aGVtZSkKKyAgIlJlZW5hYmxlIGFsbCB2YXJpYWJsZSBhbmQgZmFj ZSBzZXR0aW5ncyBkZWZpbmVkIGJ5IFRIRU1FLgorVEhFTUUgc2hvdWxkIGJlIGVpdGhlciBg dXNlcicsIG9yIGEgdGhlbWUgbG9hZGVkIHZpYSBgbG9hZC10aGVtZScuCisKK0FmdGVyIHRo aXMgZnVuY3Rpb24gY29tcGxldGVzLCBUSEVNRSB3aWxsIGhhdmUgdGhlIGhpZ2hlc3QKK3By ZWNlZGVuY2UgKGFmdGVyIGB1c2VyJykgYW1vbmcgZW5hYmxlZCB0aGVtZXMuCisKK05vdGUg dGhhdCBhbnkgYWxyZWFkeS1lbmFibGVkIHRoZW1lcyByZW1haW4gZW5hYmxlZCBhZnRlciB0 aGlzCitmdW5jdGlvbiBydW5zLiAgVG8gZGlzYWJsZSBvdGhlciB0aGVtZXMsIHVzZSBgZGlz YWJsZS10aGVtZScuCisKK0FmdGVyIFRIRU1FIGhhcyBiZWVuIGVuYWJsZWQsIHJ1bnMgYGVu YWJsZS10aGVtZS1mdW5jdGlvbnMnLiIKKyAgKGludGVyYWN0aXZlIChsaXN0IChpbnRlcm4K KwkJICAgICAgKGNvbXBsZXRpbmctcmVhZAorCQkgICAgICAgIkVuYWJsZSBjdXN0b20gdGhl bWU6ICIKKwkJICAgICAgIG9iYXJyYXkgKGxhbWJkYSAoc3ltKSAoZ2V0IHN5bSAndGhlbWUt c2V0dGluZ3MpKSB0KSkpKQorICAodW5sZXNzIChjdXN0b20tdGhlbWUtcCB0aGVtZSkKKyAg ICAoZXJyb3IgIlVuZGVmaW5lZCBDdXN0b20gdGhlbWUgJXMiIHRoZW1lKSkKKyAgKGN1c3Rv bS0tYXBwbHktdGhlbWUtc2V0dGluZ3MgdGhlbWUpCiAgICh1bmxlc3MgKGVxIHRoZW1lICd1 c2VyKQogICAgIChzZXRxIGN1c3RvbS1lbmFibGVkLXRoZW1lcwogCSAgKGNvbnMgdGhlbWUg KHJlbXEgdGhlbWUgY3VzdG9tLWVuYWJsZWQtdGhlbWVzKSkpCiAgICAgOzsgR2l2ZSB0aGUg YHVzZXInIHRoZW1lIHRoZSBoaWdoZXN0IHByaW9yaXR5LgotICAgIChlbmFibGUtdGhlbWUg J3VzZXIpKQorICAgIChjdXN0b20tLWFwcGx5LXRoZW1lLXNldHRpbmdzICd1c2VyKSkKICAg OzsgQWxsb3cgY2FsbGVycyB0byByZWFjdCB0byB0aGUgZW5hYmxpbmcuCiAgIChydW4taG9v ay13aXRoLWFyZ3MgJ2VuYWJsZS10aGVtZS1mdW5jdGlvbnMgdGhlbWUpKQogCi0tIAoyLjM0 LjEKCg== --------------ej1aJ0l0690hcocJb7BnJ4nb-- From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 25 01:22:30 2025 Received: (at 77215) by debbugs.gnu.org; 25 Mar 2025 05:22:30 +0000 Received: from localhost ([127.0.0.1]:35671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1twwkA-00045I-3c for submit@debbugs.gnu.org; Tue, 25 Mar 2025 01:22:30 -0400 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]:49448) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1twwk6-00044y-AW for 77215@debbugs.gnu.org; Tue, 25 Mar 2025 01:22:27 -0400 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-ab7430e27b2so1079516866b.3 for <77215@debbugs.gnu.org>; Mon, 24 Mar 2025 22:22:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742880140; x=1743484940; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=UGA4jz5W4Dq3IGTR7aKMF9OM9O86z3qym4u8hDEIgvs=; b=VmpxR5M/AI2YPzrfYM4qjEetwczlczPtrRaFJIfQRbbN1U24H95L91PwZOi3n97hrh cUrJ7LktftZOy7yxwi9zz4jvu5wFtU4JhKBrfbJlhHg1dYXXlu61TpWfw+/6AmI/P0BA C+sC6FsyXjKi+yIEGvzoXSI1b3QtLKTA+QmTel5kzsU39ir6tKR4IDvGoUQI7SeBjuLU +feJf+c6PappP/yyol9loQdKjMFH2DX4papLpA71oC7/lc6V6JUyCl1gyKDqZhXfe+xi 5gOXOpGrUYOdYaxO06H0kRxof+2axdVZenR6soUYvnYFcSvab6y3AnB1XBGU+DTTII4q nMZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742880140; x=1743484940; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UGA4jz5W4Dq3IGTR7aKMF9OM9O86z3qym4u8hDEIgvs=; b=hAjbmzT7r5NlXhrsDVGlTkRJDOAEgQfKY4wdvaRSVmhAfne5zgnQF8YULIBrA3LuZ7 p/HaPPA2I9aiX52kmdJ1ZD23+nHDXVsQY4D7mIPJp6xuabsgU+PeOgT1X+ubqWmLLSkw HYuTm5QkPMGqf7ULjh4+ERhvH395pdD6Jq3uXTUS00bn3o2iMxJ6IRmw7FUXEqemAVbF BgLyXzDMGMa+k8MgmWwmZ24aeoTo+Cy3r67ciIeO06ABsoh8pJx/HlS7K0NOd6iyNwAf 7T4CeYT2sd8TutElX2HhrKuFYsQPJg9j98qvC1H9VjA2pUVahSPX4u1XWk2CUt+raRFA RJug== X-Forwarded-Encrypted: i=1; AJvYcCUzUQWLetFKMaTpSiyGh2k4xGaP9J87BmI9ZPEL3QRo3B0/bj/vfMx9ie7tBcYgdB1yBS4FQw==@debbugs.gnu.org X-Gm-Message-State: AOJu0YyeS6GrXkFIjlX7oGaUedcuUsBMMQU/KjP5oGK8SaOPYPszFeD/ bdQQx+TyWgzQeZO2FKLB2IMzMu9+VQKwfg8oA3SENPe/3PyxY9E5 X-Gm-Gg: ASbGncvKajNDMKHTPVggVoSnH1AI40wfOaJTGJYJMhCHBZtA4KuOehD2XoTKDML6zEq SkujCjhcO7Gl+1HWBKKA0U3Kr0TymjAE315y2rwIv5sO2Uw13axX1f1WNyudrJubxVkT8kxRKeY 9wIzFVuXIL/gKOAk/LmBSNNMFzEHO/6c9KF8Ho5N5ZdjlOzQafxMtKpV7ieBMjsXGIC1LJUNl02 JZZLabkpz014Lq4ZjlqJJsiQOtBSWtdv8Cn9fmhWEiBn0BfceZBW7ivkQBNzI0F8O9PsHs1XxZZ lLdsQRsogLZNreI8x+Rr/pvxv2/I8AG3yhprswXE+RmaoA4CROi0 X-Google-Smtp-Source: AGHT+IGhW+Yju+nTiJm7p9RJDK2aRxL3xKcham0aZzz3ZkF8X6GAO8LvA01Td0dVWLSp5KjdjnI/3g== X-Received: by 2002:a17:907:3f20:b0:abf:59e1:ad88 with SMTP id a640c23a62f3a-ac3f229c5cdmr1372759266b.29.1742880139706; Mon, 24 Mar 2025 22:22:19 -0700 (PDT) Received: from mba ([151.81.191.82]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3ef8e511dsm799217466b.64.2025.03.24.22.22.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 22:22:18 -0700 (PDT) From: Filippo Argiolas To: Mauro Aranda , 77215@debbugs.gnu.org Subject: Re: bug#77215: 31.0.50; enable-theme-functions fires twice after a load-theme In-Reply-To: <3eee3672-5367-4a59-a46b-94e365ad1a3d@gmail.com> References: <3eee3672-5367-4a59-a46b-94e365ad1a3d@gmail.com> Date: Tue, 25 Mar 2025 06:22:17 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77215 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Filippo Argiolas writes: > > > Hi, > > > > I noticed that my `enable-theme-functions' hook always fires twice > > after either a `load-theme' or a `enable-theme'. > > > > Problem is `enable-theme' in custom.el always also enables the user > > theme to push it on top of the list. > > > > Is this desired? > > > > Technically I'd say it's correct, two enables spark two hooks, but > > from the user point of view seems a counterintuitive side effect > > without digging into the code. > > > > Filippo > > I think it would be good to avoid it. The attached patch does that. Thanks, looks good to me and it fixes the problem here. Filippo