GNU bug report logs - #77203
[PATCH 0/4] gnu: Add fscrypt.

Previous Next

Full log

Message #20 received at 77203 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 77203 <at> debbugs.gnu.org
Cc: 45mg.writes <at> gmail.com, leo <at> famulari.name
Subject: [PATCH 0/4] gnu: Add fscrypt.
Date: Sun, 30 Mar 2025 16:40:06 +0100

[Message part 1 (text/plain, inline)]

Hi

Thank you for the patches.

I picked it upas I've checked "tag:team-go" on it.
CC Leo Famulari for patches related to Linux.

This is a first round of review just touching most obvious points.

> [PATCH 4/4] gnu: Add fscryptctl.

That may go to (gnu packages filesystems) to reduce cross references and
as it's a final command and not golang module.

It also contains all required modules:
--8<---------------cut here---------------start------------->8---
(define-module (gnu packages file-systems)
  ...
  #:use-module (gnu packages base)
  ...
  #:use-module (gnu packages golang-build)
  #:use-module (gnu packages golang-check)
  #:use-module (gnu packages golang-crypto)
  #:use-module (gnu packages golang-xyz)
  ...
  #:use-module (gnu packages linux)
  ...
  #:use-module (gnu packages m4)
  ...
  #:use-module (gnu packages version-control)
--8<---------------cut here---------------end--------------->8---

--8<---------------cut here---------------start------------->8---
+    (propagated-inputs (list go-github-com-client9-misspell
--8<---------------cut here---------------end--------------->8---
As it's a final command all Golang modules need to be listed in native
inputs.

--
Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.