GNU bug report logs - #77197
31.0.50; forward-word fails after yanking into summary line of *vc-log*

Previous Next

Full log

Message #14 received at 77197 <at> debbugs.gnu.org (full text, mbox):

From: "Paul D. Nelson" <ultrono <at> gmail.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 77197 <at> debbugs.gnu.org
Subject: Re: bug#77197: 31.0.50; forward-word fails after yanking into summary
 line of *vc-log*
Date: Sun, 23 Mar 2025 14:12:15 +0100

[Message part 1 (text/plain, inline)]

> I've been running into this lately too.  I intend to look into it,
> though any further investigation from you would be much appreciated.

The issue starts at 2f3cf7ffe3c9ce986caf6d093b880fed6046b7ec, whose
purpose (bug#15645) was to have C-a take us to the start of the field
rather than the the start of the line.  Reverting log-edit.el to any
prior commit resolves the issue.

The issue is that after inserting the headers with

(propertize (concat header ": ")
            'field 'header
            'rear-nonsticky t)

any typed text inherits the (field header) property, but yanked or
inserted text does not, introducing a field boundary that obstructs
forward-word.

Removing these properties like in the patch below addresses the issue,
but I'll confess that I don't understand why these properties were
introduced; I hope someone that does can analyze further.  Indeed, I
haven't been able to reproduce bug#15645 after evaluating older versions
of log-edit.el, so maybe something relevant outside of log-edit.el has
changed in the mean time, but C-a is bound to
log-edit-beginning-of-line, which is a light wrapper around
message-beginning-of-line, which has had the "beginning of header"
feature since many years before bug#15645, so maybe I missed something.

[Message part 2 (text/x-patch, inline)]

diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
index e23e7414a18..e674f56f1e1 100644
--- a/lisp/vc/log-edit.el
+++ b/lisp/vc/log-edit.el
@@ -896,9 +896,7 @@ log-edit-empty-buffer-p
 
 (defun log-edit--make-header-line (header &optional value)
   ;; Make \\`C-a' work like it does in other buffers with header names.
-  (concat (propertize (concat header ": ")
-                      'field 'header
-                      'rear-nonsticky t)
+  (concat (concat header ": ")
           value
           "\n"))
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.