GNU bug report logs - #77186
[PATCH 00/13] Revamp the gitolite-service-type

Previous Next

Full log

Message #98 received at 77186 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Tomas Volf <~@wolfsden.cz>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 77186 <at> debbugs.gnu.org
Subject: Re: [bug#77186] [PATCH 00/13] Revamp the gitolite-service-type
Date: Thu, 27 Mar 2025 14:55:09 +0900

Hi,

Tomas Volf <~@wolfsden.cz> writes:

> Extensions and improvements for the gitolite-service-type.
>
> Tomas Volf (13):
>   services: gitolite-rc-file-compiler: Switch to match-record.
>   services: gitolite-rc-file: Add log-extra field.
>   services: gitolite-rc-file: Add host-name field.
>   services: gitolite-rc-file: Add extra-content field.
>   services: gitolite-rc-file-compiler: Set mode of the generated file.
>   services: gitolite-rc-file: Export default value for enable.
>   services: gitolite-service-type: Do not install gitolite package.
>   services: gitolite-accounts: Convert to match-record.
>   services: gitolite-activation: Convert to match-record.
>   services: Add gitolite-git-configuration.
>   services: gitolite-git-configuration: Add default-branch field.
>   services: gitolite-git-configuration: Add receive-fsck-objects field.
>   services: gitolite-git-configuration: Add extra-content field.
>
>  doc/guix.texi                    |  41 +++++
>  gnu/packages/version-control.scm |   5 +-

Apart from my comment w.r.t to the log-extra default value in patch
2/13, this LGTM.  Could you clarify my question for said patch?

Reviewed-by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.