Subject: [bug#77186] [PATCH v2 14/14] services: gitolite-service-type: Allow setting the admin name.

From: Maxim Cournoyer <[email-masked]>
Date: Thu, 03 Apr 2025 21:29:47 +0900

Hi,

Tomas Volf <[email-masked]> writes:

> * gnu/services/version-control.scm (<gitolite-configuration>): Add admin-name
> field.
> (gitolite-activation): Use it.
> * doc/guix.texi (Version Control Services): Document it.  Remove the wrong
> default value of admin-pubkey.  State the need for .pub extension.
>
> Change-Id: Idadf4b2697cee6d1da10e6ba03bdc2e1d729c417
> ---
>  doc/guix.texi                    |  9 ++++++++-
>  gnu/services/version-control.scm | 17 +++++++++++------
>  2 files changed, 19 insertions(+), 7 deletions(-)
>
> diff --git a/doc/guix.texi b/doc/guix.texi
> index ad4a623916..5db6f28f7d 100644
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -41013,7 +41013,7 @@ Version Control Services
>  A ``file-like'' object (@pxref{G-Expressions, file-like objects}),
>  representing the git configuration for Gitolite.
>  
> -@item @code{admin-pubkey} (default: @code{#f})
> +@item @code{admin-pubkey}
>  A ``file-like'' object (@pxref{G-Expressions, file-like objects}) used to
>  setup Gitolite.  This will be inserted in to the @file{keydir} directory
>  within the gitolite-admin repository.
> @@ -41024,6 +41024,13 @@ Version Control Services
>  (plain-file "yourname.pub" "ssh-rsa AAAA... guix@@example.com")
>  @end lisp
>  
> +The file has to have @file{.pub} extension.

This could be checked in a sanitizer, with a cute error message + fix
hint shown.

-- 
Thanks,
Maxim