GNU bug report logs - #77173
[PATCH] Instruct users to use customize or setopt for user options that have :set-er

Previous Next

Full log

View this message in rfc822 format

From: Visuwesh <visuweshm <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77173 <at> debbugs.gnu.org
Subject: bug#77173: [PATCH] Instruct users to use customize or setopt for user options that have :set-er
Date: Sun, 23 Mar 2025 11:28:53 +0530

[Message part 1 (text/plain, inline)]

[Saturday March 22, 2025] Eli Zaretskii wrote:

>> > What does this do when the setter is an anonymous function?  We have
>> > quite a lot of these when a defcustom needs a :set function.
>> 
>> It currently does nothing, thanks for catching this.  I forgot to
>> consider lambdas when I wrote the patch earlier.  I think we can leave
>> out the "or call XXX" part if :set is a function?
>
> I don't see any reasonable alternative.

Thanks, now done in the attached.  I hope symbolp is good enough to test
if :set is a named function.

[Saturday March 22, 2025] Stefan Kangas wrote:

> Visuwesh <visuweshm <at> gmail.com> writes:
>
>> [Saturday March 22, 2025] Stefan Kangas wrote:
>>
>>> Thanks.  Are you on a current master?
>>
>> I haven't pulled for a few weeks now.  Should I rework the patch on top
>> of yours?  I think adding this bit to help-fns--customize-variable would
>> be cleaner, but happy to change the function you wrote instead.
>
> Yes, please.  Feel free to suggest something cleaner.
>
> Thanks.

Thanks, I moved the setopt suggestion to help-fns--customize-variable to
keep related code in the same function.  In this process, I removed the
top TODO comment, should we keep it around?

[0001-Improve-formatting-of-setopt-suggestion-in-Help-buff.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.