From unknown Sat Jun 14 19:03:53 2025 X-Loop: help-debbugs@gnu.org Subject: bug#7717: 24.0.50; "games" user is hardcoded in build system Resent-From: Ulrich Mueller Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Dec 2010 08:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7717 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 7717@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.129309302614906 (code B ref -1); Thu, 23 Dec 2010 08:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Dec 2010 08:30:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVgZ6-0003sN-Sa for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:30:25 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVgZ5-0003sC-7C for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:30:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVgfT-0006tV-2u for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:36:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:33898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVgfT-0006tR-0t for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:36:59 -0500 Received: from [140.186.70.92] (port=46171 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVgfR-0001PI-Se for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2010 03:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVgfQ-0006tC-OR for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2010 03:36:57 -0500 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:52707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVgfQ-0006sW-Gl for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2010 03:36:56 -0500 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id oBN8agjt020242 for ; Thu, 23 Dec 2010 09:36:43 +0100 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.3/8.14.2) with ESMTP id oBN8ag74021526; Thu, 23 Dec 2010 09:36:42 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.4/8.14.4/Submit) id oBN8aghA021523; Thu, 23 Dec 2010 09:36:42 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----cutting-here-may-damage-your-screen-surface----54187318----" Content-Transfer-Encoding: 7bit Message-ID: <19731.2586.417212.58988@a1i15.kph.uni-mainz.de> Date: Thu, 23 Dec 2010 09:36:42 +0100 X-Mailer: VM 8.1.1 under 23.2.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.4 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) ------cutting-here-may-damage-your-screen-surface----54187318---- Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit Tags: patch The build system of Emacs currently hardcodes the "games" user that is used for shared score files in ${localstatedir}. While usage of that account name may be widespread, it is not universal. For example, in Gentoo the name is configurable. Since a variable "gameuser" and the autoconf plumbing for it already exist, the only missing piece is a configure option. See attached patch. 2010-12-22 Ulrich Mueller * configure.in: Make gameuser configurable. ------cutting-here-may-damage-your-screen-surface----54187318---- Content-Type: text/plain; name="emacs-gameuser.diff" Content-Disposition: inline; filename="emacs-gameuser.diff" Content-Transfer-Encoding: 7bit --- emacs-orig/configure.in +++ emacs/configure.in @@ -45,8 +45,6 @@ docdir='${datadir}/emacs/${version}/etc' gamedir='${localstatedir}/games/emacs' -gameuser=games - dnl OPTION_DEFAULT_OFF(NAME, HELP-STRING) dnl Create a new --with option that defaults to being disabled. dnl NAME is the base name of the option. The shell variable with_NAME @@ -203,6 +201,13 @@ The default is /usr/lib, or /usr/lib64 on some platforms.])]) CRT_DIR="${with_crt_dir}" +AC_ARG_WITH(gameuser, +[AS_HELP_STRING([--with-gameuser=USER], + [user for shared score files; default games])]) +test "X${with_gameuser}" != X && test "${with_gameuser}" != yes \ + && gameuser="${with_gameuser}" +test "X$gameuser" = X && gameuser=games + AC_ARG_WITH([gnustep-conf],dnl [AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default $GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])]) test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \ ------cutting-here-may-damage-your-screen-surface----54187318------ From unknown Sat Jun 14 19:03:53 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ulrich Mueller Subject: bug#7717: closed (Re: bug#7717: 24.0.50; "games" user is hardcoded in build system) Message-ID: References: <874o9wj0g0.fsf@stupidchicken.com> <19731.2586.417212.58988@a1i15.kph.uni-mainz.de> X-Gnu-PR-Message: they-closed 7717 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 7717@debbugs.gnu.org Date: Wed, 29 Dec 2010 11:08:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1293620882-25377-1" This is a multi-part message in MIME format... ------------=_1293620882-25377-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #7717: 24.0.50; "games" user is hardcoded in build system which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 7717@debbugs.gnu.org. --=20 7717: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D7717 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1293620882-25377-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 7717-done) by debbugs.gnu.org; 29 Dec 2010 11:07:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXtsH-0006aS-C7 for submit@debbugs.gnu.org; Wed, 29 Dec 2010 06:07:21 -0500 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PXtsF-0006aG-Lb for 7717-done@debbugs.gnu.org; Wed, 29 Dec 2010 06:07:19 -0500 Received: from furball (bb220-255-229-62.singnet.com.sg [220.255.229.62]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id oBTBE9g9027923 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 29 Dec 2010 06:14:11 -0500 Received: by furball (Postfix, from userid 1000) id CDF81160C98; Wed, 29 Dec 2010 19:14:07 +0800 (SGT) From: Chong Yidong To: Ulrich Mueller Subject: Re: bug#7717: 24.0.50; "games" user is hardcoded in build system References: <19731.2586.417212.58988@a1i15.kph.uni-mainz.de> Date: Wed, 29 Dec 2010 19:14:07 +0800 In-Reply-To: <19731.2586.417212.58988@a1i15.kph.uni-mainz.de> (Ulrich Mueller's message of "Thu, 23 Dec 2010 09:36:42 +0100") Message-ID: <874o9wj0g0.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 7717-done Cc: 7717-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Ulrich Mueller writes: > The build system of Emacs currently hardcodes the "games" user that is > used for shared score files in ${localstatedir}. While usage of that > account name may be widespread, it is not universal. For example, in > Gentoo the name is configurable. > > Since a variable "gameuser" and the autoconf plumbing for it already > exist, the only missing piece is a configure option. See attached > patch. Looks reasonable. Committed to trunk; thanks. ------------=_1293620882-25377-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Dec 2010 08:30:26 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVgZ6-0003sN-Sa for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:30:25 -0500 Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PVgZ5-0003sC-7C for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:30:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVgfT-0006tV-2u for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:36:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from lists.gnu.org ([199.232.76.165]:33898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVgfT-0006tR-0t for submit@debbugs.gnu.org; Thu, 23 Dec 2010 03:36:59 -0500 Received: from [140.186.70.92] (port=46171 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVgfR-0001PI-Se for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2010 03:36:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVgfQ-0006tC-OR for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2010 03:36:57 -0500 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:52707) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVgfQ-0006sW-Gl for bug-gnu-emacs@gnu.org; Thu, 23 Dec 2010 03:36:56 -0500 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.0/8.13.4) with ESMTP id oBN8agjt020242 for ; Thu, 23 Dec 2010 09:36:43 +0100 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.3/8.14.2) with ESMTP id oBN8ag74021526; Thu, 23 Dec 2010 09:36:42 +0100 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.4/8.14.4/Submit) id oBN8aghA021523; Thu, 23 Dec 2010 09:36:42 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----cutting-here-may-damage-your-screen-surface----54187318----" Content-Transfer-Encoding: 7bit Message-ID: <19731.2586.417212.58988@a1i15.kph.uni-mainz.de> Date: Thu, 23 Dec 2010 09:36:42 +0100 To: bug-gnu-emacs@gnu.org Subject: 24.0.50; "games" user is hardcoded in build system X-Mailer: VM 8.1.1 under 23.2.1 (x86_64-pc-linux-gnu) From: Ulrich Mueller X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.5 (-----) ------cutting-here-may-damage-your-screen-surface----54187318---- Content-Type: text/plain; charset=us-ascii Content-Description: message body text Content-Transfer-Encoding: 7bit Tags: patch The build system of Emacs currently hardcodes the "games" user that is used for shared score files in ${localstatedir}. While usage of that account name may be widespread, it is not universal. For example, in Gentoo the name is configurable. Since a variable "gameuser" and the autoconf plumbing for it already exist, the only missing piece is a configure option. See attached patch. 2010-12-22 Ulrich Mueller * configure.in: Make gameuser configurable. ------cutting-here-may-damage-your-screen-surface----54187318---- Content-Type: text/plain; name="emacs-gameuser.diff" Content-Disposition: inline; filename="emacs-gameuser.diff" Content-Transfer-Encoding: 7bit --- emacs-orig/configure.in +++ emacs/configure.in @@ -45,8 +45,6 @@ docdir='${datadir}/emacs/${version}/etc' gamedir='${localstatedir}/games/emacs' -gameuser=games - dnl OPTION_DEFAULT_OFF(NAME, HELP-STRING) dnl Create a new --with option that defaults to being disabled. dnl NAME is the base name of the option. The shell variable with_NAME @@ -203,6 +201,13 @@ The default is /usr/lib, or /usr/lib64 on some platforms.])]) CRT_DIR="${with_crt_dir}" +AC_ARG_WITH(gameuser, +[AS_HELP_STRING([--with-gameuser=USER], + [user for shared score files; default games])]) +test "X${with_gameuser}" != X && test "${with_gameuser}" != yes \ + && gameuser="${with_gameuser}" +test "X$gameuser" = X && gameuser=games + AC_ARG_WITH([gnustep-conf],dnl [AS_HELP_STRING([--with-gnustep-conf=PATH],[path to GNUstep.conf; default $GNUSTEP_CONFIG_FILE, or /etc/GNUstep/GNUstep.conf])]) test "X${with_gnustep_conf}" != X && test "${with_gnustep_conf}" != yes && \ ------cutting-here-may-damage-your-screen-surface----54187318------ ------------=_1293620882-25377-1--