GNU bug report logs - #77157
[PATCH] 'uniquify' user option setters and automatic buffer refresh

Previous Next

Full log

View this message in rfc822 format

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77157 <at> debbugs.gnu.org
Subject: bug#77157: [PATCH] 'uniquify' user option setters and automatic buffer refresh
Date: Sat, 22 Mar 2025 07:40:43 -0400

[Message part 1 (text/plain, inline)]

On Sat, Mar 22, 2025 at 7:17 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Ship Mints <shipmints <at> gmail.com>
> > Date: Sat, 22 Mar 2025 07:04:08 -0400
> > Cc: 77157 <at> debbugs.gnu.org
> >
> >  We usually use the following style for such variables:
> >
> >    Setting this variable directly will not usually take effect;
> >    use either \\[customize] or `setopt', or call `uniquify--set-option'
> >    or restart `uniquify-mode' after setting the variable directly.
> >
> >  I'll adapt this language.  Uniquify isn't implemented as a mode.  It's
> a rename buffer hook in buffer.c
> >  and depends on 'uniquify-buffer-name-style' to have a defined style.
> >
> >  Even the function 'uniquify-unload-function' doesn't attempt to remove
> the hook (it probably should set
> >  'uniquify-buffer-name-style' to nil as part of its business).  It's not
> even clear if unload ever gets called
> >  by anyone.  Perhaps a candidate to obsolete.
> >
> > The following seems more precise.  Okay with you?
> >
> > Setting this variable directly will not usually take effect; use either
> > \\[customize] or `setopt', or call `uniquify--set-option'; otherwise
> > reload your buffers, or restart Emacs.
>
> Yes, but I'd omit the "restart Emacs" alternative, as too far-fetched
> (we are talking about the ways to make the change take effect in the
> same session).
>
> Thanks.
>

Revised patch attached.  It's my pleasure.

[Message part 2 (text/html, inline)]

[0001-uniquify-user-option-setters-and-automatic-buffer-re.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.