GNU bug report logs - #77153
[PATCH 0/3] doc: cookbook: Manual libvirt networking.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#77153: closed ([PATCH 0/3] doc: cookbook: Manual libvirt
 networking.)
Date: Sun, 23 Mar 2025 04:16:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 23 Mar 2025 13:14:44 +0900
with message-id <87frj4fknf.fsf <at> gmail.com>
and subject line Re: [bug#77153] [PATCH v3 3/3] doc: cookbook: Custom NAT-based libvirt networks.
has caused the debbugs.gnu.org bug report #77153,
regarding [PATCH 0/3] doc: cookbook: Manual libvirt networking.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
77153: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=77153
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: 45mg <45mg.writes <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: 45mg <45mg.writes <at> gmail.com>
Subject: [PATCH 0/3] doc: cookbook: Manual libvirt networking.
Date: Fri, 21 Mar 2025 20:49:31 +0530

45mg (3):
  doc: cookbook: Fix terminology for libvirt virtual network switches
  doc: cookbook: Clarify virtual network switches.
  doc: cookbook: Document manual libvirt networking.

 doc/guix-cookbook.texi | 154 ++++++++++++++++++++++++++++++++++++-----
 1 file changed, 138 insertions(+), 16 deletions(-)


base-commit: 9eddd250b773043fcac5e7eaa4939e5a2d9940bd
-- 
2.48.1

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: 45mg <45mg.writes <at> gmail.com>
Cc: Ludovic Courtès <ludo <at> gnu.org>, 77153-done <at> debbugs.gnu.org
Subject: Re: [bug#77153] [PATCH v3 3/3] doc: cookbook: Custom NAT-based
 libvirt networks.
Date: Sun, 23 Mar 2025 13:14:44 +0900

Hi,

45mg <45mg.writes <at> gmail.com> writes:

> * doc/guix-cookbook.texi (Virtual Machines): [Custom NAT-based network
> for libvirt]: New section.
> [References]: New section.

I needed to add a missing @node for the new section and refresh the
menus (C-c C-u C-a in texinfo-mode in Emacs), resulting in:

--8<---------------cut here---------------start------------->8---
Unstaged changes (1)
modified   doc/guix-cookbook.texi
@@ -167,6 +167,8 @@ Top
 
 * Network bridge for QEMU::
 * Routed network for libvirt::
+* Custom NAT-based network for libvirt::
+* References: VM References.    Further reading on virtual machines.
 
 Advanced package management
 
@@ -3752,7 +3754,7 @@ Virtual Machines
 * Network bridge for QEMU::
 * Routed network for libvirt::
 * Custom NAT-based network for libvirt::
-* References::
+* References: VM References.    Further reading on virtual machines.
 @end menu
 
 @node Network bridge for QEMU
@@ -4092,6 +4094,7 @@ Custom NAT-based network for libvirt
 Ensure that you have IPv4 forwarding enabled (you can use
 @code{sysctl-service-type} for this).
 
+@node VM References
 @section References
 
 @itemize
--8<---------------cut here---------------end--------------->8---

I struggled a bit because nodes must apparently have unique names (and
they are what the menus references, so previously it'd refer to a
different section).

In the end I chose to name the node differently from the section, and
use the alternate 'Name: Node name.' form for a menu entry.  See (info
"(texinfo) Menu Parts").

Another small thing: GNU ChangeLog commit messages should document
changes, not reasoning.  It's OK and welcome to add a rationale to the
commit message, but it should appear in a paragraph between the summary
line and the changelog.

Pushed as commit da09013802.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.