Subject: Re: [PATCH 1/9] gnu: Add u-boot-qemu-ppce550.

From: Maxim Cournoyer <[email-masked]>
Date: Mon, 24 Mar 2025 09:24:43 +0900

Hi Efraim!

Efraim Flashner <[email-masked]> writes:

[...]

>> > +(define-public u-boot-qemu-ppce550
>> > +  (let ((base
>> > +          (make-u-boot-package "qemu-ppce500" "powerpc-linux-gnu"
>> > +                               ;; Disable features that require OpenSSL due
>> > +                               ;; to GPL/Openssl license incompatibilities.
>> > +                               ;; See https://bugs.gnu.org/34717 for
>> > +                               ;; details.
>> > +                               #:configs '("# CONFIG_FIT_SIGNATURE is not set"))))
>> 
>> I thought the GPL incompatibility had been resolved in recent years (see
>> https://openssl-library.org/post/2017-03-20-license/) ?
>
> I just copied it from the config above it, but I think we can drop it.

Yes!

>> > +    (package
>> > +      (inherit base)
>> > +      (arguments
>> > +       (substitute-keyword-arguments (package-arguments base)
>> > +         ((#:phases phases #~'%standard-phases)
>> > +          #~(modify-phases #$phases
>> > +              (replace 'install
>> > +                (lambda _
>> > +                  (mkdir-p (string-append #$output "/share/qemu"))
>> > +                  (copy-file "u-boot" (string-append
>> > +                                        #$output "/share/qemu/u-boot.e500")))))))))))
>> 
>> I'm not sure why we need a qemu variant; just having u-boot-ppce550 with
>> a libvirt/QEMU firmware descriptor should be enough, unless I'm missing
>> something.
>
> qemu_ppce550 is the name of the config and I figured for qemu it would
> be better to have the name of the file match the bundled firmware file.

Makes sense.  Thanks for the clarification.

-- 
Thanks,
Maxim