GNU bug report logs - #77143
30.1; package--description-file handles some packages wrong

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 77143 in the body.
You can then email your comments to 77143 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lin Jian <me <at> linj.tech>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.1; package--description-file handles some packages wrong
Date: Fri, 21 Mar 2025 09:10:54 +0800

Actual result:
(package--description-file "/some/path/p4-16-mode-0.3")
  ⇒ "p4-pkg.el"

Expected result:
(package--description-file "/some/path/p4-16-mode-0.3")
  ⇒ "p4-16-mode-pkg.el"

This example is for p4-16-mode[0].  There are a few other packages
having this issue, such as auth-source-1password[1], comment-dwim-2[2],
cyberpunk-2019-theme[3], iso-639[4], ox-750words[5] and
tango-2-theme[6].

[0]: https://elpa.nongnu.org/nongnu/p4-16-mode.html
[1]: https://github.com/dlobraico/auth-source-1password
[2]: https://github.com/remyferre/comment-dwim-2
[3]: https://github.com/the-frey/cyberpunk-2019
[4]: https://codeberg.org/tomenzgg/emacs-iso-639
[5]: https://github.com/zzamboni/750words-client
[6]: https://gist.github.com/developernotes/2024464

Message #8 received at 77143 <at> debbugs.gnu.org (full text, mbox):

From: Lin Jian <me <at> linj.tech>
To: 77143 <at> debbugs.gnu.org
Subject: Re: 30.1; package--description-file handles some packages wrong
Date: Fri, 21 Mar 2025 10:12:02 +0800

[Message part 1 (text/plain, inline)]

I made a patch to fix this.

I also notice that the version part of the regex can be improved because
it does not take `version-regexp-alist' into consideration.  But that is
out of the scope of this bug.

[0001-Fix-pkg-description-file-name-when-pkg-name-has-numb.patch (text/x-patch, attachment)]

Message #11 received at 77143 <at> debbugs.gnu.org (full text, mbox):

From: Lin Jian <me <at> linj.tech>
To: 77143 <at> debbugs.gnu.org
Subject: Re: 30.1; package--description-file handles some packages wrong
Date: Fri, 21 Mar 2025 11:50:42 +0800

Lin Jian <me <at> linj.tech> writes:

> I also notice that the version part of the regex can be improved because
> it does not take `version-regexp-alist' into consideration.  But that is
> out of the scope of this bug.

I tested the above patch with all elisp packages from (Non)GNU(-devel)
ELPA and MELPA.  All 7 packages from my initial post are fixed.  At the
same time, I find only one package vm[0] is "broken" by my patch.

Without my patch, the result is right.
(package--description-file "vm-8.3.0snapshot0.20250208.60553")
  ⇒ "vm-pkg.el"

With my patch, the result is wrong.
(package--description-file "vm-8.3.0snapshot0.20250208.60553")
  ⇒ "vm-8.3.0snapshot0.20250208.60553-pkg.el"

A quick fix is to add snapshot to the regex version part.

A proper fix is to make the regex version part know
`version-regexp-alist'.

[0]: https://elpa.nongnu.org/nongnu-devel/vm.html

Message #16 received at 77143 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Jian <me <at> linj.tech>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 77143 <at> debbugs.gnu.org
Subject: Re: bug#77143: 30.1;
 package--description-file handles some packages wrong
Date: Sat, 29 Mar 2025 14:47:52 +0300

> Date: Fri, 21 Mar 2025 11:50:42 +0800
> From:  Lin Jian via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Lin Jian <me <at> linj.tech> writes:
> 
> > I also notice that the version part of the regex can be improved because
> > it does not take `version-regexp-alist' into consideration.  But that is
> > out of the scope of this bug.
> 
> I tested the above patch with all elisp packages from (Non)GNU(-devel)
> ELPA and MELPA.  All 7 packages from my initial post are fixed.  At the
> same time, I find only one package vm[0] is "broken" by my patch.
> 
> Without my patch, the result is right.
> (package--description-file "vm-8.3.0snapshot0.20250208.60553")
>   ⇒ "vm-pkg.el"
> 
> With my patch, the result is wrong.
> (package--description-file "vm-8.3.0snapshot0.20250208.60553")
>   ⇒ "vm-8.3.0snapshot0.20250208.60553-pkg.el"
> 
> A quick fix is to add snapshot to the regex version part.
> 
> A proper fix is to make the regex version part know
> `version-regexp-alist'.
> 
> [0]: https://elpa.nongnu.org/nongnu-devel/vm.html

Stefan, any comments?

Message #19 received at 77143 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lin Jian <me <at> linj.tech>
Cc: 77143 <at> debbugs.gnu.org
Subject: Re: bug#77143: 30.1; package--description-file handles some
 packages wrong
Date: Mon, 31 Mar 2025 15:04:19 -0400

>> I also notice that the version part of the regex can be improved because
>> it does not take `version-regexp-alist' into consideration.  But that is
>> out of the scope of this bug.
>
> I tested the above patch with all elisp packages from (Non)GNU(-devel)
> ELPA and MELPA.  All 7 packages from my initial post are fixed.  At the
> same time, I find only one package vm[0] is "broken" by my patch.
>
> Without my patch, the result is right.
> (package--description-file "vm-8.3.0snapshot0.20250208.60553")
>   ⇒ "vm-pkg.el"
>
> With my patch, the result is wrong.
> (package--description-file "vm-8.3.0snapshot0.20250208.60553")
>   ⇒ "vm-8.3.0snapshot0.20250208.60553-pkg.el"
>
> A quick fix is to add snapshot to the regex version part.

Thanks I pushed your patch, amended to add `snapshot`.

Sadly, the problem will keep biting users of older Emacsen, making the
use of such package names problematic for years to come.

> A proper fix is to make the regex version part know
> `version-regexp-alist'.

Actually, we need only to match the versions generated by
`package-version-join`, not all the versions that `version-to-list`
accepts (luckily, because that would make the thing even more delicate
since `version-to-list` allows `-` to appear within a version name,
introducing a lot more ambiguity).


        Stefan

Message #22 received at 77143 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: me <at> linj.tech, 77143 <at> debbugs.gnu.org
Subject: Re: bug#77143: 30.1;
 package--description-file handles some packages wrong
Date: Tue, 01 Apr 2025 14:12:31 +0300

> Cc: 77143 <at> debbugs.gnu.org
> Date: Mon, 31 Mar 2025 15:04:19 -0400
> From:  Stefan Monnier via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> >> I also notice that the version part of the regex can be improved because
> >> it does not take `version-regexp-alist' into consideration.  But that is
> >> out of the scope of this bug.
> >
> > I tested the above patch with all elisp packages from (Non)GNU(-devel)
> > ELPA and MELPA.  All 7 packages from my initial post are fixed.  At the
> > same time, I find only one package vm[0] is "broken" by my patch.
> >
> > Without my patch, the result is right.
> > (package--description-file "vm-8.3.0snapshot0.20250208.60553")
> >   ⇒ "vm-pkg.el"
> >
> > With my patch, the result is wrong.
> > (package--description-file "vm-8.3.0snapshot0.20250208.60553")
> >   ⇒ "vm-8.3.0snapshot0.20250208.60553-pkg.el"
> >
> > A quick fix is to add snapshot to the regex version part.
> 
> Thanks I pushed your patch, amended to add `snapshot`.

Thanks.

Should this bug be closed now?

Message #27 received at 77143-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: monnier <at> iro.umontreal.ca, me <at> linj.tech
Cc: 77143-done <at> debbugs.gnu.org
Subject: Re: bug#77143: 30.1;
 package--description-file handles some packages wrong
Date: Sun, 13 Apr 2025 11:16:14 +0300

> Cc: me <at> linj.tech, 77143 <at> debbugs.gnu.org
> Date: Tue, 01 Apr 2025 14:12:31 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > Cc: 77143 <at> debbugs.gnu.org
> > Date: Mon, 31 Mar 2025 15:04:19 -0400
> > From:  Stefan Monnier via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> > 
> > >> I also notice that the version part of the regex can be improved because
> > >> it does not take `version-regexp-alist' into consideration.  But that is
> > >> out of the scope of this bug.
> > >
> > > I tested the above patch with all elisp packages from (Non)GNU(-devel)
> > > ELPA and MELPA.  All 7 packages from my initial post are fixed.  At the
> > > same time, I find only one package vm[0] is "broken" by my patch.
> > >
> > > Without my patch, the result is right.
> > > (package--description-file "vm-8.3.0snapshot0.20250208.60553")
> > >   ⇒ "vm-pkg.el"
> > >
> > > With my patch, the result is wrong.
> > > (package--description-file "vm-8.3.0snapshot0.20250208.60553")
> > >   ⇒ "vm-8.3.0snapshot0.20250208.60553-pkg.el"
> > >
> > > A quick fix is to add snapshot to the regex version part.
> > 
> > Thanks I pushed your patch, amended to add `snapshot`.
> 
> Thanks.
> 
> Should this bug be closed now?

Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.