GNU bug report logs - #77138
[PATCH] Add major mode for highlighting .npmrc files

Previous Next

Full log

Message #14 received at 77138 <at> debbugs.gnu.org (full text, mbox):

From: Konstantin Kharlamov <Hi-Angel <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77138 <at> debbugs.gnu.org
Subject: Re: bug#77138: [PATCH] Add major mode for highlighting .npmrc files
Date: Sat, 22 Mar 2025 16:59:57 +0300

[Message part 1 (text/plain, inline)]

On Sat, 2025-03-22 at 15:51 +0300, Konstantin Kharlamov wrote:
> On Sat, 2025-03-22 at 13:48 +0200, Eli Zaretskii wrote:
> > > +(define-derived-mode conf-npmrc-mode conf-mode "Conf[npmrc]"
> > > + "Conf Mode starter for .npmrc files.
> > > +Comments start with `#' and `;'. For details see `conf-mode'."
> > > + (conf-mode-initialize "#")
> > > + (modify-syntax-entry ?\; "<")
> > > + (modify-syntax-entry ?\# "<"))
> > 
> > Doesn't this affect the global syntax table, not just the syntax
> > local to the buffer under this mode?
> 
> Oooh, good catch! I counfounded "current buffer's syntax table" with
> being buffer-local as opposed to mode local.
> 
> Thank you very much, will fix today!

Fixed! Patch is attached

[1.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.