From unknown Wed Jun 18 23:07:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#77136 <77136@debbugs.gnu.org> To: bug#77136 <77136@debbugs.gnu.org> Subject: Status: 31.0.50; package.el: Built-in packages marked as upgradable when versions =?UTF-8?Q?=E2=89=A4?= bundled version Reply-To: bug#77136 <77136@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:07:04 +0000 retitle 77136 31.0.50; package.el: Built-in packages marked as upgradable w= hen versions =E2=89=A4 bundled version reassign 77136 emacs submitter 77136 davidimagid@gmail.com severity 77136 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 20 11:44:18 2025 Received: (at submit) by debbugs.gnu.org; 20 Mar 2025 15:44:18 +0000 Received: from localhost ([127.0.0.1]:58535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvI49-0005B5-Op for submit@debbugs.gnu.org; Thu, 20 Mar 2025 11:44:18 -0400 Received: from lists.gnu.org ([2001:470:142::17]:53388) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tvI45-00059b-GO for submit@debbugs.gnu.org; Thu, 20 Mar 2025 11:44:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvI3S-00020v-LX for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2025 11:43:36 -0400 Received: from mail-ua1-x930.google.com ([2607:f8b0:4864:20::930]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tvI3D-0007E6-NY for bug-gnu-emacs@gnu.org; Thu, 20 Mar 2025 11:43:27 -0400 Received: by mail-ua1-x930.google.com with SMTP id a1e0cc1a2514c-86d6ac4d5a9so415317241.1 for ; Thu, 20 Mar 2025 08:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742485397; x=1743090197; darn=gnu.org; h=mime-version:message-id:date:user-agent:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=g7EmSUtiyPTnfT6SZ6ex3MfSV1Zy7ZNkQNesTBSI28s=; b=mZa7Ow4Kn7FBF6WhJ0Qq0dbq8GvJmUDDjFDKAeDUYKLUiAztx9pXkQgQ6t8HeTKAnO siu6BlBe2sqkyxoB1bGZdnq0HD6iCKxPDbs5LkQ/sBJ6zsa+Fi5U2kfcDj6IkfbfRNT+ cMt0SXa+VRqFySt4IQFjkFaW7XJduGyfNHW5la5ufgueilDNUvOhBiR2G8iZ2hotqj8k IEWIgbW3ukM2+eG1W5iutAA6alkrkawfc4gnKFGtz5VFif6x7mTQ0Ay3jAVKu6yOvUrJ DHSN3RFndJ7sCih7CR0mvI1T4Yc/bfJlSzmISJcq5XvSggi29UBN+CXVsgo1SEkb8Im0 F1SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742485397; x=1743090197; h=mime-version:message-id:date:user-agent:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g7EmSUtiyPTnfT6SZ6ex3MfSV1Zy7ZNkQNesTBSI28s=; b=xTY1tkAW+E4VDZb6hoA0MeXdCOfIwvu0OCnu6ZWUBP7Ba46pTJDvisnw8+pimRfZvh Xz7QV5LRL/CYRilQ3SVQL8Ygb1wSwsk3bnRSK/McTBN/poTGoAGz/qsKdWwniU0i42d/ A20AOAq66LW+03L/6kQgdI7qjgF928szqMvjfi53vKdkepZRtjWI+XFNHrgON8KouQBH OTB8/7CZmysnQ9qGDRLeSlvsXIGjR0yNa/p15WTfKboYL9Mb+VQiOPam2v1hCKBK8Ivo aZAcDJVvLhQuold99G3MU+cXERn/O4LHWO8Bt8r5ssNj9BVskuMSduI4P3zg7OqX0Utf lYHQ== X-Gm-Message-State: AOJu0YzGglvEeDMoLFsrljfgXursywqRMHck4tgoYFkHf5cJ3VI5kVU/ p/EvuVpUplZL5p2BsitXezXmecmPlCvfb2Q8s0Fsc57ot94AnN0Hp59Nhg== X-Gm-Gg: ASbGncv3u7niAmBIS5Pkvd+5wzYqfpHwSbFfJVPZJWp0fqIpLhShb1WZg5xyHtvF0q2 NY56khjEqYZVja9wgLpNtn068HiNo5i8lA1nmwwlJR/olXm/KSGTgloV5dvK1UwYg/XjNdpxidb 99m6D8rdskgxk3V1RFK5GMLJfgOGyTPgLcY1Jn5ra03KuOvzOXIFDXw+IDDmGN8BfaIe4co6BQV rUa2fIV/5kroaCob2BdmBHp/+lKTTF4mz5stt9peR9bthtIdWNQXUvikC5YBTmcB+iZce64WxYA bJxtu473IA6q55YnQyg8pPqOA4FlUjRml4d/4A== X-Google-Smtp-Source: AGHT+IFdBV+D+DiW4LpqqSbz5HE+6J5r4uNQSG5coot/ksKa7RLjVB5s+HXZ++B1lh+8MU6Tc93z+w== X-Received: by 2002:a05:6102:304c:b0:4c3:c9:c667 with SMTP id ada2fe7eead31-4c4fce43641mr3786902137.24.1742485395272; Thu, 20 Mar 2025 08:43:15 -0700 (PDT) Received: from fedora ([190.6.17.138]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-86f9f3c2d01sm4990241.16.2025.03.20.08.43.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 08:43:14 -0700 (PDT) From: davidimagid@gmail.com To: bug-gnu-emacs@gnu.org Subject: 31.0.50; package.el: Built-in packages marked as upgradable when versions =?utf-8?Q?=E2=89=A4?= bundled version User-Agent: mu4e 1.12.8; emacs 31.0.50 X-Debbugs-Cc: Philip Kaludercic , Stefan Monnier , Eli Zaretskii , Stefan Kangas Date: Thu, 20 Mar 2025 11:43:06 -0400 Message-ID: <87a59foghh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::930; envelope-from=davidimagid@gmail.com; helo=mail-ua1-x930.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Dear Emacs maintainers, I've encountered an issue in `package.el` where built-in packages are marked as upgradable even when the repository version is <= the built-in version. This occurs because the version comparison logic prioritizes repository versions over built-in ones. ### Steps to reproduce: 1. Set package-archive-priorities to '(("gnu" . 5) ("nongnu" . 4)). 2. Set package-install-upgrade-built-in to t. 3. Run `M-x list-packages` and observe the package status. ### Current behavior: Built-in packages are marked as upgradable even when the repository version is <= the built-in version. ### Expected behavior: Built-in packages should only be marked as upgradable if the repository version is newer. In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.2) of 2025-03-16 built on fedora Repository revision: eab14d68b2e72b9a6b8b0cc67c9667c2bfbed4f5 Repository branch: master System Description: Fedora Linux 41 (Workstation Edition) Configured using: 'configure --with-imagemagick --with-pgtk --with-tree-sitter --with-mailutils --with-sound=yes --with-pdumper=yes --with-dumping=pdumper --with-file-notification=yes --with-gnutls' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr compile comint ansi-osc ansi-color ring comp-run bytecomp byte-compile comp-common rx emacsbug lisp-mnt message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win touch-screen pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk multi-tty move-toolbar make-network-process tty-child-frames native-compile emacs) Memory information: ((conses 16 66717 12779) (symbols 48 6838 0) (strings 32 17183 2502) (string-bytes 1 531430) (vectors 16 10577) (vector-slots 8 148392 3429) (floats 8 22 13) (intervals 56 249 0) (buffers 992 11)) From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 20 11:50:32 2025 Received: (at 77136) by debbugs.gnu.org; 20 Mar 2025 15:50:32 +0000 Received: from localhost ([127.0.0.1]:58555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvIAB-0005ZR-2i for submit@debbugs.gnu.org; Thu, 20 Mar 2025 11:50:31 -0400 Received: from mail-ua1-x931.google.com ([2607:f8b0:4864:20::931]:43239) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tvIA7-0005Z8-TZ for 77136@debbugs.gnu.org; Thu, 20 Mar 2025 11:50:28 -0400 Received: by mail-ua1-x931.google.com with SMTP id a1e0cc1a2514c-86dc3482b3dso2012021241.0 for <77136@debbugs.gnu.org>; Thu, 20 Mar 2025 08:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742485822; x=1743090622; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=9kZzZmeLuYrqDshBQvEmaQUav+uQd7tWnSgFbRD0VNo=; b=FpANPUJGNoDUmrcw1cVO+Hz7QY0MSz6Jzn99Zbmr+fK6ZqhZP56h1CEg1vdq9HkAW0 V+kBahNvB+qJ06utNo4WOR9Oz+TjnmC3hUsH4zoGCF6k7Tok1C4Wgh58yy/6ib3un5AN lfrb4KujKCYWVXLXh2FSNuMB2ZUSegKKvrSkryOKOaQBQzwkQZ603zIPYncV0V4ysJJl Kwf0RCBZWpXtptzAwo3h3GzD9xh+lavOF966JuXLdmCUIdNhKoc+P2I3hOP+6RM/S44t YJ0cCB+E3GBbtnf6E7kWueiDcK5W29JHyd9Prq3kzh33mPvNNnRrnzfFOB2Cd29aMpVp ZqTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742485822; x=1743090622; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9kZzZmeLuYrqDshBQvEmaQUav+uQd7tWnSgFbRD0VNo=; b=nheDmWfwoWDhFyJbWOLbZRsToVnbhcxulASPvvEFDXjfPd0kBikJ1cUCiRjddWabOv fYAGsWHaEdI66nfa9AFg7A9C19ZJApGh+jWB64HCNwE88kWgCo3rFvRH9EYf62lquNpQ Wi1+r2oU33GJvybbYnD+j7YDJLApn/kIwcN5h63FiUdhSMXiOGRLj9ig296TCvO0wd21 iZf3/pgmEuHHR2LFBxCd+w2PEmxLc6CERSWo5pa9ERZCxrprxWm+99QzyX0FZtnXqwd9 eHZaUpffSo+IgaQ2Grkx2eC8EjNDHLkU5Q1MDb7D6vlLL2WloWD3WrXwfHPd/EdHwJad bMdA== X-Gm-Message-State: AOJu0Yyvdhln9PhhAfTx4u2pnfvhSJTr2lmAquy8T8OunQ6OePENFxQG 91STS+CDyf8MI8Y9MpPazrfur1mxFLnpWnyYZ6ibWeWYgWKFLisQVlHL+IKTR1WSW7SDqzIiaP3 ME7Szl6gKMg6tkshrcYd0HukkV/E= X-Gm-Gg: ASbGnctp6kpp2WkrJEGsD0oQBrHDu7eze/NWqQIfX6NC93ec/yqefjXnURytqJWQPnq Vi3ILLSvicRlANBBx/YvyAu3qMDmS/E+D+TmdyhFzleEmwjx6MgpLcYBmkI4NiiQun11ReSIT0S TvyC/VqybASpxPueKK9YLfPKb6mw== X-Google-Smtp-Source: AGHT+IGYloCUTjyxsMht/Js5S+bQXb2LjxFlO6Ekoj4WXViSuuo55IZAcP6y0E1g/0hk/3zNCw96PDnMicpDKFk3kMI= X-Received: by 2002:a05:6102:dcd:b0:4c1:492a:d75b with SMTP id ada2fe7eead31-4c4fbf6cce2mr3771158137.2.1742485822034; Thu, 20 Mar 2025 08:50:22 -0700 (PDT) MIME-Version: 1.0 References: <87a59foghh.fsf@gmail.com> In-Reply-To: <87a59foghh.fsf@gmail.com> From: Ship Mints Date: Thu, 20 Mar 2025 11:50:10 -0400 X-Gm-Features: AQ5f1Jod1CO3-uUBlcb0zJAdj5CQeuio-tATbskHehX89c4rUNEjy5VKppcpENo Message-ID: Subject: =?UTF-8?Q?Re=3A_bug=2377136=3A_31=2E0=2E50=3B_package=2Eel=3A_Built=2Din_package?= =?UTF-8?Q?s_marked_as_upgradable_when_versions_=E2=89=A4_bundled_version?= To: davidimagid@gmail.com Content-Type: multipart/alternative; boundary="00000000000072db910630c818e9" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77136 Cc: Philip Kaludercic , 77136@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000072db910630c818e9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 20, 2025 at 11:46=E2=80=AFAM wrote: > Dear Emacs maintainers, > > I've encountered an issue in `package.el` where built-in packages are > marked as upgradable even when the repository version is <=3D the built-i= n > version. This occurs because the version comparison logic prioritizes > repository versions over built-in ones. > > ### Steps to reproduce: > 1. Set package-archive-priorities to '(("gnu" . 5) ("nongnu" . 4)). > 2. Set package-install-upgrade-built-in to t. > 3. Run `M-x list-packages` and observe the package status. > > ### Current behavior: > Built-in packages are marked as upgradable even when the repository > version is <=3D the built-in version. > > ### Expected behavior: > Built-in packages should only be marked as upgradable if the repository > version is newer. > > In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version > 3.24.43, cairo version 1.18.2) of 2025-03-16 built on fedora > Repository revision: eab14d68b2e72b9a6b8b0cc67c9667c2bfbed4f5 > Repository branch: master > System Description: Fedora Linux 41 (Workstation Edition) > > Configured using: > 'configure --with-imagemagick --with-pgtk --with-tree-sitter > --with-mailutils --with-sound=3Dyes --with-pdumper=3Dyes > --with-dumping=3Dpdumper --with-file-notification=3Dyes --with-gnutls' > > Configured features: > ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ > IMAGEMAGICK JPEG LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES > NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 > THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB > > Important settings: > value of $LANG: en_US.UTF-8 > value of $XMODIFIERS: @im=3Dibus > locale-coding-system: utf-8-unix > > Major mode: Lisp Interaction > > Minor modes in effect: > tooltip-mode: t > global-eldoc-mode: t > eldoc-mode: t > show-paren-mode: t > electric-indent-mode: t > mouse-wheel-mode: t > tool-bar-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > blink-cursor-mode: t > minibuffer-regexp-mode: t > line-number-mode: t > indent-tabs-mode: t > transient-mark-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > > Load-path shadows: > None found. > > Features: > (shadow sort mail-extr compile comint ansi-osc ansi-color ring comp-run > bytecomp byte-compile comp-common rx emacsbug lisp-mnt message mailcap > yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache > epa derived epg rfc6068 epg-config gnus-util text-property-search > time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 > mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 > rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip > cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type > elisp-mode mwheel term/pgtk-win pgtk-win term/common-win touch-screen > pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list > replace newcomment text-mode lisp-mode prog-mode register page tab-bar > menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse > jit-lock font-lock syntax font-core term/tty-colors frame minibuffer > nadvice seq simple cl-generic indonesian philippine cham georgian > utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean > japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european > ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop > case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure > cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp > files window text-properties overlay sha1 md5 base64 format env > code-pages mule custom widget keymap hashtable-print-readable backquote > threads dbusbind inotify dynamic-setting system-font-setting > font-render-setting cairo gtk pgtk multi-tty move-toolbar > make-network-process tty-child-frames native-compile emacs) > > Memory information: > ((conses 16 66717 12779) (symbols 48 6838 0) (strings 32 17183 2502) > (string-bytes 1 531430) (vectors 16 10577) > (vector-slots 8 148392 3429) (floats 8 22 13) (intervals 56 249 0) > (buffers 992 11)) > David, See the discussion here https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D765= 67 -Stephane --00000000000072db910630c818e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= On Thu, Mar 20, 2025 at 11:46=E2=80=AFAM <davidimagid@gmail.com> wrote:
Dear Emacs maintainers,

I've encountered an issue in `package.el` where built-in packages are marked as upgradable even when the repository version is <=3D the built-= in
version.=C2=A0 This occurs because the version comparison logic prioritizes=
repository versions over built-in ones.

### Steps to reproduce:
1. Set package-archive-priorities to '(("gnu" . 5) ("non= gnu" . 4)).
2. Set package-install-upgrade-built-in to t.
3. Run `M-x list-packages` and observe the package status.

### Current behavior:
Built-in packages are marked as upgradable even when the repository
version is <=3D the built-in version.

### Expected behavior:
Built-in packages should only be marked as upgradable if the repository
version is newer.

In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version
=C2=A03.24.43, cairo version 1.18.2) of 2025-03-16 built on fedora
Repository revision: eab14d68b2e72b9a6b8b0cc67c9667c2bfbed4f5
Repository branch: master
System Description: Fedora Linux 41 (Workstation Edition)

Configured using:
=C2=A0'configure --with-imagemagick --with-pgtk --with-tree-sitter
=C2=A0--with-mailutils --with-sound=3Dyes --with-pdumper=3Dyes
=C2=A0--with-dumping=3Dpdumper --with-file-notification=3Dyes --with-gnutls= '

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
IMAGEMAGICK JPEG LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES
NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB

Important settings:
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 value of $XMODIFIERS: @im=3Dibus
=C2=A0 locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
=C2=A0 tooltip-mode: t
=C2=A0 global-eldoc-mode: t
=C2=A0 eldoc-mode: t
=C2=A0 show-paren-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-mode: t
=C2=A0 blink-cursor-mode: t
=C2=A0 minibuffer-regexp-mode: t
=C2=A0 line-number-mode: t
=C2=A0 indent-tabs-mode: t
=C2=A0 transient-mark-mode: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-encryption-mode: t
=C2=A0 auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr compile comint ansi-osc ansi-color ring comp-run
bytecomp byte-compile comp-common rx emacsbug lisp-mnt message mailcap
yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache
epa derived epg rfc6068 epg-config gnus-util text-property-search
time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip
cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type
elisp-mode mwheel term/pgtk-win pgtk-win term/common-win touch-screen
pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list
replace newcomment text-mode lisp-mode prog-mode register page tab-bar
menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse
jit-lock font-lock syntax font-core term/tty-colors frame minibuffer
nadvice seq simple cl-generic indonesian philippine cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify dynamic-setting system-font-setting
font-render-setting cairo gtk pgtk multi-tty move-toolbar
make-network-process tty-child-frames native-compile emacs)

Memory information:
((conses 16 66717 12779) (symbols 48 6838 0) (strings 32 17183 2502)
=C2=A0(string-bytes 1 531430) (vectors 16 10577)
=C2=A0(vector-slots 8 148392 3429) (floats 8 22 13) (intervals 56 249 0) =C2=A0(buffers 992 11))

David,

See the discussion here https://debbugs.gnu.org/c= gi/bugreport.cgi?bug=3D76567

-Stephane
--00000000000072db910630c818e9-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 20 12:02:13 2025 Received: (at 77136) by debbugs.gnu.org; 20 Mar 2025 16:02:14 +0000 Received: from localhost ([127.0.0.1]:58585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvILU-00068j-An for submit@debbugs.gnu.org; Thu, 20 Mar 2025 12:02:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54770) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tvILR-00068I-KI; Thu, 20 Mar 2025 12:02:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvILH-0003NZ-PS; Thu, 20 Mar 2025 12:02:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=fm4tMMojJ3NjjReNoEnD7jArR0eTEojMnman4fX9WBc=; b=mVi55PFf+ir6D04Motv+ /7HE4P0m/YNHHSdLb6Nat6FAmBmspHRtCoTclRd4kD2wgbEkWK98xn/iyTeZlzqFvSRzY+G0WYgOU PXGj4ZoLup64eI5e5lXBPRDx156TCZQ05lS/og9/ZK41r2XU5NAStGf4/OTEIgbabZxYSDPzh4GKw mPsCa/LOq6/b26qXSlUUKG+e7/2DfDzJWSU6g2EwMkIj61SSoDDPfR88zwmJ0esgeY0105Wq/CzCN NgJl7poTkV3FEJ9R1DgWws5txyUKYdhgxM4XLS2IlFtGVzledQWNjGZ+DNeW9X6EiKVoPgp8yJnds Z0Pm00p9DH6Z+w==; Date: Thu, 20 Mar 2025 18:01:18 +0200 Message-Id: <86h63nn12p.fsf@gnu.org> From: Eli Zaretskii To: Ship Mints In-Reply-To: (message from Ship Mints on Thu, 20 Mar 2025 11:50:10 -0400) Subject: Re: bug#77136: 31.0.50; package.el: Built-in packages marked as upgradable when versions =?utf-8?Q?=E2=89=A4?= bundled version References: <87a59foghh.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77136 Cc: davidimagid@gmail.com, philipk@posteo.net, 77136@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 77136 76567 thanks > From: Ship Mints > Date: Thu, 20 Mar 2025 11:50:10 -0400 > Cc: 77136@debbugs.gnu.org, Philip Kaludercic , > Stefan Monnier , Eli Zaretskii , > Stefan Kangas > > David, > > See the discussion here https://debbugs.gnu.org/cgi/bugreport.cgi?bug=76567 Merging these two bugs. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 20 12:08:10 2025 Received: (at 77136) by debbugs.gnu.org; 20 Mar 2025 16:08:10 +0000 Received: from localhost ([127.0.0.1]:58604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvIRD-0006ST-63 for submit@debbugs.gnu.org; Thu, 20 Mar 2025 12:08:10 -0400 Received: from mout01.posteo.de ([185.67.36.65]:36729) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tvIR7-0006Rq-OV for 77136@debbugs.gnu.org; Thu, 20 Mar 2025 12:08:05 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D94FE240027 for <77136@debbugs.gnu.org>; Thu, 20 Mar 2025 17:07:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1742486875; bh=meXUvXu//XCub/LADqz1jitQl0u6ME+vrb/TeSSLXVY=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=EBjiOff0xsYUVOuBtVre3+wO7/o4qXfmSWHv6k4N0EjFZbrJG+zczM2l9TsPEzuRn jGsadn0HJM/LGUjXEojTrcRj4bF19kGJnCEKDjdPvqJc83zQ3FXY07Ealw9qNpSL/B VIK4RSjp5auX+pVyKy9g8b5E4WZgqcoWQRGOUPoakvWKWoRypmyE+41Q3f89btzHJL yaYgbdme6tOI7Y9q1/1pcgoWjKk170bNFEIMA3cXUcOYut4xAA7t+BDQ8/UWrWwpNT AsHpxZ5YWafKCD1x8IKOaZThzbehAvh51Kdb0qm4khLlUIXh2A+2FjO9McjlJz2WNB 9wQHtZrck2v5w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4ZJVpx6wkJz9rxL; Thu, 20 Mar 2025 17:07:53 +0100 (CET) From: Philip Kaludercic To: Ship Mints Subject: Re: bug#77136: 31.0.50; package.el: Built-in packages marked as upgradable when versions =?utf-8?Q?=E2=89=A4?= bundled version In-Reply-To: References: <87a59foghh.fsf@gmail.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Thu, 20 Mar 2025 16:07:52 +0000 Message-ID: <87cyebfzxj.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 77136 Cc: davidimagid@gmail.com, Eli Zaretskii , 77136@debbugs.gnu.org, Stefan Monnier , Stefan Kangas X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ship Mints writes: > On Thu, Mar 20, 2025 at 11:46=E2=80=AFAM wrote: > >> Dear Emacs maintainers, >> >> I've encountered an issue in `package.el` where built-in packages are >> marked as upgradable even when the repository version is <=3D the built-= in >> version. This occurs because the version comparison logic prioritizes >> repository versions over built-in ones. >> >> ### Steps to reproduce: >> 1. Set package-archive-priorities to '(("gnu" . 5) ("nongnu" . 4)). >> 2. Set package-install-upgrade-built-in to t. >> 3. Run `M-x list-packages` and observe the package status. >> >> ### Current behavior: >> Built-in packages are marked as upgradable even when the repository >> version is <=3D the built-in version. >> >> ### Expected behavior: >> Built-in packages should only be marked as upgradable if the repository >> version is newer. >> >> In GNU Emacs 31.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version >> 3.24.43, cairo version 1.18.2) of 2025-03-16 built on fedora >> Repository revision: eab14d68b2e72b9a6b8b0cc67c9667c2bfbed4f5 >> Repository branch: master >> System Description: Fedora Linux 41 (Workstation Edition) >> >> Configured using: >> 'configure --with-imagemagick --with-pgtk --with-tree-sitter >> --with-mailutils --with-sound=3Dyes --with-pdumper=3Dyes >> --with-dumping=3Dpdumper --with-file-notification=3Dyes --with-gnutls' >> >> Configured features: >> ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ >> IMAGEMAGICK JPEG LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES >> NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 >> THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB >> >> Important settings: >> value of $LANG: en_US.UTF-8 >> value of $XMODIFIERS: @im=3Dibus >> locale-coding-system: utf-8-unix >> >> Major mode: Lisp Interaction >> >> Minor modes in effect: >> tooltip-mode: t >> global-eldoc-mode: t >> eldoc-mode: t >> show-paren-mode: t >> electric-indent-mode: t >> mouse-wheel-mode: t >> tool-bar-mode: t >> menu-bar-mode: t >> file-name-shadow-mode: t >> global-font-lock-mode: t >> font-lock-mode: t >> blink-cursor-mode: t >> minibuffer-regexp-mode: t >> line-number-mode: t >> indent-tabs-mode: t >> transient-mark-mode: t >> auto-composition-mode: t >> auto-encryption-mode: t >> auto-compression-mode: t >> >> Load-path shadows: >> None found. >> >> Features: >> (shadow sort mail-extr compile comint ansi-osc ansi-color ring comp-run >> bytecomp byte-compile comp-common rx emacsbug lisp-mnt message mailcap >> yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache >> epa derived epg rfc6068 epg-config gnus-util text-property-search >> time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 >> mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 >> rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip >> cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type >> elisp-mode mwheel term/pgtk-win pgtk-win term/common-win touch-screen >> pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list >> replace newcomment text-mode lisp-mode prog-mode register page tab-bar >> menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse >> jit-lock font-lock syntax font-core term/tty-colors frame minibuffer >> nadvice seq simple cl-generic indonesian philippine cham georgian >> utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean >> japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european >> ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop >> case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure >> cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp >> files window text-properties overlay sha1 md5 base64 format env >> code-pages mule custom widget keymap hashtable-print-readable backquote >> threads dbusbind inotify dynamic-setting system-font-setting >> font-render-setting cairo gtk pgtk multi-tty move-toolbar >> make-network-process tty-child-frames native-compile emacs) >> >> Memory information: >> ((conses 16 66717 12779) (symbols 48 6838 0) (strings 32 17183 2502) >> (string-bytes 1 531430) (vectors 16 10577) >> (vector-slots 8 148392 3429) (floats 8 22 13) (intervals 56 249 0) >> (buffers 992 11)) >> > > David, > > See the discussion here https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D7= 6567 > > -Stephane Adding to the previous discussion, I feel that adding `package-install-upgrade-built-in' was a mistake and the confusion is visible in reports like these. My ongoing suggestion to replace `package-install-upgrade-built-in' is to use `package-pinned-packages' and upgrade built-in packages if they are pinned to "gnu" in the user option. But I know that this was and is a controversial topic, so we shouldn't deprecate anything without putting in the necessary thought. From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 20 12:56:08 2025 Received: (at 77136) by debbugs.gnu.org; 20 Mar 2025 16:56:08 +0000 Received: from localhost ([127.0.0.1]:58693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tvJBf-0003Qc-8q for submit@debbugs.gnu.org; Thu, 20 Mar 2025 12:56:08 -0400 Received: from mail-ua1-x92d.google.com ([2607:f8b0:4864:20::92d]:46451) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1tvJBW-0003Pm-2U; Thu, 20 Mar 2025 12:55:59 -0400 Received: by mail-ua1-x92d.google.com with SMTP id a1e0cc1a2514c-867129fdb0aso871079241.1; Thu, 20 Mar 2025 09:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1742489752; x=1743094552; darn=debbugs.gnu.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4JkEJji33hAvcpJeYj+XoZ7PlOsnJS0BKzyiJmQXQus=; b=R/hDfoRHQOOwruX/Op1ZLqYt8S5PF63LrDzRGJT4rpeHScgmP2s7/e0mWVp/vq3wx1 TrEhfVHKPE0LKLfgspO70qHqWi+Z+lCCGZs0fkzUx5BiXOJjsXZ7pLavWNURQbcUY5Lv uUx6krd8x/0lp/V2zgvjCVRX9Mfv5LQO4PpwO3LwJWvFF3MrCElcJc5Mk+dhJWB3o5vE 0Xt3q3aSUtD8+9QCtMgWFmAlwMl72KYoZhZKZxAyNVAhbZAsXTNf4oVZtjsssJHLUW+k zImPkuK6Kz+ybWYwFrDKRqOc4RiVpoxs+cqFu0bLBLoTsgEfHBi3STILXiU+4sMnDPtP fYAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742489752; x=1743094552; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4JkEJji33hAvcpJeYj+XoZ7PlOsnJS0BKzyiJmQXQus=; b=VzWX0+HoqK2ClNCD1dWcLzTrZbvFA3zjiZkO1YhA/qD7I8Um2ladpxPL0XepV4zstx 54ykvkZERunBzMZpWU3pfBAS2v2BEWA8hovFSQ0/H9YRVwA8ByyFsQYvqrgbnUOa4o+5 7TJo7e3Qm9LhiOM9fZVHoc5oVMHSjYI5XcLh5Ck5jwDwyaxoJ+4ypPAzcLdxGa3i5hGr q/kRZjZzfmXCARbFKeCOLZKnLc2b979uwWsIvPkLwhzYjkyIvKQTkE94VNln9/KsgcqG WybyW4yG9sUa7lfesD9jOmyw4W+cnC46LTmWw0C+ypgwlQmwlNHmOc9ljijsbfVd4cbz jzYg== X-Forwarded-Encrypted: i=1; AJvYcCUn/5nuiRbKR61Ziy9hFW+jJ3TH3XR1M6ZQBJ/UyHqYAUY5t+zNk3IT6OsrQdoillwF3ZKxSg==@debbugs.gnu.org X-Gm-Message-State: AOJu0YxSu8h7FDUfcDrMJ30HcfZT2/DewkcodMspFHpIwvW0CxV3mUtB 5t/TxJ0SULDWBSXLJvhv2cKVom3IcImYoqbrnQhJbYk5Khzi1Js7 X-Gm-Gg: ASbGnctTXm/Tgh1MTgtnlmVu63a5l+LDmyiL8dyTFoy8bkJZ7t0MLsBH6EAOhYanQ3l fEt5TF1FFIp5UEiBEstjE9nsJxcBT5BvWJ5/HdlNKigBM4H0CuwTuI4Pn290GgZBNL3S62VY9mg vwN/XCT70iMdk5P1CkLue+J774H7nJ/IsPNzYkcSFdnJKf08LsL8i/42cNiKwKmI+EqKvsqUnjD EfqelXBI+ZkXisFRS9AgXczYH5iTqjqQtODbuCFdkFZkmKVxvuIS+OXZSbUg87WvAM2yhkpkVxU NRhfYjALWLT9+jDkNi8mWElTI3d0jqiOrfFmAA== X-Google-Smtp-Source: AGHT+IEmaRs7hY/zADUyFTNTMnK1WqBuNetotzGHMs9VJfpzYYZrUzsdKaaXZnWKe4+qM9Z9Lp9yuA== X-Received: by 2002:a05:6102:c8c:b0:4ba:99b5:60f5 with SMTP id ada2fe7eead31-4c4ec84caf3mr7162301137.23.1742489751812; Thu, 20 Mar 2025 09:55:51 -0700 (PDT) Received: from fedora ([190.6.17.138]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-4c50b985b6dsm53652137.0.2025.03.20.09.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Mar 2025 09:55:50 -0700 (PDT) From: david To: Eli Zaretskii Subject: [PATCH] bug#77136 and bug#76567: package.el: Add package--newer-with-priority-p for built-in upgrades In-Reply-To: <86h63nn12p.fsf@gnu.org> References: <87a59foghh.fsf@gmail.com> <86h63nn12p.fsf@gnu.org> User-Agent: mu4e 1.12.8; emacs 31.0.50 Date: Thu, 20 Mar 2025 12:55:42 -0400 Message-ID: <87zfhfy73l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 77136 Cc: philipk@posteo.net, 77136@debbugs.gnu.org, stefankangas@gmail.com, 76567@debbugs.gnu.org, Ship Mints , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello Emacs maintainers, This patch improves built-in package upgrade checks by adding package--newer-with-priority-p. Combines version and priority checks: 1. New numeric version > built-in 2. Priority version > built-in (when enabled) Replaces direct comparisons in package-menu--find-upgrades. Uses package-desc-status instead of array indexes. Happy to adjust as needed for inclusion in master. Best regards, David D. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-package.el-Add-package-newer-with-priority-p-for-bui.patch Content-Description: package.el: Add package--newer-with-priority-p for built-in upgrades >From 78c9c9a49a1240926934e0f731458b4ca93b0c78 Mon Sep 17 00:00:00 2001 From: dimagid Date: Tue, 18 Mar 2025 13:02:40 -0400 Subject: [PATCH] package.el: Add package--newer-with-priority-p for built-in upgrades Detect newer available packages than built-in versions using both version and archive priority checks. The new function: 1. Marks built-ins as upgradable only if: a) Available version > built-in version numerically, AND b) Available priority version > built-in version (when enabled) 2. Replaces direct version comparisons with centralized logic * lisp/emacs-lisp/package.el (package--newer-with-priority-p): New function combining numeric version check and priority validation for built-ins. (package-menu--find-upgrades): Use new comparison. Query status via package-desc-status instead of array indexes. --- lisp/emacs-lisp/package.el | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index b9a8dacab15..9652da189c7 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -3844,6 +3844,16 @@ package-desc-priority-version (cons (package-desc-priority pkg-desc) (package-desc-version pkg-desc))) +(defun package--newer-with-priority-p (old new) + "Return non-nil if NEW is newer than OLD, considering priority. +Both OLD and NEW are `package-desc' objects. +Priority is only considered if NEW is newer than OLD." + (let ((old-version (package-desc-version old))) + (and (version-list-< old-version (package-desc-version new)) + (or (not (package--active-built-in-p old)) + (version-list-< old-version + (package-desc-priority-version new)))))) + (defun package-menu--find-upgrades () "In Package Menu, return an alist of packages that can be upgraded. The alist has the same form as `package-alist', namely a list @@ -3853,19 +3863,21 @@ package-menu--find-upgrades ;; Build list of installed/available packages in this buffer. (dolist (entry tabulated-list-entries) ;; ENTRY is (PKG-DESC [NAME VERSION STATUS DOC]) - (let ((pkg-desc (car entry)) - (status (aref (cadr entry) 2))) - (cond ((member status '("installed" "dependency" "unsigned" "external" "built-in")) + (let ((pkg-desc (car entry))) + (cond ((member + (package-desc-status pkg-desc) + '("installed" "dependency" "unsigned" "external" "built-in")) (push pkg-desc installed)) - ((member status '("available" "new")) - (setq available (package--append-to-alist pkg-desc available)))))) + ((member (package-desc-status pkg-desc) + '("available" "new")) + (setq available + (package--append-to-alist pkg-desc available)))))) ;; Loop through list of installed packages, finding upgrades. (dolist (pkg-desc installed) (let* ((name (package-desc-name pkg-desc)) (avail-pkg (cadr (assq name available)))) (and avail-pkg - (version-list-< (package-desc-priority-version pkg-desc) - (package-desc-priority-version avail-pkg)) + (package--newer-with-priority-p pkg-desc avail-pkg) (or (not (package--active-built-in-p pkg-desc)) package-install-upgrade-built-in) (push (cons name avail-pkg) upgrades)))) -- 2.48.1 --=-=-=--