GNU bug report logs - #77125
[PATCH] igc ; * etc/DEBUG: Fix gdb examples to: call ... (global_igc->arena)

Previous Next

Full log

Message #22 received at 77125-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jeremy Bryant <jb <at> jeremybryant.net>
Cc: gerd.moellmann <at> gmail.com, 77125-done <at> debbugs.gnu.org, pipcet <at> protonmail.com,
 eller.helmut <at> gmail.com
Subject: Re: bug#77125: [PATCH] igc ; * etc/DEBUG: Fix gdb examples to: call
 ... (global_igc->arena)
Date: Mon, 07 Apr 2025 14:18:45 +0300

> From: Jeremy Bryant <jb <at> jeremybryant.net>
> Cc: 77125 <at> debbugs.gnu.org,  pipcet <at> protonmail.com, Helmut Eller
>  <eller.helmut <at> gmail.com>, Gerd Möllmann
>  <gerd.moellmann <at> gmail.com>
> Date: Sun, 06 Apr 2025 21:26:01 +0100
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> From: Jeremy Bryant <jb <at> jeremybryant.net>
> >>  and then release it afterwards with:
> >>  
> >> -     (gdb) call mps_arena_release(arena)
> >> +     (gdb) call mps_arena_release(global_igc->arena)
> >
> > Is it really true that the arena pointer is always global_igc->arena
> > in Emacs?  If so, I would suggest to tell that separately, because the
> > GDB calls to functions can have arguments constructed in many
> > different ways.  Something like
> >
> >   In Emacs, the arena is usually stored in 'global_igc->arena'.
> >
> > and leave the examples in their current general form.
> 
> OK, on that basis please find attached patch adding that line, with 'usually'.

Thanks, installed on the branch.

Please in the future remember to mention the bug number (when known)
in the commit log message, and also end single-line log messages with
a period.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.