GNU bug report logs - #77122
[PATCH] project--find-in-directory resolves symlinks

Previous Next

Full log

Message #74 received at 77122 <at> debbugs.gnu.org (full text, mbox):

From: Ship Mints <shipmints <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 77122 <at> debbugs.gnu.org, dmitry <at> gutov.dev, dancol <at> dancol.org
Subject: Re: bug#77122: [PATCH] project--find-in-directory resolves symlinks
Date: Tue, 25 Mar 2025 08:27:45 -0400

[Message part 1 (text/plain, inline)]

On Tue, Mar 25, 2025 at 8:15 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Ship Mints <shipmints <at> gmail.com>
> > Date: Mon, 24 Mar 2025 16:15:14 -0400
> > Cc: dancol <at> dancol.org, 77122 <at> debbugs.gnu.org, dmitry <at> gutov.dev
> >
> >  As this discussion shows, it might well be a "misrepresentation" in
> >  some cases.
> >
> > Maybe unexpected but not a misrepresentation.
> >
> > In any case, the project object returned must be equivalent for both
> directories passed in and that's not how
> > project.el is structured.  Using file-equal-p or any other method to
> find an "equivalent" project object but
> > substitute the "expected" directory results in two objects that don't
> compare as equal and that's a
> > misrepresentation IMO.
>
> Thus my suggestion to make those objects 'equal', even if they aren't
> 'eq'.
>

I hear you, 100%.  But I don't see a place to perform that comparison given
the current implementation.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.