Subject: lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords

From: Jari Aalto <[email-masked]>
Date: Wed, 22 Dec 2010 21:01:36 +0200

Package: emacs
Version: 23.2+1-5.1
Severity: minor

lisp/textmodes/conf-mode.el uses macro expansion backtick (`) in here:

    (defvar conf-font-lock-keywords
=>    `(;; [section] (do this first because it may look like a parameter)
        ("^[ \t]*\\[\\(.+\\)\\]" 1 'font-lock-type-face)
        ;; var=val or var[index]=val
        ("^[ \t]*\\(.+?\\)\\(?:\\[\\(.*?\\)\\]\\)?[ \t]*="
         (1 'font-lock-variable-name-face)
         (2 'font-lock-constant-face nil t))
        ;; section { ... } (do this last because some assign ...{...)
        ("^[ \t]*\\([^=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend))
      "Keywords to hilight in Conf mode.")

Everywhere else it uses single quote:

    (defvar conf-javaprop-font-lock-keywords
=>    '(;; var=val
        ("^[ \t]*\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(\\..+?\\)?\\)?\\)?\\)?\\)?\\)?\\([:= \t]\\|$\\)"
         (1 'font-lock-variable-name-face)
         (2 'font-lock-constant-face nil t)
         (3 'font-lock-variable-name-face nil t)
         (4 'font-lock-constant-face nil t)
         (5 'font-lock-variable-name-face nil t)
         (6 'font-lock-constant-face nil t)
         (7 'font-lock-variable-name-face nil t)))
      "Keywords to hilight in Conf Java Properties mode.")
    ...

Perhaps the conf-font-lock-keywords should also use single quote?

-- System Information
Debian Release: squeeze/sid
  APT Prefers testing
  APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8

-- Versions of packages `emacs depends on'.
Depends:
emacs23         23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-lucid   23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-nox     23.2+1-5.1      GNU Emacs is the extensible self-documenting