GNU bug report logs - #7712
lisp/textmodes/conf-mode.el - Unused macro expansion in conf-font-lock-keywords

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 7712 in the body.
You can then email your comments to 7712 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: submit <at> debbugs.gnu.org
Subject: lisp/textmodes/conf-mode.el - Unused macro expansion in
	conf-font-lock-keywords
Date: Wed, 22 Dec 2010 21:01:36 +0200

Package: emacs
Version: 23.2+1-5.1
Severity: minor

lisp/textmodes/conf-mode.el uses macro expansion backtick (`) in here:

    (defvar conf-font-lock-keywords
=>    `(;; [section] (do this first because it may look like a parameter)
        ("^[ \t]*\\[\\(.+\\)\\]" 1 'font-lock-type-face)
        ;; var=val or var[index]=val
        ("^[ \t]*\\(.+?\\)\\(?:\\[\\(.*?\\)\\]\\)?[ \t]*="
         (1 'font-lock-variable-name-face)
         (2 'font-lock-constant-face nil t))
        ;; section { ... } (do this last because some assign ...{...)
        ("^[ \t]*\\([^=:\n]+?\\)[ \t\n]*{[^{}]*?$" 1 'font-lock-type-face prepend))
      "Keywords to hilight in Conf mode.")

Everywhere else it uses single quote:

    (defvar conf-javaprop-font-lock-keywords
=>    '(;; var=val
        ("^[ \t]*\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(?:\\.\\(.+?\\)\\(?:\\.\\([0-9]+\\)\\(\\..+?\\)?\\)?\\)?\\)?\\)?\\)?\\([:= \t]\\|$\\)"
         (1 'font-lock-variable-name-face)
         (2 'font-lock-constant-face nil t)
         (3 'font-lock-variable-name-face nil t)
         (4 'font-lock-constant-face nil t)
         (5 'font-lock-variable-name-face nil t)
         (6 'font-lock-constant-face nil t)
         (7 'font-lock-variable-name-face nil t)))
      "Keywords to hilight in Conf Java Properties mode.")
    ...

Perhaps the conf-font-lock-keywords should also use single quote?

-- System Information
Debian Release: squeeze/sid
  APT Prefers testing
  APT policy: (990, testing) (500, unstable) (1, experimental)
Architecture: amd64
Kernel: Linux picasso 2.6.32-5-amd64 #1 SMP Fri Sep 17 21:50:19 UTC 2010 x86_64 GNU/Linux
Locale: LANG=en_DK.UTF-8

-- Versions of packages `emacs depends on'.
Depends:
emacs23         23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-lucid   23.2+1-5.1      GNU Emacs is the extensible self-documenting 
emacs23-nox     23.2+1-5.1      GNU Emacs is the extensible self-documenting 

Message #8 received at 7712 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: 7712 <at> debbugs.gnu.org
Subject: Re: bug#7712: lisp/textmodes/conf-mode.el - Unused macro expansion in
	conf-font-lock-keywords
Date: Wed, 29 Dec 2010 19:02:46 +0800

Jari Aalto <jari.aalto <at> cante.net> writes:

> lisp/textmodes/conf-mode.el uses macro expansion backtick (`) in here:
> Perhaps the conf-font-lock-keywords should also use single quote?

Sure.  Committed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.